Re: [PATCH v2 2/2] powerpc/perf: Add generic compat mode pmu driver

2019-04-29 Thread Madhavan Srinivasan
On 29/04/19 11:12 AM, Christophe Leroy wrote: Le 29/04/2019 à 04:52, Madhavan Srinivasan a écrit : Most of the power processor generation performance monitoring unit (PMU) driver code is bundled in the kernel and one of those is enabled/registered based on the oprofile_cpu_type check at the

Re: [PATCH v2 1/2] powerpc/perf: init pmu from core-book3s

2019-04-29 Thread Madhavan Srinivasan
On 29/04/19 11:08 AM, Christophe Leroy wrote: Le 29/04/2019 à 04:52, Madhavan Srinivasan a écrit : Currenty pmu driver file for each ppc64 generation processor has a __init call in itself. Refactor the code by moving the __init call to core-books.c. This also clean's up compat mode pmu drive

Re: [PATCH kernel v3] powerpc/powernv: Isolate NVLinks between GV100GL on Witherspoon

2019-04-29 Thread Alexey Kardashevskiy
On 30/04/2019 15:45, Alistair Popple wrote: > Alexey, > > +void pnv_try_isolate_nvidia_v100(struct pci_dev *bridge) > +{ > + u32 mask, val; > + void __iomem *bar0_0, *bar0_12, *bar0_a0; > + struct pci_dev *pdev; > + u16 cmd = 0, cmdmask = PCI_COMMAND_MEMORY;

Re: [PATCH v5 5/8] powerpc/pci/IOV: Add support for runtime enabling the VFs

2019-04-29 Thread Oliver O'Halloran
On Mon, 2019-03-11 at 14:52 +0300, Sergey Miroshnichenko wrote: > When called within pcibios_sriov_enable(), the pci_sriov_get_totalvfs(pdev) > returns zero, because the device is yet preparing to enable the VFs. I don't think this is correct. The earliest pcibios_sriov_enable() can be called is

Re: [PATCH 6/8] powerpc/eeh: Initialize EEH address cache earlier

2019-04-29 Thread Sam Bobroff
On Thu, Apr 18, 2019 at 08:13:53PM +1000, Oliver O'Halloran wrote: > On Wed, 2019-03-20 at 13:58 +1100, Sam Bobroff wrote: > > The EEH address cache is currently initialized and populated by a > > single function: eeh_addr_cache_build(). While the initial population > > of the cache can only be do

powernv/subpage_prot: kernel NULL pointer dereference running kernel self tests (subpage_prot)

2019-04-29 Thread Sachin Sant
While running kselftests (subpage_prot) ran into following OOPS. This is against linuxppc merge branch. Does not happen against mainline. Same problem is seen with latest linux-next tree as well. Following recent commits have modified the code in question. ef629cc5bf0543eb57d6e344ba776880ac35fd0

Re: [PATCH kernel v3] powerpc/powernv: Isolate NVLinks between GV100GL on Witherspoon

2019-04-29 Thread Alistair Popple
Alexey, > >>> +void pnv_try_isolate_nvidia_v100(struct pci_dev *bridge) > >>> +{ > >>> + u32 mask, val; > >>> + void __iomem *bar0_0, *bar0_12, *bar0_a0; > >>> + struct pci_dev *pdev; > >>> + u16 cmd = 0, cmdmask = PCI_COMMAND_MEMORY; > >>> + > >>> + if (!bridge->subordinate) > >>> +

Re: [PATCH 5/8] powerpc/eeh: Add eeh_show_enabled()

2019-04-29 Thread Sam Bobroff
On Thu, Apr 18, 2019 at 08:01:36PM +1000, Oliver O'Halloran wrote: > On Wed, 2019-03-20 at 13:58 +1100, Sam Bobroff wrote: > > Move the EEH enabled message into it's own function so that future > > work can call it from multiple places. > > > > Signed-off-by: Sam Bobroff > > --- > > arch/powerpc

Re: [PATCH 3/8] powerpc/eeh: Convert PNV_PHB_FLAG_EEH to global flag

2019-04-29 Thread Sam Bobroff
On Thu, Apr 18, 2019 at 07:51:40PM +1000, Oliver O'Halloran wrote: > On Wed, 2019-03-20 at 13:58 +1100, Sam Bobroff wrote: > > The PHB flag, PNV_PHB_FLAG_EEH, is set (on PowerNV) individually on > > each PHB once the EEH subsystem is ready. It is the only use of the > > flags member of the phb stru

Re: [PATCH V32 01/27] Add the ability to lock down access to the running kernel image

2019-04-29 Thread Andrew Donnellan
On 29/4/19 2:54 pm, Daniel Axtens wrote: Hi, I'm thinking about whether we should lock down the powerpc xmon debug monitor - intuitively, I think the answer is yes if for no other reason than Least Astonishment, when lockdown is enabled you probably don't expect xmon to keep letting you access

Re: [PATCH v5 2/8] powerpc/powernv/pci: Suppress an EEH error when reading an empty slot

2019-04-29 Thread Oliver
On Mon, Mar 11, 2019 at 10:52 PM Sergey Miroshnichenko wrote: > > Reading an empty slot returns all ones, which triggers a false > EEH error event on PowerNV. This patch unfreezes the bus where > it has happened. > > Signed-off-by: Sergey Miroshnichenko > --- > arch/powerpc/include/asm/ppc-pci.h

Re: [PATCH v4 2/7] ocxl: Don't pass pci_dev around

2019-04-29 Thread Andrew Donnellan
On 27/3/19 4:31 pm, Alastair D'Silva wrote: From: Alastair D'Silva This data is already available in a struct Signed-off-by: Alastair D'Silva Acked-by: Andrew Donnellan --- drivers/misc/ocxl/core.c | 38 +- 1 file changed, 21 insertions(+), 17 delet

Re: [PATCH v5 1/8] powerpc/pci: Access PCI config space directly w/o pci_dn

2019-04-29 Thread Oliver
On Mon, Mar 11, 2019 at 10:52 PM Sergey Miroshnichenko wrote: > > To fetch an updated DT for the newly hotplugged device, OS must explicitly > request it from the firmware via the pnv_php driver. > > If pnv_php wasn't triggered/loaded, it is still possible to discover new > devices if PCIe I/O wil

Re: [PATCH v4 1/7] ocxl: Split pci.c

2019-04-29 Thread Andrew Donnellan
On 27/3/19 4:31 pm, Alastair D'Silva wrote: From: Alastair D'Silva In preparation for making core code available for external drivers, move the core code out of pci.c and into core.c Signed-off-by: Alastair D'Silva There doesn't seem to be much left in pci.c, is there? Acked-by: Andrew Don

RE: Machine Check Exceptions

2019-04-29 Thread Rodriguez Quesada, Pablo
Hi Christophe, I will try with the NMI approach. Just one question: >The driver I wrote that you are referring to is to handle the watchdog in e300 >powerpc core. This is because the e300 gererates a machine check on expiry >>when the watchdog is configured in NMI mode. By NMI mode do you mea

Re: [PATCH v2 0/5] Allow CPU0 to be nohz full

2019-04-29 Thread Nicholas Piggin
Peter Zijlstra's on April 25, 2019 10:04 pm: > On Thu, Apr 11, 2019 at 01:34:43PM +1000, Nicholas Piggin wrote: >> Since last time, I added a compile time option to opt-out of this >> if the platform does not support suspend on non-zero, and tried to >> improve legibility of changelogs and explain

[PATCH] powerpc: Fix kobject memleak

2019-04-29 Thread Tobin C. Harding
Currently error return from kobject_init_and_add() is not followed by a call to kobject_put(). This means there is a memory leak. Add call to kobject_put() in error path of kobject_init_and_add(). Signed-off-by: Tobin C. Harding --- Untested, did not even build. Bad Tobin, no biscuit. No cal

Re: [PATCH 13/41] drivers: tty: serial: uartlite: fill mapsize and use it

2019-04-29 Thread Enrico Weigelt, metux IT consult
On 29.04.19 17:19, Peter Korsgaard wrote: >> "Enrico" == Enrico Weigelt, metux IT consult writes: > > > Fill the struct uart_port->mapsize field and use it, insteaf of > > s/insteaf/instead/ Fixed. > > hardcoded values in many places. This makes the code layout a bit > > more consistent

[PATCH v3 3/3] powernv/mce: print additional information about mce error.

2019-04-29 Thread Mahesh Salgaonkar
Print more information about mce error whether it is an hardware or software error. Some of the mce errors can be easily categorized as hardware or software errors e.g. UEs are due to hardware error, where as error triggered due to invalid usage of tlbie is a pure software bug. But not all the mce

[PATCH v3 2/3] powernv/mce: Print correct severity for mce error.

2019-04-29 Thread Mahesh Salgaonkar
Currently all machine check errors are printed as severe errors which isn't correct. Print soft errors as warning instead of severe errors. Signed-off-by: Mahesh Salgaonkar --- change in v2: - Use kernel types i.e. u8, u64 etc. - Define sync_error as bool. --- arch/powerpc/include/asm/mce.h

[PATCH v3 1/3] powernv/mce: reduce mce console logs to lesser lines.

2019-04-29 Thread Mahesh Salgaonkar
Also add cpu number while displaying mce log. This will help cleaner logs when mce hits on multiple cpus simultaneously. before the changes the mce o/p was: [ 127.223515] Severe Machine check interrupt [Recovered] [ 127.223530] NIP [dba80280]: insert_slb_entry.constprop.0+0x278/0x2c0

Re: [PATCH 12/10] powerpc: unbreak DYNAMIC_DEBUG=y build with clang

2019-04-29 Thread Nick Desaulniers
On Fri, Apr 26, 2019 at 12:06 PM Rasmus Villemoes wrote: > > Current versions of clang does not like the %c modifier in inline > assembly for targets other than x86, so any DYNAMIC_DEBUG=y build > fails on ppc64. A fix is likely to land in 9.0 (see > https://github.com/ClangBuiltLinux/linux/issues

[PATCH v2 3/3] mm: introduce ARCH_HAS_PTE_DEVMAP

2019-04-29 Thread Robin Murphy
ARCH_HAS_ZONE_DEVICE is somewhat meaningless in itself, and combined with the long-out-of-date comment can lead to the impression than an architecture may just enable it (since __add_pages() now "comprehends device memory" for itself) and expect things to work. In practice, however, ZONE_DEVICE us

Re: serial drivers polishing

2019-04-29 Thread Enrico Weigelt, metux IT consult
On 29.04.19 18:16, Christophe Leroy wrote: Hi, > Got the following build  error while compiling for my powerpc board with > your full series applied. No time to investigate though. thanks, fixed it. That was the unclean patch where i've forgotten to add 'rfc' into the title ... turned out that t

Re: [PATCH 22/41] drivers: tty: serial: cpm_uart: fix logging calls

2019-04-29 Thread Enrico Weigelt, metux IT consult
On 29.04.19 17:59, Christophe Leroy wrote: > If we want to do something useful, wouldn't it make more sense to > introduce the use of dev_err() in order to identify the faulting device > in the message ? Well, I could get the struct device* pointer via pinfo.port->dev, but I wasn't entirely sure

Re: serial drivers polishing

2019-04-29 Thread Christophe Leroy
Hi, On 04/27/2019 12:51 PM, Enrico Weigelt, metux IT consult wrote: Hello folks, here's another attempt of polishing the serial drivers: * lots of minor cleanups to make checkpatch happier (eg. formatting, includes, inttypes, ...) * use appropriate logging helpers instead of printk() * c

Re: [PATCH 21/41] drivers: tty: serial: cpm_uart: fix includes

2019-04-29 Thread Christophe Leroy
Le 27/04/2019 à 14:52, Enrico Weigelt, metux IT consult a écrit : Fixing checkpatch warning: WARNING: Use #include instead of #25: FILE: drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c:25: +#include WARNING: Use #include instead of +#include WARNING: Use #inc

Re: [PATCH 20/41] drivers: tty: serial: cpm_uart: use dev_err()/dev_warn() instead of printk()

2019-04-29 Thread Christophe Leroy
Le 27/04/2019 à 14:52, Enrico Weigelt, metux IT consult a écrit : Using dev_err()/dev_warn() instead of printk() for more consistent output. (prints device name, etc). Signed-off-by: Enrico Weigelt Reviewed-by: Christophe Leroy --- drivers/tty/serial/cpm_uart/cpm_uart_core.c | 6 +++--

Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation

2019-04-29 Thread Enrico Weigelt, metux IT consult
On 27.04.19 15:03, John Paul Adrian Glaubitz wrote: > On 4/27/19 2:52 PM, Enrico Weigelt, metux IT consult wrote: >> Simpily io resource size computation by setting mapsize field. > > Here's a typo thx. fixed. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded

Re: [PATCH 22/41] drivers: tty: serial: cpm_uart: fix logging calls

2019-04-29 Thread Christophe Leroy
Le 27/04/2019 à 14:52, Enrico Weigelt, metux IT consult a écrit : Fix checkpatch warnings by using pr_err(): WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... #109: FILE: drivers/tty/serial/cpm_uart/cpm_uart

[PATCH stable v4.4 6/8] powerpc/fsl: Fixed warning: orphan section `__btb_flush_fixup'

2019-04-29 Thread Diana Craciun
commit 039daac5526932ec731e4499613018d263af8b3e upstream. Fixed the following build warning: powerpc-linux-gnu-ld: warning: orphan section `__btb_flush_fixup' from `arch/powerpc/kernel/head_44x.o' being placed in section `__btb_flush_fixup'. Signed-off-by: Diana Craciun Signed-off-by: Michael El

[PATCH stable v4.4 3/8] powerpc/fsl: Emulate SPRN_BUCSR register

2019-04-29 Thread Diana Craciun
commit 98518c4d8728656db349f875fcbbc7c126d4c973 upstream. In order to flush the branch predictor the guest kernel performs writes to the BUCSR register which is hypervisor privilleged. However, the branch predictor is flushed at each KVM entry, so the branch predictor has been already flushed, so

[PATCH stable v4.4 2/8] powerpc/fsl: Flush branch predictor when entering KVM

2019-04-29 Thread Diana Craciun
commit e7aa61f47b23afbec41031bc47ca8d6cb6516abc upstream. Switching from the guest to host is another place where the speculative accesses can be exploited. Flush the branch predictor when entering KVM. Signed-off-by: Diana Craciun Signed-off-by: Michael Ellerman --- arch/powerpc/kvm/bookehv_i

[PATCH stable v4.4 5/8] powerpc/fsl: Sanitize the syscall table for NXP PowerPC 32 bit platforms

2019-04-29 Thread Diana Craciun
commit c28218d4abbf4f2035495334d8bfcba64bda4787 upstream. Used barrier_nospec to sanitize the syscall table. Signed-off-by: Diana Craciun Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/entry_32.S | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/powerpc/kernel/entry

[PATCH stable v4.4 8/8] Documentation: Add nospectre_v1 parameter

2019-04-29 Thread Diana Craciun
Currently only supported on powerpc. Signed-off-by: Diana Craciun Signed-off-by: Michael Ellerman --- Documentation/kernel-parameters.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index f0bdf78420a0..3ff87d

Re: [PATCH 23/41] drivers: tty: serial: cpm_uart: fix styling issues

2019-04-29 Thread Christophe Leroy
Le 27/04/2019 à 14:52, Enrico Weigelt, metux IT consult a écrit : Fix checkpatch errors: What the main purpose of this change ? If we apply this, any fix to stable will be a nightmare to backport. Is it really worth it ? Anyway, a couple of comments in the patch below [...] Signed-o

[PATCH stable v4.4 4/8] powerpc/fsl: Flush the branch predictor at each kernel entry (32 bit)

2019-04-29 Thread Diana Craciun
commit 7fef436295bf6c05effe682c8797dfcb0deb112a upstream. In order to protect against speculation attacks on indirect branches, the branch predictor is flushed at kernel entry to protect for the following situations: - userspace process attacking another userspace process - userspace process attac

[PATCH stable v4.4 7/8] powerpc/fsl: Add FSL_PPC_BOOK3E as supported arch for nospectre_v2 boot arg

2019-04-29 Thread Diana Craciun
commit f633a8ad636efb5d4bba1a047d4a0f1ef719aa06 upstream. Signed-off-by: Diana Craciun Signed-off-by: Michael Ellerman --- Documentation/kernel-parameters.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-paramete

[PATCH stable v4.4 1/8] powerpc/fsl: Enable runtime patching if nospectre_v2 boot arg is used

2019-04-29 Thread Diana Craciun
commit 3bc8ea8603ae4c1e09aca8de229ad38b8091fcb3 upstream. If the user choses not to use the mitigations, replace the code sequence with nops. Signed-off-by: Diana Craciun Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/setup_32.c | 1 + arch/powerpc/kernel/setup_64.c | 1 + 2 files cha

[PATCH stable v4.4 0/8] missing powerpc spectre backports for 4.4

2019-04-29 Thread Diana Craciun
Hi Greg, These are missing patches from the initial powerpc spectre backports for 4.4. Please queue them as well if you don't have any objections. Thanks, Diana Craciun (8): powerpc/fsl: Enable runtime patching if nospectre_v2 boot arg is used powerpc/fsl: Flush branch predictor when enterin

Re: [PATCH stable v4.4 00/52] powerpc spectre backports for 4.4

2019-04-29 Thread Diana Madalina Craciun
On 4/28/2019 9:19 AM, Michael Ellerman wrote: > Diana Madalina Craciun writes: >> Hi Michael, >> >> There are some missing NXP Spectre v2 patches. I can send them >> separately if the series will be accepted. I have merged them, but I did >> not test them, I was sick today and incapable of doing t

Re: [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct

2019-04-29 Thread Andy Shevchenko
On Mon, Apr 29, 2019 at 04:55:05PM +0200, Enrico Weigelt, metux IT consult wrote: > On 28.04.19 17:18, Andy Shevchenko wrote: > > On Sat, Apr 27, 2019 at 02:52:17PM +0200, Enrico Weigelt, metux IT consult > > wrote: > >> - int ret = 0; > > > > This and Co is a separate change that can be done

Re: [RESEND PATCH v3 09/11] powerpc/mm/radix: mark __radix__flush_tlb_range_psize() as __always_inline

2019-04-29 Thread Christophe Leroy
Le 23/04/2019 à 05:49, Masahiro Yamada a écrit : This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common place. We need to eliminate potential issues beforehand. How did you identify the functions requiring __always_inline as this one ? Just by 'test and see if it fails', or did

[PATCH for 5.2 10/12] rseq/selftests: powerpc code signature: generate valid instructions

2019-04-29 Thread Mathieu Desnoyers
Use "twui" as the guard instruction for the restartable sequence abort handler. Signed-off-by: Mathieu Desnoyers CC: Benjamin Herrenschmidt CC: Paul Mackerras CC: Michael Ellerman CC: Boqun Feng CC: Peter Zijlstra CC: "Paul E. McKenney" CC: Alan Modra CC: linuxppc-dev@lists.ozlabs.org ---

Re: [PATCH 12/41] drivers: tty: serial: uartlite: use dev_dbg() instead of pr_debug()

2019-04-29 Thread Peter Korsgaard
> "Enrico" == Enrico Weigelt, metux IT consult writes: > Using dev_dbg() instead of pr_debg() for more consistent output. > (prints device name, etc). > Signed-off-by: Enrico Weigelt Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [PATCH 16/41] drivers: tty: serial: uartlite: fix overlong lines

2019-04-29 Thread Peter Korsgaard
> "Enrico" == Enrico Weigelt, metux IT consult writes: > Fix checkpatch warnings: > WARNING: line over 80 characters > #283: FILE: drivers/tty/serial/uartlite.c:283: > +ret = request_irq(port->irq, ulite_isr, IRQF_SHARED | > IRQF_TRIGGER_RISING, > WARNING: Miss

Re: [PATCH 15/41] drivers: tty: serial: uartlite: fix use fix bare 'unsigned'

2019-04-29 Thread Peter Korsgaard
> "Enrico" == Enrico Weigelt, metux IT consult writes: > Fix checkpatch warnings: > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > #562: FILE: drivers/tty/serial/uartlite.c:562: > +unsigned retries = 100; > WARNING: Prefer 'unsigned int' to bare u

Re: [PATCH 14/41] drivers: tty: serial: uartlite: remove unnecessary braces

2019-04-29 Thread Peter Korsgaard
> "Enrico" == Enrico Weigelt, metux IT consult writes: > checkpatch complains: > WARNING: braces {} are not necessary for any arm of this statement > #489: FILE: drivers/tty/serial/uartlite.c:489: > +if (oops_in_progress) { > [...] > +} else > [.

Re: [PATCH 13/41] drivers: tty: serial: uartlite: fill mapsize and use it

2019-04-29 Thread Peter Korsgaard
> "Enrico" == Enrico Weigelt, metux IT consult writes: > Fill the struct uart_port->mapsize field and use it, insteaf of s/insteaf/instead/ > hardcoded values in many places. This makes the code layout a bit > more consistent and easily allows using generic helpers for the > io memory h

Re: [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct

2019-04-29 Thread Enrico Weigelt, metux IT consult
On 28.04.19 17:18, Andy Shevchenko wrote: > On Sat, Apr 27, 2019 at 02:52:17PM +0200, Enrico Weigelt, metux IT consult > wrote: >> The io resource size is currently recomputed when it's needed but this >> actually needs to be done once (or drivers could specify fixed values) > > io -> IO fixed.

Re: [PATCH 01/41] drivers: tty: serial: dz: use dev_err() instead of printk()

2019-04-29 Thread Greg KH
On Mon, Apr 29, 2019 at 04:11:15PM +0200, Enrico Weigelt, metux IT consult wrote: > On 27.04.19 15:29, Greg KH wrote: > > On Sat, Apr 27, 2019 at 02:51:42PM +0200, Enrico Weigelt, metux IT consult > > wrote: > >> Using dev_err() instead of printk() for more consistent output. > >> (prints device

Re: [PATCH 01/41] drivers: tty: serial: dz: use dev_err() instead of printk()

2019-04-29 Thread Enrico Weigelt, metux IT consult
On 27.04.19 15:29, Greg KH wrote: > On Sat, Apr 27, 2019 at 02:51:42PM +0200, Enrico Weigelt, metux IT consult > wrote: >> Using dev_err() instead of printk() for more consistent output. >> (prints device name, etc). >> >> Signed-off-by: Enrico Weigelt > > Your "From:" line does not match the si

Re: [PATCH 40/41] drivers: tty: serial: helper for setting mmio range

2019-04-29 Thread Andy Shevchenko
On Mon, Apr 29, 2019 at 12:12:35PM +0200, Enrico Weigelt, metux IT consult wrote: > On 28.04.19 17:39, Andy Shevchenko wrote: > seems I've forgot to add "RFC:" in the subject - I'm not entirely happy > w/ that patch myself, just want to hear your oppinions. > > Moreover, the size argument seems

Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation

2019-04-29 Thread Andy Shevchenko
On Mon, Apr 29, 2019 at 08:48:53AM +0200, Enrico Weigelt, metux IT consult wrote: > On 28.04.19 17:21, Andy Shevchenko wrote: > >> +#define SERIAL_RT2880_IOSIZE 0x100 > > > > And why this is in the header file and not in corresponding C one? > > hmm, no particular reason, maybe just an old

Re: [PATCH 01/41] drivers: tty: serial: dz: use dev_err() instead of printk()

2019-04-29 Thread Greg KH
On Mon, Apr 29, 2019 at 02:37:04PM +0200, Enrico Weigelt, metux IT consult wrote: > On 27.04.19 15:31, Greg KH wrote: > > On Sat, Apr 27, 2019 at 02:51:42PM +0200, Enrico Weigelt, metux IT consult > > wrote: > >> Using dev_err() instead of printk() for more consistent output. > >> (prints device

Re: [PATCH 01/41] drivers: tty: serial: dz: use dev_err() instead of printk()

2019-04-29 Thread Enrico Weigelt, metux IT consult
On 27.04.19 15:31, Greg KH wrote: > On Sat, Apr 27, 2019 at 02:51:42PM +0200, Enrico Weigelt, metux IT consult > wrote: >> Using dev_err() instead of printk() for more consistent output. >> (prints device name, etc). >> >> Signed-off-by: Enrico Weigelt >> --- >> drivers/tty/serial/dz.c | 8 -

Re: [PATCH] powerpc: remove the __kernel_io_end export

2019-04-29 Thread Christoph Hellwig
On Mon, Apr 29, 2019 at 06:57:06AM -0500, Segher Boessenkool wrote: > On Mon, Apr 29, 2019 at 06:52:41AM -0500, Christoph Hellwig wrote: > > This export was added in this merge window, but without any actual > > user, or justification for a modular user. > > Hi Christoph, > > > -unsigned long __k

Re: [PATCH] powerpc/32s: fix BATs setting with CONFIG_STRICT_KERNEL_RWX

2019-04-29 Thread Segher Boessenkool
Acked-by: Segher Boessenkool (But see comments below.) On Mon, Apr 29, 2019 at 09:08:09AM +, Christophe Leroy wrote: > diff --git a/arch/powerpc/mm/ppc_mmu_32.c b/arch/powerpc/mm/ppc_mmu_32.c > index bf1de3ca39bc..37cf2af98f6a 100644 > --- a/arch/powerpc/mm/ppc_mmu_32.c > +++ b/arch/powerpc/

Re: [PATCH stable v4.4 00/52] powerpc spectre backports for 4.4

2019-04-29 Thread Michael Ellerman
Greg KH writes: > On Mon, Apr 29, 2019 at 04:26:45PM +1000, Michael Ellerman wrote: >> Michael Ellerman writes: >> > Greg KH writes: >> >> On Mon, Apr 22, 2019 at 12:19:45AM +1000, Michael Ellerman wrote: >> >>> -BEGIN PGP SIGNED MESSAGE- >> >>> Hash: SHA1 >> >>> >> >>> Hi Greg/Sasha, >

Re: [PATCH 2/3] powerpc/module32: Use symbolic instructions names.

2019-04-29 Thread Segher Boessenkool
On Mon, Apr 29, 2019 at 10:43:27AM +, Christophe Leroy wrote: > To increase readability/maintainability, replace hard coded > instructions values by symbolic names. > + /* lis r12,sym@ha */ > +#define ENTRY_JMP0(sym) (PPC_INST_ADDIS | __PPC_RT(R12) | PPC_HA(sym)) > + /* addi r12,r

[PATCH] powerpc: remove the __kernel_io_end export

2019-04-29 Thread Christoph Hellwig
This export was added in this merge window, but without any actual user, or justification for a modular user. Fixes: a35a3c6f6065 ("powerpc/mm/hash64: Add a variable to track the end of IO mapping") Signed-off-by: Christoph Hellwig --- arch/powerpc/mm/pgtable_64.c | 1 - 1 file changed, 1 delet

Re: [PATCH] powerpc: remove the __kernel_io_end export

2019-04-29 Thread Segher Boessenkool
On Mon, Apr 29, 2019 at 06:52:41AM -0500, Christoph Hellwig wrote: > This export was added in this merge window, but without any actual > user, or justification for a modular user. Hi Christoph, > -unsigned long __kernel_io_end; > EXPORT_SYMBOL(__kernel_io_end); Does that work? Don't you need

[PATCH 2/3] powerpc/module32: Use symbolic instructions names.

2019-04-29 Thread Christophe Leroy
To increase readability/maintainability, replace hard coded instructions values by symbolic names. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/module_32.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/kernel/module_32.c b/arch/powe

Re: [PATCH] powerpc/powernv/npu: Fix reference leak

2019-04-29 Thread Greg Kurz
On Mon, 29 Apr 2019 16:01:29 +1000 Alexey Kardashevskiy wrote: > On 20/04/2019 01:34, Greg Kurz wrote: > > Since 902bdc57451c, get_pci_dev() calls pci_get_domain_bus_and_slot(). This > > has the effect of incrementing the reference count of the PCI device, as > > explained in drivers/pci/search.c

Patch "powerpc: Use barrier_nospec in copy_from_user()" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc: Use barrier_nospec in copy_from_user() to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: powerpc

Patch "powerpc64s: Show ori31 availability in spectre_v1 sysfs file not v2" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc64s: Show ori31 availability in spectre_v1 sysfs file not v2 to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the pa

[PATCH 3/3] powerpc/module64: Use symbolic instructions names.

2019-04-29 Thread Christophe Leroy
To increase readability/maintainability, replace hard coded instructions values by symbolic names. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/module_64.c | 54 - 1 file changed, 37 insertions(+), 17 deletions(-) diff --git a/arch/powerpc/kern

Patch "powerpc/xmon: Add RFI flush related fields to paca dump" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/xmon: Add RFI flush related fields to paca dump to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

[PATCH 1/3] powerpc: Move PPC_HA() PPC_HI() and PPC_LO() to ppc-opcode.h

2019-04-29 Thread Christophe Leroy
PPC_HA() PPC_HI() and PPC_LO() macros are nice macros. Move them from module64.c to ppc-opcode.h in order to use them in other places. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/ppc-opcode.h | 7 +++ arch/powerpc/kernel/module_64.c | 7 --- 2 files changed, 7 inse

Re: [PATCH 40/41] drivers: tty: serial: helper for setting mmio range

2019-04-29 Thread Enrico Weigelt, metux IT consult
On 28.04.19 17:39, Andy Shevchenko wrote: Hi, seems I've forgot to add "RFC:" in the subject - I'm not entirely happy w/ that patch myself, just want to hear your oppinions. >> -port->port.iotype = UPIO_MEM;>> - port->port.mapbase = >> pci_resource_start(pcidev, bar) + offset;>> + uar

Patch "powerpc/rfi-flush: Make it possible to call setup_rfi_flush() again" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/rfi-flush: Make it possible to call setup_rfi_flush() again to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the pa

Patch "powerpc/security: Fix spectre_v2 reporting" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/security: Fix spectre_v2 reporting to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: powerpc-secu

Patch "powerpc/rfi-flush: Always enable fallback flush on pseries" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/rfi-flush: Always enable fallback flush on pseries to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "powerpc/rfi-flush: Call setup_rfi_flush() after LPM migration" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/rfi-flush: Call setup_rfi_flush() after LPM migration to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is

Patch "powerpc/rfi-flush: Move the logic to avoid a redo into the debugfs code" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/rfi-flush: Move the logic to avoid a redo into the debugfs code to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of th

Patch "powerpc/rfi-flush: Differentiate enabled and patched flush types" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/rfi-flush: Differentiate enabled and patched flush types to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Patch "powerpc/pseries: Support firmware disable of RFI flush" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/pseries: Support firmware disable of RFI flush to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "powerpc/pseries: Use the security flags in pseries_setup_rfi_flush()" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/pseries: Use the security flags in pseries_setup_rfi_flush() to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the p

Patch "powerpc/pseries: Add new H_GET_CPU_CHARACTERISTICS flags" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/pseries: Add new H_GET_CPU_CHARACTERISTICS flags to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "powerpc/pseries: Fix clearing of security feature flags" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/pseries: Fix clearing of security feature flags to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "powerpc/pseries: Set or clear security feature flags" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/pseries: Set or clear security feature flags to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: po

Patch "powerpc/pseries: Restore default security feature flags on setup" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/pseries: Restore default security feature flags on setup to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Patch "powerpc/pseries: Query hypervisor for count cache flush settings" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/pseries: Query hypervisor for count cache flush settings to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Patch "powerpc/powernv: Query firmware for count cache flush settings" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/powernv: Query firmware for count cache flush settings to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch i

Patch "powerpc/fsl: Fix spectre_v2 mitigations reporting" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/fsl: Fix spectre_v2 mitigations reporting to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: power

Patch "powerpc: Move default security feature flags" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc: Move default security feature flags to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: powerpc-mo

Patch "powerpc/fsl: Update Spectre v2 reporting" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/fsl: Update Spectre v2 reporting to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: powerpc-fsl-up

Patch "powerpc/powernv: Use the security flags in pnv_setup_rfi_flush()" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/powernv: Use the security flags in pnv_setup_rfi_flush() to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Patch "powerpc/fsl: Flush the branch predictor at each kernel entry (64bit)" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/fsl: Flush the branch predictor at each kernel entry (64bit) to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the p

Patch "powerpc/powernv: Support firmware disable of RFI flush" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/powernv: Support firmware disable of RFI flush to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "powerpc/fsl: Fix the flush of branch predictor." has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/fsl: Fix the flush of branch predictor. to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: powerpc

Patch "powerpc/powernv: Set or clear security feature flags" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/powernv: Set or clear security feature flags to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: po

Patch "powerpc/64s: Patch barrier_nospec in modules" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/64s: Patch barrier_nospec in modules to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: powerpc-64

Patch "powerpc: Avoid code patching freed init sections" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc: Avoid code patching freed init sections to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: powerp

Patch "powerpc/asm: Add a patch_site macro & helpers for patching instructions" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/asm: Add a patch_site macro & helpers for patching instructions to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of th

Patch "powerpc/fsl: Add nospectre_v2 command line argument" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/fsl: Add nospectre_v2 command line argument to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: pow

Patch "powerpc/fsl: Add macro to flush the branch predictor" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/fsl: Add macro to flush the branch predictor to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: po

Patch "powerpc/fsl: Add infrastructure to fixup branch predictor flush" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/fsl: Add infrastructure to fixup branch predictor flush to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Patch "powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book3E" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book3E to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the

Patch "powerpc/64s: Wire up cpu_show_spectre_v2()" has been added to the 4.4-stable tree

2019-04-29 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/64s: Wire up cpu_show_spectre_v2() to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: powerpc-64s-

  1   2   >