Re: [PATCH v10 7/8] KVM: PPC: Implement H_SVM_INIT_ABORT hcall

2019-11-11 Thread Ram Pai
On Tue, Nov 12, 2019 at 04:38:36PM +1100, Paul Mackerras wrote: > On Mon, Nov 11, 2019 at 05:01:58PM -0800, Ram Pai wrote: > > On Mon, Nov 11, 2019 at 03:19:24PM +1100, Paul Mackerras wrote: > > > On Mon, Nov 04, 2019 at 09:47:59AM +0530, Bharata B Rao wrote: > > > > From: Sukadev Bhattiprolu > >

Re: [PATCH v4 04/47] soc: fsl: qe: introduce qe_io{read,write}* wrappers

2019-11-11 Thread Rasmus Villemoes
On 12/11/2019 06.17, Timur Tabi wrote: > On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes > wrote: >> >> The QUICC engine drivers use the powerpc-specific out_be32() etc. In >> order to allow those drivers to build for other architectures, those >> must be replaced by iowrite32be(). However, on pow

[PATCH stable 4.4] powerpc/boot: Request no dynamic linker for boot wrapper

2019-11-11 Thread Andrew Donnellan
From: Nicholas Piggin Commit ff45000fcb56b5b0f1a14a865d3541746d838a0a upstream. The boot wrapper performs its own relocations and does not require PT_INTERP segment. However currently we don't tell the linker that. Prior to binutils 2.28 that works OK. But since binutils commit 1a9ccd70f9a7 ("F

Re: [PATCH V9] mm/debug: Add tests validating architecture page table helpers

2019-11-11 Thread Anshuman Khandual
On 11/12/2019 11:59 AM, Ingo Molnar wrote: > > * Anshuman Khandual wrote: > >> +config DEBUG_VM_PGTABLE >> +bool "Debug arch page table for semantics compliance" >> +depends on MMU >> +depends on DEBUG_VM >> +depends on ARCH_HAS_DEBUG_VM_PGTABLE >> +help >> + This opt

Re: [PATCH v3 09/23] mm/gup: introduce pin_user_pages*() and FOLL_PIN

2019-11-11 Thread Mike Rapoport
On Mon, Nov 11, 2019 at 04:06:46PM -0800, John Hubbard wrote: > Introduce pin_user_pages*() variations of get_user_pages*() calls, > and also pin_longterm_pages*() variations. > > These variants all set FOLL_PIN, which is also introduced, and > thoroughly documented. > > The pin_longterm*() varia

Re: [PATCH V9] mm/debug: Add tests validating architecture page table helpers

2019-11-11 Thread Ingo Molnar
* Anshuman Khandual wrote: > +config DEBUG_VM_PGTABLE > + bool "Debug arch page table for semantics compliance" > + depends on MMU > + depends on DEBUG_VM > + depends on ARCH_HAS_DEBUG_VM_PGTABLE > + help > + This option provides a debug method which can be used to tes

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-11 Thread Sergey Senozhatsky
On (19/11/12 13:44), Sergey Senozhatsky wrote: [..] > > But yes, this per-code-section loglevel is problematic. The feedback > > against the patchset shows that people want it also the other way. > > I mean to keep pr_debug() as pr_debug(). > > Hmm. Right. > > > A solution might be to use the per

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-11 Thread Sergey Senozhatsky
On (19/11/11 10:12), Petr Mladek wrote: [..] > > I do recall that we talked about per-CPU printk state bit which would > > start/end "just print it" section. We probably can extend it to "just > > log_store" type of functionality. Doesn't look like a very bad idea. > > The problem with per-CPU pri

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-11 Thread Sergey Senozhatsky
On (19/11/12 02:40), Dmitry Safonov wrote: [..] > In my point of view the cost of one-time [mostly build] testing every > architecture is cheaper than introducing some new smart code that will > live forever. Well, there may be the need to pass loglevel deeper due to "hey __show_stack() on that ar

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-11 Thread Dmitry Safonov
Hi Sergey, On 11/12/19 2:17 AM, Sergey Senozhatsky wrote: > On (19/11/11 19:47), Dmitry Safonov wrote: [..] >> What I'm going to do - is to fix all build and reported issues, I'll >> send v2 this week and feel free to NAK it, I will forget about those >> patches and won't be offended. > > Lovely.

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-11 Thread Sergey Senozhatsky
On (19/11/11 19:47), Dmitry Safonov wrote: [..] > I don't see how bits on task_struct or in per-cpu are easier than > supplying a log level parameter down the stack. > How would it work if sysrq_handle_crash() called by key-press? > How would that interact with deferred printing? > How would it mak

net-next branch fails to build on my P8 CI system

2019-11-11 Thread Abdul Haleem
Greeting's I see a build failure for net-next branch on my Power 8 system 13:25:10 ERROR| [stderr] ./include/linux/u64_stats_sync.h: In function 64_stats_read�: 13:25:10 ERROR| [stderr] ./include/linux/u64_stats_sync.h:80:2: warning: passing argument 1 of 鈥榣ocal_read鈥� discards 鈥榗onst鈥� qualifi

Re: [PATCH 08/10] nvdimm: Add driver for OpenCAPI Storage Class Memory

2019-11-11 Thread Dan Williams
On Mon, Nov 11, 2019 at 9:37 PM Dan Williams wrote: > > On Mon, Nov 11, 2019 at 3:34 AM Aneesh Kumar K.V > wrote: > > > > "Alastair D'Silva" writes: > > > > > From: Alastair D'Silva > > > > > > This driver exposes LPC memory on OpenCAPI SCM cards > > > as an NVDIMM, allowing the existing nvram

Re: [PATCH v10 7/8] KVM: PPC: Implement H_SVM_INIT_ABORT hcall

2019-11-11 Thread Paul Mackerras
On Mon, Nov 11, 2019 at 05:01:58PM -0800, Ram Pai wrote: > On Mon, Nov 11, 2019 at 03:19:24PM +1100, Paul Mackerras wrote: > > On Mon, Nov 04, 2019 at 09:47:59AM +0530, Bharata B Rao wrote: > > > From: Sukadev Bhattiprolu > > > > > > Implement the H_SVM_INIT_ABORT hcall which the Ultravisor can u

Re: [PATCH v10 6/8] KVM: PPC: Support reset of secure guest

2019-11-11 Thread Paul Mackerras
On Mon, Nov 04, 2019 at 09:47:58AM +0530, Bharata B Rao wrote: [snip] > @@ -5442,6 +5471,64 @@ static int kvmhv_store_to_eaddr(struct kvm_vcpu *vcpu, > ulong *eaddr, void *ptr, > return rc; > } > > +/* > + * IOCTL handler to turn off secure mode of guest > + * > + * - Issue ucall to term

Re: [PATCH 08/10] nvdimm: Add driver for OpenCAPI Storage Class Memory

2019-11-11 Thread Dan Williams
On Mon, Nov 11, 2019 at 3:34 AM Aneesh Kumar K.V wrote: > > "Alastair D'Silva" writes: > > > From: Alastair D'Silva > > > > This driver exposes LPC memory on OpenCAPI SCM cards > > as an NVDIMM, allowing the existing nvram infrastructure > > to be used. > > > > Signed-off-by: Alastair D'Silva >

Re: [PATCH v4 04/47] soc: fsl: qe: introduce qe_io{read, write}* wrappers

2019-11-11 Thread Timur Tabi
On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes wrote: > > The QUICC engine drivers use the powerpc-specific out_be32() etc. In > order to allow those drivers to build for other architectures, those > must be replaced by iowrite32be(). However, on powerpc, out_be32() is > a simple inline function

[PATCH V9 RESEND] mm/debug: Add tests validating architecture page table helpers

2019-11-11 Thread Anshuman Khandual
This adds tests which will validate architecture page table helpers and other accessors in their compliance with expected generic MM semantics. This will help various architectures in validating changes to existing page table helpers or addition of new ones. This test covers basic page table entry

Re: [PATCH v2 1/4] powerpc/kvm/book3s: Fixes possible 'use after release' of kvm

2019-11-11 Thread Michael Ellerman
Hi Leonardo, Leonardo Bras writes: > Fixes a possible 'use after free' of kvm variable in > kvm_vm_ioctl_create_spapr_tce, where it does a mutex_unlock(&kvm->lock) > after a kvm_put_kvm(kvm). There is no potential for an actual use after free here AFAICS. > diff --git a/arch/powerpc/kvm/book3s_

Re: [PATCH V9] mm/debug: Add tests validating architecture page table helpers

2019-11-11 Thread Anshuman Khandual
On 11/12/2019 09:48 AM, Anshuman Khandual wrote: > This adds tests which will validate architecture page table helpers and > other accessors in their compliance with expected generic MM semantics. > This will help various architectures in validating changes to existing > page table helpers or ad

[PATCH V9] mm/debug: Add tests validating architecture page table helpers

2019-11-11 Thread Anshuman Khandual
This adds tests which will validate architecture page table helpers and other accessors in their compliance with expected generic MM semantics. This will help various architectures in validating changes to existing page table helpers or addition of new ones. This test covers basic page table entry

Re: [PATCH 2/2] powerpc/perf: Check pmus_inuse flag in perf_event_print_debug()

2019-11-11 Thread kbuild test robot
Hi Madhavan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on v5.4-rc7 next-2019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '-

Re: [PATCH 2/2] vfio/pci: Introduce OpenCAPI devices support.

2019-11-11 Thread Alexey Kardashevskiy
On 11/11/2019 15:28, Andrew Donnellan wrote: > On 11/11/19 3:17 pm, Alexey Kardashevskiy wrote: >> What driver do you expect to work with this in the guest? >> arch/powerpc/platforms/powernv/ocxl.c is a powernv-tied driver which >> calls into OPAL so it won't work on pseries. > > https://patchw

Re: [PATCH v9 0/4] powerpc: expose secure variables to the kernel and userspace

2019-11-11 Thread Michael Ellerman
Lakshmi Ramasubramanian writes: > On 11/10/19 7:10 PM, Nayna Jain wrote: > > Hi Nayna, > >> In order to verify the OS kernel on PowerNV systems, secure boot requires >> X.509 certificates trusted by the platform. These are stored in secure >> variables controlled by OPAL, called OPAL secure variab

RE: [RFC v2 1/2] powerpc/pseries/iommu: Share the per-cpu TCE page with the hypervisor.

2019-11-11 Thread Ram Pai
On Sun, Nov 10, 2019 at 07:40:06PM +, David Gibson wrote: > On Fri, Nov 08, 2019 at 03:00:10PM -0800, Ram Pai wrote: > > The hypervisor needs to access the contents of the page holding the TCE > > entries while setting up the TCE entries in the IOMMU's TCE table. > > > > For SecureVMs, since t

Re: [PATCH v10 7/8] KVM: PPC: Implement H_SVM_INIT_ABORT hcall

2019-11-11 Thread Ram Pai
On Mon, Nov 11, 2019 at 03:19:24PM +1100, Paul Mackerras wrote: > On Mon, Nov 04, 2019 at 09:47:59AM +0530, Bharata B Rao wrote: > > From: Sukadev Bhattiprolu > > > > Implement the H_SVM_INIT_ABORT hcall which the Ultravisor can use to > > abort an SVM after it has issued the H_SVM_INIT_START and

Re: [PATCH] macintosh/ams-input: switch to using input device polling mode

2019-11-11 Thread Dmitry Torokhov
On Wed, Oct 02, 2019 at 02:48:54PM -0700, Dmitry Torokhov wrote: > Now that instances of input_dev support polling mode natively, > we no longer need to create input_polled_dev instance. Michael, could you please take this? Or I could push through my tree... Thanks! > > Signed-off-by: Dmitry To

[PATCH v3 22/23] selftests/vm: run_vmtests: invoke gup_benchmark with basic FOLL_PIN coverage

2019-11-11 Thread John Hubbard
It's good to have basic unit test coverage of the new FOLL_PIN behavior. Fortunately, the gup_benchmark unit test is extremely fast (a few milliseconds), so adding it the the run_vmtests suite is going to cause no noticeable change in running time. So, add two new invocations to run_vmtests: 1) R

[PATCH v3 23/23] mm/gup: remove support for gup(FOLL_LONGTERM)

2019-11-11 Thread John Hubbard
Now that all other kernel callers of get_user_pages(FOLL_LONGTERM) have been converted to pin_longterm_pages(), lock it down: 1) Add an assertion to get_user_pages(), preventing callers from passing FOLL_LONGTERM (in addition to the existing assertion that prevents FOLL_PIN). 2) Remove the

[PATCH v3 21/23] mm/gup_benchmark: support pin_user_pages() and related calls

2019-11-11 Thread John Hubbard
Up until now, gup_benchmark supported testing of the following kernel functions: * get_user_pages(): via the '-U' command line option * get_user_pages_longterm(): via the '-L' command line option * get_user_pages_fast(): as the default (no options required) Add test coverage for the new correspon

[PATCH v3 20/23] mm/gup_benchmark: use proper FOLL_WRITE flags instead of hard-coding "1"

2019-11-11 Thread John Hubbard
Fix the gup benchmark flags to use the symbolic FOLL_WRITE, instead of a hard-coded "1" value. Also, clean up the filtering of gup flags a little, by just doing it once before issuing any of the get_user_pages*() calls. This makes it harder to overlook, instead of having little "gup_flags & 1" phr

[PATCH v3 16/23] mm/gup: track FOLL_PIN pages

2019-11-11 Thread John Hubbard
Add tracking of pages that were pinned via FOLL_PIN. As mentioned in the FOLL_PIN documentation, callers who effectively set FOLL_PIN are required to ultimately free such pages via put_user_page(). The effect is similar to FOLL_GET, and may be thought of as "FOLL_GET for DIO and/or RDMA use". Pag

[PATCH v3 18/23] vfio, mm: pin_longterm_pages (FOLL_PIN) and put_user_page() conversion

2019-11-11 Thread John Hubbard
1. Change vfio from get_user_pages(FOLL_LONGTERM), to pin_longterm_pages(), which sets both FOLL_LONGTERM and FOLL_PIN. 2. Because all FOLL_PIN-acquired pages must be released via put_user_page(), also convert the put_page() call over to put_user_pages(). Note that this effectively changes the co

[PATCH v3 19/23] powerpc: book3s64: convert to pin_longterm_pages() and put_user_page()

2019-11-11 Thread John Hubbard
1. Convert from get_user_pages(FOLL_LONGTERM) to pin_longterm_pages(). 2. As required by pin_user_pages(), release these pages via put_user_page(). In this case, do so via put_user_pages_dirty_lock(). That has the side effect of calling set_page_dirty_lock(), instead of set_page_dirty(). This is

[PATCH v3 17/23] media/v4l2-core: pin_longterm_pages (FOLL_PIN) and put_user_page() conversion

2019-11-11 Thread John Hubbard
1. Change v4l2 from get_user_pages(FOLL_LONGTERM), to pin_longterm_pages(), which sets both FOLL_LONGTERM and FOLL_PIN. 2. Because all FOLL_PIN-acquired pages must be released via put_user_page(), also convert the put_page() call over to put_user_pages_dirty_lock(). Acked-by: Hans Verkuil Review

[PATCH v3 15/23] net/xdp: set FOLL_PIN via pin_user_pages()

2019-11-11 Thread John Hubbard
Convert net/xdp to use the new pin_longterm_pages() call, which sets FOLL_PIN. Setting FOLL_PIN is now required for code that requires tracking of pinned pages. In partial anticipation of this work, the net/xdp code was already calling put_user_page() instead of put_page(). Therefore, in order to

[PATCH v3 14/23] fs/io_uring: set FOLL_PIN via pin_user_pages()

2019-11-11 Thread John Hubbard
Convert fs/io_uring to use the new pin_user_pages() call, which sets FOLL_PIN. Setting FOLL_PIN is now required for code that requires tracking of pinned pages, and therefore for any code that calls put_user_page(). In partial anticipation of this work, the io_uring code was already calling put_us

[PATCH v3 13/23] drm/via: set FOLL_PIN via pin_user_pages_fast()

2019-11-11 Thread John Hubbard
Convert drm/via to use the new pin_user_pages_fast() call, which sets FOLL_PIN. Setting FOLL_PIN is now required for code that requires tracking of pinned pages, and therefore for any code that calls put_user_page(). In partial anticipation of this work, the drm/via driver was already calling put_

[PATCH v3 12/23] mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote()

2019-11-11 Thread John Hubbard
Convert process_vm_access to use the new pin_user_pages_remote() call, which sets FOLL_PIN. Setting FOLL_PIN is now required for code that requires tracking of pinned pages. Also, release the pages via put_user_page*(). Also, rename "pages" to "pinned_pages", as this makes for easier reading of p

[PATCH v3 07/23] media/v4l2-core: set pages dirty upon releasing DMA buffers

2019-11-11 Thread John Hubbard
After DMA is complete, and the device and CPU caches are synchronized, it's still required to mark the CPU pages as dirty, if the data was coming from the device. However, this driver was just issuing a bare put_page() call, without any set_page_dirty*() call. Fix the problem, by calling set_page_

[PATCH v3 11/23] IB/{core, hw, umem}: set FOLL_PIN, FOLL_LONGTERM via pin_longterm_pages*()

2019-11-11 Thread John Hubbard
Convert infiniband to use the new wrapper calls, and stop explicitly setting FOLL_LONGTERM at the call sites. The new pin_longterm_*() calls replace get_user_pages*() calls, and set both FOLL_LONGTERM and a new FOLL_PIN flag. The FOLL_PIN flag requires that the caller must return the pages via put

[PATCH v3 09/23] mm/gup: introduce pin_user_pages*() and FOLL_PIN

2019-11-11 Thread John Hubbard
Introduce pin_user_pages*() variations of get_user_pages*() calls, and also pin_longterm_pages*() variations. These variants all set FOLL_PIN, which is also introduced, and thoroughly documented. The pin_longterm*() variants also set FOLL_LONGTERM, in addition to FOLL_PIN: pin_user_pages()

[PATCH v3 10/23] goldish_pipe: convert to pin_user_pages() and put_user_page()

2019-11-11 Thread John Hubbard
1. Call the new global pin_user_pages_fast(), from pin_goldfish_pages(). 2. As required by pin_user_pages(), release these pages via put_user_page(). In this case, do so via put_user_pages_dirty_lock(). That has the side effect of calling set_page_dirty_lock(), instead of set_page_dirty(). This i

[PATCH v3 06/23] IB/umem: use get_user_pages_fast() to pin DMA pages

2019-11-11 Thread John Hubbard
And get rid of the mmap_sem calls, as part of that. Note that get_user_pages_fast() will, if necessary, fall back to __gup_longterm_unlocked(), which takes the mmap_sem as needed. Reviewed-by: Ira Weiny Cc: Jason Gunthorpe Signed-off-by: John Hubbard --- drivers/infiniband/core/umem.c | 17 +++

[PATCH v3 08/23] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM

2019-11-11 Thread John Hubbard
As it says in the updated comment in gup.c: current FOLL_LONGTERM behavior is incompatible with FAULT_FLAG_ALLOW_RETRY because of the FS DAX check requirement on vmas. However, the corresponding restriction in get_user_pages_remote() was slightly stricter than is actually required: it forbade all

[PATCH v3 05/23] goldish_pipe: rename local pin_user_pages() routine

2019-11-11 Thread John Hubbard
1. Avoid naming conflicts: rename local static function from "pin_user_pages()" to "pin_goldfish_pages()". An upcoming patch will introduce a global pin_user_pages() function. Reviewed-by: Jérôme Glisse Reviewed-by: Ira Weiny Signed-off-by: John Hubbard --- drivers/platform/goldfish/goldfish_

[PATCH v3 04/23] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages

2019-11-11 Thread John Hubbard
An upcoming patch changes and complicates the refcounting and especially the "put page" aspects of it. In order to keep everything clean, refactor the devmap page release routines: * Rename put_devmap_managed_page() to page_is_devmap_managed(), and limit the functionality to "read only": return

[PATCH v3 00/23] mm/gup: track dma-pinned pages: FOLL_PIN, FOLL_LONGTERM

2019-11-11 Thread John Hubbard
Hi, The cover letter is long, so the more important stuff is first: * Jason, if you or someone could look at the the VFIO cleanup (patch 8) and conversion to FOLL_PIN (patch 18), to make sure it's use of remote and longterm gup matches what we discussed during the review of v2, I'd apprecia

[PATCH v3 01/23] mm/gup: pass flags arg to __gup_device_* functions

2019-11-11 Thread John Hubbard
A subsequent patch requires access to gup flags, so pass the flags argument through to the __gup_device_* functions. Also placate checkpatch.pl by shortening a nearby line. Reviewed-by: Jérôme Glisse Reviewed-by: Ira Weiny Cc: Kirill A. Shutemov Signed-off-by: John Hubbard --- mm/gup.c | 28

[PATCH v3 03/23] mm/gup: move try_get_compound_head() to top, fix minor issues

2019-11-11 Thread John Hubbard
An upcoming patch uses try_get_compound_head() more widely, so move it to the top of gup.c. Also fix a tiny spelling error and a checkpatch.pl warning. Signed-off-by: John Hubbard --- mm/gup.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/mm

[PATCH v3 02/23] mm/gup: factor out duplicate code from four routines

2019-11-11 Thread John Hubbard
There are four locations in gup.c that have a fair amount of code duplication. This means that changing one requires making the same changes in four places, not to mention reading the same code four times, and wondering if there are subtle differences. Factor out the common code into static functi

Re: [PATCH v4 00/47] QUICC Engine support on ARM and ARM64

2019-11-11 Thread Li Yang
On Fri, Nov 8, 2019 at 7:05 AM Rasmus Villemoes wrote: > I'm generally ok with these enhencements and cleanups. But as the whole patch series touched multiple subsystems, I would like to collect the Acked-by from Scott, Greg and David if we want the whole series to go through the fsl/soc tree.

Re: [PATCH v9 0/4] powerpc: expose secure variables to the kernel and userspace

2019-11-11 Thread Lakshmi Ramasubramanian
On 11/10/19 7:10 PM, Nayna Jain wrote: Hi Nayna, In order to verify the OS kernel on PowerNV systems, secure boot requires X.509 certificates trusted by the platform. These are stored in secure variables controlled by OPAL, called OPAL secure variables. In order to enable users to manage the ke

Re: [PATCH v2 04/18] media/v4l2-core: set pages dirty upon releasing DMA buffers

2019-11-11 Thread John Hubbard
On 11/10/19 2:10 AM, Hans Verkuil wrote: > On 11/3/19 10:17 PM, John Hubbard wrote: >> After DMA is complete, and the device and CPU caches are synchronized, >> it's still required to mark the CPU pages as dirty, if the data was >> coming from the device. However, this driver was just issuing a >>

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-11 Thread Dmitry Safonov
Hi Sergey, Petr, On 11/11/19 1:23 AM, Sergey Senozhatsky wrote: > On (19/11/08 14:04), Petr Mladek wrote: > [..] >> I agree that it is complicated to pass the loglevel as >> a parameter. It would be better define the default >> log level for a given code section. It might be stored >> in task_stru

Re: [PATCH v2 0/9] Fixes and Enablement of ibm,drc-info property

2019-11-11 Thread Bjorn Helgaas
On Sun, Nov 10, 2019 at 11:21:27PM -0600, Tyrel Datwyler wrote: > There was a previous effort to add support for the PAPR > architected ibm,drc-info property. This property provides a more > memory compact representation of a parition's Dynamic Reconfig > Connectors (DRC). These can otherwise be th

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-11 Thread Vineet Gupta
On 11/7/19 8:27 PM, Anshuman Khandual wrote: > > On 11/08/2019 12:35 AM, Vineet Gupta wrote: >> On 11/6/19 8:44 PM, Anshuman Khandual wrote: > */ > -#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +#ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE > #include > #endif This in wrong.  C

Re: [PATCH v4 47/47] soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE

2019-11-11 Thread Li Yang
On Mon, Nov 11, 2019 at 1:36 AM Rasmus Villemoes wrote: > > On 09/11/2019 00.48, Li Yang wrote: > > On Fri, Nov 8, 2019 at 7:05 AM Rasmus Villemoes > > wrote: > >> > >> There are also ARM and ARM64 based SOCs with a QUICC Engine, and the > >> core QE code as well as net/wan/fsl_ucc_hdlc and tty/s

Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA

2019-11-11 Thread Geert Uytterhoeven
will hit these two linker > scripts? vmlinux-sun3.lds: sun3_defconfig vmlinux-std.lds: All other classic 680x0 targets with an MMU, e.g. plain defconfig aka multi_defconfig. > > Leading to build failures in next-2019: > > > > > > /opt/

Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA

2019-11-11 Thread Kees Cook
-sun3.lds: RODATA Argh. I've sent a patch; sorry and thanks for catching this. For my own cross-build testing, which defconfig targets will hit these two linker scripts? -Kees > > Leading to build failures in next-2019: > > > /opt/cross/kisskb/gcc-4.6.3-noli

Re: [PATCH v2 00/10] Improvements for random.h/archrandom.h

2019-11-11 Thread Borislav Petkov
On Wed, Nov 06, 2019 at 03:12:58PM +0100, Richard Henderson wrote: > During patch review for an addition of archrandom.h for arm64, it was > suggeted that the arch_random_get_* functions should be marked __must_check. > Which does sound like a good idea, since the by-reference integer output > may

Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA

2019-11-11 Thread Geert Uytterhoeven
7 insertions(+), 9 deletions(-) Somehow you missed: arch/m68k/kernel/vmlinux-std.lds: RODATA arch/m68k/kernel/vmlinux-sun3.lds: RODATA Leading to build failures in next-2019: /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-ld:./arch/m68k/kernel/vmlinux.lds:29

Re: [PATCH v15 0/9] open: introduce openat2(2) syscall

2019-11-11 Thread Aleksa Sarai
On 2019-11-05, Aleksa Sarai wrote: > This patchset is being developed here: > > > Patch changelog: > v15: > * Fix code style for LOOKUP_IN_ROOT handling in path_init(). [Linus > Torvalds] > * Split out patches for each individual LOOKU

Re: [alsa-devel] [PATCH] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-11 Thread Daniel Baluta
On Thu, Nov 7, 2019 at 8:54 AM S.j. Wang wrote: > > Hi > > > > Hi Shengjiu, > > > > Comments inline. > > > > On Wed, Nov 6, 2019 at 9:30 AM Shengjiu Wang > > wrote: > > > > > > Audmix support two substream, When two substream start to run, the > > > trigger function may be called by two substream

Re: [alsa-devel] [PATCH V2] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-11 Thread Daniel Baluta
On Mon, Nov 11, 2019 at 9:53 AM Shengjiu Wang wrote: > > Audmix support two substream, When two substream start > to run, the trigger function may be called by two substream > in same time, that the priv->tdms may be updated wrongly. > > The expected priv->tdms is 0x3, but sometimes the > result i

Re: [PATCH 12/23] y2038: syscalls: change remaining timeval to __kernel_old_timeval

2019-11-11 Thread Christian Brauner
On Fri, Nov 08, 2019 at 10:12:11PM +0100, Arnd Bergmann wrote: > All of the remaining syscalls that pass a timeval (gettimeofday, utime, > futimesat) can trivially be changed to pass a __kernel_old_timeval > instead, which has a compatible layout, but avoids ambiguity with > the timeval type in use

Re: Bug 205201 - overflow of DMA mask and bus mask

2019-11-11 Thread Christian Zigotzky
On 11 November 2019 at 09:16 am, Christian Zigotzky wrote: On 11 November 2019 at 09:12 am, Christian Zigotzky wrote: On 10 November 2019 at 08:27 am, Christian Zigotzky wrote: On 07 November 2019 at 10:53 am, Christian Zigotzky wrote: On 05 November 2019 at 05:28 pm, Christoph Hellwig wrote:

[Bug 205201] Booting halts if Dawicontrol DC-2976 UW SCSI board installed, unless RAM size limited to 3500M

2019-11-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205201 --- Comment #13 from Christian Zigotzky (chzigot...@xenosoft.de) --- Christoph, Now, I can definitely say that this patch does not solve the issue. Do you have another patch for testing or shall I bisect? Thanks, Christian -- You are receivin

[PATCH v4 0/3] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs)

2019-11-11 Thread Bhupesh Sharma
Changes since v3: - v3 can be seen here: http://lists.infradead.org/pipermail/kexec/2019-March/022590.html - Addressed comments from James and exported TCR_EL1.T1SZ in vmcoreinfo instead of PTRS_PER_PGD. - Added a new patch (via [PATCH 3/3]), which fixes a simple typo in 'Doc

Re: [PATCH] KVM: PPC: Book3S HV: XIVE: Free previous EQ page when setting up a new one

2019-11-11 Thread Cédric Le Goater
On 11/11/2019 10:49, Greg Kurz wrote: > The EQ page is allocated by the guest and then passed to the hypervisor > with the H_INT_SET_QUEUE_CONFIG hcall. A reference is taken on the page > before handing it over to the HW. This reference is dropped either when > the guest issues the H_INT_RESET hcal

Re: [PATCH 08/10] nvdimm: Add driver for OpenCAPI Storage Class Memory

2019-11-11 Thread Aneesh Kumar K.V
"Alastair D'Silva" writes: > From: Alastair D'Silva > > This driver exposes LPC memory on OpenCAPI SCM cards > as an NVDIMM, allowing the existing nvram infrastructure > to be used. > > Signed-off-by: Alastair D'Silva > --- > drivers/nvdimm/Kconfig | 17 + > drivers/nvdimm/Makefi

Re: [PATCH 1/3] powerpc/mm: Initialize the HPTE encoding values

2019-11-11 Thread Aneesh Kumar K.V
Laurent Dufour writes: > Before reading the HPTE encoding values we initialize all of them to -1 (an > invalid value) to later being able to detect the initialized ones. > > Signed-off-by: Laurent Dufour We already do this in mmu_psize_set_default_penc() ? > --- > arch/powerpc/mm/book3s64/has

Re: [PATCH 09/10] powerpc: Enable OpenCAPI Storage Class Memory driver on bare metal

2019-11-11 Thread Aneesh Kumar K.V
"Alastair D'Silva" writes: > From: Alastair D'Silva > > Enable OpenCAPI Storage Class Memory driver on bare metal But that doesn't explain why these need to be builtin. > > Signed-off-by: Alastair D'Silva > --- > arch/powerpc/configs/powernv_defconfig | 4 > 1 file changed, 4 insertions(

Re: [PATCH 04/10] powerpc: Map & release OpenCAPI LPC memory

2019-11-11 Thread Aneesh Kumar K.V
"Alastair D'Silva" writes: > From: Alastair D'Silva > > This patch adds platform support to map & release LPC memory. > > Signed-off-by: Alastair D'Silva > --- > arch/powerpc/include/asm/pnv-ocxl.h | 2 ++ > arch/powerpc/platforms/powernv/ocxl.c | 41 +++ > include/l

[PATCH v4 1/3] crash_core, vmcoreinfo: Append 'MAX_PHYSMEM_BITS' to vmcoreinfo

2019-11-11 Thread Bhupesh Sharma
Right now user-space tools like 'makedumpfile' and 'crash' need to rely on a best-guess method of determining value of 'MAX_PHYSMEM_BITS' supported by underlying kernel. This value is used in user-space code to calculate the bit-space required to store a section for SPARESMEM (similar to the exist

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-11 Thread Petr Mladek
On Mon 2019-11-11 10:23:36, Sergey Senozhatsky wrote: > On (19/11/08 14:04), Petr Mladek wrote: > [..] > > I agree that it is complicated to pass the loglevel as > > a parameter. It would be better define the default > > log level for a given code section. It might be stored > > in task_struct for

[PATCH] KVM: PPC: Book3S HV: XIVE: Free previous EQ page when setting up a new one

2019-11-11 Thread Greg Kurz
The EQ page is allocated by the guest and then passed to the hypervisor with the H_INT_SET_QUEUE_CONFIG hcall. A reference is taken on the page before handing it over to the HW. This reference is dropped either when the guest issues the H_INT_RESET hcall or when the KVM device is released. But, the

[PATCH V3 2/2] ASoC: fsl_asrc: Add support for imx8qm

2019-11-11 Thread Shengjiu Wang
There are two asrc module in imx8qm, each module has different clock configuration, and the DMA type is EDMA. So in this patch, we define the new clocks, refine the clock map, and include struct fsl_asrc_soc_data for different soc usage. The EDMA channel is fixed with each dma request, one dma re

[PATCH V3 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm

2019-11-11 Thread Shengjiu Wang
Add compatible string "fsl,imx8qm-asrc" for imx8qm platform. There are two asrc modules in imx8qm, the clock mapping is different for each other, so add new property "fsl,asrc-clk-map" to distinguish them. Signed-off-by: Shengjiu Wang --- changes in v2 -none changes in v3 -use only one compatib

Re: [alsa-devel] [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm

2019-11-11 Thread S.j. Wang
Hi Rob, Nicolin > > Hi Rob > > > > On Wed, Oct 30, 2019 at 07:41:26PM +0800, Shengjiu Wang wrote: > > > In order to support the two asrc modules in imx8qm, we need to add > > > compatible string "fsl,imx8qm-asrc0" and "fsl,imx8qm-asrc1" > > > > Are the blocks different in some way? > > > > If not

Re: Bug 205201 - overflow of DMA mask and bus mask

2019-11-11 Thread Christian Zigotzky
On 11 November 2019 at 09:12 am, Christian Zigotzky wrote: On 10 November 2019 at 08:27 am, Christian Zigotzky wrote: On 07 November 2019 at 10:53 am, Christian Zigotzky wrote: On 05 November 2019 at 05:28 pm, Christoph Hellwig wrote: On Tue, Nov 05, 2019 at 08:56:27AM +0100, Christian Zigotzk

Re: Bug 205201 - overflow of DMA mask and bus mask

2019-11-11 Thread Christian Zigotzky
On 10 November 2019 at 08:27 am, Christian Zigotzky wrote: On 07 November 2019 at 10:53 am, Christian Zigotzky wrote: On 05 November 2019 at 05:28 pm, Christoph Hellwig wrote: On Tue, Nov 05, 2019 at 08:56:27AM +0100, Christian Zigotzky wrote: Hi All, We still have DMA problems with some PCI