Re: [PATCH v3 00/27] Add support for OpenCAPI Persistent Memory devices

2020-02-23 Thread Oliver O'Halloran
On Mon, Feb 24, 2020 at 3:43 PM Alastair D'Silva wrote: > > On Sun, 2020-02-23 at 20:37 -0800, Matthew Wilcox wrote: > > On Mon, Feb 24, 2020 at 03:34:07PM +1100, Alastair D'Silva wrote: > > > V3: > > > - Rebase against next/next-20200220 > > > - Move driver to arch/powerpc/platforms/powernv,

Re: [PATCH v3 08/27] ocxl: Emit a log message showing how much LPC memory was detected

2020-02-23 Thread Andrew Donnellan
On 24/2/20 5:10 pm, Alastair D'Silva wrote: Printing this at info level for every single AFU seems a bit noisy. Perhaps we can print it only if LPC memory is > 0? There is an early exit before this if there is no LPC memory. Noted, I'd missed that amidst all the early returns for errors.

Re: [PATCH v3 08/27] ocxl: Emit a log message showing how much LPC memory was detected

2020-02-23 Thread Alastair D'Silva
On Mon, 2020-02-24 at 17:06 +1100, Andrew Donnellan wrote: > On 21/2/20 2:27 pm, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > This patch emits a message showing how much LPC memory & special > > purpose > > memory was detected on an OCXL device. > > > > Signed-off-by: Alastair

Re: [PATCH v3 07/27] ocxl: Add functions to map/unmap LPC memory

2020-02-23 Thread Alastair D'Silva
On Mon, 2020-02-24 at 17:02 +1100, Andrew Donnellan wrote: > On 21/2/20 2:27 pm, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > Add functions to map/unmap LPC memory > > > > Signed-off-by: Alastair D'Silva > > --- > > drivers/misc/ocxl/core.c | 51 > >

Re: [PATCH v3 08/27] ocxl: Emit a log message showing how much LPC memory was detected

2020-02-23 Thread Andrew Donnellan
On 21/2/20 2:27 pm, Alastair D'Silva wrote: From: Alastair D'Silva This patch emits a message showing how much LPC memory & special purpose memory was detected on an OCXL device. Signed-off-by: Alastair D'Silva --- drivers/misc/ocxl/config.c | 4 1 file changed, 4 insertions(+) diff

Re: [PATCH v3 07/27] ocxl: Add functions to map/unmap LPC memory

2020-02-23 Thread Andrew Donnellan
On 21/2/20 2:27 pm, Alastair D'Silva wrote: From: Alastair D'Silva Add functions to map/unmap LPC memory Signed-off-by: Alastair D'Silva --- drivers/misc/ocxl/core.c | 51 +++ drivers/misc/ocxl/ocxl_internal.h | 3 ++ include/misc/ocxl.h

Re: [RFC PATCH v2 00/12] Reduce ifdef mess in ptrace

2020-02-23 Thread Christophe Leroy
Le 24/02/2020 à 03:15, Michael Neuling a écrit : Christophe, Le 28/06/2019 à 17:47, Christophe Leroy a écrit : The purpose of this series is to reduce the amount of #ifdefs in ptrace.c Any feedback on this series which aims at fixing the issue you opened at

Re: [PATCH v3 01/27] powerpc: Add OPAL calls for LPC memory alloc/release

2020-02-23 Thread Alastair D'Silva
On Mon, 2020-02-24 at 16:49 +1100, Andrew Donnellan wrote: > On 21/2/20 2:26 pm, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > Add OPAL calls for LPC memory alloc/release > > > > Signed-off-by: Alastair D'Silva > > Acked-by: Andrew Donnellan > > Acked-by: Frederic Barrat > >

Re: [PATCH v3 03/27] powerpc: Map & release OpenCAPI LPC memory

2020-02-23 Thread Andrew Donnellan
On 24/2/20 1:51 pm, Andrew Donnellan wrote: On 21/2/20 2:26 pm, Alastair D'Silva wrote: From: Alastair D'Silva This patch adds platform support to map & release LPC memory. Signed-off-by: Alastair D'Silva Nothing seems obviously wrong here. Reviewed-by: Andrew Donnellan Oh, commit

Re: [PATCH v3 01/27] powerpc: Add OPAL calls for LPC memory alloc/release

2020-02-23 Thread Andrew Donnellan
On 21/2/20 2:26 pm, Alastair D'Silva wrote: From: Alastair D'Silva Add OPAL calls for LPC memory alloc/release Signed-off-by: Alastair D'Silva Acked-by: Andrew Donnellan Acked-by: Frederic Barrat Summary line should be "powerpc/powernv". -- Andrew Donnellan OzLabs, ADL

Re: [PATCH v3 06/27] ocxl: Tally up the LPC memory on a link & allow it to be mapped

2020-02-23 Thread Alastair D'Silva
On Mon, 2020-02-24 at 16:25 +1100, Andrew Donnellan wrote: > On 21/2/20 2:26 pm, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > Tally up the LPC memory on an OpenCAPI link & allow it to be mapped > > > > Signed-off-by: Alastair D'Silva > > This commit message is a bit short and

Re: [PATCH v3 06/27] ocxl: Tally up the LPC memory on a link & allow it to be mapped

2020-02-23 Thread Andrew Donnellan
On 21/2/20 2:26 pm, Alastair D'Silva wrote: From: Alastair D'Silva Tally up the LPC memory on an OpenCAPI link & allow it to be mapped Signed-off-by: Alastair D'Silva This commit message is a bit short and could do with some further explanation. In particular - it's worth explaining why

Re: [PATCH v2 1/8] powerpc/perf/hv-24x7: Fix inconsistent output values incase multiple hv-24x7 events run

2020-02-23 Thread kajoljain
On 2/23/20 8:21 AM, Sukadev Bhattiprolu wrote: > Kajol Jain [kj...@linux.ibm.com] wrote: >> Commit 2b206ee6b0df ("powerpc/perf/hv-24x7: Display change in counter >> values")' added to print _change_ in the counter value rather then raw >> value for 24x7 counters. Incase of transactions, the

Re: [PATCH v2 5/5] Documentation: Document sysfs interfaces purr, spurr, idle_purr, idle_spurr

2020-02-23 Thread Gautham R Shenoy
On Fri, Feb 21, 2020 at 10:55:07AM -0600, Nathan Lynch wrote: > "Gautham R. Shenoy" writes: > > diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu > > b/Documentation/ABI/testing/sysfs-devices-system-cpu > > index 2e0e3b4..799dc737a 100644 > > ---

Re: [PATCH v2 4/5] powerpc/sysfs: Show idle_purr and idle_spurr for every CPU

2020-02-23 Thread Gautham R Shenoy
On Fri, Feb 21, 2020 at 10:50:12AM -0600, Nathan Lynch wrote: > "Gautham R. Shenoy" writes: > > diff --git a/arch/powerpc/kernel/sysfs.c b/arch/powerpc/kernel/sysfs.c > > index 80a676d..5b4b450 100644 > > --- a/arch/powerpc/kernel/sysfs.c > > +++ b/arch/powerpc/kernel/sysfs.c > > @@ -19,6 +19,7

Re: [PATCH v2 3/5] powerpc/pseries: Account for SPURR ticks on idle CPUs

2020-02-23 Thread Gautham R Shenoy
Hello Nathan, On Fri, Feb 21, 2020 at 10:47:41AM -0600, Nathan Lynch wrote: > "Gautham R. Shenoy" writes: > > +static inline void snapshot_spurr_idle_entry(void) > > +{ > > + *this_cpu_ptr(_entry_spurr_snap) = mfspr(SPRN_SPURR); > > +} > > + > > [...] > > > +static inline void

[PATCH V2 3/4] mm/vma: Replace all remaining open encodings with is_vm_hugetlb_page()

2020-02-23 Thread Anshuman Khandual
This replaces all remaining open encodings with is_vm_hugetlb_page(). Cc: Paul Mackerras Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Cc: Alexander Viro Cc: Will Deacon Cc: "Aneesh Kumar K.V" Cc: Andrew Morton Cc: Nick Piggin Cc: Peter Zijlstra Cc: Arnd Bergmann Cc: Ingo Molnar Cc:

[PATCH V2 2/4] mm/vma: Make vma_is_accessible() available for general use

2020-02-23 Thread Anshuman Khandual
Lets move vma_is_accessible() helper to include/linux/mm.h which makes it available for general use. While here, this replaces all remaining open encodings for VMA access check with vma_is_accessible(). Cc: Guo Ren Cc: Geert Uytterhoeven Cc: Ralf Baechle Cc: Paul Burton Cc: Benjamin

[PATCH V2 0/4] mm/vma: Use all available wrappers when possible

2020-02-23 Thread Anshuman Khandual
Apart from adding a VMA flag readable name for trace purpose, this series does some open encoding replacements with availabe VMA specific wrappers. This skips VM_HUGETLB check in vma_migratable() as its already being done with another patch (https://patchwork.kernel.org/patch/11347831/) which is

Re: [PATCH v2 1/5] powerpc: Move idle_loop_prolog()/epilog() functions to header file

2020-02-23 Thread Gautham R Shenoy
Hello Nathan, On Fri, Feb 21, 2020 at 09:03:16AM -0600, Nathan Lynch wrote: > "Gautham R. Shenoy" writes: > > > From: "Gautham R. Shenoy" > > > > Currently prior to entering an idle state on a Linux Guest, the > > pseries cpuidle driver implement an idle_loop_prolog() and > >

Re: [PATCH v3 00/27] Add support for OpenCAPI Persistent Memory devices

2020-02-23 Thread Alastair D'Silva
On Sun, 2020-02-23 at 20:37 -0800, Matthew Wilcox wrote: > On Mon, Feb 24, 2020 at 03:34:07PM +1100, Alastair D'Silva wrote: > > V3: > > - Rebase against next/next-20200220 > > - Move driver to arch/powerpc/platforms/powernv, we now expect > > this > > driver to go upstream via the powerpc

Re: [PATCH v3 00/27] Add support for OpenCAPI Persistent Memory devices

2020-02-23 Thread Matthew Wilcox
On Mon, Feb 24, 2020 at 03:34:07PM +1100, Alastair D'Silva wrote: > V3: > - Rebase against next/next-20200220 > - Move driver to arch/powerpc/platforms/powernv, we now expect this > driver to go upstream via the powerpc tree That's rather the opposite direction of normal; mostly drivers

Re: [PATCH v3 00/27] Add support for OpenCAPI Persistent Memory devices

2020-02-23 Thread Alastair D'Silva
On Fri, 2020-02-21 at 08:21 -0800, Dan Williams wrote: > On Thu, Feb 20, 2020 at 7:28 PM Alastair D'Silva < > alast...@au1.ibm.com> wrote: > > From: Alastair D'Silva > > > > This series adds support for OpenCAPI Persistent Memory devices, > > exposing > > them as nvdimms so that we can make use

Re: [PATCH v2 0/5] Track and expose idle PURR and SPURR ticks

2020-02-23 Thread Kamalesh Babulal
On 2/21/20 10:48 AM, Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" [...] > > Gautham R. Shenoy (5): > powerpc: Move idle_loop_prolog()/epilog() functions to header file > powerpc/idle: Add accessor function to always read latest idle PURR > powerpc/pseries: Account for SPURR ticks

Re: [PATCH] powerpc: Include .BTF section

2020-02-23 Thread Naveen N. Rao
Michael Ellerman wrote: "Naveen N. Rao" writes: Selecting CONFIG_DEBUG_INFO_BTF results in the below warning from ld: ld: warning: orphan section `.BTF' from `.btf.vmlinux.bin.o' being placed in section `.BTF' Include .BTF section in vmlinux explicitly to fix the same. I don't see any

Re: [PATCH 2/2] powerpc/powernv: Add explicit fast-reboot support

2020-02-23 Thread Andrew Donnellan
On 17/2/20 1:48 pm, Oliver O'Halloran wrote: Add a way to manually invoke a fast-reboot rather than setting the NVRAM flag. The idea is to allow userspace to invoke a fast-reboot using the optional string argument to the reboot() system call, or using the xmon zr command so we don't need to

Re: [PATCH 1/2] powerpc/powernv: Treat an empty reboot string as default

2020-02-23 Thread Andrew Donnellan
On 17/2/20 1:48 pm, Oliver O'Halloran wrote: Treat an empty reboot cmd string the same as a NULL string. This squashes a spurious unsupported reboot message that sometimes gets out when using xmon. Signed-off-by: Oliver O'Halloran Pretty sure I've seen that spurious reboot message a few

Re: [PATCH v3 03/27] powerpc: Map & release OpenCAPI LPC memory

2020-02-23 Thread Andrew Donnellan
On 21/2/20 2:26 pm, Alastair D'Silva wrote: From: Alastair D'Silva This patch adds platform support to map & release LPC memory. Signed-off-by: Alastair D'Silva Nothing seems obviously wrong here. Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra

Re: [PATCH 1/2] powerpc/powernv: Treat an empty reboot string as default

2020-02-23 Thread Alexey Kardashevskiy
On 17/02/2020 13:48, Oliver O'Halloran wrote: > Treat an empty reboot cmd string the same as a NULL string. This squashes a > spurious unsupported reboot message that sometimes gets out when using > xmon. > > Signed-off-by: Oliver O'Halloran > --- > arch/powerpc/platforms/powernv/setup.c | 2

Re: [RFC PATCH v2 00/12] Reduce ifdef mess in ptrace

2020-02-23 Thread Michael Neuling
Christophe, > Le 28/06/2019 à 17:47, Christophe Leroy a écrit : > > The purpose of this series is to reduce the amount of #ifdefs > > in ptrace.c > > > > Any feedback on this series which aims at fixing the issue you opened at > https://github.com/linuxppc/issues/issues/128 ? Yeah, sorry my

Re: [PATCH v3 05/27] ocxl: Address kernel doc errors & warnings

2020-02-23 Thread Andrew Donnellan
On 21/2/20 2:26 pm, Alastair D'Silva wrote: From: Alastair D'Silva This patch addresses warnings and errors from the kernel doc scripts for the OpenCAPI driver. It also makes minor tweaks to make the docs more consistent. Signed-off-by: Alastair D'Silva Looks good, fixes all the kerneldoc

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-23 Thread Anshuman Khandual
On 02/17/2020 08:47 AM, Anshuman Khandual wrote: > This adds a test validation for architecture exported page table helpers. > Patch adds basic transformation tests at various levels of the page table. > > This test was originally suggested by Catalin during arm64 THP migration > RFC discussion

[PATCH v2 10/18] powerpc: Replace setup_irq() by request_irq()

2020-02-23 Thread afzal mohammed
request_irq() is preferred over setup_irq(). The early boot setup_irq() invocations happen either via 'init_IRQ()' or 'time_init()', while memory allocators are ready by 'mm_init()'. Per tglx[1], setup_irq() existed in olden days when allocators were not ready by the time early interrupts were

[PATCH v2 00/18] genirq: Remove setup_irq()

2020-02-23 Thread afzal mohammed
While trying to understand internals of irq handling, came across a thread [1] in which tglx was referring to avoid usage of setup_irq(). The early boot setup_irq() invocations happen either via 'init_IRQ()' or 'time_init()', while memory allocators are ready by 'mm_init()'. Hence instances of

Re: [PATCH] powerpc: Include .BTF section

2020-02-23 Thread Michael Ellerman
"Naveen N. Rao" writes: > Selecting CONFIG_DEBUG_INFO_BTF results in the below warning from ld: > ld: warning: orphan section `.BTF' from `.btf.vmlinux.bin.o' being placed > in section `.BTF' > > Include .BTF section in vmlinux explicitly to fix the same. I don't see any other architectures

[PATCH v3 08/15] powerpc: Replace cpu_up/down with add/remove_cpu

2020-02-23 Thread Qais Yousef
The core device API performs extra housekeeping bits that are missing from directly calling cpu_up/down. See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and serialization during LPM") for an example description of what might go wrong. This also prepares to make cpu_up/down a

[PATCH v3 00/15] Convert cpu_up/down to device_online/offline

2020-02-23 Thread Qais Yousef
Changes in v3: * Fixup smp_shutdown_nonboot_cpus() to hold the right lock as suggested by Russel King. * Split the combined arm/arm64 patch into 2 separate patches. * Add new add/remove_cpu() functions that wraps lock, device_online/offline, unlock as

[PATCH v3 01/15] cpu: Add new {add,remove}_cpu() functions

2020-02-23 Thread Qais Yousef
The new functions use device_{online,offline}() which are userspace safe. This is in preparation to move cpu_{up, down} kernel users to use a safer interface that is not racy with userspace. Suggested-by: "Paul E. McKenney" Signed-off-by: Qais Yousef CC: Thomas Gleixner CC: "Paul E. McKenney"