Re: [RFC PATCH 4/5] powerpc/mm: Remove custom stack expansion checking

2020-07-06 Thread Michael Ellerman
Christophe Leroy writes: > Le 03/07/2020 à 16:13, Michael Ellerman a écrit : >> We have powerpc specific logic in our page fault handling to decide if >> an access to an unmapped address below the stack pointer should expand >> the stack VMA. >> >> The logic aims to prevent userspace from doing b

Re: [PATCH 3/5] selftests/powerpc: Update the stack expansion test

2020-07-06 Thread Michael Ellerman
Christophe Leroy writes: > Le 03/07/2020 à 16:13, Michael Ellerman a écrit : >> Update the stack expansion load/store test to take into account the >> new allowance of 4096 bytes below the stack pointer. > > [I didn't receive patch 2, don't know why, hence commenting patch 2 here.] > > Shouldn't p

Re: [PATCH v2 06/10] powerpc/perf: power10 Performance Monitoring support

2020-07-06 Thread Michael Neuling
> @@ -480,6 +520,7 @@ int isa207_compute_mmcr(u64 event[], int n_ev, > mmcr[1] = mmcr1; > mmcr[2] = mmcra; > mmcr[3] = mmcr2; > + mmcr[4] = mmcr3; This is fragile like the kvm vcpu case I commented on before but it gets passed in via a function parameter?! Can you create a

Re: [PATCH v4 24/41] powerpc/book3s64/pkeys: Store/restore userspace AMR correctly on entry and exit from kernel

2020-07-06 Thread Nicholas Piggin
Excerpts from Aneesh Kumar K.V's message of July 3, 2020 7:30 pm: > On 7/3/20 2:48 PM, Nicholas Piggin wrote: >> Excerpts from Aneesh Kumar K.V's message of June 15, 2020 4:14 pm: >>> This prepare kernel to operate with a different value than userspace AMR. >>> For this, AMR needs to be saved and r

Re: [PATCH v2 04/10] powerpc/perf: Add power10_feat to dt_cpu_ftrs

2020-07-06 Thread Michael Neuling
On Wed, 2020-07-01 at 05:20 -0400, Athira Rajeev wrote: > From: Madhavan Srinivasan > > Add power10 feature function to dt_cpu_ftrs.c along > with a power10 specific init() to initialize pmu sprs. Can you say why you're doing this? Can you add some text about what you're doing to the BHRB in th

Re: [PATCH v2 02/10] KVM: PPC: Book3S HV: Save/restore new PMU registers

2020-07-06 Thread Michael Neuling
@@ -637,12 +637,12 @@ struct kvm_vcpu_arch { > u32 ccr1; > u32 dbsr; > > - u64 mmcr[5]; > + u64 mmcr[6]; > u32 pmc[8]; > u32 spmc[2]; > u64 siar; > + mfspr r5, SPRN_MMCR3 > + mfspr r6, SPRN_SIER2 > + mfspr r7, SPRN_SIER3 > + std r5

Re: [PATCH v5 23/26] powerpc/book3s64/kuap: Move UAMOR setup to key init function

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > UAMOR values are not application-specific. It used to be, that's worth mentioning. > The kernel initializes its value based on different reserved keys. > Remove the thread-specific UAMOR value and don't switch the UAMOR on > context switch. > > Move UAMOR initializat

Re: [PATCH v3 0/6] powerpc: queued spinlocks and rwlocks

2020-07-06 Thread Nicholas Piggin
Excerpts from Waiman Long's message of July 7, 2020 4:39 am: > On 7/6/20 12:35 AM, Nicholas Piggin wrote: >> v3 is updated to use __pv_queued_spin_unlock, noticed by Waiman (thank you). >> >> Thanks, >> Nick >> >> Nicholas Piggin (6): >>powerpc/powernv: must include hvcall.h to get PAPR defines

Re: [PATCH] powerpc/pseries: detect secure and trusted boot state of the system.

2020-07-06 Thread Michael Ellerman
Nayna Jain writes: > The device-tree property to check secure and trusted boot state is > different for guests(pseries) compared to baremetal(powernv). > > This patch updates the existing is_ppc_secureboot_enabled() and > is_ppc_trustedboot_enabled() function to add support for pseries. > > Signed

Re: [PATCH] powerpc: select ARCH_HAS_MEMBARRIER_SYNC_CORE

2020-07-06 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of July 6, 2020 7:53 pm: > > > Le 06/07/2020 à 04:18, Nicholas Piggin a écrit : >> diff --git a/arch/powerpc/include/asm/exception-64s.h >> b/arch/powerpc/include/asm/exception-64s.h >> index 47bd4ea0837d..b88cb3a989b6 100644 >> --- a/arch/powerpc/include

Re: [PATCH v3 1/2] powerpc/perf/hv-24x7: Add cpu hotplug support

2020-07-06 Thread Madhavan Srinivasan
On 7/7/20 10:26 AM, Michael Ellerman wrote: Madhavan Srinivasan writes: On 7/6/20 8:43 AM, Michael Ellerman wrote: Kajol Jain writes: Patch here adds cpu hotplug functions to hv_24x7 pmu. A new cpuhp_state "CPUHP_AP_PERF_POWERPC_HV_24x7_ONLINE" enum is added. The online callback function

Re: [PATCH v12 00/31] Speculative page faults

2020-07-06 Thread Chinwen Chang
On Mon, 2020-07-06 at 14:27 +0200, Laurent Dufour wrote: > Le 06/07/2020 à 11:25, Chinwen Chang a écrit : > > On Thu, 2019-06-20 at 16:19 +0800, Haiyan Song wrote: > >> Hi Laurent, > >> > >> I downloaded your script and run it on Intel 2s skylake platform with > >> spf-v12 patch > >> serials. > >>

Re: [PATCH] powerpc/numa: Restrict possible nodes based on platform

2020-07-06 Thread Michael Ellerman
Srikar Dronamraju writes: > As per PAPR, there are 2 device tree property > ibm,max-associativity-domains (which defines the maximum number of > domains that the firmware i.e PowerVM can support) and > ibm,current-associativity-domains (which defines the maximum number of > domains that the platfo

[PATCH v2] MAINTAINERS: Add Shengjiu to reviewer list of sound/soc/fsl

2020-07-06 Thread Nicolin Chen
Add Shengjiu who's actively working on the latest fsl/nxp audio drivers. Signed-off-by: Nicolin Chen Acked-by: Shengjiu Wang Reviewed-by: Fabio Estevam --- Changelog v1->v2: * Replaced Shengjiu's emaill address with his gmail one * Added Acked-by from Shengjiu and Reviewed-by from Fabio MAI

Re: [PATCH v3 1/2] powerpc/perf/hv-24x7: Add cpu hotplug support

2020-07-06 Thread Michael Ellerman
Madhavan Srinivasan writes: > On 7/6/20 8:43 AM, Michael Ellerman wrote: >> Kajol Jain writes: >>> Patch here adds cpu hotplug functions to hv_24x7 pmu. >>> A new cpuhp_state "CPUHP_AP_PERF_POWERPC_HV_24x7_ONLINE" enum >>> is added. >>> >>> The online callback function updates the cpumask only if

Re: [PATCH v3 1/2] powerpc/perf/hv-24x7: Add cpu hotplug support

2020-07-06 Thread Madhavan Srinivasan
On 7/6/20 8:43 AM, Michael Ellerman wrote: Kajol Jain writes: Patch here adds cpu hotplug functions to hv_24x7 pmu. A new cpuhp_state "CPUHP_AP_PERF_POWERPC_HV_24x7_ONLINE" enum is added. The online callback function updates the cpumask only if its empty. As the primary intention of adding

Re: [PATCH] powerpc/numa: Restrict possible nodes based on platform

2020-07-06 Thread Srikar Dronamraju
* Nathan Lynch [2020-07-06 19:44:31]: > Tyrel Datwyler writes: > >> --- a/arch/powerpc/mm/numa.c > >> +++ b/arch/powerpc/mm/numa.c > >> @@ -897,7 +897,7 @@ static void __init find_possible_nodes(void) > >>return; > >> > >>if (of_property_read_u32_index(rtas, > >> -

Re: [PATCH] powerpc/pseries: detect secure and trusted boot state of the system.

2020-07-06 Thread Daniel Axtens
As a final extra note, https://github.com/daxtens/qemu/tree/pseries-secboot is a qemu repository that fakes out the relevant properties if anyone else wants to test this. Also, > 3-9 - enabled, OS-defined behaviour. In this patch we map all these >values to enabled and enforcing. Aga

Re: [PATCH] powerpc/numa: Restrict possible nodes based on platform

2020-07-06 Thread Srikar Dronamraju
* Tyrel Datwyler [2020-07-06 13:58:42]: > On 7/5/20 11:40 PM, Srikar Dronamraju wrote: > > diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c > > index 9fcf2d195830..3d55cef1a2dc 100644 > > --- a/arch/powerpc/mm/numa.c > > +++ b/arch/powerpc/mm/numa.c > > @@ -897,7 +897,7 @@ static void

RE: [PATCH v6 00/11] Add the multiple PF support for DWC and Layerscape

2020-07-06 Thread Z.q. Hou
Hi Lorenzo, > -Original Message- > From: Lorenzo Pieralisi [mailto:lorenzo.pieral...@arm.com] > Sent: 2020年7月6日 18:47 > To: Xiaowei Bao > Cc: Z.q. Hou ; M.h. Lian ; > Mingkai Hu ; bhelg...@google.com; > robh...@kernel.org; shawn...@kernel.org; Leo Li ; > kis...@ti.com; Roy Zang ; > amur..

Re: [PATCH] powerpc/pseries: detect secure and trusted boot state of the system.

2020-07-06 Thread Daniel Axtens
Thanks Nayna! I'm hoping to get better public documentation for this soon as it's not documented in a public PAPR yet. Until then: The values of ibm,secure-boot under PowerVM are: 0 - disabled 1 - audit mode only. This patch ignores this value for Linux, which I think is the appropriat

Re: [PATCH] MAINTAINERS: Add Shengjiu to reviewer list of sound/soc/fsl

2020-07-06 Thread Shengjiu Wang
On Fri, Jul 3, 2020 at 3:33 AM Nicolin Chen wrote: > > Add Shengjiu who's actively working on the latest fsl/nxp audio drivers. > > Signed-off-by: Nicolin Chen > Cc: Shengjiu Wang > --- > To Shengjiu, please ack if you feel okay with this (your email address too). Thanks Nicolin for nominating

Re: [PATCH v5 10/26] powerpc/book3s64/pkeys: Convert pkey_total to max_pkey

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > On 7/6/20 12:34 PM, Michael Ellerman wrote: >> "Aneesh Kumar K.V" writes: >>> max_pkey now represents max key value that userspace can allocate. >>> > > I guess commit message is confusing. And the name. If it's called max_pkey then it should be the maximum allowed

Re: [PATCH v5 19/26] powerpc/book3s64/kuap: Move KUAP related function outside radix

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > On 7/6/20 6:11 PM, Michael Ellerman wrote: >> "Aneesh Kumar K.V" writes: >>> The next set of patches adds support for kuap with hash translation. >> >> That's no longer true of this series. >> >>> diff --git a/arch/powerpc/mm/book3s64/pkeys.c >>> b/arch/powerpc/mm/

Re: [PATCH v5 18/26] powerpc/book3s64/keys/kuap: Reset AMR/IAMR values on kexec

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > On 7/6/20 5:59 PM, Michael Ellerman wrote: >> "Aneesh Kumar K.V" writes: >>> As we kexec across kernels that use AMR/IAMR for different purposes >>> we need to ensure that new kernels get kexec'd with a reset value >>> of AMR/IAMR. For ex: the new kernel can use key 0

Re: [PATCH v5 13/26] powerpc/book3s64/pkeys: Enable MMU_FTR_PKEY

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: >>>   /*    * Let's assume 32 pkeys on P8 bare metal, if its not defined by device    * tree. We make this exception since skiboot forgot to expose this    * property on power8.    */  

[PATCH 1/1] KVM/PPC: Fix typo on H_DISABLE_AND_GET hcall

2020-07-06 Thread Leonardo Bras
On PAPR+ the hcall() on 0x1B0 is called H_DISABLE_AND_GET, but got defined as H_DISABLE_AND_GETC instead. This define was introduced with a typo in commit ("[PATCH] powerpc: Extends HCALL interface for InfiniBand usage"), and was later used without having the typo noticed. Signed-off-by: Leonard

Re: [PATCH] powerpc/numa: Restrict possible nodes based on platform

2020-07-06 Thread Nathan Lynch
Tyrel Datwyler writes: >> --- a/arch/powerpc/mm/numa.c >> +++ b/arch/powerpc/mm/numa.c >> @@ -897,7 +897,7 @@ static void __init find_possible_nodes(void) >> return; >> >> if (of_property_read_u32_index(rtas, >> -"ibm,max-associativity-domains", >> +

Re: [PATCH v2 00/12] ppc64: enable kdump support for kexec_file_load syscall

2020-07-06 Thread piliu
On 07/03/2020 03:53 AM, Hari Bathini wrote: > This patch series enables kdump support for kexec_file_load system > call (kexec -s -p) on PPC64. The changes are inspired from kexec-tools > code but heavily modified for kernel consumption. There is scope to > expand purgatory to verify sha256 dige

Re: [PATCH 1/4] dma-mapping: move the remaining DMA API calls out of line

2020-07-06 Thread Alexey Kardashevskiy
On 03/06/2020 14:13, Alexey Kardashevskiy wrote: > > > On 09/05/2020 18:19, Christoph Hellwig wrote: >> On Tue, May 05, 2020 at 02:18:37PM +1000, Alexey Kardashevskiy wrote: >>> >>> >>> On 17/04/2020 17:58, Christoph Hellwig wrote: On Wed, Apr 15, 2020 at 09:21:37PM +1000, Alexey Kardashe

Re: [PATCH] powerpc/spufs: add CONFIG_COREDUMP dependency

2020-07-06 Thread Jeremy Kerr
Hi Arnd, > The kernel test robot pointed out a slightly different error message > after recent commit 5456ffdee666 ("powerpc/spufs: simplify spufs core > dumping") to spufs for a configuration that never worked: > >powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in > function `.

Re: [PATCH] powerpc/numa: Restrict possible nodes based on platform

2020-07-06 Thread Nathan Lynch
Srikar Dronamraju writes: > diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c > index 9fcf2d195830..3d55cef1a2dc 100644 > --- a/arch/powerpc/mm/numa.c > +++ b/arch/powerpc/mm/numa.c > @@ -897,7 +897,7 @@ static void __init find_possible_nodes(void) > return; > > if

Re: [PATCH] powerpc/numa: Restrict possible nodes based on platform

2020-07-06 Thread Tyrel Datwyler
On 7/5/20 11:40 PM, Srikar Dronamraju wrote: > As per PAPR, there are 2 device tree property > ibm,max-associativity-domains (which defines the maximum number of > domains that the firmware i.e PowerVM can support) and > ibm,current-associativity-domains (which defines the maximum number of > domai

Re: [PATCH v3 0/6] powerpc: queued spinlocks and rwlocks

2020-07-06 Thread Waiman Long
On 7/6/20 12:35 AM, Nicholas Piggin wrote: v3 is updated to use __pv_queued_spin_unlock, noticed by Waiman (thank you). Thanks, Nick Nicholas Piggin (6): powerpc/powernv: must include hvcall.h to get PAPR defines powerpc/pseries: move some PAPR paravirt functions to their own file powe

Re: [PATCH] kbuild: introduce ccflags-remove-y and asflags-remove-y

2020-07-06 Thread Masahiro Yamada
Hi Anders, On Mon, Jul 6, 2020 at 8:24 PM Anders Roxell wrote: > > The full log can be found here [1]. > > Without this patch for 'trace_selftest_dynamic' for instance, CC_FLAGS_FTRACE > was removed from kernel/trace/*, and then added back to > kernel/trace/trace_selftest_dynamic. > While with

Re: [PATCH v5 13/26] powerpc/book3s64/pkeys: Enable MMU_FTR_PKEY

2020-07-06 Thread Aneesh Kumar K.V
  /*    * Let's assume 32 pkeys on P8 bare metal, if its not defined by device    * tree. We make this exception since skiboot forgot to expose this    * property on power8.    */   if (!firmware_has_feature(FW_FEATURE_LPAR) && -    c

Re: [PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

2020-07-06 Thread Andi Kleen
> > What's the point of this indirection other than another way of avoiding > > empty node 0? > > Honestly, I do not have any idea. I've traced it down to > Author: Andi Kleen > Date: Tue Jan 11 15:35:48 2005 -0800 I don't remember all the details, and I can't even find the commit (is it in li

Re: [PATCH v5 19/26] powerpc/book3s64/kuap: Move KUAP related function outside radix

2020-07-06 Thread Aneesh Kumar K.V
On 7/6/20 6:11 PM, Michael Ellerman wrote: "Aneesh Kumar K.V" writes: The next set of patches adds support for kuap with hash translation. That's no longer true of this series. diff --git a/arch/powerpc/mm/book3s64/pkeys.c b/arch/powerpc/mm/book3s64/pkeys.c index 0d72c0246052..e93b65a0e6e7

Re: [PATCH v5 18/26] powerpc/book3s64/keys/kuap: Reset AMR/IAMR values on kexec

2020-07-06 Thread Aneesh Kumar K.V
On 7/6/20 5:59 PM, Michael Ellerman wrote: "Aneesh Kumar K.V" writes: As we kexec across kernels that use AMR/IAMR for different purposes we need to ensure that new kernels get kexec'd with a reset value of AMR/IAMR. For ex: the new kernel can use key 0 for kernel mapping and the old AMR value

Re: [PATCH v5 13/26] powerpc/book3s64/pkeys: Enable MMU_FTR_PKEY

2020-07-06 Thread Aneesh Kumar K.V
On 7/6/20 6:40 PM, Michael Ellerman wrote: "Aneesh Kumar K.V" writes: Parse storage keys related device tree entry in early_init_devtree and enable MMU feature MMU_FTR_PKEY if pkeys are supported. MMU feature is used instead of CPU feature because this enables us to group MMU_FTR_KUAP and MMU_

[PATCH] powerpc/spufs: add CONFIG_COREDUMP dependency

2020-07-06 Thread Arnd Bergmann
The kernel test robot pointed out a slightly different error message after recent commit 5456ffdee666 ("powerpc/spufs: simplify spufs core dumping") to spufs for a configuration that never worked: powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_proxydma_info_d

Re: [PATCH v5 13/26] powerpc/book3s64/pkeys: Enable MMU_FTR_PKEY

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > Parse storage keys related device tree entry in early_init_devtree > and enable MMU feature MMU_FTR_PKEY if pkeys are supported. > > MMU feature is used instead of CPU feature because this enables us > to group MMU_FTR_KUAP and MMU_FTR_PKEY in asm feature fixup code.

Re: [PATCH v5 19/26] powerpc/book3s64/kuap: Move KUAP related function outside radix

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > The next set of patches adds support for kuap with hash translation. That's no longer true of this series. > diff --git a/arch/powerpc/mm/book3s64/pkeys.c > b/arch/powerpc/mm/book3s64/pkeys.c > index 0d72c0246052..e93b65a0e6e7 100644 > --- a/arch/powerpc/mm/book3s64

Re: [PATCH v12 00/31] Speculative page faults

2020-07-06 Thread Laurent Dufour
Le 06/07/2020 à 11:25, Chinwen Chang a écrit : On Thu, 2019-06-20 at 16:19 +0800, Haiyan Song wrote: Hi Laurent, I downloaded your script and run it on Intel 2s skylake platform with spf-v12 patch serials. Here attached the output results of this script. The following comparison result is st

Re: [PATCH v5 18/26] powerpc/book3s64/keys/kuap: Reset AMR/IAMR values on kexec

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > As we kexec across kernels that use AMR/IAMR for different purposes > we need to ensure that new kernels get kexec'd with a reset value > of AMR/IAMR. For ex: the new kernel can use key 0 for kernel mapping and the > old > AMR value prevents access to key 0. > > This

Re: [PATCH V4 0/4] mm/debug_vm_pgtable: Add some more tests

2020-07-06 Thread Alexander Gordeev
On Mon, Jul 06, 2020 at 06:18:32AM +0530, Anshuman Khandual wrote: [...] > Tested on arm64, x86 platforms but only build tested on all other enabled > platforms through ARCH_HAS_DEBUG_VM_PGTABLE i.e powerpc, arc, s390. The Sorry for missing to test earlier. Works for me on s390. Also, tried with

Re: [PATCH] kbuild: introduce ccflags-remove-y and asflags-remove-y

2020-07-06 Thread Anders Roxell
On Mon, 6 Jul 2020 at 13:24, Anders Roxell wrote: > > Hi, > > When I built an allmodconfig kernel for arm64, and boot that in qemu > guest I see the following issues: > > [...] > [ 10.451561][T1] Testing tracer function: PASSED > [ 33.087895][T1] Testing dynamic ftrace: .. filter did n

Re: [PATCH] kbuild: introduce ccflags-remove-y and asflags-remove-y

2020-07-06 Thread Anders Roxell
Hi, When I built an allmodconfig kernel for arm64, and boot that in qemu guest I see the following issues: [...] [ 10.451561][T1] Testing tracer function: PASSED [ 33.087895][T1] Testing dynamic ftrace: .. filter did not filter .. FAILED! [ 51.127094][T1] [ cut here

Re: [PATCH v6 00/11] Add the multiple PF support for DWC and Layerscape

2020-07-06 Thread Lorenzo Pieralisi
On Sat, Mar 14, 2020 at 11:30:27AM +0800, Xiaowei Bao wrote: > Add the PCIe EP multiple PF support for DWC and Layerscape, add > the doorbell MSIX function for DWC, use list to manage the PF of > one PCIe controller, and refactor the Layerscape EP driver due to > some platforms difference. > > Xia

[PATCH 11/11 RFC] PCI: Remove "*val = 0" from pcie_capability_read_*()

2020-07-06 Thread Saheed Olayemi Bolarinwa
From: Bolarinwa Olayemi Saheed **TODO** Suggested-by: Bjorn Helgaas Signed-off-by: Bolarinwa Olayemi Saheed --- This patch depends on all of the preceeding patches in this series, otherwise it will introduce bugs as pointed out in the commit message of each. drivers/pci/access.c | 14 --

[PATCH 0/11 RFC] PCI: Remove "*val = 0" from pcie_capability_read_*()

2020-07-06 Thread Saheed Olayemi Bolarinwa
From: Bolarinwa Olayemi Saheed *** BLURB HERE *** Bolarinwa Olayemi Saheed (9): IB/hfi1: Confirm that pcie_capability_read_dword() is successful misc: rtsx: Confirm that pcie_capability_read_word() is successful PCI/AER: Use error return value from pcie_capability_read_*() PCI/ASPM: Use

Re: [PATCH v12 00/31] Speculative page faults

2020-07-06 Thread Chinwen Chang
On Thu, 2019-06-20 at 16:19 +0800, Haiyan Song wrote: > Hi Laurent, > > I downloaded your script and run it on Intel 2s skylake platform with spf-v12 > patch > serials. > > Here attached the output results of this script. > > The following comparison result is statistics from the script outputs

Re: [PATCH] powerpc: select ARCH_HAS_MEMBARRIER_SYNC_CORE

2020-07-06 Thread Christophe Leroy
Le 06/07/2020 à 04:18, Nicholas Piggin a écrit : powerpc return from interrupt and return from system call sequences are context synchronising. Signed-off-by: Nicholas Piggin --- .../features/sched/membarrier-sync-core/arch-support.txt | 4 ++-- arch/powerpc/Kconfig

Re: [PATCH 01/14] powerpc/eeh: Remove eeh_dev_phb_init_dynamic()

2020-07-06 Thread kernel test robot
Hi Oliver, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.8-rc4 next-20200706] [cannot apply to scottwood/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v2 01/12] kexec_file: allow archs to handle special regions while locating memory hole

2020-07-06 Thread Dave Young
On 07/03/20 at 01:24am, Hari Bathini wrote: > Some architectures may have special memory regions, within the given > memory range, which can't be used for the buffer in a kexec segment. > Implement weak arch_kexec_locate_mem_hole() definition which arch code > may override, to take care of special

Re: [PATCH v5 15/26] powerpc/book3s64/pkeys: Use execute_pkey_disable static key

2020-07-06 Thread Aneesh Kumar K.V
On 7/6/20 12:50 PM, Michael Ellerman wrote: "Aneesh Kumar K.V" writes: Use execute_pkey_disabled static key to check for execute key support instead of pkey_disabled. Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/include/asm/pkeys.h | 10 +- arch/powerpc/mm/book3s64/pkeys.c | 5

Re: [PATCH v5 11/26] powerpc/book3s64/pkeys: Make initial_allocation_mask static

2020-07-06 Thread Aneesh Kumar K.V
On 7/6/20 12:34 PM, Michael Ellerman wrote: "Aneesh Kumar K.V" writes: initial_allocation_mask is not used outside this file. And never modified after init, so make it __ro_after_init as well? ok, will update reserved_allocation_maask too. cheers diff --git a/arch/powerpc/include/asm/

Re: [PATCH v5 08/26] powerpc/book3s64/pkeys: Convert execute key support to static key

2020-07-06 Thread Aneesh Kumar K.V
On 7/6/20 12:49 PM, Michael Ellerman wrote: "Aneesh Kumar K.V" writes: Convert the bool to a static key like pkey_disabled. I'm not convinced this is worth the added complexity of a static key. It's not used in any performance critical paths, except for context switch, but that's already gua

Re: [PATCH v8 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support

2020-07-06 Thread kernel test robot
to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Axtens/KASAN-for-powerpc64-radix/20200702-105552 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc64-randconfig-s031-20200706

Re: [PATCH v5 17/26] powerpc/book3s64/keys: Print information during boot.

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > Signed-off-by: Aneesh Kumar K.V > --- > arch/powerpc/mm/book3s64/pkeys.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/mm/book3s64/pkeys.c > b/arch/powerpc/mm/book3s64/pkeys.c > index 810118123e70..0d72c0246052 100644 > --- a/arch/powerpc/mm

[RFC][PATCH] avoid refcounting the lazy tlb mm struct

2020-07-06 Thread Nicholas Piggin
On big systems, the mm refcount can become highly contented when doing a lot of context switching with threaded applications (particularly switching between the idle thread and an application thread). Not doing lazy tlb at all slows switching down quite a bit, so I wonder if we can avoid the refco

Re: [PATCH v5 10/26] powerpc/book3s64/pkeys: Convert pkey_total to max_pkey

2020-07-06 Thread Aneesh Kumar K.V
On 7/6/20 12:34 PM, Michael Ellerman wrote: "Aneesh Kumar K.V" writes: max_pkey now represents max key value that userspace can allocate. I guess commit message is confusing. Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/include/asm/pkeys.h | 7 +-- arch/powerpc/mm/book3s64/pke

Re: [PATCH v5 15/26] powerpc/book3s64/pkeys: Use execute_pkey_disable static key

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > Use execute_pkey_disabled static key to check for execute key support instead > of pkey_disabled. > > Signed-off-by: Aneesh Kumar K.V > --- > arch/powerpc/include/asm/pkeys.h | 10 +- > arch/powerpc/mm/book3s64/pkeys.c | 5 - > 2 files changed, 5 inserti

Re: [PATCH v5 08/26] powerpc/book3s64/pkeys: Convert execute key support to static key

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > Convert the bool to a static key like pkey_disabled. I'm not convinced this is worth the added complexity of a static key. It's not used in any performance critical paths, except for context switch, but that's already guarded by: if (old_thread->iamr != new_

Re: [PATCH v5 11/26] powerpc/book3s64/pkeys: Make initial_allocation_mask static

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > initial_allocation_mask is not used outside this file. And never modified after init, so make it __ro_after_init as well? cheers > diff --git a/arch/powerpc/include/asm/pkeys.h > b/arch/powerpc/include/asm/pkeys.h > index 652bad7334f3..47c81d41ea9a 100644 > --- a/a

Re: [PATCH v5 10/26] powerpc/book3s64/pkeys: Convert pkey_total to max_pkey

2020-07-06 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > max_pkey now represents max key value that userspace can allocate. > > Signed-off-by: Aneesh Kumar K.V > --- > arch/powerpc/include/asm/pkeys.h | 7 +-- > arch/powerpc/mm/book3s64/pkeys.c | 14 +++--- > 2 files changed, 12 insertions(+), 9 deletions(-) >