Re: [PATCH v4 10/10] powerpc/watchpoint: Remove 512 byte boundary

2020-07-19 Thread Jordan Niethe
On Fri, Jul 17, 2020 at 2:11 PM Ravi Bangoria wrote: > > Power10 has removed 512 bytes boundary from match criteria. i.e. The watch > range can cross 512 bytes boundary. It looks like this change is not mentioned in ISA v3.1 Book III 9.4 Data Address Watchpoint. It could be useful to mention that

Re: [PATCH 05/11] powerpc/smp: Dont assume l2-cache to be superset of sibling

2020-07-19 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-07-17 11:30:11]: > Hi Srikar, > > On Tue, Jul 14, 2020 at 10:06:18AM +0530, Srikar Dronamraju wrote: > > Current code assumes that cpumask of cpus sharing a l2-cache mask will > > always be a superset of cpu_sibling_mask. > > > > Lets stop that assumption. > > > > Cc:

Re: [PATCH 5/5] cpuidle-pseries: Block Extended CEDE(1) which adds no additional value.

2020-07-19 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2020-07-07 16:41:39]: > From: "Gautham R. Shenoy" > > The Extended CEDE state with latency-hint = 1 is only different from > normal CEDE (with latency-hint = 0) in that a CPU in Extended CEDE(1) > does not wakeup on timer events. Both CEDE and Extended CEDE(1) map to > the s

Re: [PATCH 4/5] cpuidle-pseries : Include extended CEDE states in cpuidle framework

2020-07-19 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2020-07-07 16:41:38]: > From: "Gautham R. Shenoy" > > This patch exposes those extended CEDE states to the cpuidle framework > which are responsive to external interrupts and do not need an H_PROD. > > Since as per the PAPR, all the extended CEDE states are non-responsive >

Re: [PATCH 3/5] cpuidle-pseries : Fixup exit latency for CEDE(0)

2020-07-19 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2020-07-07 16:41:37]: > From: "Gautham R. Shenoy" > > We are currently assuming that CEDE(0) has exit latency 10us, since > there is no way for us to query from the platform. However, if the > wakeup latency of an Extended CEDE state is smaller than 10us, then we > can be s

Re: [PATCH 3/5] dma-mapping: make support for dma ops optional

2020-07-19 Thread Christoph Hellwig
On Sat, Jul 18, 2020 at 10:17:14AM -0700, Guenter Roeck wrote: > On Wed, Jul 08, 2020 at 05:24:47PM +0200, Christoph Hellwig wrote: > > Avoid the overhead of the dma ops support for tiny builds that only > > use the direct mapping. > > > > Signed-off-by: Christoph Hellwig > > For ppc:pmac32_defc

Re: [PATCH 06/11] powerpc/smp: Generalize 2nd sched domain

2020-07-19 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-07-17 12:07:55]: > On Tue, Jul 14, 2020 at 10:06:19AM +0530, Srikar Dronamraju wrote: > > Currently "CACHE" domain happens to be the 2nd sched domain as per > > powerpc_topology. This domain will collapse if cpumask of l2-cache is > > same as SMT domain. However we could

Re: [FIX PATCH] powerpc/prom: Enable Radix GTSE in cpu pa-features

2020-07-19 Thread Bharata B Rao
On Mon, Jul 20, 2020 at 03:38:29PM +1000, Nicholas Piggin wrote: > Excerpts from Bharata B Rao's message of July 20, 2020 2:42 pm: > > diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c > > index 9cc49f265c86..a9594bad572a 100644 > > --- a/arch/powerpc/kernel/prom.c > > +++ b/arch

Re: [PATCH v6 03/23] powerpc/book3s64/pkeys: pkeys are supported only on hash on book3s.

2020-07-19 Thread Aneesh Kumar K.V
On 7/20/20 11:35 AM, Michael Ellerman wrote: "Aneesh Kumar K.V" writes: Move them to hash specific file and add BUG() for radix path. --- .../powerpc/include/asm/book3s/64/hash-pkey.h | 32 arch/powerpc/include/asm/book3s/64/pkeys.h| 25 + arch/powerpc/inclu

Re: [PATCH 2/5] cpuidle-pseries: Add function to parse extended CEDE records

2020-07-19 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2020-07-07 16:41:36]: > From: "Gautham R. Shenoy" > > Currently we use CEDE with latency-hint 0 as the only other idle state > on a dedicated LPAR apart from the polling "snooze" state. > > The platform might support additional extended CEDE idle states, which > can be disc

Re: [PATCH v6 03/23] powerpc/book3s64/pkeys: pkeys are supported only on hash on book3s.

2020-07-19 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > Move them to hash specific file and add BUG() for radix path. > --- > .../powerpc/include/asm/book3s/64/hash-pkey.h | 32 > arch/powerpc/include/asm/book3s/64/pkeys.h| 25 + > arch/powerpc/include/asm/pkeys.h | 37

Re: [PATCH 09/11] Powerpc/smp: Create coregroup domain

2020-07-19 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-07-17 13:49:26]: > On Tue, Jul 14, 2020 at 10:06:22AM +0530, Srikar Dronamraju wrote: > > Add percpu coregroup maps and masks to create coregroup domain. > > If a coregroup doesn't exist, the coregroup domain will be degenerated > > in favour of SMT/CACHE domain. > > > >

Re: [PATCH 1/5] cpuidle-pseries: Set the latency-hint before entering CEDE

2020-07-19 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2020-07-07 16:41:35]: > From: "Gautham R. Shenoy" > > As per the PAPR, each H_CEDE call is associated with a latency-hint to > be passed in the VPA field "cede_latency_hint". The CEDE states that > we were implicitly entering so far is CEDE with latency-hint = 0. > > This p

Re: [PATCH v2 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2020-07-19 Thread Gautham R Shenoy
Hi Pratik, On Fri, Jul 17, 2020 at 02:48:01PM +0530, Pratik Rajesh Sampat wrote: > This patch adds support to trace IPI based and timer based wakeup > latency from idle states > > Latches onto the test-cpuidle_latency kernel module using the debugfs > interface to send IPIs or schedule a timer b

Re: [PATCH 0/5] cpuidle-pseries: Parse extended CEDE information for idle.

2020-07-19 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2020-07-07 16:41:34]: > From: "Gautham R. Shenoy" > > Hi, > > On pseries Dedicated Linux LPARs, apart from the polling snooze idle > state, we currently have the CEDE idle state which cedes the CPU to > the hypervisor with latency-hint = 0. > > However, the PowerVM hypervi

Re: [PATCH 10/11] powerpc/smp: Implement cpu_to_coregroup_id

2020-07-19 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-07-17 13:56:53]: > On Tue, Jul 14, 2020 at 10:06:23AM +0530, Srikar Dronamraju wrote: > > Lookup the coregroup id from the associativity array. > > > > If unable to detect the coregroup id, fallback on the core id. > > This way, ensure sched_domain degenerates and an ext

Re: [FIX PATCH] powerpc/prom: Enable Radix GTSE in cpu pa-features

2020-07-19 Thread Nicholas Piggin
Excerpts from Bharata B Rao's message of July 20, 2020 2:42 pm: > From: Nicholas Piggin > > When '029ab30b4c0a ("powerpc/mm: Enable radix GTSE only if supported.")' > made GTSE an MMU feature, it was enabled by default in > powerpc-cpu-features but was missed in pa-features. This causes > random

Re: [PATCH v2 13/16] scripts/kallsyms: move ignored symbol types to is_ignored_symbol()

2020-07-19 Thread Masahiro Yamada
On Mon, Jul 20, 2020 at 10:46 AM Finn Thain wrote: > > On Sun, 24 Nov 2019, Masahiro Yamada wrote: > > > Collect the ignored patterns to is_ignored_symbol(). > > > > Signed-off-by: Masahiro Yamada > > This commit (887df76de67f5) caused a regression in my powerpc builds as it > causes symbol names

Re: [PATCH v2 1/2] cpuidle: Trace IPI based and timer based wakeup latency from idle states

2020-07-19 Thread Gautham R Shenoy
On Fri, Jul 17, 2020 at 02:48:00PM +0530, Pratik Rajesh Sampat wrote: > Fire directed smp_call_function_single IPIs from a specified source > CPU to the specified target CPU to reduce the noise we have to wade > through in the trace log. > The module is based on the idea written by Srivatsa Bhat an

[FIX PATCH] powerpc/prom: Enable Radix GTSE in cpu pa-features

2020-07-19 Thread Bharata B Rao
From: Nicholas Piggin When '029ab30b4c0a ("powerpc/mm: Enable radix GTSE only if supported.")' made GTSE an MMU feature, it was enabled by default in powerpc-cpu-features but was missed in pa-features. This causes random memory corruption during boot of PowerNV kernels where CONFIG_PPC_DT_CPU_FTR

Re: [PATCH v2 2/3] powerpc/powernv/idle: save-restore DAWR0, DAWRX0 for P10

2020-07-19 Thread Ravi Bangoria
Hi Nick, On 7/13/20 11:22 AM, Nicholas Piggin wrote: Excerpts from Pratik Rajesh Sampat's message of July 10, 2020 3:22 pm: Additional registers DAWR0, DAWRX0 may be lost on Power 10 for stop levels < 4. Therefore save the values of these SPRs before entering a "stop" state and restore their v

Re: [PATCH v2 2/3] powerpc/powernv/idle: save-restore DAWR0,DAWRX0 for P10

2020-07-19 Thread Ravi Bangoria
Hi Pratik, On 7/10/20 10:52 AM, Pratik Rajesh Sampat wrote: Additional registers DAWR0, DAWRX0 may be lost on Power 10 for stop levels < 4. p10 has one more pair DAWR1/DAWRX1. Please include that as well. Ravi

Re: [PATCH v4 09/10] powerpc/watchpoint: Return available watchpoints dynamically

2020-07-19 Thread Jordan Niethe
On Fri, Jul 17, 2020 at 2:11 PM Ravi Bangoria wrote: > > So far Book3S Powerpc supported only one watchpoint. Power10 is > introducing 2nd DAWR. Enable 2nd DAWR support for Power10. > Availability of 2nd DAWR will depend on CPU_FTR_DAWR1. > > Signed-off-by: Ravi Bangoria > --- > arch/powerpc/inc

Re: [RFC PATCH 4/7] x86: use exit_lazy_tlb rather than membarrier_mm_sync_core_before_usermode

2020-07-19 Thread Nicholas Piggin
Excerpts from Mathieu Desnoyers's message of July 17, 2020 11:42 pm: > - On Jul 16, 2020, at 7:26 PM, Nicholas Piggin npig...@gmail.com wrote: > [...] >> >> membarrier does replace barrier instructions on remote CPUs, which do >> order accesses performed by the kernel on the user address space

Re: [PATCH v2 4/4] mm/vmalloc: Hugepage vmalloc mappings

2020-07-19 Thread Nicholas Piggin
Excerpts from Zefan Li's message of July 20, 2020 12:02 pm: >> +static int vmap_pages_range_noflush(unsigned long start, unsigned long end, >> +pgprot_t prot, struct page **pages, >> +unsigned int page_shift) >> +{ >> +if (page_shi

Re: [PATCH v2 4/4] mm/vmalloc: Hugepage vmalloc mappings

2020-07-19 Thread Zefan Li
> +static int vmap_pages_range_noflush(unsigned long start, unsigned long end, > + pgprot_t prot, struct page **pages, > + unsigned int page_shift) > +{ > + if (page_shift == PAGE_SIZE) { Is this a typo of PAGE_SHIFT? > +

Re: [PATCH v4 07/10] powerpc/watchpoint: Rename current H_SET_MODE DAWR macro

2020-07-19 Thread Jordan Niethe
On Fri, Jul 17, 2020 at 2:11 PM Ravi Bangoria wrote: > > Current H_SET_MODE hcall macro name for setting/resetting DAWR0 is > H_SET_MODE_RESOURCE_SET_DAWR. Add suffix 0 to macro name as well. > > Signed-off-by: Ravi Bangoria Reviewed-by: Jordan Niethe > --- > arch/powerpc/include/asm/hvcall.h

Re: [PATCH v2 13/16] scripts/kallsyms: move ignored symbol types to is_ignored_symbol()

2020-07-19 Thread Finn Thain
On Sun, 24 Nov 2019, Masahiro Yamada wrote: > Collect the ignored patterns to is_ignored_symbol(). > > Signed-off-by: Masahiro Yamada This commit (887df76de67f5) caused a regression in my powerpc builds as it causes symbol names to disappear from backtraces: [ cut here ]--

Re: [PATCH v4 06/10] powerpc/watchpoint: Set CPU_FTR_DAWR1 based on pa-features bit

2020-07-19 Thread Jordan Niethe
On Fri, Jul 17, 2020 at 2:10 PM Ravi Bangoria wrote: > > As per the PAPR, bit 0 of byte 64 in pa-features property indicates > availability of 2nd DAWR registers. i.e. If this bit is set, 2nd > DAWR is present, otherwise not. Host generally uses "cpu-features", > which masks "pa-features". But "cp

Re: [PATCH v2] powerpc/powernv/pci: use ifdef to avoid dead code

2020-07-19 Thread Oliver O'Halloran
On Sun, Jul 19, 2020 at 5:13 AM Greg Thelen wrote: > > Oliver O'Halloran wrote: > > > On Mon, Jun 15, 2020 at 9:33 AM Greg Thelen wrote: > >> > >> Commit dc3d8f85bb57 ("powerpc/powernv/pci: Re-work bus PE > >> configuration") removed a couple pnv_ioda_setup_bus_dma() calls. The > >> only remain

io_uring kthread_use_mm / mmget_not_zero possible abuse

2020-07-19 Thread Nicholas Piggin
When I last looked at this (predating io_uring), as far as I remember it was not permitted to actually switch to (use_mm) an mm user context that was pinned with mmget_not_zero. Those pins were only allowed to look at page tables, vmas, etc., but not actually run the CPU in that mm context. spa

Re: [PATCH v3 3/3] powerpc/powernv/idle: Exclude mfspr on HID1, 4, 5 on P9 and above

2020-07-19 Thread Nicholas Piggin
Excerpts from Pratik Rajesh Sampat's message of July 18, 2020 4:53 am: > POWER9 onwards the support for the registers HID1, HID4, HID5 has been > receded. > Although mfspr on the above registers worked in Power9, In Power10 > simulator is unrecognized. Moving their assignment under the > check for

Re: [PATCH v3 1/3] powerpc/powernv/idle: Replace CPU features checks with PVR checks

2020-07-19 Thread Nicholas Piggin
Excerpts from Pratik Rajesh Sampat's message of July 18, 2020 4:53 am: > As the idle framework's architecture is incomplete, hence instead of > checking for just the processor type advertised in the device tree CPU > features; check for the Processor Version Register (PVR) so that finer > granulari

Re: [PATCH v3 2/3] powerpc/powernv/idle: Rename pnv_first_spr_loss_level variable

2020-07-19 Thread Nicholas Piggin
Excerpts from Pratik Rajesh Sampat's message of July 18, 2020 4:53 am: > Replace the variable name from using "pnv_first_spr_loss_level" to > "pnv_first_fullstate_loss_level". > > As pnv_first_spr_loss_level is supposed to be the earliest state that > has OPAL_PM_LOSE_FULL_CONTEXT set, however as

Re: [v3 12/15] powerpc/perf: Add support for outputting extended regs in perf intr_regs

2020-07-19 Thread kernel test robot
onfig-r024-20200719 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ed6b578040a85977026c93bf4188f996148f3218) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross

[powerpc:next-test] BUILD SUCCESS 5fed3b3e21db21f9a7002426f456fd3a8a8c0772

2020-07-19 Thread kernel test robot
-20200717 i386 randconfig-a004-20200717 i386 randconfig-a001-20200719 i386 randconfig-a006-20200719 i386 randconfig-a002-20200719 i386 randconfig-a005-20200719 i386 randconfig-a003-20200719 i386