Re: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and simplifications

2020-12-09 Thread Rasmus Villemoes
On 05/12/2020 22.27, Jakub Kicinski wrote: > On Sat, 5 Dec 2020 22:11:39 +0100 Rasmus Villemoes wrote: >>> Looks like a nice clean up on a quick look. >>> >>> Please separate patches 1 and 11 (which are the two bug fixes I see) >> >> I think patch 2 is a bug fix as well, but I'd like someone from

Re: [PATCH v2 4/5] powerpc/smp: Add support detecting thread-groups sharing L2 cache

2020-12-09 Thread kernel test robot
Hi "Gautham, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on v5.10-rc7 next-20201209] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '

Re: [PATCH v1 1/2] KVM: PPC: Book3S HV: Add support for H_RPT_INVALIDATE (nested case only)

2020-12-09 Thread Bharata B Rao
On Wed, Dec 09, 2020 at 03:15:42PM +1100, Paul Mackerras wrote: > On Mon, Oct 19, 2020 at 04:56:41PM +0530, Bharata B Rao wrote: > > Implements H_RPT_INVALIDATE hcall and supports only nested case > > currently. > > > > A KVM capability KVM_CAP_RPT_INVALIDATE is added to indicate the > > support f

Re: [PATCH v5 12/19] dt-bindings: usb: dwc3: Add synopsys, dwc3 compatible string

2020-12-09 Thread Rob Herring
On Sat, 05 Dec 2020 18:24:19 +0300, Serge Semin wrote: > The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc > expects the DWC USB3 DT node to have the compatible string with the > "synopsys" vendor prefix. Let's add the corresponding compatible string to > the controller DT

Re: [PATCH v5 01/19] dt-bindings: usb: usb-hcd: Detach generic USB controller properties

2020-12-09 Thread Rob Herring
On Sat, 05 Dec 2020 18:24:08 +0300, Serge Semin wrote: > There can be three distinctive types of the USB controllers: USB hosts, > USB peripherals/gadgets and USB OTG, which can switch from one role to > another. In order to have that hierarchy handled in the DT binding files, > we need to collect

Re: [PATCH 07/20] ethernet: ucc_geth: use qe_muram_free_addr()

2020-12-09 Thread Andrew Lunn
On Sat, Dec 05, 2020 at 08:17:30PM +0100, Rasmus Villemoes wrote: > This removes the explicit NULL checks, and allows us to stop storing > at least some of the _offset values separately. > > Signed-off-by: Rasmus Villemoes This seems to rely on one of the missing patches. Please don't split patc

Re: [PATCH 01/20] ethernet: ucc_geth: set dev->max_mtu to 1518

2020-12-09 Thread Andrew Lunn
On Sat, Dec 05, 2020 at 08:17:24PM +0100, Rasmus Villemoes wrote: > All the buffers and registers are already set up appropriately for an > MTU slightly above 1500, so we just need to expose this to the > networking stack. AFAICT, there's no need to implement .ndo_change_mtu > when the receive buff

Re: [PATCH v2 4/5] powerpc/smp: Add support detecting thread-groups sharing L2 cache

2020-12-09 Thread kernel test robot
Hi "Gautham, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.10-rc7 next-20201209] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base'

Re: [PATCH v2] powerpc/mm: Fix KUAP warning by providing copy_from_kernel_nofault_allowed()

2020-12-09 Thread Michael Ellerman
On Mon, 7 Dec 2020 16:58:01 + (UTC), Christophe Leroy wrote: > Since commit c33165253492 ("powerpc: use non-set_fs based maccess > routines"), userspace access is not granted anymore when using > copy_from_kernel_nofault() > > However, kthread_probe_data() uses copy_from_kernel_nofault() > to

Re: [PATCH v1 2/6] powerpc/8xx: Always pin kernel text TLB

2020-12-09 Thread Michael Ellerman
Christophe Leroy writes: > Le 09/12/2020 à 11:43, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> There is no big poing in not pinning kernel text anymore, as now >>> we can keep pinned TLB even with things like DEBUG_PAGEALLOC. >>> >>> Remove CONFIG_PIN_TLB_TEXT, making it always righ

Re: linux-next: build warning after merge of the akpm tree

2020-12-09 Thread Michael Ellerman
Stephen Rothwell writes: > Hi Michael, > > On Wed, 09 Dec 2020 15:44:35 +1100 Michael Ellerman > wrote: >> >> They should really be in DATA_DATA or similar shouldn't they? > > No other architecture appears t need them ... Any arch with orphan-handling=warn should see them I thought? cheers

Re: [PATCH v2 5/5] powerpc/cacheinfo: Print correct cache-sibling map/list for L2 cache

2020-12-09 Thread kernel test robot
Hi "Gautham, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on v5.10-rc7 next-20201209] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Bjorn Helgaas
On Wed, Dec 09, 2020 at 11:43:59PM +0200, Vladimir Oltean wrote: > On Wed, Dec 09, 2020 at 03:34:49PM -0600, Bjorn Helgaas wrote: > > On Wed, Dec 09, 2020 at 11:20:17PM +0200, Vladimir Oltean wrote: > > > On Wed, Dec 09, 2020 at 02:59:13PM -0600, Bjorn Helgaas wrote: > > > > Yep, that's the theory.

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Vladimir Oltean
On Wed, Dec 09, 2020 at 03:34:49PM -0600, Bjorn Helgaas wrote: > On Wed, Dec 09, 2020 at 11:20:17PM +0200, Vladimir Oltean wrote: > > On Wed, Dec 09, 2020 at 02:59:13PM -0600, Bjorn Helgaas wrote: > > > Yep, that's the theory. Thanks for testing it! > > > > Testing what? I'm not following. > > You

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Bjorn Helgaas
On Wed, Dec 09, 2020 at 11:20:17PM +0200, Vladimir Oltean wrote: > On Wed, Dec 09, 2020 at 02:59:13PM -0600, Bjorn Helgaas wrote: > > Yep, that's the theory. Thanks for testing it! > > Testing what? I'm not following. You posted a patch that you said fixed the bug for you. The fix is exactly th

Re: [RESEND v1 5/5] powerpc/platforms: Move files from 4xx to 44x

2020-12-09 Thread kernel test robot
Hi Christophe, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on next-20201209] [cannot apply to robh/for-next linus/master mpe/next v5.10-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Vladimir Oltean
On Wed, Dec 09, 2020 at 02:59:13PM -0600, Bjorn Helgaas wrote: > Yep, that's the theory. Thanks for testing it! Testing what? I'm not following.

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Bjorn Helgaas
On Wed, Dec 09, 2020 at 10:29:04PM +0200, Vladimir Oltean wrote: > On Wed, Dec 09, 2020 at 04:40:52PM +0100, Michael Walle wrote: > > Hopefully my mail client won't mess up the output that much. > > I can reproduce on my LS1028A as well. The following fixes the bug for > me. I did not follow the d

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Vladimir Oltean
On Wed, Dec 09, 2020 at 04:40:52PM +0100, Michael Walle wrote: > Hopefully my mail client won't mess up the output that much. I can reproduce on my LS1028A as well. The following fixes the bug for me. I did not follow the discussion and see if it is helpful for others. I don't understand how the b

Re: linux-next: build warning after merge of the akpm tree

2020-12-09 Thread Kees Cook
On Tue, Dec 08, 2020 at 11:01:57PM +1100, Stephen Rothwell wrote: > Hi Stephen, > > On Fri, 4 Dec 2020 21:00:00 +1100 Stephen Rothwell > wrote: > > > > Hi all, > > > > After merging the akpm tree, today's linux-next build (powerpc > > allyesconfig) produced warnings like this: > > > > ld: warn

[PATCH v2 2/5] powerpc/smp: Rename cpu_l1_cache_map as thread_group_l1_cache_map

2020-12-09 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" On platforms which have the "ibm,thread-groups" property, the per-cpu variable cpu_l1_cache_map keeps a track of which group of threads within the same core share the L1 cache, Instruction and Data flow. This patch renames the variable to "thread_group_l1_cache_map" to

[PATCH v2 1/5] powerpc/smp: Parse ibm, thread-groups with multiple properties

2020-12-09 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" The "ibm,thread-groups" device-tree property is an array that is used to indicate if groups of threads within a core share certain properties. It provides details of which property is being shared by which groups of threads. This array can encode information about multip

[PATCH v2 4/5] powerpc/smp: Add support detecting thread-groups sharing L2 cache

2020-12-09 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" On POWER systems, groups of threads within a core sharing the L2-cache can be indicated by the "ibm,thread-groups" property array with the identifier "2". This patch adds support for detecting this, and when present, populate the populating the cpu_l2_cache_mask of ever

[PATCH v2 5/5] powerpc/cacheinfo: Print correct cache-sibling map/list for L2 cache

2020-12-09 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" On POWER platforms where only some groups of threads within a core share the L2-cache (indicated by the ibm,thread-groups device-tree property), we currently print the incorrect shared_cpu_map/list for L2-cache in the sysfs. This patch reports the correct shared_cpu_map

[PATCH v2 0/5] Extend Parsing "ibm, thread-groups" for Shared-L2 information

2020-12-09 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" Hi, This is the v2 of the patchset to extend parsing of "ibm,thread-groups" property to discover the Shared-L2 cache information. The v1 can be found here : https://lore.kernel.org/linuxppc-dev/1607057327-29822-1-git-send-email-...@linux.vnet.ibm.com/T/#m0fabffa1ea1a28

[PATCH v2 3/5] powerpc/smp: Rename init_thread_group_l1_cache_map() to make it generic

2020-12-09 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" init_thread_group_l1_cache_map() initializes the per-cpu cpumask thread_group_l1_cache_map with the core-siblings which share L1 cache with the CPU. Make this function generic to the cache-property (L1 or L2) and update a suitable mask. This is a preparatory patch for th

Re: [PATCH 04/13] powerpc/xive: Use cpu_to_node() instead of ibm, chip-id property

2020-12-09 Thread Cédric Le Goater
On 12/9/20 5:39 AM, Aneesh Kumar K.V wrote: > Cédric Le Goater writes: > >> The 'chip_id' field of the XIVE CPU structure is used to choose a >> target for a source located on the same chip when possible. This field >> is assigned on the PowerNV platform using the "ibm,chip-id" property >> on pSe

Re: [PATCH 07/13] powerpc/xive: Add a debug_show handler to the XIVE irq_domain

2020-12-09 Thread Cédric Le Goater
On 12/9/20 4:50 PM, Greg Kurz wrote: > On Tue, 8 Dec 2020 16:11:18 +0100 > Cédric Le Goater wrote: > >> Full state of the Linux interrupt descriptors can be dumped under >> debugfs when compiled with CONFIG_GENERIC_IRQ_DEBUGFS. Add support for >> the XIVE interrupt controller. >> >> Signed-off-by

Re: [PATCH 12/13] powerpc/xive: Simplify xive_do_source_eoi()

2020-12-09 Thread Greg Kurz
On Tue, 8 Dec 2020 16:11:23 +0100 Cédric Le Goater wrote: > Previous patches removed the need of the first argument which was a > hack for Firwmware EOI. Remove it and flatten the routine which has > became simpler. > > Signed-off-by: Cédric Le Goater > --- Much nicer indeed. Reviewed-by: Gre

Re: [PATCH 07/13] powerpc/xive: Add a debug_show handler to the XIVE irq_domain

2020-12-09 Thread Greg Kurz
On Tue, 8 Dec 2020 16:11:18 +0100 Cédric Le Goater wrote: > Full state of the Linux interrupt descriptors can be dumped under > debugfs when compiled with CONFIG_GENERIC_IRQ_DEBUGFS. Add support for > the XIVE interrupt controller. > > Signed-off-by: Cédric Le Goater > --- > arch/powerpc/sysde

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Michael Walle
Am 2020-12-09 15:57, schrieb Bjorn Helgaas: [..] Can you try the following just to get started? diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 46935695cfb9..569a45727bc7 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -79,6 +79,7 @@ int pci_generic_config_read(str

Re: [PATCH 13/13] powerpc/xive: Improve error reporting of OPAL calls

2020-12-09 Thread Greg Kurz
On Tue, 8 Dec 2020 16:11:24 +0100 Cédric Le Goater wrote: > Introduce a vp_err() macro to standardize error reporting. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > arch/powerpc/sysdev/xive/native.c | 28 > 1 file changed, 16 insertions(+),

Re: [PATCH 11/13] powerpc/xive: Remove P9 DD1 flag XIVE_IRQ_FLAG_EOI_FW

2020-12-09 Thread Greg Kurz
On Tue, 8 Dec 2020 16:11:22 +0100 Cédric Le Goater wrote: > This flag was used to support the P9 DD1 and we have stopped > supporting this CPU when DD2 came out. See skiboot commit: > > https://github.com/open-power/skiboot/commit/0b0d15e3c170 > > Also, remove eoi handler which is now unused.

Re: [PATCH 10/13] powerpc/xive: Remove P9 DD1 flag XIVE_IRQ_FLAG_MASK_FW

2020-12-09 Thread Greg Kurz
On Tue, 8 Dec 2020 16:11:21 +0100 Cédric Le Goater wrote: > This flag was used to support the PHB4 LSIs on P9 DD1 and we have > stopped supporting this CPU when DD2 came out. See skiboot commit: > > https://github.com/open-power/skiboot/commit/0b0d15e3c170 > > Signed-off-by: Cédric Le Goater

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Bjorn Helgaas
On Wed, Dec 09, 2020 at 02:08:00PM +0100, Michael Walle wrote: > [+ Vladimir and Alex] > > Am 2020-12-09 13:36, schrieb Bjorn Helgaas: > > On Tue, Dec 08, 2020 at 04:41:50PM +0100, Michael Walle wrote: > > > >On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: > > > >> Unify ECAM-relat

Re: [PATCH v2 1/4] KVM: PPC: Allow nested guest creation when L0 hv_guest_state > L1

2020-12-09 Thread Fabiano Rosas
Ravi Bangoria writes: > On powerpc, L1 hypervisor takes help of L0 using H_ENTER_NESTED > hcall to load L2 guest state in cpu. L1 hypervisor prepares the > L2 state in struct hv_guest_state and passes a pointer to it via > hcall. Using that pointer, L0 reads/writes that state directly > from/to L

[RESEND v1 3/5] powerpc: Remove support for 40x

2020-12-09 Thread Christophe Leroy
Now that 40x platforms have gone, remove support for 40x in the core of powerpc arch. Signed-off-by: Christophe Leroy --- arch/powerpc/Kconfig | 8 +- arch/powerpc/Kconfig.debug | 13 - arch/powerpc/Makefile| 1 - arch/powerp

[RESEND v1 4/5] powerpc/4xx: Remove CONFIG_4xx

2020-12-09 Thread Christophe Leroy
CONFIG_4xx was corresponding to CONFIG_40x | CONFIG_44x. As CONFIG_40x is gone, CONFIG_4xx and CONFIG_44x are now equivalent. And CONFIG_BOOKE is also set when CONFIG_44x is set. Replace (CONFIG_4xx | CONFIG_BOOKE) by CONFIG_BOOKE Replace other CONFIG_4xx by CONFIG_44x Remove CONFIG_4xx. Signed-

[RESEND v1 5/5] powerpc/platforms: Move files from 4xx to 44x

2020-12-09 Thread Christophe Leroy
Only 44x uses 4xx now, so only keep one directory. Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/44x/Makefile | 9 +++- arch/powerpc/platforms/{4xx => 44x}/cpm.c | 0 arch/powerpc/platforms/{4xx => 44x}/gpio.c| 0 .../powerpc/platforms/{4xx => 44x}/hsta_msi.

[RESEND v1 1/5] powerpc/40x: Remove 40x platforms.

2020-12-09 Thread Christophe Leroy
40x platforms have been orphaned for many years. Remove them. Signed-off-by: Christophe Leroy --- Resend with correct Author --- MAINTAINERS | 1 - arch/powerpc/configs/40x/acadia_defconfig | 61 arch/powerpc/configs/40x/kilauea_defconfig | 6

[RESEND v1 2/5] powerpc/boot: Remove all 40x platforms

2020-12-09 Thread Christophe Leroy
Remove 40x platforms from the boot directory. Signed-off-by: Christophe Leroy --- arch/powerpc/boot/4xx.c | 266 - arch/powerpc/boot/4xx.h | 4 - arch/powerpc/boot/Makefile | 11 - arch/powerpc/boot/cuboot-acadia.c | 171 --- arch/pow

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Michael Walle
[+ Vladimir and Alex] Am 2020-12-09 13:36, schrieb Bjorn Helgaas: On Tue, Dec 08, 2020 at 04:41:50PM +0100, Michael Walle wrote: >On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: >> Unify ECAM-related constants into a single set of standard constants >> defining memory address sh

[PATCH v1 4/5] powerpc/4xx: Remove CONFIG_4xx

2020-12-09 Thread Christophe Leroy
From: Christophe Leroy CONFIG_4xx was corresponding to CONFIG_40x | CONFIG_44x. As CONFIG_40x is gone, CONFIG_4xx and CONFIG_44x are now equivalent. And CONFIG_BOOKE is also set when CONFIG_44x is set. Replace (CONFIG_4xx | CONFIG_BOOKE) by CONFIG_BOOKE Replace other CONFIG_4xx by CONFIG_44x Re

[PATCH v1 1/5] powerpc/40x: Remove 40x platforms.

2020-12-09 Thread Christophe Leroy
From: Christophe Leroy 40x platforms have been orphaned for many years. Remove them. Signed-off-by: Christophe Leroy --- MAINTAINERS | 1 - arch/powerpc/configs/40x/acadia_defconfig | 61 arch/powerpc/configs/40x/kilauea_defconfig | 69

[PATCH v1 5/5] powerpc/platforms: Move files from 4xx to 44x

2020-12-09 Thread Christophe Leroy
From: Christophe Leroy Only 44x uses 4xx now, so only keep one directory. Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/44x/Makefile | 9 +++- arch/powerpc/platforms/{4xx => 44x}/cpm.c | 0 arch/powerpc/platforms/{4xx => 44x}/gpio.c| 0 .../powerpc/platfor

[PATCH v1 3/5] powerpc: Remove support for 40x

2020-12-09 Thread Christophe Leroy
From: Christophe Leroy Now that 40x platforms have gone, remove support for 40x in the core of powerpc arch. Signed-off-by: Christophe Leroy --- arch/powerpc/Kconfig | 8 +- arch/powerpc/Kconfig.debug | 13 - arch/powerpc/Makefile

[PATCH v1 2/5] powerpc/boot: Remove all 40x platforms

2020-12-09 Thread Christophe Leroy
From: Christophe Leroy Remove 40x platforms from the boot directory. Signed-off-by: Christophe Leroy --- arch/powerpc/boot/4xx.c | 266 - arch/powerpc/boot/4xx.h | 4 - arch/powerpc/boot/Makefile | 11 - arch/powerpc/boot/cuboot-acadia.c |

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Bjorn Helgaas
On Tue, Dec 08, 2020 at 04:41:50PM +0100, Michael Walle wrote: > >On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: > >> Unify ECAM-related constants into a single set of standard constants > >> defining memory address shift values for the byte-level address that can > >> be used when

Re: [PATCH v1 2/6] powerpc/8xx: Always pin kernel text TLB

2020-12-09 Thread Christophe Leroy
Le 09/12/2020 à 11:43, Michael Ellerman a écrit : Christophe Leroy writes: There is no big poing in not pinning kernel text anymore, as now we can keep pinned TLB even with things like DEBUG_PAGEALLOC. Remove CONFIG_PIN_TLB_TEXT, making it always right. Signed-off-by: Christophe Leroy ---

Re: [PATCH] drivers: usb: gadget: prefer pr_*() functions over raw printk()

2020-12-09 Thread Laurent Pinchart
Hi Enrico, On Wed, Dec 09, 2020 at 12:11:36PM +0100, Enrico Weigelt, metux IT consult wrote: > On 08.12.20 16:54, Laurent Pinchart wrote: > >> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c > >> b/drivers/usb/gadget/udc/atmel_usba_udc.c > >> index 2b893bceea45..4834fafb3f70 100644 > >> ---

Re: [PATCH] drivers: usb: gadget: prefer pr_*() functions over raw printk()

2020-12-09 Thread Enrico Weigelt, metux IT consult
On 08.12.20 16:54, Laurent Pinchart wrote: Hi, >> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c >> b/drivers/usb/gadget/udc/atmel_usba_udc.c >> index 2b893bceea45..4834fafb3f70 100644 >> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c >> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c >> @@ -

Re: [PATCH v1 2/6] powerpc/8xx: Always pin kernel text TLB

2020-12-09 Thread Michael Ellerman
Christophe Leroy writes: > There is no big poing in not pinning kernel text anymore, as now > we can keep pinned TLB even with things like DEBUG_PAGEALLOC. > > Remove CONFIG_PIN_TLB_TEXT, making it always right. > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/Kconfig | 3

Re: linux-next: build warning after merge of the akpm tree

2020-12-09 Thread Stephen Rothwell
Hi all, On Tue, 8 Dec 2020 23:01:57 +1100 Stephen Rothwell wrote: > > I will try the following patch tomorrow: > > From: Stephen Rothwell > Date: Tue, 8 Dec 2020 22:58:24 +1100 > Subject: [PATCH] powerpc: Add .data..Lubsan_data*/.data..Lubsan_type* > sections explicitly > > Similarly to comm

Re: [PATCH 2/3] powerpc/smp: Add support detecting thread-groups sharing L2 cache

2020-12-09 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-12-08 23:12:37]: > > > For L2 we have thread_group_l2_cache_map to store the tasks from the thread > > group. but cpu_l2_cache_map for keeping track of tasks. > > > > > I think we should do some renaming to keep the names consistent. > > I would say probably say move

Re: [PATCH 3/3] powerpc/cacheinfo: Print correct cache-sibling map/list for L2 cache

2020-12-09 Thread Gautham R Shenoy
On Wed, Dec 09, 2020 at 02:09:21PM +0530, Srikar Dronamraju wrote: > * Gautham R Shenoy [2020-12-08 23:26:47]: > > > > The drawback of this is even if cpus 0,2,4,6 are released L1 cache will > > > not > > > be released. Is this as expected? > > > > cacheinfo populates the cache->shared_cpu_map

Re: [PATCH 1/3] powerpc/smp: Parse ibm,thread-groups with multiple properties

2020-12-09 Thread Gautham R Shenoy
On Wed, Dec 09, 2020 at 02:05:41PM +0530, Srikar Dronamraju wrote: > * Gautham R Shenoy [2020-12-08 22:55:40]: > > > > > > > NIT: > > > tglx mentions in one of his recent comments to try keep a reverse fir tree > > > ordering of variables where possible. > > > > I suppose you mean moving the lo

Re: [PATCH 3/3] powerpc/cacheinfo: Print correct cache-sibling map/list for L2 cache

2020-12-09 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-12-08 23:26:47]: > > The drawback of this is even if cpus 0,2,4,6 are released L1 cache will not > > be released. Is this as expected? > > cacheinfo populates the cache->shared_cpu_map on the basis of which > CPUs share the common device-tree node for a particular cache.

Re: [PATCH 1/3] powerpc/smp: Parse ibm,thread-groups with multiple properties

2020-12-09 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-12-08 22:55:40]: > > > > NIT: > > tglx mentions in one of his recent comments to try keep a reverse fir tree > > ordering of variables where possible. > > I suppose you mean moving the longer local variable declarations to to > the top and shorter ones to the bottom. Th