Re: [PATCH 1/5] CMDLINE: add generic builtin command line

2021-03-03 Thread Christophe Leroy
Le 04/03/2021 à 05:47, Daniel Walker a écrit : This code allows architectures to use a generic builtin command line. The state of the builtin command line options across architecture is diverse. On x86 and mips they have pretty much the same code and the code prepends the builtin command line

Re: [PATCH v3] powerpc/uprobes: Validation for prefixed instruction

2021-03-03 Thread Ravi Bangoria
@@ -41,6 +41,14 @@ int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe, if (addr & 0x03) return -EINVAL; + if (!IS_ENABLED(CONFIG_PPC64) || !cpu_has_feature(CPU_FTR_ARCH_31)) + return 0; Sorry, I missed this last time, but I think we can drop

Re: [PATCH 3/5] CMDLINE: powerpc: convert to generic builtin command line

2021-03-03 Thread Christophe Leroy
Le 04/03/2021 à 05:48, Daniel Walker a écrit : This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE option. CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #143: FILE: arch/powerpc/kernel/prom_init.c:788: +

Re: [PATCH 3/5] CMDLINE: powerpc: convert to generic builtin command line

2021-03-03 Thread Christophe Leroy
Le 04/03/2021 à 05:48, Daniel Walker a écrit : This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE option. In file included from arch/powerpc/kernel/prom_init.c:30: arch/powerpc/kernel/prom_init.c: In function 'early_cmdline_parse': arch/powerpc/kernel/prom_init.c:788:17: error:

Re: [PATCH v3] powerpc/uprobes: Validation for prefixed instruction

2021-03-03 Thread Christophe Leroy
Le 04/03/2021 à 06:05, Ravi Bangoria a écrit : As per ISA 3.1, prefixed instruction should not cross 64-byte boundary. So don't allow Uprobe on such prefixed instruction. There are two ways probed instruction is changed in mapped pages. First, when Uprobe is activated, it searches for all

Re: [PATCH 3/5] CMDLINE: powerpc: convert to generic builtin command line

2021-03-03 Thread Christophe Leroy
Le 04/03/2021 à 05:48, Daniel Walker a écrit : This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE option. Should be split in two patches. The change of strcpy to strlcpy should go in a first patch. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko

Re: [PATCH 2/5] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-03 Thread Christophe Leroy
Le 04/03/2021 à 05:47, Daniel Walker a écrit : It looks like there's some seepage of cmdline stuff into the generic device tree code. This conflicts with the generic cmdline implementation so I remove it in the case when that's enabled. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan

Re: [PATCH 1/5] CMDLINE: add generic builtin command line

2021-03-03 Thread Christophe Leroy
Le 04/03/2021 à 05:47, Daniel Walker a écrit : This code allows architectures to use a generic builtin command line. The state of the builtin command line options across architecture is diverse. On x86 and mips they have pretty much the same code and the code prepends the builtin command line

Re: [PATCH v5 2/3] KVM: PPC: Book3S HV: Add support for H_RPT_INVALIDATE

2021-03-03 Thread David Gibson
On Tue, Mar 02, 2021 at 10:28:53AM +0530, Bharata B Rao wrote: > On Tue, Mar 02, 2021 at 12:45:18PM +1100, David Gibson wrote: > > > diff --git a/Documentation/virt/kvm/api.rst > > > b/Documentation/virt/kvm/api.rst > > > index 45fd862ac128..38ce3f21b21f 100644 > > > ---

Re: [PATCH v5 1/3] powerpc/book3s64/radix: Add H_RPT_INVALIDATE pgsize encodings to mmu_psize_def

2021-03-03 Thread David Gibson
On Tue, Mar 02, 2021 at 09:51:28AM +0530, Bharata B Rao wrote: > On Tue, Mar 02, 2021 at 12:28:34PM +1100, David Gibson wrote: > > On Wed, Feb 24, 2021 at 01:55:08PM +0530, Bharata B Rao wrote: > > > Add a field to mmu_psize_def to store the page size encodings > > > of H_RPT_INVALIDATE hcall.

Re: [PATCH] crypto: sha: remove unneeded semicolon

2021-03-03 Thread Herbert Xu
On Mon, Feb 08, 2021 at 05:10:38PM +0800, Yang Li wrote: > Eliminate the following coccicheck warning: > ./arch/powerpc/crypto/sha1-spe-glue.c:110:2-3: Unneeded semicolon > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > arch/powerpc/crypto/sha1-spe-glue.c | 2 +- > 1 file changed,

Re: [PATCH v2] crypto/nx: add missing call to of_node_put()

2021-03-03 Thread Herbert Xu
On Fri, Feb 26, 2021 at 09:23:06AM +0800, Yang Li wrote: > In one of the error paths of the for_each_child_of_node() loop, > add missing call to of_node_put(). > > Fix the following coccicheck warning: > ./drivers/crypto/nx/nx-common-powernv.c:927:1-23: WARNING: Function >

[PATCH] powerpc/perf: Fix the threshold event selection for memory events in power10

2021-03-03 Thread Athira Rajeev
Memory events (mem-loads and mem-stores) currently use the threshold event selection as issue to finish. Power10 supports issue to complete as part of thresholding which is more appropriate for mem-loads and mem-stores. Hence fix the event code for memory events to use issue to complete. Fixes:

Re: [PATCH v3 1/2] powerpc/perf: Use PVR rather than oprofile field to determine CPU version

2021-03-03 Thread Athira Rajeev
> On 01-Mar-2021, at 5:39 PM, Christophe Leroy > wrote: > > From: Rashmica Gupta > > Currently the perf CPU backend drivers detect what CPU they're on using > cur_cpu_spec->oprofile_cpu_type. > > Although that works, it's a bit crufty to be using oprofile related fields, > especially

Re: [PATCH v3] powerpc/uprobes: Validation for prefixed instruction

2021-03-03 Thread Naveen N. Rao
On 2021/03/04 10:35AM, Ravi Bangoria wrote: > As per ISA 3.1, prefixed instruction should not cross 64-byte > boundary. So don't allow Uprobe on such prefixed instruction. > > There are two ways probed instruction is changed in mapped pages. > First, when Uprobe is activated, it searches for all

Re: [PATCH v5 0/5] ibmvfc: hard reset fixes

2021-03-03 Thread Martin K. Petersen
On Tue, 2 Mar 2021 17:05:38 -0600, Tyrel Datwyler wrote: > This series contains a minor simplification of ibmvfc_init_sub_crqs() followed > by a couple fixes for sub-CRQ handling which effect hard reset of the > client/host adapter CRQ pair. > > changes in v5: > Patches 2-5: Corrected upstream

[PATCH v3] powerpc/uprobes: Validation for prefixed instruction

2021-03-03 Thread Ravi Bangoria
As per ISA 3.1, prefixed instruction should not cross 64-byte boundary. So don't allow Uprobe on such prefixed instruction. There are two ways probed instruction is changed in mapped pages. First, when Uprobe is activated, it searches for all the relevant pages and replace instruction in them. In

Re: [PATCH v3 1/2] powerpc/perf: Use PVR rather than oprofile field to determine CPU version

2021-03-03 Thread kajoljain
On 3/1/21 5:39 PM, Christophe Leroy wrote: > From: Rashmica Gupta > > Currently the perf CPU backend drivers detect what CPU they're on using > cur_cpu_spec->oprofile_cpu_type. > > Although that works, it's a bit crufty to be using oprofile related fields, > especially seeing as oprofile is

[PATCH] arch:powerpc:kernel: remove duplicate include in traps.c

2021-03-03 Thread menglong8 . dong
From: Zhang Yunkai 'asm/tm.h' included in 'traps.c' is duplicated. It is also included in the 62th line. Signed-off-by: Zhang Yunkai --- arch/powerpc/kernel/traps.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c index

[PATCH 5/5] CMDLINE: x86: convert to generic builtin command line

2021-03-03 Thread Daniel Walker
This updates the x86 code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/x86/Kconfig| 44 + arch/x86/kernel/setup.c

[PATCH 1/5] CMDLINE: add generic builtin command line

2021-03-03 Thread Daniel Walker
This code allows architectures to use a generic builtin command line. The state of the builtin command line options across architecture is diverse. On x86 and mips they have pretty much the same code and the code prepends the builtin command line onto the boot loader provided one. On powerpc there

[PATCH 2/5] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-03 Thread Daniel Walker
It looks like there's some seepage of cmdline stuff into the generic device tree code. This conflicts with the generic cmdline implementation so I remove it in the case when that's enabled. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Daniel Walker ---

[PATCH 3/5] CMDLINE: powerpc: convert to generic builtin command line

2021-03-03 Thread Daniel Walker
This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/powerpc/Kconfig| 37 +

[PATCH 4/5] CMDLINE: mips: convert to generic builtin command line

2021-03-03 Thread Daniel Walker
This updates the mips code to use the CONFIG_GENERIC_CMDLINE option. This deletes the option for MIPS_CMDLINE_BUILTIN_EXTEND and replaces the functionality with generic code. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel

[PATCH] arch:powerpc:kernel: remove duplicate include in setup-common

2021-03-03 Thread menglong8 . dong
From: Zhang Yunkai 'asm/udbg.h' included in 'setup-common.c' is duplicated. It is also included in the 61th line. Signed-off-by: Zhang Yunkai --- arch/powerpc/kernel/setup-common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kernel/setup-common.c

Re: [PATCH V2] mm: Generalize HUGETLB_PAGE_SIZE_VARIABLE

2021-03-03 Thread Anshuman Khandual
On 3/2/21 10:43 AM, Anshuman Khandual wrote: > HUGETLB_PAGE_SIZE_VARIABLE need not be defined for each individual > platform subscribing it. Instead just make it generic. > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Andrew Morton > Cc: Christoph Hellwig

[PATCH] arch/powerpc/include: remove duplicate include in thread_info.h

2021-03-03 Thread menglong8 . dong
From: Zhang Yunkai 'asm/page.h' included in 'arch/powerpc/include/asm/thread_info.h' is duplicated.It is also included in 13th line. Signed-off-by: Zhang Yunkai --- arch/powerpc/include/asm/thread_info.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/include/asm/thread_info.h

[PATCH] arch/powerpc/include: remove duplicate include in pgtable.h

2021-03-03 Thread menglong8 . dong
From: Zhang Yunkai 'asm/tlbflush.h' included in 'arch/powerpc/include/asm/pgtable.h' is duplicated.It is also included in the 11th line. Signed-off-by: Zhang Yunkai --- arch/powerpc/include/asm/pgtable.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/include/asm/pgtable.h

[PATCH] arch/powerpc/include:fix misspellings in tlbflush.h

2021-03-03 Thread menglong8 . dong
From: Zhang Yunkai Some typos are found out.The information at the end of the file does not match the beginning. Signed-off-by: Zhang Yunkai --- arch/powerpc/include/asm/book3s/32/tlbflush.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] arch/powerpc/include/asm/book3s/64/: remove duplicate include in mmu-hash.h

2021-03-03 Thread menglong8 . dong
From: Zhang Yunkai 'asm/bug.h' included in 'arch/powerpc/include/asm/book3s/64/mmu-hash.h' is duplicated.It is also included in the 12th line. Signed-off-by: Zhang Yunkai --- arch/powerpc/include/asm/book3s/64/mmu-hash.h | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH][next] ASoC: fsl: fsl_easrc: Fix uninitialized variable st2_mem_alloc

2021-03-03 Thread Mark Brown
On Wed, 3 Mar 2021 09:18:35 +, Colin King wrote: > A previous cleanup commit removed the ininitialization of st2_mem_alloc. > Fix this by restoring the original behaviour by initializing it to zero. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Re: [PATCH] powerpc: remove redundant space

2021-03-03 Thread Christophe Leroy
maqiang a écrit : These one line of code don't meet the kernel coding style, so remove the redundant space. There seems to be several other style issues in this function and in the following one too. You should fix them all at once I think. Signed-off-by: maqiang ---

[Bug 210749] sysfs: cannot create duplicate filename '/bus/nvmem/devices/module-vpd'

2021-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210749 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #294195|0 |1 is obsolete|

[Bug 210749] sysfs: cannot create duplicate filename '/bus/nvmem/devices/module-vpd'

2021-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210749 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #294193|0 |1 is obsolete|

[PATCH] powerpc: remove redundant space

2021-03-03 Thread maqiang
These one line of code don't meet the kernel coding style, so remove the redundant space. Signed-off-by: maqiang --- arch/powerpc/kernel/syscalls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c index

[Bug 206203] kmemleak reports various leaks in drivers/of/unittest.c

2021-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206203 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH v2 34/37] KVM: PPC: Book3S HV: add virtual mode handlers for HPT hcalls and page faults

2021-03-03 Thread Fabiano Rosas
Nicholas Piggin writes: > In order to support hash guests in the P9 path (which does not do real > mode hcalls or page fault handling), these real-mode hash specific > interrupts need to be implemented in virt mode. > > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/kvm/book3s_hv.c | 118

Re: [PATCH next v4 00/15] printk: remove logbuf_lock

2021-03-03 Thread Petr Mladek
On Wed 2021-03-03 11:15:13, John Ogness wrote: > Hello, > > Here is v4 of a series to remove @logbuf_lock, exposing the > ringbuffer locklessly to both readers and writers. v3 is > here [0]. The series look ready. I am going to push it into printk/linux.git the following week unless anyone

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-03 Thread Marco Elver
On Wed, Mar 03, 2021 at 03:52PM +0100, Christophe Leroy wrote: > Le 03/03/2021 à 15:38, Marco Elver a écrit : > > On Wed, 3 Mar 2021 at 15:09, Christophe Leroy > > wrote: > > > > > > It seems like all other sane architectures, namely x86 and arm64 > > > at least, include the running function as

Re: [PATCH v2 0/7] Improve boot command line handling

2021-03-03 Thread Daniel Walker
On Wed, Mar 03, 2021 at 07:07:45PM +0100, Christophe Leroy wrote: > > > Le 03/03/2021 à 18:39, Daniel Walker a écrit : > > On Tue, Mar 02, 2021 at 08:01:01PM -0600, Rob Herring wrote: > > > +Will D > > > > > > On Tue, Mar 2, 2021 at 11:36 AM Daniel Walker wrote: > > > > > > > > On Tue, Mar

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-03 Thread Marco Elver
On Wed, 3 Mar 2021 at 15:09, Christophe Leroy wrote: > > It seems like all other sane architectures, namely x86 and arm64 > at least, include the running function as top entry when saving > stack trace. > > Functionnalities like KFENCE expect it. > > Do the same on powerpc, it allows KFENCE to

Re: [PATCH v2 4/7] cmdline: Add capability to prepend the command line

2021-03-03 Thread Will Deacon
On Tue, Mar 02, 2021 at 05:25:20PM +, Christophe Leroy wrote: > This patchs adds an option of prepend a text to the command > line instead of appending it. > > Signed-off-by: Christophe Leroy > --- > include/linux/cmdline.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > >

Re: [PATCH v2 1/7] cmdline: Add generic function to build command line.

2021-03-03 Thread Will Deacon
On Wed, Mar 03, 2021 at 06:57:09PM +0100, Christophe Leroy wrote: > Le 03/03/2021 à 18:46, Will Deacon a écrit : > > On Wed, Mar 03, 2021 at 06:38:16PM +0100, Christophe Leroy wrote: > > > Le 03/03/2021 à 18:28, Will Deacon a écrit : > > > > On Tue, Mar 02, 2021 at 05:25:17PM +, Christophe

Re: [PATCH v2 0/7] Improve boot command line handling

2021-03-03 Thread Christophe Leroy
Le 03/03/2021 à 18:39, Daniel Walker a écrit : On Tue, Mar 02, 2021 at 08:01:01PM -0600, Rob Herring wrote: +Will D On Tue, Mar 2, 2021 at 11:36 AM Daniel Walker wrote: On Tue, Mar 02, 2021 at 05:25:16PM +, Christophe Leroy wrote: The purpose of this series is to improve and enhance

Re: [PATCH v2 6/7] cmdline: Gives architectures opportunity to use generically defined boot cmdline manipulation

2021-03-03 Thread Will Deacon
On Tue, Mar 02, 2021 at 05:25:22PM +, Christophe Leroy wrote: > Most architectures have similar boot command line manipulation > options. This patchs adds the definition in init/Kconfig, gated by > CONFIG_HAVE_CMDLINE that the architectures can select to use them. > > In order to use this, a

Re: [PATCH v2 1/7] cmdline: Add generic function to build command line.

2021-03-03 Thread Christophe Leroy
Le 03/03/2021 à 18:46, Will Deacon a écrit : On Wed, Mar 03, 2021 at 06:38:16PM +0100, Christophe Leroy wrote: Le 03/03/2021 à 18:28, Will Deacon a écrit : On Tue, Mar 02, 2021 at 05:25:17PM +, Christophe Leroy wrote: This code provides architectures with a way to build command line

[PATCH v2 1/8] powerpc/xive: Use cpu_to_node() instead of ibm, chip-id property

2021-03-03 Thread Cédric Le Goater
The 'chip_id' field of the XIVE CPU structure is used to choose a target for a source located on the same chip when possible. This field is assigned on the PowerNV platform using the "ibm,chip-id" property on pSeries under KVM when NUMA nodes are defined but it is undefined under PowerVM. The XIVE

[PATCH v2 3/8] powerpc/xive: Remove useless check on XIVE_IPI_HW_IRQ

2021-03-03 Thread Cédric Le Goater
The IPI interrupt has its own domain now. Testing the HW interrupt number is not needed anymore. Signed-off-by: Cédric Le Goater --- arch/powerpc/sysdev/xive/common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/powerpc/sysdev/xive/common.c

[PATCH v2 5/8] powerpc/xive: Drop check on irq_data in xive_core_debug_show()

2021-03-03 Thread Cédric Le Goater
When looping on IRQ descriptor, irq_data is always valid. Reported-by: kernel test robot Reported-by: Dan Carpenter Fixes: 930914b7d528 ("powerpc/xive: Add a debugfs file to dump internal XIVE state") Signed-off-by: Cédric Le Goater --- arch/powerpc/sysdev/xive/common.c | 21

[PATCH v2 2/8] powerpc/xive: Introduce an IPI interrupt domain

2021-03-03 Thread Cédric Le Goater
The IPI interrupt is a special case of the XIVE IRQ domain. When mapping and unmapping the interrupts in the Linux interrupt number space, the HW interrupt number 0 (XIVE_IPI_HW_IRQ) is checked to distinguish the IPI interrupt from other interrupts of the system. Simplify the XIVE interrupt

[PATCH v2 4/8] powerpc/xive: Simplify xive_core_debug_show()

2021-03-03 Thread Cédric Le Goater
Now that the IPI interrupt has its own domain, the checks on the HW interrupt number XIVE_IPI_HW_IRQ and on the chip can be replaced by a check on the domain. Signed-off-by: Cédric Le Goater --- arch/powerpc/sysdev/xive/common.c | 18 -- 1 file changed, 4 insertions(+), 14

[PATCH v2 7/8] powerpc/xive: Fix xmon command "dxi"

2021-03-03 Thread Cédric Le Goater
When under xmon, the "dxi" command dumps the state of the XIVE interrupts. If an interrupt number is specified, only the state of the associated XIVE interrupt is dumped. This form of the command lacks an irq_data parameter which is nevertheless used by xmon_xive_get_irq_config(), leading to an

[PATCH v2 0/8] powerpc/xive: Map one IPI interrupt per node

2021-03-03 Thread Cédric Le Goater
Hello, ipistorm [*] can be used to benchmark the raw interrupt rate of an interrupt controller by measuring the number of IPIs a system can sustain. When applied to the XIVE interrupt controller of POWER9 and POWER10 systems, a significant drop of the interrupt rate can be observed when crossing

[PATCH v2 8/8] powerpc/xive: Map one IPI interrupt per node

2021-03-03 Thread Cédric Le Goater
ipistorm [*] can be used to benchmark the raw interrupt rate of an interrupt controller by measuring the number of IPIs a system can sustain. When applied to the XIVE interrupt controller of POWER9 and POWER10 systems, a significant drop of the interrupt rate can be observed when crossing the

[PATCH v2 6/8] powerpc/xive: Simplify the dump of XIVE interrupts under xmon

2021-03-03 Thread Cédric Le Goater
Move the xmon routine under XIVE subsystem and rework the loop on the interrupts taking into account the xive_irq_domain to filter out IPIs. Signed-off-by: Cédric Le Goater --- arch/powerpc/include/asm/xive.h | 1 + arch/powerpc/sysdev/xive/common.c | 14 ++

Re: [PATCH next v4 12/15] printk: introduce a kmsg_dump iterator

2021-03-03 Thread Petr Mladek
On Wed 2021-03-03 11:15:25, John Ogness wrote: > Rather than storing the iterator information in the registered > kmsg_dumper structure, create a separate iterator structure. The > kmsg_dump_iter structure can reside on the stack of the caller, thus > allowing lockless use of the kmsg_dump

Re: [PATCH v2 1/7] cmdline: Add generic function to build command line.

2021-03-03 Thread Will Deacon
On Wed, Mar 03, 2021 at 06:38:16PM +0100, Christophe Leroy wrote: > Le 03/03/2021 à 18:28, Will Deacon a écrit : > > On Tue, Mar 02, 2021 at 05:25:17PM +, Christophe Leroy wrote: > > > This code provides architectures with a way to build command line > > > based on what is built in the kernel

Re: [PATCH v2 1/7] cmdline: Add generic function to build command line.

2021-03-03 Thread Christophe Leroy
Le 03/03/2021 à 18:28, Will Deacon a écrit : On Tue, Mar 02, 2021 at 05:25:17PM +, Christophe Leroy wrote: This code provides architectures with a way to build command line based on what is built in the kernel and what is handed over by the bootloader, based on selected compile-time

Re: [PATCH v2 1/7] cmdline: Add generic function to build command line.

2021-03-03 Thread Will Deacon
On Tue, Mar 02, 2021 at 05:25:17PM +, Christophe Leroy wrote: > This code provides architectures with a way to build command line > based on what is built in the kernel and what is handed over by the > bootloader, based on selected compile-time options. > > Signed-off-by: Christophe Leroy >

Re: [PATCH v2 0/7] Improve boot command line handling

2021-03-03 Thread Daniel Walker
On Tue, Mar 02, 2021 at 08:01:01PM -0600, Rob Herring wrote: > +Will D > > On Tue, Mar 2, 2021 at 11:36 AM Daniel Walker wrote: > > > > On Tue, Mar 02, 2021 at 05:25:16PM +, Christophe Leroy wrote: > > > The purpose of this series is to improve and enhance the > > > handling of kernel boot

Re: [PATCH v2 1/7] cmdline: Add generic function to build command line.

2021-03-03 Thread Will Deacon
On Tue, Mar 02, 2021 at 05:25:17PM +, Christophe Leroy wrote: > This code provides architectures with a way to build command line > based on what is built in the kernel and what is handed over by the > bootloader, based on selected compile-time options. > > Signed-off-by: Christophe Leroy >

[PATCH v2] powerpc: Fix save_stack_trace_regs() to have running function as first entry

2021-03-03 Thread Christophe Leroy
It seems like other architectures, namely x86 and arm64 at least, include the running function as top entry when saving stack trace with save_stack_trace_regs(). Functionnalities like KFENCE expect it. Do the same on powerpc, it allows KFENCE to properly identify the faulting function as

lkml delivery: was: Re: [PATCH next v4 00/15] printk: remove logbuf_lock

2021-03-03 Thread Petr Mladek
Hi John, On Wed 2021-03-03 11:15:13, John Ogness wrote: > Hello, > > Here is v4 of a series to remove @logbuf_lock, exposing the > ringbuffer locklessly to both readers and writers. v3 is > here [0]. Have you got some reply from lkml that it has not delivered there, please? I am not able to

Re: [PATCH] ibmvnic: Fix possibly uninitialized old_num_tx_queues variable warning.

2021-03-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Mar 2021 20:47:47 +0100 you wrote: > GCC 7.5 reports: > ../drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_reset_init': > ../drivers/net/ethernet/ibm/ibmvnic.c:5373:51: warning: 'old_num_tx_queues' > may be

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-03 Thread Marco Elver
On Wed, 3 Mar 2021 at 11:39, Christophe Leroy wrote: > > > > Le 02/03/2021 à 12:39, Marco Elver a écrit : > > On Tue, 2 Mar 2021 at 12:21, Christophe Leroy > > wrote: > > [...] > Booting with 'no_hash_pointers" I get the following. Does it helps ? > > [ 16.837198] >

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-03 Thread Christophe Leroy
Le 03/03/2021 à 15:38, Marco Elver a écrit : On Wed, 3 Mar 2021 at 15:09, Christophe Leroy wrote: It seems like all other sane architectures, namely x86 and arm64 at least, include the running function as top entry when saving stack trace. Functionnalities like KFENCE expect it. Do the

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-03 Thread Marco Elver
On Wed, 3 Mar 2021 at 11:32, Christophe Leroy wrote: > > > > Le 02/03/2021 à 10:53, Marco Elver a écrit : > > On Tue, 2 Mar 2021 at 10:27, Christophe Leroy > > wrote: > >> Le 02/03/2021 à 10:21, Alexander Potapenko a écrit : > [ 14.998426] BUG: KFENCE: invalid read in >

[PATCH 09/10] crypto: nx: nx-aes-cbc: Repair some kernel-doc problems

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'tfm' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'in_key' not described in 'cbc_aes_nx_set_key'

[PATCH 08/10] crypto: vmx: Source headers are not good kernel-doc candidates

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/crypto/vmx/vmx.c:23: warning: expecting prototype for Routines supporting VMX instructions on the Power 8(). Prototype was for p8_init() instead Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc:

[PATCH v2 00/10] Rid W=1 warnings in Crypto

2021-03-03 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. This is set 1 of 2 sets required to fully clean Crypto. No functional changes since v1. Lee Jones (10): crypto: hisilicon: sec_drv: Supply

Re: lkml delivery: was: Re: [PATCH next v4 00/15] printk: remove logbuf_lock

2021-03-03 Thread Steven Rostedt
On Wed, 3 Mar 2021 14:18:29 +0100 Petr Mladek wrote: > Hi John, > > On Wed 2021-03-03 11:15:13, John Ogness wrote: > > Hello, > > > > Here is v4 of a series to remove @logbuf_lock, exposing the > > ringbuffer locklessly to both readers and writers. v3 is > > here [0]. > > Have you got some

[PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-03 Thread Christophe Leroy
It seems like all other sane architectures, namely x86 and arm64 at least, include the running function as top entry when saving stack trace. Functionnalities like KFENCE expect it. Do the same on powerpc, it allows KFENCE to properly identify the faulting function as depicted below. Before the

Re: [PATCH] ASoC: hdmi-codec: fix platform_no_drv_owner.cocci warnings

2021-03-03 Thread Fabio Estevam
Hi Yang, On Wed, Mar 3, 2021 at 5:54 AM Yang Li wrote: > > ./sound/soc/fsl/imx-hdmi.c:226:3-8: No need to set .owner here. The core > will do it. > > Remove .owner field if calls are used which set it automatically > > Reported-by: Abaci Robot > Signed-off-by: Yang Li The patch looks good,

[RESEND 1/1] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for ‘hvc_vio_init_early’ [-Wmissing-prototypes] 385 | void __init hvc_vio_init_early(void) | ^~ Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-03 Thread Andreas Schwab
On Mär 03 2021, Marco Elver wrote: > On Wed, 3 Mar 2021 at 11:32, Christophe Leroy > wrote: >> ./include/linux/kern_levels.h:5:18: warning: format '%zd' expects argument >> of type 'signed size_t', >> but argument 3 has type 'ptrdiff_t' {aka 'const long int'} [-Wformat=] >> 5 | #define

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-03 Thread Christophe Leroy
Le 03/03/2021 à 11:39, Marco Elver a écrit : On Wed, 3 Mar 2021 at 11:32, Christophe Leroy wrote: Le 02/03/2021 à 10:53, Marco Elver a écrit : On Tue, 2 Mar 2021 at 10:27, Christophe Leroy wrote: Le 02/03/2021 à 10:21, Alexander Potapenko a écrit : [ 14.998426] BUG: KFENCE: invalid

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-03 Thread Christophe Leroy
Le 02/03/2021 à 12:39, Marco Elver a écrit : On Tue, 2 Mar 2021 at 12:21, Christophe Leroy wrote: [...] Booting with 'no_hash_pointers" I get the following. Does it helps ? [ 16.837198] == [ 16.848521] BUG: KFENCE:

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-03 Thread Christophe Leroy
Le 02/03/2021 à 10:53, Marco Elver a écrit : On Tue, 2 Mar 2021 at 10:27, Christophe Leroy wrote: Le 02/03/2021 à 10:21, Alexander Potapenko a écrit : [ 14.998426] BUG: KFENCE: invalid read in finish_task_switch.isra.0+0x54/0x23c [ 14.998426] [ 15.007061] Invalid read at 0x(ptrval):

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-03 Thread Christophe Leroy
Le 02/03/2021 à 12:40, Michael Ellerman a écrit : Christophe Leroy writes: Le 02/03/2021 à 10:53, Marco Elver a écrit : On Tue, 2 Mar 2021 at 10:27, Christophe Leroy wrote: Le 02/03/2021 à 10:21, Alexander Potapenko a écrit : [ 14.998426] BUG: KFENCE: invalid read in

[PATCH next v4 14/15] printk: kmsg_dump: remove _nolock() variants

2021-03-03 Thread John Ogness
kmsg_dump_rewind() and kmsg_dump_get_line() are lockless, so there is no need for _nolock() variants. Remove these functions and switch all callers of the _nolock() variants. The functions without _nolock() were chosen because they are already exported to kernel modules. Signed-off-by: John

[PATCH next v4 12/15] printk: introduce a kmsg_dump iterator

2021-03-03 Thread John Ogness
Rather than storing the iterator information in the registered kmsg_dumper structure, create a separate iterator structure. The kmsg_dump_iter structure can reside on the stack of the caller, thus allowing lockless use of the kmsg_dump functions. Update code that accesses the kernel logs using

[PATCH next v4 11/15] printk: kmsg_dumper: remove @active field

2021-03-03 Thread John Ogness
All 6 kmsg_dumpers do not benefit from the @active flag: (provide their own synchronization) - arch/powerpc/kernel/nvram_64.c - arch/um/kernel/kmsg_dump.c - drivers/mtd/mtdoops.c - fs/pstore/platform.c (only dump on KMSG_DUMP_PANIC, which does not require synchronization) -

[PATCH next v4 00/15] printk: remove logbuf_lock

2021-03-03 Thread John Ogness
on next-20210303. Changes since v3: - disable interrupts in the arch/um kmsg_dumper - reduce CONSOLE_LOG_MAX value from 4096 back to 1024 to revert the increasd 3KiB static memory footprint - change the kmsg_dumper() callback prototype back to how it was because some dumpers need the registered

[PATCH][next] ASoC: fsl: fsl_easrc: Fix uninitialized variable st2_mem_alloc

2021-03-03 Thread Colin King
From: Colin Ian King A previous cleanup commit removed the ininitialization of st2_mem_alloc. Fix this by restoring the original behaviour by initializing it to zero. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: e80382fe721f ("ASoC: fsl: fsl_easrc: remove useless assignments")

[PATCH] ASoC: hdmi-codec: fix platform_no_drv_owner.cocci warnings

2021-03-03 Thread Yang Li
./sound/soc/fsl/imx-hdmi.c:226:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Reported-by: Abaci Robot Signed-off-by: Yang Li --- sound/soc/fsl/imx-hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH 40/44] tty: hvc, drop unneeded forward declarations

2021-03-03 Thread Uwe Kleine-König
Hello Jiri, On Tue, Mar 02, 2021 at 07:22:10AM +0100, Jiri Slaby wrote: > Forward declarations make the code larger and rewrites harder. Harder as > they are often omitted from global changes. Remove forward declarations > which are not really needed, i.e. the definition of the function is >