Re: [PATCH 00/36] [Set 4] Rid W=1 warnings in SCSI

2021-03-24 Thread Martin K. Petersen
On Wed, 17 Mar 2021 09:11:54 +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (36): > scsi: myrb: Demote non-conformant kernel-doc headers and fix

Re: [PATCH 0/2] Fix EH race and MQ support

2021-03-24 Thread Martin K. Petersen
On Fri, 19 Mar 2021 14:50:27 -0600, Tyrel Datwyler wrote: > Changes to the locking pattern protecting the event lists and handling of scsi > command completion introduced a race where an ouststanding command that EH is > waiting ifor to complete is no longer identifiable by being on the sent

Re: [PATCH] powerpc/asm-offsets: GPR14 is not needed either

2021-03-24 Thread Rashmica Gupta
On Mon, 2021-03-15 at 11:01 +, Christophe Leroy wrote: > Commit aac6a91fea93 ("powerpc/asm: Remove unused symbols in > asm-offsets.c") removed GPR15 to GPR31 but kept GPR14, > probably because it pops up in a couple of comments when doing > a grep. > > However, it was never used either, so

Re: [RESEND 1/1] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location

2021-03-24 Thread Michael Ellerman
Lee Jones writes: > On Wed, 03 Mar 2021, Lee Jones wrote: > >> Fixes the following W=1 kernel build warning(s): >> >> drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for >> ‘hvc_vio_init_early’ [-Wmissing-prototypes] >> 385 | void __init hvc_vio_init_early(void) >> |

Re: [RFC PATCH 6/8] powerpc/mm/book3s64/hash: drop pre 2.06 tlbiel for clang

2021-03-24 Thread Segher Boessenkool
On Wed, Mar 24, 2021 at 10:51:05AM -0500, Segher Boessenkool wrote: > The variants with fewer operands have those coded as 0 in the > instruction. All of this is backwards compatible. I was reminded that this is broken in ISA 2.03. Ouch. Segher

[PATCH v7 0/7] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

2021-03-24 Thread Serge Semin
As the subject states this series is an attempt to harmonize the xHCI, EHCI, OHCI and DWC USB3 DT nodes with the DT schema introduced in the framework of the patchset [1]. Firstly as Krzysztof suggested we've deprecated a support of DWC USB3 controllers with "synopsys,"-vendor prefix compatible

[PATCH v7 3/7] powerpc: dts: akebono: Harmonize EHCI/OHCI DT nodes name

2021-03-24 Thread Serge Semin
In accordance with the Generic EHCI/OHCI bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible nodes are

Re: [PATCH V2 3/5] tools/perf: Add powerpc support for PERF_SAMPLE_WEIGHT_STRUCT

2021-03-24 Thread Jiri Olsa
On Mon, Mar 22, 2021 at 10:57:25AM -0400, Athira Rajeev wrote: > Add arch specific arch_evsel__set_sample_weight() to set the new > sample type for powerpc. > > Add arch specific arch_perf_parse_sample_weight() to store the > sample->weight values depending on the sample type applied. > if the

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

2021-03-24 Thread Rob Herring
On Wed, Mar 24, 2021 at 11:01 AM Christophe Leroy wrote: > > > > Le 09/03/2021 à 22:29, Daniel Walker a écrit : > > On Tue, Mar 09, 2021 at 08:47:09AM +0100, Christophe Leroy wrote: > >> > >> > >> Le 09/03/2021 à 01:02, Daniel Walker a écrit : > >>> This is a scripted mass convert of the config

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

2021-03-24 Thread Christophe Leroy
Le 09/03/2021 à 22:29, Daniel Walker a écrit : On Tue, Mar 09, 2021 at 08:47:09AM +0100, Christophe Leroy wrote: Le 09/03/2021 à 01:02, Daniel Walker a écrit : This is a scripted mass convert of the config files to use the new generic cmdline. There is a bit of a trim effect here. It

Re: [PATCH v4 00/46] KVM: PPC: Book3S: C-ify the P9 entry/exit code

2021-03-24 Thread Nicholas Piggin
Excerpts from Nicholas Piggin's message of March 23, 2021 11:02 am: > I think enough changes and fixes have gone in since last round > to repost. > > I put a git tree here to make things easier to get. > > https://github.com/npiggin/linux/tree/kvm-in-c-2 I just pushed a new tree

Re: [RFC PATCH 6/8] powerpc/mm/book3s64/hash: drop pre 2.06 tlbiel for clang

2021-03-24 Thread Segher Boessenkool
Hi! On Tue, Mar 23, 2021 at 04:11:10AM +1000, Nicholas Piggin wrote: > The problem in this file is we generate 3 different tlbie and tlbiel > instructions with the same mnemonic corresponding to different ISA > versions. > > This might actually be the one good place to use .machine to make sure

Re: [PATCH v2 4/7] CMDLINE: powerpc: convert to generic builtin command line

2021-03-24 Thread Christophe Leroy
Le 09/03/2021 à 22:40, Daniel Walker a écrit : On Tue, Mar 09, 2021 at 08:56:47AM +0100, Christophe Leroy wrote: Le 09/03/2021 à 01:02, Daniel Walker a écrit : This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan

[PATCH v2 1/4] mm/vmalloc: Change the 'caller' type to unsigned long

2021-03-24 Thread Matthew Wilcox (Oracle)
kmalloc uses an unsigned long while vmalloc uses const void * to represent the address of the caller. _RET_IP_ is more popular than __builtin_return_address (429 to 258), so switch vmalloc to match kmalloc (which changes the score to 504 to 183). Also lets us use _THIS_IP_ instead of the

Re: [PATCH v2 0/7] Generic Command Line changes

2021-03-24 Thread Rob Herring
On Mon, Mar 8, 2021 at 5:02 PM Daniel Walker wrote: > > This fixed some problem identified in my last release. I made updates > based on comments from Christophe Leroy. > > I added scripted updates to the defconfig file for mips and powerpc. > This is required in order to maintain the status quo

[PATCH -next] powerpc/smp: Remove unused inline functions

2021-03-24 Thread YueHaibing
commit 441c19c8a290 ("powerpc/kvm/book3s_hv: Rework the secondary inhibit code") left behind this, so can remove it. Signed-off-by: YueHaibing --- arch/powerpc/include/asm/smp.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/include/asm/smp.h b/arch/powerpc/include/asm/smp.h

[PATCH -next] powerpc/eeh: Remove unused inline function eeh_dev_phb_init_dynamic()

2021-03-24 Thread YueHaibing
commit 475028efc708 ("powerpc/eeh: Remove eeh_dev_phb_init_dynamic()") left behind this, so can remove it. Signed-off-by: YueHaibing --- arch/powerpc/include/asm/eeh.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h index

Re: [PATCH v7] powerpc/irq: Inline call_do_irq() and call_do_softirq()

2021-03-24 Thread Michael Ellerman
Christophe Leroy writes: > Le 20/03/2021 à 13:22, Michael Ellerman a écrit : >> From: Christophe Leroy >> >> call_do_irq() and call_do_softirq() are simple enough to be >> worth inlining. >> >> Inlining them avoids an mflr/mtlr pair plus a save/reload on stack. It >> also allows GCC to keep

[PATCH v1 1/3] drivers/char: remove /dev/kmem for good

2021-03-24 Thread David Hildenbrand
Exploring /dev/kmem and /dev/mem in the context of memory hot(un)plug and memory ballooning, I started questioning the existance of /dev/kmem. Comparing it with the /proc/kcore implementation, it does not seem to be able to deal with things like a) Pages unmapped from the direct mapping (e.g., to

Re: [RESEND 1/1] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location

2021-03-24 Thread Lee Jones
On Wed, 03 Mar 2021, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for > ‘hvc_vio_init_early’ [-Wmissing-prototypes] > 385 | void __init hvc_vio_init_early(void) > | ^~ > > Cc: Michael

[PATCH v1 2/3] mm: remove xlate_dev_kmem_ptr()

2021-03-24 Thread David Hildenbrand
Since /dev/kmem has been removed, let's remove the xlate_dev_kmem_ptr() leftovers. Acked-by: Geert Uytterhoeven Cc: Linus Torvalds Cc: Greg Kroah-Hartman Cc: Andrew Morton Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: Russell King Cc: Brian Cain Cc: Geert Uytterhoeven

Re: [PATCH 08/10] MIPS: disable CONFIG_IDE in malta*_defconfig

2021-03-24 Thread Thomas Bogendoerfer
On Thu, Mar 18, 2021 at 05:57:04AM +0100, Christoph Hellwig wrote: > Various malta defconfigs enable CONFIG_IDE for the tc86c001 ide driver, > hich is a Toshiba plug in card that does not make much sense to use on > bigsur platforms. For all other ATA cards libata support is already > enabled. >

Re: [PATCH 04/10] MIPS: disable CONFIG_IDE in sb1250_swarm_defconfig

2021-03-24 Thread Thomas Bogendoerfer
On Thu, Mar 18, 2021 at 05:57:00AM +0100, Christoph Hellwig wrote: > sb1250_swarm_defconfig enables CONFIG_IDE but no actual host controller > driver, so just drop CONFIG_IDE, CONFIG_BLK_DEV_IDECD and > CONFIG_BLK_DEV_IDETAPE as they are useless. > > Signed-off-by: Christoph Hellwig > --- >

Re: [PATCH 06/10] MIPS: disable CONFIG_IDE in rbtx49xx_defconfig

2021-03-24 Thread Thomas Bogendoerfer
On Thu, Mar 18, 2021 at 05:57:02AM +0100, Christoph Hellwig wrote: > rbtx49xx_defconfig enables CONFIG_IDE for the tx4938 and tx4939 ide > drivers, but those aren't actually used by the last known remaining user: > >

Re: [PATCH 05/10] MIPS: switch workpad_defconfig from legacy IDE to libata

2021-03-24 Thread Thomas Bogendoerfer
On Thu, Mar 18, 2021 at 05:57:01AM +0100, Christoph Hellwig wrote: > Use libata instead of the deprecated legacy ide driver in > workpad_defconfig. > > Signed-off-by: Christoph Hellwig > --- > arch/mips/configs/workpad_defconfig | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-)

Re: [PATCH 07/10] MIPS: disable CONFIG_IDE in bigsur_defconfig

2021-03-24 Thread Thomas Bogendoerfer
On Thu, Mar 18, 2021 at 05:57:03AM +0100, Christoph Hellwig wrote: > bigsur_defconfig enables CONFIG_IDE for the tc86c001 ide driver, which > is a Toshiba plug in card that does not make much sense to use on bigsur > platforms. For all other ATA cards libata support is already enabled. > >

Re: [PATCH v2] powerpc/papr_scm: Implement support for H_SCM_FLUSH hcall

2021-03-24 Thread Vaibhav Jain
Hi Shiva, Thanks for the patch. Few minor review comments: Shivaprasad G Bhat writes: > Add support for ND_REGION_ASYNC capability if the device tree > indicates 'ibm,hcall-flush-required' property in the NVDIMM node. > Flush is done by issuing H_SCM_FLUSH hcall to the hypervisor. > > If the

Re: [PATCH V3 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread heying (H)
Dear Alexandre, 在 2021/3/24 17:29, Alexandre Belloni 写道: On 24/03/2021 05:09:39-0400, He Ying wrote: We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol 'rtc_lock' was not declared. Should

Re: [PATCH V3 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread Christophe Leroy
Le 24/03/2021 à 10:29, Alexandre Belloni a écrit : On 24/03/2021 05:09:39-0400, He Ying wrote: We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol 'rtc_lock' was not declared. Should it be

Re: [PATCH V3 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread Christophe Leroy
Le 24/03/2021 à 10:09, He Ying a écrit : We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol 'rtc_lock' was not declared. Should it be static? warning: symbol 'dtl_consumer' was not

Re: [PATCH V3 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread Alexandre Belloni
On 24/03/2021 05:09:39-0400, He Ying wrote: > We found these warnings in arch/powerpc/kernel/time.c as follows: > warning: symbol 'decrementer_max' was not declared. Should it be static? > warning: symbol 'rtc_lock' was not declared. Should it be static? > warning: symbol 'dtl_consumer' was not

[PATCH V3 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread He Ying
We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol 'rtc_lock' was not declared. Should it be static? warning: symbol 'dtl_consumer' was not declared. Should it be static? Declare

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread Alexandre Belloni
On 24/03/2021 09:19:58+0100, Geert Uytterhoeven wrote: > Hi Alexandre, > > On Tue, Mar 23, 2021 at 11:18 PM Alexandre Belloni > wrote: > > On 23/03/2021 05:12:57-0400, He Ying wrote: > > > We found these warnings in arch/powerpc/kernel/time.c as follows: > > > warning: symbol 'decrementer_max'

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread heying (H)
Dear, 在 2021/3/24 14:22, Christophe Leroy 写道: Le 24/03/2021 à 07:14, Christophe Leroy a écrit : Le 24/03/2021 à 00:05, Alexandre Belloni a écrit : On 23/03/2021 23:18:17+0100, Alexandre Belloni wrote: Hello, On 23/03/2021 05:12:57-0400, He Ying wrote: We found these warnings in

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread Geert Uytterhoeven
Hi Alexandre, On Tue, Mar 23, 2021 at 11:18 PM Alexandre Belloni wrote: > On 23/03/2021 05:12:57-0400, He Ying wrote: > > We found these warnings in arch/powerpc/kernel/time.c as follows: > > warning: symbol 'decrementer_max' was not declared. Should it be static? > > warning: symbol 'rtc_lock'

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread Christophe Leroy
Le 24/03/2021 à 07:14, Christophe Leroy a écrit : Le 24/03/2021 à 00:05, Alexandre Belloni a écrit : On 23/03/2021 23:18:17+0100, Alexandre Belloni wrote: Hello, On 23/03/2021 05:12:57-0400, He Ying wrote: We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread Christophe Leroy
Le 24/03/2021 à 00:05, Alexandre Belloni a écrit : On 23/03/2021 23:18:17+0100, Alexandre Belloni wrote: Hello, On 23/03/2021 05:12:57-0400, He Ying wrote: We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be