Re: [PATCH v3 31/41] powerpc/32: Dismantle EXC_XFER_STD/LITE/TEMPLATE

2021-08-02 Thread Finn Thain
On Mon, 2 Aug 2021, LEROY Christophe wrote: > Le 01/08/2021 à 03:21, Finn Thain a écrit : > > On Sat, 31 Jul 2021, Christophe Leroy wrote: > > > > > > > > > > Stan Johnson contacted me about a regression in mainline that he > > > > observed on his G3 Powerbooks. Using 'git bisect' we determined

[PATCH] KVM: PPC: Book3S HV: Fix kvmhv_copy_tofrom_guest_radix

2021-08-02 Thread Fabiano Rosas
This function was introduced along with nested HV guest support. It uses the platform's Radix MMU quadrants[1] to provide a nested hypervisor with fast access to its nested guests memory (H_COPY_TOFROM_GUEST hypercall). It has also since been added as a fast path for the kvmppc_ld/st routines

Re: Possible regression by ab037dd87a2f (powerpc/vdso: Switch VDSO to generic C implementation.)

2021-08-02 Thread Lynn Boger
Fixes will be in Go 1.16.7 and 1.15.15. Backports are no longer being done for Go 1.14. On 8/2/21 1:18 AM, Michael Ellerman wrote: "Paul Murphy" writes: (My apologies for however IBM's email client munges this) I heard it is going to be in Go 1.16.7, but I do not know much about Go.

Re: [PATCH 2/3] trace: refactor TRACE_IRQFLAGS_SUPPORT in Kconfig

2021-08-02 Thread Max Filippov
On Fri, Jul 30, 2021 at 10:24 PM Masahiro Yamada wrote: > > Make architectures select TRACE_IRQFLAGS_SUPPORT instead of > having many defines. > > Signed-off-by: Masahiro Yamada > --- > arch/xtensa/Kconfig | 4 +--- Acked-by: Max Filippov -- Thanks. -- Max

Re: [PATCH 2/3] trace: refactor TRACE_IRQFLAGS_SUPPORT in Kconfig

2021-08-02 Thread Catalin Marinas
On Sat, Jul 31, 2021 at 02:22:32PM +0900, Masahiro Yamada wrote: > Make architectures select TRACE_IRQFLAGS_SUPPORT instead of > having many defines. > > Signed-off-by: Masahiro Yamada For arm64: Acked-by: Catalin Marinas

Re: [PATCH v1 4/5] PCI: Adapt all code locations to not use struct pci_dev::driver directly

2021-08-02 Thread Boris Ostrovsky
On 7/31/21 8:08 AM, Uwe Kleine-König wrote: > Hello Boris, > > On Fri, Jul 30, 2021 at 04:37:31PM -0400, Boris Ostrovsky wrote: >> On 7/29/21 4:37 PM, Uwe Kleine-König wrote: >>> --- a/drivers/pci/xen-pcifront.c >>> +++ b/drivers/pci/xen-pcifront.c >>> @@ -599,12 +599,12 @@ static

Re: [PATCH 2/2] virtio-console: remove unnecessary kmemdup()

2021-08-02 Thread Xianting Tian
在 2021/8/2 下午3:25, Jiri Slaby 写道: Hi, why is this 2/2? I seem (Lore neither) to find 1/2. You didn't receive 1/2? [PATCH 1/2] tty: hvc: pass DMA capable memory to put_chars() https://lkml.org/lkml/2021/8/1/8 On 01. 08. 21, 7:16, Xianting Tian wrote: hvc

Re: [PATCH 2/3] trace: refactor TRACE_IRQFLAGS_SUPPORT in Kconfig

2021-08-02 Thread Michael Ellerman
Masahiro Yamada writes: > Make architectures select TRACE_IRQFLAGS_SUPPORT instead of > having many defines. > > Signed-off-by: Masahiro Yamada > --- > > arch/Kconfig | 3 +++ > arch/arc/Kconfig | 4 +--- > arch/arm/Kconfig | 5 + >

[Bug 213803] G5 kernel build (v5.14-rc2) fails at linking stage - ld: arch/powerpc/mm/pgtable.o: in function `.__ptep_set_access_flags': /usr/src/linux-stable/./arch/powerpc/include/asm/book3s/64/pgta

2021-08-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213803 --- Comment #1 from Erhard F. (erhar...@mailbox.org) --- Still a problem in v5.14-rc4. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH 3/3] isystem: delete global -isystem compile option

2021-08-02 Thread Segher Boessenkool
On Mon, Aug 02, 2021 at 11:30:00PM +0300, Alexey Dobriyan wrote: > On Mon, Aug 02, 2021 at 11:47:47AM -0500, Segher Boessenkool wrote: > > The kernel *cannot* make up its own types for this. It has to use the > > types it is required to use (by C, by the ABIs, etc.) So why > > reimplement this?

Re: Debian SID kernel doesn't boot on PowerBook 3400c

2021-08-02 Thread Stan Johnson
On 8/2/21 8:41 AM, Christophe Leroy wrote: > > > Le 31/07/2021 à 20:24, Stan Johnson a écrit : >> Hi Christophe, >> >> On 7/31/21 9:58 AM, Christophe Leroy wrote: >>> Stan Johnson a écrit : >>> Hello, The current Debian SID kernel will not boot on a PowerBook 3400c running

Re: [PATCH 3/3] isystem: delete global -isystem compile option

2021-08-02 Thread Nathan Chancellor
On 8/2/2021 1:32 PM, Alexey Dobriyan wrote: On Mon, Aug 02, 2021 at 11:18:32AM -0700, Nathan Chancellor wrote: On Sun, Aug 01, 2021 at 11:13:36PM +0300, Alexey Dobriyan wrote: In theory, it enables "leakage" of userspace headers into kernel which may present licensing problem. In practice,

Re: [PATCH 3/3] isystem: delete global -isystem compile option

2021-08-02 Thread Alexey Dobriyan
On Mon, Aug 02, 2021 at 11:18:32AM -0700, Nathan Chancellor wrote: > On Sun, Aug 01, 2021 at 11:13:36PM +0300, Alexey Dobriyan wrote: > > In theory, it enables "leakage" of userspace headers into kernel which > > may present licensing problem. > > > > In practice, only stdarg.h was used,

Re: [PATCH 3/3] isystem: delete global -isystem compile option

2021-08-02 Thread Alexey Dobriyan
On Mon, Aug 02, 2021 at 11:47:47AM -0500, Segher Boessenkool wrote: > On Mon, Aug 02, 2021 at 09:42:45AM +0300, Alexey Dobriyan wrote: > > On Sun, Aug 01, 2021 at 04:32:47PM -0500, Segher Boessenkool wrote: > > > On Sun, Aug 01, 2021 at 11:13:36PM +0300, Alexey Dobriyan wrote: > > > > In theory,

Re: [PATCH 3/3] isystem: delete global -isystem compile option

2021-08-02 Thread Nathan Chancellor
On Sun, Aug 01, 2021 at 11:13:36PM +0300, Alexey Dobriyan wrote: > In theory, it enables "leakage" of userspace headers into kernel which > may present licensing problem. > > In practice, only stdarg.h was used, stdbool.h is trivial and SIMD > intrinsics are contained to a few architectures and

Re: Possible regression by ab037dd87a2f (powerpc/vdso: Switch VDSO to generic C implementation.)

2021-08-02 Thread Segher Boessenkool
On Mon, Aug 02, 2021 at 04:18:58PM +1000, Michael Ellerman wrote: > > Go up to this point has only used the vdso function __kernel_clock_gettime; > > it > > is the only entry point which would need to explicitly avoid R30 for > > Go's sake. > > I thought about limiting the workaround to just

Re: [PATCH 3/3] isystem: delete global -isystem compile option

2021-08-02 Thread Segher Boessenkool
On Mon, Aug 02, 2021 at 09:42:45AM +0300, Alexey Dobriyan wrote: > On Sun, Aug 01, 2021 at 04:32:47PM -0500, Segher Boessenkool wrote: > > On Sun, Aug 01, 2021 at 11:13:36PM +0300, Alexey Dobriyan wrote: > > > In theory, it enables "leakage" of userspace headers into kernel which > > > may present

Re: [PATCH v3 31/41] powerpc/32: Dismantle EXC_XFER_STD/LITE/TEMPLATE

2021-08-02 Thread LEROY Christophe
Le 01/08/2021 à 03:21, Finn Thain a écrit : On Sat, 31 Jul 2021, Christophe Leroy wrote: Stan Johnson contacted me about a regression in mainline that he observed on his G3 Powerbooks. Using 'git bisect' we determined that this patch was the cause of the regression, i.e. commit

Re: Debian SID kernel doesn't boot on PowerBook 3400c

2021-08-02 Thread Christophe Leroy
Le 31/07/2021 à 20:24, Stan Johnson a écrit : Hi Christophe, On 7/31/21 9:58 AM, Christophe Leroy wrote: Stan Johnson a écrit : Hello, The current Debian SID kernel will not boot on a PowerBook 3400c running the latest version of Debian SID. If booted using the BootX extension, the

Re: [PATCH] powerpc/xive: Do not skip CPU-less nodes when creating the IPIs

2021-08-02 Thread Cédric Le Goater
On 8/2/21 8:37 AM, Michael Ellerman wrote: > Cédric Le Goater writes: >> On PowerVM, CPU-less nodes can be populated with hot-plugged CPUs at >> runtime. Today, the IPI is not created for such nodes, and hot-plugged >> CPUs use a bogus IPI, which leads to soft lockups. >> >> We could create the

Re: Possible regression by ab037dd87a2f (powerpc/vdso: Switch VDSO to generic C implementation.)

2021-08-02 Thread Benjamin Herrenschmidt
On Mon, 2021-08-02 at 16:18 +1000, Michael Ellerman wrote: > > But to be fair the ABI of the VDSO has always been a little fishy, > > because the entry points pretend to be a transparent wrapper around > > system calls, but then in a case like this are not. This is somewhat debatable :-) If

Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

2021-08-02 Thread Christophe Leroy
Le 28/07/2021 à 00:26, Tom Lendacky a écrit : Replace occurrences of mem_encrypt_active() with calls to prot_guest_has() with the PATTR_MEM_ENCRYPT attribute. What about https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210730114231.23445-1-w...@kernel.org/ ? Christophe Cc:

Re: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

2021-08-02 Thread kajoljain
On 8/2/21 2:28 PM, Moritz Fischer wrote: > On Mon, Aug 02, 2021 at 01:15:00PM +0530, kajoljain wrote: >> >> >> On 7/13/21 1:12 PM, Kajol Jain wrote: >>> The performance reporting driver added cpu hotplug >>> feature but it didn't add pmu migration call in cpu >>> offline function. >>> This can

Re: [PATCH] powerpc/vdso: Don't use r30 to avoid breaking Go lang

2021-08-02 Thread Michael Ellerman
Michael Ellerman writes: > The Go runtime uses r30 for some special value called 'g'. It assumes > that value will remain unchanged even when calling VDSO functions. > Although r30 is non-volatile across function calls, the callee is free > to use it, as long as the callee saves the value and

Re: [PATCH] powerpc/svm: Don't issue ultracalls if !mem_encrypt_active()

2021-08-02 Thread Michael Ellerman
Will Deacon writes: > Commit ad6c00283163 ("swiotlb: Free tbl memory in swiotlb_exit()") > introduced a set_memory_encrypted() call to swiotlb_exit() so that the > buffer pages are returned to an encrypted state prior to being freed. > > Sachin reports that this leads to the following crash on a

Re: [PATCH 08/11] mm: Remove the now unused mem_encrypt_active() function

2021-08-02 Thread Joerg Roedel
On Tue, Jul 27, 2021 at 05:26:11PM -0500, Tom Lendacky wrote: > The mem_encrypt_active() function has been replaced by prot_guest_has(), > so remove the implementation. > > Signed-off-by: Tom Lendacky Reviewed-by: Joerg Roedel

Re: [PATCH 09/11] x86/sev: Remove the now unused mem_encrypt_active() function

2021-08-02 Thread Joerg Roedel
On Tue, Jul 27, 2021 at 05:26:12PM -0500, Tom Lendacky wrote: > The mem_encrypt_active() function has been replaced by prot_guest_has(), > so remove the implementation. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Signed-off-by: Tom Lendacky Reviewed-by: Joerg Roedel

Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()

2021-08-02 Thread Joerg Roedel
On Tue, Jul 27, 2021 at 05:26:09PM -0500, Tom Lendacky wrote: > @@ -48,7 +47,7 @@ static void sme_sev_setup_real_mode(struct > trampoline_header *th) > if (prot_guest_has(PATTR_HOST_MEM_ENCRYPT)) > th->flags |= TH_FLAGS_SME_ACTIVE; > > - if (sev_es_active()) { > + if

Re: [PATCH 05/11] x86/sev: Replace occurrences of sev_active() with prot_guest_has()

2021-08-02 Thread Joerg Roedel
On Tue, Jul 27, 2021 at 05:26:08PM -0500, Tom Lendacky wrote: > Replace occurrences of sev_active() with the more generic prot_guest_has() > using PATTR_GUEST_MEM_ENCRYPT, except for in arch/x86/mm/mem_encrypt*.c > where PATTR_SEV will be used. If future support is added for other memory >

Re: [PATCH 02/11] x86/sev: Add an x86 version of prot_guest_has()

2021-08-02 Thread Joerg Roedel
On Tue, Jul 27, 2021 at 05:26:05PM -0500, Tom Lendacky wrote: > Introduce an x86 version of the prot_guest_has() function. This will be > used in the more generic x86 code to replace vendor specific calls like > sev_active(), etc. > > While the name suggests this is intended mainly for guests, it

Re: [PATCH 01/11] mm: Introduce a function to check for virtualization protection features

2021-08-02 Thread Joerg Roedel
On Tue, Jul 27, 2021 at 05:26:04PM -0500, Tom Lendacky wrote: > In prep for other protected virtualization technologies, introduce a > generic helper function, prot_guest_has(), that can be used to check > for specific protection attributes, like memory encryption. This is > intended to eliminate

Re: [PATCH 04/11] x86/sme: Replace occurrences of sme_active() with prot_guest_has()

2021-08-02 Thread Joerg Roedel
On Tue, Jul 27, 2021 at 05:26:07PM -0500, Tom Lendacky wrote: > Replace occurrences of sme_active() with the more generic prot_guest_has() > using PATTR_HOST_MEM_ENCRYPT, except for in arch/x86/mm/mem_encrypt*.c > where PATTR_SME will be used. If future support is added for other memory >

Re: [PATCH v2 13/21] s390/pci: don't set failed sg dma_address to DMA_MAPPING_ERROR

2021-08-02 Thread Niklas Schnelle
On Fri, 2021-07-23 at 11:50 -0600, Logan Gunthorpe wrote: > Setting the ->dma_address to DMA_MAPPING_ERROR is not part of > the ->map_sg calling convention, so remove it. > > Link: https://lore.kernel.org/linux-mips/20210716063241.gc13...@lst.de/ > Suggested-by: Christoph Hellwig >

Re: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

2021-08-02 Thread Moritz Fischer
On Mon, Aug 02, 2021 at 01:15:00PM +0530, kajoljain wrote: > > > On 7/13/21 1:12 PM, Kajol Jain wrote: > > The performance reporting driver added cpu hotplug > > feature but it didn't add pmu migration call in cpu > > offline function. > > This can create an issue incase the current designated >

Re: [PATCH 2/2] virtio-console: remove unnecessary kmemdup()

2021-08-02 Thread Xianting Tian
在 2021/8/2 下午4:40, Jiri Slaby 写道: On 02. 08. 21, 10:32, Xianting Tian wrote: 在 2021/8/2 下午3:25, Jiri Slaby 写道: Hi, why is this 2/2? I seem (Lore neither) to find 1/2. You didn't receive 1/2? [PATCH 1/2] tty: hvc: pass DMA capable memory to put_chars() https://lkml.org/lkml/2021/8/1/8

Re: [PATCH 2/2] virtio-console: remove unnecessary kmemdup()

2021-08-02 Thread Jiri Slaby
On 02. 08. 21, 10:32, Xianting Tian wrote: 在 2021/8/2 下午3:25, Jiri Slaby 写道: Hi, why is this 2/2? I seem (Lore neither) to find 1/2. You didn't receive 1/2? [PATCH 1/2] tty: hvc: pass DMA capable memory to put_chars() https://lkml.org/lkml/2021/8/1/8 Oh,

Re: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

2021-08-02 Thread kajoljain
On 7/13/21 1:12 PM, Kajol Jain wrote: > The performance reporting driver added cpu hotplug > feature but it didn't add pmu migration call in cpu > offline function. > This can create an issue incase the current designated > cpu being used to collect fme pmu data got offline, > as based on

[PATCH v4 4/4] powerpc/papr_scm: Document papr_scm sysfs event format entries

2021-08-02 Thread Kajol Jain
Details is added for the event, cpumask and format attributes in the ABI documentation. Acked-by: Peter Zijlstra (Intel) Reviewed-by: Madhavan Srinivasan Tested-by: Nageswara R Sastry Signed-off-by: Kajol Jain --- Documentation/ABI/testing/sysfs-bus-papr-pmem | 31 +++ 1 file

[PATCH v4 3/4] powerpc/papr_scm: Add perf interface support

2021-08-02 Thread Kajol Jain
Performance monitoring support for papr-scm nvdimm devices via perf interface is added which includes addition of pmu functions like add/del/read/event_init for nvdimm_pmu struture. A new parameter 'priv' in added to the pdev_archdata structure to save nvdimm_pmu device pointer, to handle the

[PATCH v4 2/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats

2021-08-02 Thread Kajol Jain
A common interface is added to get performance stats reporting support for nvdimm devices. Added interface includes support for pmu register/unregister functions, cpu hotplug and pmu event functions like event_init/add/read/del. User could use the standard perf tool to access perf events exposed

[PATCH v4 1/4] drivers/nvdimm: Add nvdimm pmu structure

2021-08-02 Thread Kajol Jain
A structure is added, called nvdimm_pmu, for performance stats reporting support of nvdimm devices. It can be used to add nvdimm pmu data such as supported events and pmu event functions like event_init/add/read/del with cpu hotplug support. Acked-by: Peter Zijlstra (Intel) Reviewed-by: Madhavan

[PATCH v4 0/4] Add perf interface to expose nvdimm

2021-08-02 Thread Kajol Jain
Patchset adds performance stats reporting support for nvdimm. Added interface includes support for pmu register/unregister functions. A structure is added called nvdimm_pmu to be used for adding arch/platform specific data such as supported events, cpumask pmu event functions like

Re: [PATCH 2/2] virtio-console: remove unnecessary kmemdup()

2021-08-02 Thread Jiri Slaby
Hi, why is this 2/2? I seem (Lore neither) to find 1/2. On 01. 08. 21, 7:16, Xianting Tian wrote: hvc framework will never pass stack memory to the put_chars() function, Am I blind or missing something? hvc_console_print(...) { char c[N_OUTBUF] ...

Re: [PATCH 3/3] isystem: delete global -isystem compile option

2021-08-02 Thread Alexey Dobriyan
On Sun, Aug 01, 2021 at 04:32:47PM -0500, Segher Boessenkool wrote: > On Sun, Aug 01, 2021 at 11:13:36PM +0300, Alexey Dobriyan wrote: > > In theory, it enables "leakage" of userspace headers into kernel which > > may present licensing problem. > > > -NOSTDINC_FLAGS += -nostdinc -isystem $(shell

Re: [PATCH] powerpc/xive: Do not skip CPU-less nodes when creating the IPIs

2021-08-02 Thread Michael Ellerman
Cédric Le Goater writes: > On PowerVM, CPU-less nodes can be populated with hot-plugged CPUs at > runtime. Today, the IPI is not created for such nodes, and hot-plugged > CPUs use a bogus IPI, which leads to soft lockups. > > We could create the node IPI on demand but it is a bit complex because

RE: Possible regression by ab037dd87a2f (powerpc/vdso: Switch VDSO to generic C implementation.)

2021-08-02 Thread Michael Ellerman
"Paul Murphy" writes: > > (My apologies for however IBM's email client munges this) > >> I heard it is going to be in Go 1.16.7, but I do not know much about Go. >> Maybe the folks in Cc can chime in. > > > We have backports primed and ready for the next point release. They > are waiting on

Re: Possible regression by ab037dd87a2f (powerpc/vdso: Switch VDSO to generic C implementation.)

2021-08-02 Thread Michael Ellerman
Andreas Schwab writes: > On Jul 29 2021, Michael Ellerman wrote: > >> I haven't been able to reproduce the crash by following the instructions >> in your bug report, I have go1.13.8, I guess the crash is only in newer >> versions? > > Yes, only go1.14 and later are affected. > >

Re: [PATCH kernel] powerpc/powernv: Check if powernv_rng is initialized

2021-08-02 Thread Michael Ellerman
Alexey Kardashevskiy writes: > The powernv-rng driver has 2 users - the bare metal powernv platform and > the KVM's H_RANDOM hcall. The hcall handler works fine when it is L0 KVM > but fails in L1 KVM as there is no support for the HW registers in L1 VMs > and such support is not advertised