[PATCH v2] drivers: scsi: replace snprintf in show functions with sysfs_emit

2021-11-01 Thread cgel . zte
From: Jing Yao coccicheck complains about the use of snprintf() in sysfs show functions: WARNING use scnprintf or sprintf Use sysfs_emit instead of scnprintf or sprintf makes more sense. Reported-by: Zeal Robot Signed-off-by: Jing Yao --- drivers/scsi/ibmvscsi/ibmvfc.c | 12 ++-- 1 f

Re: [PATCH v12 1/2] tty: hvc: pass DMA capable memory to put_chars()

2021-11-01 Thread Jiri Slaby
On 28. 10. 21, 17:09, Xianting Tian wrote: As well known, hvc backend can register its opertions to hvc backend. the operations contain put_chars(), get_chars() and so on. Some hvc backend may do dma in its operations. eg, put_chars() of virtio-console. But in the code of hvc framework, it may p

Re: [PATCH kernel 0/4] Fixes for powerpc/pseries/iommu: Make use of DDW for indirect mapping

2021-11-01 Thread Michael Ellerman
On Thu, 21 Oct 2021 00:23:11 +1100, Alexey Kardashevskiy wrote: > Found some issues on SRIOV enabled PHYP. > It probably should be one patch, or not? > > Please comment. Thanks. > > > > [...] Patches 2-4 applied to powerpc/fixes. [2/4] powerpc/pseries/iommu: Use correct vfree for it_map

Re: Fwd: Fwd: X stopped working with 5.14 on iBook

2021-11-01 Thread Finn Thain
Hi Christopher, After many builds and tests, Stan and I were able to determine that this regression only affects builds with CONFIG_USER_NS=y. That is, d3ccc9781560 + CONFIG_USER_NS=y --> fail d3ccc9781560 + CONFIG_USER_NS=n --> okay d3ccc9781560~ + CONFIG_USER_NS=y --> okay d3ccc9781560

[PATCH] powerpc: Fix reference leak of node np in opal_lpc_init

2021-11-01 Thread He Ying
When breaking from for_each_compatible_node body, we increase the reference of node np. Then calling isa_bridge_init_non_pci() will assign np to isa_bridge_devnode. It looks good. However, other error paths in the code should put the node np back to avoid the reference leak. Fix the problem by addi

Re: [PATCH v2 11/45] arm64: Use do_kernel_power_off()

2021-11-01 Thread Catalin Marinas
On Thu, Oct 28, 2021 at 12:16:41AM +0300, Dmitry Osipenko wrote: > Kernel now supports chained power-off handlers. Use do_kernel_power_off() > that invokes chained power-off handlers. It also invokes legacy > pm_power_off() for now, which will be removed once all drivers will > be converted to the

Re: Linux kernel: powerpc: KVM guest can trigger host crash on Power8

2021-11-01 Thread Michal Suchánek
On Fri, Oct 29, 2021 at 02:33:12PM +0200, John Paul Adrian Glaubitz wrote: > Hi Nicholas! > > On 10/29/21 02:41, Nicholas Piggin wrote: > > Soft lockup should mean it's taking timer interrupts still, just not > > scheduling. Do you have the hard lockup detector enabled as well? Is > > there anyth

Re: Linux kernel: powerpc: KVM guest can trigger host crash on Power8

2021-11-01 Thread Michal Suchánek
Hello, On Thu, Oct 28, 2021 at 04:15:19PM +0200, John Paul Adrian Glaubitz wrote: > Hi! > > On 10/28/21 16:05, John Paul Adrian Glaubitz wrote: > > The following packages were being built at the same time: > > > > - guest 1: virtuoso-opensource and openturns > > - guest 2: llvm-toolchain-13 > >

Re: Linux kernel: powerpc: KVM guest can trigger host crash on Power8

2021-11-01 Thread John Paul Adrian Glaubitz
Hi Michael! On 11/1/21 08:37, John Paul Adrian Glaubitz wrote: > I made another experiment and upgraded the host to 5.15-rc7 which contains > your > fixes and made the guests build gcc-10. Interestingly, this time, the gcc-10 > build crashed the guest but didn't manage to crash the host. I will u

Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-11-01 Thread Miroslav Benes
Hi, On Thu, 28 Oct 2021, Christophe Leroy wrote: > This series implements livepatch on PPC32. > > This is largely copied from what's done on PPC64. > > Christophe Leroy (5): > livepatch: Fix build failure on 32 bits processors > powerpc/ftrace: No need to read LR from stack in _mcount() >

Re: ppc64le STRICT_MODULE_RWX and livepatch apply_relocate_add() crashes

2021-11-01 Thread Joe Lawrence
On 11/1/21 5:20 AM, Russell Currey wrote: > I'm looking into this now, will update when there's progress. I > personally wasn't aware but Jordan flagged this as an issue back in > August [0]. Are the selftests in the klp-convert tree sufficient for > testing? I'm not especially familiar with liv

[PATCH] powerpc/44x/fsp2: Add missing of_node_put in node_irq_request

2021-11-01 Thread He Ying
Early exits from for_each_compatible_node() should decrement the node reference counter. Signed-off-by: He Ying --- arch/powerpc/platforms/44x/fsp2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/platforms/44x/fsp2.c b/arch/powerpc/platforms/44x/fsp2.c index b299e43f5ef9..8

Re: ppc64le STRICT_MODULE_RWX and livepatch apply_relocate_add() crashes

2021-11-01 Thread Russell Currey
On Sun, 2021-10-31 at 22:43 -0400, Joe Lawrence wrote: > Starting with 5.14 kernels, I can reliably reproduce a crash [1] on > ppc64le when loading livepatches containing late klp-relocations [2]. > These are relocations, specific to livepatching, that are resolved not > when a livepatch module is

[PATCH] powerpc/xmon: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-11-01 Thread cgel . zte
From: Changcheng Deng Fix the following coccicheck warning: ./arch/powerpc/xmon/xmon.c: 4064: 0-23: WARNING: xmon_dbgfs_ops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Zeal Robot Signed-off-by: Changcheng Deng --- arch/powerpc/xmon/xmon.c | 2 +- 1 file changed, 1 insertion(

Re: Linux kernel: powerpc: KVM guest can trigger host crash on Power8

2021-11-01 Thread John Paul Adrian Glaubitz
Hi Michael! On 11/1/21 07:53, Michael Ellerman wrote: > Sure, will give that a try. > > I was able to crash my machine over the weekend, building openjdk, but I > haven't been able to reproduce it for ~24 hours now (I didn't change > anything). I made another experiment and upgraded the host to