Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-11-24 Thread Christophe Leroy
Le 24/11/2021 à 23:34, Michael Ellerman a écrit : Christophe Leroy writes: This series implements livepatch on PPC32. This is largely copied from what's done on PPC64. Christophe Leroy (5): livepatch: Fix build failure on 32 bits processors powerpc/ftrace: No need to read LR from sta

Re: [PATCH] powerpc/eeh: Delay slot presence check once driver is notified about the pci error.

2021-11-24 Thread Mahesh J Salgaonkar
On 2021-11-24 22:57:13 Wed, Oliver O'Halloran wrote: > On Wed, Nov 24, 2021 at 7:45 PM Mahesh J Salgaonkar > wrote: > > > > No it doesn't. We will still do a presence check before the recovery > > process starts. This patch moves the check after notifying the driver to > > stop active I/O operatio

Re: [PATCH v2 2/2] powerpc:85xx: fix timebase sync issue when CONFIG_HOTPLUG_CPU=n

2021-11-24 Thread Martin Kennedy
Hi there, I have bisected OpenWrt master, and then the Linux kernel down to this change, to confirm that this change causes a kernel panic on my P1020RDB-based, dual-core Aerohive HiveAP 370, at initialization of the second CPU: : [0.00] Linux version 5.10.80 (labby@lobon) (powerpc-openwr

[PATCH 2/2] tools/perf: Update global/local variants for p_stage_cyc in powerpc

2021-11-24 Thread Athira Rajeev
Update the arch_support_sort_key() function in powerpc to enable presenting local and global variants of sort key: p_stage_cyc. Update the "se_header" strings for these in arch_perf_header_entry() function along with instruction latency. Signed-off-by: Athira Rajeev Reported-by: Namhyung Kim ---

[PATCH 1/2] tools/perf: Include global and local variants for p_stage_cyc sort key

2021-11-24 Thread Athira Rajeev
Sort key p_stage_cyc is used to present the latency cycles spend in pipeline stages. perf tool has local p_stage_cyc sort key to display this info. There is no global variant available for this sort key. local variant shows latency in a sinlge sample, whereas, global value will be useful to present

Re: [PATCH 1/1] futex: Wireup futex_waitv syscall

2021-11-24 Thread Thomas Gleixner
On Wed, Nov 24 2021 at 15:29, Arnd Bergmann wrote: > On Wed, Nov 24, 2021 at 2:21 PM André Almeida > wrote: >> >> Wireup futex_waitv syscall for all remaining archs. >> >> Signed-off-by: André Almeida > > Reviewed-by: Arnd Bergmann > > I double-checked that futex_waitv() doesn't need any archit

Re: [PATCH 1/1] futex: Wireup futex_waitv syscall

2021-11-24 Thread Michael Ellerman
André Almeida writes: > diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl > b/arch/powerpc/kernel/syscalls/syscall.tbl > index 7bef917cc84e..15109af9d075 100644 > --- a/arch/powerpc/kernel/syscalls/syscall.tbl > +++ b/arch/powerpc/kernel/syscalls/syscall.tbl > @@ -528,3 +528,4 @@ > 446 comm

Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-11-24 Thread Michael Ellerman
Christophe Leroy writes: > This series implements livepatch on PPC32. > > This is largely copied from what's done on PPC64. > > Christophe Leroy (5): > livepatch: Fix build failure on 32 bits processors > powerpc/ftrace: No need to read LR from stack in _mcount() > powerpc/ftrace: Add module

Re: [PATCH 0/8] Convert powerpc to default topdown mmap layout

2021-11-24 Thread Christophe Leroy
Le 24/11/2021 à 14:40, Christophe Leroy a écrit : Le 24/11/2021 à 14:21, Nicholas Piggin a écrit : Excerpts from Christophe Leroy's message of November 22, 2021 6:48 pm: This series converts powerpc to default topdown mmap layout. powerpc provides its own arch_get_unmapped_area() only whe

Re: [PATCH 1/1] futex: Wireup futex_waitv syscall

2021-11-24 Thread Max Filippov
On Wed, Nov 24, 2021 at 5:21 AM André Almeida wrote: > > Wireup futex_waitv syscall for all remaining archs. > > Signed-off-by: André Almeida > --- > arch/alpha/kernel/syscalls/syscall.tbl | 1 + > arch/ia64/kernel/syscalls/syscall.tbl | 1 + > arch/m68k/kernel/syscalls/syscall.tbl

Re: [PATCH 0/3] of/fdt: Rework early FDT scanning functions

2021-11-24 Thread Frank Rowand
On 11/18/21 1:12 PM, Rob Herring wrote: > The early FDT scanning functions use of_scan_flat_dt() which implements > its own node walking method. This function predates libfdt and is an > unnecessary indirection. This series reworks > early_init_dt_scan_chosen(), early_init_dt_scan_root(), and >

Re: [PATCH 3/3] of/fdt: Rework early_init_dt_scan_memory() to call directly

2021-11-24 Thread Frank Rowand
On 11/18/21 1:12 PM, Rob Herring wrote: > Use of the of_scan_flat_dt() function predates libfdt and is discouraged > as libfdt provides a nicer set of APIs. Rework > early_init_dt_scan_memory() to be called directly and use libfdt. > > Cc: John Crispin > Cc: Thomas Bogendoerfer > Cc: Michael Ell

Re: [PATCH 2/3] of/fdt: Rework early_init_dt_scan_root() to call directly

2021-11-24 Thread Frank Rowand
On 11/18/21 1:12 PM, Rob Herring wrote: > Use of the of_scan_flat_dt() function predates libfdt and is discouraged > as libfdt provides a nicer set of APIs. Rework early_init_dt_scan_root() > to be called directly and use libfdt. > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul M

Re: [PATCH 1/3] of/fdt: Rework early_init_dt_scan_chosen() to call directly

2021-11-24 Thread Frank Rowand
On 11/18/21 1:12 PM, Rob Herring wrote: > Use of the of_scan_flat_dt() function predates libfdt and is discouraged > as libfdt provides a nicer set of APIs. Rework > early_init_dt_scan_chosen() to be called directly and use libfdt. > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul

Re: [PATCH 1/1] futex: Wireup futex_waitv syscall

2021-11-24 Thread André Almeida
Às 11:29 de 24/11/21, Arnd Bergmann escreveu: > On Wed, Nov 24, 2021 at 2:21 PM André Almeida > wrote: >> >> Wireup futex_waitv syscall for all remaining archs. >> >> Signed-off-by: André Almeida > > Reviewed-by: Arnd Bergmann > > I double-checked that futex_waitv() doesn't need any architect

[PATCH] recordmcount: Support empty section from recent binutils

2021-11-24 Thread Christophe Leroy
Looks like recent binutils (2.36 and over ?) may empty some section, leading to failure like: Cannot find symbol for section 11: .text.unlikely. kernel/kexec_file.o: failed make[1]: *** [scripts/Makefile.build:287: kernel/kexec_file.o] Error 1 In order to avoid that, ensur

Re: [PATCH 1/1] futex: Wireup futex_waitv syscall

2021-11-24 Thread Arnd Bergmann
On Wed, Nov 24, 2021 at 2:21 PM André Almeida wrote: > > Wireup futex_waitv syscall for all remaining archs. > > Signed-off-by: André Almeida Reviewed-by: Arnd Bergmann I double-checked that futex_waitv() doesn't need any architecture specific hacks, and that the list above is complete. Shoul

Re: [PATCH 1/1] futex: Wireup futex_waitv syscall

2021-11-24 Thread Geert Uytterhoeven
On Wed, Nov 24, 2021 at 2:21 PM André Almeida wrote: > Wireup futex_waitv syscall for all remaining archs. > > Signed-off-by: André Almeida > arch/m68k/kernel/syscalls/syscall.tbl | 1 + Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeve

Re: [PATCH 1/8] powerpc/mm: Make slice specific to book3s/64

2021-11-24 Thread Christophe Leroy
Le 24/11/2021 à 13:10, Christophe Leroy a écrit : Le 22/11/2021 à 15:48, kernel test robot a écrit : Hi Christophe, I love your patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on hnaz-mm/master linus/master v5.16-rc2 next-2028]

[PATCH 1/1] futex: Wireup futex_waitv syscall

2021-11-24 Thread André Almeida
Wireup futex_waitv syscall for all remaining archs. Signed-off-by: André Almeida --- arch/alpha/kernel/syscalls/syscall.tbl | 1 + arch/ia64/kernel/syscalls/syscall.tbl | 1 + arch/m68k/kernel/syscalls/syscall.tbl | 1 + arch/microblaze/kernel/syscalls/syscall.tbl | 1 + arch/po

Re: [PATCH v2 6/8] inotify: simplify subdirectory registration with register_sysctl()

2021-11-24 Thread Luis Chamberlain
On Wed, Nov 24, 2021 at 10:44:09AM +0100, Jan Kara wrote: > On Tue 23-11-21 12:24:20, Luis Chamberlain wrote: > > From: Xiaoming Ni > > > > There is no need to user boiler plate code to specify a set of base > > directories we're going to stuff sysctls under. Simplify this by using > > register_s

Re: [PATCH 0/8] Convert powerpc to default topdown mmap layout

2021-11-24 Thread Christophe Leroy
Le 24/11/2021 à 14:21, Nicholas Piggin a écrit : Excerpts from Christophe Leroy's message of November 22, 2021 6:48 pm: This series converts powerpc to default topdown mmap layout. powerpc provides its own arch_get_unmapped_area() only when slices are needed, which is only for book3s/64. Fir

Re: [PATCH 0/3] KEXEC_SIG with appended signature

2021-11-24 Thread Michal Suchánek
On Wed, Nov 24, 2021 at 08:10:10AM -0500, Mimi Zohar wrote: > On Wed, 2021-11-24 at 12:09 +0100, Philipp Rudo wrote: > > Now Michal wants to adapt KEXEC_SIG for ppc too so distros can rely on all > > architectures using the same mechanism and thus reduce maintenance cost. > > On the way there he ev

Re: [PATCH 0/8] Convert powerpc to default topdown mmap layout

2021-11-24 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of November 22, 2021 6:48 pm: > This series converts powerpc to default topdown mmap layout. > > powerpc provides its own arch_get_unmapped_area() only when > slices are needed, which is only for book3s/64. First part of > the series moves slices into book3

[PATCH 5.15 258/279] signal/powerpc: On swapcontext failure force SIGSEGV

2021-11-24 Thread Greg Kroah-Hartman
From: Eric W. Biederman commit 83a1f27ad773b1d8f0460d3a676114c7651918cc upstream. If the register state may be partial and corrupted instead of calling do_exit, call force_sigsegv(SIGSEGV). Which properly kills the process with SIGSEGV and does not let any more userspace code execute, instead o

Re: [PATCH v3 2/2] pseries/mce: Refactor the pseries mce handling code

2021-11-24 Thread Nicholas Piggin
Excerpts from Ganesh Goudar's message of November 24, 2021 7:55 pm: > Now that we are no longer switching on the mmu in realmode > mce handler, Revert the commit 4ff753feab02("powerpc/pseries: > Avoid using addr_to_pfn in real mode") partially, which > introduced functions mce_handle_err_virtmode/r

Re: [PATCH 0/3] KEXEC_SIG with appended signature

2021-11-24 Thread Mimi Zohar
On Wed, 2021-11-24 at 12:09 +0100, Philipp Rudo wrote: > Now Michal wants to adapt KEXEC_SIG for ppc too so distros can rely on all > architectures using the same mechanism and thus reduce maintenance cost. > On the way there he even makes some absolutely reasonable improvements > for everybody. >

Re: [PATCH v3 1/2] powerpc/mce: Avoid using irq_work_queue() in realmode

2021-11-24 Thread Nicholas Piggin
Excerpts from Ganesh Goudar's message of November 24, 2021 7:54 pm: > In realmode mce handler we use irq_work_queue() to defer > the processing of mce events, irq_work_queue() can only > be called when translation is enabled because it touches > memory outside RMA, hence we enable translation befor

Re: [PATCH 1/8] powerpc/mm: Make slice specific to book3s/64

2021-11-24 Thread Christophe Leroy
Le 22/11/2021 à 22:10, kernel test robot a écrit : Hi Christophe, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on hnaz-mm/master linus/master v5.16-rc2 next-2028] [If your patch is applied to the wrong git tree, kindly drop u

Re: [PATCH 1/8] powerpc/mm: Make slice specific to book3s/64

2021-11-24 Thread Christophe Leroy
Le 22/11/2021 à 15:48, kernel test robot a écrit : Hi Christophe, I love your patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on hnaz-mm/master linus/master v5.16-rc2 next-2028] [If your patch is applied to the wrong git tree, kindl

Re: [PATCH] powerpc/eeh: Delay slot presence check once driver is notified about the pci error.

2021-11-24 Thread Oliver O'Halloran
On Wed, Nov 24, 2021 at 12:05 AM Mahesh Salgaonkar wrote: > > *snip* > > This causes the EEH handler to get stuck for ~6 > seconds before it could notify that the pci error has been detected and > stop any active operations. Hence with running I/O traffic, during this 6 > seconds, the network driv

Re: [PATCH] powerpc/eeh: Delay slot presence check once driver is notified about the pci error.

2021-11-24 Thread Oliver O'Halloran
On Wed, Nov 24, 2021 at 7:45 PM Mahesh J Salgaonkar wrote: > > No it doesn't. We will still do a presence check before the recovery > process starts. This patch moves the check after notifying the driver to > stop active I/O operations. If a presence check finds the device isn't > present, we will

Re: [PATCH 0/3] KEXEC_SIG with appended signature

2021-11-24 Thread Philipp Rudo
Hi Mimi, On Fri, 19 Nov 2021 13:16:20 -0500 Mimi Zohar wrote: > On Fri, 2021-11-19 at 12:18 +0100, Michal Suchánek wrote: > > Maybe I was not clear enough. If you happen to focus on an architecture > > that supports IMA fully it's great. > > > > My point of view is maintaining multiple architec

[PATCH v3 1/2] powerpc/mce: Avoid using irq_work_queue() in realmode

2021-11-24 Thread Ganesh Goudar
In realmode mce handler we use irq_work_queue() to defer the processing of mce events, irq_work_queue() can only be called when translation is enabled because it touches memory outside RMA, hence we enable translation before calling irq_work_queue and disable on return, though it is not safe to do

[PATCH v3 2/2] pseries/mce: Refactor the pseries mce handling code

2021-11-24 Thread Ganesh Goudar
Now that we are no longer switching on the mmu in realmode mce handler, Revert the commit 4ff753feab02("powerpc/pseries: Avoid using addr_to_pfn in real mode") partially, which introduced functions mce_handle_err_virtmode/realmode() to separate mce handler code which needed translation to enabled.

Re: [PATCH v2 4/8] ocfs2: simplify subdirectory registration with register_sysctl()

2021-11-24 Thread Jan Kara
On Tue 23-11-21 12:24:18, Luis Chamberlain wrote: > There is no need to user boiler plate code to specify a set of base > directories we're going to stuff sysctls under. Simplify this by using > register_sysctl() and specifying the directory path directly. > > // pycocci sysctl-subdir-register-sys

Re: [PATCH v2 6/8] inotify: simplify subdirectory registration with register_sysctl()

2021-11-24 Thread Jan Kara
On Tue 23-11-21 12:24:20, Luis Chamberlain wrote: > From: Xiaoming Ni > > There is no need to user boiler plate code to specify a set of base > directories we're going to stuff sysctls under. Simplify this by using > register_sysctl() and specifying the directory path directly. > > Move inotify_

[PATCH 6/6] powerpc: Mark probe_machine() __init and static

2021-11-24 Thread Michael Ellerman
Prior to commit b1923caa6e64 ("powerpc: Merge 32-bit and 64-bit setup_arch()") probe_machine() was called from setup_32/64.c and lived in setup-common.c. But now it's only called from setup-common.c so it can be static and __init, and we don't need the declaration in machdep.h either. Signed-off-b

[PATCH 5/6] powerpc/smp: Move setup_profiling_timer() under CONFIG_PROFILING

2021-11-24 Thread Michael Ellerman
setup_profiling_timer() is only needed when CONFIG_PROFILING is enabled. Fixes the following W=1 warning when CONFIG_PROFILING=n: linux/arch/powerpc/kernel/smp.c:1638:5: error: no previous prototype for ‘setup_profiling_timer’ Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/smp.c | 2

[PATCH 4/6] powerpc/mm: Move tlbcam_sz() and make it static

2021-11-24 Thread Michael Ellerman
Building with W=1 we see a warning: linux/arch/powerpc/mm/nohash/fsl_book3e.c:63:15: error: no previous prototype for ‘tlbcam_sz’ tlbcam_sz() is not used outside this file, so we can make it static. However it's only used inside #ifdef CONFIG_PPC32, so move it within that ifdef, otherwise we wo

[PATCH 3/6] powerpc/85xx: Make c293_pcie_pic_init() static

2021-11-24 Thread Michael Ellerman
To fix the W=1 warning: linux/arch/powerpc/platforms/85xx/c293pcie.c:22:13: error: no previous prototype for ‘c293_pcie_pic_init’ Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/85xx/c293pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platfor

[PATCH 1/6] powerpc/85xx: Fix no previous prototype warning for mpc85xx_setup_pmc()

2021-11-24 Thread Michael Ellerman
Fixes the following W=1 warning: arch/powerpc/platforms/85xx/mpc85xx_pm_ops.c:89:12: warning: no previous prototype for 'mpc85xx_setup_pmc' Reported-by: kernel test robot Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/85xx/mpc85xx_pm_ops.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH 2/6] powerpc/85xx: Make mpc85xx_smp_kexec_cpu_down() static

2021-11-24 Thread Michael Ellerman
To fix the W=1 warning: arch/powerpc/platforms/85xx/smp.c:369:6: error: no previous prototype for ‘mpc85xx_smp_kexec_cpu_down’ Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/85xx/smp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/8

Re: [PATCH v2 1/2] powerpc/mce: Avoid using irq_work_queue() in realmode

2021-11-24 Thread kernel test robot
Hi Ganesh, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.16-rc2 next-20211124] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as doc

Re: [PATCH] powerpc/eeh: Delay slot presence check once driver is notified about the pci error.

2021-11-24 Thread Mahesh J Salgaonkar
On 2021-11-24 10:14:30 Wed, Michael Ellerman wrote: > Mahesh Salgaonkar writes: > > When certain PHB HW failure causes phyp to recover PHB, it marks the PE > > state as temporarily unavailable until recovery is complete. This also > > triggers an EEH handler in Linux which needs to notify drivers,