Re: code conditional on non-existing PPC_EARLY_DEBUG_MICROWATT.

2021-12-25 Thread Michael Ellerman
Christophe Leroy writes: > Le 23/12/2021 à 11:21, Lukas Bulwahn a écrit : >> Dear Benjamin, dear Paul, dear Michael, >> >> with commit 48b545b8018d ("powerpc/microwatt: Use standard 16550 UART >> for console"), you have some code in arch/powerpc/kernel/udbg_16550.c, >> conditional on the Kconfig

Re: [PATCH V2 5/8] sched: s390: Remove unused TASK_SIZE_OF

2021-12-25 Thread Heiko Carstens
On Sat, Dec 25, 2021 at 12:54:27PM +0800, guo...@kernel.org wrote: > From: Guo Ren > > This macro isn't used in Linux sched, now. Delete in > include/linux/sched.h and arch's include/asm. > > Signed-off-by: Guo Ren > Reviewed-by: Arnd Bergmann > --- > arch/s390/include/asm/processor.h | 3

Re: [PATCH] Revert "mm/usercopy: Drop extra is_vmalloc_or_module() check"

2021-12-25 Thread Nicholas Piggin
Excerpts from Kefeng Wang's message of December 25, 2021 12:05 pm: > > On 2021/12/24 21:18, Christophe Leroy wrote: >> >> Le 24/12/2021 à 08:06, Kefeng Wang a écrit : >>> On 2021/12/24 14:01, Christophe Leroy wrote: Le 23/12/2021 à 11:21, Kefeng Wang a écrit : > This reverts commit

Re: [BISECTED] power8: watchdog: CPU 3 self-detected hard LOCKUP @ queued_spin_lock_slowpath+0x154/0x2d0

2021-12-25 Thread Nicholas Piggin
Excerpts from Stijn Tintel's message of December 22, 2021 11:20 am: > Hi, > > After upgrading my Power8 server from 5.10 LTS to 5.15 LTS, I started > experiencing CPU hard lockups, usually rather quickly after boot: > > > watchdog: CPU 3 self-detected hard LOCKUP @ >

Re: [PATCH 3/3] KVM: PPC: Book3S HV: Free allocated memory if module init fails

2021-12-25 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of December 24, 2021 7:19 am: > The module's exit function is not called when the init fails, we need > to do cleanup before returning. > > Signed-off-by: Fabiano Rosas > --- > arch/powerpc/kvm/book3s_hv.c | 15 +++ > 1 file changed, 11

Re: [PATCH 2/3] KVM: PPC: Book3S HV: Delay setting of kvm ops

2021-12-25 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of December 24, 2021 7:19 am: > Delay the setting of kvm_hv_ops until after all init code has > completed. This avoids leaving the ops still accessible if the init > fails. > > Signed-off-by: Fabiano Rosas Also looks okay to me but KVM init has lots of

Re: [PATCH 1/3] KVM: PPC: Book3S HV: Check return value of kvmppc_radix_init

2021-12-25 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of December 24, 2021 7:19 am: > The return of the function is being shadowed by the call to > kvmppc_uvmem_init. > Reviewed-by: Nicholas Piggin > Fixes: ca9f4942670c ("KVM: PPC: Book3S HV: Support for running secure guests") > Signed-off-by: Fabiano Rosas

Re: [PATCH 3/3] KVM: PPC: Fix mmio length message

2021-12-25 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of December 24, 2021 7:15 am: > We check against 'bytes' but print 'run->mmio.len' which at that point > has an old value. > > e.g. 16-byte load: > > before: > __kvmppc_handle_load: bad MMIO length: 8 > > now: > __kvmppc_handle_load: bad MMIO length: 16 >

Re: [PATCH 2/3] KVM: PPC: Fix vmx/vsx mixup in mmio emulation

2021-12-25 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of December 24, 2021 7:15 am: > The MMIO emulation code for vector instructions is duplicated between > VSX and VMX. When emulating VMX we should check the VMX copy size > instead of the VSX one. > > Fixes: acc9eb9305fe ("KVM: PPC: Reimplement

Re: [PATCH 1/3] KVM: PPC: Book3S HV: Stop returning internal values to userspace

2021-12-25 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of December 24, 2021 7:15 am: > Our kvm_arch_vcpu_ioctl_run currently returns the RESUME_HOST values > to userspace, against the API of the KVM_RUN ioctl which returns 0 on > success. > > Signed-off-by: Fabiano Rosas > --- > This was noticed while enabling

Re: [PATCH 4/5] powerpc/64: Add VIRTUAL_BUG_ON checks for __va and __pa addresses

2021-12-25 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of December 24, 2021 11:24 pm: > Hi Nic, > > Le 24/07/2019 à 10:46, Nicholas Piggin a écrit : >> Ensure __va is given a physical address below PAGE_OFFSET, and __pa is >> given a virtual address above PAGE_OFFSET. >> >> Signed-off-by: Nicholas Piggin >>