Re: [PATCH v4 1/2] PCI/AER: Disable AER service when link is in L2/L3 ready, L2 and L3 state

2022-06-30 Thread Kai-Heng Feng
On Sat, Apr 23, 2022 at 6:26 AM Bjorn Helgaas wrote: > > [+cc Rafael, linux-pm; sorry forgot this last time] > > On Fri, Apr 22, 2022 at 05:24:36PM -0500, Bjorn Helgaas wrote: > > On Fri, Apr 08, 2022 at 11:31:58PM +0800, Kai-Heng Feng wrote: > > > On Intel Alder Lake platforms, Thunderbolt

Re: [PATCH 5.15 00/28] 5.15.52-rc1 review

2022-06-30 Thread Bagas Sanjaya
On Thu, Jun 30, 2022 at 03:46:56PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.15.52 release. > There are 28 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH] freescale/fs_enet:fix repeated words in comments

2022-06-30 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Wed, 29 Jun 2022 20:54:41 +0800 you wrote: > Delete the redundant word 'a'. > > Signed-off-by: Jilin Yuan > --- > drivers/net/ethernet/freescale/fs_enet/fs_enet.h | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH v4 4/5] of: kexec: Refactor IMA buffer related functions to make them reusable

2022-06-30 Thread Stefan Berger
Refactor IMA buffer related functions to make them reusable for carrying TPM logs across kexec. Signed-off-by: Stefan Berger Cc: Rob Herring Cc: Frank Rowand Cc: Mimi Zohar --- v4: - Move debug output into setup_buffer() --- drivers/of/kexec.c | 131

[PATCH v4 1/5] of: check previous kernel's ima-kexec-buffer against memory bounds

2022-06-30 Thread Stefan Berger
From: Vaibhav Jain Presently ima_get_kexec_buffer() doesn't check if the previous kernel's ima-kexec-buffer lies outside the addressable memory range. This can result in a kernel panic if the new kernel is booted with 'mem=X' arg and the ima-kexec-buffer was allocated beyond that range by the

[PATCH v4 3/5] tpm: of: Make of-tree specific function commonly available

2022-06-30 Thread Stefan Berger
Simplify tpm_read_log_of() by moving reusable parts of the code into an inline function that makes it commonly available so it can be used also for kexec support. Call the new of_tpm_get_sml_parameters() function from the TPM Open Firmware driver. Signed-off-by: Stefan Berger Cc: Jarkko Sakkinen

[PATCH v4 5/5] tpm/kexec: Duplicate TPM measurement log in of-tree for kexec

2022-06-30 Thread Stefan Berger
The memory area of the TPM measurement log is currently not properly duplicated for carrying it across kexec when an Open Firmware Devicetree is used. Therefore, the contents of the log get corrupted. Fix this for the kexec_file_load() syscall by allocating a buffer and copying the contents of the

[PATCH v4 2/5] drivers: of: kexec ima: Support 32-bit platforms

2022-06-30 Thread Stefan Berger
From: Palmer Dabbelt RISC-V recently added kexec_file() support, which uses enables kexec IMA. We're the first 32-bit platform to support this, so we found a build bug. [ Several tags removed; for testing by krobot ] Signed-off-by: Palmer Dabbelt --- drivers/of/kexec.c | 4 ++-- 1 file

[PATCH v4 0/5] tpm: Preserve TPM measurement log across kexec (ppc64)

2022-06-30 Thread Stefan Berger
The of-tree subsystem does not currently preserve the IBM vTPM 1.2 and vTPM 2.0 measurement logs across a kexec on PowerVM and PowerKVM. This series fixes this for the kexec_file_load() syscall using the flattened device tree (fdt) to carry the TPM measurement log's buffer across kexec. Stefan

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-30 Thread Michael Schmitz
Hi Christoph, On 29/06/22 18:25, Christoph Hellwig wrote: On Wed, Jun 29, 2022 at 09:38:00AM +1200, Michael Schmitz wrote: That's one of the 'liberties' I alluded to. The reason I left these in is that I'm none too certain what device feature the DMA API uses to decide a device isn't

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-30 Thread Michael Schmitz
Hi Christoph, On 29/06/22 18:21, Christoph Hellwig wrote: On Wed, Jun 29, 2022 at 11:09:00AM +1200, Michael Schmitz wrote: And all SCSI buffers are allocated using kmalloc? No way at all for user space to pass unaligned data? Most that you will see actually comes from the page allocator. But

[Bug 216190] 5.19-rc4 kernel + KASAN fails to boot at very early stage when CONFIG_SMP=y is selected (PowerMac G4 3,6)

2022-06-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216190 --- Comment #2 from Christophe Leroy (christophe.le...@csgroup.eu) --- Problem is likely due to commit 4291d085b0b0 ("powerpc/32s: Make pte_update() non atomic on 603 core") kasan_early_init() calls __set_pte_at(), which calls pte_update() if

WARN at crypto/testmgr.c:5774 (next)

2022-06-30 Thread Sachin Sant
Following warning is seen while booting recent -next kernel on IBM Power server. [1.544420] [ cut here ] [1.544422] alg: self-tests for rsa-generic (rsa) failed (rc=-22) [1.544429] WARNING: CPU: 18 PID: 512 at crypto/testmgr.c:5774 alg_test+0x42c/0x850 [

Re: [PATCH v3 0/2] powerpc rng cleanups

2022-06-30 Thread Jason A. Donenfeld
s(+), 51 deletions(-) > > > > I tried these 2 patches + previous one (to fix kobject warning) on > top of 5.19.0-rc4-next-20220630 next on a Power8 server. > > 5.19.0-rc4-next-20220630 + > powerpc/powernv: delay rng of node creation until later in boot + > powerpc/pow

Re: [PATCH v3 0/2] powerpc rng cleanups

2022-06-30 Thread Sachin Sant
t; arch/powerpc/platforms/powernv/rng.c | 65 ++- > drivers/char/hw_random/powernv-rng.c | 2 +- > 4 files changed, 30 insertions(+), 51 deletions(-) > I tried these 2 patches + previous one (to fix kobject warning) on top of 5.19.0-rc4-next-20220630 next on a Power8 server.

Re: [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON()

2022-06-30 Thread Segher Boessenkool
On Thu, Jun 30, 2022 at 04:07:47PM +0530, Naveen N. Rao wrote: > Objtool classifies 'ud2' as INSN_BUG, and 'int3' as INSN_TRAP. In x86 > BUG(), there is no need for an annotation since objtool assumes that > 'ud2' terminates control flow. But, for __WARN_FLAGS(), since 'ud2' is > used, an

[PATCH v3 2/2] powerpc/kvm: don't crash on missing rng, and use darn

2022-06-30 Thread Jason A. Donenfeld
On POWER8 systems that don't have ibm,power-rng available, a guest that ignores the KVM_CAP_PPC_HWRNG flag and calls H_RANDOM anyway will dereference a NULL pointer. And on machines with darn instead of ibm,power-rng, H_RANDOM won't work at all. This patch kills two birds with one stone, by

[PATCH v3 0/2] powerpc rng cleanups

2022-06-30 Thread Jason A. Donenfeld
These are two small cleanups for -next. I'm sending this v3 because very likely https://lore.kernel.org/all/20220630121654.1939181-1-ja...@zx2c4.com/ will land first, in which case this needs a small adjustment. Jason A. Donenfeld (2): powerpc/powernv: rename remaining rng powernv_ functions

[PATCH v3 1/2] powerpc/powernv: rename remaining rng powernv_ functions to pnv_

2022-06-30 Thread Jason A. Donenfeld
The preferred nomenclature is pnv_, not powernv_, but rng.c used powernv_ for some reason, which isn't consistent with the rest. A recent commit added a few pnv_ functions to rng.c, making the file a bit of a mishmash. This commit just replaces the rest of them. Cc: Michael Ellerman Fixes:

Re: [PATCH] powerpc/powernv: delay rng of node creation until later in boot

2022-06-30 Thread Sachin Sant
> On 30-Jun-2022, at 5:46 PM, Jason A. Donenfeld wrote: > > The of node for the rng must be created much later in boot. Otherwise it > tries to connect to a parent that doesn't yet exist, resulting on this > splat: > > [0.000478] kobject: '(null)' ((ptrval)): is not initialized,

[Bug 215389] pagealloc: memory corruption at building glibc-2.33 and running its' testsuite

2022-06-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215389 --- Comment #32 from Erhard F. (erhar...@mailbox.org) --- (In reply to Michael Ellerman from comment #30) > It's a bit of a stab in the dark, but can you try turning preempt off? > > ie. CONFIG_PREEMPT_NONE=y Looks like your intuition was not

Re: [PATCH v4.9] kexec_file: drop weak attribute from arch_kexec_apply_relocations[_add]

2022-06-30 Thread Greg KH
On Tue, Jun 28, 2022 at 09:12:48PM +0530, Naveen N. Rao wrote: > commit 3e35142ef99fe6b4fe5d834ad43ee13cca10a2dc upstream. > > Since commit d1bcae833b32f1 ("ELF: Don't generate unused section > symbols") [1], binutils (v2.36+) started dropping section symbols that > it thought were unused. This

[PATCH] powerpc/powernv: delay rng of node creation until later in boot

2022-06-30 Thread Jason A. Donenfeld
The of node for the rng must be created much later in boot. Otherwise it tries to connect to a parent that doesn't yet exist, resulting on this splat: [0.000478] kobject: '(null)' ((ptrval)): is not initialized, yet kobject_get() is being called. [0.002925] [c2a0fb30]

Re: [next-20220629] kobject warnings during boot

2022-06-30 Thread Jason A. Donenfeld
Hi Sachin, On Thu, Jun 30, 2022 at 05:01:57PM +0530, Sachin Sant wrote: > [0.000478] kobject: '(null)' ((ptrval)): is not initialized, yet > kobject_get() is being called. > [0.002925] [c2a0fb30] [c073b0bc] kobject_get+0x8c/0x100 > (unreliable) > [0.003071]

[next-20220629] kobject warnings during boot

2022-06-30 Thread Sachin Sant
While booting linux-next (5.19.0-rc4-next-20220629) on Power8 non-virtualised following koject warning is seen: [0.000184] clocksource: timebase mult[1f4] shift[24] registered [0.000303] clockevent: decrementer mult[83126e98] shift[32] cpu[0] [0.000397] [ cut here

Re: [PATCH v5.18] powerpc/ftrace: Remove ftrace init tramp once kernel init is complete

2022-06-30 Thread Greg KH
On Mon, Jun 27, 2022 at 11:09:29PM +0530, Naveen N. Rao wrote: > commit 84ade0a6655bee803d176525ef457175cbf4df22 upstream. > > Stop using the ftrace trampoline for init section once kernel init is > complete. > > Fixes: 67361cf8071286 ("powerpc/ftrace: Handle large kernel configs") > Cc:

Re: [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON()

2022-06-30 Thread Naveen N. Rao
Christophe Leroy wrote: Le 30/06/2022 à 10:05, Naveen N. Rao a écrit : Christophe Leroy wrote: The builtin variant of unreachable (__builtin_unreachable()) works. How about using that instead of unreachable() ? In fact the problem comes from the macro annotate_unreachable() which is

Re: [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON()

2022-06-30 Thread Christophe Leroy
Le 30/06/2022 à 11:58, Christophe Leroy a écrit : Le 30/06/2022 à 10:05, Naveen N. Rao a écrit : Christophe Leroy wrote: Hi Sathvika, Adding ARM people as they seem to face the same kind of problem (see

RE: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-30 Thread David Laight
From: Christophe Leroy > Sent: 30 June 2022 10:40 > > Le 30/06/2022 à 10:04, David Laight a écrit : > > From: Michael Schmitz > >> Sent: 29 June 2022 00:09 > >> > >> Hi Arnd, > >> > >> On 29/06/22 09:50, Arnd Bergmann wrote: > >>> On Tue, Jun 28, 2022 at 11:03 PM Michael Schmitz > >>> wrote: >

Re: [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON()

2022-06-30 Thread Christophe Leroy
Le 30/06/2022 à 10:05, Naveen N. Rao a écrit : > Christophe Leroy wrote: >> Hi Sathvika, >> >> Adding ARM people as they seem to face the same kind of problem (see >> https://patchwork.kernel.org/project/linux-kbuild/patch/20220623014917.199563-33-chenzhong...@huawei.com/) >> >> >> >> Le

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-30 Thread Christophe Leroy
Le 30/06/2022 à 10:04, David Laight a écrit : > From: Michael Schmitz >> Sent: 29 June 2022 00:09 >> >> Hi Arnd, >> >> On 29/06/22 09:50, Arnd Bergmann wrote: >>> On Tue, Jun 28, 2022 at 11:03 PM Michael Schmitz >>> wrote: On 28/06/22 19:03, Geert Uytterhoeven wrote: >> The driver

Re: [PATCH] crypto: nx - drop unexpected word "the"

2022-06-30 Thread Herbert Xu
Jiang Jian wrote: > there is an unexpected word "the" in the comments that need to be dropped > >>- * The DDE is setup with the the DDE count, byte count, and address of >>+ * The DDE is setup with the DDE count, byte count, and address of > > Signed-off-by: Jiang Jian > --- >

Re: [PATCH] crypto: vmx - drop unexpected word 'for' in comments

2022-06-30 Thread Herbert Xu
Jiang Jian wrote: > there is an unexpected word 'for' in the comments that need to be dropped > > file - drivers/crypto/vmx/ghashp8-ppc.pl > line - 19 > > "# GHASH for for PowerISA v2.07." > > changed to: > > "# GHASH for PowerISA v2.07." > > Signed-off-by: Jiang Jian > --- >

Re: [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON()

2022-06-30 Thread Naveen N. Rao
Christophe Leroy wrote: Hi Sathvika, Adding ARM people as they seem to face the same kind of problem (see https://patchwork.kernel.org/project/linux-kbuild/patch/20220623014917.199563-33-chenzhong...@huawei.com/) Le 27/06/2022 à 17:35, Sathvika Vasireddy a écrit : On 25/06/22 12:16,

RE: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-30 Thread David Laight
From: Michael Schmitz > Sent: 29 June 2022 00:09 > > Hi Arnd, > > On 29/06/22 09:50, Arnd Bergmann wrote: > > On Tue, Jun 28, 2022 at 11:03 PM Michael Schmitz > > wrote: > >> On 28/06/22 19:03, Geert Uytterhoeven wrote: > The driver allocates bounce buffers using kmalloc if it hits an >

[PATCH v2] powerpc/crash: save cpu register data in crash_smp_send_stop()

2022-06-30 Thread Hari Bathini
During kdump, two set of NMI IPIs are sent to secondary CPUs, if 'crash_kexec_post_notifiers' option is set. The first set of NMI IPIs to stop the CPUs and the other set to collect register data. Instead, capture register data for secondary CPUs while stopping them itself. Also, fallback to

Re: [PATCH] powerpc/crash: save cpu register data in crash_smp_send_stop()

2022-06-30 Thread Hari Bathini
Please ignore this thread. Will resend with v2 tag.. On 30/06/22 11:00 am, Hari Bathini wrote: During kdump, two set of NMI IPIs are sent to secondary CPUs, if 'crash_kexec_post_notifiers' option is set. The first set of NMI IPIs to stop the CPUs and the other set to collect register data.