On 32-bit kernels, 64-bit syscall arguments are split into two
registers. For that to work with syscall wrappers, the prototype of the
syscall must have the argument split so that the wrapper macro properly
unpacks the arguments from pt_regs.
The fanotify_mark() syscall is one such syscall, which
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski :
On Fri, 28 Oct 2022 13:35:11 -0700 you wrote:
> Changed maintainers for vnic driver, since Dany has new responsibilities.
> Also added Nick Child as reviewer.
>
> Signed-off-by: Rick Lindsley
>
> ---
> MAINTAINERS |
The current code provokes some kernel-doc warnings:
arch/powerpc/kernel/process.c:1606: warning: This comment starts with
'/**', but isn't a kernel-doc comment. Refer
Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Bo Liu
---
arch/powerpc/kernel/process.c | 2 +-
1 file changed,
> On 23 Sep 2022, at 6:02 pm, Nicholas Piggin wrote:
>
> On Wed Sep 21, 2022 at 4:56 PM AEST, Rohan McLure wrote:
>> Clear user state in gprs (assign to zero) to reduce the influence of user
>> registers on speculation within kernel syscall handlers. Clears occur
>> at the very beginning of the
On 10/31/22 10:12, Camelia Alexandra Groza wrote:
>> -Original Message-
>> From: Sean Anderson
>> Sent: Friday, October 28, 2022 19:55
>> To: Camelia Alexandra Groza ; Sean Anderson
>> ; David S . Miller ;
>> Jakub Kicinski ; Madalin Bucur
>> ; net...@vger.kernel.org
>> Cc: Eric Dumazet ;
Cannot call memory_failure() directly from the fault handler because
mmap_lock (and others) are held.
It is important, but not urgent, to mark the source page as h/w poisoned
and unmap it from other tasks.
Use memory_failure_queue() to request a call to memory_failure() for the
page with the
If the kernel is copying a page as the result of a copy-on-write
fault and runs into an uncorrectable error, Linux will crash because
it does not have recovery code for this case where poison is consumed
by the kernel.
It is easy to set up a test case. Just inject an error into a private
page,
Recover from poison consumption while copying pages
in the kernel for a copy-on-write fault.
Changes since v3:
1) Miaohe Lin pointed out that a recent change
by Alexander Potapenko to copy_user_highpage()
added a call to kmsan_unpoison_memory(). Same is needed in my cloned
On Mon, Oct 31, 2022, at 15:47, Andreas Schwab wrote:
> With the introducion of syscall wrappers all wrappers for syscalls with
> 64-bit arguments must be handled specially, not only those that have
> unaligned 64-bit arguments. This left out the fallocate and
> sync_file_range2 syscalls.
>
>
Barry Song <21cn...@gmail.com> writes:
> On Sat, Oct 29, 2022 at 2:11 AM Punit Agrawal
> wrote:
>>
>> Yicong Yang writes:
>>
>> > On 2022/10/27 22:19, Punit Agrawal wrote:
>> >>
>> >> [ Apologies for chiming in late in the conversation ]
>> >>
>> >> Anshuman Khandual writes:
>> >>
>> >>> On
On Fri, 28 Oct 2022 16:27:48 +0800, Chancel Liu wrote:
> Add compatible string "fsl,imx93-micfil" for i.MX93 platform
>
> Signed-off-by: Chancel Liu
> ---
> Documentation/devicetree/bindings/sound/fsl,micfil.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring
> -Original Message-
> From: Bjorn Helgaas
> Subject: [PATCH v3 5/5] PCI: Remove unnecessary includes
>
> From: Bjorn Helgaas
>
> Many host controller drivers #include even though they
> don't need it. Remove the unnecessary #includes.
>
> Signed-off-by: Bjorn Helgaas
> ---
>
From: Bjorn Helgaas
Many host controller drivers #include even though they
don't need it. Remove the unnecessary #includes.
Signed-off-by: Bjorn Helgaas
---
drivers/pci/controller/cadence/pci-j721e.c | 1 -
drivers/pci/controller/dwc/pci-layerscape.c | 1 -
From: Bjorn Helgaas
pci-xgene-msi.c uses irq_domain_add_linear() and related interfaces, so it
needs but doesn't include it directly; it relies on the
fact that includes it.
But pci-xgene-msi.c *doesn't* need itself. Include
directly to remove this implicit dependency so a future
patch can
From: Bjorn Helgaas
pci-mvebu.c uses irq_domain_add_linear() and related interfaces but relies
on but doesn't include it directly; it relies on the
fact that includes it.
Include directly to remove this implicit dependency.
Signed-off-by: Bjorn Helgaas
Acked-by: Thomas Petazzoni
---
From: Bjorn Helgaas
pcie-microchip-host.c uses irq_domain_add_linear() and related interfaces,
so it needs but doesn't include it directly; it relies
on the fact that includes it.
But pcie-microchip-host.c *doesn't* need itself. Include
directly to remove this implicit dependency so a
From: Bjorn Helgaas
pcie-altera-msi.c uses irq_domain_add_linear() and related interfaces, so
it needs but doesn't include it directly; it relies on
the fact that includes it.
But pcie-altera-msi.c *doesn't* need itself. Include
directly to remove this implicit dependency so a future
patch
From: Bjorn Helgaas
Many host controller drivers #include even though they
don't need it. Remove the unnecessary #includes.
v2: https://lore.kernel.org/r/20221025185147.665365-1-helg...@kernel.org/
v1: https://lore.kernel.org/r/20221019195452.37606-1-helg...@kernel.org/
Changes from v2 to
On 10/29/22 05:11, Bagas Sanjaya wrote:
> On Thu, Oct 27, 2022 at 03:11:08PM -0400, Sean Anderson wrote:
>> .. only:: subproject and html
>> diff --git a/Documentation/driver-api/phy/lynx_10g.rst
>> b/Documentation/driver-api/phy/lynx_10g.rst
>> new file mode 100644
>> index
With the introducion of syscall wrappers all wrappers for syscalls with
64-bit arguments must be handled specially, not only those that have
unaligned 64-bit arguments. This left out the fallocate and
sync_file_range2 syscalls.
Fixes: 7e92e01b7245 ("powerpc: Provide syscall wrapper")
Fixes:
> -Original Message-
> From: Sean Anderson
> Sent: Friday, October 28, 2022 19:55
> To: Camelia Alexandra Groza ; Sean Anderson
> ; David S . Miller ;
> Jakub Kicinski ; Madalin Bucur
> ; net...@vger.kernel.org
> Cc: Eric Dumazet ; linuxppc-dev @ lists . ozlabs .
> org ;
The macros are defined backwards.
Fixes: 43d5de2b67d7 ("asm-generic: compat: Support BE for long long args in
32-bit ABIs")
Signed-off-by: Andreas Schwab
---
include/asm-generic/compat.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/asm-generic/compat.h
Override the generic module ELF check to provide a check for the ELF ABI
version. This becomes important if we allow big-endian ELF ABI V2 builds
but it doesn't hurt to check now.
Cc: Jessica Yu
Signed-off-by: Michael Ellerman
[np: split patch, added changelog, adjust to Jessica's proposal]
The elf_check_arch() function is also used to test compatibility of
usermode binaries. Kernel modules may have more specific requirements,
for example powerpc would like to test for ABI version compatibility.
Add a weak module_elf_check_arch() that defaults to true, and call it
from
These slipped through the cracks. Picking them up again...
The story so far is that Jessica gave us the new scheme in patch 1,
now slightly rebased. Patch 2 implements the additional check
that powerpc wants which originally came from Michael, and has been
updated to the new approach.
This was
On Mon, Oct 31, 2022 at 09:58:57AM +0100, Borislav Petkov wrote:
> On Mon, Oct 31, 2022 at 09:06:04AM +0100, Andrew Jones wrote:
> > The valid cpumask range is [0, nr_cpu_ids) and cpumask_next() always
> > returns a CPU ID greater than its input, which results in its input
> > range being [-1,
On Mon, Oct 31, 2022 at 09:06:04AM +0100, Andrew Jones wrote:
> The valid cpumask range is [0, nr_cpu_ids) and cpumask_next() always
> returns a CPU ID greater than its input, which results in its input
> range being [-1, nr_cpu_ids - 1). Ensure showing CPU info avoids
> triggering error
On Fri, Oct 28, 2022 at 06:06:41PM +0200, Borislav Petkov wrote:
> On Fri, Oct 28, 2022 at 10:13:28AM -0500, Yury Norov wrote:
> > Because it's related to bitmap API usage and has been revealed after
> > some work in bitmaps.
>
> So first of all, that "fix" needs to explain what exactly it is
Fixes the following W=1 kernel build warning(s):
arch/powerpc/platforms/pseries/eeh_pseries.c:163: warning: Function parameter
or member 'config_addr' not described in 'pseries_eeh_phb_reset'
arch/powerpc/platforms/pseries/eeh_pseries.c:163: warning: Excess function
parameter 'config_adddr'
There are 4 unused bytes in the minimum frame in the ELFv2 ABI. At the
risk of causing a future ABI incompatibility, use this and save 16 bytes
from interrupt and switch frames.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/include/asm/ptrace.h | 15 ++-
1 file changed, 10
The marker is a 32-bit constant across all platforms now, so use 32-bit
memory accesses.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/include/asm/ptrace.h| 1 -
arch/powerpc/kernel/exceptions-64e.S | 2 +-
arch/powerpc/kernel/exceptions-64s.S | 2 +-
arch/powerpc/kernel/interrupt_64.S
This is equal to STACK_FRAME_MIN_SIZE on 32-bit and 64-bit ELFv1, and no
longer used in 64-bit ELFv2, so replace it with that constant.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/include/asm/ptrace.h | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff
This requires an extra 16 bytes beyond the minimum frame size for the
aligned regs marker for the int frame. The switch frame needs to match
that because they share some offset definitions.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/include/asm/ptrace.h | 21 +++--
1 file
This affects only 64-bit ELFv2 kernels, and reduces the minimum
asm-created stack frame size from 112 to 32 byte on those kernels.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/kernel/head_40x.S | 2 +-
arch/powerpc/kernel/head_44x.S | 6 +++---
arch/powerpc/kernel/head_64.S
Most callers just want to validate an arbitrary kernel stack pointer,
some need a particular size. Make the size case the exceptional one
with an extra function.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/include/asm/processor.h | 15 ---
arch/powerpc/kernel/process.c|
Stack unwinders need LR and the back chain as a minimum. The switch
stack uses regs->nip for its return pointer rather than lrsave, so
that was not filled in, and neither was the back chain.
With this and the previous change, a stack trace in the switch or
interrupt stack goes from looking like
Backtraces will not recognise the fork system call interrupt without
the regs marker. And at least perf starts unwinding the user stack
from gpr[1] directly, but regular interrupt entry from userspace creates
the back chain to the user stack, so do this too, to be consistent.
Signed-off-by:
This is open-coded in process.c, ppc32 uses a different define with the
same value, and the C definition is name differently which makes it an
extra indirection to grep for.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/include/asm/ptrace.h | 6 --
arch/powerpc/kernel/asm-offsets.c | 2
The user interrupt frame is a different size from the kernel frame, so
give it its own name.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/include/asm/ptrace.h | 6 +++---
arch/powerpc/kernel/process.c | 6 +++---
arch/powerpc/kernel/stacktrace.c | 4 ++--
3 files changed, 8
This is a count of longs from the stack pointer to the regs marker.
Rename it to make it more distinct from the other byte offsets. It
can be derived from the byte offset definitions just added.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/include/asm/ptrace.h | 4 ++--
Define a constant rather than open-code the offset for the
"regs" marker.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/include/asm/ptrace.h | 2 ++
arch/powerpc/kernel/entry_32.S | 2 +-
arch/powerpc/kernel/exceptions-64e.S| 2 +-
arch/powerpc/kernel/exceptions-64s.S
This is a common offset that currently uses the overloaded
STACK_FRAME_OVERHEAD constant. It's easier to read and more
flexible to use a specific regs offset for this.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/include/asm/ptrace.h | 2 +
arch/powerpc/kernel/asm-offsets.c
Adjust the pt_regs pointer so the interrupt frame offsets can be used
directly to save registers.
Signed-off-by: Nicholas Piggin
---
arch/powerpc/kernel/ppc_save_regs.S | 58 +++--
1 file changed, 14 insertions(+), 44 deletions(-)
diff --git
43 matches
Mail list logo