Re: [6.1.0-rc4-next-20221109] Boot time warning kernel/module/main.c:852

2022-11-10 Thread Sachin Sant
>> [ 8.809079] [c7c37e10] [c000cffc] >> ret_from_kernel_thread+0x5c/0x64 >> [ 8.809086] Instruction dump: >> [ 8.809090] f821ffc1 41820034 395e03c0 7c0004ac 7d205028 2c090001 3929 >> 41c00010 >> [ 8.809101] 7d20512d >> [ 8.809101] sd 1:0:0:1: [sdc] Preferred minimum I/O size 3

Re: [PATCH v4 1/1] x86: cpuinfo: Ensure inputs to cpumask_next are valid

2022-11-10 Thread Yury Norov
On Thu, Nov 03, 2022 at 03:25:04PM +0100, Andrew Jones wrote: > The valid cpumask range is [0, nr_cpu_ids) and cpumask_next() > currently calls find_next_bit() with its input CPU ID number plus one > for the bit number, giving cpumask_next() the range [-1, nr_cpu_ids - 1). > seq_read_iter() and cpu

Re: [PATCH] mm: remove kern_addr_valid() completely

2022-11-10 Thread Palmer Dabbelt
On Tue, 18 Oct 2022 00:40:14 PDT (-0700), wangkefeng.w...@huawei.com wrote: Most architectures(except arm64/x86/sparc) simply return 1 for kern_addr_valid(), which is only used in read_kcore(), and it calls copy_from_kernel_nofault() which could check whether the address is a valid kernel address

Writing not working to CPLD/FPGA.

2022-11-10 Thread Steven J. Hill
Hello. My platform is a 7447A with Marvell GT64260 bridge chip. I have currently got the kernel upgraded to v3.12 (started from v2.6.26) and only have one more piece to get working that has never worked. There is a CPLD on the board. It maps in just fine and I can read the registers without issue

[PATCH AUTOSEL 6.0 10/30] powerpc/64e: Fix amdgpu build on Book3E w/o AltiVec

2022-11-10 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit 2153fc9623e5465f503d793d4c94ad65e9ec9b5f ] There's a build failure for Book3E without AltiVec: Error: cc1: error: AltiVec not supported in this target make[6]: *** [/linux/scripts/Makefile.build:250: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/disp

Re: [PATCH v8 0/4] tpm: Preserve TPM measurement log across kexec (ppc64)

2022-11-10 Thread Coiby Xu
Hi Michael, Could the PowerPC tree take this patch set which resolves a PowerVM/KVM-specific issue? On Thu, Sep 01, 2022 at 05:46:06PM -0400, Stefan Berger wrote: The of-tree subsystem does not currently preserve the IBM vTPM 1.2 and vTPM 2.0 measurement logs across a kexec on PowerVM and Power

Re: [PATCH 10/44] KVM: VMX: Clean up eVMCS enabling if KVM initialization fails

2022-11-10 Thread Sean Christopherson
On Thu, Nov 03, 2022, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > + /* > > +* Reset everything to support using non-enlightened VMCS access later > > +* (e.g. when we reload the module with enlightened_vmcs=0) > > +*/ > > + for_each_online_cpu(cpu) { > > + v

[PATCH linux-next] scsi: ibmvfc: use sysfs_emit() to instead of scnprintf()

2022-11-10 Thread yang.yang29
From: Xu Panda Replace the open-code with sysfs_emit() to simplify the code. Reported-by: Zeal Robot Signed-off-by: Xu Panda Signed-off-by: Yang Yang --- drivers/scsi/ibmvscsi/ibmvfc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/ibmvscsi/

Re: [PATCH 36/44] KVM: x86: Do compatibility checks when onlining CPU

2022-11-10 Thread Sean Christopherson
On Fri, Nov 04, 2022, Isaku Yamahata wrote: > On Thu, Nov 03, 2022 at 10:34:10PM +, > Sean Christopherson wrote: > > > On Thu, Nov 03, 2022, Isaku Yamahata wrote: > > > On Wed, Nov 02, 2022 at 11:19:03PM +, > > > Sean Christopherson wrote: > > > > diff --git a/arch/x86/include/asm/kvm_ho

Re: [PATCH v3 0/5] PCI: Remove unnecessary includes

2022-11-10 Thread Bjorn Helgaas
On Mon, Oct 31, 2022 at 10:39:49AM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Many host controller drivers #include even though they > don't need it. Remove the unnecessary #includes. > > v2: https://lore.kernel.org/r/20221025185147.665365-1-helg...@kernel.org/ > v1: https://lore.ke

[RFC PATCH 3/3] powerpc/bpf: use bpf_jit_binary_pack_[alloc|finalize|free]

2022-11-10 Thread Hari Bathini
Use bpf_jit_binary_pack_alloc in powerpc jit. The jit engine first writes the program to the rw buffer. When the jit is done, the program is copied to the final location with bpf_jit_binary_pack_finalize. With multiple jit_subprogs, bpf_jit_free is called on some subprograms that haven't got bpf_ji

[RFC PATCH 1/3] powerpc/bpf: implement bpf_arch_text_copy

2022-11-10 Thread Hari Bathini
bpf_arch_text_copy is used to dump JITed binary to RX page, allowing multiple BPF programs to share the same page. Using patch_instruction to implement it. Signed-off-by: Hari Bathini --- arch/powerpc/net/bpf_jit_comp.c | 39 - 1 file changed, 38 insertions(+), 1

[RFC PATCH 2/3] powerpc/bpf: implement bpf_arch_text_invalidate for bpf_prog_pack

2022-11-10 Thread Hari Bathini
Implement bpf_arch_text_invalidate and use it to fill unused part of the bpf_prog_pack with trap instructions when a BPF program is freed. Signed-off-by: Hari Bathini --- arch/powerpc/net/bpf_jit_comp.c | 32 1 file changed, 32 insertions(+) diff --git a/arch/po

[RFC PATCH 0/3] enable bpf_prog_pack allocator for powerpc

2022-11-10 Thread Hari Bathini
Most BPF programs are small, but they consume a page each. For systems with busy traffic and many BPF programs, this may also add significant pressure on instruction TLB. High iTLB pressure usually slows down the whole system causing visible performance degradation for production workloads. bpf_pr

[PATCH v2 0/2] Consider the size of the added CPU nodes in the kexec FDT

2022-11-10 Thread Laurent Dufour
When adding CPUs to an already big system (test show it seems to start with more than 256 CPUs), the kernel is showing error messages when building the FDT for the kexec kernel (kdump or kexec). It's worth to mention that the kdump kernel is reloaded after a CPU add operation. The messages look l

[PATCH v2 2/2] powerpc: Take in account addition CPU node when building kexec FDT

2022-11-10 Thread Laurent Dufour
On a system with a large number of CPUs, the creation of the FDT for a kexec kernel may fail because the allocated FDT is not large enough. When this happens, such a message is displayed on the console: Unable to add ibm,processor-vadd-size property: FDT_ERR_NOSPACE The property's name may chang

[PATCH v2 1/2] powerpc: export the CPU node count

2022-11-10 Thread Laurent Dufour
At boot time, the FDT is parsed to compute the number of CPUs. In addition count the number of CPU nodes and export it. This is useful when building the FDT for a kexeced kernel since we need to take in account the CPU node added since the boot time during CPU hotplug operations. Signed-off-by: L

Re: [6.1.0-rc4-next-20221109] Boot time warning kernel/module/main.c:852

2022-11-10 Thread Bart Van Assche
On 11/10/22 00:01, Sachin Sant wrote: While booting 6.1.0-rc4-next-20221109 next kernel on a IBM Power9 LPAR following warning is seen: [ 8.808868] [ cut here ] [ 8.808872] WARNING: CPU: 1 PID: 378 at kernel/module/main.c:852 module_put+0x48/0x100 [ 8.809024] sd 1:0:0:1:

Re: [PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling

2022-11-10 Thread Sean Christopherson
On Thu, Nov 10, 2022, Huang, Kai wrote: > On Thu, 2022-11-10 at 01:33 +, Huang, Kai wrote: > > > @@ -9283,7 +9283,13 @@ static int > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops) > > >   int cpu = smp_processor_id(); > > >   struct cpuinfo_x86 *c = &cpu_data(cpu); > >

Re: [PATCH net-next v2 00/11] net: pcs: Add support for devices probed in the "usual" manner

2022-11-10 Thread Sean Anderson
On 11/10/22 11:00, Vladimir Oltean wrote: > On Thu, Nov 10, 2022 at 10:39:30AM -0500, Sean Anderson wrote: >> On 11/10/22 10:29, Vladimir Oltean wrote: >> > On Thu, Nov 10, 2022 at 09:55:32AM -0500, Sean Anderson wrote: >> >> On 11/9/22 17:41, Vladimir Oltean wrote: >> >> > On Thu, Nov 03, 2022 at

Re: [PATCH 32/44] KVM: x86: Unify pr_fmt to use module name for all KVM modules

2022-11-10 Thread Sean Christopherson
On Thu, Nov 10, 2022, Robert Hoo wrote: > After this patch set, still find some printk()s left in arch/x86/kvm/*, > consider clean all of them up? Hmm, yeah, I suppose at this point it makes sense to tack on a patch to clean them up.

Re: [PATCH 37/44] KVM: Rename and move CPUHP_AP_KVM_STARTING to ONLINE section

2022-11-10 Thread Sean Christopherson
On Thu, Nov 10, 2022, Robert Hoo wrote: > > -static int kvm_starting_cpu(unsigned int cpu) > > +static int kvm_online_cpu(unsigned int cpu) > > { > > + int ret = 0; > > + > > raw_spin_lock(&kvm_count_lock); > > - if (kvm_usage_count) > > + /* > > +* Abort the CPU online process if ha

Re: [PATCH net-next v2 00/11] net: pcs: Add support for devices probed in the "usual" manner

2022-11-10 Thread Andrew Lunn
On Thu, Nov 10, 2022 at 03:29:26PM +, Vladimir Oltean wrote: > On Thu, Nov 10, 2022 at 09:55:32AM -0500, Sean Anderson wrote: > > On 11/9/22 17:41, Vladimir Oltean wrote: > > > On Thu, Nov 03, 2022 at 05:06:39PM -0400, Sean Anderson wrote: > > >> Several (later) patches in this series cannot be

Re: [PATCH net-next v2 00/11] net: pcs: Add support for devices probed in the "usual" manner

2022-11-10 Thread Vladimir Oltean
On Thu, Nov 10, 2022 at 05:01:34PM +0100, Andrew Lunn wrote: > On Thu, Nov 10, 2022 at 03:29:26PM +, Vladimir Oltean wrote: > > On Thu, Nov 10, 2022 at 09:55:32AM -0500, Sean Anderson wrote: > > > On 11/9/22 17:41, Vladimir Oltean wrote: > > > > On Thu, Nov 03, 2022 at 05:06:39PM -0400, Sean An

Re: [PATCH net-next v2 00/11] net: pcs: Add support for devices probed in the "usual" manner

2022-11-10 Thread Vladimir Oltean
On Thu, Nov 10, 2022 at 10:39:30AM -0500, Sean Anderson wrote: > On 11/10/22 10:29, Vladimir Oltean wrote: > > On Thu, Nov 10, 2022 at 09:55:32AM -0500, Sean Anderson wrote: > >> On 11/9/22 17:41, Vladimir Oltean wrote: > >> > On Thu, Nov 03, 2022 at 05:06:39PM -0400, Sean Anderson wrote: > >> >> S

Re: [PATCH net-next v2 00/11] net: pcs: Add support for devices probed in the "usual" manner

2022-11-10 Thread Sean Anderson
On 11/10/22 10:29, Vladimir Oltean wrote: > On Thu, Nov 10, 2022 at 09:55:32AM -0500, Sean Anderson wrote: >> On 11/9/22 17:41, Vladimir Oltean wrote: >> > On Thu, Nov 03, 2022 at 05:06:39PM -0400, Sean Anderson wrote: >> >> Several (later) patches in this series cannot be applied until a stable >>

Re: [PATCH net-next v2 00/11] net: pcs: Add support for devices probed in the "usual" manner

2022-11-10 Thread Vladimir Oltean
On Thu, Nov 10, 2022 at 09:55:32AM -0500, Sean Anderson wrote: > On 11/9/22 17:41, Vladimir Oltean wrote: > > On Thu, Nov 03, 2022 at 05:06:39PM -0400, Sean Anderson wrote: > >> Several (later) patches in this series cannot be applied until a stable > >> release has occured containing the dts updat

Re: [PATCH net-next v2 00/11] net: pcs: Add support for devices probed in the "usual" manner

2022-11-10 Thread Sean Anderson
On 11/9/22 17:59, Vladimir Oltean wrote: > On Thu, Nov 03, 2022 at 05:06:39PM -0400, Sean Anderson wrote: >> For a long time, PCSs have been tightly coupled with their MACs. For >> this reason, the MAC creates the "phy" or mdio device, and then passes >> it to the PCS to initialize. This has a few

Re: [PATCH net-next v2 00/11] net: pcs: Add support for devices probed in the "usual" manner

2022-11-10 Thread Sean Anderson
On 11/9/22 17:41, Vladimir Oltean wrote: > On Thu, Nov 03, 2022 at 05:06:39PM -0400, Sean Anderson wrote: >> Several (later) patches in this series cannot be applied until a stable >> release has occured containing the dts updates. > > New kernels must remain compatible with old device trees. Wel

Re: [PATCH printk v3 26/40] tty: hvc: use console_is_registered()

2022-11-10 Thread Petr Mladek
On Mon 2022-11-07 15:22:24, John Ogness wrote: > It is not reliable to check for CON_ENABLED in order to identify if a > console is registered. Use console_is_registered() instead. > > Signed-off-by: John Ogness Reviewed-by: Petr Mladek Best Regards, Petr

Re: [PATCH] virt: fsl_hypervisor: Replace NO_IRQ by 0

2022-11-10 Thread Greg Kroah-Hartman
On Thu, Nov 10, 2022 at 01:25:14PM +, Christophe Leroy wrote: > Hi Greg, > > Le 06/10/2022 à 07:27, Christophe Leroy a écrit : > > NO_IRQ is used to check the return of irq_of_parse_and_map(). > > > > On some architecture NO_IRQ is 0, on other architectures it is -1. > > > > irq_of_parse_and

Re: [PATCH] virt: fsl_hypervisor: Replace NO_IRQ by 0

2022-11-10 Thread Christophe Leroy
Hi Greg, Le 06/10/2022 à 07:27, Christophe Leroy a écrit : > NO_IRQ is used to check the return of irq_of_parse_and_map(). > > On some architecture NO_IRQ is 0, on other architectures it is -1. > > irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ. > > So use 0 instead of using N

Re: [PATCH linux-next] scsi: ibmvfc: use sysfs_emit() to instead of scnprintf()

2022-11-10 Thread Christophe Leroy
Le 10/11/2022 à 13:34, yang.yan...@zte.com.cn a écrit : > [Vous ne recevez pas souvent de courriers de yang.yan...@zte.com.cn. > Découvrez pourquoi ceci est important à > https://aka.ms/LearnAboutSenderIdentification ] > > From: Xu Panda > > Replace the open-code with sysfs_emit() to simplify

Re: [PATCH 04/17] powerpc/qspinlock: convert atomic operations to assembly

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 6:36 PM AEST, Christophe Leroy wrote: > > > Le 10/11/2022 à 01:39, Jordan Niethe a écrit : > >> +static __always_inline int trylock_clear_tail_cpu(struct qspinlock *lock, > >> u32 old) > >> { > >> - int newval = _Q_LOCKED_VAL; > >> - > >> - if (atomic_cmpxchg_acquire(&lo

Re: [PATCH 01/17] powerpc/qspinlock: powerpc qspinlock implementation

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 4:37 PM AEST, Christophe Leroy wrote: > > > Le 10/11/2022 à 01:35, Jordan Niethe a écrit : > > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > > > >> -#define queued_spin_lock queued_spin_lock > >> > >> -static inline void queued_spin_unlock(struct qspinlock *

Re: [PATCH 17/17] powerpc/qspinlock: provide accounting and options for sleepy locks

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:44 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > Finding the owner or a queued waiter on a lock with a preempted vcpu > > is indicative of an oversubscribed guest causing the lock to get into >

Re: [PATCH 16/17] powerpc/qspinlock: allow indefinite spinning on a preempted owner

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:44 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > Provide an option that holds off queueing indefinitely while the lock > > owner is preempted. This could reduce queueing latencies for very > > o

Re: [PATCH 15/17] powerpc/qspinlock: reduce remote node steal spins

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:43 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > Allow for a reduction in the number of times a CPU from a different > > node than the owner can attempt to steal the lock before queueing. > > Th

Re: [PATCH 14/17] powerpc/qspinlock: use spin_begin/end API

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:43 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > Use the spin_begin/spin_cpu_relax/spin_end APIs in qspinlock, which helps > > to prevent threads issuing a lot of expensive priority nops which m

Re: [PATCH 13/17] powerpc/qspinlock: trylock and initial lock attempt may steal

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:43 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > This gives trylock slightly more strength, and it also gives most > > of the benefit of passing 'val' back through the slowpath without > > the c

Re: [PATCH 12/17] powerpc/qspinlock: add ability to prod new queue head CPU

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:42 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > After the head of the queue acquires the lock, it releases the > > next waiter in the queue to become the new head. Add an option > > to prod the

Re: [PATCH 11/17] powerpc/qspinlock: allow propagation of yield CPU down the queue

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:42 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > Having all CPUs poll the lock word for the owner CPU that should be > > yielded to defeats most of the purpose of using MCS queueing for > > scal

Re: [PATCH 10/17] powerpc/qspinlock: allow stealing when head of queue yields

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:42 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > If the head of queue is preventing stealing but it finds the owner vCPU > > is preempted, it will yield its cycles to the owner which could cause

Re: [PATCH 09/17] powerpc/qspinlock: implement option to yield to previous node

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:41 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > Queued waiters which are not at the head of the queue don't spin on > > the lock word but their qnode lock word, waiting for the previous queued

Re: [PATCH 08/17] powerpc/qspinlock: paravirt yield to lock owner

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:41 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > Waiters spinning on the lock word should yield to the lock owner if the > > vCPU is preempted. This improves performance when the hypervisor ha

Re: [PATCH 07/17] powerpc/qspinlock: store owner CPU in lock word

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:40 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > Store the owner CPU number in the lock word so it may be yielded to, > > as powerpc's paravirtualised simple spinlocks do. > > --- > > arch/powe

Re: [PATCH 06/17] powerpc/qspinlock: theft prevention to control latency

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:40 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > Give the queue head the ability to stop stealers. After a number of > > spins without sucessfully acquiring the lock, the queue head employs > >

Re: [PATCH 05/17] powerpc/qspinlock: allow new waiters to steal the lock before queueing

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:40 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > Allow new waiters a number of spins on the lock word before queueing, > > which particularly helps paravirt performance when physical CPUs are >

Re: [PATCH 2/4] fs: define a firmware security filesystem named fwsecurityfs

2022-11-10 Thread Greg Kroah-Hartman
On Wed, Nov 09, 2022 at 03:10:37PM -0500, Nayna wrote: > > On 11/9/22 08:46, Greg Kroah-Hartman wrote: > > On Sun, Nov 06, 2022 at 04:07:42PM -0500, Nayna Jain wrote: > > > securityfs is meant for Linux security subsystems to expose policies/logs > > > or any other information. However, there are

Re: [PATCH 04/17] powerpc/qspinlock: convert atomic operations to assembly

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:39 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > This uses more optimal ll/sc style access patterns (rather than > > cmpxchg), and also sets the EH=1 lock hint on those operations > > which acqu

Re: [PATCH 03/17] powerpc/qspinlock: use a half-word store to unlock to avoid larx/stcx.

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:39 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] > > The first 16 bits of the lock are only modified by the owner, and other > > modifications always use atomic operations on the entire 32 bits, so

Re: [PATCH 02/17] powerpc/qspinlock: add mcs queueing for contended waiters

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:36 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > > [resend as utf-8, not utf-7] > > > > +/* > > + * Bitfields in the atomic value: > > + * > > + * 0: locked bit > > + * 16-31: tail cpu (+1) > > + */ > > +#define_Q_SE

Re: [PATCH 01/17] powerpc/qspinlock: powerpc qspinlock implementation

2022-11-10 Thread Nicholas Piggin
On Thu Nov 10, 2022 at 10:35 AM AEST, Jordan Niethe wrote: > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > > > -#define queued_spin_lock queued_spin_lock > > > > -static inline void queued_spin_unlock(struct qspinlock *lock) > > +static __always_inline int queued_spin_trylock(struc

Re: [PATCH 04/17] powerpc/qspinlock: convert atomic operations to assembly

2022-11-10 Thread Christophe Leroy
Le 10/11/2022 à 01:39, Jordan Niethe a écrit : > On Thu, 2022-07-28 at 16:31 +1000, Nicholas Piggin wrote: > [resend as utf-8, not utf-7] >> This uses more optimal ll/sc style access patterns (rather than >> cmpxchg), and also sets the EH=1 lock hint on those operations >> which acquire ownership

[6.1.0-rc4-next-20221109] Boot time warning kernel/module/main.c:852

2022-11-10 Thread Sachin Sant
While booting 6.1.0-rc4-next-20221109 next kernel on a IBM Power9 LPAR following warning is seen: [ 8.808868] [ cut here ] [ 8.808872] WARNING: CPU: 1 PID: 378 at kernel/module/main.c:852 module_put+0x48/0x100 [ 8.808881] Modules linked in: sr_mod(E) cdrom(E) sd_mod(E) sg(