Re: [PATCH 289/606] macintosh: ams/ams-i2c: Convert to i2c's .probe_new()

2022-11-18 Thread Christophe Leroy
Le 18/11/2022 à 23:40, Uwe Kleine-König a écrit : > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König The patch itself and the others seems ok. But can you group all

Re: [PATCH 000/606] i2c: Complete conversion to i2c_probe_new

2022-11-18 Thread patchwork-bot+chrome-platform
Hello: This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih : On Fri, 18 Nov 2022 23:35:34 +0100 you wrote: > Hello, > > since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type") from 2016 there is a "temporary" alternative probe >

Re: [PATCH 000/606] i2c: Complete conversion to i2c_probe_new

2022-11-18 Thread patchwork-bot+chrome-platform
Hello: This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih : On Fri, 18 Nov 2022 23:35:34 +0100 you wrote: > Hello, > > since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type") from 2016 there is a "temporary" alternative probe > callback

[PATCH] powerpc: Fix potential memory leak in icp_native_map_one_cpu()

2022-11-18 Thread Xiu Jianfeng
Before return error, it has allocated memory by kasprintf() and save it in @rname, may cause a memory leak issue, fix it. Fixes: 0b05ac6e2480 ("powerpc/xics: Rewrite XICS driver") Signed-off-by: Xiu Jianfeng --- arch/powerpc/sysdev/xics/icp-native.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: build failure in linux-next: offb missing fb helpers

2022-11-18 Thread Randy Dunlap
Hi-- [adding Masahiro-san] On 11/18/22 07:03, Michal Suchánek wrote: > Hello, > > I am seeing these errors: > > [ 3825s] AR built-in.a > [ 3827s] AR vmlinux.a > [ 3835s] LD vmlinux.o > [ 3835s] OBJCOPY modules.builtin.modinfo > [ 3835s] GEN modules.builtin > [

Re: [PATCH 2/4] fs: define a firmware security filesystem named fwsecurityfs

2022-11-18 Thread Nayna
On 11/17/22 16:27, Greg Kroah-Hartman wrote: On Mon, Nov 14, 2022 at 06:03:43PM -0500, Nayna wrote: On 11/10/22 04:58, Greg Kroah-Hartman wrote: On Wed, Nov 09, 2022 at 03:10:37PM -0500, Nayna wrote: On 11/9/22 08:46, Greg Kroah-Hartman wrote: On Sun, Nov 06, 2022 at 04:07:42PM -0500,

[PATCH AUTOSEL 5.10 12/18] scsi: ibmvfc: Avoid path failures during live migration

2022-11-18 Thread Sasha Levin
From: Brian King [ Upstream commit 62fa3ce05d5d73c5eccc40b2db493f55fecfc446 ] Fix an issue reported when performing a live migration when multipath is configured with a short fast fail timeout of 5 seconds and also to have no_path_retry set to fail. In this scenario, all paths would go into the

[PATCH AUTOSEL 5.15 18/27] scsi: ibmvfc: Avoid path failures during live migration

2022-11-18 Thread Sasha Levin
From: Brian King [ Upstream commit 62fa3ce05d5d73c5eccc40b2db493f55fecfc446 ] Fix an issue reported when performing a live migration when multipath is configured with a short fast fail timeout of 5 seconds and also to have no_path_retry set to fail. In this scenario, all paths would go into the

[PATCH AUTOSEL 6.0 23/44] scsi: ibmvfc: Avoid path failures during live migration

2022-11-18 Thread Sasha Levin
From: Brian King [ Upstream commit 62fa3ce05d5d73c5eccc40b2db493f55fecfc446 ] Fix an issue reported when performing a live migration when multipath is configured with a short fast fail timeout of 5 seconds and also to have no_path_retry set to fail. In this scenario, all paths would go into the

Re: [PATCH mm-unstable v1 20/20] mm: rename FOLL_FORCE to FOLL_PTRACE

2022-11-18 Thread Kees Cook
On Fri, Nov 18, 2022 at 12:09:02PM +0100, Peter Zijlstra wrote: > On Wed, Nov 16, 2022 at 10:16:34AM -0800, Linus Torvalds wrote: > > Following the history of it is a big of a mess, because there's a > > number of renamings and re-organizations, but it seems to go back to > > 2007 and commit

Re: [patch 23/39] PCI/MSI: Move pci_alloc_irq_vectors_affinity() to api.c

2022-11-18 Thread Ahmed S. Darwish
On Wed, Nov 16, 2022 at 10:23:22AM -0600, Bjorn Helgaas wrote: > On Fri, Nov 11, 2022 at 02:54:51PM +0100, Thomas Gleixner wrote: ... > > + > > +/** > > + * pci_alloc_irq_vectors_affinity() - Allocate multiple device interrupt > > + *vectors with affinity

Re: [PATCH mm-unstable v1 20/20] mm: rename FOLL_FORCE to FOLL_PTRACE

2022-11-18 Thread Peter Zijlstra
On Wed, Nov 16, 2022 at 10:16:34AM -0800, Linus Torvalds wrote: > Following the history of it is a big of a mess, because there's a > number of renamings and re-organizations, but it seems to go back to > 2007 and commit b6a2fea39318 ("mm: variable length argument support"). I went back and read

[PATCH 289/606] macintosh: ams/ams-i2c: Convert to i2c's .probe_new()

2022-11-18 Thread Uwe Kleine-König
From: Uwe Kleine-König The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König --- drivers/macintosh/ams/ams-i2c.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH 293/606] macintosh: windfarm_fcu_controls: Convert to i2c's .probe_new()

2022-11-18 Thread Uwe Kleine-König
From: Uwe Kleine-König The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König --- drivers/macintosh/windfarm_fcu_controls.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 292/606] macintosh: windfarm_ad7417_sensor: Convert to i2c's .probe_new()

2022-11-18 Thread Uwe Kleine-König
From: Uwe Kleine-König The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König --- drivers/macintosh/windfarm_ad7417_sensor.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 294/606] macintosh: windfarm_lm75_sensor: Convert to i2c's .probe_new()

2022-11-18 Thread Uwe Kleine-König
From: Uwe Kleine-König .probe_new() doesn't get the i2c_device_id * parameter, so determine that explicitly in the probe function. Signed-off-by: Uwe Kleine-König --- drivers/macintosh/windfarm_lm75_sensor.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 296/606] macintosh: windfarm_max6690_sensor: Convert to i2c's .probe_new()

2022-11-18 Thread Uwe Kleine-König
From: Uwe Kleine-König The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König --- drivers/macintosh/windfarm_max6690_sensor.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 297/606] macintosh: windfarm_smu_sat: Convert to i2c's .probe_new()

2022-11-18 Thread Uwe Kleine-König
From: Uwe Kleine-König The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König --- drivers/macintosh/windfarm_smu_sat.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 291/606] macintosh: therm_windtunnel: Convert to i2c's .probe_new()

2022-11-18 Thread Uwe Kleine-König
From: Uwe Kleine-König .probe_new() doesn't get the i2c_device_id * parameter, so determine that explicitly in the probe function. Signed-off-by: Uwe Kleine-König --- drivers/macintosh/therm_windtunnel.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 295/606] macintosh: windfarm_lm87_sensor: Convert to i2c's .probe_new()

2022-11-18 Thread Uwe Kleine-König
From: Uwe Kleine-König The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König --- drivers/macintosh/windfarm_lm87_sensor.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 290/606] macintosh: therm_adt746x: Convert to i2c's .probe_new()

2022-11-18 Thread Uwe Kleine-König
From: Uwe Kleine-König .probe_new() doesn't get the i2c_device_id * parameter, so determine that explicitly in the probe function. Signed-off-by: Uwe Kleine-König --- drivers/macintosh/therm_adt746x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 000/606] i2c: Complete conversion to i2c_probe_new

2022-11-18 Thread Uwe Kleine-König
Hello, since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type") from 2016 there is a "temporary" alternative probe callback for i2c drivers. This series completes all drivers to this new callback (unless I missed something). It's based on current next/master. A part of

[PATCH 598/606] ALSA: aoa: tas: Convert to i2c's .probe_new()

2022-11-18 Thread Uwe Kleine-König
From: Uwe Kleine-König The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König --- sound/aoa/codecs/tas.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/aoa/codecs/tas.c

[PATCH 597/606] ALSA: aoa: onyx: Convert to i2c's .probe_new()

2022-11-18 Thread Uwe Kleine-König
From: Uwe Kleine-König The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König --- sound/aoa/codecs/onyx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/aoa/codecs/onyx.c

Re: [RFC PATCH 0/3] enable bpf_prog_pack allocator for powerpc

2022-11-18 Thread Christophe Leroy
Le 18/11/2022 à 18:28, Song Liu a écrit : > On Fri, Nov 18, 2022 at 3:47 AM Christophe Leroy > wrote: >> >> >> >> Le 18/11/2022 à 10:39, Hari Bathini a écrit : >>> >>> >>> On 18/11/22 2:21 pm, Christophe Leroy wrote: > >>> I had the same config but hit this problem: >>> >>>

Re: [PATCH] powerpc/pseries: unregister VPA when hot unplugging a CPU

2022-11-18 Thread Nathan Lynch
Laurent Dufour writes: > The VPA should unregister when offlining a CPU. Otherwise there could be a > short window where 2 CPUs could share the same VPA. > > This happens because the hypervisor is still keeping the VPA attached to > the vCPU even if it became offline. > > Here is a potential

Re: [RFC PATCH 0/3] enable bpf_prog_pack allocator for powerpc

2022-11-18 Thread Song Liu
On Fri, Nov 18, 2022 at 3:47 AM Christophe Leroy wrote: > > > > Le 18/11/2022 à 10:39, Hari Bathini a écrit : > > > > > > On 18/11/22 2:21 pm, Christophe Leroy wrote: > > > I had the same config but hit this problem: > > > ># echo 1 > /proc/sys/net/core/bpf_jit_enable;

Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-11-18 Thread Song Liu
Hi Petr, On Fri, Nov 18, 2022 at 8:24 AM Petr Mladek wrote: > > On Thu 2022-09-01 10:12:52, Song Liu wrote: [...] > > > > arch/powerpc/kernel/module_32.c | 10 > > arch/powerpc/kernel/module_64.c | 49 +++ > > arch/s390/kernel/module.c | 8 +++ > >

Re: [PATCH mm-unstable v1 05/20] mm: add early FAULT_FLAG_WRITE consistency checks

2022-11-18 Thread Vlastimil Babka
On 11/16/22 11:26, David Hildenbrand wrote: > Let's catch abuse of FAULT_FLAG_WRITE early, such that we don't have to > care in all other handlers and might get "surprises" if we forget to do > so. > > Write faults without VM_MAYWRITE don't make any sense, and our > maybe_mkwrite() logic could

Re: [PATCH mm-unstable v1 04/20] mm: add early FAULT_FLAG_UNSHARE consistency checks

2022-11-18 Thread Vlastimil Babka
On 11/16/22 11:26, David Hildenbrand wrote: > For now, FAULT_FLAG_UNSHARE only applies to anonymous pages, which > implies a COW mapping. Let's hide FAULT_FLAG_UNSHARE early if we're not > dealing with a COW mapping, such that we treat it like a read fault as > documented and don't have to worry

Re: [RFC PATCH v2 8/8] sched, smp: Trace smp callback causing an IPI

2022-11-18 Thread Daniel Bristot de Oliveira
On 11/18/22 10:12, Peter Zijlstra wrote: > On Thu, Nov 17, 2022 at 02:45:29PM +, Valentin Schneider wrote: > >>> + if (trace_ipi_send_cpumask_enabled()) { >>> + call_single_data_t *csd; >>> + smp_call_func_t func; >>> + >>> + csd = container_of(node,

Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-11-18 Thread Petr Mladek
On Thu 2022-09-01 10:12:52, Song Liu wrote: > From: Miroslav Benes > > Josh reported a bug: > > When the object to be patched is a module, and that module is > rmmod'ed and reloaded, it fails to load with: > > module: x86/modules: Skipping invalid relocation target, existing value is >

Re: [PATCH mm-unstable v1 01/20] selftests/vm: anon_cow: prepare for non-anonymous COW tests

2022-11-18 Thread Vlastimil Babka
On 11/16/22 11:26, David Hildenbrand wrote: > Originally, the plan was to have a separate tests for testing COW of > non-anonymous (e.g., shared zeropage) pages. > > Turns out, that we'd need a lot of similar functionality and that there > isn't a really good reason to separate it. So let's

[PATCH 04/13] powerpc/rtas: avoid scheduling in rtas_os_term()

2022-11-18 Thread Nathan Lynch
It's unsafe to use rtas_busy_delay() to handle a busy status from the ibm,os-term RTAS function in rtas_os_term(): Kernel panic - not syncing: Attempted to kill init! exitcode=0x000b BUG: sleeping function called from invalid context at arch/powerpc/kernel/rtas.c:618 in_atomic(): 1,

[PATCH 11/13] powerpc/rtas: strengthen do_enter_rtas() type safety, drop inline

2022-11-18 Thread Nathan Lynch
Make do_enter_rtas() take a pointer to struct rtas_args and do the __pa() conversion in one place instead of leaving it to callers. This also makes it possible to introduce enter/exit tracepoints that access the rtas_args struct fields. There's no apparent reason to force inlining of

[PATCH 09/13] powerpc/rtas: mandate RTAS syscall filtering

2022-11-18 Thread Nathan Lynch
CONFIG_PPC_RTAS_FILTER has been optional but default-enabled since its introduction. It's been enabled in enterprise distro kernels for a while without causing ABI breakage that wasn't easily fixed, and it prevents harmful abuses of the rtas syscall. Let's make it unconditional. Signed-off-by:

[PATCH 13/13] powerpc/rtas: place tracepoints in do_enter_rtas()

2022-11-18 Thread Nathan Lynch
Call the just-added rtas tracepoints in do_enter_rtas(), taking care to avoid function name lookups in the CPU offline path. Signed-off-by: Nathan Lynch --- arch/powerpc/kernel/rtas.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/powerpc/kernel/rtas.c

[PATCH 05/13] powerpc/pseries/eeh: use correct API for error log size

2022-11-18 Thread Nathan Lynch
rtas-error-log-max is not the name of an RTAS function, so rtas_token() is not the appropriate API for retrieving its value. We already have rtas_get_error_log_max() which returns a sensible value if the property is absent for any reason, so use that instead. Signed-off-by: Nathan Lynch Fixes:

[PATCH 12/13] powerpc/tracing: tracepoints for RTAS entry and exit

2022-11-18 Thread Nathan Lynch
Add two sets of tracepoints to be used around RTAS entry: * rtas_input/rtas_output, which emit the function name, its inputs, the returned status, and any other outputs. These produce an API-level record of OS<->RTAS activity. * rtas_ll_entry/rtas_ll_exit, which are lower-level and emit the

[PATCH 08/13] powerpc/rtas: define pr_fmt and convert printk call sites

2022-11-18 Thread Nathan Lynch
Set pr_fmt to "rtas: " and convert the handful of printk() uses in rtas.c, adjusting the messages to remove now-redundant "RTAS" strings. Note that rtas_restart(), rtas_power_off(), and rtas_halt() all currently use printk() without specifying a log level. These have been changed to use

[PATCH 10/13] powerpc/rtas: improve function information lookups

2022-11-18 Thread Nathan Lynch
The core RTAS support code and its clients perform two types of lookup for RTAS firmware function information. First, mapping a known function name to a token. The typical use case invokes rtas_token() to retrieve the token value to pass to rtas_call(). rtas_token() relies on of_get_property(),

[PATCH 07/13] powerpc/rtas: clean up includes

2022-11-18 Thread Nathan Lynch
rtas.c used to host complex code related to pseries-specific guest migration and suspend, which used atomics, completions, hcalls, and CPU hotplug APIs. That's all been deleted or moved, so remove the include directives that have been rendered unnecessary. Sort the remainder (with linux/ before

[PATCH 00/13] RTAS maintenance

2022-11-18 Thread Nathan Lynch
A collection of loosely-related RTAS code changes, most notably: * Fixing misuses of rtas_token() for non-function properties. * The stronger validation for sys_rtas() offered by the PPC_RTAS_FILTER config option is always enabled. * Improved function token lookups, including efficient

[PATCH 06/13] powerpc/rtas: clean up rtas_error_log_max initialization

2022-11-18 Thread Nathan Lynch
The code in rtas_get_error_log_max() doesn't cause problems in practice, but there are no measures to ensure that the lazy initialization of the static rtas_error_log_max variable is atomic, and it's not worth adding them. Initialize the static rtas_error_log_max variable at boot when we're

[PATCH 02/13] powerpc/rtasd: use correct OF API for event scan rate

2022-11-18 Thread Nathan Lynch
rtas_token() should be used only for properties that are RTAS function tokens. "rtas-event-scan-rate" does not contain a function token, but it has the same size/format as token properties so reading it with rtas_token() happens to work. Convert to of_property_read_u32(). Signed-off-by: Nathan

[PATCH 01/13] powerpc/rtas: document rtas_call()

2022-11-18 Thread Nathan Lynch
rtas_call() has a complex calling convention, non-standard return values, and many users. Add kernel-doc for it and remove the less structured commentary from rtas.h. Signed-off-by: Nathan Lynch --- arch/powerpc/include/asm/rtas.h | 15 - arch/powerpc/kernel/rtas.c | 58

[PATCH 03/13] powerpc/rtas: avoid device tree lookups in rtas_os_term()

2022-11-18 Thread Nathan Lynch
rtas_os_term() is called during panic. Its behavior depends on a couple of conditions in the /rtas node of the device tree, the traversal of which entails locking and local IRQ state changes. If the kernel panics while devtree_lock is held, rtas_os_term() as currently written could hang. Instead

Re: [PATCH printk v5 00/40] reduce console_lock scope

2022-11-18 Thread Petr Mladek
On Fri 2022-11-18 12:22:58, Petr Mladek wrote: > On Wed 2022-11-16 17:27:12, John Ogness wrote: > > This is v5 of a series to prepare for threaded/atomic > > printing. v4 is here [0]. This series focuses on reducing the > > scope of the BKL console_lock. It achieves this by switching to > > SRCU

Re: [patch 23/39] PCI/MSI: Move pci_alloc_irq_vectors_affinity() to api.c

2022-11-18 Thread Peter Zijlstra
On Fri, Nov 18, 2022 at 01:34:12PM +0100, Ahmed S. Darwish wrote: > On Wed, Nov 16, 2022 at 10:23:22AM -0600, Bjorn Helgaas wrote: > > On Fri, Nov 11, 2022 at 02:54:51PM +0100, Thomas Gleixner wrote: > ... > > > + > > > +/** > > > + * pci_alloc_irq_vectors_affinity() - Allocate multiple device

Re: [RFC PATCH 0/3] enable bpf_prog_pack allocator for powerpc

2022-11-18 Thread Christophe Leroy
Le 18/11/2022 à 10:39, Hari Bathini a écrit : > > > On 18/11/22 2:21 pm, Christophe Leroy wrote: > > I had the same config but hit this problem: > >    # echo 1 > /proc/sys/net/core/bpf_jit_enable; modprobe test_bpf >    test_bpf: #0 TAX >    [

Re: [PATCH printk v5 00/40] reduce console_lock scope

2022-11-18 Thread Petr Mladek
On Wed 2022-11-16 17:27:12, John Ogness wrote: > This is v5 of a series to prepare for threaded/atomic > printing. v4 is here [0]. This series focuses on reducing the > scope of the BKL console_lock. It achieves this by switching to > SRCU and a dedicated mutex for console list iteration and >

[PATCH] powerpc: Use "grep -E" instead of "egrep"

2022-11-18 Thread Tiezhu Yang
The latest version of grep claims the egrep is now obsolete so the build now contains warnings that look like: egrep: warning: egrep is obsolescent; using grep -E fix this up by moving the related file to use "grep -E" instead. sed -i "s/egrep/grep -E/g" `grep egrep -rwl arch/powerpc`

Re: [RFC PATCH 0/3] enable bpf_prog_pack allocator for powerpc

2022-11-18 Thread Hari Bathini
On 18/11/22 2:21 pm, Christophe Leroy wrote: Le 18/11/2022 à 09:39, Hari Bathini a écrit : On 17/11/22 12:29 pm, Christophe Leroy wrote: Le 16/11/2022 à 18:01, Hari Bathini a écrit : On 16/11/22 12:14 am, Christophe Leroy wrote: Le 14/11/2022 à 18:27, Christophe Leroy a écrit :

Re: [RFC PATCH v2 8/8] sched, smp: Trace smp callback causing an IPI

2022-11-18 Thread Peter Zijlstra
On Thu, Nov 17, 2022 at 02:45:29PM +, Valentin Schneider wrote: > > + if (trace_ipi_send_cpumask_enabled()) { > > + call_single_data_t *csd; > > + smp_call_func_t func; > > + > > + csd = container_of(node, call_single_data_t, node.llist); > > + > > +

Re: [RFC PATCH 0/3] enable bpf_prog_pack allocator for powerpc

2022-11-18 Thread Christophe Leroy
Le 18/11/2022 à 09:39, Hari Bathini a écrit : > > > On 17/11/22 12:29 pm, Christophe Leroy wrote: >> >> >> Le 16/11/2022 à 18:01, Hari Bathini a écrit : >>> >>> >>> On 16/11/22 12:14 am, Christophe Leroy wrote: Le 14/11/2022 à 18:27, Christophe Leroy a écrit : > > >

Re: [RFC PATCH 0/3] enable bpf_prog_pack allocator for powerpc

2022-11-18 Thread Hari Bathini
On 17/11/22 12:29 pm, Christophe Leroy wrote: Le 16/11/2022 à 18:01, Hari Bathini a écrit : On 16/11/22 12:14 am, Christophe Leroy wrote: Le 14/11/2022 à 18:27, Christophe Leroy a écrit : Le 14/11/2022 à 15:47, Hari Bathini a écrit : Hi Christophe, On 11/11/22 4:55 pm, Christophe