Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-12-01 Thread Hannes Reinecke
On 12/1/22 19:03, Greg Joyce wrote: On Wed, 2022-11-30 at 08:00 +0100, Hannes Reinecke wrote: On 11/30/22 00:25, gjo...@linux.vnet.ibm.com wrote: From: Greg Joyce Extend the SED block driver so it can alternatively obtain a key from a sed-opal kernel keyring. The SED ioctls will indicate the

Re: [powerpc:next] BUILD REGRESSION 3604661f206238a0295df53e38b7986a91c00cc4

2022-12-01 Thread Michael Ellerman
kernel test robot writes: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next > branch HEAD: 3604661f206238a0295df53e38b7986a91c00cc4 Merge branch > 'topic/qspinlock' into next > > Error/Warning reports: > > https://lore.kernel.org/oe-kbuild-all/202212020435.

Re: [PATCH v3 2/7] selftests/powerpc: Add ptrace setup_core_pattern() null-terminator

2022-12-01 Thread Andrew Donnellan
On Mon, 2022-11-28 at 15:19 +1100, Benjamin Gray wrote: > - malloc() does not zero the buffer, > - fread() does not null-terminate it's output, > - `cat /proc/sys/kernel/core_pattern | hexdump -C` shows the file is >   not inherently null-terminated > > So using string operations on the buffer is

linux-next: boot failure after merge of the powerpc tree

2022-12-01 Thread Stephen Rothwell
Hi all, After merging all the trees, today's linux-next qemu run (powerpc pseries_le_defconfig with kvm) crashed like this: Memory: 2029504K/2097152K available (14592K kernel code, 2944K rwdata, 18176K rodata, 5120K init, 1468K bss, 67648K reserved, 0K cma-reserved) SLUB: HWalign=128, Order=0-3,

Re: [PATCH 1/5] dt-bindings: net: qca,ar71xx: remove label = "cpu" from examples

2022-12-01 Thread Rob Herring
On Wed, 30 Nov 2022 17:10:36 +0300, Arınç ÜNAL wrote: > This is not used by the DSA dt-binding, so remove it from the examples. > > Signed-off-by: Arınç ÜNAL > --- > Documentation/devicetree/bindings/net/qca,ar71xx.yaml | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Rob Herring

[powerpc:merge] BUILD SUCCESS 4a8e43570ec8d94403b4ecdfb8f3d4e4807d165e

2022-12-01 Thread kernel test robot
21128 i386 randconfig-a002-20221128 x86_64randconfig-a011 x86_64randconfig-a013 x86_64randconfig-a015 arc randconfig-r043-20221201 riscvrandconfig-r042-20221201 s390 randc

Re: linux-next: build failure after merge of the tip tree

2022-12-01 Thread Benjamin Gray
On Fri, 2022-12-02 at 11:26 +1100, Stephen Rothwell wrote: > Though, I wonder if the powerpc tree should > use mm_alloc() instead of copy_init_mm() as well?  The tip tree > commit > says: > >     Instead of duplicating init_mm, allocate a fresh mm. The > advantage is >     that mm_alloc() has much

[powerpc:next] BUILD REGRESSION 3604661f206238a0295df53e38b7986a91c00cc4

2022-12-01 Thread kernel test robot
allmodconfig x86_64 rhel-8.3 x86_64 defconfig x86_64 allyesconfig x86_64randconfig-a013 x86_64randconfig-a011 x86_64randconfig-a015 arc

[powerpc:topic/ppc-kvm] BUILD SUCCESS 6c645b01e536757a9e1a9f72c13767f9b3f8559f

2022-12-01 Thread kernel test robot
defconfig parisc defconfig parisc64defconfig parisc allyesconfig i386 randconfig-c001 arc randconfig-r043-20221201 riscvrandconfig-r042

[powerpc:next-test] BUILD SUCCESS c4027f8490ab77605d0522069755ccbef0ffe616

2022-12-01 Thread kernel test robot
arc randconfig-r043-20221201 x86_64randconfig-a013 x86_64randconfig-a011 x86_64randconfig-a015 i386 randconfig-a001 s390 randconfig-r044-20221201 i386

linux-next: build failure after merge of the tip tree

2022-12-01 Thread Stephen Rothwell
Hi all, After merging the tip tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/lib/code-patching.c: In function 'text_area_cpu_up_mm': arch/powerpc/lib/code-patching.c:157:14: error: implicit declaration of function 'copy_init_mm' [-Werror=implicit-function

Re: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding

2022-12-01 Thread Rob Herring
On Thu, Dec 01, 2022 at 06:39:02PM +0100, Pali Rohár wrote: > On Thursday 01 December 2022 21:40:03 Michael Ellerman wrote: > > Arınç ÜNAL writes: > > > This is not used by the DSA dt-binding, so remove it from all devicetrees. > > > > > > Signed-off-by: Arınç ÜNAL > > > --- > > > arch/powerpc/b

Re: [PATCH 2/5] arm: dts: remove label = "cpu" from DSA dt-binding

2022-12-01 Thread Bjorn Andersson
On Wed, Nov 30, 2022 at 05:10:37PM +0300, Arınç ÜNAL wrote: [..] > arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 2 -- Acked-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH v2 21/50] KVM: MIPS: Hardcode callbacks to hardware virtualization extensions

2022-12-01 Thread Sean Christopherson
On Thu, Dec 01, 2022, Philippe Mathieu-Daudé wrote: > On 1/12/22 00:09, Sean Christopherson wrote: > > Now that KVM no longer supports trap-and-emulate (see commit 45c7e8af4a5e > > "MIPS: Remove KVM_TE support"), hardcode the MIPS callbacks to the > > virtualization callbacks. > > > > Harcoding th

Re: [PATCH v2 21/50] KVM: MIPS: Hardcode callbacks to hardware virtualization extensions

2022-12-01 Thread Philippe Mathieu-Daudé
On 1/12/22 00:09, Sean Christopherson wrote: Now that KVM no longer supports trap-and-emulate (see commit 45c7e8af4a5e "MIPS: Remove KVM_TE support"), hardcode the MIPS callbacks to the virtualization callbacks. Harcoding the callbacks eliminates the technically-unnecessary check on non-NULL kvm

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-12-01 Thread Greg Joyce
On Wed, 2022-11-30 at 08:00 +0100, Hannes Reinecke wrote: > On 11/30/22 00:25, gjo...@linux.vnet.ibm.com wrote: > > From: Greg Joyce > > > > Extend the SED block driver so it can alternatively > > obtain a key from a sed-opal kernel keyring. The SED > > ioctls will indicate the source of the key,

[linux-next:master] BUILD REGRESSION 2934ceb4e967b9233d0f97732e47175574a11406

2022-12-01 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 2934ceb4e967b9233d0f97732e47175574a11406 Add linux-next specific files for 20221201 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211041320.coq8eelj-...@intel.com https

Re: [PATCH 2/3] selftests/powerpc: Bump up rlimit for perf-hwbreak test

2022-12-01 Thread Rohan Deshpande
Hi, I have verified and tested this patch. No issues found. Changes look good. Tested-by: Rohan Deshpande

Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-01 Thread Ricardo Ribalda
Hi Oliver On Thu, 1 Dec 2022 at 14:22, 'Oliver Neukum' via Chromeos Kdump wrote: > > On 01.12.22 14:03, Ricardo Ribalda wrote: > > Hi, > > > This patchset does not modify this behaviour. It simply fixes the > > stall for kexec(). > > > > The patch that introduced the stall: > > 83bfc7e793b5 ("AS

Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-01 Thread Oliver Neukum
On 01.12.22 14:03, Ricardo Ribalda wrote: Hi, This patchset does not modify this behaviour. It simply fixes the stall for kexec(). The patch that introduced the stall: 83bfc7e793b5 ("ASoC: SOF: core: unregister clients and machine drivers in .shutdown") That patch is problematic. I would g

Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-01 Thread Ricardo Ribalda
Hi Oliver Thanks for your review On Thu, 1 Dec 2022 at 13:29, Oliver Neukum wrote: > > On 01.12.22 12:08, Ricardo Ribalda wrote: > > If we are shutting down due to kexec and the userspace is frozen, the > > system will stall forever waiting for userspace to complete. > > > > Do not wait for the

Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-01 Thread Oliver Neukum
On 01.12.22 12:08, Ricardo Ribalda wrote: If we are shutting down due to kexec and the userspace is frozen, the system will stall forever waiting for userspace to complete. Do not wait for the clients to complete in that case. Hi, I am afraid I have to state that this approach is bad in every

Re: [PATCH 0/5] remove label = "cpu" from DSA dt-binding

2022-12-01 Thread Arınç ÜNAL
On 1.12.2022 13:42, Michael Ellerman wrote: Arınç ÜNAL writes: On 30.11.2022 18:55, Andrew Lunn wrote: On Wed, Nov 30, 2022 at 05:10:35PM +0300, Arınç ÜNAL wrote: Hello folks, With this patch series, we're completely getting rid of 'label = "cpu";' which is not used by the DSA dt-binding at

Re: [RFC PATCH] Disable Book-E KVM support?

2022-12-01 Thread Bernhard Beschow
Am 1. Dezember 2022 06:06:16 UTC schrieb Nicholas Piggin : >On Thu Dec 1, 2022 at 6:45 AM AEST, Crystal Wood wrote: >> On Mon, 2022-11-28 at 14:36 +1000, Nicholas Piggin wrote: >> > BookE KVM is in a deep maintenance state, I'm not sure how much testing >> > it gets. I don't have a test setup, a

Re: [PATCH 4/5] mips: dts: remove label = "cpu" from DSA dt-binding

2022-12-01 Thread Thomas Bogendoerfer
On Wed, Nov 30, 2022 at 05:10:39PM +0300, Arınç ÜNAL wrote: > This is not used by the DSA dt-binding, so remove it from all devicetrees. > > Signed-off-by: Arınç ÜNAL > --- > arch/mips/boot/dts/qca/ar9331.dtsi| 1 - > arch/mips/boot/dts/ralink/mt7621.dtsi | 1 - > 2 files changed, 2 deletion

[PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-01 Thread Ricardo Ribalda
If we are shutting down due to kexec and the userspace is frozen, the system will stall forever waiting for userspace to complete. Do not wait for the clients to complete in that case. This fixes: [ 84.943749] Freezing user space processes ... (elapsed 0.111 seconds) done. [ 246.784446] INFO:

[PATCH v8 2/3] freezer: refactor pm_freezing into a function.

2022-12-01 Thread Ricardo Ribalda
Add a way to let the drivers know if the processes are frozen. This is needed by drivers that are waiting for processes to end on their shutdown path. Convert pm_freezing into a function and export it, so it can be used by drivers that are either built-in or modules. Cc: sta...@vger.kernel.org F

[PATCH v8 1/3] kexec: Refactor kexec_in_progress into a function

2022-12-01 Thread Ricardo Ribalda
Drivers running .shutdown() might want to behave differently during kexec. Convert kexec_in_progress into a function and export it, so it can be used by drivers that are either built-in or modules. Cc: sta...@vger.kernel.org Fixes: 83bfc7e793b5 ("ASoC: SOF: core: unregister clients and machine dr

[PATCH v8 0/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-01 Thread Ricardo Ribalda
Since: 83bfc7e793b5 ("ASoC: SOF: core: unregister clients and machine drivers in .shutdown") we wait for all the workloads to be completed during shutdown. This was done to avoid a stall once the device is started again. Unfortunately this has the side effect of stalling kexec(), if the userspac

Re: [PATCH v2 34/50] KVM: x86: Unify pr_fmt to use module name for all KVM modules

2022-12-01 Thread Paul Durrant
On 30/11/2022 23:09, Sean Christopherson wrote: Define pr_fmt using KBUILD_MODNAME for all KVM x86 code so that printks use consistent formatting across common x86, Intel, and AMD code. In addition to providing consistent print formatting, using KBUILD_MODNAME, e.g. kvm_amd and kvm_intel, allows

Re: [PATCH 0/5] remove label = "cpu" from DSA dt-binding

2022-12-01 Thread Michael Ellerman
Arınç ÜNAL writes: > On 30.11.2022 18:55, Andrew Lunn wrote: >> On Wed, Nov 30, 2022 at 05:10:35PM +0300, Arınç ÜNAL wrote: >>> Hello folks, >>> >>> With this patch series, we're completely getting rid of 'label = "cpu";' >>> which is not used by the DSA dt-binding at all. >>> >>> Information for

Re: [PATCH 1/5] dt-bindings: net: qca,ar71xx: remove label = "cpu" from examples

2022-12-01 Thread Oleksij Rempel
On Wed, Nov 30, 2022 at 05:10:36PM +0300, Arınç ÜNAL wrote: > This is not used by the DSA dt-binding, so remove it from the examples. > > Signed-off-by: Arınç ÜNAL Reviewed-by: Oleksij Rempel Thx! > --- > Documentation/devicetree/bindings/net/qca,ar71xx.yaml | 1 - > 1 file changed, 1 deleti

Re: [PATCH 4/5] mips: dts: remove label = "cpu" from DSA dt-binding

2022-12-01 Thread Oleksij Rempel
On Wed, Nov 30, 2022 at 05:10:39PM +0300, Arınç ÜNAL wrote: > This is not used by the DSA dt-binding, so remove it from all devicetrees. > > Signed-off-by: Arınç ÜNAL > --- > arch/mips/boot/dts/qca/ar9331.dtsi| 1 - > arch/mips/boot/dts/ralink/mt7621.dtsi | 1 - > 2 files changed, 2 deletion

Re: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding

2022-12-01 Thread Pali Rohár
On Thursday 01 December 2022 21:40:03 Michael Ellerman wrote: > Arınç ÜNAL writes: > > This is not used by the DSA dt-binding, so remove it from all devicetrees. > > > > Signed-off-by: Arınç ÜNAL > > --- > > arch/powerpc/boot/dts/turris1x.dts | 2 -- > > 1 file changed, 2 deletions(-) > > Addin

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-12-01 Thread Greg Joyce
On Thu, 2022-12-01 at 10:58 -0600, Greg Joyce wrote: > On Thu, 2022-12-01 at 11:12 -0500, Ben Boeckel wrote: > > On Thu, Dec 01, 2022 at 09:29:36 -0600, Greg Joyce wrote: > > > On Wed, 2022-11-30 at 22:46 -0500, Ben Boeckel wrote: > > > > Perhaps naming it `OPAL_MAX_KEY_LEN` would help clarify this

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-12-01 Thread Greg Joyce
On Thu, 2022-12-01 at 11:12 -0500, Ben Boeckel wrote: > On Thu, Dec 01, 2022 at 09:29:36 -0600, Greg Joyce wrote: > > On Wed, 2022-11-30 at 22:46 -0500, Ben Boeckel wrote: > > > Perhaps naming it `OPAL_MAX_KEY_LEN` would help clarify this? > > > > I'm not averse to changing it because it would be

Re: [PATCH v2 26/50] KVM: PPC: Move processor compatibility check to module init

2022-12-01 Thread Sean Christopherson
On Thu, Dec 01, 2022, Michael Ellerman wrote: > Sean Christopherson writes: > > Move KVM PPC's compatibility checks to their respective module_init() > > hooks, there's no need to wait until KVM's common compat check, nor is > > there a need to perform the check on every CPU (provided by common KV

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-12-01 Thread Ben Boeckel
On Thu, Dec 01, 2022 at 09:29:36 -0600, Greg Joyce wrote: > On Wed, 2022-11-30 at 22:46 -0500, Ben Boeckel wrote: > > Perhaps naming it `OPAL_MAX_KEY_LEN` would help clarify this? > > I'm not averse to changing it because it would be clearer. My concern > is that it's been OPAL_KEY_MAX for 5+ year

[PATCH] powerpc/ftrace: fix syscall tracing on PPC64_ELF_ABI_V1

2022-12-01 Thread Michael Jeanson
In v5.7 the powerpc syscall entry/exit logic was rewritten in C, on PPC64_ELF_ABI_V1 this resulted in the symbols in the syscall table changing from their dot prefixed variant to the non-prefixed ones. Since ftrace prefixes a dot to the syscall names when matching them to build its syscall event l

Re: [PATCH v2 10/50] KVM: VMX: Reset eVMCS controls in VP assist page during hardware disabling

2022-12-01 Thread Vitaly Kuznetsov
Sean Christopherson writes: > Reset the eVMCS controls in the per-CPU VP assist page during hardware > disabling instead of waiting until kvm-intel's module exit. The controls > are activated if and only if KVM creates a VM, i.e. don't need to be > reset if hardware is never enabled. > > Doing t

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-12-01 Thread Greg Joyce
On Wed, 2022-11-30 at 22:46 -0500, Ben Boeckel wrote: > On Wed, Nov 30, 2022 at 09:19:25 -0600, Greg Joyce wrote: > > On Wed, 2022-11-30 at 08:00 +0100, Hannes Reinecke wrote: > > > On 11/30/22 00:25, gjo...@linux.vnet.ibm.com wrote: > > > > + case OPAL_KEYRING: > > > > + /* the

Re: [PATCH v2 12/50] KVM: VMX: Move Hyper-V eVMCS initialization to helper

2022-12-01 Thread Vitaly Kuznetsov
Sean Christopherson writes: > Move Hyper-V's eVMCS initialization to a dedicated helper to clean up > vmx_init(), and add a comment to call out that the Hyper-V init code > doesn't need to be unwound if vmx_init() ultimately fails. > > No functional change intended. > > Signed-off-by: Sean Christ

Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-01 Thread Takashi Iwai
On Thu, 01 Dec 2022 14:22:12 +0100, Oliver Neukum wrote: > > On 01.12.22 14:03, Ricardo Ribalda wrote: > > Hi, > > > This patchset does not modify this behaviour. It simply fixes the > > stall for kexec(). > > > > The patch that introduced the stall: > > 83bfc7e793b5 ("ASoC: SOF: core: unregi

Re: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding

2022-12-01 Thread Michael Ellerman
Arınç ÜNAL writes: > This is not used by the DSA dt-binding, so remove it from all devicetrees. > > Signed-off-by: Arınç ÜNAL > --- > arch/powerpc/boot/dts/turris1x.dts | 2 -- > 1 file changed, 2 deletions(-) Adding Pali to Cc. These were only recently updated in commit: 8bf056f57f1d ("pow

Re: [PATCH 0/5] remove label = "cpu" from DSA dt-binding

2022-12-01 Thread Arınç ÜNAL
I'm sending a more specific mail to make sure this series doesn't fall through the cracks like Andrew said. I'd like this merged this week before the merge window closes. Jakub, please take patch 1. Arnd, please take patch 2 and 3. Thomas, please take patch 4. Michael, please take patch 5. Arı

[PATCH v1 04/10] powerpc/bpf/32: Only set a stack frame when necessary

2022-12-01 Thread Christophe Leroy
Until now a stack frame was set at all time due to the need to keep tail call counter in the stack. But since commit fa025537f584 ("powerpc/bpf/32: Fix Oops on tail call tests"), the tail call counter is passed via register r4. It is therefore not necessary anymore to have a stack frame for that.

[PATCH v1 10/10] powerpc/bpf/32: perform three operands ALU operations

2022-12-01 Thread Christophe Leroy
When an ALU instruction is preceded by a MOV instruction that just moves a source register into the destination register of the ALU, replace that MOV+ALU instructions by an ALU operation taking the source of the MOV as second source instead of using its destination. Before the change, code could l

[PATCH v1 06/10] powerpc/bpf: Perform complete extra passes to update addresses

2022-12-01 Thread Christophe Leroy
BPF core calls the jit compiler again for an extra pass in order to properly set subprog addresses. Unlike other architectures, powerpc only updates the addresses during that extra pass. It means that holes must have been left in the code in order to enable the maximum possible instruction size.

[PATCH v1 08/10] powerpc/bpf/32: Optimise some particular const operations

2022-12-01 Thread Christophe Leroy
Simplify multiplications and divisions with constants when the constant is 1 or -1. When the constant is a power of 2, replace them by bit shits. Signed-off-by: Christophe Leroy --- arch/powerpc/net/bpf_jit_comp32.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-)

[PATCH v1 09/10] powerpc/bpf/32: introduce a second source register for ALU operations

2022-12-01 Thread Christophe Leroy
At the time being, all ALU operation are performed with same L-source and destination, requiring the L-source to be moved into destination via a separate register move, like: 70: 7f c6 f3 78 mr r6,r30 74: 7f a5 eb 78 mr r5,r29 78: 30 c6 ff f4 addic r6,r6,-12 7