Re: (subset) [PATCH 000/606] i2c: Complete conversion to i2c_probe_new

2022-12-09 Thread Robert Foss
On Fri, 18 Nov 2022 23:35:34 +0100, Uwe Kleine-König wrote: > since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type") from 2016 there is a "temporary" alternative probe > callback for i2c drivers. > > This series completes all drivers to this new callback (unless I mis

Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-09 Thread Kai Vehmanen
Hi, On Thu, 1 Dec 2022, Ricardo Ribalda wrote: > On Thu, 1 Dec 2022 at 14:22, 'Oliver Neukum' via Chromeos Kdump > wrote: > > > > On 01.12.22 14:03, Ricardo Ribalda wrote: > > > This patchset does not modify this behaviour. It simply fixes the > > > stall for kexec(). > > > > > > The patch tha

Re: powerpc-part: was: Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-12-09 Thread Song Liu
On Fri, Dec 9, 2022 at 3:41 AM Petr Mladek wrote: > > Hi, > > this reply is only about the powerpc-specific part. > > Also adding Kamalesh and Michael into Cc who worked on the related > commit a443bf6e8a7674b86221f49 ("powerpc/modules: Add REL24 relocation > support of livepatch symbols"). > > >

Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-12-09 Thread Song Liu
On Fri, Dec 9, 2022 at 10:52 AM Christophe Leroy wrote: > > > > Le 09/12/2022 à 19:30, Song Liu a écrit : > > On Fri, Dec 9, 2022 at 4:55 AM Miroslav Benes wrote: > >> > >> Hi, > >> > >> first thank you for taking over and I also appologize for not replying > >> much sooner. > >> > >> On Thu, 1 S

Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-12-09 Thread Christophe Leroy
Le 09/12/2022 à 19:30, Song Liu a écrit : > On Fri, Dec 9, 2022 at 4:55 AM Miroslav Benes wrote: >> >> Hi, >> >> first thank you for taking over and I also appologize for not replying >> much sooner. >> >> On Thu, 1 Sep 2022, Song Liu wrote: >> >>> From: Miroslav Benes >>> >>> Josh reported a b

Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-12-09 Thread Song Liu
On Fri, Dec 9, 2022 at 4:55 AM Miroslav Benes wrote: > > Hi, > > first thank you for taking over and I also appologize for not replying > much sooner. > > On Thu, 1 Sep 2022, Song Liu wrote: > > > From: Miroslav Benes > > > > Josh reported a bug: > > > > When the object to be patched is a modul

Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-12-09 Thread Song Liu
On Fri, Dec 9, 2022 at 5:54 AM Petr Mladek wrote: > > On Mon 2022-11-28 17:57:06, Song Liu wrote: > > On Fri, Nov 18, 2022 at 8:24 AM Petr Mladek wrote: > > > > --- a/kernel/livepatch/core.c > > > > +++ b/kernel/livepatch/core.c > > > > @@ -316,6 +316,45 @@ int klp_apply_section_relocs(struct mod

Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-12-09 Thread Petr Mladek
On Fri 2022-12-09 14:54:10, Petr Mladek wrote: > On Mon 2022-11-28 17:57:06, Song Liu wrote: > > On Fri, Nov 18, 2022 at 8:24 AM Petr Mladek wrote: > > > > --- a/kernel/livepatch/core.c > > > > +++ b/kernel/livepatch/core.c > I see that you removed also: > > if (strcmp(objname ? objname : "

Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-12-09 Thread Petr Mladek
On Mon 2022-11-28 17:57:06, Song Liu wrote: > On Fri, Nov 18, 2022 at 8:24 AM Petr Mladek wrote: > > > --- a/kernel/livepatch/core.c > > > +++ b/kernel/livepatch/core.c > > > @@ -316,6 +316,45 @@ int klp_apply_section_relocs(struct module *pmod, > > > Elf_Shdr *sechdrs, > > > return apply_r

Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-12-09 Thread Miroslav Benes
Hi, first thank you for taking over and I also appologize for not replying much sooner. On Thu, 1 Sep 2022, Song Liu wrote: > From: Miroslav Benes > > Josh reported a bug: > > When the object to be patched is a module, and that module is > rmmod'ed and reloaded, it fails to load with: >

Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-12-09 Thread Miroslav Benes
> > > --- a/kernel/livepatch/core.c > > > +++ b/kernel/livepatch/core.c > > > @@ -316,6 +316,45 @@ int klp_apply_section_relocs(struct module *pmod, > > > Elf_Shdr *sechdrs, > > > return apply_relocate_add(sechdrs, strtab, symndx, secndx, pmod); > > > } > > > > > > +static void klp_clear_ob

x86 part: was: Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-12-09 Thread Petr Mladek
On Mon 2022-11-28 17:57:06, Song Liu wrote: > On Fri, Nov 18, 2022 at 8:24 AM Petr Mladek wrote: > --- a/arch/x86/kernel/module.c > +++ b/arch/x86/kernel/module.c > > This duplicates a lot of code. Please, rename apply_relocate_add() the > > same way as __apply_clear_relocate_add() and add the "ap

powerpc-part: was: Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-12-09 Thread Petr Mladek
Hi, this reply is only about the powerpc-specific part. Also adding Kamalesh and Michael into Cc who worked on the related commit a443bf6e8a7674b86221f49 ("powerpc/modules: Add REL24 relocation support of livepatch symbols"). On Mon 2022-11-28 17:57:06, Song Liu wrote: > On Fri, Nov 18, 2022 at