Re: [PATCH v3 03/14] arm64: reword ARCH_FORCE_MAX_ORDER prompt and help text

2023-03-24 Thread Kefeng Wang
On 2023/3/25 14:08, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to describe this configuration option. Update both to actually describe what this option does. Acked-by: Kirill A. Shutemov Reviewed-by: Zi Yan Signed-

Re: [PATCH v3 02/14] arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER

2023-03-24 Thread Kefeng Wang
On 2023/3/25 14:08, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" It is not a good idea to change fundamental parameters of core memory management. Having predefined ranges suggests that the values within those ranges are sensible, but one has to *really* understand implications of changi

Re: [PATCH v3 05/14] ia64: don't allow users to override ARCH_FORCE_MAX_ORDER

2023-03-24 Thread Kefeng Wang
On 2023/3/25 14:08, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" It is enough to keep default values for base and huge pages without letting users to override ARCH_FORCE_MAX_ORDER. Drop the prompt to make the option unvisible in *config. Acked-by: Kirill A. Shutemov Reviewed-by: Zi Ya

[PATCH v3 14/14] xtensa: reword ARCH_FORCE_MAX_ORDER prompt and help text

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to describe this configuration option. Update both to actually describe what this option does. Reviewed-by: Max Filippov Acked-by: Kirill A. Shutemov Reviewed-by: Zi Yan Signed-off-by: Mike Rapopo

[PATCH v3 13/14] sparc: reword ARCH_FORCE_MAX_ORDER prompt and help text

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to describe this configuration option. Update both to actually describe what this option does. Acked-by: Kirill A. Shutemov Reviewed-by: Zi Yan Signed-off-by: Mike Rapoport (IBM) --- arch/sparc/K

[PATCH v3 12/14] sh: drop ranges for definition of ARCH_FORCE_MAX_ORDER

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" sh defines insane ranges for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER up to 63, which implies maximal contiguous allocation size of 2^63 pages. Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a simple integer with sensible defaults. Users that *

[PATCH v3 11/14] sh: reword ARCH_FORCE_MAX_ORDER prompt and help text

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to describe this configuration option. Update both to actually describe what this option does. Acked-by: Kirill A. Shutemov Reviewed-by: Zi Yan Signed-off-by: Mike Rapoport (IBM) --- arch/sh/mm/K

[PATCH v3 10/14] powerpc: drop ranges for definition of ARCH_FORCE_MAX_ORDER

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" PowerPC defines ranges for ARCH_FORCE_MAX_ORDER some of which are insanely allowing MAX_ORDER up to 63, which implies maximal contiguous allocation size of 2^63 pages. Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a simple integer with sensibl

[PATCH v3 09/14] powerpc: reword ARCH_FORCE_MAX_ORDER prompt and help text

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to describe this configuration option. Update both to actually describe what this option does. Acked-by: Kirill A. Shutemov Reviewed-by: Zi Yan Signed-off-by: Mike Rapoport (IBM) --- arch/powerpc

[PATCH v3 08/14] nios2: drop ranges for definition of ARCH_FORCE_MAX_ORDER

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" nios2 defines range for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER up to 19, which implies maximal contiguous allocation size of 2^19 pages or 2GiB. Drop bogus definition of ranges for ARCH_FORCE_MAX_ORDER and leave it a simple integer with sensible default. Users that

[PATCH v3 07/14] nios2: reword ARCH_FORCE_MAX_ORDER prompt and help text

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to describe this configuration option. Update both to actually describe what this option does. Acked-by: Kirill A. Shutemov Reviewed-by: Zi Yan Signed-off-by: Mike Rapoport (IBM) --- arch/nios2/K

[PATCH v3 06/14] m68k: reword ARCH_FORCE_MAX_ORDER prompt and help text

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to describe this configuration option. Update both to actually describe what this option does. Acked-by: Kirill A. Shutemov Acked-by: Geert Uytterhoeven Reviewed-by: Zi Yan Signed-off-by: Mike Rap

[PATCH v3 05/14] ia64: don't allow users to override ARCH_FORCE_MAX_ORDER

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" It is enough to keep default values for base and huge pages without letting users to override ARCH_FORCE_MAX_ORDER. Drop the prompt to make the option unvisible in *config. Acked-by: Kirill A. Shutemov Reviewed-by: Zi Yan Signed-off-by: Mike Rapoport (IBM) --- ar

[PATCH v3 04/14] csky: drop ARCH_FORCE_MAX_ORDER

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" The default value of ARCH_FORCE_MAX_ORDER matches the generic default defined in the MM code, the architecture does not support huge pages, so there is no need to keep ARCH_FORCE_MAX_ORDER option available. Drop it. Acked-by: Kirill A. Shutemov Reviewed-by: Zi Yan

[PATCH v3 03/14] arm64: reword ARCH_FORCE_MAX_ORDER prompt and help text

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to describe this configuration option. Update both to actually describe what this option does. Acked-by: Kirill A. Shutemov Reviewed-by: Zi Yan Signed-off-by: Mike Rapoport (IBM) --- arch/arm64/K

[PATCH v3 02/14] arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" It is not a good idea to change fundamental parameters of core memory management. Having predefined ranges suggests that the values within those ranges are sensible, but one has to *really* understand implications of changing MAX_ORDER before actually amending it and r

[PATCH v3 01/14] arm: reword ARCH_FORCE_MAX_ORDER prompt and help text

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to describe this configuration option. Update both to actually describe what this option does. Acked-by: Kirill A. Shutemov Reviewed-by: Zi Yan Signed-off-by: Mike Rapoport (IBM) --- arch/arm/Kco

[PATCH v3 00/14] arch,mm: cleanup Kconfig entries for ARCH_FORCE_MAX_ORDER

2023-03-24 Thread Mike Rapoport
From: "Mike Rapoport (IBM)" Hi, Several architectures have ARCH_FORCE_MAX_ORDER in their Kconfig and they all have wrong and misleading prompt and help text for this option. Besides, some define insane limits for possible values of ARCH_FORCE_MAX_ORDER, some carefully define ranges only for a s

Re: Memory coherency issue with IO thread offloading?

2023-03-24 Thread Jens Axboe
On 3/24/23 6:42?PM, Michael Ellerman wrote: > Jens Axboe writes: >> Hi, > > Hi Jens, > > Thanks for the report. > >> I got a report sent to me from mariadb, in where 5.10.158 works fine and >> 5.10.162 is broken. And in fact, current 6.3-rc also fails the test >> case. Beware that this email is

Re: Memory coherency issue with IO thread offloading?

2023-03-24 Thread Michael Ellerman
Jens Axboe writes: > Hi, Hi Jens, Thanks for the report. > I got a report sent to me from mariadb, in where 5.10.158 works fine and > 5.10.162 is broken. And in fact, current 6.3-rc also fails the test > case. Beware that this email is long, as I'm trying to include > everything that may be rel

Re: Memory coherency issue with IO thread offloading?

2023-03-24 Thread Jens Axboe
On 3/24/23 6:15 PM, Michael Ellerman wrote: > Jens Axboe writes: >> On 3/24/23 1:27?AM, Christophe Leroy wrote: >>> Le 23/03/2023 ? 19:54, Jens Axboe a ?crit : I got a report sent to me from mariadb, in where 5.10.158 works fine and 5.10.162 is broken. And in fact, current 6.3-rc also fa

Re: Memory coherency issue with IO thread offloading?

2023-03-24 Thread Michael Ellerman
Jens Axboe writes: > On 3/24/23 1:27?AM, Christophe Leroy wrote: >> Le 23/03/2023 ? 19:54, Jens Axboe a ?crit : >>> I got a report sent to me from mariadb, in where 5.10.158 works fine and >>> 5.10.162 is broken. And in fact, current 6.3-rc also fails the test >>> case. Beware that this email is l

[PATCH] powerpc/pseries: Add spaces around / operator

2023-03-24 Thread Petr Vaněk
This is follow up change after 14b5d59a261b ("powerpc/pseries: Fix formatting to make code look more beautiful") to conform to kernel coding style. Signed-off-by: Petr Vaněk --- arch/powerpc/platforms/pseries/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerp

Re: [linux-next:master] BUILD REGRESSION 7c4a254d78f89546d0e74a40617ef24c6151c8d1

2023-03-24 Thread Péter Ujfalusi
Hi, On 23/03/2023 23:34, kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: 7c4a254d78f89546d0e74a40617ef24c6151c8d1 Add linux-next > specific files for 20230323 > > Error/Warning reports: > > https://lore.kernel

Re: [PATCH v2 00/14] arch,mm: cleanup Kconfig entries for ARCH_FORCE_MAX_ORDER

2023-03-24 Thread Mike Rapoport
On Fri, Mar 24, 2023 at 10:30:07AM -0400, Zi Yan wrote: > On 24 Mar 2023, at 1:22, Mike Rapoport wrote: > > > From: "Mike Rapoport (IBM)" > > > > Hi, > > > > Several architectures have ARCH_FORCE_MAX_ORDER in their Kconfig and > > they all have wrong and misleading prompt and help text for this o

Re: [PATCH 01/10] locking/atomic: Add missing cast to try_cmpxchg() fallbacks

2023-03-24 Thread Mark Rutland
On Fri, Mar 24, 2023 at 04:14:22PM +, Mark Rutland wrote: > On Fri, Mar 24, 2023 at 04:43:32PM +0100, Uros Bizjak wrote: > > On Fri, Mar 24, 2023 at 3:13 PM Mark Rutland wrote: > > > > > > On Sun, Mar 05, 2023 at 09:56:19PM +0100, Uros Bizjak wrote: > > > > Cast _oldp to the type of _ptr to av

Re: [PATCH 01/10] locking/atomic: Add missing cast to try_cmpxchg() fallbacks

2023-03-24 Thread Mark Rutland
On Fri, Mar 24, 2023 at 04:43:32PM +0100, Uros Bizjak wrote: > On Fri, Mar 24, 2023 at 3:13 PM Mark Rutland wrote: > > > > On Sun, Mar 05, 2023 at 09:56:19PM +0100, Uros Bizjak wrote: > > > Cast _oldp to the type of _ptr to avoid incompatible-pointer-types > > > warning. > > > > Can you give an e

Re: [PATCH 01/10] locking/atomic: Add missing cast to try_cmpxchg() fallbacks

2023-03-24 Thread Uros Bizjak
On Fri, Mar 24, 2023 at 3:13 PM Mark Rutland wrote: > > On Sun, Mar 05, 2023 at 09:56:19PM +0100, Uros Bizjak wrote: > > Cast _oldp to the type of _ptr to avoid incompatible-pointer-types warning. > > Can you give an example of where we are passing an incompatible pointer? An example is patch 10/

Re: [PATCH v2 00/14] arch,mm: cleanup Kconfig entries for ARCH_FORCE_MAX_ORDER

2023-03-24 Thread Zi Yan
On 24 Mar 2023, at 1:22, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Hi, > > Several architectures have ARCH_FORCE_MAX_ORDER in their Kconfig and > they all have wrong and misleading prompt and help text for this option. > > Besides, some define insane limits for possible values of > A

Re: [PATCH v2 11/14] sh: reword ARCH_FORCE_MAX_ORDER prompt and help text

2023-03-24 Thread Zi Yan
On 24 Mar 2023, at 1:22, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to > describe this configuration option. > > Update both to actually describe what this option does. > > Signed-off-by: Mike Rapoport (IBM) > Acked-

Re: [PATCH 01/10] locking/atomic: Add missing cast to try_cmpxchg() fallbacks

2023-03-24 Thread Mark Rutland
On Sun, Mar 05, 2023 at 09:56:19PM +0100, Uros Bizjak wrote: > Cast _oldp to the type of _ptr to avoid incompatible-pointer-types warning. Can you give an example of where we are passing an incompatible pointer? That sounds indicative of a bug in the caller, but maybe I'm missing some reason this

Re: [PATCH v2 03/14] arm64: reword ARCH_FORCE_MAX_ORDER prompt and help text

2023-03-24 Thread Zi Yan
On 24 Mar 2023, at 1:22, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to > describe this configuration option. > > Update both to actually describe what this option does. > > Signed-off-by: Mike Rapoport (IBM) > Acked-

Re: [PATCH v12 13/13] arm64: dts: ls1088ardb: Add serdes descriptions

2023-03-24 Thread Ioana Ciornei
On Tue, Mar 21, 2023 at 04:13:12PM -0400, Sean Anderson wrote: > This adds serdes support to the LS1088ARDB. I have tested the QSGMII > ports as well as the two 10G ports. The SFP slot is now fully supported, > instead of being modeled as a fixed-link. > > Linux hangs around when the serdes is ini

Re: Memory coherency issue with IO thread offloading?

2023-03-24 Thread Jens Axboe
On 3/24/23 1:27?AM, Christophe Leroy wrote: > Hi, > > Le 23/03/2023 ? 19:54, Jens Axboe a ?crit : >> Hi, >> >> I got a report sent to me from mariadb, in where 5.10.158 works fine and >> 5.10.162 is broken. And in fact, current 6.3-rc also fails the test >> case. Beware that this email is long, as

Re: [PATCH v8 1/3] riscv: Introduce CONFIG_RELOCATABLE

2023-03-24 Thread Alexandre Ghiti
Hi Nick, On 3/22/23 19:25, Nick Desaulniers wrote: On Fri, Feb 24, 2023 at 7:58 AM Björn Töpel wrote: Alexandre Ghiti writes: +cc linux-kbuild, llvm, Nathan, Nick On 2/15/23 15:36, Alexandre Ghiti wrote: From: Alexandre Ghiti I tried a lot of things, but I struggle to understand, does

Re: [PATCH] crypto: p10-aes-gcm - remove duplicate include header

2023-03-24 Thread Herbert Xu
On Tue, Mar 14, 2023 at 04:31:51PM +0800, ye.xingc...@zte.com.cn wrote: > From: Ye Xingchen > > crypto/algapi.h is included more than once. > > Signed-off-by: Ye Xingchen > --- > arch/powerpc/crypto/aes-gcm-p10-glue.c | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks. -- Email: H

Re: [PATCH v7 6/6] PCI: Make use of pci_resource_n()

2023-03-24 Thread Andy Shevchenko
On Fri, Mar 24, 2023 at 10:08:39AM +0100, Philippe Mathieu-Daudé wrote: > On 23/3/23 18:36, Andy Shevchenko wrote: > > Replace open-coded implementations of pci_resource_n() in pci.h. ... > > #define pci_resource_n(dev, bar) (&(dev)->resource[(bar)]) > > -#define pci_resource_start(dev, bar)

Re: [PATCH v7 4/6] EISA: Convert to use less arguments in pci_bus_for_each_resource()

2023-03-24 Thread Andy Shevchenko
On Fri, Mar 24, 2023 at 10:02:15AM +0100, Philippe Mathieu-Daudé wrote: > On 23/3/23 18:36, Andy Shevchenko wrote: > > The pci_bus_for_each_resource() can hide the iterator loop since > > it may be not used otherwise. With this, we may drop that iterator > > variable definition. > > > > Signed-off

Re: [PATCH v3 0/4] Use dma_default_coherent for devicetree default coherency

2023-03-24 Thread Jiaxun Yang
> 2023年3月23日 21:39,Christoph Hellwig 写道: > > On Thu, Mar 23, 2023 at 09:07:31PM +, Jiaxun Yang wrote: >> >> >>> 2023年3月23日 07:29,Christoph Hellwig 写道: >>> >>> The series looks fine to me. How should we merge it? >> >> Perhaps go through dma-mapping tree? > > Is patch a 6.3 candidate

Re: [PATCH v7 6/6] PCI: Make use of pci_resource_n()

2023-03-24 Thread Philippe Mathieu-Daudé
On 23/3/23 18:36, Andy Shevchenko wrote: Replace open-coded implementations of pci_resource_n() in pci.h. Signed-off-by: Andy Shevchenko --- include/linux/pci.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/linux/pci.h b/include/linux/pci.h index

Re: [PATCH v7 4/6] EISA: Convert to use less arguments in pci_bus_for_each_resource()

2023-03-24 Thread Philippe Mathieu-Daudé
On 23/3/23 18:36, Andy Shevchenko wrote: The pci_bus_for_each_resource() can hide the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko Reviewed-by: Krzysztof Wilczyński --- drivers/eisa/pci_eisa.c | 4 +

Re: [PATCH v7 3/6] PCI: Allow pci_bus_for_each_resource() to take less arguments

2023-03-24 Thread Philippe Mathieu-Daudé
On 23/3/23 18:36, Andy Shevchenko wrote: Refactor pci_bus_for_each_resource() in the same way as it's done in pci_dev_for_each_resource() case. This will allow to hide iterator inside the loop, where it's not used otherwise. No functional changes intended. Signed-off-by: Andy Shevchenko Review

Re: Memory coherency issue with IO thread offloading?

2023-03-24 Thread Christophe Leroy
Hi, Le 23/03/2023 à 19:54, Jens Axboe a écrit : > Hi, > > I got a report sent to me from mariadb, in where 5.10.158 works fine and > 5.10.162 is broken. And in fact, current 6.3-rc also fails the test > case. Beware that this email is long, as I'm trying to include > everything that may be releva