Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-26 Thread Oliver Sang
hi, Linus, On Sun, Nov 26, 2023 at 03:20:58PM -0800, Linus Torvalds wrote: > On Sun, 26 Nov 2023 at 12:23, Linus Torvalds > wrote: > > > > IOW, I might have messed up some "trivial cleanup" when prepping for > > sending it out... > > Bah. Famous last words. One of the "trivial cleanups" made

Re: [PATCH] powerpc/mm: Fix null-pointer dereference in pgtable_cache_add

2023-11-26 Thread Kunwu Chan
Hi Christophe, Thanks for your reply. It's my bad. According your reply, i read the code in sysfs_do_create_link_sd.There is a null pointer check indeed. My intention was to check null pointer after memory allocation. Whether we can add a comment here for someone like me, the null pointer

[PATCH 3/3] powerpc/64: Only warn for kuap locked when KCSAN not present

2023-11-26 Thread Rohan McLure
Arbitrary instrumented locations, including syscall handlers, can call arch_local_irq_restore() transitively when KCSAN is enabled, and in turn also replay_soft_interrupts_irqrestore(). The precondition on entry to this routine that is checked is that KUAP is enabled (user access prohibited).

[PATCH 2/3] powerpc: Apply __always_inline to interrupt_{enter,exit}_prepare()

2023-11-26 Thread Rohan McLure
In keeping with the advice given by Documentation/core-api/entry.rst, entry and exit handlers for interrupts should not be instrumented. Guarantee that the interrupt_{enter,exit}_prepare() routines are inlined so that they will inheret instrumentation from their caller. KCSAN kernels were

[PATCH 1/3] asm-generic/mmiowb: Mark accesses to fix KCSAN warnings

2023-11-26 Thread Rohan McLure
Prior to this patch, data races are detectable by KCSAN of the following forms: [1] Asynchronous calls to mmiowb_set_pending() from an interrupt context or otherwise outside of a critical section [2] Interrupted critical sections, where the interrupt will itself acquire a lock In case

Re: [PATCHv9 2/2] powerpc/setup: Loosen the mapping between cpu logical id and its seq in dt

2023-11-26 Thread Hari Bathini
Hi Pingfan, Michael, On 17/10/23 4:03 pm, Hari Bathini wrote: On 17/10/23 7:58 am, Pingfan Liu wrote: *** Idea *** For kexec -p, the boot cpu can be not the cpu0, this causes the problem of allocating memory for paca_ptrs[]. However, in theory, there is no requirement to assign cpu's logical

[PATCH] powerpc/powernv/pci: Do setup dev PE in pnv_pci_enable_device_hook

2023-11-26 Thread Luming Yu
after hot remove a pcie deivce with pci_dn having pnp_php driver attached, pci rescan with echo 1 > /sys/bus/pci/rescan could fail with error message like: pci 0020:0e:00.0: BAR 0: assigned [mem 0x3fe80182-0x3fe80182 64bit] nvme nvme1: pci function 0020:0e:00.0 nvme 0020:0e:00.0

Re: linux-next: build failure after merge of the mm tree

2023-11-26 Thread Stephen Rothwell
Hi all, Just cc'ing the PowerPC guys to see if my fix is sensible. On Mon, 27 Nov 2023 13:28:09 +1100 Stephen Rothwell wrote: > > After merging the mm tree, today's linux-next build (powerpc64 > allnoconfig) failed like this: > > arch/powerpc/mm/book3s64/pgtable.c:557:5: error: no previous

[PATCH] powerpc/powernv: Add a null pointer check in opal_event_init

2023-11-26 Thread Kunwu Chan
kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Fixes: 2717a33d6074 ("powerpc/opal-irqchip: Use interrupt names if present") Signed-off-by: Kunwu Chan --- arch/powerpc/platforms/powernv/opal-irqchip.c | 2 ++ 1 file changed, 2 insertions(+) diff

linux-next: duplicate patch in the tty tree

2023-11-26 Thread Stephen Rothwell
Hi all, The following commit is also in the powerpc tree as a different commit (but the same patch): aa46b225ebbf ("tty: hvc: hvc_opal: Convert to platform remove callback returning void") This is commit f99c0e0d0859 ("tty: hvc: hvc_opal: Convert to platform remove callback returning

linux-next: manual merge of the tty tree with the powerpc tree

2023-11-26 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tty tree got a conflict in: drivers/tty/hvc/hvc_console.h between commit: c9e38dc90e1c ("tty: hvc: Make hvc_remove() return no value") from the powerpc tree and commit: 7f30c19caf94 ("tty: hvc: Make hvc_remove() return no value") from the tty

Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-26 Thread Linus Torvalds
On Sun, 26 Nov 2023 at 12:23, Linus Torvalds wrote: > > IOW, I might have messed up some "trivial cleanup" when prepping for > sending it out... Bah. Famous last words. One of the "trivial cleanups" made the code more "obvious" by renaming the nospec mask as just "mask". And that trivial rename

Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-26 Thread Linus Torvalds
On Sun, 19 Nov 2023 at 23:11, kernel test robot wrote: > > kernel test robot noticed a -2.9% regression of will-it-scale.per_thread_ops > on: > > commit: 0ede61d8589cc2d93aa78230d74ac58b5b8d0244 ("file: convert to > SLAB_TYPESAFE_BY_RCU") Ok, so __fget_light() is one of our more

Re: [PATCH v2 03/10] i2c: pasemi: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON

2023-11-26 Thread Andi Shyti
Hi Heiner, On Fri, Nov 24, 2023 at 11:16:12AM +0100, Heiner Kallweit wrote: > After removal of the legacy eeprom driver the only remaining I2C > client device driver supporting I2C_CLASS_SPD is jc42. Because this > driver also supports I2C_CLASS_HWMON, adapters don't have to > declare support for

Re: [PATCH v2 4/7] kexec_file, arm64: print out debugging message if required

2023-11-26 Thread Baoquan He
[PATCH v2 4/7] kexec_file, arm64: print out debugging message > if required > config: arm64-randconfig-001-20231126 > (https://download.01.org/0day-ci/archive/20231126/202311260548.1haxcdne-...@intel.com/config) > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git &g

[PATCH] powerpc/powernv: Fix null pointer dereference in opal_powercap_init

2023-11-26 Thread Kunwu Chan
kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Fixes: b9ef7b4b867f ("powerpc: Convert to using %pOFn instead of device_node.name") Signed-off-by: Kunwu Chan --- arch/powerpc/platforms/powernv/opal-powercap.c | 6 ++ 1 file changed, 6

[PATCH] powerpc/imc-pmu: Fix null pointer dereference in update_events_in_group

2023-11-26 Thread Kunwu Chan
kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Fixes: 885dcd709ba9 ("powerpc/perf: Add nest IMC PMU support") Signed-off-by: Kunwu Chan --- arch/powerpc/perf/imc-pmu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git