Re: [PATCH v3 12/12] mm/gup: Handle hugetlb in the generic follow_page_mask code

2024-03-22 Thread Peter Xu
On Fri, Mar 22, 2024 at 08:45:59PM -0400, Peter Xu wrote: > On Fri, Mar 22, 2024 at 01:48:18PM -0700, Andrew Morton wrote: > > On Thu, 21 Mar 2024 18:08:02 -0400 pet...@redhat.com wrote: > > > > > From: Peter Xu > > > > > > Now follow_page() is ready to handle hugetlb pages in whatever form,

Re: [PATCH v3 03/12] mm: Make HPAGE_PXD_* macros even if !THP

2024-03-22 Thread SeongJae Park
Hi Peter, On Fri, 22 Mar 2024 20:30:24 -0400 Peter Xu wrote: > On Fri, Mar 22, 2024 at 10:14:56AM -0700, SeongJae Park wrote: > > Hi Peter, > > Hi, SeongJae, > > > > > On Thu, 21 Mar 2024 18:07:53 -0400 pet...@redhat.com wrote: > > > > > From: Peter Xu > > > > > > These macros can be

[GIT PULL] Please pull powerpc/linux.git powerpc-6.9-2 tag

2024-03-22 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc updates for 6.9. These were posted before the merge window but had complicated dependencies and/or conflicts with other content that has gone into 6.9. cheers The following changes since commit

Re: [PATCH linux-next v2 0/3] powerpc/kexec: split CONFIG_CRASH_DUMP out from CONFIG_KEXEC_CORE

2024-03-22 Thread Michael Ellerman
On Mon, 26 Feb 2024 16:00:07 +0530, Hari Bathini wrote: > This patch series is a follow-up to [1] based on discussions at [2] > about additional work needed to get it working on powerpc. > > The first patch in the series makes struct crash_mem available with or > without CONFIG_CRASH_DUMP

Re: [PATCH v2] powerpc: Handle error in mark_rodata_ro() and mark_initmem_nx()

2024-03-22 Thread Michael Ellerman
On Sat, 16 Mar 2024 12:18:21 +0100, Christophe Leroy wrote: > mark_rodata_ro() and mark_initmem_nx() use functions that can > fail like set_memory_nx() and set_memory_ro(), leading to a not > protected kernel. > > In case of failure, panic. > > > [...] Applied to powerpc/next. [1/1] powerpc:

Re: [PATCH v3 12/12] mm/gup: Handle hugetlb in the generic follow_page_mask code

2024-03-22 Thread Peter Xu
On Fri, Mar 22, 2024 at 01:48:18PM -0700, Andrew Morton wrote: > On Thu, 21 Mar 2024 18:08:02 -0400 pet...@redhat.com wrote: > > > From: Peter Xu > > > > Now follow_page() is ready to handle hugetlb pages in whatever form, and > > over all architectures. Switch to the generic code path. > > >

Re: [PATCH v3 03/12] mm: Make HPAGE_PXD_* macros even if !THP

2024-03-22 Thread Peter Xu
On Fri, Mar 22, 2024 at 10:14:56AM -0700, SeongJae Park wrote: > Hi Peter, Hi, SeongJae, > > On Thu, 21 Mar 2024 18:07:53 -0400 pet...@redhat.com wrote: > > > From: Peter Xu > > > > These macros can be helpful when we plan to merge hugetlb code into generic > > code. Move them out and

Re: Cannot load wireguard module

2024-03-22 Thread Michael Ellerman
Herbert Xu writes: > On Wed, Mar 20, 2024 at 11:41:32PM +1100, Michael Ellerman wrote: >> >> This diff fixes it for me: > > Yes I think this is the correct fix. Thanks, I'll send a proper patch next week. cheers

Re: [PATCH v3 12/12] mm/gup: Handle hugetlb in the generic follow_page_mask code

2024-03-22 Thread Andrew Morton
On Thu, 21 Mar 2024 18:08:02 -0400 pet...@redhat.com wrote: > From: Peter Xu > > Now follow_page() is ready to handle hugetlb pages in whatever form, and > over all architectures. Switch to the generic code path. > > Time to retire hugetlb_follow_page_mask(), following the previous >

Re: [PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage

2024-03-22 Thread Arnd Bergmann
On Fri, Mar 22, 2024, at 09:34, Geoff Levand wrote: > On 3/21/24 17:32, Geert Uytterhoeven wrote: >> --- a/arch/powerpc/platforms/ps3/device-init.c >>> +++ b/arch/powerpc/platforms/ps3/device-init.c >>> @@ -770,7 +770,7 @@ static struct task_struct *probe_task; >>> >>> static int

Re: [PATCH 3/4] PCI: Add TLP Prefix reading into pcie_read_tlp_log()

2024-03-22 Thread Bjorn Helgaas
On Tue, Feb 06, 2024 at 03:57:16PM +0200, Ilpo Järvinen wrote: > pcie_read_tlp_log() handles only 4 TLP Header Log DWORDs but TLP Prefix > Log (PCIe r6.1 secs 7.8.4.12 & 7.9.14.13) may also be present. s/TLP Header Log/Header Log/ to match spec terminology (also below) > Generalize

[PATCH v3 5/5] dt-bindings: hwmon: ibm,p8-occ-hwmon: move to trivial devices

2024-03-22 Thread Javier Carrasco
This binding meets the requirements to be converted to dtschema via trivial-devices.yaml. Reviewed-by: Rob Herring Signed-off-by: Javier Carrasco --- .../devicetree/bindings/hwmon/ibm,p8-occ-hwmon.txt | 25 -- .../devicetree/bindings/trivial-devices.yaml | 2 ++ 2

[PATCH v3 4/5] dt-bindings: hwmon: stts751: convert to dtschema

2024-03-22 Thread Javier Carrasco
Convert existing binding to support validation. This is a straightforward conversion with no new properties. Reviewed-by: Conor Dooley Signed-off-by: Javier Carrasco --- .../devicetree/bindings/hwmon/st,stts751.yaml | 41 ++ .../devicetree/bindings/hwmon/stts751.txt

[PATCH v3 1/5] dt-bindings: hwmon: as370: convert to dtschema

2024-03-22 Thread Javier Carrasco
Convert existing binding to support validation. This is a straightforward conversion with now new properties. Reviewed-by: Rob Herring Signed-off-by: Javier Carrasco --- Documentation/devicetree/bindings/hwmon/as370.txt | 11 .../devicetree/bindings/hwmon/syna,as370.yaml | 32

[PATCH v3 0/5] dt-bindings: hwmon: convert multiple devices to dtschema

2024-03-22 Thread Javier Carrasco
, and it is not mentioned anywhere in the tree. I could not find the rationale, but its current state does not seem to provide any valuable information. Signed-off-by: Javier Carrasco --- Changes in v3: - Rename ibmpowernv to ibm,opal-sensor to match compatibles. - Link to v2: https://lore.kernel.org/r/20240322

[PATCH v3 2/5] dt-bindings: hwmon: ibmpowernv: convert to dtschema

2024-03-22 Thread Javier Carrasco
Convert existing binding to support validation. The binding has been renamed to match its compatible strings, with no further additions. Reviewed-by: Conor Dooley Signed-off-by: Javier Carrasco --- .../devicetree/bindings/hwmon/ibm,opal-sensor.yaml | 37 ++

[PATCH v3 3/5] dt-bindings: hwmon: pwm-fan: drop text file

2024-03-22 Thread Javier Carrasco
This binding was converted to dtschema a year ago. Acked-by: Rob Herring Signed-off-by: Javier Carrasco --- Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt

Re: [PATCH v2 4/5] dt-bindings: hwmon: stts751: convert to dtschema

2024-03-22 Thread Conor Dooley
On Fri, Mar 22, 2024 at 07:45:29AM +0100, Javier Carrasco wrote: > Convert existing binding to support validation. > > This is a straightforward conversion with no new properties. > Reviewed-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH v2 2/5] dt-bindings: hwmon: ibmpowernv: convert to dtschema

2024-03-22 Thread Conor Dooley
On Fri, Mar 22, 2024 at 07:45:27AM +0100, Javier Carrasco wrote: > Convert existing binding to support validation. > > This is a straightforward conversion with now new properties. > > Signed-off-by: Javier Carrasco > --- > .../devicetree/bindings/hwmon/ibm,powernv.yaml | 37 >

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Wolfram Sang
> Kind of odd though to change function names but not parameter names of > those very same functions. Ouch, this is definitely a valid point. Seems like this series will need a respin after all. Will wait for further comments, though. Thanks! signature.asc Description: PGP signature

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Nicolas Ferre
On 22/03/2024 at 14:25, Wolfram Sang wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Match the wording in i2c_algorithm in I2C drivers wrt. the newest I2C v7, SMBus 3.2, I3C specifications and replace "master/slave" with more appropriate terms.

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Guenter Roeck
On Fri, Mar 22, 2024 at 9:47 AM Wolfram Sang wrote: > > > > Acked-by: Nicolas Ferre # for at91 > > Probably file names themselves will need some care, in a second time. > > Totally true. I am aware of that. But one step after the other... > Kind of odd though to change function names but not

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Wolfram Sang
> Acked-by: Nicolas Ferre # for at91 > Probably file names themselves will need some care, in a second time. Totally true. I am aware of that. But one step after the other... signature.asc Description: PGP signature

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Bjorn Andersson
On Fri, Mar 22, 2024 at 02:25:57PM +0100, Wolfram Sang wrote: > Match the wording in i2c_algorithm in I2C drivers wrt. the newest I2C > v7, SMBus 3.2, I3C specifications and replace "master/slave" with more > appropriate terms. For some drivers, this means no more conversions are > needed. For the

[PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Wolfram Sang
Match the wording in i2c_algorithm in I2C drivers wrt. the newest I2C v7, SMBus 3.2, I3C specifications and replace "master/slave" with more appropriate terms. For some drivers, this means no more conversions are needed. For the others more work needs to be done but this will be performed

Re: [PATCH v3 03/12] mm: Make HPAGE_PXD_* macros even if !THP

2024-03-22 Thread SeongJae Park
Hi Peter, On Thu, 21 Mar 2024 18:07:53 -0400 pet...@redhat.com wrote: > From: Peter Xu > > These macros can be helpful when we plan to merge hugetlb code into generic > code. Move them out and define them even if !THP. > > We actually already defined HPAGE_PMD_NR for other reasons even if

Re: [RFC] sched/eevdf: sched feature to dismiss lag on wakeup

2024-03-22 Thread Vincent Guittot
On Thu, 21 Mar 2024 at 13:18, Tobias Huschle wrote: > > On Wed, Mar 20, 2024 at 02:51:00PM +0100, Vincent Guittot wrote: > > On Wed, 20 Mar 2024 at 08:04, Tobias Huschle wrote: > > > There was no guarantee of course. place_entity was reducing the vruntime > > > of > > > woken up tasks though,

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Andy Shevchenko
On Fri, Mar 22, 2024 at 05:48:54PM +0100, Wolfram Sang wrote: > > > > static const struct i2c_algorithm at91_twi_algorithm = { > > > - .master_xfer= at91_twi_xfer, > > > + .xfer = at91_twi_xfer, > > > > Seems you made this by a script, can you check the indentations afterwards? > > Yes,

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Wolfram Sang
> > static const struct i2c_algorithm at91_twi_algorithm = { > > - .master_xfer= at91_twi_xfer, > > + .xfer = at91_twi_xfer, > > Seems you made this by a script, can you check the indentations afterwards? Yes, I noticed as well. But other (not converted) drivers have issues there as

Re: [PATCH v3 00/12] mm/gup: Unify hugetlb, part 2

2024-03-22 Thread Jason Gunthorpe
On Thu, Mar 21, 2024 at 06:07:50PM -0400, pet...@redhat.com wrote: > From: Peter Xu > > v3: > - Rebased to latest mm-unstalbe (a824831a082f, of March 21th) > - Dropped patch to introduce pmd_thp_or_huge(), replace such uses (and also > pXd_huge() users) with pXd_leaf() [Jason] > - Add a

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Andy Shevchenko
On Fri, Mar 22, 2024 at 02:25:57PM +0100, Wolfram Sang wrote: > Match the wording in i2c_algorithm in I2C drivers wrt. the newest I2C > v7, SMBus 3.2, I3C specifications and replace "master/slave" with more > appropriate terms. For some drivers, this means no more conversions are > needed. For the

Re: [PATCH v3 12/12] mm/gup: Handle hugetlb in the generic follow_page_mask code

2024-03-22 Thread Jason Gunthorpe
On Fri, Mar 22, 2024 at 11:55:11AM -0400, Peter Xu wrote: > Jason, > > On Fri, Mar 22, 2024 at 10:30:12AM -0300, Jason Gunthorpe wrote: > > On Thu, Mar 21, 2024 at 06:08:02PM -0400, pet...@redhat.com wrote: > > > > > A quick performance test on an aarch64 VM on M1 chip shows 15% degrade > > >

Re: [PATCH v3 12/12] mm/gup: Handle hugetlb in the generic follow_page_mask code

2024-03-22 Thread Peter Xu
Jason, On Fri, Mar 22, 2024 at 10:30:12AM -0300, Jason Gunthorpe wrote: > On Thu, Mar 21, 2024 at 06:08:02PM -0400, pet...@redhat.com wrote: > > > A quick performance test on an aarch64 VM on M1 chip shows 15% degrade over > > a tight loop of slow gup after the path switched. That shouldn't be

Re: [PATCH 0/4] PCI: Consolidate TLP Log reading and printing

2024-03-22 Thread Ilpo Järvinen
On Mon, 11 Mar 2024, Ilpo Järvinen wrote: > On Fri, 8 Mar 2024, Bjorn Helgaas wrote: > > > On Tue, Feb 06, 2024 at 03:57:13PM +0200, Ilpo Järvinen wrote: > > > This series consolidates AER & DPC TLP Log handling code. Helpers are > > > added for reading and printing the TLP Log and the format is

[PATCH 42/64] i2c: powermac: reword according to newest specification

2024-03-22 Thread Wolfram Sang
Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C specifications and replace "master/slave" with more appropriate terms. They are also more specific because we distinguish now between a remote entity ("client") and a local one ("target"). Signed-off-by: Wolfram Sang ---

[PATCH 14/64] i2c: cpm: reword according to newest specification

2024-03-22 Thread Wolfram Sang
Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C specifications and replace "master/slave" with more appropriate terms. They are also more specific because we distinguish now between a remote entity ("client") and a local one ("target"). Signed-off-by: Wolfram Sang ---

[PATCH 00/64] i2c: reword i2c_algorithm according to newest specification

2024-03-22 Thread Wolfram Sang
Okay, we need to begin somewhere... Start changing the wording of the I2C main header wrt. the newest I2C v7, SMBus 3.2, I3C specifications and replace "master/slave" with more appropriate terms. This first step renames the members of struct i2c_algorithm. Once all in-tree users are converted,

Re: [PATCH v3 12/12] mm/gup: Handle hugetlb in the generic follow_page_mask code

2024-03-22 Thread Jason Gunthorpe
On Thu, Mar 21, 2024 at 06:08:02PM -0400, pet...@redhat.com wrote: > A quick performance test on an aarch64 VM on M1 chip shows 15% degrade over > a tight loop of slow gup after the path switched. That shouldn't be a > problem because slow-gup should not be a hot path for GUP in general: when >

Re: [PATCH v3 05/12] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing

2024-03-22 Thread Jason Gunthorpe
On Thu, Mar 21, 2024 at 06:07:55PM -0400, pet...@redhat.com wrote: > From: Peter Xu > > Hugepd format for GUP is only used in PowerPC with hugetlbfs. There are > some kernel usage of hugepd (can refer to hugepd_populate_kernel() for > PPC_8XX), however those pages are not candidates for GUP. >

Re: [PATCH v3 04/12] mm: Introduce vma_pgtable_walk_{begin|end}()

2024-03-22 Thread Jason Gunthorpe
On Thu, Mar 21, 2024 at 06:07:54PM -0400, pet...@redhat.com wrote: > From: Peter Xu > > Introduce per-vma begin()/end() helpers for pgtable walks. This is a > preparation work to merge hugetlb pgtable walkers with generic mm. > > The helpers need to be called before and after a pgtable walk,

Re: [PATCH v10 8/8] PCI: dwc: ep: Remove "core_init_notifier" flag

2024-03-22 Thread Niklas Cassel
On Thu, Mar 14, 2024 at 01:18:06PM +0530, Manivannan Sadhasivam wrote: > "core_init_notifier" flag is set by the glue drivers requiring refclk from > the host to complete the DWC core initialization. Also, those drivers will > send a notification to the EPF drivers once the initialization is fully

Re: Cannot load wireguard module

2024-03-22 Thread Herbert Xu
On Wed, Mar 20, 2024 at 11:41:32PM +1100, Michael Ellerman wrote: > > This diff fixes it for me: Yes I think this is the correct fix. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v10 7/8] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers

2024-03-22 Thread Niklas Cassel
On Thu, Mar 14, 2024 at 01:18:05PM +0530, Manivannan Sadhasivam wrote: > Currently, dw_pcie_ep_init_registers() API is directly called by the glue > drivers requiring active refclk from host. But for the other drivers, it is > getting called implicitly by dw_pcie_ep_init(). This is due to the fact

Re: [PATCH v10 2/8] PCI: dwc: ep: Add Kernel-doc comments for APIs

2024-03-22 Thread Niklas Cassel
On Thu, Mar 14, 2024 at 01:18:00PM +0530, Manivannan Sadhasivam wrote: > All of the APIs are missing the Kernel-doc comments. Hence, add them. > > Reviewed-by: Frank Li > Signed-off-by: Manivannan Sadhasivam > --- > drivers/pci/controller/dwc/pcie-designware-ep.c | 78 >

[PATCH] Documentation: embargoed-hardware-issues.rst: Add myself for Power

2024-03-22 Thread Michael Ellerman
Unfortunately Anton has left IBM. Add myself as the contact for Power, until someone else volunteers. Signed-off-by: Michael Ellerman --- Documentation/process/embargoed-hardware-issues.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3] arch/powerpc/kvm: Add support for reading VPA counters for pseries guests

2024-03-22 Thread Gautam Menghani
PAPR hypervisor has introduced three new counters in the VPA area of LPAR CPUs for KVM L2 guest (see [1] for terminology) observability - 2 for context switches from host to guest and vice versa, and 1 counter for getting the total time spent inside the KVM guest. Add a tracepoint that enables

Re: [PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage

2024-03-22 Thread Geoff Levand
On 3/21/24 17:32, Geert Uytterhoeven wrote: > --- a/arch/powerpc/platforms/ps3/device-init.c >> +++ b/arch/powerpc/platforms/ps3/device-init.c >> @@ -770,7 +770,7 @@ static struct task_struct *probe_task; >> >> static int ps3_probe_thread(void *data) >> { >> - struct

[PATCH v2 5/5] dt-bindings: hwmon: ibm,p8-occ-hwmon: move to trivial devices

2024-03-22 Thread Javier Carrasco
This binding meets the requirements to be converted to dtschema via trivial-devices.yaml. Reviewed-by: Rob Herring Signed-off-by: Javier Carrasco --- .../devicetree/bindings/hwmon/ibm,p8-occ-hwmon.txt | 25 -- .../devicetree/bindings/trivial-devices.yaml | 2 ++ 2

[PATCH v2 4/5] dt-bindings: hwmon: stts751: convert to dtschema

2024-03-22 Thread Javier Carrasco
Convert existing binding to support validation. This is a straightforward conversion with no new properties. Signed-off-by: Javier Carrasco --- .../devicetree/bindings/hwmon/st,stts751.yaml | 41 ++ .../devicetree/bindings/hwmon/stts751.txt | 15 2

[PATCH v2 3/5] dt-bindings: hwmon: pwm-fan: drop text file

2024-03-22 Thread Javier Carrasco
This binding was converted to dtschema a year ago. Acked-by: Rob Herring Signed-off-by: Javier Carrasco --- Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt

[PATCH v2 2/5] dt-bindings: hwmon: ibmpowernv: convert to dtschema

2024-03-22 Thread Javier Carrasco
Convert existing binding to support validation. This is a straightforward conversion with now new properties. Signed-off-by: Javier Carrasco --- .../devicetree/bindings/hwmon/ibm,powernv.yaml | 37 ++ .../devicetree/bindings/hwmon/ibmpowernv.txt | 23

[PATCH v2 0/5] dt-bindings: hwmon: convert multiple devices to dtschema

2024-03-22 Thread Javier Carrasco
This series converts the following existing bindings to dtschema: - as370 - ibmpowernv - stts751 - ibm,p8-occ-hwmon (moved to trivial-devices.yaml) Additionally, pwm-fan.txt has been dropped because it was converted a year ago, and it is not mentioned anywhere in the tree. I could not find the

[PATCH v2 1/5] dt-bindings: hwmon: as370: convert to dtschema

2024-03-22 Thread Javier Carrasco
Convert existing binding to support validation. This is a straightforward conversion with now new properties. Reviewed-by: Rob Herring Signed-off-by: Javier Carrasco --- Documentation/devicetree/bindings/hwmon/as370.txt | 11 .../devicetree/bindings/hwmon/syna,as370.yaml | 32