Re: [PATCH v6] arch/powerpc/kvm: Add support for reading VPA counters for pseries guests

2024-05-06 Thread Naveen N Rao
On Mon, May 06, 2024 at 08:26:03PM GMT, Gautam Menghani wrote: > PAPR hypervisor has introduced three new counters in the VPA area of > LPAR CPUs for KVM L2 guest (see [1] for terminology) observability - 2 > for context switches from host to guest and vice versa, and 1 counter > for getting the to

[powerpc:next] BUILD SUCCESS be140f1732b523947425aaafbe2e37b41b622d96

2024-05-06 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next branch HEAD: be140f1732b523947425aaafbe2e37b41b622d96 powerpc/64: Set _IO_BASE to POISON_POINTER_DELTA not 0 for CONFIG_PCI=n elapsed time: 923m configs tested: 181 configs skipped: 4 The following configs hav

Re: [PATCH V2 4/9] tools/perf: Add support to capture and parse raw instruction in objdump

2024-05-06 Thread Namhyung Kim
On Mon, May 6, 2024 at 5:21 AM Athira Rajeev wrote: > > Add support to capture and parse raw instruction in objdump. > Currently, the perf tool infrastructure uses "--no-show-raw-insn" option > with "objdump" while disassemble. Example from powerpc with this option > for an instruction address is:

Re: [PATCH V2 3/9] tools/perf: Fix a comment about multi_regs in extract_reg_offset function

2024-05-06 Thread Namhyung Kim
On Mon, May 6, 2024 at 5:19 AM Athira Rajeev wrote: > > Fix a comment in function which explains how multi_regs field gets set > for an instruction. In the example, "mov %rsi, 8(%rbx,%rcx,4)", the > comment mistakenly referred to "dst_multi_regs = 0". Correct it to use > "src_multi_regs = 0" > >

Re: [PATCH V2 0/9] Add data type profiling support for powerpc

2024-05-06 Thread Namhyung Kim
Hello, On Mon, May 6, 2024 at 5:19 AM Athira Rajeev wrote: > > The patchset from Namhyung added support for data type profiling > in perf tool. This enabled support to associate PMU samples to data > types they refer using DWARF debug information. With the upstream > perf, currently it possible t

Re: [kvm-unit-tests PATCH v9 03/31] powerpc: Mark known failing tests as kfail

2024-05-06 Thread Nicholas Piggin
On Mon May 6, 2024 at 5:37 PM AEST, Thomas Huth wrote: > On 04/05/2024 14.28, Nicholas Piggin wrote: > > Mark the failing h_cede_tm and spapr_vpa tests as kfail. > > > > Signed-off-by: Nicholas Piggin > > --- > > powerpc/spapr_vpa.c | 3 ++- > > powerpc/tm.c| 3 ++- > > 2 files change

[powerpc:merge] BUILD SUCCESS bbd9f1ec54a72b7a68ed18ad2281f453ee06d606

2024-05-06 Thread kernel test robot
i386 allmodconfig gcc i386 allnoconfig gcc i386 allyesconfig gcc i386 buildonly-randconfig-001-20240506 gcc i386 buildonly-randconfig-001-20240507 clang i386 buildonly-randconfig-002-20240506 clang

Re: [kvm-unit-tests PATCH v9 01/31] doc: update unittests doc

2024-05-06 Thread Nicholas Piggin
On Mon May 6, 2024 at 5:03 PM AEST, Thomas Huth wrote: > On 04/05/2024 14.28, Nicholas Piggin wrote: > > This adds a few minor fixes. > > > > Signed-off-by: Nicholas Piggin > > --- > > docs/unittests.txt | 12 +++- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > > diff --git

Re: linux-next: manual merge of the risc-v tree with the powerpc tree

2024-05-06 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > Today's linux-next merge of the risc-v tree got conflicts in: > > include/uapi/linux/prctl.h > kernel/sys.c > > between commit: > > 628d701f2de5 ("powerpc/dexcr: Add DEXCR prctl interface") > > from the powerpc tree and commit: > > 6b9391b581fd ("risc

Re: WARNING: CPU: 1 PID: 1 at net/core/netpoll.c:370 netpoll_send_skb+0x1fc/0x20c at boot when netconsole is enabled (kernel v6.9-rc5, v6.8.7, sungem, PowerMac G4 DP)

2024-05-06 Thread Jakub Kicinski
On Tue, 7 May 2024 02:42:58 +0200 Erhard Furtner wrote: > And indeed without gem_poll_controller() I don't hit the "WARNING: CPU: 1 > PID: 1 at net/core/netpoll.c:370 netpoll_send_skb+0x1fc/0x20c" and "WARNING: > CPU: 1 PID: 1 at kernel/locking/irqflag-debug.c:10 > warn_bogus_irq_restore+0x30/0x

Re: WARNING: CPU: 1 PID: 1 at net/core/netpoll.c:370 netpoll_send_skb+0x1fc/0x20c at boot when netconsole is enabled (kernel v6.9-rc5, v6.8.7, sungem, PowerMac G4 DP)

2024-05-06 Thread Erhard Furtner
On Mon, 6 May 2024 07:26:45 -0700 Jakub Kicinski wrote: > On Sun, 5 May 2024 23:27:13 +0200 Erhard Furtner wrote: > > > On Sun, 28 Apr 2024 12:53:06 +0200 Erhard Furtner wrote: > > > > With netconsole enabled I get this "WARNING: CPU: 1 PID: 1 at > > > > net/core/netpoll.c:370 netpoll_send_sk

linux-next: manual merge of the risc-v tree with the powerpc tree

2024-05-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the risc-v tree got conflicts in: include/uapi/linux/prctl.h kernel/sys.c between commit: 628d701f2de5 ("powerpc/dexcr: Add DEXCR prctl interface") from the powerpc tree and commit: 6b9391b581fd ("riscv: Include riscv_set_icache_flush_ctx prctl") f

Re: [PATCH v3] kprobe/ftrace: bail out if ftrace was killed

2024-05-06 Thread Steven Rostedt
On Mon, 6 May 2024 14:46:57 + Christophe Leroy wrote: > Isn't it safer to provide a fonction rather than a direct access to a > variable ? > > By the way, wouldn't it be more performant to use a static branch (jump > label) ? A static branch could work, but the point of this is that if ft

Re: [PATCH 0/7] Remove 40x

2024-05-06 Thread Rob Herring (Arm)
On Mon, 06 May 2024 22:51:45 +1000, Michael Ellerman wrote: > The 40x platforms & CPUs are old and have been unmaintained for years, and as > far as we can tell have no users. > > Note 44x and 476 are not affected. > > Christophe first proposed removing 40x in 2020: > > https://lore.kernel.o

Re: [PATCH v8 13/17] x86/ftrace: enable dynamic ftrace without CONFIG_MODULES

2024-05-06 Thread Steven Rostedt
On Sun, 5 May 2024 17:25:56 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Dynamic ftrace must allocate memory for code and this was impossible > without CONFIG_MODULES. > > With execmem separated from the modules code, execmem_text_alloc() is > available regardless of CONFIG_MO

Re: [PATCH v8 06/17] mm: introduce execmem_alloc() and execmem_free()

2024-05-06 Thread Steven Rostedt
On Sun, 5 May 2024 17:25:49 +0300 Mike Rapoport wrote: > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c > index 70139d9d2e01..c8ddb7abda7c 100644 > --- a/arch/x86/kernel/ftrace.c > +++ b/arch/x86/kernel/ftrace.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#inc

Re: [RFC PATCH v2 0/6] powerpc: pSeries: vfio: iommu: Re-enable support for SPAPR TCE VFIO

2024-05-06 Thread Jason Gunthorpe
On Sat, May 04, 2024 at 12:33:53AM +0530, Shivaprasad G Bhat wrote: > We have legacy workloads using VFIO in userspace/kvm guests running > on downstream distro kernels. We want these workloads to be able to > continue running on our arch. It has been broken since 2018, I don't find this reasoning

Re: [RFC PATCH 1/2] objtool: Run objtool only if either of the config options are selected

2024-05-06 Thread Masahiro Yamada
On Tue, Apr 23, 2024 at 1:19 AM Sathvika Vasireddy wrote: > > Hi Masahiro, thanks for reviewing. > > On 4/22/24 5:39 PM, Masahiro Yamada wrote: > > On Mon, Apr 22, 2024 at 6:25 PM Sathvika Vasireddy wrote: > > Currently, when objtool is enabled and none of the supported options > are triggered, k

Re: [RFC PATCH 2/2] objtool/powerpc: Enhance objtool to fixup alternate feature relative addresses

2024-05-06 Thread Masahiro Yamada
On Mon, Apr 22, 2024 at 6:25 PM Sathvika Vasireddy wrote: > > Implement build-time fixup of alternate feature relative addresses for > the out-of-line (else) patch code. Initial posting to achieve the same > using another tool can be found at [1]. Idea is to implement this using > objtool instead

[PATCH 3/3] arch/powerpc/kvm: Reduce lock contention by moving spinlock from ics to irq_state

2024-05-06 Thread Gautam Menghani
Take a spinlock on state of an IRQ instead of an entire ICS. This improves scalability by reducing contention. Signed-off-by: Gautam Menghani --- arch/powerpc/kvm/book3s_hv_rm_xics.c | 8 ++--- arch/powerpc/kvm/book3s_xics.c | 44 arch/powerpc/kvm/book3s_xics.

[PATCH 2/3] arch/powerpc/kvm: Optimize the server number -> ICP lookup

2024-05-06 Thread Gautam Menghani
Given a server number, kvmppc_xics_find_server() does a linear search over the vcpus of a VM. Optimize this logic by using an array to maintain the mapping between server number -> icp. Signed-off-by: Gautam Menghani --- arch/powerpc/kvm/book3s_xics.c | 4 ++-- arch/powerpc/kvm/book3s_xics.h |

[PATCH 1/3] arch/powerpc/kvm: Use bitmap to speed up resend of irqs in ICS

2024-05-06 Thread Gautam Menghani
When an irq is to be resent, all 1024 irqs in an ICS are scanned and the irqs having 'resend' flag set are resent. Optimize this flow using bitmap array to speed up the resends. Signed-off-by: Gautam Menghani --- arch/powerpc/kvm/book3s_xics.c | 22 +++--- arch/powerpc/kvm/book3s

[PATCH 0/3] XICS emulation optimizations in KVM for PPC

2024-05-06 Thread Gautam Menghani
Optimize the XICS emulation code in KVM as per the 'performance todos' in the comments of book3s_xics.c. Performance numbers: 1. Test case: Pgbench run in a KVM on PowerVM guest for 120 secs 2. Time taken by arch_send_call_function_single_ipi() currently measured with funclatency [1]. $ ./fun

[PATCH v6] arch/powerpc/kvm: Add support for reading VPA counters for pseries guests

2024-05-06 Thread Gautam Menghani
PAPR hypervisor has introduced three new counters in the VPA area of LPAR CPUs for KVM L2 guest (see [1] for terminology) observability - 2 for context switches from host to guest and vice versa, and 1 counter for getting the total time spent inside the KVM guest. Add a tracepoint that enables read

Re: [PATCH v3] kprobe/ftrace: bail out if ftrace was killed

2024-05-06 Thread Christophe Leroy
Le 01/05/2024 à 18:29, Stephen Brennan a écrit : > If an error happens in ftrace, ftrace_kill() will prevent disarming > kprobes. Eventually, the ftrace_ops associated with the kprobes will be > freed, yet the kprobes will still be active, and when triggered, they > will use the freed memory, lik

Re: [PATCH v3 1/2] PCI: Add TLP Prefix reading into pcie_read_tlp_log()

2024-05-06 Thread Ilpo Järvinen
On Fri, 3 May 2024, Bjorn Helgaas wrote: > On Fri, Apr 12, 2024 at 04:36:34PM +0300, Ilpo Järvinen wrote: > > pcie_read_tlp_log() handles only 4 TLP Header Log DWORDs but TLP Prefix > > Log (PCIe r6.1 secs 7.8.4.12 & 7.9.14.13) may also be present. > > > > Generalize pcie_read_tlp_log() and struc

Re: WARNING: CPU: 1 PID: 1 at net/core/netpoll.c:370 netpoll_send_skb+0x1fc/0x20c at boot when netconsole is enabled (kernel v6.9-rc5, v6.8.7, sungem, PowerMac G4 DP)

2024-05-06 Thread Jakub Kicinski
On Sun, 5 May 2024 23:27:13 +0200 Erhard Furtner wrote: > > On Sun, 28 Apr 2024 12:53:06 +0200 Erhard Furtner wrote: > > > With netconsole enabled I get this "WARNING: CPU: 1 PID: 1 at > > > net/core/netpoll.c:370 netpoll_send_skb+0x1fc/0x20c" and "WARNING: > > > CPU: 1 PID: 1 at kernel/locking/i

[PATCH 7/7] powerpc/platforms: Move files from 4xx to 44x

2024-05-06 Thread Michael Ellerman
From: Christophe Leroy Only 44x uses 4xx now, so only keep one directory. Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/44x/Makefile | 6 - arch/powerpc/platforms/{4xx => 44x}/cpm.c | 0 arch/powerpc/platforms/{4xx => 44x}/gpio.

[PATCH 6/7] powerpc: Replace CONFIG_4xx with CONFIG_44x

2024-05-06 Thread Michael Ellerman
Replace 4xx usage with 44x, and replace 4xx_SOC with 44x. Signed-off-by: Michael Ellerman --- arch/powerpc/Kconfig | 5 + arch/powerpc/include/asm/cacheflush.h | 2 +- arch/powerpc/include/asm/ppc_asm.h | 2 +- arch/powerpc/kernel/entry_32.S | 6 +++--- arch/po

[PATCH 5/7] powerpc/4xx: Remove CONFIG_BOOKE_OR_40x

2024-05-06 Thread Michael Ellerman
Now that 40x is gone, replace CONFIG_BOOKE_OR_40x by CONFIG_BOOKE. Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/hw_irq.h | 8 arch/powerpc/include/asm/irq.h | 2 +- arch/powerpc/include/asm/kup.h | 2 +- arch/powerpc/include/asm/processor.h | 2 +-

[PATCH 3/7] powerpc: Remove 40x from Kconfig and defconfig

2024-05-06 Thread Michael Ellerman
Remove 40x from Kconfig, making the code unreachable. Signed-off-by: Michael Ellerman --- arch/powerpc/Kconfig | 12 ++-- arch/powerpc/Kconfig.debug | 13 - arch/powerpc/Makefile | 5 - arch/powerpc/configs/40x.config

[PATCH 2/7] powerpc/boot: Remove all 40x platforms from boot

2024-05-06 Thread Michael Ellerman
From: Christophe Leroy Remove 40x platforms from the boot directory. Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman --- arch/powerpc/boot/4xx.c | 266 -- arch/powerpc/boot/4xx.h | 4 - arch/powerpc/boot/Makefile | 11 - arch

[PATCH 1/7] powerpc/40x: Remove 40x platforms.

2024-05-06 Thread Michael Ellerman
From: Christophe Leroy 40x platforms have been orphaned for many years. Remove them. Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman --- MAINTAINERS | 1 - arch/powerpc/configs/40x/acadia_defconfig | 61 arch/powerpc/configs

[PATCH 0/7] Remove 40x

2024-05-06 Thread Michael Ellerman
The 40x platforms & CPUs are old and have been unmaintained for years, and as far as we can tell have no users. Note 44x and 476 are not affected. Christophe first proposed removing 40x in 2020: https://lore.kernel.org/linuxppc-dev/40899eb1b8f10da3706acd06c3d46d2418c8886e.1585635837.git.christ

[PATCH V2 4/9] tools/perf: Add support to capture and parse raw instruction in objdump

2024-05-06 Thread Athira Rajeev
Add support to capture and parse raw instruction in objdump. Currently, the perf tool infrastructure uses "--no-show-raw-insn" option with "objdump" while disassemble. Example from powerpc with this option for an instruction address is: Snippet from: objdump --start-address= --stop-address= -d

[PATCH V2 9/9] tools/perf: Add support for global_die to capture name of variable in case of register defined variable

2024-05-06 Thread Athira Rajeev
In case of register defined variable (found using find_data_type_global_reg), if the type of variable happens to be base type (example, long unsigned int), perf report captures it as: 12.85% long unsigned int long unsigned int +0 (no field) The above data type is actually referring to sampl

[PATCH V2 8/9] tools/perf: Add support to find global register variables using find_data_type_global_reg

2024-05-06 Thread Athira Rajeev
There are cases where define a global register variable and associate it with a specified register. Example, in powerpc, two registers are defined to represent variable: 1. r13: represents local_paca register struct paca_struct *local_paca asm("r13"); 2. r1: represents stack_pointer register void

[PATCH V2 7/9] tools/perf: Update instruction tracking with add instruction

2024-05-06 Thread Athira Rajeev
Update instruction tracking with add instruction. Apart from "mr" instruction, the register state is carried on by other insns, ie, "add, addi, addis". Since these are not memory instructions and doesn't fall in the range of (32 to 63), add these as part of nmemonic table. For now, add* instruction

[PATCH V2 6/9] tools/perf: Update instruction tracking for powerpc

2024-05-06 Thread Athira Rajeev
Add instruction tracking function "update_insn_state_powerpc" for powerpc. Example sequence in powerpc: ld r10,264(r3) mr r31,r3 < ld r9,312(r31) Consider ithe sample is pointing to: "ld r9,312(r31)". Here the memory reference is hit at "312(r31)" where 312 is the offset and r31 is

[PATCH V2 5/9] tools/perf: Update parameters for reg extract functions to use raw instruction on powerpc

2024-05-06 Thread Athira Rajeev
Use the raw instruction code and macros to identify memory instructions, extract register fields and also offset. The implementation addresses the D-form, X-form, DS-form instructions. Two main functions are added. New parse function "load_store__parse" as instruction ops parser for memory instruct

[PATCH V2 2/9] tools/perf: Add "update_insn_state" callback function to handle arch specific instruction tracking

2024-05-06 Thread Athira Rajeev
Add "update_insn_state" callback to "struct arch" to handle instruction tracking. Currently updating instruction state is handled by static function "update_insn_state_x86" which is defined in "annotate-data.c". Make this as a callback for specific arch and move to archs specific file "arch/x86/ann

[PATCH V2 3/9] tools/perf: Fix a comment about multi_regs in extract_reg_offset function

2024-05-06 Thread Athira Rajeev
Fix a comment in function which explains how multi_regs field gets set for an instruction. In the example, "mov %rsi, 8(%rbx,%rcx,4)", the comment mistakenly referred to "dst_multi_regs = 0". Correct it to use "src_multi_regs = 0" Signed-off-by: Athira Rajeev --- tools/perf/util/annotate.c | 2

[PATCH V2 1/9] tools/perf: Move the data structures related to register type to header file

2024-05-06 Thread Athira Rajeev
Data type profiling uses instruction tracking by checking each instruction and updating the register type state in some data structures. This is useful to find the data type in cases when the register state gets transferred from one reg to another. Example, in x86, "mov" instruction and in powerpc,

[PATCH V2 0/9] Add data type profiling support for powerpc

2024-05-06 Thread Athira Rajeev
The patchset from Namhyung added support for data type profiling in perf tool. This enabled support to associate PMU samples to data types they refer using DWARF debug information. With the upstream perf, currently it possible to run perf report or perf annotate to view the data type information on

[PATCH] selftests/mm: Fix powerpc ARCH check

2024-05-06 Thread Michael Ellerman
In commit 0518dbe97fe6 ("selftests/mm: fix cross compilation with LLVM") the logic to detect the machine architecture in the Makefile was changed to use ARCH, and only fallback to uname -m if ARCH is unset. However the tests of ARCH were not updated to account for the fact that ARCH is "powerpc" fo

Re: [kvm-unit-tests PATCH v9 02/31] report: Add known failure reporting option

2024-05-06 Thread Thomas Huth
On 06/05/2024 10.01, Andrew Jones wrote: On Mon, May 06, 2024 at 09:25:37AM GMT, Thomas Huth wrote: On 04/05/2024 14.28, Nicholas Piggin wrote: There are times we would like to test a function that is known to fail in some conditions due to a bug in implementation (QEMU, KVM, or even hardware).

Re: [PATCH v15 00/16] Add audio support in v4l2 framework

2024-05-06 Thread Jaroslav Kysela
On 06. 05. 24 10:49, Shengjiu Wang wrote: Even now I still think V4L2 is the best option, but it looks like there are a lot of rejects. If develop a new ALSA-mem2mem, it is also a duplication of code (bigger duplication that just add audio support in V4L2 I think). Maybe not. Could you try to

Re: [PATCH v4 01/29] powerpc/mm: add ARCH_PKEY_BITS to Kconfig

2024-05-06 Thread Michael Ellerman
Joey Gouly writes: > The new config option specifies how many bits are in each PKEY. > > Signed-off-by: Joey Gouly > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Christophe Leroy > Cc: "Aneesh Kumar K.V" > Cc: "Naveen N. Rao" > Cc: linuxppc-dev@lists.ozlabs.org > --- > arch/powerpc/Kcon

Re: [PATCH v15 00/16] Add audio support in v4l2 framework

2024-05-06 Thread Shengjiu Wang
On Fri, May 3, 2024 at 4:42 PM Mauro Carvalho Chehab wrote: > > Em Fri, 3 May 2024 10:47:19 +0900 > Mark Brown escreveu: > > > On Thu, May 02, 2024 at 10:26:43AM +0100, Mauro Carvalho Chehab wrote: > > > Mauro Carvalho Chehab escreveu: > > > > > > There are still time control associated with it,

Re: [kvm-unit-tests PATCH v9 01/31] doc: update unittests doc

2024-05-06 Thread Andrew Jones
On Sat, May 04, 2024 at 10:28:07PM GMT, Nicholas Piggin wrote: > This adds a few minor fixes. > > Signed-off-by: Nicholas Piggin > --- > docs/unittests.txt | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/docs/unittests.txt b/docs/unittests.txt > index 3192a

Re: [kvm-unit-tests PATCH v9 02/31] report: Add known failure reporting option

2024-05-06 Thread Andrew Jones
On Mon, May 06, 2024 at 09:25:37AM GMT, Thomas Huth wrote: > On 04/05/2024 14.28, Nicholas Piggin wrote: > > There are times we would like to test a function that is known to fail > > in some conditions due to a bug in implementation (QEMU, KVM, or even > > hardware). It would be nice to count thes

Re: [kvm-unit-tests PATCH v9 03/31] powerpc: Mark known failing tests as kfail

2024-05-06 Thread Thomas Huth
On 04/05/2024 14.28, Nicholas Piggin wrote: Mark the failing h_cede_tm and spapr_vpa tests as kfail. Signed-off-by: Nicholas Piggin --- powerpc/spapr_vpa.c | 3 ++- powerpc/tm.c| 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/powerpc/spapr_vpa.c b/powerpc/spap

Re: [kvm-unit-tests PATCH v9 02/31] report: Add known failure reporting option

2024-05-06 Thread Thomas Huth
On 04/05/2024 14.28, Nicholas Piggin wrote: There are times we would like to test a function that is known to fail in some conditions due to a bug in implementation (QEMU, KVM, or even hardware). It would be nice to count these as known failures and not report a summary failure. xfail is not the

Re: [kvm-unit-tests PATCH v9 01/31] doc: update unittests doc

2024-05-06 Thread Thomas Huth
On 04/05/2024 14.28, Nicholas Piggin wrote: This adds a few minor fixes. Signed-off-by: Nicholas Piggin --- docs/unittests.txt | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/unittests.txt b/docs/unittests.txt index 3192a60ec..7cf2c55ad 100644 --- a/docs