Re: [PATCH AUTOSEL 6.9 18/23] powerpc: make fadump resilient with memory add/remove events

2024-06-18 Thread Michael Ellerman
Pavel Machek writes: >> Hello Sasha, >> >> Thank you for considering this patch for the stable tree 6.9, 6.8, 6.6, and >> 6.1. >> >> This patch does two things: >> 1. Fixes a potential memory corruption issue mentioned as the third point in >> the commit message >> 2. Enables the kernel to avoid

Re: [PATCH v8 2/3] PCI/AER: Disable AER service on suspend

2024-06-18 Thread Kai-Heng Feng
On Wed, Jun 19, 2024 at 4:48 AM Bjorn Helgaas wrote: > > On Thu, Apr 25, 2024 at 03:33:01PM +0800, Kai-Heng Feng wrote: > > On Fri, Apr 19, 2024 at 4:35 AM Bjorn Helgaas wrote: > > > > > > On Tue, Apr 16, 2024 at 12:32:24PM +0800, Kai-Heng Feng wrote: > > > > When the power rail gets cut off, the

Re: [PATCH v2 00/14] Introducing TIF_NOTIFY_IPI flag

2024-06-18 Thread K Prateek Nayak
Hello Chenyu, On 6/18/2024 1:19 PM, Chen Yu wrote: [..snip..] Vincent [5] pointed out a case where the idle load kick will fail to run on an idle CPU since the IPI handler launching the ILB will check for need_resched(). In such cases, the idle CPU relies on newidle_balance() to pull tasks to

Re: [PATCH v3 0/3] KVM: Set vcpu->preempted/ready iff scheduled out while running

2024-06-18 Thread Sean Christopherson
On Fri, 03 May 2024 11:17:31 -0700, David Matlack wrote: > This series changes KVM to mark a vCPU as preempted/ready if-and-only-if > it's scheduled out while running. i.e. Do not mark a vCPU > preempted/ready if it's scheduled out during a non-KVM_RUN ioctl() or > when userspace is doing KVM_RUN w

Re: [PATCH RFC v2 4/5] dma-direct: add base offset to zone_dma_bits

2024-06-18 Thread Catalin Marinas
On Tue, Apr 09, 2024 at 09:17:57AM +0300, Baruch Siach wrote: > Current code using zone_dma_bits assume that all addresses range in the > bits mask are suitable for DMA. For some existing platforms this > assumption is not correct. DMA range might have non zero lower limit. [...] > @@ -59,7 +60,7 @

Re: [PATCH RFC v2 2/5] of: get dma area lower limit

2024-06-18 Thread Catalin Marinas
On Tue, Apr 09, 2024 at 09:17:55AM +0300, Baruch Siach wrote: > of_dma_get_max_cpu_address() returns the highest CPU address that > devices can use for DMA. The implicit assumption is that all CPU > addresses below that limit are suitable for DMA. However the > 'dma-ranges' property this code uses

[PATCH v9 2/2] PCI/DPC: Disable DPC service on suspend

2024-06-18 Thread Bjorn Helgaas
From: Kai-Heng Feng If the link is powered off during suspend, electrical noise may cause errors that trigger DPC. If the DPC interrupt is enabled and shares an IRQ with PME, that causes a spurious wakeup during suspend. Disable DPC triggering and the DPC interrupt during suspend to prevent thi

[PATCH v9 1/2] PCI/AER: Disable AER service on suspend

2024-06-18 Thread Bjorn Helgaas
From: Kai-Heng Feng If the link is powered off during suspend, electrical noise may cause errors that are logged via AER. If the AER interrupt is enabled and shares an IRQ with PME, that causes a spurious wakeup during suspend. Disable the AER interrupt during suspend to prevent this. Clear er

[PATCH v9 0/2] PCI: Disable AER & DPC on suspend

2024-06-18 Thread Bjorn Helgaas
From: Bjorn Helgaas This is an old series from Kai-Heng that I didn't handle soon enough. The intent is to fix several suspend/resume issues: - Spurious wakeup from s2idle (https://bugzilla.kernel.org/show_bug.cgi?id=216295) - Steam Deck doesn't resume after suspend (https://bugzil

Re: [PATCH v8 2/3] PCI/AER: Disable AER service on suspend

2024-06-18 Thread Bjorn Helgaas
On Thu, Apr 25, 2024 at 03:33:01PM +0800, Kai-Heng Feng wrote: > On Fri, Apr 19, 2024 at 4:35 AM Bjorn Helgaas wrote: > > > > On Tue, Apr 16, 2024 at 12:32:24PM +0800, Kai-Heng Feng wrote: > > > When the power rail gets cut off, the hardware can create some electric > > > noise on the link that tr

Re: [kvm-unit-tests PATCH v10 08/15] powerpc: add pmu tests

2024-06-18 Thread Thomas Huth
On 12/06/2024 07.23, Nicholas Piggin wrote: Add some initial PMU testing. - PMC5/6 tests - PMAE / PMI test - BHRB basic tests Signed-off-by: Nicholas Piggin --- ... diff --git a/powerpc/pmu.c b/powerpc/pmu.c new file mode 100644 index 0..bdc45e167 --- /dev/null +++ b/powerpc/pmu.c @@

Re: [PATCH RFC v2 1/5] dma-mapping: replace zone_dma_bits by zone_dma_limit

2024-06-18 Thread Catalin Marinas
(finally getting around to looking at this series, sorry for the delay) On Tue, Apr 09, 2024 at 09:17:54AM +0300, Baruch Siach wrote: > From: Catalin Marinas > > Hardware DMA limit might not be power of 2. When RAM range starts above > 0, say 4GB, DMA limit of 30 bits should end at 5GB. A single

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-18 Thread Paul E. McKenney
On Tue, Jun 18, 2024 at 07:21:42PM +0200, Vlastimil Babka wrote: > On 6/18/24 6:48 PM, Paul E. McKenney wrote: > > On Tue, Jun 18, 2024 at 11:31:00AM +0200, Uladzislau Rezki wrote: > >> > On 6/17/24 8:42 PM, Uladzislau Rezki wrote: > >> > >> + > >> > >> + s = container_of(work, struct kmem_cach

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-18 Thread Vlastimil Babka
On 6/18/24 6:48 PM, Paul E. McKenney wrote: > On Tue, Jun 18, 2024 at 11:31:00AM +0200, Uladzislau Rezki wrote: >> > On 6/17/24 8:42 PM, Uladzislau Rezki wrote: >> > >> + >> > >> + s = container_of(work, struct kmem_cache, async_destroy_work); >> > >> + >> > >> + // XXX use the real kme

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-18 Thread Paul E. McKenney
On Tue, Jun 18, 2024 at 11:31:00AM +0200, Uladzislau Rezki wrote: > > On 6/17/24 8:42 PM, Uladzislau Rezki wrote: > > >> + > > >> +s = container_of(work, struct kmem_cache, async_destroy_work); > > >> + > > >> +// XXX use the real kmem_cache_free_barrier() or similar thing > > >> h

Re: [kvm-unit-tests PATCH v10 08/15] powerpc: add pmu tests

2024-06-18 Thread Thomas Huth
On 12/06/2024 07.23, Nicholas Piggin wrote: Add some initial PMU testing. - PMC5/6 tests - PMAE / PMI test - BHRB basic tests Signed-off-by: Nicholas Piggin --- lib/powerpc/asm/processor.h | 2 + lib/powerpc/asm/reg.h | 9 + lib/powerpc/asm/setup.h | 1 + lib/powerpc/setup

[PATCH V3 2/3] tools/perf: Use is_perf_pid_map_name helper function to check dso's of pattern /tmp/perf-%d.map

2024-06-18 Thread Athira Rajeev
commit 80d496be89ed ("perf report: Add support for profiling JIT generated code") added support for profiling JIT generated code. This patch handles dso's of form "/tmp/perf-$PID.map". Some of the references doesn't check exactly for same pattern. some uses "if (!strncmp(dso_name, "/tmp/perf-", 10

[PATCH V3 3/3] tools/perf: Fix parallel-perf python script to replace new python syntax ":=" usage

2024-06-18 Thread Athira Rajeev
perf test "perf script tests" fails as below in systems with python 3.6 File "/home/athira/linux/tools/perf/tests/shell/../../scripts/python/parallel-perf.py", line 442 if line := p.stdout.readline(): ^ SyntaxError: invalid syntax --- Cleaning up ---

[PATCH V3 1/3] tools/perf: Fix the string match for "/tmp/perf-$PID.map" files in dso__load

2024-06-18 Thread Athira Rajeev
Perf test for perf probe of function from different CU fails as below: ./perf test -vv "test perf probe of function from different CU" 116: test perf probe of function from different CU: --- start --- test child forked, pid 2679 Failed to find symbol foo in

Re: [PATCH] powerpc: Fixed duplicate copying in the early boot.

2024-06-18 Thread Segher Boessenkool
On Tue, Jun 18, 2024 at 10:12:54PM +1000, Michael Ellerman wrote: > Segher Boessenkool writes: > > On Mon, Jun 17, 2024 at 10:35:09AM +0800, Jinglin Wen wrote: > >> + cmplwi cr0,r4,0/* runtime base addr is zero */ > > > > Just write > >cmpwi r4,0 > > > > cr0 is the default, also impl

Re: [PATCH v12 00/11] Support page table check PowerPC

2024-06-18 Thread LEROY Christophe
Le 02/04/2024 à 07:11, Rohan McLure a écrit : > Support page table check on all PowerPC platforms. This works by > serialising assignments, reassignments and clears of page table > entries at each level in order to ensure that anonymous mappings > have at most one writable consumer, and likewise

Re: [PATCH] powerpc: Fixed duplicate copying in the early boot.

2024-06-18 Thread Michael Ellerman
Segher Boessenkool writes: > Hi! > > On Mon, Jun 17, 2024 at 10:35:09AM +0800, Jinglin Wen wrote: >> +cmplwi cr0,r4,0/* runtime base addr is zero */ > > Just write >cmpwi r4,0 > > cr0 is the default, also implicit in many other instructions, please > don't clutter the source code.

Re: [PATCH] tools/perf: Handle perftool-testsuite_probe testcases fail when kernel debuginfo is not present

2024-06-18 Thread James Clark
On 17/06/2024 17:47, Athira Rajeev wrote: > > >> On 17 Jun 2024, at 8:30 PM, James Clark wrote: >> >> >> >> On 17/06/2024 13:21, Athira Rajeev wrote: >>> Running "perftool-testsuite_probe" fails as below: >>> >>> ./perf test -v "perftool-testsuite_probe" >>> 83: perftool-testsuite_probe : FA

Re: [PATCH] powerpc: Fixed duplicate copying in the early boot.

2024-06-18 Thread Jinglin Wen
Hi Segher Boessenkool, Segher Boessenkool writes: > Hi! > > On Mon, Jun 17, 2024 at 10:35:09AM +0800, Jinglin Wen wrote: > > + cmplwi cr0,r4,0/* runtime base addr is zero */ > > Just write >cmpwi r4,0 > > cr0 is the default, also implicit in many other instructions, please > don

Re: [PATCH] powerpc: Fixed duplicate copying in the early boot.

2024-06-18 Thread Jinglin Wen
Hi Michael Ellerman, Michael Ellerman writes: > Jinglin Wen writes: > > According to the code logic, when the kernel is loaded to address 0, > > no copying operation should be performed, but it is currently being > > done. > > > > This patch fixes the issue where the kernel code was incorrectly

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-18 Thread Uladzislau Rezki
> On 6/17/24 8:42 PM, Uladzislau Rezki wrote: > >> + > >> + s = container_of(work, struct kmem_cache, async_destroy_work); > >> + > >> + // XXX use the real kmem_cache_free_barrier() or similar thing here > > It implies that we need to introduce kfree_rcu_barrier(), a new API, which i > > wanted

Re: [PATCH V2 2/3] tools/perf: Use is_perf_pid_map_name helper function to check dso's of pattern /tmp/perf-%d.map

2024-06-18 Thread Athira Rajeev
> On 18 Jun 2024, at 12:41 PM, Adrian Hunter wrote: > > On 17/06/24 16:03, Athira Rajeev wrote: >> commit 80d496be89ed ("perf report: Add support for profiling JIT >> generated code") added support for profiling JIT generated code. >> This patch handles dso's of form "/tmp/perf-$PID.map". >>

Re: [PATCH AUTOSEL 6.9 18/23] powerpc: make fadump resilient with memory add/remove events

2024-06-18 Thread Pavel Machek
Hi! > Hello Sasha, > > Thank you for considering this patch for the stable tree 6.9, 6.8, 6.6, and > 6.1. > > This patch does two things: > 1. Fixes a potential memory corruption issue mentioned as the third point in > the commit message > 2. Enables the kernel to avoid unnecessary fadump re-reg

Re: [PATCH v2] PowerPC: Replace kretprobe with rethook

2024-06-18 Thread Naveen N Rao
On Tue, Jun 18, 2024 at 06:43:06AM GMT, Masami Hiramatsu wrote: > On Mon, 17 Jun 2024 18:28:07 +0530 > Naveen N Rao wrote: > > > Hi Abhishek, > > > > On Mon, Jun 10, 2024 at 11:45:09AM GMT, Abhishek Dubey wrote: > > > This is an adaptation of commit f3a112c0c40d ("x86,rethook,kprobes: > > > Repl

Re: [PATCH v2 00/14] Introducing TIF_NOTIFY_IPI flag

2024-06-18 Thread Chen Yu
On 2024-06-17 at 14:03:41 +0530, K Prateek Nayak wrote: > Hello Chenyu, > > On 6/14/2024 10:01 PM, Chen Yu wrote: > > On 2024-06-14 at 12:48:37 +0200, Vincent Guittot wrote: > > > On Fri, 14 Jun 2024 at 11:28, Peter Zijlstra wrote: > > > > > > > > On Thu, Jun 13, 2024 at 06:15:59PM +, K Prat

Re: [PATCH v3 4/4] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs

2024-06-18 Thread Piotr Wojtaszczyk
On Mon, Jun 17, 2024 at 9:30 PM Markus Elfring wrote: > Would you become interested to apply a statement like > “guard(mutex)(&i2s_info_p->lock);”? > https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L196 I take it. Thanks. -- Piotr Wojtaszczyk Timesys

Re: [PATCH V2 2/3] tools/perf: Use is_perf_pid_map_name helper function to check dso's of pattern /tmp/perf-%d.map

2024-06-18 Thread Adrian Hunter
On 17/06/24 16:03, Athira Rajeev wrote: > commit 80d496be89ed ("perf report: Add support for profiling JIT > generated code") added support for profiling JIT generated code. > This patch handles dso's of form "/tmp/perf-$PID.map". > > Some of the references doesn't check exactly for same pattern.

Re: [PATCH] powerpc/pseries: Whitelist dtl slub object for copying to userspace

2024-06-18 Thread Michael Ellerman
Kees Cook writes: > On Fri, Jun 14, 2024 at 11:08:44PM +0530, Anjali K wrote: >> Reading the dispatch trace log from /sys/kernel/debug/powerpc/dtl/cpu-* >> results in a BUG() when the config CONFIG_HARDENED_USERCOPY is enabled as >> shown below. >> >> kernel BUG at mm/usercopy.c:102! >> O