Re: [PATCH net-next v3 2/3] net: ibmveth: Reset the adapter when unexpected states are detected

2025-04-22 Thread Jakub Kicinski
On Wed, 16 Apr 2025 15:57:50 -0500 Dave Marquardt wrote: > Reset the adapter through new function ibmveth_reset, called in > WARN_ON situations. Removed conflicting and unneeded forward > declaration. There's a schedule_work() added but neither cancel nor flush when interface is shut down or remov

Re: [PATCH] fsl_pamu: Use 40-bits for addressing where appropriate

2025-04-22 Thread Ben Collins
On Tue, Apr 22, 2025 at 08:43:05PM -0500, Jason Gunthorpe wrote: > On Tue, Apr 22, 2025 at 06:21:32PM -0400, Ben Collins wrote: > > On Tue, Apr 22, 2025 at 04:09:21PM -0500, Jason Gunthorpe wrote: > > > On Mon, Apr 21, 2025 at 10:46:19PM -0400, Ben Collins wrote: > > > > diff --git a/drivers/iommu/

Re: [PATCH] fsl_pamu: Use 40-bits for addressing where appropriate

2025-04-22 Thread Jason Gunthorpe
On Tue, Apr 22, 2025 at 06:21:32PM -0400, Ben Collins wrote: > On Tue, Apr 22, 2025 at 04:09:21PM -0500, Jason Gunthorpe wrote: > > On Mon, Apr 21, 2025 at 10:46:19PM -0400, Ben Collins wrote: > > > diff --git a/drivers/iommu/fsl_pamu_domain.c > > > b/drivers/iommu/fsl_pamu_domain.c > > > index 30

Re: [PATCH] fsl_pamu: Use 40-bits for addressing where appropriate

2025-04-22 Thread Ben Collins
On Tue, Apr 22, 2025 at 04:09:21PM -0500, Jason Gunthorpe wrote: > On Mon, Apr 21, 2025 at 10:46:19PM -0400, Ben Collins wrote: > > diff --git a/drivers/iommu/fsl_pamu_domain.c > > b/drivers/iommu/fsl_pamu_domain.c > > index 30be786bff11e..a4bc6482a00f7 100644 > > --- a/drivers/iommu/fsl_pamu_doma

Re: [PATCH] fsldma: Support 40 bit DMA addresses where capable

2025-04-22 Thread Ben Collins
On Tue, Apr 22, 2025 at 11:25:40AM -0500, Arnd Bergmann wrote: > On Tue, Apr 22, 2025, at 10:56, Ben Collins wrote: > > On Tue, Apr 22, 2025 at 09:59:42AM -0500, Arnd Bergmann wrote: > >> > >> Right, but this could just mean that they end up using SWIOTLB > >> to bounce the high DMA pages or use a

Re: [PATCH] fsl_pamu: Use 40-bits for addressing where appropriate

2025-04-22 Thread Jason Gunthorpe
On Mon, Apr 21, 2025 at 10:46:19PM -0400, Ben Collins wrote: > diff --git a/drivers/iommu/fsl_pamu_domain.c b/drivers/iommu/fsl_pamu_domain.c > index 30be786bff11e..a4bc6482a00f7 100644 > --- a/drivers/iommu/fsl_pamu_domain.c > +++ b/drivers/iommu/fsl_pamu_domain.c > @@ -214,9 +214,10 @@ static str

[PATCH v3 12/13] crypto: lib/chacha - remove INTERNAL symbol and selection of CRYPTO

2025-04-22 Thread Eric Biggers
From: Eric Biggers Now that the architecture-optimized ChaCha kconfig symbols are defined regardless of CRYPTO, there is no need for CRYPTO_LIB_CHACHA to select CRYPTO. So, remove that. This makes the indirection through the CRYPTO_LIB_CHACHA_INTERNAL symbol unnecessary, so get rid of that and

[PATCH v3 13/13] crypto: lib/poly1305 - remove INTERNAL symbol and selection of CRYPTO

2025-04-22 Thread Eric Biggers
From: Eric Biggers Now that the architecture-optimized Poly1305 kconfig symbols are defined regardless of CRYPTO, there is no need for CRYPTO_LIB_POLY1305 to select CRYPTO. So, remove that. This makes the indirection through the CRYPTO_LIB_POLY1305_INTERNAL symbol unnecessary, so get rid of tha

[PATCH v3 10/13] crypto: s390 - move library functions to arch/s390/lib/crypto/

2025-04-22 Thread Eric Biggers
From: Eric Biggers Continue disentangling the crypto library functions from the generic crypto infrastructure by moving the s390 ChaCha library functions into a new directory arch/s390/lib/crypto/ that does not depend on CRYPTO. This mirrors the distinction between crypto/ and lib/crypto/. Acked

[PATCH v3 07/13] crypto: mips - move library functions to arch/mips/lib/crypto/

2025-04-22 Thread Eric Biggers
From: Eric Biggers Continue disentangling the crypto library functions from the generic crypto infrastructure by moving the mips ChaCha and Poly1305 library functions into a new directory arch/mips/lib/crypto/ that does not depend on CRYPTO. This mirrors the distinction between crypto/ and lib/c

[PATCH v3 04/13] crypto: x86 - drop redundant dependencies on X86

2025-04-22 Thread Eric Biggers
From: Eric Biggers arch/x86/crypto/Kconfig is sourced only when CONFIG_X86=y, so there is no need for the symbols defined inside it to depend on X86. In the case of CRYPTO_TWOFISH_586 and CRYPTO_TWOFISH_X86_64, the dependency was actually on '(X86 || UML_X86)', which suggests that these two symb

[PATCH v3 05/13] crypto: arm - move library functions to arch/arm/lib/crypto/

2025-04-22 Thread Eric Biggers
From: Eric Biggers Continue disentangling the crypto library functions from the generic crypto infrastructure by moving the arm BLAKE2s, ChaCha, and Poly1305 library functions into a new directory arch/arm/lib/crypto/ that does not depend on CRYPTO. This mirrors the distinction between crypto/ a

[PATCH v3 09/13] crypto: riscv - move library functions to arch/riscv/lib/crypto/

2025-04-22 Thread Eric Biggers
From: Eric Biggers Continue disentangling the crypto library functions from the generic crypto infrastructure by moving the riscv ChaCha library functions into a new directory arch/riscv/lib/crypto/ that does not depend on CRYPTO. This mirrors the distinction between crypto/ and lib/crypto/. Sig

[PATCH v3 11/13] crypto: x86 - move library functions to arch/x86/lib/crypto/

2025-04-22 Thread Eric Biggers
From: Eric Biggers Continue disentangling the crypto library functions from the generic crypto infrastructure by moving the x86 BLAKE2s, ChaCha, and Poly1305 library functions into a new directory arch/x86/lib/crypto/ that does not depend on CRYPTO. This mirrors the distinction between crypto/ a

[PATCH v3 08/13] crypto: powerpc - move library functions to arch/powerpc/lib/crypto/

2025-04-22 Thread Eric Biggers
From: Eric Biggers Continue disentangling the crypto library functions from the generic crypto infrastructure by moving the powerpc ChaCha and Poly1305 library functions into a new directory arch/powerpc/lib/crypto/ that does not depend on CRYPTO. This mirrors the distinction between crypto/ and

[PATCH v3 00/13] Finish disentangling ChaCha, Poly1305, and BLAKE2s from CRYPTO

2025-04-22 Thread Eric Biggers
This series removes the unnecessary dependency of the ChaCha, Poly1305, and BLAKE2s library functions on the generic crypto infrastructure, i.e. CONFIG_CRYPTO. To do this, it moves the architecture-optimized implementations of these functions into new directories arch/*/lib/crypto/ which do not de

[PATCH v3 06/13] crypto: arm64 - move library functions to arch/arm64/lib/crypto/

2025-04-22 Thread Eric Biggers
From: Eric Biggers Continue disentangling the crypto library functions from the generic crypto infrastructure by moving the arm64 ChaCha and Poly1305 library functions into a new directory arch/arm64/lib/crypto/ that does not depend on CRYPTO. This mirrors the distinction between crypto/ and lib

[PATCH v3 02/13] crypto: powerpc - drop redundant dependencies on PPC

2025-04-22 Thread Eric Biggers
From: Eric Biggers arch/powerpc/crypto/Kconfig is sourced only when CONFIG_PPC=y, so there is no need for the symbols defined inside it to depend on PPC. Acked-by: Ard Biesheuvel Signed-off-by: Eric Biggers --- arch/powerpc/crypto/Kconfig | 8 +++- 1 file changed, 3 insertions(+), 5 delet

[PATCH v3 03/13] crypto: s390 - drop redundant dependencies on S390

2025-04-22 Thread Eric Biggers
From: Eric Biggers arch/s390/crypto/Kconfig is sourced only when CONFIG_S390=y, so there is no need for the symbols defined inside it to depend on S390. Acked-by: Ard Biesheuvel Acked-by: Heiko Carstens Signed-off-by: Eric Biggers --- arch/s390/crypto/Kconfig | 10 -- 1 file changed,

[PATCH v3 01/13] crypto: arm64 - drop redundant dependencies on ARM64

2025-04-22 Thread Eric Biggers
From: Eric Biggers arch/arm64/crypto/Kconfig is sourced only when CONFIG_ARM64=y, so there is no need for the symbols defined inside it to depend on ARM64. Acked-by: Ard Biesheuvel Signed-off-by: Eric Biggers --- arch/arm64/crypto/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH v4 3/3] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-04-22 Thread Christian Brauner
On Tue, Apr 22, 2025 at 04:31:29PM +0200, Christian Brauner wrote: > On Thu, Mar 27, 2025 at 12:39:28PM +0100, Amir Goldstein wrote: > > On Thu, Mar 27, 2025 at 10:33 AM Andrey Albershteyn > > wrote: > > > > > > On 2025-03-23 09:56:25, Amir Goldstein wrote: > > > > On Fri, Mar 21, 2025 at 8:49 PM

Re: [PATCH v4 3/3] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-04-22 Thread Christian Brauner
On Fri, Mar 21, 2025 at 08:48:42PM +0100, Andrey Albershteyn wrote: > From: Andrey Albershteyn > > Introduce getfsxattrat and setfsxattrat syscalls to manipulate inode > extended attributes/flags. The syscalls take parent directory fd and > path to the child together with struct fsxattr. > > Thi

Re: [PATCH v4 3/3] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-04-22 Thread Christian Brauner
On Thu, Mar 27, 2025 at 12:39:28PM +0100, Amir Goldstein wrote: > On Thu, Mar 27, 2025 at 10:33 AM Andrey Albershteyn > wrote: > > > > On 2025-03-23 09:56:25, Amir Goldstein wrote: > > > On Fri, Mar 21, 2025 at 8:49 PM Andrey Albershteyn > > > wrote: > > > > > > > > From: Andrey Albershteyn >

Re: [PATCH] powerpc/boot: Fix dash warning

2025-04-22 Thread Madhavan Srinivasan
On 4/22/25 6:38 PM, Stephen Rothwell wrote: > Hi Madhavan, > > On Tue, 22 Apr 2025 17:00:23 +0530 Madhavan Srinivasan > wrote: >> >> # suppress some warnings in recent ld versions >> nowarn="-z noexecstack" >> -if [ $(${CROSS}ld -v --no-warn-rwx-segments &>/dev/null; echo $?) -eq 0 ]; >> t

Re: [PATCH 6/6] powerpc/boot/install.sh: Fix shellcheck warnings

2025-04-22 Thread Stephen Rothwell
Hi Madhavan, On Tue, 22 Apr 2025 18:40:40 +0530 Madhavan Srinivasan wrote: > > -if [ -f $4/$image_name-$1 ]; then > - mv $4/$image_name-$1 $4/$image_name-$1.old > +if [ -f "$4"/"$image_name"-"$1" ]; then > + mv "$4"/"$image_name"-"$1" "$4"/"$image_name"-"$1".old "$4/$image_name-$1" is j

Re: [PATCH 5/6] powerpc/prom_init: Fix shellcheck warnings

2025-04-22 Thread Stephen Rothwell
Hi Madhavan, On Tue, 22 Apr 2025 18:40:39 +0530 Madhavan Srinivasan wrote: > > Fix "Double quote to prevent globbing and word splitting." > warning from shellcheck Looks good to me. Reviewed-by: Stephen Rothwell -- Cheers, Stephen Rothwell pgpiFfnobaiO9.pgp Description: OpenPGP digital si

[PATCH 6/6] powerpc/boot/install.sh: Fix shellcheck warnings

2025-04-22 Thread Madhavan Srinivasan
Fix shellcheck warning such as "Double quote to prevent globbing and word splitting." and Use $(...) notation instead of legacy backticks `...`. Signed-off-by: Madhavan Srinivasan --- arch/powerpc/boot/install.sh | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/

[PATCH 5/6] powerpc/prom_init: Fix shellcheck warnings

2025-04-22 Thread Madhavan Srinivasan
Fix "Double quote to prevent globbing and word splitting." warning from shellcheck Signed-off-by: Madhavan Srinivasan --- arch/powerpc/kernel/prom_init_check.sh | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/pow

[PATCH 4/6] powerpc: fix sparse warnings

2025-04-22 Thread Madhavan Srinivasan
structs are local to the source and does not need to be in global scope, so make it static. Signed-off-by: Madhavan Srinivasan --- arch/powerpc/kernel/btext.c | 2 +- arch/powerpc/kernel/setup-common.c | 2 +- arch/powerpc/platforms/powernv/opal.c| 2 +- arch/powerpc/platf

[PATCH 3/6] powerpc/perf:make isa207_pmu_format_group struct static

2025-04-22 Thread Madhavan Srinivasan
isa207_pmu_format_group struct is local to the source and does not need to be in global scope, so make it static Cleans up sparse warning: arch/powerpc/perf/isa207-common.c:40:30: warning: symbol 'isa207_pmu_format_group' was not declared. Should it be static? Signed-off-by: Madhavan Srinivasan

[PATCH 2/6] powerpc/xmon: fix sparse warning "Using plain integer as NULL pointer"

2025-04-22 Thread Madhavan Srinivasan
Fix passing of argument 0 to NULL to avoid sparse warning Cleans up sparse warning: arch/powerpc/xmon/ppc-opc.c:797:15: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:797:18: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:801:15: warning: Using p

[PATCH 1/6] powerpc/kvm: Fix sparse warning

2025-04-22 Thread Madhavan Srinivasan
When compiling for pseries or powernv defconfig with "make C=1", these warning were reported by sparse tool in powerpc/kernel/kvm.c arch/powerpc/kernel/kvm.c:635:9: warning: switch with no cases arch/powerpc/kernel/kvm.c:646:9: warning: switch with no cases Currently #ifdef were added after the s

[PATCH 0/6] Fixes for shellcheck/sparse warnings

2025-04-22 Thread Madhavan Srinivasan
Patchset handles fixes for some of the sparse and shellcheck warnings. Madhavan Srinivasan (6): powerpc/kvm: Fix sparse warning powerpc/xmon: fix sparse warning "Using plain integer as NULL pointer" powerpc/perf:make isa207_pmu_format_group struct static powerpc: fix sparse warnings powe

Re: [PATCH] powerpc/boot: Fix dash warning

2025-04-22 Thread Stephen Rothwell
Hi Madhavan, On Tue, 22 Apr 2025 17:00:23 +0530 Madhavan Srinivasan wrote: > > # suppress some warnings in recent ld versions > nowarn="-z noexecstack" > -if [ $(${CROSS}ld -v --no-warn-rwx-segments &>/dev/null; echo $?) -eq 0 ]; > then > +if [ "$("${CROSS}"ld -v --no-warn-rwx-segments >/dev/

Re: [PATCH v3] dt-bindings: powerpc: Convert fsl/pmc.txt to YAML

2025-04-22 Thread Rob Herring (Arm)
On Thu, 17 Apr 2025 16:21:14 +0200, J. Neuschäfer wrote: > This patch rewrites pmc.txt into YAML format. Descriptive texts are > expanded or shortened in a few places to better fit today's conventions. > > The list of compatible strings (and combinations of them) is based on > existing device tr

Re: [PATCH net-next v3 3/3] net: ibmveth: added KUnit tests for some buffer pool functions

2025-04-22 Thread Simon Horman
On Wed, Apr 16, 2025 at 03:57:51PM -0500, Dave Marquardt wrote: > Added KUnit tests for ibmveth_remove_buffer_from_pool and > ibmveth_rxq_get_buffer under new IBMVETH_KUNIT_TEST config option. > > Signed-off-by: Dave Marquardt Reviewed-by: Simon Horman

Re: [PATCH net-next v3 2/3] net: ibmveth: Reset the adapter when unexpected states are detected

2025-04-22 Thread Simon Horman
On Wed, Apr 16, 2025 at 03:57:50PM -0500, Dave Marquardt wrote: > Reset the adapter through new function ibmveth_reset, called in > WARN_ON situations. Removed conflicting and unneeded forward > declaration. > > Signed-off-by: Dave Marquardt Reviewed-by: Simon Horman

Re: [PATCH net-next v3 1/3] net: ibmveth: Indented struct ibmveth_adapter correctly

2025-04-22 Thread Simon Horman
On Wed, Apr 16, 2025 at 03:57:49PM -0500, Dave Marquardt wrote: > Made struct ibmveth_adapter follow indentation rules > > Signed-off-by: Dave Marquardt Reviewed-by: Simon Horman

[PATCH] powerpc/boot: Fix dash warning

2025-04-22 Thread Madhavan Srinivasan
Commit b2accfe7ca5b '("powerpc/boot: Check for ld-option support")' suppressed linker warnings, but the expressed used did not go well with POSIX shell (dash) resulting with this warning arch/powerpc/boot/wrapper: 237: [: 0: unexpected operator ld: warning: arch/powerpc/boot/zImage.epapr has a LOA

Re: [PATCH v2 10/13] crypto: s390 - move library functions to arch/s390/lib/crypto/

2025-04-22 Thread Heiko Carstens
On Sun, Apr 20, 2025 at 12:26:06PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Continue disentangling the crypto library functions from the generic > crypto infrastructure by moving the s390 ChaCha library functions into a > new directory arch/s390/lib/crypto/ that does not depend on CRYP

Re: [PATCH v2 03/13] crypto: s390 - drop redundant dependencies on S390

2025-04-22 Thread Heiko Carstens
On Sun, Apr 20, 2025 at 12:25:59PM -0700, Eric Biggers wrote: > From: Eric Biggers > > arch/s390/crypto/Kconfig is sourced only when CONFIG_S390=y, so there is > no need for the symbols defined inside it to depend on S390. > > Acked-by: Ard Biesheuvel > Signed-off-by: Eric Biggers > --- > arc

Re: frozen PHB on IBM Power9 system in 6.15-rc2 (bisected)

2025-04-22 Thread Dan Horák
Hi Hannes, On Tue, 22 Apr 2025 08:37:32 +0200 Hannes Reinecke wrote: > On 4/17/25 17:10, Dan Horák wrote: > > Hi, > > > > I am seeing "frozen PHB" on Power9 bare-metal (PowerNV ppc64le) system > > leading to non-accessible nvme drives (they are behind a switch) in the > > 6.15-rc2 kernel (origi

Re: [PATCH] fsldma: Support 40 bit DMA addresses where capable

2025-04-22 Thread Arnd Bergmann
On Tue, Apr 22, 2025, at 10:56, Ben Collins wrote: > On Tue, Apr 22, 2025 at 09:59:42AM -0500, Arnd Bergmann wrote: >> >> Right, but this could just mean that they end up using SWIOTLB >> to bounce the high DMA pages or use an IOMMU rather than actually >> translating the physical address to a dma

Re: [PATCH] tools headers: Update the include/vdso/unaligned.h to sync headers

2025-04-22 Thread James Clark
On 21/04/2025 4:41 am, Athira Rajeev wrote: To pick up the changes in: commit acea9943271b ("vdso: Address variable shadowing in macros") Addressing this perf tools build warning: diff -u tools/include/vdso/unaligned.h include/vdso/unaligned.h Reported-by: Venkat Rao Bagalko

Re: [PATCH] fsldma: Support 40 bit DMA addresses where capable

2025-04-22 Thread Ben Collins
On Tue, Apr 22, 2025 at 09:59:42AM -0500, Arnd Bergmann wrote: > On Tue, Apr 22, 2025, at 09:12, Ben Collins wrote: > > On Tue, Apr 22, 2025 at 08:34:55AM -0500, Arnd Bergmann wrote: > >> > >> - SoCs that don't set a dma-ranges property in the parent bus > >> are normally still capped to 32 bit

Re: [PATCH v2] powerpc64/bpf: fix JIT code size calculation of bpf trampoline

2025-04-22 Thread Hari Bathini
On 17/04/25 8:06 pm, Venkat Rao Bagalkote wrote: On 17/04/25 1:10 am, Hari Bathini wrote: arch_bpf_trampoline_size() provides JIT size of the BPF trampoline before the buffer for JIT'ing it is allocated. The total number of instructions emitted for BPF trampoline JIT code depends on where th

Re: [PATCH v2] powerpc64/bpf: fix JIT code size calculation of bpf trampoline

2025-04-22 Thread Hari Bathini
On 19/04/25 4:31 pm, Naveen N Rao wrote: On Thu, Apr 17, 2025 at 01:10:37AM +0530, Hari Bathini wrote: arch_bpf_trampoline_size() provides JIT size of the BPF trampoline before the buffer for JIT'ing it is allocated. The total number of instructions emitted for BPF trampoline JIT code depends

[PATCH v3] powerpc/bpf: fix JIT code size calculation of bpf trampoline

2025-04-22 Thread Hari Bathini
arch_bpf_trampoline_size() provides JIT size of the BPF trampoline before the buffer for JIT'ing it is allocated. The total number of instructions emitted for BPF trampoline JIT code depends on where the final image is located. So, the size arrived at with the dummy pass in arch_bpf_trampoline_size

Re: [PATCH] fsldma: Support 40 bit DMA addresses where capable

2025-04-22 Thread Arnd Bergmann
On Tue, Apr 22, 2025, at 09:12, Ben Collins wrote: > On Tue, Apr 22, 2025 at 08:34:55AM -0500, Arnd Bergmann wrote: >> >> - SoCs that don't set a dma-ranges property in the parent bus >> are normally still capped to 32 bit DMA. I don't see those >> properties, so unless there is a special hack

Re: [PATCH] fsldma: Support 40 bit DMA addresses where capable

2025-04-22 Thread Ben Collins
On Tue, Apr 22, 2025 at 08:34:55AM -0500, Arnd Bergmann wrote: > On Tue, Apr 22, 2025, at 04:49, Ben Collins wrote: > > On 64-bit QorIQ platforms like T4240, the CPU supports 40-bit addressing > > and memory configurations > 64GiB. The fsldma driver is limiting itself > > to only 64GiB in all Elo c