Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a

2023-02-03 Thread ALOK TIWARI
{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata }, + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata }, { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata }, can it be like this for better readability. ? Thanks, Alok On 2/2/2023 11

Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a

2023-02-09 Thread ALOK TIWARI
yes, it is more about sort the list using .data and .compatible. key much better if it we keep this as suggested by Frank, static const struct of_device_id ls_pcie_ep_of_match[] = { + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata }, { .compatible = "fsl,ls1046a-pc

Re: [External] : [PATCH v3 1/1] PCI: layerscape: Add EP mode support for ls1028a

2023-02-10 Thread ALOK TIWARI
LGTM, Thanks, Alok On 2/9/2023 8:40 PM, Frank Li wrote: From: Xiaowei Bao Add PCIe EP mode support for ls1028a. Signed-off-by: Xiaowei Bao Signed-off-by: Hou Zhiqiang Signed-off-by: Frank Li Acked-by: Roy Zang --- Change from v2 to v3 order by .compatible Change from v2 to v2 Added

Re: [External] : [PATCH v3 1/1] PCI: layerscape: Add EP mode support for ls1028a

2023-02-10 Thread ALOK TIWARI
Reviewed-by: Alok Tiwari On 2/9/2023 8:40 PM, Frank Li wrote: From: Xiaowei Bao Add PCIe EP mode support for ls1028a. Signed-off-by: Xiaowei Bao Signed-off-by: Hou Zhiqiang Signed-off-by: Frank Li Acked-by: Roy Zang --- Change from v2 to v3 order by .compatible Change from v2 to v2

Re: [External] : [PATCH v3 1/1] PCI: layerscape: Add EP mode support for ls1028a

2023-02-10 Thread ALOK TIWARI
Reviewed-by: Alok Tiwari On 2/9/2023 8:40 PM, Frank Li wrote: From: Xiaowei Bao Add PCIe EP mode support for ls1028a. Signed-off-by: Xiaowei Bao Signed-off-by: Hou Zhiqiang Signed-off-by: Frank Li Acked-by: Roy Zang --- Change from v2 to v3 order by .compatible Change from v2 to v2