Re: [PATCH v17 00/12] Support page table check on PowerPC

Hi Andrew, On Tue, 2025-09-09 at 19:13 +1000, Andrew Donnellan wrote: > Support page table check on all PowerPC platforms. This works by serialising > assignments, reassignments and clears of page table entries at each level in > order to ensure that anonymous mappings have at most one

[PATCH v17 01/12] arm64/mm: Add addr parameter to __set_ptes_anysz()

d-off-by: Andrew Donnellan --- v15: new patch v16: rebase --- arch/arm64/include/asm/pgtable.h | 19 --- arch/arm64/mm/hugetlbpage.c | 10 +- 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgta

[PATCH v17 12/12] powerpc: mm: Support page table check

inux.ibm.com: rebase] Reviewed-by: Christophe Leroy Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan Acked-by: Madhavan Srinivasan --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/book3s/32/pgtable.h | 7 ++- arch

[PATCH v17 11/12] powerpc: mm: Use set_pte_at_unchecked() for internal usages

: don't change to unchecked for early boot/kernel mappings] Signed-off-by: Rohan McLure Signed-off-by: Andrew Donnellan Acked-by: Madhavan Srinivasan --- v13: don't use the unchecked version for early-boot kernel mappings (Pasha) --- arch/powerpc/include/asm/pgtable.h | 2 ++ arch/

[PATCH v17 02/12] arm64/mm: Add addr parameter to __ptep_get_and_clear_anysz()

ingly. Signed-off-by: Andrew Donnellan --- v15: new patch --- arch/arm64/include/asm/pgtable.h | 5 +++-- arch/arm64/mm/hugetlbpage.c | 7 --- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index ed644be

[PATCH v17 10/12] powerpc: mm: Implement *_user_accessible_page() for ptes

ned-off-by: Andrew Donnellan Acked-by: Madhavan Srinivasan --- arch/powerpc/include/asm/book3s/32/pgtable.h | 5 + arch/powerpc/include/asm/book3s/64/pgtable.h | 17 + arch/powerpc/include/asm/nohash/pgtable.h| 5 + arch/powerpc/include/asm/pgtable.h | 8 +

[PATCH v17 08/12] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pte_clear()

e pte, but instead in the address of the access. [a...@linux.ibm.com: rebase, fix additional occurrence and loop handling] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Ingo Molnar # x86 Acked-by: Alexandre Ghiti # riscv Signed-off-by: Andrew Donnellan --- v13: fix an

[PATCH v17 00/12] Support page table check on PowerPC

uired. Link: https://lore.kernel.org/linuxppc-dev/20230214015939.1853438-1-rmcl...@linux.ibm.com/ v5: Link: https://lore.kernel.org/linuxppc-dev/20221118002146.25979-1-rmcl...@linux.ibm.com/ Andrew Donnellan (2): arm64/mm: Add addr parameter to __set_ptes_anysz() arm64/mm: Add addr parameter to __p

[PATCH v17 03/12] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud[s]_set()

a Tatashin Acked-by: Ingo Molnar # x86 Acked-by: Alexandre Ghiti # riscv Signed-off-by: Andrew Donnellan --- v13: remove inaccurate comment on riscv in the commit message v14: fix an x86 usage I missed (found by akpm) v15: rebase, amend commit message --- arch/arm64/include/asm/pgtable.h | 3 ++-

[PATCH v17 06/12] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_clear()

e pte, but instead in the address of the access. [a...@linux.ibm.com: rebase on arm64 changes] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v15: rebase v17: rebase, fix conflict with riscv patch --- arch/arm64/i

[PATCH v17 07/12] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd_clear()

e pte, but instead in the address of the access. [a...@linux.ibm.com: rebase on arm64 changes] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Ingo Molnar # x86 Acked-by: Alexandre Ghiti # riscv Signed-off-by: Andrew Donnellan --- v15: rebase --- arch/arm64/include/asm/pgta

[PATCH v17 09/12] mm: Provide address parameter to p{te,md,ud}_user_accessible_page()

provide support for page table check on powerpc. [a...@linux.ibm.com: rebase on arm64 changes] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Ingo Molnar # x86 Acked-by: Alexandre Ghiti # riscv Signed-off-by: Andrew Donnellan --- v15: rebase --- arch/arm64/include/asm

[PATCH v17 05/12] mm/page_table_check: Provide addr parameter to page_table_check_ptes_set()

platforms, this can be inferred from the addr parameter. [a...@linux.ibm.com: rebase on arm64 + riscv changes, update commit message] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Alexandre Ghiti # riscv Signed-off-by: Andrew Donnellan --- v15: rebase, amend commit message

[PATCH v17 04/12] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd[s]_set()

a Tatashin Acked-by: Ingo Molnar # x86 Acked-by: Alexandre Ghiti # riscv Signed-off-by: Andrew Donnellan --- v13: remove inaccurate comment on riscv in the commit message v14: rebase v15: rebase, amend commit message --- arch/arm64/include/asm/pgtable.h | 5 +++-- arch/riscv/include/asm/pgta

Re: [PATCH RFC] powerpc: Panic on jump label code patching failure

for when the store instruction faults. > > > > Although there are other places where there can be an error returned, > > so I was wondering if that is what you were hitting or something else? > > Andrew was hitting the -EPERM because the memory area was read-only. > > Christophe -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

[PATCH RFC] powerpc: Panic on jump label code patching failure

-by: Erhard Furtner Signed-off-by: Andrew Donnellan --- Ran into this while debugging an issue that Erhard reported to me about my PAGE_TABLE_CHECK series on a G4, where updating a static key failed silently, but only for one call site, leading to an incorrect reference count later on. This looks

Re: [PATCH] powerpc/32: Remove PAGE_KERNEL_TEXT to fix startup failure

check_pte_clear(), which was in turn inlined ultimately into debug_vm_pgtable(). This patch seems to fix the problem, so: Tested-by: Andrew Donnellan But I'm still curious about why I only see the issue when: (a) CONFIG_KFENCE=y (even when disabled using kfence.sample_interval=0) - noting that changin

Re: Kernel v6.17-rc4 with STATIC_CALL_SELFTEST=y enabled fails to boot at early stage (PowerMac G4 DP)

c04b9f00] [c002d3b0] cpu_mitigations_off+0x0/0x14 [c04b9f40] [c00127ac] fixup_cpc710_pci64+0x0/0x20 [c04b9f70] [c035082c] static_call_init+0x108/0x140 [c04b9fa0] [c0342ed0] start_kernel+0x78/0x4a8 [c04b9ff0] [3500] 0x3500 Rebooting in 180 seconds.. -- Andrew DonnellanOzLabs, ADL Canberra a..

[PATCH v16 13/13] powerpc: mm: Support page table check

inux.ibm.com: rebase] Reviewed-by: Christophe Leroy Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan Acked-by: Madhavan Srinivasan --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/book3s/32/pgtable.h | 7 ++- arch

[PATCH v16 12/13] powerpc: mm: Use set_pte_at_unchecked() for internal usages

: don't change to unchecked for early boot/kernel mappings] Signed-off-by: Rohan McLure Signed-off-by: Andrew Donnellan Acked-by: Madhavan Srinivasan --- v13: don't use the unchecked version for early-boot kernel mappings (Pasha) --- arch/powerpc/include/asm/pgtable.h | 2 ++ arch/

[PATCH v16 11/13] powerpc: mm: Implement *_user_accessible_page() for ptes

ned-off-by: Andrew Donnellan Acked-by: Madhavan Srinivasan --- arch/powerpc/include/asm/book3s/32/pgtable.h | 5 + arch/powerpc/include/asm/book3s/64/pgtable.h | 17 + arch/powerpc/include/asm/nohash/pgtable.h| 5 + arch/powerpc/include/asm/pgtable.h | 8 +

[PATCH v16 10/13] powerpc: mm: Add pud_pfn() stub

, include this stub as a BUILD_BUG(). Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan Acked-by: Madhavan Srinivasan --- arch/powerpc/include/asm/pgtable.h | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/powerpc/include/asm/pgtable.h b/arch

[PATCH v16 09/13] mm: Provide address parameter to p{te,md,ud}_user_accessible_page()

provide support for page table check on powerpc. [a...@linux.ibm.com: rebase on arm64 changes] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v15: rebase --- arch/arm64/include/asm/pgtable.h | 6 +++--- arch/riscv/include

[PATCH v16 08/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pte_clear()

e pte, but instead in the address of the access. [a...@linux.ibm.com: rebase, fix additional occurrence and loop handling] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v13: fix an additional occurrence v15: rebase

[PATCH v16 07/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd_clear()

e pte, but instead in the address of the access. [a...@linux.ibm.com: rebase on arm64 changes] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v15: rebase --- arch/arm64/include/asm/pgtable.h | 2 +- arch/riscv/i

[PATCH v16 06/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_clear()

e pte, but instead in the address of the access. [a...@linux.ibm.com: rebase on arm64 changes] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v15: rebase --- arch/arm64/include/asm/pgtable.h | 2 +- arch/x86/include/asm

[PATCH v16 05/13] mm/page_table_check: Provide addr parameter to page_table_check_ptes_set()

platforms, this can be inferred from the addr parameter. [a...@linux.ibm.com: rebase on arm64 + riscv changes, update commit message] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan --- v15: rebase, amend commit message --- arch/arm64/include/asm

[PATCH v16 00/13] Support page table check on PowerPC

as access to the mm_struct * is required. Link: https://lore.kernel.org/linuxppc-dev/20230214015939.1853438-1-rmcl...@linux.ibm.com/ v5: Link: https://lore.kernel.org/linuxppc-dev/20221118002146.25979-1-rmcl...@linux.ibm.com/ Andrew Donnellan (2): arm64/mm: Add addr parameter to __set_ptes_any

[PATCH v16 02/13] arm64/mm: Add addr parameter to __ptep_get_and_clear_anysz()

ingly. Signed-off-by: Andrew Donnellan --- v15: new patch --- arch/arm64/include/asm/pgtable.h | 5 +++-- arch/arm64/mm/hugetlbpage.c | 7 --- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index ed644be

[PATCH v16 04/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd[s]_set()

a Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v13: remove inaccurate comment on riscv in the commit message v14: rebase v15: rebase, amend commit message --- arch/arm64/include/asm/pgtable.h | 5 +++-- arch/riscv/include/asm/pgtable.h | 4 ++-- arch/x86/include/asm

[PATCH v16 03/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud[s]_set()

a Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v13: remove inaccurate comment on riscv in the commit message v14: fix an x86 usage I missed (found by akpm) v15: rebase, amend commit message --- arch/arm64/include/asm/pgtable.h | 3 ++- arch/riscv/include/asm/pgta

[PATCH v16 01/13] arm64/mm: Add addr parameter to __set_ptes_anysz()

d-off-by: Andrew Donnellan --- v15: new patch v16: rebase --- arch/arm64/include/asm/pgtable.h | 19 --- arch/arm64/mm/hugetlbpage.c | 10 +- 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgta

Re: [PATCH v2 2/2] powerpc: pci-ioda: Optimize pnv_ioda_pick_m64_pe()

le() loop with the dedicated > for_each_set_bit(). > > Signed-off-by: Yury Norov (NVIDIA) Reviewed-by: Andrew Donnellan -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH v2 1/2] powerpc: pci-ioda: use bitmap_alloc() in pnv_ioda_pick_m64_pe()

't checked whether or not this has practical impact given what we later do with the bitmap - does this need to be bitmap_zalloc() to match the existing use of kzalloc()? -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

[PATCH] KVM: PPC: Fix misleading interrupts comment in kvmppc_prepare_to_enter()

interrupts itself. Fix the comment to reflect the current behaviour. Fixes: 6c85f52b10fd ("kvm/ppc: IRQ disabling cleanup") Signed-off-by: Andrew Donnellan --- arch/powerpc/kvm/powerpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/powerpc.c b/arch/p

Re: [PATCH] ocxl: sysfs.c: Replace scnprintf() with sysfs_emit()

Signed-off-by: Ryan Chung An identical patch has already been merged in char-misc-next: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20250620024705.11321-1-ankitchauhan2...@gmail.com/ Andrew -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

[PATCH v15 00/13] Support page table check on PowerPC

.@linux.ibm.com/ Andrew Donnellan (2): arm64/mm: Add addr parameter to __set_{ptes_anysz,ptes,pmds,puds}() arm64/mm: Add addr parameter to __ptep_get_and_clear_anysz() Rohan McLure (11): mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud[s]_set() mm/page_table_c

[PATCH v15 13/13] powerpc: mm: Support page table check

inux.ibm.com: rebase] Reviewed-by: Christophe Leroy Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/book3s/32/pgtable.h | 7 ++- arch/powerpc/includ

[PATCH v15 05/13] mm/page_table_check: Provide addr parameter to [__]page_table_check_ptes_set()

platforms, this can be inferred from the addr parameter. [a...@linux.ibm.com: rebase on arm64 + riscv changes, update commit message] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan --- v15: rebase, amend commit message --- arch/arm64/include/asm

[PATCH v15 04/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd[s]_set()

a Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v13: remove inaccurate comment on riscv in the commit message v14: rebase v15: rebase, amend commit message --- arch/arm64/include/asm/pgtable.h | 5 +++-- arch/riscv/include/asm/pgtable.h | 4 ++-- arch/x86/include/asm

[PATCH v15 02/13] arm64/mm: Add addr parameter to __ptep_get_and_clear_anysz()

ingly. While this parameter won't (at present) be used on arm64, this will keep the usage of the page table check interfaces consistent. Signed-off-by: Andrew Donnellan --- v15: new patch --- arch/arm64/include/asm/pgtable.h | 5 +++-- arch/arm64/mm/hugetlbpage.c | 7 --- 2 files

[PATCH v15 03/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud[s]_set()

a Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v13: remove inaccurate comment on riscv in the commit message v14: fix an x86 usage I missed (found by akpm) v15: rebase, amend commit message --- arch/arm64/include/asm/pgtable.h | 3 ++- arch/riscv/include/asm/pgta

[PATCH v15 07/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd_clear()

e pte, but instead in the address of the access. [a...@linux.ibm.com: rebase on arm64 changes] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v15: rebase --- arch/arm64/include/asm/pgtable.h | 2 +- arch/riscv/i

[PATCH v15 10/13] powerpc: mm: Add pud_pfn() stub

...@linux.ibm.com: clarify commit message] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan --- v15: clarify commit message --- arch/powerpc/include/asm/pgtable.h | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/powerpc/include/asm/pgtable.h b

[PATCH v15 12/13] powerpc: mm: Use set_pte_at_unchecked() for internal usages

: don't change to unchecked for early boot/kernel mappings] Signed-off-by: Rohan McLure Signed-off-by: Andrew Donnellan --- v13: don't use the unchecked version for early-boot kernel mappings (Pasha) --- arch/powerpc/include/asm/pgtable.h | 2 ++ arch/powerpc/mm/book3s64/pgtable.c

[PATCH v15 11/13] powerpc: mm: Implement *_user_accessible_page() for ptes

ned-off-by: Andrew Donnellan --- arch/powerpc/include/asm/book3s/32/pgtable.h | 5 + arch/powerpc/include/asm/book3s/64/pgtable.h | 17 + arch/powerpc/include/asm/nohash/pgtable.h| 5 + arch/powerpc/include/asm/pgtable.h | 8 4 files changed, 35

[PATCH v15 08/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pte_clear()

e pte, but instead in the address of the access. [a...@linux.ibm.com: rebase, fix additional occurrence and loop handling] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v13: fix an additional occurrence v15: rebase

[PATCH v15 09/13] mm: Provide address parameter to p{te,md,ud}_user_accessible_page()

provide support for page table check on powerpc. [a...@linux.ibm.com: rebase on arm64 changes] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v15: rebase --- arch/arm64/include/asm/pgtable.h | 6 +++--- arch/riscv/include

[PATCH v15 06/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_clear()

e pte, but instead in the address of the access. [a...@linux.ibm.com: rebase on arm64 changes] Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Acked-by: Ingo Molnar # x86 Signed-off-by: Andrew Donnellan --- v15: rebase --- arch/arm64/include/asm/pgtable.h | 2 +- arch/x86/include/asm

[PATCH v15 01/13] arm64/mm: Add addr parameter to __set_{ptes_anysz,ptes,pmds,puds}()

) and __set_puds(). While this parameter won't (at present) be used on arm64, this will keep the usage of the page table check interfaces consistent. Signed-off-by: Andrew Donnellan --- v15: new patch --- arch/arm64/include/asm/pgtable.h | 19 --- arch/arm64/mm/hugetlbpage.c

Re: [PATCH] misc: ocxl: Replace scnprintf() with sysfs_emit() in sysfs show functions

t Chauhan Thanks for the cleanup! Acked-by: Andrew Donnellan -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH v14 00/11] Support page table check on PowerPC

On Tue, 2025-06-10 at 09:33 +0200, Christophe Leroy wrote: > This series requires a rebase after commit 91e40668e70a > ("mm/page_table_check: Batch-check pmds/puds just like ptes") Will respin! > -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH v2 1/3] powerpc/pseries: Correct secvar format representation for static key management

ep > Signed-off-by: Srish Srinivasan > Reviewed-by: Mimi Zohar > Reviewed-by: Stefan Berger > Reviewed-by: Nayna Jain Thanks for the fixes, minor comment about the docs below. Reviewed-by: Andrew Donnellan > --- >  Documentation/ABI/testing/sysfs-secvar    | 

Re: [PATCH v2 08/14] powerpc: Handle KCOV __init vs inline mismatches

GCC's inline optimizations get resolved. > For > s390 this requires forcing a couple functions to be inline with I assume you mean powerpc here, though I'm sure my employer is happy that you're at least confusing us with IBM's other architecture :) -- Andrew DonnellanOzLabs,

Re: [PATCH 1/3] powerpc/pseries: Correct secvar format representation for static key management

explicitly in a comment that we default to static mode in the event of any weird errors. -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH 1/3] powerpc/pseries: Correct secvar format representation for static key management

ect, thus triggering the password verification. In which case, we do need to catch -EPERM. Thanks for correcting me! -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH v14 00/11] Support page table check on PowerPC

On Fri, 2025-04-11 at 15:43 +1000, Andrew Donnellan wrote: > Support page table check on all PowerPC platforms. This works by > serialising assignments, reassignments and clears of page table > entries at each level in order to ensure that anonymous mappings > have at most one writa

Re: [PATCH 1/3] powerpc/pseries: Correct secvar format representation for static key management

ION to always be world-readable, I think? In which case it shouldn't return H_AUTHORITY / -EPERM, ever, and if it does that's an error which should be handled as an error. Or am I misinterpreting the spec here? -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH 1/3] powerpc/pseries: Correct secvar format representation for static key management

dynamic would be bit confusing? I mean being static is clear, but > what they relate v1 to? Or did you mean to have "ibm,plpks-sb-static" > and "ibm,plpks-sb-dynamic"  for the two modes? > I don't feel strongly about this, as long as it's well documented. -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH 2/3] powerpc/secvar: Expose secvars relevant to the key management mode

by: Souradeep > Signed-off-by: Srish Srinivasan > Reviewed-by: Mimi Zohar > Reviewed-by: Stefan Berger I'm assuming it's been determined that there's no value in letting userspace see db/dbx/etc in a read-only way in static mode? With one comment below: Reviewe

Re: [PATCH 1/3] powerpc/pseries: Correct secvar format representation for static key management

y us, takes the form "ibm,plpks- > sb-v".Set > +// the secvar format property to either "ibm,plpks-sb-v1" or > "ibm,plpks-sb-v0", > +// based on the key management mode, and return the length of the > secvar format > +// property. > +static ssize_t plpks_secvar_format(char *buf, size_t bufsize) > +{ > + u8 mode; > + > + mode = plpks_get_sb_keymgmt_mode(); > + return snprintf(buf, bufsize, "ibm,plpks-sb-v%hhu", mode); It might be better to use something like "ibm,plpks-sb-static" in place of "ibm,plpks-sb-v0" to make it instantly clear that static mode doesn't use the same version numbering scheme as dynamic mode. >  } >   >  static int plpks_max_size(u64 *max_size) -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH 3/3] integrity/platform_certs: Allow loading of keys in static key management mode

agement mode is dynamic. > > Allow loading of the trustedcadb and moduledb keys even in the static > key management mode, where the secvar format string takes the form > "ibm,plpks-sb-v0". > > Signed-off-by: Srish Srinivasan > Reviewed-by: Mimi Zohar > Reviewed-

Re: [PATCH v13 04/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_clear()

On Thu, 2025-03-13 at 16:10 -0700, Andrew Morton wrote: > On Wed, 12 Feb 2025 03:13:57 +1100 Andrew Donnellan > wrote: > > > This reverts commit 931c38e16499 ("mm/page_table_check: remove > > unused > > parameter in [__]page_table_check_pud_clear").

[PATCH v14 06/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pte_clear()

e pte, but instead in the address of the access. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase and fix additional occurrence] Signed-off-by: Andrew Donnellan --- v13: fix an additional occurrence --- arch/arm64/include/asm/pgtable.h | 2 +- arch/riscv/include/asm/pgta

[PATCH v14 07/11] mm: Provide address parameter to p{te,md,ud}_user_accessible_page()

provide support for page table check on powerpc. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase on arm64 changes] Signed-off-by: Andrew Donnellan --- arch/arm64/include/asm/pgtable.h | 6 +++--- arch/riscv/include/asm/pgtable.h | 6 +++--- arch/x86/include/asm/pgtable.h

[PATCH v14 08/11] powerpc: mm: Add pud_pfn() stub

, include this stub as a BUILD_BUG(). Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan --- arch/powerpc/include/asm/pgtable.h | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/powerpc/include/asm/pgtable.h b/arch/powerpc/include/asm/pgtable.h

[PATCH v14 02/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd_set()

e pte, but instead in the address of the access. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase on riscv and mm/page_table_check.c changes, remove riscv commit message comment] Signed-off-by: Andrew Donnellan --- v13: remove inaccurate comment on riscv in the commit message

[PATCH v14 09/11] powerpc: mm: Implement *_user_accessible_page() for ptes

) pte_user() is no longer required to be present on all platforms as it may be equivalent to or implied by pte_read(). Hence implementations of pte_user_accessible_page() are specialised. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase and fix commit message] Signed-off-

[PATCH v14 04/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_clear()

e pte, but instead in the address of the access. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan --- arch/x86/include/asm/pgtable.h | 2 +- include/linux/page_table_check.h | 11 +++ include/linux/pgtable.h | 2 +- mm/page_tab

[PATCH v14 03/11] mm/page_table_check: Provide addr parameter to page_table_check_pte_set()

form the addr parameter. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase] Signed-off-by: Andrew Donnellan --- arch/arm64/include/asm/pgtable.h | 2 +- arch/riscv/include/asm/pgtable.h | 2 +- include/linux/page_table_check.h | 12 +++- include/linux/pgtable.h

[PATCH v14 10/11] powerpc: mm: Use set_pte_at_unchecked() for internal usages

McLure [ajd: don't change to unchecked for early boot/kernel mappings] Signed-off-by: Andrew Donnellan --- v13: don't use the unchecked version for early-boot kernel mappings (Pasha) --- arch/powerpc/include/asm/pgtable.h | 2 ++ arch/powerpc/mm/book3s64/pgtable.c | 6 ++

[PATCH v14 11/11] powerpc: mm: Support page table check

d-by: Christophe Leroy Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase] Signed-off-by: Andrew Donnellan --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/book3s/32/pgtable.h | 7 ++- arch/powerpc/include/asm/book3s/64/pgtable.h | 45

[PATCH v14 00/11] Support page table check on PowerPC

Support page table check on all PowerPC platforms. This works by serialising assignments, reassignments and clears of page table entries at each level in order to ensure that anonymous mappings have at most one writable consumer, and likewise that file-backed mappings are not simultaneously also an

[PATCH v14 01/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_set()

e pte, but instead in the address of the access. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase on riscv changes, remove riscv commit message comment] Signed-off-by: Andrew Donnellan --- v13: remove inaccurate comment on riscv in the commit message v14: fix an x86 usage I mis

[PATCH v14 05/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd_clear()

e pte, but instead in the address of the access. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan --- arch/arm64/include/asm/pgtable.h | 2 +- arch/riscv/include/asm/pgtable.h | 2 +- arch/x86/include/asm/pgtable.h | 2 +- include/linux/page_table_ch

Re: [PATCH v2 5/6] powerpc: powernv: ocxl: use lock guard for mutex

12093537.614161...@infradead.org/T/#u > > Signed-off-by: Shrikanth Hegde Acked-by: Andrew Donnellan -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH 5/6] powerpc: powenv: oxcl: use lock guard for mutex

de churn here, I would prefer > not > use it. I think this is fine. -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH 5/6] powerpc: powenv: oxcl: use lock guard for mutex

12093537.614161...@infradead.org/T/#u > > Signed-off-by: Shrikanth Hegde The subject line of this patch misspells powernv and ocxl. Otherwise this looks like a nice cleanup. -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH v13 00/11] Support page table check on PowerPC

On Wed, 2025-02-12 at 03:13 +1100, Andrew Donnellan wrote: > Support page table check on all PowerPC platforms. This works by > serialising assignments, reassignments and clears of page table > entries at each level in order to ensure that anonymous mappings > have at most one writa

Re: [PATCH] Documentation: ocxl.rst: Update consortium site

think I'd update this to say: The specification was developed by the OpenCAPI Consortium, and is now available from the `Compute Express Link Consortium <https://computeexpresslink.org/resource/opencapi-specification-archive/>_. Thanks, Andrew -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

[PATCH v3 0/1] Remove cxl driver

tate=* v1->v2: rebase and update docs v2->v3: rebase on docs changes Andrew Donnellan (1): cxl: Remove driver .../ABI/{obsolete => removed}/sysfs-class-cxl | 55 +- Documentation/arch/powerpc/cxl.rst| 470 Documentation/arch/powerpc/index.rst |

[PATCH] cxl: Fix cross-reference in documentation and add deprecation warning

as merged. Fix the cross-reference, and also add a deprecation warning. Fixes: 5731d41af924 ("cxl: Deprecate driver") Reported-by: Bagas Sanjaya Signed-off-by: Andrew Donnellan --- Maddy: can we take this by powerpc-fixes? --- Documentation/arch/powerpc/cxl.rst | 3 ++- 1 file c

Re: linux-next: build warning after merge of the powerpc tree

gt;   5731d41af924 ("cxl: Deprecate driver") > > The reference is from Documentation/arch/powerpc/cxl.rst > > I don't know why this has appeared just now. I think this warning is added by ff7ff6eb4f809 ("docs: media: Allow creating cross-references for RC ABI&

Re: [PATCH 0/9] Extend automarkup support for ABI symbols

s moved to obsolete/ by 5731d41af924b which was merged in rc1, and will be moved again to removed/ by [0]. Andrew [0] https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20250203072801.365551-3-...@linux.ibm.com/ -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

[PATCH v13 11/11] powerpc: mm: Support page table check

d-by: Christophe Leroy Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase] Signed-off-by: Andrew Donnellan --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/book3s/32/pgtable.h | 7 ++- arch/powerpc/include/asm/book3s/64/pgtable.h | 45

[PATCH v13 10/11] powerpc: mm: Use set_pte_at_unchecked() for internal usages

McLure [ajd: don't change to unchecked for early boot/kernel mappings] Signed-off-by: Andrew Donnellan --- v13: don't use the unchecked version for early-boot kernel mappings (Pasha) --- arch/powerpc/include/asm/pgtable.h | 2 ++ arch/powerpc/mm/book3s64/pgtable.c | 6 ++

[PATCH v13 09/11] powerpc: mm: Implement *_user_accessible_page() for ptes

) pte_user() is no longer required to be present on all platforms as it may be equivalent to or implied by pte_read(). Hence implementations of pte_user_accessible_page() are specialised. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase and fix commit message] Signed-off-

[PATCH v13 08/11] powerpc: mm: Add pud_pfn() stub

, include this stub as a BUILD_BUG(). Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan --- arch/powerpc/include/asm/pgtable.h | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/powerpc/include/asm/pgtable.h b/arch/powerpc/include/asm/pgtable.h

[PATCH v13 07/11] mm: Provide address parameter to p{te,md,ud}_user_accessible_page()

provide support for page table check on powerpc. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase on arm64 changes] Signed-off-by: Andrew Donnellan --- arch/arm64/include/asm/pgtable.h | 6 +++--- arch/riscv/include/asm/pgtable.h | 6 +++--- arch/x86/include/asm/pgtable.h

[PATCH v13 06/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pte_clear()

e pte, but instead in the address of the access. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase and fix additional occurrence] Signed-off-by: Andrew Donnellan --- v13: fix an additional occurrence --- arch/arm64/include/asm/pgtable.h | 2 +- arch/riscv/include/asm/pgta

[PATCH v13 05/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd_clear()

e pte, but instead in the address of the access. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan --- arch/arm64/include/asm/pgtable.h | 2 +- arch/riscv/include/asm/pgtable.h | 2 +- arch/x86/include/asm/pgtable.h | 2 +- include/linux/page_table_ch

[PATCH v13 04/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_clear()

e pte, but instead in the address of the access. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin Signed-off-by: Andrew Donnellan --- arch/x86/include/asm/pgtable.h | 2 +- include/linux/page_table_check.h | 11 +++ include/linux/pgtable.h | 2 +- mm/page_tab

[PATCH v13 02/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd_set()

e pte, but instead in the address of the access. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase on riscv and mm/page_table_check.c changes, remove riscv commit message comment] Signed-off-by: Andrew Donnellan --- v13: remove inaccurate comment on riscv in the commit message

[PATCH v13 03/11] mm/page_table_check: Provide addr parameter to page_table_check_pte_set()

form the addr parameter. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase] Signed-off-by: Andrew Donnellan --- arch/arm64/include/asm/pgtable.h | 2 +- arch/riscv/include/asm/pgtable.h | 2 +- include/linux/page_table_check.h | 12 +++- include/linux/pgtable.h

[PATCH v13 01/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_set()

e pte, but instead in the address of the access. Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin [ajd: rebase on riscv changes, remove riscv commit message comment] Signed-off-by: Andrew Donnellan --- v13: remove inaccurate comment on riscv in the commit message --- arch/arm64/include/asm

[PATCH v13 00/11] Support page table check on PowerPC

Support page table check on all PowerPC platforms. This works by serialising assignments, reassignments and clears of page table entries at each level in order to ensure that anonymous mappings have at most one writable consumer, and likewise that file-backed mappings are not simultaneously also an

[PATCH v2 0/2] Remove cxl and cxlflash drivers

driver, nor does it affect Compute Express Link (the other cxl, an amusing but unfortunate naming collision). v1: https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=436014&state=* v1->v2: rebase and update docs Andrew Donnellan (2): cxlflash: Remove driver cxl: Remove

Re: [PATCH 2/9] cxl: Constify 'struct bin_attribute'

ßschuh Acked-by: Andrew Donnellan noting that we're hoping to remove this driver shortly. -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH 1/9] ocxl: Constify 'struct bin_attribute'

ßschuh Acked-by: Andrew Donnellan -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH 0/2] Remove cxl and cxlflash drivers

On Tue, 2024-12-17 at 14:26 +1100, Michael Ellerman wrote: > It would be good to explain that this only removes support for the > original CAPI interface - not the Power9 "OpenCAPI", which is still > supported by drivers/misc/ocxl. Agreed, will mention if/when I respin this -

  1   2   3   4   5   6   7   8   9   10   >