On Thu, Aug 01, 2024 at 01:03:44PM +0530, kajoljain wrote:
>
>
> On 8/1/24 01:44, Arnaldo Carvalho de Melo wrote:
> > On Wed, Jul 31, 2024 at 04:44:49PM -0300, Arnaldo Carvalho de Melo wrote:
> >> On Fri, Jul 26, 2024 at 11:08:55AM -0300, Arnaldo Carvalho de Melo wro
On Wed, Jul 31, 2024 at 04:44:49PM -0300, Arnaldo Carvalho de Melo wrote:
> On Fri, Jul 26, 2024 at 11:08:55AM -0300, Arnaldo Carvalho de Melo wrote:
> > On Tue, Jul 23, 2024 at 09:02:23AM -0700, Ian Rogers wrote:
> > > On Mon, Jul 22, 2024 at 10:27 PM Kajol Jain wrote:
>
On Fri, Jul 26, 2024 at 11:08:55AM -0300, Arnaldo Carvalho de Melo wrote:
> On Tue, Jul 23, 2024 at 09:02:23AM -0700, Ian Rogers wrote:
> > On Mon, Jul 22, 2024 at 10:27 PM Kajol Jain wrote:
> > >
> > > Update JSON/events for power10 platform with additio
gt; >
> > Signed-off-by: Kajol Jain
>
> Reviewed-by: Ian Rogers
Thanks, applied to tmp.perf-tools-next,
- Arnaldo
> > ---
> > .../arch/powerpc/power10/frontend.json| 5 +
> > .../arch/powerpc/power10/others.json | 100 +-
>
uild-test
Before asking for review.
Please do that next time.
I'm fixing this up this time so that we can make progress.
Best regards,
- Arnaldo
> ---
> tools/perf/util/disasm.c | 143 +++
> 1 file changed, 143 insertions(+)
>
> diff --g
idely, hopefully finding and improving data structures in the
kernel.
We need to write about such cases so as to provide success stories on
using perf for data-type profiling.
Thanks for working on this!
- Arnaldo
> https://lore.kernel.org/all/6e09dc28-4a2e-49d8-a2b5-ffb3396a9...@csgroup.eu/T/
atic int disasm_line__parse_powerpc(struct disasm_line *dl)
> +{
> + char *line = dl->al.line;
> + const char **namep = >ins.name;
> + char **rawp = >ops.raw;
> + char *tmp_raw_insn, *name_raw_insn = skip_spaces(line);
> + char *name = skip_sp
at is needed for us to print them in a cross
arch way, no?
I see there is the FIXME there, ok.
- Arnaldo
> Reviewed-and-tested-by: Kajol Jain
> Reviewed-by: Namhyung Kim
> Signed-off-by: Athira Rajeev
> ---
> tools/perf/util/annotate-data.h | 4
> 1 file changed, 4 inserti
bin Du
Cc: Ingo Molnar
Cc: Jiri Olsa
Cc: Kan Liang
Cc: Peter Zijlstra
Link: https://lore.kernel.org/r/20240329215812.537846-5-namhy...@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo
>From a quick look at http://www.capstone-engine.org/compile.html it
seems PowerPC is supported
", the
> > comment mistakenly referred to "dst_multi_regs = 0". Correct it to use
> > "src_multi_regs = 0"
> >
> > Signed-off-by: Athira Rajeev
>
> Acked-by: Namhyung Kim
Cherry picked this one into perf-tools-next.
Thanks,
- Arnaldo
s/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json: text/plain;
> charset=us-ascii
Thanks, applied!
- Arnaldo
> Fixes: 0b4de7bdf46c5215 ("perf jevents: Add support for Arm CMN PMU aliasing")
> Reported-by: Arnaldo Carvalho de Melo
> Signed-off-by: Jing Zhang
> ---
> t
Em Fri, Dec 15, 2023 at 11:41:19AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Dec 15, 2023 at 11:39:14AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Mar 27, 2023 at 09:52:11AM +0530, kajoljain escreveu:
> > > > UnicodeDecodeError: 'ascii' codec can't decode
Em Fri, Dec 15, 2023 at 11:39:14AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Mar 27, 2023 at 09:52:11AM +0530, kajoljain escreveu:
> > On 3/23/23 18:41, Arnaldo Carvalho de Melo wrote:
> > > Exception processing pmu-events/arch/powerpc/power9/other.json
> > >
Em Mon, Mar 27, 2023 at 09:52:11AM +0530, kajoljain escreveu:
> On 3/23/23 18:41, Arnaldo Carvalho de Melo wrote:
> > Exception processing pmu-events/arch/powerpc/power9/other.json
> > Traceback (most recent call last):
> > File "pmu-events/jevents.py", line 997
Em Wed, Dec 06, 2023 at 10:15:06AM +0530, Athira Rajeev escreveu:
>
>
> > On 06-Dec-2023, at 3:20 AM, Arnaldo Carvalho de Melo
> > wrote:
> >
> > Em Mon, Nov 27, 2023 at 11:12:57AM +, James Clark escreveu:
> >> On 23/11/2023 16:02, Athira Rajeev wrot
Em Tue, Dec 05, 2023 at 02:09:01PM -0800, Ian Rogers escreveu:
> On Tue, Dec 5, 2023 at 1:50 PM Arnaldo Carvalho de Melo
> wrote:
> >
> > Em Mon, Nov 27, 2023 at 11:12:57AM +, James Clark escreveu:
> > > On 23/11/2023 16:02, Athira Rajeev wrote:
> > &
erf-tools-next with torvalds/master I noticed that maybe
we better have the above added line as:
+ $(call QUIET_CLEAN, tests) $(Q)$(MAKE) -f
$(srctree)/tools/perf/tests/Makefile.tests clean
No?
Anyway I'm merging as-is, but it just hit my eye while merging,
- Arnaldo
Em Mon, Dec 04, 2023 at 05:20:46PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Dec 04, 2023 at 12:12:54PM -0800, Ian Rogers escreveu:
> > On Thu, Nov 23, 2023 at 8:01 AM Athira Rajeev
> > wrote:
> > >
> > > Running "perf list" on
> Given duplicate events creates broken pmu-events.c we should capture
> that as an exception in jevents.py. That way a JEVENTS_ARCH=all build
> will fail if any vendor/architecture would break in this way. We
> should also add JEVENTS_ARCH=all to tools/perf/tests/make. Athira, do
> you want to look at doing this?
Should I go ahead and remove this patch till this is sorted out?
- Arnaldo
t; >> branch-instructions OR branches[Hardware event]
> >> branch-misses [Hardware event]
> >> Tested-by: Disha Goel
> > Thanks Disha for testing
> Hi Arnaldo,
> Can we get this pulled in if the patch looks good ?
Thanks, applied to perf-tools-next.
- Arnaldo
starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# Author:Likhitha Korrapati
# Date: Sun Nov 26 02:09:14 2023 -0500
I'm copy and pasting from the original post, thanks!
- Arnaldo
> probe libc's inet_pton & backtrace it with ping: FAILED!
>
>
Seems to work really well. I also tested it on Ubuntu, and checked
> NO_SHELLCHECK, cleaning and with and without shellcheck installed etc.
> Reviewed-by: James Clark
Tested on Fedora 38, works as advertised, applied.
- Arnaldo
Em Tue, Nov 07, 2023 at 12:08:25PM +0530, Athira Rajeev escreveu:
> > On 07-Nov-2023, at 3:14 AM, Arnaldo Carvalho de Melo
> > wrote:
> >>> Reviewed-by: James Clark
> > Some are not applying, even after b4 picking up v2
&
Em Thu, Oct 05, 2023 at 02:24:15PM +0530, Athira Rajeev escreveu:
> > On 05-Oct-2023, at 1:50 PM, James Clark wrote:
> > On 29/09/2023 05:11, Athira Rajeev wrote:
> >> Running shellcheck on tests/shell/test_arm_coresight.sh
> >> throws below warnings:
> >>
> >> In
ajeev
> >>> ---
> >>> Changelog:
> >>> v1 -> v2:
> >>> Addressed review comments from Ian. Updated size of
> >>> pmu event name variable and changed bool name which is
> >>> used to skip the test.
> >>>
> >>
s that
> > could arise when other "CONFIG_*" checks are added to Makefile.perf
> > in future as well.
> >
> > Signed-off-by: Athira Rajeev
>
> Reviewed-by: Ian Rogers
Thanks, applied.
- Arnaldo
> Thanks,
> Ian
>
> > ---
> > Change
Em Tue, Sep 05, 2023 at 05:10:37PM +0530, Kajol Jain escreveu:
> Update JSON/Events list with data-source events for power10 platform.
Thanks, applied the series.
- Arnaldo
> Signed-off-by: Kajol Jain
> ---
> .../arch/powerpc/power10/datasource.json | 1282 +
so when someone does a 'git log
--oneline' it looks like a straight dup.
Please try to provide descriptive subjects.
- Arnaldo
> Signed-off-by: Kajol Jain
> ---
> .../arch/powerpc/power10/datasource.json | 505 ++
> 1 file changed, 505 insertions(+)
>
>
Em Tue, Sep 05, 2023 at 05:10:37PM +0530, Kajol Jain escreveu:
> Update JSON/Events list with data-source events for power10 platform.
Next time could you please provide some pointer to the document from
where these metrics came if it is available online?
- Arnaldo
> Signed-off-by: Kajo
thread
> perf_event_open: No such device
>
> Result on power9 system after patch changes:
> [command]# ./perf bench breakpoint thread
> Skipping perf bench breakpoint thread: No hardware support
>
> Reported-by: Disha Goel
> Signed-off-by: Kajol Jain
Thanks,
sh_offset (Section file
> offst) of the elf header for text.
You're stating what this patch does, but not why. So far was not needed,
why now?
Probably the second patch will have the answer, but please try to add
the reason on the patch that introduces the new field.
Thanks,
- Arnal
ymbols is used by
> > function "map__rip_2objdump" which converts symbol start
> > address to objdump address. Also set the dso long_name during
> > dso__load_vmlinux function.
> >
> > Suggested-by: Adrian Hunter
> > Signed-off-by: Athira Rajeev
>
&
testcase.
I wonder if we shouldn't somehow check if the credentials needed to
performing a test shouldn't be checked before trying it. This way we
would check if the check that the tool or the kernel is doing is the
appropriate one.
I.e. the kernel refusal for doing something may be an error.
-
a requirement here:
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/pmu-events/Build?h=perf-tools-next#n30
> >>> I think we can translate:
> >>> for F in $(find tests/shell/ -perm -o=x -name '*.sh'); do shellcheck
> &
Em Fri, Jul 28, 2023 at 09:01:11AM -0700, Ian Rogers escreveu:
> On Fri, Jul 28, 2023 at 7:54 AM Arnaldo Carvalho de Melo
> wrote:
> >
> > Em Tue, Jul 25, 2023 at 11:46:49AM +0530, Aditya Gupta escreveu:
> > > Currently we depend on output of 'perf record -e "sche
ing a:
perf build --has libtraceevent
subcommand to have that query made more compact and to avoid the two
extra grep.
BTW, I'll change that to:
[acme@quaco perf-tools-next]$ perf version --build-options | grep " on .*
HAVE_LIBTRACEEVENT"
libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
[acme@quaco perf-tools-next]$
replacing "on" with OFF, so that we have just one grep.
Thanks,
- Arnaldo
> }
>
> --
> 2.41.0
>
--
- Arnaldo
Em Mon, Jul 24, 2023 at 10:28:15PM +0530, Athira Rajeev escreveu:
> perf record with callchain recording fails as below
> in powerpc:
>
> ./perf record -a -gR sleep 10
> ./perf report
> perf: Segmentation fault
>
> gdb trace points to thread__find_map
>
> 0 0x101df314
Em Wed, Jun 14, 2023 at 09:59:14AM +0800, Leo Yan escreveu:
> On Tue, Jun 13, 2023 at 04:54:08PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jun 13, 2023 at 10:11:29PM +0530, Athira Rajeev escreveu:
> > > From: Sourabh Jain
> > >
> > > Scrip
s/
/,/')
[root@quaco ~]# echo $evts
open,openat
[root@quaco ~]#
Then after:
[root@quaco ~]# evts=$(echo "$(perf list syscalls:sys_enter_open* 2>/dev/null |
grep -E 'open(at)? ' | sed -r 's/.*sys_enter_([a-z]+) +\[.*$/\1/')" | sed 's/
/,/')
[root@quaco ~]# echo $evts
open openat
[root@
l scripts.
Thanks, applied the series.
- Arnaldo
> Patches 1-14 fixes the issues found with shellcheck. Patch 15, 16
> and patch 17 address a fix in task_analyzer test.
>
> This cleanup is a pre-requisite to include a build option for shellcheck
> discussed here: https://www.spin
sage,
Thanks, applied.
- Arnaldo
> Signed-off-by: Athira Rajeev
> Signed-off-by: Kajol Jain
> Signed-off-by: Aditya Gupta
> ---
> tools/perf/tests/shell/test_task_analyzer.sh | 24 ++--
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git
in this message.
thanks!
- Arnaldo
> This issue due to ${$1} caused all function calls to give error in
> `find_str_or_fail` line, and so no test runs completely. But
> 'perf test "perf script task-analyzer tests"' wrongly reports
> that tests passed with the status OK, which is
Em Tue, Jun 13, 2023 at 10:11:29PM +0530, Athira Rajeev escreveu:
> From: Sourabh Jain
>
> Script doesn't use sys library, so remove it.
Please Cc the persons working on that file, I added Leo to the CC list
of this message.
Thanks, applied.
- Arnaldo
> Report by pylint:
>
ii
> > pmu-events/arch/powerpc/power9/other.json: application/json;
> > charset=us-ascii
> > pmu-events/arch/powerpc/power9/pipeline.json: application/json;
> > charset=us-ascii
> > pmu-events/arch/powerpc/power9/pmc.json:application/json;
>
ting for unfinished jobs
Now jevents is an opt-out feature so I'm noticing these problems.
A similar fix for s390 was accepted today:
https://lore.kernel.org/r/20230323122532.2305847-1-tmri...@linux.ibm.com
https://lore.kernel.org/r/ZBwkl77/I31AQk12@osiris
--
- Arnaldo
ide monitoring to get the data.
> > Fix this issue by changing current system wide check from true workload to
> > sleep 0.01 workload.
> >
> > Result with the patch changes in powerpc:
> >
> > 98: perf all metrics test : Ok
> >
> > Reviewed-by: Athira Rajeev
> > Tested-by: Disha Goel
> > Suggested-by: Ian Rogers
> > Signed-off-by: Kajol Jain
>
> Tested-by: Ian Rogers
>
> The mention of a4b8cfcabb1d can be moved to a Fixes tag so that this
> is backported.
Done, thanks, applied.
- Arnaldo
93,916,546,654 PM_DISP_STALL_CYC
> > 8,455,376,836,463 PM_EXEC_STALL
> >
> > "--metric-no-group" is used for forcing PM_RUN_INST_CMPL to be scheduled
> > in all group for more accuracy.
> >
> > Signed-off-by: Athira Rajeev
>
> Acked-by: Ian Rogers
Thanks, applied.
- Arnaldo
Em Mon, Feb 06, 2023 at 07:28:49PM +0530, Athira Rajeev escreveu:
>
>
> > On 05-Jan-2023, at 6:24 PM, Arnaldo Carvalho de Melo
> > wrote:
> >
> > Em Thu, Jan 05, 2023 at 05:47:42PM +0530, Athira Rajeev escreveu:
> >> Perf BPF filter test fails
Em Mon, Feb 06, 2023 at 09:27:13AM +0530, Athira Rajeev escreveu:
> > On 02-Feb-2023, at 6:27 AM, Arnaldo Carvalho de Melo
> > wrote:
> >
> > Em Tue, Jan 31, 2023 at 07:20:01PM +0530, Athira Rajeev escreveu:
> >> "bpf" tests fails in environment with
Em Thu, Jan 26, 2023 at 03:36:45PM -0800, Ian Rogers escreveu:
> Add a target that generates a log file for running metric_test.py and
> make this a dependency on generating pmu-events.c. The log output is
> displayed if the test fails like (the test was modified to make it
> fail):
>
> ```
>
Em Fri, Feb 03, 2023 at 01:02:02PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Feb 03, 2023 at 12:43:48PM -0300, Arnaldo Carvalho de Melo escreveu:
> > I tried bisecting, but at this cset:
> >
> > acme@roc-rk3399-pc:~/git/perf$ git log --oneline -1
> > d22e569c
Em Fri, Feb 03, 2023 at 12:43:48PM -0300, Arnaldo Carvalho de Melo escreveu:
> I tried bisecting, but at this cset:
>
> acme@roc-rk3399-pc:~/git/perf$ git log --oneline -1
> d22e569cd33d (HEAD) perf pmu-events: Separate the metrics from events for no
> jevents
> acme@roc-rk
Em Fri, Feb 03, 2023 at 11:43:23AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Feb 03, 2023 at 11:36:30AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Feb 03, 2023 at 11:35:29AM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Feb 03, 2023 at 11:17:3
Em Fri, Feb 03, 2023 at 11:36:30AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Feb 03, 2023 at 11:35:29AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Feb 03, 2023 at 11:17:38AM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Thu, Feb 02, 2023 at 05:41:22PM
Em Fri, Feb 03, 2023 at 11:35:29AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Feb 03, 2023 at 11:17:38AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Thu, Feb 02, 2023 at 05:41:22PM -0800, Ian Rogers escreveu:
> > > On Thu, Feb 2, 2023 at 5:40 PM
Em Fri, Feb 03, 2023 at 11:17:38AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Feb 02, 2023 at 05:41:22PM -0800, Ian Rogers escreveu:
> > On Thu, Feb 2, 2023 at 5:40 PM Ian Rogers wrote:
> > >
> > > ARM64 overrides a weak function but a previous change
t, I'll double check on my rk3399 board and
on again on the cross-build container.
- Arnaldo
>
> Thanks,
> Ian
>
> > Signed-off-by: Ian Rogers
> > ---
> > tools/perf/arch/arm64/util/pmu.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --gi
> devel. Hence perf is compiled without libtraceevent support.
Thanks, applied.
- Arnaldo
> Detailed logs:
> ./perf test -v "Basic BPF filtering"
>
> Failed to add BPF event syscalls:sys_enter_epoll_pwait
> bpf: tracepoint call back failed, stop iterate
oints, check for LIBTRACEEVENT is not done in case of perf probe.
> Hence, in environment with missing libtraceevent-devel, it is
> observed that adding a probe point shows below message though it
> can't be used via perf record.
Thanks, applied.
- Arnaldo
> Example:
> Adding
patch and ends up chopped up when I use git-am.
I'm fixing it now.
- Arnaldo
> test child forked, pid 304211
> failed to open /tmp/perf.data.Btf: No such file or directory
> test child finished with 0
> end
> probe libc's inet_pton & backtrace it with ping: Ok
>
> Fi
only a set of models are possible.
> >
> > Signed-off-by: Ian Rogers
>
> Thanks for this:
>
> Reviewed-by: John Garry
Thanks for reviewing the series John, I see there are a few patches for
which you didn't provide your Reviewed-by, are you planning to review
those as we
Em Fri, Jan 20, 2023 at 08:51:59AM +, David Laight escreveu:
> From: Arnaldo Carvalho de Melo
> > Sent: 19 January 2023 17:00
> >
> > Em Thu, Jan 19, 2023 at 03:49:15PM +, David Laight escreveu:
> > > From: Athira Rajeev
> > > > Sent: 19 Jan
000.service/memory.stat"
[root@quaco tracing]#
So you could instead replace the suggestion from:
"
You can now use it in all perf tools, such as:
perf record -e probe:vfs_getname -aR sleep 1
"
To:
"
perf is not linked with libtraceevent, to use the new probe you
; > "sh" or other shells. Above error on line number 69 that reports
> > "Bad substitution" is:
>
> Looks better - assuming it works :-)
:-)
Can I take this as an:
Acked-by: David Laight
?
- Arnaldo
n test is run from /root.
>
> The patch adds a change in build_id_cache__add to use
> copyfile_mode which also passes the file’s original mode as
> argument. This way the destination file mode also will
> be same as original file.
>
> Signed-off-by: Athira Rajeev
Thanks, applied bot
ails, we're just improving
the user reporting to make that clear at first sight.
- Arnaldo
> Test failure logs:
> <<>>
> 42: BPF filter:
> 42.1: Basic BPF filtering : Ok
> 42.2: BPF pinning : Ok
> 42.3
nc__null_lseek(void *ctx, int err, unsigned long _f_mode,
>^
> 2 errors generated.
Thanks for fixing this, I noticed the problem but didn't got around to
investigate it.
Tested and applied.
- Arnaldo
> The test code tes
Em Mon, Jan 02, 2023 at 07:12:50PM +0530, Athira Rajeev escreveu:
> > On 14-Dec-2022, at 9:21 PM, Arnaldo Carvalho de Melo > <mailto:a...@kernel.org>> wrote:
> > Em Tue, Dec 13, 2022 at 03:21:03PM +0530, Athira Rajeev escreveu:
> >>> On 13-Dec-2022, a
Em Tue, Dec 13, 2022 at 03:21:03PM +0530, Athira Rajeev escreveu:
> > On 13-Dec-2022, at 12:27 AM, Arnaldo Carvalho de Melo
> > wrote:
> > Em Thu, Nov 03, 2022 at 12:27:01PM +0530, Athira Rajeev escreveu:
> >>> On 28-Oct-2022, at 9:12 PM, Kajol Jain wrote:
>
t; > NULL);
> > parse_events_error__exit(_error);
> > + if (err == -ENOENT) {
> > + pr_debug("Failed to add events selected by BPF, debuginfo
> > package not installed\n");
> > + return TEST_SKIP;
> > + }
>
> Hi Kajol,
&g
Hence add a sanity check to see if event_open
> >> succeeds before proceeding with the test.
> >>
> >> Fixes: b20d9215a35f ("perf test: Add event group test for events in
> >> multiple PMUs")
> >> Signed-off-by: Athira Rajeev
> >
> > Acked-by: Ravi Bangoria
>
> Thanks Ravi for checking the patch
Thanks, applied.
- Arnaldo
rinting os->prefix.
>
> # ./perf stat -x, --per-socket -a -C 1 ls
> S0,1,82.11,msec,cpu-clock,82111626,100.00,1.000,CPUs utilized
> S0,1,2,,context-switches,82109314,100.00,24.358,/sec
> --
> > S0,1,,,1.71,stalled cycles per insn
Thanks, tested and
perf_event_open_cloexec_flag());
> > > - if (fd < 0)
> > > + if (fd < 0) {
> > > + fd = -errno;
> > > pr_debug("failed opening event %x\n", attr.bp_type);
> > > + }
> >
> > Do you really need that ?
> >
> > Can't you directly check errno in the caller ?
>
> errno is very easily clobbered and not clearly set on success - ie,
> it'd be better not to do that.
>
> Acked-by: Ian Rogers
Thanks, applied.
- Arnaldo
./perf stat -x, --per-socket -a -C 1 ls
> > S0,1,1.92,msec,cpu-clock,1917648,100.00,1.010,CPUs utilized
> > S0,1,54,,context-switches,1916762,100.00,28.176,K/sec
> > ---
> > S0,1,528693,,instructions,1908854,100.00,0.36,insn per cycle
> > S0,1,
Em Tue, Oct 18, 2022 at 09:24:44AM +0530, Madhavan Srinivasan escreveu:
>
> On 10/17/22 7:03 PM, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Oct 14, 2022 at 07:32:20PM +0530, Kajol Jain escreveu:
> > > Testcase stat_all_metrics.sh fails in powerpc:
> > >
> >
inator, so adding 1
> to the denominator of the metric expression as a fix.
>
> Result in powerpc box after this patch changes:
>
> 90: perf all metrics test : Ok
Looks ok, applied. Next time please try to ask others to provide a
Reviewed-by or at least an Acked-by.
- Arnaldo
>
Em Thu, Oct 06, 2022 at 09:21:48PM +0530, Athira Rajeev escreveu:
> Testcase stat+csv_output.sh fails in powerpc:
>
> 84: perf stat CSV output linter: FAILED!
Thanks, applied both patches.
- Arnaldo
Em Thu, Oct 06, 2022 at 06:16:14PM +0530, Athira Rajeev escreveu:
>
>
> > On 05-Oct-2022, at 6:05 PM, Arnaldo Carvalho de Melo
> > wrote:
> >
> > Em Wed, Oct 05, 2022 at 09:28:52AM -0300, Arnaldo Carvalho de Melo escreveu:
> >> Em Wed, Oct 05, 2022 at 1
Em Wed, Oct 05, 2022 at 09:28:52AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Oct 05, 2022 at 10:23:39AM +0530, Athira Rajeev escreveu:
> > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> > index b82844cb0ce7..cf28020798ec 100644
> >
Em Wed, Oct 05, 2022 at 10:23:39AM +0530, Athira Rajeev escreveu:
>
>
> > On 04-Oct-2022, at 11:44 PM, Arnaldo Carvalho de Melo
> > wrote:
> >
> > Em Tue, Oct 04, 2022 at 03:14:27PM -0300, Arnaldo Carvalho de Melo escreveu:
> >> Em Tue, Oct 04, 2022 a
Em Wed, Oct 05, 2022 at 10:23:39AM +0530, Athira Rajeev escreveu:
>
>
> > On 04-Oct-2022, at 11:44 PM, Arnaldo Carvalho de Melo
> > wrote:
> >
> > Em Tue, Oct 04, 2022 at 03:14:27PM -0300, Arnaldo Carvalho de Melo escreveu:
> >> Em Tue, Oct 04, 2022 a
Em Tue, Oct 04, 2022 at 03:14:27PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Oct 04, 2022 at 07:49:21AM -0700, Ian Rogers escreveu:
> > On Tue, Oct 4, 2022, 12:06 AM Athira Rajeev
> > > Thanks for helping with testing. Can I add your Tested-by for the patch ?
>
&g
Em Tue, Oct 04, 2022 at 07:49:21AM -0700, Ian Rogers escreveu:
> On Tue, Oct 4, 2022, 12:06 AM Athira Rajeev
> > Thanks for helping with testing. Can I add your Tested-by for the patch ?
> Yep.
> Tested-by: Ian Rogers
> Thanks,
> Ian
type, any. if any
> platform doesn't support the branch filters used in the test, the testcase
> will fail. In powerpc, currently mutliple branch filters are not supported
> and hence this test fails in powerpc. Fix the sanity check to look at
> the support for branch filters used in this
Em Wed, Sep 28, 2022 at 10:22:18AM +0530, Athira Rajeev escreveu:
> The testcase “vmlinux-kallsyms.c” fails in powerpc.
>
> vmlinux symtab matches kallsyms: FAILED!
Thanks, applied.
- Arnaldo
> This test look at the symbols in the vmlinux DSO
> and check if we f
gt; > The /lib/modules//build/vmlinux file has no debug information.
> > Rebuild with CONFIG_DEBUG_INFO=y, or install an appropriate debuginfo
> > package.
> > Error: Failed to add events.
> > <<>>
> >
> > Update the skip_if_no_debuginfo function
urgent]$
Opinions?
- Arnaldo
> <<>>
> 78: build id cache operations :
> test child forked, pid 01
> WARNING: wine not found. PE binaries will not be run.
> test binaries: /tmp/perf.ex.SHA1.PKz /tmp/perf.ex.MD5.Gt3
> ./tests/sh
he set_bit could
> access an array member which is out-of the array size. This
> is because currently, there is no boundary check for the CPU.
> This will result in seg fault:
Thanks, tested, reproduced the problem before, and the fix after,
applied.
- Arnaldo
> <<>>
> ./pe
test session topology: Fix test to skip the test
> > in guest environment")
> > Reported-by: Thomas Richter
> > Signed-off-by: Athira Rajeev
>
> Acked-by: Ian Rogers
Thanks, applied.
- Arnaldo
> Thanks,
> Ian
>
> > ---
> > tools/perf/tests/topology.c
>> with the patch.
> >> Tested-by: Disha Goel
> > Acked-by: Ian Rogers
> Thanks all for the review.
Thanks, applied.
- Arnaldo
sts/shell/stat_all_pmu.sh
> > +++ b/tools/perf/tests/shell/stat_all_pmu.sh
> > @@ -5,6 +5,16 @@
> > set -e
> >
> > for p in $(perf list --raw-dump pmu); do
> > + # In powerpc, skip the events for hv_24x7 and hv_gpci.
> > + # These events needs input values to be f
Em Tue, May 10, 2022 at 07:08:47PM +0530, Athira Rajeev escreveu:
>
>
> > On 06-May-2022, at 3:03 PM, Athira Rajeev
> > wrote:
> >
> >
> >
> >> On 05-May-2022, at 10:54 PM, Arnaldo Carvalho de Melo
> >> wrote:
> >>
> &
Em Fri, May 06, 2022 at 03:07:51PM +0530, Athira Rajeev escreveu:
>
>
> > On 05-May-2022, at 10:51 PM, Arnaldo Carvalho de Melo
> > wrote:
> >
> > Em Thu, May 05, 2022 at 03:30:39PM +0530, Athira Rajeev escreveu:
> >> Perf BPF filter
ols/perf/util/header.h
> index 0eb4bc29a5a4..b0f754364bd4 100644
> --- a/tools/perf/util/header.h
> +++ b/tools/perf/util/header.h
> @@ -166,4 +166,5 @@ int get_cpuid(char *buffer, size_t sz);
>
> char *get_cpuid_str(struct perf_pmu *pmu __maybe_unused);
> int strcmp_cpuid_str(const char *s1, const char *s2);
> +char *cpuinfo_field(const char *search);
> #endif /* __PERF_HEADER_H */
> --
> 2.35.1
--
- Arnaldo
bpf_testcase_table[idx].prog_id,
> -true, NULL);
> +false, NULL);
> if (ret != TEST_OK || !obj_buf || !obj_buf_sz) {
> pr_debug("Unable to get BPF object, %s\n",
>bpf_testcase_table[idx].msg_compile_fail);
> - if (idx == 0)
> + if ((idx == 0) || (ret == TEST_SKIP))
> return TEST_SKIP;
> else
> return TEST_FAIL;
> --
> 2.35.1
--
- Arnaldo
rnel to is_kallsyms
> > * move the logic to generic function
> > * remove arch-specific functions
> >
> > Thanks,
> > Namhyung
>
> Thanks Namhyung! The series:
>
> Acked-by: Ian Rogers
Thanks, applied to perf/urgent.
- Arnaldo
> > Namhyung Kim
with affinity.
Thanks, applied.
- Arnaldo
> Example snippet from numa benchmark:
> <<>>
> perf: bench/numa.c:302: bind_to_node: Assertion `!(ret)' failed.
> Aborted (core dumped)
> <<>>
>
> bind_to_node function uses "sched_getaffinity&quo
Em Sat, Apr 09, 2022 at 12:28:01PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Apr 06, 2022 at 11:21:09PM +0530, Athira Rajeev escreveu:
> > The perf benchmark for collections: numa, futex and epoll
> > hits failure in system configuration with CPU's more than 1024.
>
n the code to work with affinity.
Applied 1-3, 4 needs some reworking and can wait for v5.19, the first 3
are fixes, so can go now.
- Arnaldo
ndex 6da12e522edc..3f5fcf5d4b3f 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -983,6 +983,49 @@ static int write_dir_format(struct feat_fd *ff,
> return do_write(ff, >dir.version, sizeof(data->dir.version));
> }
>
> +#define SYSFS "/sys/
1 - 100 of 406 matches
Mail list logo
