Re: [PATCH v2] pstore: Adjust buffer size for compression for smaller registered buffers

2013-09-12 Thread Aruna Balakrishnaiah
On Thursday 12 September 2013 11:13 PM, Luck, Tony wrote: + default: + cmpr = 60; + break; + } Is this the right "default"? It may be a good choice for a backend with a really tiny buffer (1 ... 999). But less good for a (theoretical) backend with a la

[PATCH v2] pstore: Adjust buffer size for compression for smaller registered buffers

2013-09-11 Thread Aruna Balakrishnaiah
experiments with plain text for buffers of size 1k - 4k (Smaller the buffer size repeated occurence will be less) and with sample crash log for buffers ranging from 4k - 10k. Reported-by: Seiji Aguchi Signed-off-by: Aruna Balakrishnaiah --- Changes from v1: Retain the cmpr = 45 for

[PATCH 3/3] pstore: Remove the messages related to compression failure

2013-09-11 Thread Aruna Balakrishnaiah
Remove the messages indicating compression failure as it will add to the space during panic path. Reported-by: Seiji Aguchi Signed-off-by: Aruna Balakrishnaiah --- fs/pstore/platform.c |4 1 file changed, 4 deletions(-) diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index

[PATCH 2/3] pstore: Use zlib_inflateInit2 instead of zlib_inflateInit

2013-09-11 Thread Aruna Balakrishnaiah
Since zlib_deflateInit2() is used for specifying window bit during compression, zlib_inflateInit2() is appropriate for decompression. Reported-by: Seiji Aguchi Signed-off-by: Aruna Balakrishnaiah --- fs/pstore/platform.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs

[PATCH 1/3] pstore: Adjust buffer size for compression for smaller registered buffers

2013-09-11 Thread Aruna Balakrishnaiah
experiments with plain text for buffers of size 1k - 4k (Smaller the buffer size repeated occurence will be less) and with sample crash log for buffers ranging from 4k - 10k. Reported-by: Seiji Aguchi Signed-off-by: Aruna Balakrishnaiah --- fs/pstore/platform.c | 23 ++- 1

Re: [RFC PATCH v2 04/11] pstore: Add compression support to pstore

2013-09-03 Thread Aruna Balakrishnaiah
On Wednesday 04 September 2013 07:14 AM, Seiji Aguchi wrote: Aruna, Sorry for the late response. Seiji, Could you let us know the efivars buffer size with which the pstore is registered when the failure occurred. I looked into the issue today. I added some debug message just before pstore_c

Re: [RFC PATCH v2 06/11] pstore: Add decompression support to pstore

2013-08-27 Thread Aruna Balakrishnaiah
On Friday 23 August 2013 04:34 AM, Seiji Aguchi wrote: -Original Message- From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Aruna Balakrishnaiah Sent: Friday, August 16, 2013 9:18 AM To: linuxppc-...@ozlabs.org; tony.l...@intel.com

Re: [RFC PATCH v2 04/11] pstore: Add compression support to pstore

2013-08-26 Thread Aruna Balakrishnaiah
On Friday 23 August 2013 04:47 AM, Luck, Tony wrote: <1>[ 383.209057] RIP [] sysrq_handle_crash+0x16/0x20 <4>[ 383.209057] RSP <4>[ 383.209057] CR2: <4>[ 383.209057] ---[ end trace 04a1cddad37b4b33 ]--- <3>[ 383.209057] pstore: compression failed for Part 2 returned -5 <3

[RFC PATCH v2 07/11] pstore: Add file extension to pstore file if compressed

2013-08-16 Thread Aruna Balakrishnaiah
In case decompression fails, add a ".enc.z" to indicate the file has compressed data. This will help user space utilities to figure out the file contents. Signed-off-by: Aruna Balakrishnaiah --- fs/pstore/inode.c|7 --- fs/pstore/internal.h |5 +++-- fs/pstore/platfor

[RFC PATCH v2 08/11] powerpc/pseries: Read and write to the 'compressed' flag of pstore

2013-08-16 Thread Aruna Balakrishnaiah
patch adds backward compatibilty with old format oops header when reading from pstore. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c |8 1 file changed, 8 insertions(+) diff --git a/arch/powerpc/platforms/pseries/nvram.c b/arch/powerpc/platforms/pseries/nv

[RFC PATCH v2 10/11] efi-pstore: Read and write to the 'compressed' flag of pstore

2013-08-16 Thread Aruna Balakrishnaiah
In pstore write, Efi will add a character 'C'(compressed) or D'(decompressed) in its header while writing to persistent store. In pstore read, read the header and update the 'compressed' flag accordingly. Signed-off-by: Aruna Balakrishnaiah --- drivers/firmwar

[RFC PATCH v2 11/11] pstore/ram: Read and write to the 'compressed' flag of pstore

2013-08-16 Thread Aruna Balakrishnaiah
In pstore write, add character 'C'(compressed) or 'D'(decompressed) in the header while writing to Ram persistent buffer. In pstore read, read the header and update the 'compressed' flag accordingly. Signed-off-by: Aruna Balakrishnaia

[RFC PATCH v2 09/11] erst: Read and write to the 'compressed' flag of pstore

2013-08-16 Thread Aruna Balakrishnaiah
In pstore write, set the section type to CPER_SECTION_TYPE_DMESG_COMPR if the data is compressed. In pstore read, read the section type and update the 'compressed' flag accordingly. Signed-off-by: Aruna Balakrishnaiah --- drivers/acpi/apei/erst.c | 13 - 1 file c

[RFC PATCH v2 06/11] pstore: Add decompression support to pstore

2013-08-16 Thread Aruna Balakrishnaiah
Based on the flag 'compressed' set or not, pstore will decompress the data returning a plain text file. If decompression fails for a particular record it will have the compressed data in the file which can be decompressed with 'openssl' command line tool. Signed-off-by:

[RFC PATCH v2 05/11] pstore: Introduce new argument 'compressed' in the read callback

2013-08-16 Thread Aruna Balakrishnaiah
Backends will set the flag 'compressed' after reading the log from persistent store to indicate the data being returned to pstore is compressed or not. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c |2 +- drivers/acpi/apei/erst.c

[RFC PATCH v2 04/11] pstore: Add compression support to pstore

2013-08-16 Thread Aruna Balakrishnaiah
will capture the uncompressed data by making a call again to kmsg_dump with registered_buffer of registered size. Pstore will indicate the data is compressed or not with a flag in the write callback. Signed-off-by: Aruna Balakrishnaiah --- fs/pstore/platform.c | 148

[RFC PATCH v2 02/11] pstore: Add new argument 'compressed' in pstore write callback

2013-08-16 Thread Aruna Balakrishnaiah
e. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c |4 ++-- drivers/acpi/apei/erst.c |4 ++-- drivers/firmware/efi/efi-pstore.c |2 +- fs/pstore/platform.c |7 --- fs/pstore/ram.c|2 +

[RFC PATCH v2 03/11] pstore/Kconfig: Select ZLIB_DEFLATE and ZLIB_INFLATE when PSTORE is selected

2013-08-16 Thread Aruna Balakrishnaiah
Pstore will make use of deflate and inflate algorithm to compress and decompress the data. So when Pstore is enabled select zlib_deflate and zlib_inflate. Signed-off-by: Aruna Balakrishnaiah --- fs/pstore/Kconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/pstore/Kconfig b/fs

[RFC PATCH v2 01/11] powerpc/pseries: Remove (de)compression in nvram with pstore enabled

2013-08-16 Thread Aruna Balakrishnaiah
t in pstore write as 'hsize' will be removed in the subsequent patch. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c | 102 1 file changed, 12 insertions(+), 90 deletions(-) diff --git a/arch/powerpc/platforms/pseries/nvr

[RFC PATCH v2 00/11] Add (de)compression support to pstore

2013-08-16 Thread Aruna Balakrishnaiah
, efivars and persistent ram. --- Aruna Balakrishnaiah (11): powerpc/pseries: Remove (de)compression in nvram with pstore enabled pstore: Add new argument 'compressed' in pstore write callback pstore/Kconfig: Select ZLIB_DEFLATE and ZLIB_INFLATE when PSTORE is selected pst

Re: [PATCH 00/11] Add compression support to pstore

2013-08-09 Thread Aruna Balakrishnaiah
On Thursday 08 August 2013 09:38 AM, Aruna Balakrishnaiah wrote: Hi Tony, On Thursday 08 August 2013 03:52 AM, Tony Luck wrote: On Tue, Aug 6, 2013 at 10:35 PM, Tony Luck wrote: ERST is at the whim of the BIOS writer (the ACPI standard doesn't provide any suggestions on record sizes)

[PATCH 1/2] powerpc/pseries: Fix buffer overflow when reading from pstore

2013-08-08 Thread Aruna Balakrishnaiah
have 'openssl' command line tool to decompress the compressed data, dump the compressed data in case decompression fails instead of not dumping anything. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c | 70 +++- 1 file c

[PATCH 2/2] powerpc/pseries: Add backward compatibilty to read old kernel oops-log

2013-08-08 Thread Aruna Balakrishnaiah
Older kernels has just length information in their header. Handle it while reading old kernel oops log from pstore. Applies on top of powerpc/pseries: Fix buffer overflow when reading from pstore Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c | 18

Re: [PATCH 00/11] Add compression support to pstore

2013-08-07 Thread Aruna Balakrishnaiah
On Wednesday 07 August 2013 11:00 PM, Tony Luck wrote: Oh - one more thing - and my apologies for not spotting this before: dst = allocate_buf_for_compression(big_buf_sz); No - you may not call kmalloc() in oops/panic context. Please pre-allocate everything you need in some in

Re: [PATCH 00/11] Add compression support to pstore

2013-08-07 Thread Aruna Balakrishnaiah
Hi Tony, On Thursday 08 August 2013 03:52 AM, Tony Luck wrote: On Tue, Aug 6, 2013 at 10:35 PM, Tony Luck wrote: ERST is at the whim of the BIOS writer (the ACPI standard doesn't provide any suggestions on record sizes). My systems support ~6K record size. Off by a little - 7896 bytes on my

Re: [PATCH 00/11] Add compression support to pstore

2013-08-06 Thread Aruna Balakrishnaiah
Hi Tony, On Wednesday 07 August 2013 08:55 AM, Tony Luck wrote: On Tue, Aug 6, 2013 at 6:58 PM, Aruna Balakrishnaiah wrote: The patch looks right. I will clean it up. Does the issue still persist after this? Things seem to be working - but testing has hardly been extensive (just a couple of

Re: [PATCH 00/11] Add compression support to pstore

2013-08-06 Thread Aruna Balakrishnaiah
On Wednesday 07 August 2013 05:06 AM, Tony Luck wrote: On Mon, Aug 5, 2013 at 2:20 PM, Tony Luck wrote: Still have problems booting if there are any compressed images in ERST to be inflated. So I took another look at this part of the code ... and saw a couple of issues: while ((size

Re: [PATCH 00/11] Add compression support to pstore

2013-08-05 Thread Aruna Balakrishnaiah
hould have encountered same issue on Power too. Please give a final try with the patch I have attached and I will dig into this more tomorrow. Patch to be applied on top of my patch series (without your fix patch). - Aruna -Tony commit 35b489152ae8f673fa79e7eeffc0bc8503c608b6 Author: Aruna Bal

Re: [PATCH 00/11] Add compression support to pstore

2013-08-05 Thread Aruna Balakrishnaiah
Hi Tony, Thank you very much for testing my patches. On Saturday 03 August 2013 03:42 AM, Tony Luck wrote: A quick experiment to use your patchset - but with compression disabled by tweaking this line in pstore_dump(): zipped_len = -1; //zip_data(dst, hsize + len); turned out well. This

Re: [PATCH 00/11] Add compression support to pstore

2013-08-01 Thread Aruna Balakrishnaiah
Hi Tony/Kees, Could you please review and let me know your comments!! Regards, Aruna On Monday 15 July 2013 10:25 PM, Aruna Balakrishnaiah wrote: The patchset adds compression support to pstore. As the non-volatile storage space is limited, adding compression support results in capturing

[PATCH 11/11] pstore/ram: Read and write to the 'compressed' flag of pstore

2013-07-15 Thread Aruna Balakrishnaiah
In pstore write, add character 'C'(compressed) or 'D'(decompressed) in the header while writing to Ram persistent buffer. In pstore read, read the header and update the 'compressed' flag accordingly. Signed-off-by: Aruna Balakrishnaia

[PATCH 10/11] efi-pstore: Read and write to the 'compressed' flag of pstore

2013-07-15 Thread Aruna Balakrishnaiah
In pstore write, Efi will add a character 'C'(compressed) or D'(decompressed) in its header while writing to persistent store. In pstore read, read the header and update the 'compressed' flag accordingly. Signed-off-by: Aruna Balakrishnaiah --- drivers/firmwar

[PATCH 09/11] erst: Read and write to the 'compressed' flag of pstore

2013-07-15 Thread Aruna Balakrishnaiah
In pstore write, set the section type to CPER_SECTION_TYPE_DMESG_COMPR if the data is compressed. In pstore read, read the section type and update the 'compressed' flag accordingly. Signed-off-by: Aruna Balakrishnaiah --- drivers/acpi/apei/erst.c | 13 - 1 file c

[PATCH 08/11] powerpc/pseries: Read and write to the 'compressed' flag of pstore

2013-07-15 Thread Aruna Balakrishnaiah
patch adds backward compatibilty with old format oops header when reading from pstore. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c | 34 +--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/platforms/pseries/nvr

[PATCH 06/11] pstore: Provide decompression support to pstore

2013-07-15 Thread Aruna Balakrishnaiah
Based on the flag 'compressed' set or not, pstore will decompress the data returning a plain text file. If decompression fails for a particular record it will have the compressed data in the file which can be decompressed with 'openssl' command line tool. Signed-off-by:

[PATCH 07/11] pstore: Add file extension to pstore file if compressed

2013-07-15 Thread Aruna Balakrishnaiah
In case decompression fails, add a ".enc.z" to indicate the file has compressed data. This will help user space utilities to figure out the file contents. Signed-off-by: Aruna Balakrishnaiah --- fs/pstore/inode.c|9 + fs/pstore/internal.h |5 +++-- fs/pstore/

[PATCH 04/11] pstore: Add compression support to pstore

2013-07-15 Thread Aruna Balakrishnaiah
will capture the uncompressed data by making a call again to kmsg_dump with registered_buffer of registered size. Pstore will indicate the data is compressed or not with a flag in the write callback. Signed-off-by: Aruna Balakrishnaiah --- fs/pstore/platform.c | 124

[PATCH 05/11] pstore: Introduce new argument 'compressed' in the read callback

2013-07-15 Thread Aruna Balakrishnaiah
Backends will set the flag 'compressed' after reading the log from persistent store to indicate the data being returned to pstore is compressed or not. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c |2 +- drivers/acpi/apei/erst.c

[PATCH 03/11] pstore/Kconfig: Select ZLIB_DEFLATE and ZLIB_INFLATE when PSTORE is selected

2013-07-15 Thread Aruna Balakrishnaiah
Pstore will make use of deflate and inflate algorithm to compress and decompress the data. So when Pstore is enabled select zlib_deflate and zlib_inflate. Signed-off-by: Aruna Balakrishnaiah --- fs/pstore/Kconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/pstore/Kconfig b/fs

[PATCH 01/11] powerpc/pseries: Remove (de)compression in nvram with pstore enabled

2013-07-15 Thread Aruna Balakrishnaiah
t in pstore write as 'hsize' will be removed in the subsequent patch. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c | 40 1 file changed, 40 deletions(-) diff --git a/arch/powerpc/platforms/pseries/nvram.c b/arch/pow

[PATCH 02/11] pstore: Add new argument 'compressed' in pstore write callback

2013-07-15 Thread Aruna Balakrishnaiah
e. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c |4 ++-- drivers/acpi/apei/erst.c |4 ++-- drivers/firmware/efi/efi-pstore.c |2 +- fs/pstore/platform.c |7 --- fs/pstore/ram.c|2 +

[PATCH 00/11] Add compression support to pstore

2013-07-15 Thread Aruna Balakrishnaiah
ad call back. Pstore will decompress the data based on the flag and writes decompressed data to the file. Test results: Have tested the patches on powerpc/pseries. On Intel have only tested with erst backend. Efi-pstore and RAM persistent buffer requires testing. --- Aruna Balakrishnaiah

[PATCH] Add hsize argument in write_buf call of pstore_ftrace_call

2013-07-01 Thread Aruna Balakrishnaiah
Incorporate the addition of hsize argument in write_buf callback of pstore. Signed-off-by: Aruna Balakrishnaiah --- fs/pstore/ftrace.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/pstore/ftrace.c b/fs/pstore/ftrace.c index 43b1280..76a4eeb 100644 --- a/fs/pstore

Re: [PATCH 3/3] powerpc/pseries: Support compression of oops text via pstore

2013-06-27 Thread Aruna Balakrishnaiah
Hi Tony, On Tuesday 25 June 2013 09:32 PM, Luck, Tony wrote: Introducing headersize in pstore_write() API would need changes at multiple places whereits being called. The idea is to move the compression support to pstore infrastructure so that other platforms could also make use of it. Any thou

[PATCH v2 3/3] powerpc/pseries: Support compression of oops text via pstore

2013-06-27 Thread Aruna Balakrishnaiah
by pstore and last oops_data_sz bytes of big_oops_buf to NVRAM so that we have recent oops messages in lnx,oops-log. In case decompression fails, it will result in absence of oops file but still have files (in /dev/pstore) for other partitions. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc

[PATCH v2 2/3] powerpc/pseries: Re-organise the oops compression code

2013-06-27 Thread Aruna Balakrishnaiah
nvram_compress() and zip_oops() is used by the nvram_pstore_write API to compress oops messages hence re-organise the functions accordingly to avoid forward declarations. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c | 104 1

[PATCH v2 1/3] Pass header size in the pstore write callback

2013-06-27 Thread Aruna Balakrishnaiah
Header size is needed to distinguish between header and the dump data. Incorporate the addition of new argument (hsize) in the pstore write callback. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c |4 +++- drivers/acpi/apei/erst.c |4

[PATCH v2 0/3] Nvram-to-pstore: compression support for oops data

2013-06-27 Thread Aruna Balakrishnaiah
dmesg file but will still have files relating to other parititons. --- Aruna Balakrishnaiah (3): Pass header size in the pstore write callback powerpc/pseries: Re-organise the oops compression code powerpc/pseries: Support compression of oops text via pstore arch/powerpc/platforms

Re: [PATCH 3/3] powerpc/pseries: Support compression of oops text via pstore

2013-06-25 Thread Aruna Balakrishnaiah
Hi Kees, On Monday 24 June 2013 11:27 PM, Kees Cook wrote: On Sun, Jun 23, 2013 at 11:23 PM, Aruna Balakrishnaiah wrote: The patch set supports compression of oops messages while writing to NVRAM, this helps in capturing more of oops data to lnx,oops-log. The pstore file for oops messages

[PATCH v3] powerpc/pseries: Enable PSTORE in pseries_defconfig

2013-06-23 Thread Aruna Balakrishnaiah
Since now we have pstore support for nvram in pseries, enable it in the default config. With this config option enabled, pstore infra-structure will be used to read/write the messages from/to nvram. Signed-off-by: Aruna Balakrishnaiah --- v3: Move pstore config to right place v2

Re: [PATCH] powerpc/pseries: Enable PSTORE in pseries_defconfig

2013-06-23 Thread Aruna Balakrishnaiah
g is more important than "what", since you can always determine "what" is being changed, by looking at the diff. The "why" will be long forgotten. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/configs/pseries_defconfig |1 + 1 file changed, 1 insertion(+)

[PATCH v2] powerpc/pseries: Enable PSTORE in pseries_defconfig

2013-06-23 Thread Aruna Balakrishnaiah
Since now we have pstore support for nvram in pseries, enable it in the default config. With this config option enabled, pstore infra-structure will be used to read/write the messages from/to nvram. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/configs/pseries_defconfig |1 + 1 file

[PATCH 3/3] powerpc/pseries: Support compression of oops text via pstore

2013-06-23 Thread Aruna Balakrishnaiah
by pstore and last oops_data_sz bytes of big_oops_buf to NVRAM so that we have recent oops messages in lnx,oops-log. In case decompression fails, it will result in absence of oops file but still have files (in /dev/pstore) for other partitions. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc

[PATCH 1/3] Retreive header size from pstore

2013-06-23 Thread Aruna Balakrishnaiah
pstore_get_header_size will return the size of the header added by pstore while logging messages to the registered buffer. Signed-off-by: Aruna Balakrishnaiah --- fs/pstore/platform.c |7 ++- include/linux/pstore.h |6 ++ 2 files changed, 12 insertions(+), 1 deletion(-) diff

[PATCH 2/3] powerpc/pseries: Re-organise the oops compression code

2013-06-23 Thread Aruna Balakrishnaiah
nvram_compress() and zip_oops() is used by the nvram_pstore_write API to compress oops messages hence re-organise the functions accordingly to avoid forward declarations. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c | 104 1

[RESEND PATCH 0/3] Nvram-to-pstore: compression support for oops data

2013-06-23 Thread Aruna Balakrishnaiah
having the compressed data (junk) in the dmesg file it will skip and continue reading other partitions. This results in absence of dmesg file but will still have files relating to other parititons. --- Aruna Balakrishnaiah (3): Retreive header size from pstore powerpc/pseries: Re-organise

[PATCH] powerpc/pseries: Enable PSTORE in pseries_defconfig

2013-06-21 Thread Aruna Balakrishnaiah
Enable PSTORE in pseries_defconfig Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/configs/pseries_defconfig |1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig index c4dfbaf..9630a50 100644 --- a/arch

Re: [PATCH v4 0/8] Nvram-to-pstore

2013-06-18 Thread Aruna Balakrishnaiah
Hi Michael, On Wednesday 19 June 2013 11:45 AM, Michael Neuling wrote: Aruna Balakrishnaiah wrote: Currently the kernel provides the contents of p-series NVRAM only as a simple stream of bytes via /dev/nvram, which must be interpreted in user space by the nvram command in the powerpc-utils

Re: [RFC PATCH 0/3] Nvram-to-pstore: compression support for oops data

2013-06-05 Thread Aruna Balakrishnaiah
parititons. --- Aruna Balakrishnaiah (3): Retreive header size from pstore. powerpc/pseries: Re-organise the oops compression code powerpc/pseries: Support compression of oops text via pstore arch/powerpc/platforms/pseries/nvram.c | 236 +++- fs

[PATCH v4 7/8] powerpc/pseries: Read of-config partition via pstore

2013-06-05 Thread Aruna Balakrishnaiah
This patch set exploits the pstore subsystem to read details of of-config partition in NVRAM to a separate file in /dev/pstore. For instance, of-config partition details will be stored in a file named [of-nvram-5]. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc

[PATCH v4 8/8] powerpc/pseries: Read common partition via pstore

2013-06-05 Thread Aruna Balakrishnaiah
This patch exploits pstore subsystem to read details of common partition in NVRAM to a separate file in /dev/pstore. For instance, common partition details will be stored in a file named [common-nvram-6]. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc/platforms

[PATCH v4 6/8] powerpc/pseries: Distinguish between a os-partition and non-os partition

2013-06-05 Thread Aruna Balakrishnaiah
Introduce os_partition member in nvram_os_partition structure to identify if the partition is an os partition or not. This will be useful to handle non-os partitions of-config and common. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc/platforms/pseries/nvram.c

[PATCH v4 5/8] powerpc/pseries: Read rtas partition via pstore

2013-06-05 Thread Aruna Balakrishnaiah
This patch set exploits the pstore subsystem to read details of rtas partition in NVRAM to a separate file in /dev/pstore. For instance, rtas details will be stored in a file named [rtas-nvram-4]. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc/platforms/pseries

[PATCH v4 4/8] powerpc/pseries: Read/Write oops nvram partition via pstore

2013-06-05 Thread Aruna Balakrishnaiah
kmsg_dump mechanism. This patch will read/write the oops messages from/to this partition via pstore. Signed-off-by: Jim Keniston Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c | 172 +--- 1 file changed, 157 insertions(+), 15 deletion

[PATCH v4 3/8] powerpc/pseries: Introduce generic read function to read nvram-partitions

2013-06-05 Thread Aruna Balakrishnaiah
Introduce generic read function to read nvram partitions other than rtas. nvram_read_error_log will be retained which is used to read rtas partition from rtasd. nvram_read_partition is the generic read function to read from any nvram partition. Signed-off-by: Aruna Balakrishnaiah Reviewed-by

[PATCH v4 1/8] powerpc/pseries: Remove syslog prefix in uncompressed oops text

2013-06-05 Thread Aruna Balakrishnaiah
Removal of syslog prefix in the uncompressed oops text will help in capturing more oops data. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc/platforms/pseries/nvram.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms

[PATCH v4 2/8] powerpc/pseries: Add version and timestamp to oops header

2013-06-05 Thread Aruna Balakrishnaiah
headers. version is assigned 5000 (greater than oops partition size) so that existing tools will refuse to dump new style partitions as the length is too large. The updated tools will work with both old and new format headers. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston

[PATCH v4 0/8] Nvram-to-pstore

2013-06-05 Thread Aruna Balakrishnaiah
remove forward declarations of pstore callbacks - Handle return value of nvram_write_os_partition - Remove empty pstore callbacks and register pstore only when pstore is configured --- Aruna Balakrishnaiah (8): powerpc/pseries: Remove syslog prefix in uncompressed

Re: [PATCH v3 0/8] Nvram-to-pstore

2013-06-05 Thread Aruna Balakrishnaiah
On Wednesday 05 June 2013 03:13 PM, Benjamin Herrenschmidt wrote: On Wed, 2013-06-05 at 14:30 +0530, Aruna Balakrishnaiah wrote: Hi Ben, On Saturday 01 June 2013 10:55 AM, Benjamin Herrenschmidt wrote: Another question... Should the core pstore fail to unlink partitions that don't ha

Re: [PATCH v3 0/8] Nvram-to-pstore

2013-06-05 Thread Aruna Balakrishnaiah
Hi Ben, On Saturday 01 June 2013 10:55 AM, Benjamin Herrenschmidt wrote: Another question... Should the core pstore fail to unlink partitions that don't have an ->erase callback ? IE. Why would you let anyone erase the OFW common partition for example ? That means that userspace tools can no lo

Re: [PATCH 3/3] powerpc/pseries: Support compression of oops text via pstore

2013-06-04 Thread Aruna Balakrishnaiah
Hi Ben, On Saturday 01 June 2013 10:24 AM, Benjamin Herrenschmidt wrote: On Fri, 2013-04-26 at 15:26 +0530, Aruna Balakrishnaiah wrote: The patch set supports compression of oops messages while writing to NVRAM, this helps in capturing more of oops data to lnx,oops-log. The pstore file for

Re: [PATCH v3 8/8] powerpc/pseries: Read common partition via pstore

2013-06-04 Thread Aruna Balakrishnaiah
On Saturday 01 June 2013 10:22 AM, Benjamin Herrenschmidt wrote: On Thu, 2013-04-25 at 15:49 +0530, Aruna Balakrishnaiah wrote: diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c index 8d4fb65..88cc050 100644 --- a/fs/pstore/inode.c +++ b/fs/pstore/inode.c @@ -330,6 +330,9 @@ int pstore_mkfile

[PATCH 3/3] powerpc/pseries: Support compression of oops text via pstore

2013-04-26 Thread Aruna Balakrishnaiah
by pstore and last oops_data_sz bytes of big_oops_buf to NVRAM so that we have recent oops messages in lnx,oops-log. In case decompression fails, it will result in absence of oops file but still have files (in /dev/pstore) for other partitions. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc

[PATCH 2/3] powerpc/pseries: Re-organise the oops compression code

2013-04-26 Thread Aruna Balakrishnaiah
nvram_compress() and zip_oops() is used by the nvram_pstore_write API to compress oops messages hence re-organise the functions accordingly to avoid forward declarations. Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c | 104 1

[PATCH 1/3] Retreive header size from pstore.

2013-04-26 Thread Aruna Balakrishnaiah
pstore_get_header_size will return the size of the header added by pstore while logging messages to the registered buffer. Signed-off-by: Aruna Balakrishnaiah --- fs/pstore/platform.c |7 ++- include/linux/pstore.h |6 ++ 2 files changed, 12 insertions(+), 1 deletion(-) diff

[RFC PATCH 0/3] Nvram-to-pstore: compression support for oops data

2013-04-26 Thread Aruna Balakrishnaiah
having the compressed data (junk) in the dmesg file it will skip and continue reading other partitions. This results in absence of dmesg file but will still have files relating to other parititons. --- Aruna Balakrishnaiah (3): Retreive header size from pstore. powerpc/pseries: Re

[PATCH v3 8/8] powerpc/pseries: Read common partition via pstore

2013-04-25 Thread Aruna Balakrishnaiah
This patch exploits pstore subsystem to read details of common partition in NVRAM to a separate file in /dev/pstore. For instance, common partition details will be stored in a file named [common-nvram-6]. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc/platforms

[PATCH v3 6/8] powerpc/pseries: Distinguish between a os-partition and non-os partition

2013-04-25 Thread Aruna Balakrishnaiah
Introduce os_partition member in nvram_os_partition structure to identify if the partition is an os partition or not. This will be useful to handle non-os partitions of-config and common. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc/platforms/pseries/nvram.c

[PATCH v3 7/8] powerpc/pseries: Read of-config partition via pstore

2013-04-25 Thread Aruna Balakrishnaiah
This patch set exploits the pstore subsystem to read details of of-config partition in NVRAM to a separate file in /dev/pstore. For instance, of-config partition details will be stored in a file named [of-nvram-5]. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc

[PATCH v3 5/8] powerpc/pseries: Read rtas partition via pstore

2013-04-25 Thread Aruna Balakrishnaiah
This patch set exploits the pstore subsystem to read details of rtas partition in NVRAM to a separate file in /dev/pstore. For instance, rtas details will be stored in a file named [rtas-nvram-4]. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc/platforms/pseries

[PATCH v3 4/8] powerpc/pseries: Read/Write oops nvram partition via pstore

2013-04-25 Thread Aruna Balakrishnaiah
kmsg_dump mechanism. This patch will read/write the oops messages from/to this partition via pstore. Signed-off-by: Jim Keniston Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c | 172 +--- 1 file changed, 157 insertions(+), 15 deletion

[PATCH v3 3/8] powerpc/pseries: Introduce generic read function to read nvram-partitions

2013-04-25 Thread Aruna Balakrishnaiah
Introduce generic read function to read nvram partitions other than rtas. nvram_read_error_log will be retained which is used to read rtas partition from rtasd. nvram_read_partition is the generic read function to read from any nvram partition. Signed-off-by: Aruna Balakrishnaiah Reviewed-by

[PATCH v3 2/8] powerpc/pseries: Add version and timestamp to oops header

2013-04-25 Thread Aruna Balakrishnaiah
headers. version is assigned 5000 (greater than oops partition size) so that existing tools will refuse to dump new style partitions as the length is too large. The updated tools will work with both old and new format headers. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston

[PATCH v3 1/8] powerpc/pseries: Remove syslog prefix in uncompressed oops text

2013-04-25 Thread Aruna Balakrishnaiah
Removal of syslog prefix in the uncompressed oops text will help in capturing more oops data. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc/platforms/pseries/nvram.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms

[PATCH v3 0/8] Nvram-to-pstore

2013-04-25 Thread Aruna Balakrishnaiah
nvram_write_os_partition - Remove empty pstore callbacks and register pstore only when pstore is configured --- Aruna Balakrishnaiah (8): powerpc/pseries: Remove syslog prefix in uncompressed oops text powerpc/pseries: Add version and timestamp to oops header powerpc

Re: [PATCH v2 0/8] powerpc/pseries: Nvram-to-pstore

2013-04-24 Thread Aruna Balakrishnaiah
Hi Kees, On Thursday 25 April 2013 02:15 AM, Kees Cook wrote: On Tue, Apr 23, 2013 at 11:19 PM, Aruna Balakrishnaiah wrote: Currently the kernel provides the contents of p-series NVRAM only as a simple stream of bytes via /dev/nvram, which must be interpreted in user space by the nvram

Re: [PATCH v2 7/8] powerpc/pseries: Read of-config partition via pstore

2013-04-24 Thread Aruna Balakrishnaiah
On Thursday 25 April 2013 02:13 AM, Kees Cook wrote: Hi Kees, On Tue, Apr 23, 2013 at 11:20 PM, Aruna Balakrishnaiah wrote: This patch set exploits the pstore subsystem to read details of of-config partition in NVRAM to a separate file in /dev/pstore. For instance, of-config partition

[PATCH v2 8/8] powerpc/pseries: Read common partition via pstore

2013-04-23 Thread Aruna Balakrishnaiah
This patch exploits pstore subsystem to read details of common partition in NVRAM to a separate file in /dev/pstore. For instance, common partition details will be stored in a file named [common-nvram-6]. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc/platforms

[PATCH v2 7/8] powerpc/pseries: Read of-config partition via pstore

2013-04-23 Thread Aruna Balakrishnaiah
This patch set exploits the pstore subsystem to read details of of-config partition in NVRAM to a separate file in /dev/pstore. For instance, of-config partition details will be stored in a file named [of-nvram-5]. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc

[PATCH v2 6/8] powerpc/pseries: Distinguish between a os-partition and non-os partition

2013-04-23 Thread Aruna Balakrishnaiah
Introduce os_partition member in nvram_os_partition structure to identify if the partition is an os partition or not. This will be useful to handle non-os partitions of-config and common. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc/platforms/pseries/nvram.c

[PATCH v2 5/8] powerpc/pseries: Read rtas partition via pstore

2013-04-23 Thread Aruna Balakrishnaiah
This patch set exploits the pstore subsystem to read details of rtas partition in NVRAM to a separate file in /dev/pstore. For instance, rtas details will be stored in a file named [rtas-nvram-4]. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc/platforms/pseries

[PATCH v2 4/8] powerpc/pseries: Read/Write oops nvram partition via pstore

2013-04-23 Thread Aruna Balakrishnaiah
kmsg_dump mechanism. This patch will read/write the oops messages from/to this partition via pstore. Signed-off-by: Jim Keniston Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c | 172 +--- 1 file changed, 157 insertions(+), 15 deletion

[PATCH v2 3/8] powerpc/pseries: Introduce generic read function to read nvram-partitions

2013-04-23 Thread Aruna Balakrishnaiah
Introduce generic read function to read nvram partitions other than rtas. nvram_read_error_log will be retained which is used to read rtas partition from rtasd. nvram_read_partition is the generic read function to read from any nvram partition. Signed-off-by: Aruna Balakrishnaiah Reviewed-by

[PATCH v2 2/8] powerpc/pseries: Add version and timestamp to oops header

2013-04-23 Thread Aruna Balakrishnaiah
headers. version is assigned 5000 (greater than oops partition size) so that existing tools will refuse to dump new style partitions as the length is too large. The updated tools will work with both old and new format headers. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston

[PATCH v2 1/8] powerpc/pseries: Remove syslog prefix in uncompressed oops text

2013-04-23 Thread Aruna Balakrishnaiah
Removal of syslog prefix in the uncompressed oops text will help in capturing more oops data. Signed-off-by: Aruna Balakrishnaiah Reviewed-by: Jim Keniston --- arch/powerpc/platforms/pseries/nvram.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms

[PATCH v2 0/8] powerpc/pseries: Nvram-to-pstore

2013-04-23 Thread Aruna Balakrishnaiah
pstore only when pstore is configured --- Aruna Balakrishnaiah (8): powerpc/pseries: Remove syslog prefix in uncompressed oops text powerpc/pseries: Add version and timestamp to oops header powerpc/pseries: Introduce generic read function to read nvram-partitions

Re: [PATCH 4/8] Read/Write oops nvram partition via pstore

2013-04-16 Thread Aruna Balakrishnaiah
On Tuesday 16 April 2013 11:50 AM, Aruna Balakrishnaiah wrote: Currently with this patchset, pstore is not supporting compression of oops-messages since it involves some changes in the pstore framework. big_oops_buf will hold the large part of oops data which will be compressed and put to

Re: [PATCH 4/8] Read/Write oops nvram partition via pstore

2013-04-16 Thread Aruna Balakrishnaiah
On Tuesday 16 April 2013 12:44 PM, Benjamin Herrenschmidt wrote: On Tue, 2013-04-16 at 11:50 +0530, Aruna Balakrishnaiah wrote: Sure. I will have one #ifdef for declarations and one for function definitions. Declarations generally don't need #ifdef's Sorry by declarations I mean

Re: [PATCH 5/8] Read rtas partition via pstore

2013-04-15 Thread Aruna Balakrishnaiah
On Monday 15 April 2013 01:31 PM, Michael Ellerman wrote: On Wed, Apr 10, 2013 at 12:53:27PM +0530, Aruna Balakrishnaiah wrote: This patch exploits pstore infrastructure to read the details from NVRAM's rtas partition. Does that mean it's exposed in the pstore filesystem? Yeah t

Re: [PATCH 4/8] Read/Write oops nvram partition via pstore

2013-04-15 Thread Aruna Balakrishnaiah
Hi Michael, Thanks for reviewing my patches. On Monday 15 April 2013 01:25 PM, Michael Ellerman wrote: On Wed, Apr 10, 2013 at 12:53:03PM +0530, Aruna Balakrishnaiah wrote: This patch exploits pstore infrastructure in power systems. IBM's system p machines provide persistent storage for

  1   2   >