Re: [patch 01/39] PCI/MSI: Check for MSI enabled in __pci_msix_enable()

2022-11-17 Thread Ashok Raj
On Thu, Nov 17, 2022 at 02:07:33PM +0100, Thomas Gleixner wrote: > On Wed, Nov 16 2022 at 07:39, Ashok Raj wrote: > > On Fri, Nov 11, 2022 at 02:54:15PM +0100, Thomas Gleixner wrote: > > > > Can the pre-enabled checks for msi and msix be moved up before any vector > > ra

Re: [patch 02/39] iommu/vt-d: Remove bogus check for multi MSI-X

2022-11-16 Thread Ashok Raj
On Wed, Nov 16, 2022 at 06:02:30PM +0100, Thomas Gleixner wrote: > On Wed, Nov 16 2022 at 07:52, Ashok Raj wrote: > > On Fri, Nov 11, 2022 at 02:54:17PM +0100, Thomas Gleixner wrote: > >> PCI/Multi-MSI is MSI specific and not supported for MSI-X. > >> > >

Re: [patch 11/39] genirq/irqdomain: Move bus token enum into a seperate header

2022-11-16 Thread Ashok Raj
- > include/linux/irqdomain_defs.h | 26 ++ > 2 files changed, 27 insertions(+), 21 deletions(-) > for Patches 5-11: Reviewed-by: Ashok Raj

Re: [patch 04/39] genirq/msi: Use MSI_DESC_ALL in msi_add_simple_msi_descs()

2022-11-16 Thread Ashok Raj
; fail: > - msi_free_msi_descs_range(dev, MSI_DESC_NOTASSOCIATED, index, last); > + msi_free_msi_descs_range(dev, MSI_DESC_ALL, index, last); > return ret; > } > > Reviewed-by: Ashok Raj

Re: [patch 03/39] iommu/amd: Remove bogus check for multi MSI-X

2022-11-16 Thread Ashok Raj
On Fri, Nov 11, 2022 at 02:54:19PM +0100, Thomas Gleixner wrote: > PCI/Multi-MSI is MSI specific and not supported for MSI-X > > Signed-off-by: Thomas Gleixner > --- > drivers/iommu/amd/iommu.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- a/drivers/iommu/amd/iommu.c > ++

Re: [patch 02/39] iommu/vt-d: Remove bogus check for multi MSI-X

2022-11-16 Thread Ashok Raj
On Fri, Nov 11, 2022 at 02:54:17PM +0100, Thomas Gleixner wrote: > PCI/Multi-MSI is MSI specific and not supported for MSI-X. > > Signed-off-by: Thomas Gleixner > --- > drivers/iommu/intel/irq_remapping.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- a/drivers/iommu/intel

Re: [patch 01/39] PCI/MSI: Check for MSI enabled in __pci_msix_enable()

2022-11-16 Thread Ashok Raj
_info(dev, "can't enable MSI-X (MSI already enabled)\n"); > + return -EINVAL; > + } > + nit: Can the pre-enabled checks for msi and msix be moved up before any vector range check? not that it matters for how it fails, does EBUSY sound better? lo