On Mon, Jun 05, 2017 at 04:53:46PM +0800, Jisheng Zhang wrote:
> The dw_pcie_host_ops structures are never modified. Constify these
> structures such that these can be write-protected.
>
> Signed-off-by: Jisheng Zhang
Applied with Jingoo's ack to pci/host-designware for v4.13, thanks!
> ---
>
On Thu, Aug 24, 2017 at 10:57:26AM +1000, Dave Airlie wrote:
> > Yeah, maybe it's time to disconnect the "default display device" idea
> > from the VGA arbiter. I have no idea what (if any) dependencies X has
> > on the legacy VGA resources. I assume X works fine on power, where it
> > sounds lik
Tested-by: Carol L Soto
Signed-off-by: Gavin Shan
Signed-off-by: Alexey Kardashevskiy
[bhelgaas: changelog]
Signed-off-by: Bjorn Helgaas
Cc: shan.ga...@gmail.com
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 1
On Wed, Aug 30, 2017 at 02:02:06PM -0500, Bjorn Helgaas wrote:
> On Fri, Aug 11, 2017 at 06:19:33PM +1000, Alexey Kardashevskiy wrote:
> > From: Gavin Shan
> >
> > The PowerNV platform is the only user of pcibios_sriov_disable().
> > The IOV BAR could be shifted by pci
On Mon, Sep 18, 2017 at 02:26:49PM -0500, Bryant G. Ly wrote:
> When enabling SR-IOV one might want to have their
> own version of starting device drivers for the VFs.
> This patch allows for SR-IOV callers to use
> pci_bus_add_virtfn_device instead of generic
> pci_bus_add_device.
>
> When enabli
On Fri, Sep 01, 2017 at 05:27:41PM +1000, Daniel Axtens wrote:
> This patch set:
>
> - splits the default display handling out from VGA arbiter, into its
>own file and behind its own Kconfig option (and gives the functions
>better names).
>
> - adds extra detection of default devices. T
On Wed, Sep 06, 2017 at 01:21:22AM +0200, Jan H. Schönherr wrote:
> The reset argument passed to pci_iov_add_virtfn() and
> pci_iov_remove_virtfn() is always zero since commit 46cb7b1bd86fc227a
> ("PCI: Remove unused SR-IOV VF Migration support").
>
> Remove the argument together with the associat
Sorry for the long cc list. These are pretty trivial; they just remove
some unnecessary declarations across several arches.
---
Bjorn Helgaas (4):
PCI: Remove redundant pcibios_set_master() declarations
PCI: Remove redundant pci_dev, pci_bus, resource declarations
PCI: Remove
From: Bjorn Helgaas
All users of pcibios_set_master() include , which already has
a declaration. Remove the unnecessary declarations from the
files.
Signed-off-by: Bjorn Helgaas
---
arch/alpha/include/asm/pci.h |2 --
arch/cris/include/asm/pci.h|1 -
arch/frv/include/asm/pci.h
From: Bjorn Helgaas
defines struct pci_bus and struct pci_dev and includes the
struct resource definition before including . Nobody includes
directly, so they don't need their own declarations.
Remove the redundant struct pci_dev, pci_bus, resource declarations.
Signed-off-by: Bjorn He
From: Bjorn Helgaas
Remove these unused declarations:
pcibios_config_init() # never defined anywhere
pcibios_scan_root()# only defined by x86
pcibios_get_irq_routing_table()# only defined by x86
pcibios_set_irq_routing() # only defined by x86
From: Bjorn Helgaas
pdev_save_srm_config() and struct pdev_srm_saved_conf are only used in
arch/alpha/kernel/pci.c, so make them static there.
Signed-off-by: Bjorn Helgaas
---
arch/alpha/kernel/pci.c | 11 ++-
arch/alpha/kernel/pci_impl.h |8
2 files changed, 10
On Wed, Sep 27, 2017 at 01:52:55PM +1000, Daniel Axtens wrote:
> Hi Bjorn,
>
> Yes, this works:
>
> Tested-by: Daniel Axtens # arm64, ppc64-qemu-tcg
I guess I was assuming you'd pick this up, but that doesn't really
make sense because I didn't give you a signed-off-by or anything.
I'll post thi
ection (and the EFI
override) from vga_arb_device_init() to make it easier to read.
---
Bjorn Helgaas (2):
vgaarb: Select a default VGA device even if there's no legacy VGA
vgaarb: Factor out EFI and fallback default device selection
arch/powerpc/kernel/pci-common.c | 12 ---
From: Bjorn Helgaas
Daniel Axtens reported that on the HiSilicon D05 board, the VGA device is
behind a bridge that doesn't support PCI_BRIDGE_CTL_VGA, so the VGA arbiter
never selects it as the default, which means Xorg auto-detection doesn't
work.
VGA is a legacy PCI feature: a VGA
From: Bjorn Helgaas
The default VGA device is normally set in vga_arbiter_add_pci_device() when
we call it for the first enabled device that can be accessed with the
legacy VGA resources ([mem 0xa-0xb], etc.)
That default device can be overridden by an EFI device that owns the boot
On Tue, Sep 19, 2017 at 05:26:53PM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang
>
> This patch set adds ls1012a MSI and PCIe support, including driver
> and device tree nodes. The ls1046a's MSI support patch and PCIe
> driver patch has been applied, so only adds the PCIe device tree
> nodes.
>
On Fri, Sep 22, 2017 at 09:19:28AM -0500, Bryant G. Ly wrote:
> This patch adds the machine dependent call for
> pcibios_bus_add_device, since the previous patch
> separated the calls out between the PowerNV and PowerVM.
>
> The difference here is that for the PowerVM environment
> we do not want
On Fri, Sep 22, 2017 at 09:19:26AM -0500, Bryant G. Ly wrote:
> This patch series is to prepare for enabling SR-IOV
> on pseries. It separates the calls to be machine dependent
> and does not change any current functionality.
>
> The patch linked below which is currently in review is a dependency:
On Thu, Oct 12, 2017 at 03:09:53PM +1100, Michael Ellerman wrote:
> Bjorn Helgaas writes:
>
> > On Fri, Sep 22, 2017 at 09:19:28AM -0500, Bryant G. Ly wrote:
> >> This patch adds the machine dependent call for
> >> pcibios_bus_add_device, since the previous patc
[+cc Alex, Bodong, Eli, Saeed]
On Thu, Oct 12, 2017 at 02:59:23PM -0500, Bryant G. Ly wrote:
> On 10/12/17 1:29 PM, Bjorn Helgaas wrote:
> >On Thu, Oct 12, 2017 at 03:09:53PM +1100, Michael Ellerman wrote:
> >>Bjorn Helgaas writes:
> >>
> >>>On Fri, Sep 22,
On Thu, Oct 12, 2017 at 12:24:10PM +0100, Julien Thierry wrote:
> Hi Bjorn,
>
> On 06/10/17 23:24, Bjorn Helgaas wrote:
> >From: Bjorn Helgaas
> >
> >Daniel Axtens reported that on the HiSilicon D05 board, the VGA device is
> >behind a bridge that doesn't
tty sure the change above doesn't
invalidate this testing)
---
Bjorn Helgaas (2):
vgaarb: Select a default VGA device even if there's no legacy VGA
vgaarb: Factor out EFI and fallback default device selection
arch/powerpc/kernel/pci-common.c | 12
nd, and
if none are enabled, the first VGA device we find.
Link: http://lkml.kernel.org/r/20170901072744.2409-1-...@axtens.net
Tested-by: Daniel Axtens# arm64, ppc64-qemu-tcg
Tested-by: Zhou Wang # D05 Hisi Hip07, Hip08
Signed-off-by: Bjorn Helgaas
---
arch/powerpc/kernel/pci
ehavior, but it untangles the "bridge control possible" checking and
messages from the default device selection.
Tested-by: Zhou Wang # D05 Hisi Hip07, Hip08
Signed-off-by: Bjorn Helgaas
---
drivers/gpu/vga/vgaarb.c | 57 --
1 file chan
On Fri, Oct 13, 2017 at 02:12:32PM -0500, Bryant G. Ly wrote:
>
>
> On 10/13/17 1:05 PM, Alex Williamson wrote:
> >On Fri, 13 Oct 2017 07:01:48 -0500
> >Steven Royer wrote:
> >
> >>On 2017-10-13 06:53, Steven Royer wrote:
> >>>On 2017-10-12 22:
On Tue, Oct 17, 2017 at 09:33:34AM -0500, Juan Alvarez wrote:
> On 10/17/17 8:51 AM, Bjorn Helgaas wrote:
> > This is where I get confused. I guess the Linux that sets
> > PCI_SRIOV_CTRL_VFE to enable the VFs can also perform config accesses
> > to the VFs, since it can enu
ources are stored in pci_dn to avoid
> kmalloc/free.
>
> Cc: linux-...@vger.kernel.org
> Cc: Benjamin Herrenschmidt
> Cc: Bjorn Helgaas
> Signed-off-by: Alexey Kardashevskiy
Looks good to me.
Acked-by: Bjorn Helgaas
I assume this will be merged via the powerpc branch.
On Tue, Oct 17, 2017 at 12:23:01PM -0500, Juan Alvarez wrote:
> On 10/17/17 11:26 AM, Bjorn Helgaas wrote:
> > To pop back up to the top of the stack, I think the main point of this
> > patch is to keep from binding a driver to the VFs in the kernel that
> > set PCI_SRIOV_
On Tue, Oct 17, 2017 at 06:13:35PM -0500, Juan Alvarez wrote:
> On 10/17/17 1:52 PM, Bjorn Helgaas wrote:
> > I'm suggesting that maybe there should be a generic way to prevent
> > binding to VF devices that works for everybody and doesn't require any
> > arch-speci
On Tue, Oct 31, 2017 at 10:12 AM, Andy Shevchenko
wrote:
> On Fri, 2017-10-13 at 19:52 +0300, Andy Shevchenko wrote:
>> ...which makes code slightly cleaner.
>
> +Cc: Bjorn
>
> Perhaps it makes sense to pass this through PCI if no one objects?
Fine with me, but I only apply things that appear on
: Thomas Petazzoni
> Cc: Jason Cooper
> Cc: Bjorn Helgaas
> Cc: Thierry Reding
> Cc: Jonathan Hunter
> Cc: Benjamin Herrenschmidt
> Cc: Paul Mackerras
> Cc: Michael Ellerman
> Cc: linux-...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc
On Sat, Jul 15, 2017 at 11:39:45PM -0700, Bjorn Andersson wrote:
> In several dwc based drivers host_init can fail, so make sure to
> propagate and handle this to avoid continuing operation of a driver or
> hardware in an invalid state.
>
> Signed-off-by: Bjorn Andersson
Applied patches 1-3 to p
[+cc Tyrel]
On Wed, Aug 09, 2017 at 05:04:43PM -0500, Rob Herring wrote:
> On Wed, Aug 2, 2017 at 5:39 PM, Bjorn Helgaas wrote:
> > On Tue, Jul 18, 2017 at 04:43:21PM -0500, Rob Herring wrote:
> >> Now that we have a custom printf format specifier, convert users of
> >
On Fri, Aug 04, 2017 at 08:20:31PM +1000, Daniel Axtens wrote:
> Some powerpc devices provide a PCI display that isn't picked up by
> the VGA arbiter, presumably because it doesn't support the PCI
> legacy VGA ranges.
>
> Commit c2e1d84523ad ("powerpc: Set default VGA device") introduced
> an arch
On Tue, Jul 25, 2017 at 03:56:20PM +, Gabriele Paoloni wrote:
> > Having practically zero background in gfx development (either kernel or
> > Xorg), I think the problem is that vga_default_device() /
> > vga_set_default_device(), which -- apparently -- "boot_vga" is based
> > upon, come from "d
On Fri, Aug 18, 2017 at 08:05:42AM +1000, Alexey Kardashevskiy wrote:
> On 11/08/17 18:19, Alexey Kardashevskiy wrote:
> > From: Gavin Shan
> >
> > The PowerNV platform is the only user of pcibios_sriov_disable().
> > The IOV BAR could be shifted by pci_iov_update_resource(). The
> > warning mess
On Thu, Aug 17, 2017 at 09:30:28PM +1000, Daniel Axtens wrote:
> A system without PCI legacy resources (e.g. ARM64)
Can you be a little more specific about what you mean by "a system
without PCI legacy resources"? I'm not sure what the connection with
ARM64 as an architecture is.
My understandin
On Sun, Aug 20, 2017 at 12:08:20PM -0700, Benjamin Herrenschmidt wrote:
> On Sat, 2017-08-19 at 10:47 -0500, Bjorn Helgaas wrote:
> > So if ARM64 doesn't have these PCI legacy resources, does that mean an
> > ARM64 host bridge cannot generate these legacy addresses on PCI? Tha
On Mon, Aug 21, 2017 at 11:53:01AM +0100, Lorenzo Pieralisi wrote:
> On Thu, Aug 17, 2017 at 09:30:28PM +1000, Daniel Axtens wrote:
> > A system without PCI legacy resources (e.g. ARM64) may find that no
> > default/boot VGA device has been marked, because the VGA arbiter
> > checks for legacy reso
On Wed, Aug 23, 2017 at 02:48:42PM +0100, Ard Biesheuvel wrote:
> On 22 August 2017 at 23:19, Bjorn Helgaas wrote:
> > On Mon, Aug 21, 2017 at 11:53:01AM +0100, Lorenzo Pieralisi wrote:
> >> On Thu, Aug 17, 2017 at 09:30:28PM +1000, Daniel Axtens wrote:
> >> &g
ial times. But not sure which one violate the
> guide?
>
> @Bjorn Helgaas. How do you think so?
Since Lorenzo didn't point out anything specific in the patch itself,
I think he was probably referring to the subject line and this advice:
- Follow the existing convention, i.e., run "git
On Mon, Oct 16, 2023 at 12:11:04PM -0400, Frank Li wrote:
> On Mon, Oct 16, 2023 at 10:22:11AM -0500, Bjorn Helgaas wrote:
> > Obviously Lorenzo *could* edit all your subject lines on your behalf,
> > but it makes everybody's life easier if people look at the existing
>
On Fri, May 12, 2023 at 08:00:12AM +0800, Kai-Heng Feng wrote:
> There are many places that enable and disable AER interrupt, so move
> them into helpers.
>
> Reviewed-by: Mika Westerberg
> Reviewed-by: Kuppuswamy Sathyanarayanan
>
> Reviewed-by: Jonathan Cameron
> Signed-off-by: Kai-Heng Feng
[+cc powerpc, clang folks]
On Sat, Oct 28, 2023 at 08:22:54PM +0800, kernel test robot wrote:
> tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git
> controller/xilinx-xdma
> branch HEAD: 8d786149d78c7784144c7179e25134b6530b714b PCI: xilinx-xdma: Add
> Xilinx XDMA Root Port
On Tue, Oct 31, 2023 at 04:35:23AM +0800, kernel test robot wrote:
> tree/branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> branch HEAD: c503e3eec382ac708ee7adf874add37b77c5d312 Add linux-next
> specific files for 20231030
>
> Error/Warning reports:
> ...
>
On Tue, Oct 31, 2023 at 09:59:29AM -0700, Nick Desaulniers wrote:
> On Tue, Oct 31, 2023 at 7:56 AM Bjorn Helgaas wrote:
> > On Sat, Oct 28, 2023 at 08:22:54PM +0800, kernel test robot wrote:
> > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git
>
[+cc scsi, powerpc folks]
On Fri, Dec 01, 2023 at 02:44:47PM -0600, Bjorn Helgaas wrote:
> On Fri, Nov 24, 2023 at 11:09:13AM +0200, Ilpo Järvinen wrote:
> > Replace 0x7f and 0x80 literals with PCI_HEADER_TYPE_* defines.
> >
> > Signed-off-by: Ilpo Järvinen
>
> Appli
From: Bjorn Helgaas
Clean up some minor AER logging issues:
- Log as "Correctable errors", not "Corrected errors"
- Decode the Requester ID when we couldn't find detail error info
Bjorn Helgaas (3):
PCI/AER: Use 'Correctable' and 'Uncorrectable&
From: Bjorn Helgaas
The PCIe spec classifies errors as either "Correctable" or "Uncorrectable".
Previously we printed these as "Corrected" or "Uncorrected". To avoid
confusion, use the same terms as the spec.
One confusing situation is when one agen
From: Bjorn Helgaas
When a device with AER detects an error, it logs error information in its
own AER Error Status registers. It may send an Error Message to the Root
Port (RCEC in the case of an RCiEP), which logs the fact that an Error
Message was received (Root Error Status) and the
From: Bjorn Helgaas
aer_irq() reads the AER Root Error Status and Error Source Identification
(PCI_ERR_ROOT_STATUS and PCI_ERR_ROOT_ERR_SRC) registers directly into
struct aer_err_source. Both registers are 32 bits, so declare the members
explicitly as "u32" instead of &qu
[+cc Jonathan]
On Wed, Dec 06, 2023 at 04:42:28PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas
>
> Clean up some minor AER logging issues:
>
> - Log as "Correctable errors", not "Corrected errors"
>
> - Decode the Requester ID when we c
On Tue, Dec 12, 2023 at 09:00:24AM -0600, Terry Bowman wrote:
> Hi Bjorn,
>
> Will help prevent confusion. LGTM.
Thanks a lot for taking a look at these! I'd like to give you credit
in the log, e.g., "Reviewed-by: Terry Bowman ",
but I'm OCD enough that I don't want to translate "LGTM" into tha
On Tue, Jan 02, 2024 at 11:22:53AM -0800, Kuppuswamy Sathyanarayanan wrote:
> On 12/6/2023 2:42 PM, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas
> >
> > When a device with AER detects an error, it logs error information in its
> > own AER Error Status registers. It m
From: Bjorn Helgaas
Fix typos, most reported by "codespell arch/powerpc". Only touches
comments, no code changes.
Signed-off-by: Bjorn Helgaas
Cc: Nicholas Piggin
Cc: Christophe Leroy
Cc: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc/boot/Makefile | 4 ++--
ar
e.kernel.org/r/20220806085301.25142-1-rus...@russell.cc
Signed-off-by: Russell Currey
Signed-off-by: Bjorn Helgaas
diff --git a/MAINTAINERS b/MAINTAINERS
index f60dfac7661c..51def5ac9462 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15696,8 +15696,8 @@ F: drivers/pci/endpoint/
F: t
On Sat, Aug 20, 2022 at 10:17:41AM +1000, Michael Ellerman wrote:
> Bjorn Helgaas writes:
> > On Sat, Aug 06, 2022 at 06:53:01PM +1000, Russell Currey wrote:
> >> I haven't touched EEH in a long time I don't have much knowledge of the
> >> subsystem at thi
On Mon, Sep 12, 2022 at 01:09:05AM +0800, Zhuo Chen wrote:
> On 9/12/22 12:22 AM, Serge Semin wrote:
> > On Fri, Sep 02, 2022 at 02:16:32AM +0800, Zhuo Chen wrote:
> > > Status bits for ERR_NONFATAL errors only are cleared in
> > > pci_aer_clear_nonfatal_status(), but we want clear uncorrectable
>
On Fri, Sep 02, 2022 at 02:16:33AM +0800, Zhuo Chen wrote:
> When state is pci_channel_io_frozen in pcie_do_recovery(),
> the severity is fatal and fatal status should be cleared.
> So we add pci_aer_clear_fatal_status().
Seems sensible to me. Did you find this by code inspection or by
debugging
On Fri, Sep 02, 2022 at 02:16:34AM +0800, Zhuo Chen wrote:
> Statements clearing AER error status in aer_enable_rootport() has the
> same function as pci_aer_raw_clear_status(). So we replace them, which
> has no functional changes.
>
> Signed-off-by: Zhuo Chen
> ---
> drivers/pci/pcie/aer.c | 7
On Mon, Sep 26, 2022 at 09:30:48PM +0800, Zhuo Chen wrote:
> On 9/23/22 4:02 AM, Bjorn Helgaas wrote:
> > On Mon, Sep 12, 2022 at 01:09:05AM +0800, Zhuo Chen wrote:
> > > On 9/12/22 12:22 AM, Serge Semin wrote:
> > > > On Fri, Sep 02, 2022 at 02:
On Mon, Sep 26, 2022 at 10:16:23PM +0800, Zhuo Chen wrote:
> On 9/23/22 5:50 AM, Bjorn Helgaas wrote:
> > On Fri, Sep 02, 2022 at 02:16:34AM +0800, Zhuo Chen wrote:
> > > Statements clearing AER error status in aer_enable_rootport() has the
> > > same function as pci_ae
On Mon, Sep 26, 2022 at 10:01:55PM +0800, Zhuo Chen wrote:
> On 9/23/22 5:08 AM, Bjorn Helgaas wrote:
> > On Fri, Sep 02, 2022 at 02:16:33AM +0800, Zhuo Chen wrote:
> > > When state is pci_channel_io_frozen in pcie_do_recovery(),
> > > the severity is fatal and fat
On Wed, Jul 27, 2022 at 09:32:52AM +0800, Kai-Heng Feng wrote:
> PCIe service that shares IRQ with PME may cause spurious wakeup on
> system suspend.
>
> Since AER is conditionally disabled in previous patch, also apply the
> same condition to disable DPC which depends on AER to work.
>
> PCIe Ba
On Wed, Jul 27, 2022 at 09:32:51AM +0800, Kai-Heng Feng wrote:
> PCIe service that shares IRQ with PME may cause spurious wakeup on
> system suspend.
>
> PCIe Base Spec 5.0, section 5.2 "Link State Power Management" states
> that TLP and DLLP transmission is disabled for a Link in L2/L3 Ready
> (D
From: Bjorn Helgaas
Many host controller drivers #include even though they
don't need it. Remove the unnecessary #includes.
Signed-off-by: Bjorn Helgaas
---
drivers/pci/controller/cadence/pci-j721e.c | 1 -
drivers/pci/controller/dwc/pci-layerscape.c | 1 -
drivers/pci/controlle
-20221020]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/l
[+cc Pali, heads-up for trivial addition of to
pci-mvebu.c]
On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote:
> On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote:
> > Hi Bjorn,
> >
> > I love your patch! Yet something to improve:
> >
> > >> drivers/pci/controller/pci
On Thu, Oct 20, 2022 at 08:41:01AM -0500, Bjorn Helgaas wrote:
> On Thu, Oct 20, 2022 at 04:09:37PM +0800, kernel test robot wrote:
> > Hi Bjorn,
> >
> > I love your patch! Yet something to improve:
> >
> > [auto build test ERROR on helgaas-pci/next]
> >
-20221020]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/l
From: Bjorn Helgaas
pcie-altera-msi.c uses irq_domain_add_linear() and related interfaces, so
it needs but doesn't include it directly; it relies on
the fact that includes it.
But pcie-altera-msi.c *doesn't* need itself. Include
directly to remove this implicit dependency so a fu
From: Bjorn Helgaas
Many host controller drivers #include even though they
don't need it. Remove the unnecessary #includes.
v1: https://lore.kernel.org/all/20221019195452.37606-1-helg...@kernel.org/
Changes from v1 to v2:
- Include explicitly in altera-msi and microchip,
which
From: Bjorn Helgaas
pcie-microchip-host.c uses irq_domain_add_linear() and related interfaces,
so it needs but doesn't include it directly; it relies
on the fact that includes it.
But pcie-microchip-host.c *doesn't* need itself. Include
directly to remove this implicit depen
From: Bjorn Helgaas
pci-mvebu.c uses irq_domain_add_linear() and related interfaces but relies
on but doesn't include it directly; it relies on the
fact that includes it.
Include directly to remove this implicit dependency.
Signed-off-by: Bjorn Helgaas
---
drivers/pci/controlle
From: Bjorn Helgaas
Many host controller drivers #include even though they
don't need it. Remove the unnecessary #includes.
Signed-off-by: Bjorn Helgaas
---
drivers/pci/controller/cadence/pci-j721e.c | 1 -
drivers/pci/controller/dwc/pci-layerscape.c | 1 -
drivers/pci/controlle
From: Bjorn Helgaas
Many host controller drivers #include even though they
don't need it. Remove the unnecessary #includes.
v2: https://lore.kernel.org/r/20221025185147.665365-1-helg...@kernel.org/
v1: https://lore.kernel.org/r/20221019195452.37606-1-helg...@kernel.org/
Changes from v2
From: Bjorn Helgaas
pcie-altera-msi.c uses irq_domain_add_linear() and related interfaces, so
it needs but doesn't include it directly; it relies on
the fact that includes it.
But pcie-altera-msi.c *doesn't* need itself. Include
directly to remove this implicit dependency so a fu
From: Bjorn Helgaas
pcie-microchip-host.c uses irq_domain_add_linear() and related interfaces,
so it needs but doesn't include it directly; it relies
on the fact that includes it.
But pcie-microchip-host.c *doesn't* need itself. Include
directly to remove this implicit depen
From: Bjorn Helgaas
pci-mvebu.c uses irq_domain_add_linear() and related interfaces but relies
on but doesn't include it directly; it relies on the
fact that includes it.
Include directly to remove this implicit dependency.
Signed-off-by: Bjorn Helgaas
Acked-by: Thomas Peta
From: Bjorn Helgaas
pci-xgene-msi.c uses irq_domain_add_linear() and related interfaces, so it
needs but doesn't include it directly; it relies on the
fact that includes it.
But pci-xgene-msi.c *doesn't* need itself. Include
directly to remove this implicit dependency so a future
From: Bjorn Helgaas
Many host controller drivers #include even though they
don't need it. Remove the unnecessary #includes.
Signed-off-by: Bjorn Helgaas
---
drivers/pci/controller/cadence/pci-j721e.c | 1 -
drivers/pci/controller/dwc/pci-layerscape.c | 1 -
drivers/pci/controlle
On Mon, Apr 15, 2024 at 07:30:15PM +0530, Manivannan Sadhasivam wrote:
> On Fri, Apr 12, 2024 at 02:58:36PM -0500, Bjorn Helgaas wrote:
> > On Wed, Mar 27, 2024 at 02:43:31PM +0530, Manivannan Sadhasivam wrote:
> > > All of the APIs are missing the Kernel-doc comment
On Tue, Apr 16, 2024 at 12:32:24PM +0800, Kai-Heng Feng wrote:
> When the power rail gets cut off, the hardware can create some electric
> noise on the link that triggers AER. If IRQ is shared between AER with
> PME, such AER noise will cause a spurious wakeup on system suspend.
>
> When the power
On Fri, Apr 12, 2024 at 04:36:34PM +0300, Ilpo Järvinen wrote:
> pcie_read_tlp_log() handles only 4 TLP Header Log DWORDs but TLP Prefix
> Log (PCIe r6.1 secs 7.8.4.12 & 7.9.14.13) may also be present.
>
> Generalize pcie_read_tlp_log() and struct pcie_tlp_log to handle also
> TLP Prefix Log. The
h_string(ecrc_policy_str, ARRAY_SIZE(ecrc_policy_str), str);
> + i = match_string(ecrc_policy_str, str);
> if (i < 0)
> return;
>
Acked-by: Bjorn Helgaas# drivers/pci/
> +++ b/mm/vmpressure.c
> @@ -388,7 +388,7 @@ int vmpressure_register_event(str
On Wed, Jun 05, 2024 at 09:23:44PM +, Abhinav Jain wrote:
> Print the add device error in find_device_iter()
>
> Signed-off-by: Abhinav Jain
>
> PATCH v1 link :
> https://lore.kernel.org/all/20240415161055.8316-1-jain.abhinav...@gmail.com/
>
> Changes since v1:
> - Replaced pr_err() with
On Thu, Jun 06, 2024 at 12:56:35PM +0530, Manivannan Sadhasivam wrote:
> As like the 'epc_init' event, that is used to signal the EPF drivers about
> the EPC initialization, let's introduce 'epc_deinit' event that is used to
> signal EPC deinitialization.
>
> The EPC deinitialization applies only
On Thu, Apr 25, 2024 at 03:33:01PM +0800, Kai-Heng Feng wrote:
> On Fri, Apr 19, 2024 at 4:35 AM Bjorn Helgaas wrote:
> >
> > On Tue, Apr 16, 2024 at 12:32:24PM +0800, Kai-Heng Feng wrote:
> > > When the power rail gets cut off, the hardware can create some electric
>
From: Bjorn Helgaas
This is an old series from Kai-Heng that I didn't handle soon enough. The
intent is to fix several suspend/resume issues:
- Spurious wakeup from s2idle
(https://bugzilla.kernel.org/show_bug.cgi?id=216295)
- Steam Deck doesn't resume after suspend
l.org/show_bug.cgi?id=218090
Link:
https://lore.kernel.org/r/20240416043225.1462548-2-kai.heng.f...@canonical.com
Signed-off-by: Kai-Heng Feng
[bhelgaas: drop pci_ancestor_pr3_present() etc, commit log]
Signed-off-by: Bjorn Helgaas
---
drivers/pci/pcie/aer.c | 18 ++
1 file change
https://bugzilla.kernel.org/show_bug.cgi?id=218090
Link:
https://lore.kernel.org/r/20240416043225.1462548-3-kai.heng.f...@canonical.com
Signed-off-by: Kai-Heng Feng
[bhelgaas: clear status on resume, add comments, commit log]
Signed-off-by: Bjorn Helgaas
---
drivers/pci/pcie/dpc.c
hat the code should not try to invoke pci_disable_msi/msix() if its
> data structure is already freed.
s/Proposed Fix : The fix is to// ... Just say what the patch does.
If/when the powerpc folks like this, add my:
Acked-by: Bjorn Helgaas
> Cc: Michael Ellerman
> Cc: Nicholas Piggin
On Thu, Jun 27, 2024 at 10:54:17AM +1000, Alistair Popple wrote:
> The reference counts for ZONE_DEVICE private pages should be
> initialised by the driver when the page is actually allocated by the
> driver allocator, not when they are first created. This is currently
> the case for MEMORY_DEVICE_
On Tue, Feb 07, 2023 at 04:20:21PM +, Frank Li wrote:
> > Subject: Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP
> > mode support for ls1028a
> >
> > { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> > + { .compatible = "fsl,ls1028a-pcie-ep"
On Fri, Feb 10, 2023 at 11:51:46PM +0530, ALOK TIWARI wrote:
> LGTM,
Thanks a lot for looking at this!
In the Linux world, "LGTM" is not something a maintainer can really
act on. If you respond with a "Reviewed-by" tag as described here:
https://git.kernel.org/pub/scm/linux/kernel/git/torval
the errors
we can, but I'm a little wary if the spec authors thought it was
important to mask these by default.
> [1]
> https://lore.kernel.org/all/167604864163.2392965.5102660329807283871.stgit@djiang5-mobl3.local/
>
> Cc: Bjorn Helgaas
> Cc: Jonathan Cameron
> Cc:
On Wed, Mar 08, 2023 at 12:00:48PM -0800, Grant Grundler wrote:
> Ping? Did I miss an email or other work that this patch collides with?
Nope, we typically make topic branches based on -rc1, so not much
happens during the merge window. -rc1 was tagged Sunday, so things
will start appearing in -ne
On Tue, Feb 28, 2023 at 10:04:53PM -0800, Grant Grundler wrote:
> Since correctable errors have been corrected (and counted), the dmesg output
> should not be reported as a warning, but rather as "informational".
>
> Otherwise, using a certain well known vendor's PCIe parts in a USB4 docking
> sta
On Thu, Jan 12, 2023 at 02:44:33PM -0500, Frank Li wrote:
> From: Xiaowei Bao
>
> When a link down or hot reset event occurs, the PCI Express EP
> controller's Link Capabilities Register should retain the values of
> the Maximum Link Width and Supported Link Speed configured by RCW.
Can you rewo
501 - 600 of 882 matches
Mail list logo
