Re: [PATCH v2 1/3] init/main.c: Give init_task a canary

2014-09-11 Thread Chuck Ebbert
On Wed, 10 Sep 2014 14:29:33 +0100 Aaron Tomlin atom...@redhat.com wrote: On Wed, Sep 10, 2014 at 02:26:54AM -0500, Chuck Ebbert wrote: And has this been tested on parisc and metag, which use STACK_GROWSUP ? I can't see how end_of_stack() as it's defined now could work on those archs

Re: [PATCH v3 0/3] sched: Always check the integrity of the canary

2014-09-11 Thread Chuck Ebbert
On Thu, 11 Sep 2014 16:02:45 + David Laight david.lai...@aculab.com wrote: From: Aaron Tomlin Currently in the event of a stack overrun a call to schedule() does not check for this type of corruption. This corruption is often silent and can go unnoticed. However once the corrupted

Re: [PATCH v2 1/3] init/main.c: Give init_task a canary

2014-09-10 Thread Chuck Ebbert
On Tue, 9 Sep 2014 10:42:27 +0100 Aaron Tomlin atom...@redhat.com wrote: +void task_stack_end_magic(struct task_struct *tsk) +{ + unsigned long *stackend; + + stackend = end_of_stack(tsk); + *stackend = STACK_END_MAGIC;/* for overflow detection */ +} + For clarity this

Re: [PATCH] fix idr_get_new_above id alias bugs

2007-07-12 Thread Chuck Ebbert
On 07/12/2007 05:35 PM, Andrew Morton wrote: With this patch, idr.c should work as advertised allocating id values in the range 0...0x7fff. Andrew had speculated that it should allow the full range 0...0x to be used. I was tempted to make changes to allow this, but it would