addr,len) readsl(port,addr,len)
> -#define __ide_mm_outsw(port,addr,len)writesw(port,addr,len)
> -#define __ide_mm_outsl(port,addr,len)writesl(port,addr,len)
> -
> -#endif /* __KERNEL__ */
> -
> -#endif /* __ASMARM_IDE_H */
--
Damien Le Moal
Western Digital Research
#include
> ata: pata_gayle: Remove #include
> m68k: Remove
Applied to libata for-6.6. Thanks !
--
Damien Le Moal
Western Digital Research
ne inode_ctime_get()
? Also, inode_set_ctime() & inode_get_ctime() may be a little more natural. But
no strong opinion about that though.
--
Damien Le Moal
Western Digital Research
o that safely though, we'll need to eradicate raw
> accesses of the inode->i_ctime field from the kernel.
>
> Add new accessor functions for the ctime that we use to replace them.
>
> Reviewed-by: Jan Kara
> Reviewed-by: Luis Chamberlain
> Signed-off-by: Jeff Layt
_dir, struct dentry
> *old_dentry,
> + struct inode *new_dir, struct dentry *new_dentry);
> extern int simple_rename_exchange(struct inode *old_dir, struct dentry
> *old_dentry,
> struct inode *new_dir, struct dentry
> *new_dentry);
> extern int simple_rename(struct mnt_idmap *, struct inode *,
--
Damien Le Moal
Western Digital Research
On 7/6/23 03:58, Jeff Layton wrote:
> Now that everything in-tree is converted to use the accessor functions,
> rename the i_ctime field in the inode to discourage direct access.
>
> Signed-off-by: Jeff Layton
Looks OK to me.
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Wes
On 2022/05/04 22:44, Andy Shevchenko wrote:
> Switch mpc5xxx_get_bus_frequency() to use fwnode in order to help
> cleaning up other parts of the kernel from OF specific code.
>
> No functional change intended.
>
> Signed-off-by: Andy Shevchenko
For the pata bits,
Acked-
| 5 +
> drivers/tty/serial/pmac_zilog.c | 7 ++-
> sound/aoa/soundbus/i2sbus/core.c | 4 +---
> 10 files changed, 11 insertions(+), 32 deletions(-)
For the ata bits:
Acked-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
ata_dev_warn(dev, "%s is not supported for %s\n",
>modestr, list[i]);
Looks good to me.
Acked-by: Damien Le Moal# drivers/ata/
--
Damien Le Moal
Western Digital Research
c6829f5c...@roeck-us.net/
> Reported-by: Doru Iorgulescu
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218858
> Signed-off-by: Michael Ellerman
> Reviewed-by: Christoph Hellwig
Looks good.
Reviewed-by: Damien Le Moal
> ---
> drivers/ata/pata_macio.c | 9 ++-
xes: 7437bb73f087 ("block: remove support for the host aware zone model")
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
true;
> +
> + /*
> + * Per ZBC and ZAC specifications, writes in sequential write required
> + * zones of host-managed devices must be aligned to the device physical
> + * block size.
> + */
> + lim->zone_write_granularity = sdkp->physical_block_size;
>
> /* READ16/WRITE16/SYNC16 is mandatory for ZBC devices */
> sdkp->device->use_16_for_rw = 1;
--
Damien Le Moal
Western Digital Research
k);
> loop_sysfs_exit(lo);
> /* let user-space know about this change */
Otherwise, looks OK to me.
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
Hellwig
Looks OK to me.
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
nderlying block size */
> - bsize = bdev_logical_block_size(inode->i_sb->s_bdev);
> - else
> - bsize = 512;
> -
> - error = loop_reconfigure_limits(lo, bsize);
> + error = loop_reconfigure_limits(lo, config->block_size);
> if (WARN_ON_ONCE(error))
> goto out_unlock;
>
--
Damien Le Moal
Western Digital Research
e the below "if" ? (backing_dev declaration can go
there too).
> if (!bsize)
> - bsize = loop_default_blocksize(lo, inode->i_sb->s_bdev);
> + bsize = loop_default_blocksize(lo, backing_bdev);
>
> lim = queue_limits_start_update(lo->lo_queue);
> lim.logical_block_size = bsize;
--
Damien Le Moal
Western Digital Research
On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> This prepares for moving the rotational flag into the queue_limits and
> also fixes it for the case where the loop device is backed by a block
> device.
>
> Signed-off-by: Christoph Hellwig
Looks good to me.
Reviewed-by:
On 6/11/24 2:52 PM, Christoph Hellwig wrote:
> On Tue, Jun 11, 2024 at 02:51:24PM +0900, Damien Le Moal wrote:
>>> - if (lim->zoned)
>>> + if (sdkp->device->type == TYPE_ZBC)
>>
>> Nit: use sd_is_zoned() here ?
>
> Yes.
>
>>&g
gt;zoned) {
lim->max_open_zones = 0;
lim->max_active_zones = 0;
lim->zone_write_granularity = 0;
lim->max_zone_append_sectors = 0
return 0;
}
But then we would not see "bad" drivers. Co
On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> virtblk_update_cache_mode boils down to a single call to
> blk_queue_write_cache. Remove it in preparation for moving the cache
> control flags into the queue_limits.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Damien Le Moal
On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> Move setting the cache control flags in nbd in preparation for moving
> these flags into the queue_limits structure.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
that removal of xlvbd_flush() as well ?
And it feels like the "stop disabling cache flushes when they fail" part should
be a fix patch sent separately...
Anyway, for both parts, feel free to add:
Reviewed-by: Damien Le Moal
> ---
> drivers/block/xen-blkfront.c | 29
ristoph Hellwig
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> Fold blk_flush_policy into the only caller to prepare for pending changes
> to it.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
+/* flags set by the driver in queue_limits.features */
> +enum {
> + /* supports a a volatile write cache */
Repeated "a".
> + BLK_FEAT_WRITE_CACHE= (1u << 0),
> +
> + /* supports passing on the FUA bit */
> + BLK_FEAT_FUA= (1u << 1),
> +};
> +static inline bool blk_queue_write_cache(struct request_queue *q)
> +{
> + return (q->limits.features & BLK_FEAT_WRITE_CACHE) &&
> + (q->limits.flags & BLK_FLAGS_WRITE_CACHE_DISABLED);
Hmm, shouldn't this be !(q->limits.flags & BLK_FLAGS_WRITE_CACHE_DISABLED) ?
> +}
> +
> static inline bool bdev_write_cache(struct block_device *bdev)
> {
> - return test_bit(QUEUE_FLAG_WC, &bdev_get_queue(bdev)->queue_flags);
> + return blk_queue_write_cache(bdev_get_queue(bdev));
> }
>
> static inline bool bdev_fua(struct block_device *bdev)
> {
> - return test_bit(QUEUE_FLAG_FUA, &bdev_get_queue(bdev)->queue_flags);
> + return bdev_get_queue(bdev)->limits.features & BLK_FEAT_FUA;
> }
>
> static inline bool bdev_nowait(struct block_device *bdev)
--
Damien Le Moal
Western Digital Research
cally inherited in blk_stack_limits matching the
> existing behavior in dm and md.
>
> Signed-off-by: Christoph Hellwig
Other than that, looks good to me.
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
removes code from dm to clear the flag based on
> the underlying devices, which can't be reached as dm devices will
> always start out without the flag set.
>
> Signed-off-by: Christoph Hellwig
Other than that, looks OK to me.
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
block layer thing rather than a device characteristic,
no ?
>
> Simplify md and dm to set the flag unconditionally instead of avoiding
> setting a simple flag for cases where it already is set by other means,
> which is a bit pointless.
>
> Signed-off-by: Christoph Hellwig
--
s
> the code in dm, and fixed md which previously did not pass on the flag
> set on lower devices.
>
> Signed-off-by: Christoph Hellwig
Other than the nit above, looks OK to me.
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> Move the synchronous flag into the queue_limits feature field so that it
> can be set atomically and all I/O is frozen when changing the flag.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Damien Le Moal
--
Da
t; if (dm_table_supports_nowait(t))
> - blk_queue_flag_set(QUEUE_FLAG_NOWAIT, q);
> - else
> - blk_queue_flag_clear(QUEUE_FLAG_NOWAIT, q);
> + limits->features &= ~BLK_FEAT_NOWAIT;
Shouldn't you set the flag here instead of clearing it ?
--
Damien Le Moal
Western Digital Research
On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> Move the dax flag into the queue_limits feature field so that it
> can be set atomically and all I/O is frozen when changing the flag.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Damien Le Moal
--
Damien Le
device feature makes it OK to have poll (and io_stat) as a feature rather than
a flag.
So:
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> Move the boolean zoned field into the flags field to reclaim a little
> bit of space.
Nit: flags -> feature flags
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> Move the zone_resetall flag into the queue_limits feature field so that
> it can be set atomically and all I/O is frozen when changing the flag.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Wes
On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> Move the pci_p2pdma flag into the queue_limits feature field so that it
> can be set atomically and all I/O is frozen when changing the flag.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Wes
On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> Move the skip_tagset_quiesce flag into the queue_limits feature field so
> that it can be set atomically and all I/O is frozen when changing the
> flag.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Damien Le Moal
--
Damien
On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> Move the bounce field into the flags field to reclaim a little bit of
s/flags/feature
> space.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
On 6/13/24 18:39, Christoph Hellwig wrote:
> On Tue, Jun 11, 2024 at 02:51:24PM +0900, Damien Le Moal wrote:
>>> + if (sdkp->device->type == TYPE_ZBC)
>>
>> Nit: use sd_is_zoned() here ?
>
> Actually - is there much in even keeping sd_is_zoned now that the
&g
On 6/17/24 13:53, Christoph Hellwig wrote:
> On Mon, Jun 17, 2024 at 08:01:04AM +0900, Damien Le Moal wrote:
>> On 6/13/24 18:39, Christoph Hellwig wrote:
>>> On Tue, Jun 11, 2024 at 02:51:24PM +0900, Damien Le Moal wrote:
>>>>> + if (sdkp->device->type == T
On 6/17/24 15:04, Christoph Hellwig wrote:
> Move a bit of code that sets up the zone flag and the write granularity
> into sd_zbc_read_zones to be with the rest of the zoned limits.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Damien Le Moal
--
Damien Le
common code.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Hannes Reinecke
> Reviewed-by: Bart Van Assche
Looks good to me.
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
;
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Hannes Reinecke
> Reviewed-by: Bart Van Assche
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
nderlying devices.
>
> Signed-off-by: Christoph Hellwig
> Acked-by: Ulf Hansson [mmc]
A few nits below. With these fixed,
Reviewed-by: Damien Le Moal
> +Implementation details for bio based block drivers
> +--
> +
> +For
ready is set by other means,
> which is a bit pointless.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
the features is not
> supported by any of the underlying devices.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
ORM
> help
> This option enables support for generic directly connected ATA
> devices commonly found on embedded systems with OpenFirmware
>
> and then also drop the "select HAVE_PATA_PLATFORM" from
> arm64 and arm/versatile.
>
> Or we can go one step further, and either split out the
> 'pata_platform_driver' into a separate file from
> '__pata_platform_probe', or merge pata_of_platform.c
> back into pata_platform.c.
>
> Arnd
--
Damien Le Moal
Western Digital Research
On 2022/09/11 21:41, Arnd Bergmann wrote:
> On Sun, Sep 11, 2022, at 1:54 PM, Damien Le Moal wrote:
>> On 2022/09/09 20:31, Arnd Bergmann wrote:
>>>
>>> config PATA_PLATFORM
>>> - tristate "Generic platform device PATA support"
>>
dev_err()
calls and fix blank lines in fsl_sata_rx_watermark_store().
Reported-by: kernel test robot
Signed-off-by: Damien Le Moal
---
drivers/ata/sata_fsl.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
On 2/8/22 15:46, Damien Le Moal wrote:
> Use the %u format for unsigned int parameters handling with sscanf() and
> sysfs_emit() to avoid compilation warnings. In
> fsl_sata_rx_watermark_store(), the call to sscanf() to parse a single
> argument is replaced with a call to kstrtouint()
t;%d\n", vhost->log_level);
> + len = sysfs_emit(buf, "%d\n", vhost->log_level);
> spin_unlock_irqrestore(shost->host_lock, flags);
> return len;
> }
> @@ -3509,7 +3509,7 @@ static ssize_t ibmvfc_show_scsi_channels(struct device
> *dev,
> int len;
>
> spin_lock_irqsave(shost->host_lock, flags);
> - len = snprintf(buf, PAGE_SIZE, "%d\n", vhost->client_scsi_channels);
> + len = sysfs_emit(buf, "%d\n", vhost->client_scsi_channels);
> spin_unlock_irqrestore(shost->host_lock, flags);
> return len;
> }
--
Damien Le Moal
Western Digital Research
ugzilla.kernel.org if you don't have
>> a better place to put them.
>>
>> You could attach the kernel config there, too, since it didn't make it
>> to the mailing list (vger may discard them -- see
>> http://vger.kernel.org/majordomo-info.html).
>
> Bjorn and I looked at which commits that went with a recent Pull Request
> from us might be causing this, but we are a little bit at loss, and were
> hoping that you could give us a hand in troubleshooting this.
>
> Thank you in advance!
>
> Krzysztof
>
>
--
Damien Le Moal
Western Digital Research
On 2020/10/10 4:52, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> The kmap() calls in this FS are localized to a single thread. To avoid
> the over head of global PKRS updates use the new kmap_thread() call.
>
> Cc: Damien Le Moal
> Cc: Naohiro Aota
> Signed-off-by
els this must be at least 64K. However the
> - * hardware can't handle 64K, so pata_macio_qc_prep() will split large
> - * requests.
> - */
> - .max_segment_size = SZ_64K,
> + .max_segment_size = MAX_SEGMENT_SIZE,
> .device_configure = pata_macio_device_configure,
> .sdev_groups= ata_common_sdev_groups,
> .can_queue = ATA_DEF_QUEUE,
--
Damien Le Moal
Western Digital Research
t; /* Should never happen according to Tejun */
> - BUG_ON(!pi);
> + if (WARN_ON_ONCE(!pi))
> + return AC_ERR_OTHER;
>
> /* Convert the last command to an input/output */
> table--;
--
Damien Le Moal
Western Digital Research
Closes:
> https://lore.kernel.org/all/3b6441b8-06e6-45da-9e55-f92f2c869...@ufal.mff.cuni.cz/
> Tested-by: Kolbjørn Barmen
> Signed-off-by: Michael Ellerman
Applied to for-6.11-fixes. Thanks !
--
Damien Le Moal
Western Digital Research
m to keep running.
>
> Signed-off-by: Michael Ellerman
Applied to for-6.11-fixes. Thanks !
--
Damien Le Moal
Western Digital Research
57 matches
Mail list logo
