Re: [PATCH 5/8] drivers: firmware: efi: libstub: enable generic commandline

2023-12-12 Thread Daniel Walker (danielwa)
On Tue, Dec 12, 2023 at 10:55:33AM +0100, Ard Biesheuvel wrote: > On Fri, 10 Nov 2023 at 02:39, Daniel Walker wrote: > > > > This adds code to handle the generic command line changes. > > The efi code appears that it doesn't benefit as much from this design > >

Re: [PATCH 7/8] of: replace command line handling

2023-11-16 Thread Daniel Walker (danielwa)
On Thu, Nov 16, 2023 at 10:09:36AM -0600, Rob Herring wrote: > On Thu, Nov 09, 2023 at 05:38:11PM -0800, Daniel Walker wrote: > > Rob Herring has complained about this section of code. I removed the > > command line handling code to the cmdline.h header. This hopefully makes > &

Re: [PATCH 0/8] generic command line v6

2023-11-09 Thread Daniel Walker (danielwa)
On Thu, Nov 09, 2023 at 05:51:42PM -0800, Andrew Morton wrote: > On Thu, 9 Nov 2023 17:38:04 -0800 Daniel Walker wrote: > > > This release is an up-rev of the v5 patches. No additional features have > > been added. Some changes were mode to function names and some chan

[PATCH 7/8] of: replace command line handling

2023-11-09 Thread Daniel Walker
mmand line conversion. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- drivers/of/fdt.c| 22 +++--- include/linux/cmdline.h | 31 +++ 2 files changed, 34 insertions(+), 19 deletions(-) diff --git a/drivers/of/fdt.c b/drivers/of/

[PATCH 6/8] CMDLINE: x86: convert to generic builtin command line

2023-11-09 Thread Daniel Walker
This updates the x86 code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/x86/Kconfig| 44 + arch/x86/kernel/setup.c

[PATCH 4/8] CMDLINE: mips: convert to generic builtin command line

2023-11-09 Thread Daniel Walker
1/.config make ARCH=$1 O=$1 olddefconfig make ARCH=$1 O=$1 savedefconfig cp $1/defconfig $2 rm -Rf $1 Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/mips/Kconfig | 4 +- arch/mips/K

[PATCH 8/8] CMDLINE: arm64: convert to generic builtin command line

2023-11-09 Thread Daniel Walker
. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- arch/arm64/Kconfig | 33 + arch/arm64/include/asm/setup.h | 4 arch/arm64/include/uapi/asm/setup.h | 2 ++ arch/arm64/kernel/idreg-override.c | 9 arch/arm64

[PATCH 2/8] scripts: insert-sys-cert: add command line insert capability

2023-11-09 Thread Daniel Walker
intentionally keeps the tool filename the same to allow the changes to be seen more easily. The next commit will change the name of the tool. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- scripts/insert-sys-cert.c | 241 +++--- 1 file changed, 170

[PATCH 5/8] drivers: firmware: efi: libstub: enable generic commandline

2023-11-09 Thread Daniel Walker
way to do that currently. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- .../firmware/efi/libstub/efi-stub-helper.c| 29 +++ drivers/firmware/efi/libstub/efi-stub.c | 9 ++ drivers/firmware/efi/libstub/efistub.h| 1 + drivers/firmware/efi

[PATCH 3/8] scripts: insert-sys-cert: change name to insert-symbol

2023-11-09 Thread Daniel Walker
Since the tool is used to update the command line and/or to update the certificates, I think it makes sense to changes the name of this tool. Update the name of the tool to better reflect it's new use. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- scripts/Mak

[PATCH 1/8] CMDLINE: add generic builtin command line

2023-11-09 Thread Daniel Walker
ality needed by Cisco on all platform which we enable it on. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- include/linux/cmdline.h | 106 ++ init/Kconfig| 79 +++ lib/Kconfig

[PATCH 0/8] generic command line v6

2023-11-09 Thread Daniel Walker
Cisco Systems, Inc. on millions of released products to great effect. Hopefully they can be used by the entire Linux eco system. My apologies on the length between releases. I will try to release more often. Daniel Walker (8): CMDLINE: add generic builtin command line scripts: insert-sys-cert

Re: [PATCH 1/4] add generic builtin command line

2023-11-08 Thread Daniel Walker (danielwa)
On Wed, Nov 08, 2023 at 11:33:37AM +, Christophe Leroy wrote: > As far as I remember, Daniel's proposal had some weaknesses that were > never addressed. At that time I proposed an alternative series that was > addressing most weaknesses, and my series was considered more mature > that Daniel

Re: mm/debug_vm_pgtable.c:860 warning triggered

2023-11-05 Thread Daniel Walker (danielwa)
On Mon, Nov 06, 2023 at 08:39:26AM +0530, Anshuman Khandual wrote: > Hello Daniel, > > This test just ensures that PFN is preserved during pte <--> swap pte > transformations > , and the warning here seems to have been caused by powerpc platform specific > helpers > and/or its pte_t representati

Re: [PATCH 1/4] add generic builtin command line

2023-10-17 Thread Daniel Walker (danielwa)
On Tue, Oct 17, 2023 at 04:10:42PM +0530, Pratyush Brahma wrote: > For such a usecase, the CONFIG_CMDLINE_PREPEND seems to be quite useful as > it would help to stitch bootloader > and the desired build variant's configs together. Can you please help to > merge this patch? Yes, your at least the s

Re: [PATCH 1/4] add generic builtin command line

2023-04-17 Thread Daniel Walker (danielwa)
On Mon, Apr 17, 2023 at 06:18:18PM +0200, Tomas Mudrunka wrote: > This seems quite useful. Can you please merge it? I need to re-send it before it can be merge. I'll try to update it soon. Daniel

Re: [PATCH 0/8] generic command line v4

2022-09-26 Thread Daniel Walker
On Mon, Sep 26, 2022 at 05:52:18PM -0500, Rob Herring wrote: > On Thu, Sep 22, 2022 at 4:15 PM Daniel Gimpelevich > wrote: > > > > On Thu, 2022-09-22 at 14:10 -0700, Daniel Walker wrote: > > > On Thu, Sep 22, 2022 at 05:03:46PM -0400, Sean Anderson wrote: > > [

Re: [PATCH 0/8] generic command line v4

2022-09-26 Thread Daniel Walker
On Thu, Sep 22, 2022 at 02:15:44PM -0700, Daniel Gimpelevich wrote: > On Thu, 2022-09-22 at 14:10 -0700, Daniel Walker wrote: > > On Thu, Sep 22, 2022 at 05:03:46PM -0400, Sean Anderson wrote: > [snip] > > > As recently as last month, someone's patch to add such support w

Re: [PATCH 0/8] generic command line v4

2022-09-22 Thread Daniel Walker
On Thu, Sep 22, 2022 at 05:03:46PM -0400, Sean Anderson wrote: > > > > On 9/22/22 4:53 PM, Daniel Walker wrote: > > On Thu, Sep 22, 2022 at 04:45:01PM -0400, Sean Anderson wrote: > >> > >> > >> > >> For an arm64 platform (after rebasing

Re: [PATCH 0/8] generic command line v4

2022-09-22 Thread Daniel Walker
On Thu, Sep 22, 2022 at 04:45:01PM -0400, Sean Anderson wrote: > > > > For an arm64 platform (after rebasing): > > Tested-by: Sean Anderson Maybe I'll re-submit it. Daniel

Re: [PATCH 1/3] lib: early_string: allow early usage of some string functions

2021-05-03 Thread Daniel Walker
On Mon, May 03, 2021 at 11:01:41AM -0700, Daniel Walker wrote: > On Sat, May 01, 2021 at 09:31:47AM +0200, Christophe Leroy wrote: > > > > > In fact, should be like in prom_init today: > > > > > > #ifdef __EARLY_STRING_ENABLED > > > if

Re: [PATCH 1/3] lib: early_string: allow early usage of some string functions

2021-05-03 Thread Daniel Walker
On Sat, May 01, 2021 at 09:31:47AM +0200, Christophe Leroy wrote: > > > In fact, should be like in prom_init today: > > > > #ifdef __EARLY_STRING_ENABLED > > if (dsize >= count) > >     return count; > > #else > > BUG_ON(dsize >= count); > > #endif > > Thinking about it once more,

[PATCH 1/3] lib: early_string: allow early usage of some string functions

2021-04-29 Thread Daniel Walker
exter...@cisco.com Signed-off-by: Daniel Walker --- include/linux/string.h | 6 ++ lib/Makefile | 23 +- lib/early_string.c | 172 + lib/string.c | 154 4 files changed, 200 insertions(+), 155

[PATCH 3/3] x86: switch amd mem encrypt to early string functions

2021-04-29 Thread Daniel Walker
This switched x86 early string users to use the early string variants and re-enabled KASAN on general string functions use thru out the rest of the system. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- arch/x86/mm/mem_encrypt_identity.c | 4 ++-- lib/Makefile

[PATCH 2/3] powerpc: prom_init: switch to early string functions

2021-04-29 Thread Daniel Walker
This converts the prom_init string users to the early string function which don't suffer from KASAN or any other debugging enabled. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- arch/powerpc/kernel/prom_init.c| 185 ++--- arch/powerpc/k

[PATCH 8/8] CMDLINE: arm64: convert to generic builtin command line

2021-04-15 Thread Daniel Walker
. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- arch/arm64/Kconfig | 33 +- arch/arm64/include/asm/setup.h | 2 ++ arch/arm64/kernel/idreg-override.c | 9 3 files changed, 8 insertions(+), 36 deletions(-) diff --git a

[PATCH 7/8] of: allow sending a NULL value to early_init_dt_scan_chosen

2021-04-15 Thread Daniel Walker
ns, unless it's already populated. This code was boot tested on powerpc 32bit, x86, and arm64. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- drivers/of/fdt.c | 44 +--- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git a/driver

[PATCH 5/8] drivers: firmware: efi: libstub: enable generic commandline

2021-04-15 Thread Daniel Walker
way to do that currently. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- .../firmware/efi/libstub/efi-stub-helper.c| 29 +++ drivers/firmware/efi/libstub/efi-stub.c | 9 ++ drivers/firmware/efi/libstub/efistub.h| 1 + drivers/firmware/efi

[PATCH 6/8] CMDLINE: x86: convert to generic builtin command line

2021-04-15 Thread Daniel Walker
This updates the x86 code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/x86/Kconfig| 44 + arch/x86/kernel/setup.c

[PATCH 4/8] CMDLINE: mips: convert to generic builtin command line

2021-04-15 Thread Daniel Walker
1/.config make ARCH=$1 O=$1 olddefconfig make ARCH=$1 O=$1 savedefconfig cp $1/defconfig $2 rm -Rf $1 Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/mips/Kconfig | 4 +

[PATCH 3/8] scripts: insert-sys-cert: change name to insert-symbol

2021-04-15 Thread Daniel Walker
Since the tool is used to update the command line and/or to update the certificates, I think it makes sense to changes the name of this tool. Update the name of the tool to better reflect it's new use. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- scripts/Mak

[PATCH 2/8] scripts: insert-sys-cert: add command line insert capability

2021-04-15 Thread Daniel Walker
intentionally keeps the tool filename the same to allow the changes to be seen more easily. The next commit will change the name of the tool. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- scripts/insert-sys-cert.c | 241 +++--- 1 file changed, 170

[PATCH 1/8] CMDLINE: add generic builtin command line

2021-04-15 Thread Daniel Walker
ality needed by Cisco on all platform which we enable it on. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- include/linux/cmdline.h | 103 + init/Kconfig| 78 ++ lib/Kconfig

[PATCH 0/8] generic command line v4

2021-04-15 Thread Daniel Walker
k his reservations are founded, and these changes should fully work on powerpc. However, I dropped these changes so Christophe can have more time to get comfortable with the changes. Enjoy! Daniel Walker (8): CMDLINE: add generic builtin command line scripts: insert-sys-cert: add co

Re: [PATCH 2/8] CMDLINE: drivers: of: ifdef out cmdline section

2021-04-08 Thread Daniel Walker
On Wed, Apr 07, 2021 at 05:59:15PM -0500, Rob Herring wrote: > On Tue, Mar 30, 2021 at 04:17:53PM -0700, Daniel Walker wrote: > > On Tue, Mar 30, 2021 at 02:49:13PM -0500, Rob Herring wrote: > > > On Tue, Mar 30, 2021 at 12:57 PM Daniel Walker wrote: > > > > >

Re: [PATCH v4 19/20] mips: Convert to GENERIC_CMDLINE

2021-04-08 Thread Daniel Walker
On Thu, Apr 08, 2021 at 02:04:08PM -0500, Rob Herring wrote: > On Tue, Apr 06, 2021 at 10:38:36AM -0700, Daniel Walker wrote: > > On Fri, Apr 02, 2021 at 03:18:21PM +, Christophe Leroy wrote: > > > -config CMDLINE_BOOL > > > - bool "Built-in kernel command line&

Re: [PATCH v4 19/20] mips: Convert to GENERIC_CMDLINE

2021-04-06 Thread Daniel Walker
On Fri, Apr 02, 2021 at 03:18:21PM +, Christophe Leroy wrote: > -config CMDLINE_BOOL > - bool "Built-in kernel command line" > - help > - For most systems, it is firmware or second stage bootloader that > - by default specifies the kernel command line options. However, > -

Re: [PATCH v4 00/20] Implement GENERIC_CMDLINE

2021-04-06 Thread Daniel Walker
On Fri, Apr 02, 2021 at 03:18:01PM +, Christophe Leroy wrote: > The purpose of this series is to improve and enhance the > handling of kernel boot arguments. > > Current situation is that most if not all architectures are using > similar options to do some manupulation on command line argument

Re: [PATCH 6/8] drivers: firmware: efi: libstub: enable generic commandline

2021-04-06 Thread Daniel Walker
On Fri, Apr 02, 2021 at 07:36:53PM +0200, Christophe Leroy wrote: > > > Le 30/03/2021 à 19:57, Daniel Walker a écrit : > > This adds code to handle the generic command line changes. > > The efi code appears that it doesn't benefit as much from this design > > a

Re: [PATCH 4/8] CMDLINE: powerpc: convert to generic builtin command line

2021-04-06 Thread Daniel Walker
On Fri, Apr 02, 2021 at 07:34:19PM +0200, Christophe Leroy wrote: > > > Le 30/03/2021 à 19:56, Daniel Walker a écrit : > > This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE > > option. > > > > This includes a scripted mass convert of the config

Re: [PATCH 2/8] CMDLINE: drivers: of: ifdef out cmdline section

2021-04-06 Thread Daniel Walker
On Fri, Apr 02, 2021 at 07:32:08PM +0200, Christophe Leroy wrote: > > > Le 30/03/2021 à 19:56, Daniel Walker a écrit : > > It looks like there's some seepage of cmdline stuff into > > the generic device tree code. This conflicts with the > > generic cmdline impl

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

2021-04-06 Thread Daniel Walker
On Thu, Apr 01, 2021 at 03:08:04PM -0500, Rob Herring wrote: > On Tue, Mar 30, 2021 at 6:31 PM Daniel Walker wrote: > > > > On Tue, Mar 30, 2021 at 03:13:04PM -0500, Rob Herring wrote: > > > On Tue, Mar 30, 2021 at 12:33 PM Daniel Walker wrote: > > > > > &

Re: [PATCH 6/8] drivers: firmware: efi: libstub: enable generic commandline

2021-03-31 Thread Daniel Walker
On Wed, Mar 31, 2021 at 06:10:08PM +0200, Ard Biesheuvel wrote: > (+ Arvind) > > On Tue, 30 Mar 2021 at 19:57, Daniel Walker wrote: > > > > This adds code to handle the generic command line changes. > > The efi code appears that it doesn't benefit as much

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

2021-03-31 Thread Daniel Walker
On Wed, Mar 31, 2021 at 12:52:19PM +0100, Will Deacon wrote: > On Tue, Mar 30, 2021 at 10:35:21AM -0700, Daniel Walker wrote: > > On Mon, Mar 29, 2021 at 11:07:51AM +0100, Will Deacon wrote: > > > On Thu, Mar 25, 2021 at 12:59:56PM -0700, Daniel Walker wrote: > > > >

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

2021-03-30 Thread Daniel Walker
On Tue, Mar 30, 2021 at 03:13:04PM -0500, Rob Herring wrote: > On Tue, Mar 30, 2021 at 12:33 PM Daniel Walker wrote: > > > > On Thu, Mar 25, 2021 at 05:29:44PM -0600, Rob Herring wrote: > > > On Thu, Mar 25, 2021 at 2:00 PM Daniel Walker wrote: > > > > > &

Re: [PATCH 2/8] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-30 Thread Daniel Walker
On Tue, Mar 30, 2021 at 02:49:13PM -0500, Rob Herring wrote: > On Tue, Mar 30, 2021 at 12:57 PM Daniel Walker wrote: > > > > It looks like there's some seepage of cmdline stuff into > > the generic device tree code. This conflicts with the > > generic cmdline impl

Re: [PATCH v3 01/17] cmdline: Add generic function to build command line.

2021-03-30 Thread Daniel Walker
On Tue, Mar 30, 2021 at 08:07:30PM +0200, H. Nikolaus Schaller wrote: > > > Am 30.03.2021 um 19:27 schrieb Daniel Walker : > > > > On Fri, Mar 26, 2021 at 01:44:48PM +, Christophe Leroy wrote: > >> This code provides architectures with a way to build command li

[PATCH 8/8] CMDLINE: arm64: convert to generic builtin command line

2021-03-30 Thread Daniel Walker
This updates the arm64 code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- arch/arm64/Kconfig | 33 +- arch/arm64/kernel/idreg-override.c | 8 +--- arch/arm64/kernel/setup.c

[PATCH 7/8] CMDLINE: x86: convert to generic builtin command line

2021-03-30 Thread Daniel Walker
This updates the x86 code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/x86/Kconfig| 44 + arch/x86/kernel/setup.c

[PATCH 6/8] drivers: firmware: efi: libstub: enable generic commandline

2021-03-30 Thread Daniel Walker
e appears to be no way to re-enable kaslr or some of the other options. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- .../firmware/efi/libstub/efi-stub-helper.c| 35 +++ drivers/firmware/efi/libstub/efi-stub.c | 7 drivers/firmware/efi/li

[PATCH 4/8] CMDLINE: powerpc: convert to generic builtin command line

2021-03-30 Thread Daniel Walker
fconfig make ARCH=$1 O=$1 savedefconfig cp $1/defconfig $2 rm -Rf $1 Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/powerpc/Kconfig | 38 +-- arch/

[PATCH 5/8] CMDLINE: mips: convert to generic builtin command line

2021-03-30 Thread Daniel Walker
;s/CONFIG_CMDLINE=/CONFIG_CMDLINE_BOOL=y\nCONFIG_CMDLINE_PREPEND=/g' $1/.config make ARCH=$1 O=$1 olddefconfig make ARCH=$1 O=$1 savedefconfig cp $1/defconfig $2 rm -Rf $1 Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/mip

[PATCH 2/8] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-30 Thread Daniel Walker
It looks like there's some seepage of cmdline stuff into the generic device tree code. This conflicts with the generic cmdline implementation so I remove it in the case when that's enabled. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Dan

[PATCH 3/8] powerpc: convert strcpy to strlcpy in prom_init

2021-03-30 Thread Daniel Walker
There's only two users of strcpy and one is the command line handling. The generic command line handling uses strlcpy and it makes sense to convert this one other user to strlcpy to keep prom_init size consistent. Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker --- arch/po

[PATCH 1/8] CMDLINE: add generic builtin command line

2021-03-30 Thread Daniel Walker
add the builtin command line. This unified implementation offers the same functionality needed by Cisco on all platform which use it. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- include/linux/cmdline.h | 98

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

2021-03-30 Thread Daniel Walker
On Mon, Mar 29, 2021 at 11:07:51AM +0100, Will Deacon wrote: > On Thu, Mar 25, 2021 at 12:59:56PM -0700, Daniel Walker wrote: > > On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote: > > > > > > Ok, so you agree we don't need to provide two CMDLINE, o

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

2021-03-30 Thread Daniel Walker
On Thu, Mar 25, 2021 at 05:29:44PM -0600, Rob Herring wrote: > On Thu, Mar 25, 2021 at 2:00 PM Daniel Walker wrote: > > > > On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote: > > > > > > Ok, so you agree we don't need to provide two CMDLINE, o

Re: [PATCH v3 01/17] cmdline: Add generic function to build command line.

2021-03-30 Thread Daniel Walker
On Fri, Mar 26, 2021 at 01:44:48PM +, Christophe Leroy wrote: > This code provides architectures with a way to build command line > based on what is built in the kernel and what is handed over by the > bootloader, based on selected compile-time options. > > Signed-off-by: Christophe Leroy > -

Re: [PATCH v2 4/7] CMDLINE: powerpc: convert to generic builtin command line

2021-03-25 Thread Daniel Walker
On Wed, Mar 24, 2021 at 04:31:35PM +0100, Christophe Leroy wrote: > > > Le 09/03/2021 à 22:40, Daniel Walker a écrit : > > On Tue, Mar 09, 2021 at 08:56:47AM +0100, Christophe Leroy wrote: > > > > > > > > > Le 09/03/2021 à 01:02, Daniel Walker a écrit 

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

2021-03-25 Thread Daniel Walker
On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote: > > Ok, so you agree we don't need to provide two CMDLINE, one to be appended and > one to be prepended. > > Let's only provide once CMDLINE as of today, and ask the user to select > whether he wants it appended or prepended or re

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

2021-03-25 Thread Daniel Walker
On Wed, Mar 24, 2021 at 05:59:59PM +0100, Christophe Leroy wrote: > > I think my changes maintain most of this due to the override of > > CONFIG_CMDLINE_PREPEND. This is an upgrade and the inflexibility in powerpc > > is > > an example of why these changes were created in the first place. > > "in

Re: [PATCH v2 4/7] CMDLINE: powerpc: convert to generic builtin command line

2021-03-09 Thread Daniel Walker
On Tue, Mar 09, 2021 at 08:56:47AM +0100, Christophe Leroy wrote: > > > Le 09/03/2021 à 01:02, Daniel Walker a écrit : > > This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE > > option. > > > > Cc: xe-linux-exter...@cisco.com > > Signed-off-by

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

2021-03-09 Thread Daniel Walker
On Tue, Mar 09, 2021 at 08:47:09AM +0100, Christophe Leroy wrote: > > > Le 09/03/2021 à 01:02, Daniel Walker a écrit : > > This is a scripted mass convert of the config files to use > > the new generic cmdline. There is a bit of a trim effect here. > > It would se

[PATCH v2 7/7] CMDLINE: x86: convert to generic builtin command line

2021-03-08 Thread Daniel Walker
This updates the x86 code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/x86/Kconfig| 44 + arch/x86/kernel/setup.c

[PATCH v2 6/7] CMDLINE: mips: convert to generic builtin command line

2021-03-08 Thread Daniel Walker
This updates the mips code to use the CONFIG_GENERIC_CMDLINE option. This deletes the option for MIPS_CMDLINE_BUILTIN_EXTEND and replaces the functionality with generic code. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel

[PATCH v2 5/7] mips: convert config files to generic cmdline

2021-03-08 Thread Daniel Walker
echo "Two arguments are needed." exit 1 fi mkdir $1 cp $2 $1/.config sed -i 's/CONFIG_CMDLINE=/CONFIG_CMDLINE_BOOL=y\nCONFIG_CMDLINE_PREPEND=/g' $1/.config make ARCH=$1 O=$1 olddefconfig make ARCH=$1 O=$1 savedefconfig cp $1/defconfig $2 rm -Rf $1 Cc: xe-linux-exter...@cisc

[PATCH v2 4/7] CMDLINE: powerpc: convert to generic builtin command line

2021-03-08 Thread Daniel Walker
This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/powerpc/Kconfig| 37 + arch/powerpc/kernel

[PATCH v2 3/7] powerpc: convert config files to generic cmdline

2021-03-08 Thread Daniel Walker
]; then echo "Two arguments are needed." exit 1 fi mkdir $1 cp $2 $1/.config sed -i 's/CONFIG_CMDLINE=/CONFIG_CMDLINE_BOOL=y\nCONFIG_CMDLINE_PREPEND=/g' $1/.config make ARCH=$1 O=$1 olddefconfig make ARCH=$1 O=$1 savedefconfig cp $1/defconfig $2 rm -Rf $1 Cc: xe-l

[PATCH v2 2/7] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-08 Thread Daniel Walker
It looks like there's some seepage of cmdline stuff into the generic device tree code. This conflicts with the generic cmdline implementation so I remove it in the case when that's enabled. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Dan

[PATCH v2 0/7] Generic Command Line changes

2021-03-08 Thread Daniel Walker
system. These were tested on all effected architectures. Daniel Walker (7): CMDLINE: add generic builtin command line CMDLINE: drivers: of: ifdef out cmdline section powerpc: convert config files to generic cmdline CMDLINE: powerpc: convert to generic builtin command line mips: convert

[PATCH v2 1/7] CMDLINE: add generic builtin command line

2021-03-08 Thread Daniel Walker
...@cisco.com Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- include/linux/cmdline.h | 89 + init/Kconfig| 68 +++ 2 files changed, 157 insertions(+) create mode 100644 include/linux/cmdline.h diff --git a

[PATCH v2 2/7] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-08 Thread Daniel Walker
It looks like there's some seepage of cmdline stuff into the generic device tree code. This conflicts with the generic cmdline implementation so I remove it in the case when that's enabled. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Dan

[PATCH v2 1/7] CMDLINE: add generic builtin command line

2021-03-08 Thread Daniel Walker
...@cisco.com Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- include/linux/cmdline.h | 89 + init/Kconfig| 68 +++ 2 files changed, 157 insertions(+) create mode 100644 include/linux/cmdline.h diff --git a

[PATCH v2 0/7] Generic Command Line changes

2021-03-08 Thread Daniel Walker
system. These were tested on all effected architectures. Daniel Walker (7): CMDLINE: add generic builtin command line CMDLINE: drivers: of: ifdef out cmdline section powerpc: convert config files to generic cmdline CMDLINE: powerpc: convert to generic builtin command line mips: convert

Re: [PATCH 2/5] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-04 Thread Daniel Walker
On Thu, Mar 04, 2021 at 08:09:52AM +0100, Christophe Leroy wrote: > > > Le 04/03/2021 à 05:47, Daniel Walker a écrit : > > It looks like there's some seepage of cmdline stuff into > > the generic device tree code. This conflicts with the > > generic cmdline impl

Re: [PATCH 1/5] CMDLINE: add generic builtin command line

2021-03-04 Thread Daniel Walker
On Thu, Mar 04, 2021 at 08:00:49AM +0100, Christophe Leroy wrote: > > > Le 04/03/2021 à 05:47, Daniel Walker a écrit : > > This code allows architectures to use a generic builtin command line. > > The state of the builtin command line options across architecture is > &g

Re: [PATCH 2/5] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-04 Thread Daniel Walker
On Thu, Mar 04, 2021 at 08:32:37AM -0600, Rob Herring wrote: > On Wed, Mar 3, 2021 at 10:48 PM Daniel Walker wrote: > > > > It looks like there's some seepage of cmdline stuff into > > the generic device tree code. This conflicts with the > > generic cmdline impl

[PATCH 5/5] CMDLINE: x86: convert to generic builtin command line

2021-03-03 Thread Daniel Walker
This updates the x86 code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/x86/Kconfig| 44 + arch/x86/kernel/setup.c

[PATCH 1/5] CMDLINE: add generic builtin command line

2021-03-03 Thread Daniel Walker
...@cisco.com Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- include/linux/cmdline.h | 75 + init/Kconfig| 68 + 2 files changed, 143 insertions(+) create mode 100644 include/linux/cmdline.h diff --git a

[PATCH 2/5] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-03 Thread Daniel Walker
It looks like there's some seepage of cmdline stuff into the generic device tree code. This conflicts with the generic cmdline implementation so I remove it in the case when that's enabled. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Dan

[PATCH 3/5] CMDLINE: powerpc: convert to generic builtin command line

2021-03-03 Thread Daniel Walker
This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel Walker --- arch/powerpc/Kconfig| 37 + arch/powerpc/kernel

[PATCH 4/5] CMDLINE: mips: convert to generic builtin command line

2021-03-03 Thread Daniel Walker
This updates the mips code to use the CONFIG_GENERIC_CMDLINE option. This deletes the option for MIPS_CMDLINE_BUILTIN_EXTEND and replaces the functionality with generic code. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan Ruslichenko Signed-off-by: Ruslan Bilovol Signed-off-by: Daniel

Re: [PATCH v2 0/7] Improve boot command line handling

2021-03-03 Thread Daniel Walker
On Wed, Mar 03, 2021 at 07:07:45PM +0100, Christophe Leroy wrote: > > > Le 03/03/2021 à 18:39, Daniel Walker a écrit : > > On Tue, Mar 02, 2021 at 08:01:01PM -0600, Rob Herring wrote: > > > +Will D > > > > > > On Tue, Mar 2, 2021 at 11:36 AM Daniel Walk

Re: [PATCH v2 0/7] Improve boot command line handling

2021-03-03 Thread Daniel Walker
On Tue, Mar 02, 2021 at 08:01:01PM -0600, Rob Herring wrote: > +Will D > > On Tue, Mar 2, 2021 at 11:36 AM Daniel Walker wrote: > > > > On Tue, Mar 02, 2021 at 05:25:16PM +, Christophe Leroy wrote: > > > The purpose of this series is to improve and enhance the

Re: [PATCH v2 0/7] Improve boot command line handling

2021-03-02 Thread Daniel Walker
On Tue, Mar 02, 2021 at 05:25:16PM +, Christophe Leroy wrote: > The purpose of this series is to improve and enhance the > handling of kernel boot arguments. > > It is first focussed on powerpc but also extends the capability > for other arches. > > This is based on s

Re: [PATCH 0/2] Fix CMDLINE_EXTEND handling for FDT "bootargs"

2021-03-02 Thread Daniel Walker
On Mon, Mar 01, 2021 at 11:26:14AM -0600, Rob Herring wrote: > +PPC folks and Daniel W > > On Mon, Mar 1, 2021 at 8:42 AM Will Deacon wrote: > > > > On Mon, Mar 01, 2021 at 08:19:32AM -0600, Rob Herring wrote: > > > On Thu, Feb 25, 2021 at 6:59 AM Will Deacon wrote: > > > > We recently [1] enabl

Re: [PATCH 1/4] add generic builtin command line

2021-02-16 Thread Daniel Walker
On Mon, Feb 15, 2021 at 11:32:01AM -0800, Daniel Gimpelevich wrote: > On Thu, 2019-03-21 at 15:15 -0700, Andrew Morton wrote: > > On Thu, 21 Mar 2019 08:13:08 -0700 Daniel Walker wrote: > > > On Wed, Mar 20, 2019 at 08:14:33PM -0700, Andrew Morton wrote: > > > > T

Re: [PATCH 1/4] add generic builtin command line

2019-03-21 Thread Daniel Walker
On Wed, Mar 20, 2019 at 08:14:33PM -0700, Andrew Morton wrote: > On Wed, 20 Mar 2019 16:23:28 -0700 Daniel Walker wrote: > > > On Wed, Mar 20, 2019 at 03:53:19PM -0700, Andrew Morton wrote: > > > On Tue, 19 Mar 2019 16:24:45 -0700 Daniel Walker > > > wrote: &

Re: [PATCH 1/4] add generic builtin command line

2019-03-20 Thread Daniel Walker
On Wed, Mar 20, 2019 at 03:53:19PM -0700, Andrew Morton wrote: > On Tue, 19 Mar 2019 16:24:45 -0700 Daniel Walker wrote: > > > This code allows architectures to use a generic builtin command line. > > I wasn't cc'ed on [2/4]. No mailing lists were cc'ed on [

[PATCH 4/4] powerpc: convert config files to generic cmdline

2019-03-19 Thread Daniel Walker
This is a mass convert of the config files to use the new generic cmdline. The command used to convert is as follows, sed -i 's/CONFIG_CMDLINE=/CONFIG_CMDLINE_PREPEND=/g' Cc: xe-linux-exter...@cisco.com Cc: Daniel Walker Signed-off-by: Daniel Walker

[PATCH 1/4] add generic builtin command line

2019-03-19 Thread Daniel Walker
...@globallogic.com: fix cmdline_add_builtin() macro] Cc: Daniel Walker Cc: Daniel Walker Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker Signed-off-by: Maksym Kokhan --- include/linux/cmdline.h | 69 + init/Kconfig| 69

[PATCH 2/4] drivers: of: generic command line support

2019-03-19 Thread Daniel Walker
simply add "select GENERIC_CMDLINE" and delete their Kconfig options for the current CMDLINE. Change-Id: Ief473a5ffac01a999b0aba7619f5b63bc4b36ac4 Cc: Andrew Morton Cc: Christophe Leroy Cc: Michael Ellerman Signed-off-by: Daniel Walker --- drivers/of/fdt.c | 10 -- 1 file

[PATCH 3/4] powerpc: convert to generic builtin command line

2019-03-19 Thread Daniel Walker
This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE option. [maksym.kok...@globallogic.com: add strlcat to prom_init_check.sh whitelist] Cc: Daniel Walker Cc: Daniel Walker Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker Signed-off-by: Maksym Kokhan --- arch/powerpc

Generic command line -v2

2019-03-19 Thread Daniel Walker
Hi all, new in -v2 * Updated with some changes to adding spaces from Christophe Leroy. * Added OF support with comments from Rob on my 2015 submission which he reviewed. (https://lore.kernel.org/patchwork/patch/604997/) Christophe and Rob suggested to hav

Re: [PATCH 2/3] powerpc: convert to generic builtin command line

2019-03-19 Thread Daniel Walker
On Mon, Mar 04, 2019 at 03:26:59PM +0100, Christophe Leroy wrote: > > > Le 01/03/2019 à 20:44, Daniel Walker a écrit : > > This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE > > option. > > Please explain more in details how each powerpc option is repla

Re: [PULL REQUEST] powerpc generic command line

2019-03-19 Thread Daniel Walker
On Tue, Mar 19, 2019 at 06:42:35PM +0100, Christophe Leroy wrote: > Well, that's what I started with, but at the end my main worry has been that > you bring a non exciting set of complicated macros and code to replace > simple code, and you break something out of generic OF code to a new brand > ne

Re: [PULL REQUEST] powerpc generic command line

2019-03-19 Thread Daniel Walker
On Tue, Mar 19, 2019 at 12:18:03PM +1100, Michael Ellerman wrote: > Hi Daniel, > > Daniel Walker writes: > > Here are the generic command line changes for powerpc. > > > > These changes have been in linux-next for two cycles, with few problems > > reported.

Re: [PULL REQUEST] powerpc generic command line

2019-03-04 Thread Daniel Walker
On Mon, Mar 04, 2019 at 06:29:12PM +0100, Christophe Leroy wrote: > > > Le 04/03/2019 à 17:57, Daniel Walker a écrit : > > On Mon, Mar 04, 2019 at 02:55:08PM +0100, Christophe Leroy wrote: > > > > > > > > > Le 01/03/2019 à 20:44, Daniel Walker a éc

Re: [PULL REQUEST] powerpc generic command line

2019-03-04 Thread Daniel Walker
On Mon, Mar 04, 2019 at 02:55:08PM +0100, Christophe Leroy wrote: > > > Le 01/03/2019 à 20:44, Daniel Walker a écrit : > > Here are the generic command line changes for powerpc. > > > > These changes have been in linux-next for two cycles, with few problems >

[PULL REQUEST] powerpc generic command line

2019-03-01 Thread Daniel Walker
anges since commit ccda4af0f4b92f7b4c308d3acc262f4a7e3affad: Linux 4.20-rc2 (2018-11-11 17:12:31 -0600) are available in the git repository at: https://github.com/daniel-walker/cisco-linux.git for-powerpc for you to fetch changes up to 5d4514a9c291ecf19b0626695161673d35e5d549: powerpc: co

  1   2   >