Re: [PATCH 3/3] tracing: Tracers that use CALLER_ADDR macros should select FRAME_POINTER

2009-02-04 Thread Frédéric Weisbecker
2009/2/4 Steven Rostedt : > > >From ftrace.h: > > #ifdef CONFIG_FRAME_POINTER > /* TODO: need to fix this for ARM */ > # define CALLER_ADDR0 ((unsigned long)__builtin_return_address(0)) > # define CALLER_ADDR1 ((unsigned long)__builtin_return_address(1)) > # define CALLER_ADDR2 ((unsigned long)__bu

Re: [PATCH 3/3] tracing: Tracers that use CALLER_ADDR macros should select FRAME_POINTER

2009-02-04 Thread Frédéric Weisbecker
2009/2/4 Anton Vorontsov : > Irqsoff, switch and preempt tracers use CALLER_ADDR macros, so they > should select FRAME_POINTER. Otherwise traces are meaningless. > > Signed-off-by: Anton Vorontsov > --- > kernel/trace/Kconfig |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff

Re: [PATCH 0/2] ftrace: fixes for PPC

2008-10-20 Thread Frédéric Weisbecker
2008/10/20 Steven Rostedt <[EMAIL PROTECTED]>: > I believe MIPS has the same issues as PPC. Doesn't it use a trampoline > too? No it doesn't seem to. If I'm not wrong, MIPS uses only the elf relocation table to relocate its addresses. > I want to make the generic code handle trampolines a bit bet

Re: [PATCH 0/2] ftrace: fixes for PPC

2008-10-20 Thread Frédéric Weisbecker
2008/10/20 Josh Boyer <[EMAIL PROTECTED]>: > That seems like a good plan. Should we mark dynamic ftrace as X86 only > in Kconfig for .28 to prevent people from inadvertently setting it? Hi Josh. There are other arch that support ftrace as well like sh or sparc64 (I'm currently working on an impl