Re: [PATCH 5/8] powerpc: Drop XILINX MAINTAINERS entry

2020-02-24 Thread Grant Likely
On 24/02/2020 23:31, Michael Ellerman wrote: This has been orphaned for ~7 years, remove it. Cc: Grant Likely Signed-off-by: Michael Ellerman Acked-by: Grant Likely --- MAINTAINERS | 6 -- 1 file changed, 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 939da2ac08db

Re: drivers binding to device node with multiple compatible strings

2018-10-04 Thread Grant Likely
On 04/10/2018 10:32, Grant Likely wrote: On Fri, Sep 28, 2018 at 10:01 PM Li Yang wrote: On Fri, Sep 28, 2018 at 3:07 PM Rob Herring wrote: On Thu, Sep 27, 2018 at 5:25 PM Li Yang wrote: Hi Rob and Grant, Various device tree specs are recommending to include all the potential

Re: drivers binding to device node with multiple compatible strings

2018-10-04 Thread Grant Likely
On Fri, Sep 28, 2018 at 10:01 PM Li Yang wrote: > > On Fri, Sep 28, 2018 at 3:07 PM Rob Herring wrote: > > > > On Thu, Sep 27, 2018 at 5:25 PM Li Yang wrote: > > > > > > Hi Rob and Grant, > > > > > > Various device tree specs are recommending to include all the > > > potential compatible strings

Re: DT case sensitivity

2018-08-23 Thread Grant Likely
On 23/08/2018 13:08, Rob Herring wrote: On Thu, Aug 23, 2018 at 6:48 AM Benjamin Herrenschmidt wrote: On Thu, 2018-08-23 at 06:43 -0500, Rob Herring wrote: On Thu, Aug 23, 2018 at 4:02 AM Grant Likely wrote: What problem are you trying to solve? I'm looking at removing device_node

Re: DT case sensitivity

2018-08-23 Thread Grant Likely
On 23/08/2018 12:47, Benjamin Herrenschmidt wrote: On Thu, 2018-08-23 at 06:43 -0500, Rob Herring wrote: On Thu, Aug 23, 2018 at 4:02 AM Grant Likely wrote: What problem are you trying to solve? I'm looking at removing device_node.name and using full_name instead (which now is onl

Re: DT case sensitivity

2018-08-23 Thread Grant Likely
On 23/08/2018 02:29, Benjamin Herrenschmidt wrote: On Wed, 2018-08-22 at 20:26 -0500, Rob Herring wrote: On Wed, Aug 22, 2018 at 8:14 PM Benjamin Herrenschmidt wrote: On Wed, 2018-08-22 at 19:47 -0500, Rob Herring wrote: The default DT string handling in the kernel is node names and compatib

Re: [git pull] Please pull powerpc.git next branch

2018-06-19 Thread Grant Likely
On Sun, Aug 8, 2010 at 10:11 PM, Benjamin Herrenschmidt wrote: > Hi Linus ! > > Here's a few misc things for .36. The big bit is that I trimmed all the > defconfigs using make savedefconfig. [...] >  108 files changed, 270 insertions(+), 134609 deletions(-) And how is anyone else to make it into

Re: Devicetree specification process

2016-04-30 Thread Grant Likely
On Sat, Apr 30, 2016 at 12:23 AM, Grant Likely wrote: > I'm pleased to announce the first *very early draft* of the new > devicetree specification that I and several others have been working > on since January. This document picks up where ePAPR left off in 2012. > I'm a

Fwd: Devicetree specification process

2016-04-30 Thread Grant Likely
I'm pleased to announce the first *very early draft* of the new devicetree specification that I and several others have been working on since January. This document picks up where ePAPR left off in 2012. I'm announcing it now along with the new devicetree.org organization which will handle governan

Re: [PATCH v5 39/42] drivers/of: Unflatten nodes equal or deeper than specified level

2015-06-30 Thread Grant Likely
On Thu, 4 Jun 2015 16:42:08 +1000 , Gavin Shan wrote: > unflatten_dt_node() is called recursively to unflatten FDT nodes > with the assumption that FDT blob has only one root node, which > isn't true when the FDT blob represents device sub-tree. The > patch improves the function to supporting de

Re: [PATCH v5 40/42] drivers/of: Allow to specify root node in of_fdt_unflatten_tree()

2015-06-30 Thread Grant Likely
On Thu, 4 Jun 2015 16:42:09 +1000 , Gavin Shan wrote: > The patch introduces one more argument to of_fdt_unflatten_tree() > to specify the root node for the FDT blob, which is going to be > unflattened. In the result, the function can be used to unflatten > FDT blob, which represents device sub-

Re: [PATCH v5 42/42] pci/hotplug: PowerPC PowerNV PCI hotplug driver

2015-06-30 Thread Grant Likely
On Thu, 4 Jun 2015 16:42:11 +1000 , Gavin Shan wrote: > The patch intends to add standalone driver to support PCI hotplug > for PowerPC PowerNV platform, which runs on top of skiboot firmware. > The firmware identified hotpluggable slots and marked their device > tree node with proper "ibm,slot-

Re: [PATCH] Fix pSeries boot failure, by returning interrupt controller node when an interrupt-map property doesn't exist

2015-06-30 Thread Grant Likely
On Tue, 30 Jun 2015 13:23:33 +1000 , Benjamin Herrenschmidt wrote: > On Mon, 2015-06-29 at 18:50 -0500, Jeremy Linton wrote: > > This is a reformat of the patch attached to "pSeries boot failure due > > to wrong interrupt controller". > > > > It allows of_irq_parse_raw() to return the node point

Re: [PATCH v4 19/21] drivers/of: Support adding sub-tree

2015-06-08 Thread Grant Likely
On Mon, Jun 8, 2015 at 9:57 PM, Benjamin Herrenschmidt wrote: > On Sun, 2015-06-07 at 08:54 +0100, Grant Likely wrote: >> > IE. conceptually, what overlays do today is quite rooted around the idea >> > of having a fixed "base" DT and some pre-compiled DTB overlays t

Re: [PATCH v4 19/21] drivers/of: Support adding sub-tree

2015-06-07 Thread Grant Likely
Sorry for not weighing in earlier, I've had other work keeping me away. My short answer: don't use overlays. They're not what you need. Generic CONFIG_OF_DYNAMIC should be all that is required to make changes in your use case. Overlays are a specific api for being able to apply a set of changes i

Re: of/dynamic: Fix test for PPC_PSERIES

2015-06-04 Thread Grant Likely
On Thu, 4 Jun 2015 20:57:32 +1000 (AEST) , Michael Ellerman wrote: > On Thu, 2015-04-06 at 09:34:41 UTC, Geert Uytterhoeven wrote: > > "IS_ENABLED(PPC_PSERIES)" always evaluates to false, as IS_ENABLED() is > > supposed to be used with the full Kconfig symbol name, including the > > "CONFIG_" pr

Re: [PATCH] of: clean-up unnecessary libfdt include paths

2015-06-04 Thread Grant Likely
On Wed, 3 Jun 2015 10:26:38 +0200 , Ralf Baechle wrote: > On Wed, Jun 03, 2015 at 12:10:25AM -0500, Rob Herring wrote: > > Date: Wed, 3 Jun 2015 00:10:25 -0500 > > From: Rob Herring > > To: devicet...@vger.kernel.org, linux-ker...@vger.kernel.org > > Cc:

Re: [PATCH] of: return NUMA_NO_NODE from fallback of_node_to_nid()

2015-06-04 Thread Grant Likely
On Mon, 13 Apr 2015 11:49:31 -0500 , Rob Herring wrote: > On Mon, Apr 13, 2015 at 8:38 AM, Konstantin Khlebnikov > wrote: > > On 13.04.2015 16:22, Rob Herring wrote: > >> > >> On Wed, Apr 8, 2015 at 11:59 AM, Konstantin Khlebnikov > >> wrote: > >>> > >>> Node 0 might be offline as well as any o

Re: drivers/of: Add empty ranges quirk for PA-Semi

2015-03-25 Thread Grant Likely
On Mon, 23 Mar 2015 15:06:35 +1100 , Benjamin Herrenschmidt wrote: > On Mon, 2015-03-23 at 14:50 +1100, Michael Ellerman wrote: > > On Mon, 2015-23-03 at 03:16:38 UTC, Benjamin Herrenschmidt wrote: > > > The "sdc" node is missing the ranges property, it needs to be treated > > > as having an empt

Re: [PATCH v2 07/14] of/reconfig: Always use the same structure for notifiers

2014-11-26 Thread Grant Likely
On Tue, 25 Nov 2014 21:11:58 -0600 , Nathan Fontenot wrote: > On 11/25/2014 05:07 PM, Benjamin Herrenschmidt wrote: > > On Mon, 2014-11-24 at 22:33 +0000, Grant Likely wrote: > >> The OF_RECONFIG notifier callback uses a different structure depending > >> on wheth

[PATCH v2 07/14] of/reconfig: Always use the same structure for notifiers

2014-11-24 Thread Grant Likely
The OF_RECONFIG notifier callback uses a different structure depending on whether it is a node change or a property change. This is silly, and not very safe. Rework the code to use the same data structure regardless of the type of notifier. Signed-off-by: Grant Likely Cc: Benjamin Herrenschmidt

Re: [PATCH v3] of/base: Fix PowerPC address parsing hack

2014-11-18 Thread Grant Likely
e exposed properly > and will fix a number of other embedded cases. > > Signed-off-by: Benjamin Herrenschmidt > CC: Acked-by: Grant Likely Rob will pick up this patch and send it to Linus in his fixups tree for v3.18 g. > --- > > V2: Make it less horrendously

Re: [PATCH] of/platform: Move platform devices under /sys/devices/platform

2014-11-18 Thread Grant Likely
On Tue, 18 Nov 2014 11:36:19 +0100 , Andrzej Hajda wrote: > On 11/04/2014 11:45 AM, Grant Likely wrote: > > Currently the devices created by drivers/of/platform.c get created at > > the root of /sys/devices. This goes against the typical pattern for > > sysfs where the t

Re: [PATCH] of/base: Fix PowerPC address parsing hack

2014-11-13 Thread Grant Likely
On Thu, Nov 13, 2014 at 12:45 AM, Benjamin Herrenschmidt wrote: > What about this one instead ? I want to cache it because that function > can be called quite a while and doing two additional property lookup > and string compares every time might hurt some platforms. > > > > We have a histori

Re: [PATCH] of/base: Fix PowerPC address parsing hack

2014-11-12 Thread Grant Likely
On Wed, 12 Nov 2014 08:39:32 -0600 , Rob Herring wrote: > On Tue, Nov 11, 2014 at 11:51 PM, Benjamin Herrenschmidt > wrote: > > We have a historical hack that treats missing ranges properties as the > > equivalent of an empty one. This is needed for ancient PowerMac "bad" > > device-trees, and s

[PATCH] of/platform: Move platform devices under /sys/devices/platform

2014-11-04 Thread Grant Likely
er a fixed /sys/devices/... path will be affected. It isn't /supposed/ to do that, but if anyone complains then I'll add a default-off workaround option to put them back into the root. Signed-off-by: Grant Likely Cc: Rob Herring Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Benjamin

Re: [PATCH / RFC] PowerPC: boot: Parse chosen/cmdline-timeout parameter

2014-09-09 Thread Grant Likely
On Tue, Sep 9, 2014 at 3:01 PM, Simon Kågström wrote: > A 5 second timeout during boot might be too long, so make it > configurable. > > The property is added to the chosen node, e.g., > > chosen { > bootargs = "console=ttyUL0 root=/dev/ram0"; > linux,stdout

Re: [PATCH] of: make sure of_alias is initialized before accessing it

2014-09-08 Thread Grant Likely
d legacy method. > > [Fixes a752ee5 - tty: Update hypervisor tty drivers to > > use core stdout parsing code] > > Signed-off-by: Laurentiu Tudor > Cc: Grant Likely > --- > drivers/of/base.c | 8 > 1 file changed, 4 insertions(+)

Re: [PATCH] powerpc: Check flat device tree version at boot

2014-08-29 Thread Grant Likely
On 29 Aug 2014 02:56, "Michael Ellerman" wrote: > > On Thu, 2014-08-28 at 09:27 -0500, Rob Herring wrote: > > On Thu, Aug 28, 2014 at 3:40 AM, Michael Ellerman > > wrote: > > > In commit e6a6928c3ea1 "of/fdt: Convert FDT functions to use libfdt", > > > the kernel stopped supporting old flat devi

Re: OF_DYNAMIC node lifecycle

2014-07-16 Thread Grant Likely
On Wed, Jul 16, 2014 at 5:12 PM, Nathan Fontenot wrote: > On 07/16/2014 05:26 PM, Grant Likely wrote: >> On Wed, Jul 16, 2014 at 2:57 PM, Grant Likely >> wrote: >>> On Wed, Jul 16, 2014 at 12:30 PM, Tyrel Datwyler >>> wrote: >>>> On 07/15/2014

Re: OF_DYNAMIC node lifecycle

2014-07-16 Thread Grant Likely
On Wed, Jul 16, 2014 at 2:57 PM, Grant Likely wrote: > On Wed, Jul 16, 2014 at 12:30 PM, Tyrel Datwyler > wrote: >> On 07/15/2014 10:33 PM, Grant Likely wrote: >>> I've got another question about powerpc reconfiguration. I was looking >>> at the dlpar_configure

Re: OF_DYNAMIC node lifecycle

2014-07-16 Thread Grant Likely
On Wed, Jul 16, 2014 at 12:30 PM, Tyrel Datwyler wrote: > On 07/15/2014 10:33 PM, Grant Likely wrote: >> I've got another question about powerpc reconfiguration. I was looking >> at the dlpar_configure_connector() function in dlpar.c. I see that the >> function has the a

Re: OF_DYNAMIC node lifecycle

2014-07-15 Thread Grant Likely
r actually receive more than one node at once? g. On Fri, Jun 27, 2014 at 8:41 AM, Nathan Fontenot wrote: > On 06/27/2014 07:41 AM, Grant Likely wrote: >> On Thu, 26 Jun 2014 15:01:49 -0500, Nathan Fontenot >> wrote: >>> On 06/25/2014 03:24 PM, Grant Likely wrote: >&

Re: [PATCH v2] powerpc/pseries: dynamically added OF nodes need to call of_node_init

2014-07-15 Thread Grant Likely
t; >> Fixes: 0829f6d1f69e ("of: device_node kobject lifecycle fixes") >> Cc: sta...@vger.kernel.org >> Signed-off-by: Tyrel Datwyler > > Acked-by: Nathan Fontenot Acked-by: Grant Likely Ben, are you going to take this or should I take it via my tree? g. >

Re: OF_DYNAMIC node lifecycle

2014-06-27 Thread Grant Likely
On Thu, 26 Jun 2014 15:01:49 -0500, Nathan Fontenot wrote: > On 06/25/2014 03:24 PM, Grant Likely wrote: > > On Tue, 24 Jun 2014 15:10:55 -0500, Nathan Fontenot > > wrote: > >>>> heh! I have often thought about adding reference counting to device tree >

Re: OF_DYNAMIC node lifecycle

2014-06-27 Thread Grant Likely
On Thu, 26 Jun 2014 14:59:31 -0500, Nathan Fontenot wrote: > On 06/25/2014 03:22 PM, Grant Likely wrote: > > On Tue, 24 Jun 2014 15:07:05 -0500, Nathan Fontenot > > wrote: > >> On 06/23/2014 09:58 AM, Grant Likely wrote: > >>> On Thu, 19 Jun 2014 11:33:20 +0

Re: OF_DYNAMIC node lifecycle

2014-06-25 Thread Grant Likely
On Tue, 24 Jun 2014 15:10:55 -0500, Nathan Fontenot wrote: > On 06/23/2014 09:48 AM, Grant Likely wrote: > > On Thu, 19 Jun 2014 10:26:15 -0500, Nathan Fontenot > > wrote: > >> On 06/18/2014 03:07 PM, Grant Likely wrote: > >>> Hi Nathan and Tyrel, > >

Re: OF_DYNAMIC node lifecycle

2014-06-25 Thread Grant Likely
On Tue, 24 Jun 2014 15:07:05 -0500, Nathan Fontenot wrote: > On 06/23/2014 09:58 AM, Grant Likely wrote: > > On Thu, 19 Jun 2014 11:33:20 +0300, Pantelis Antoniou > > wrote: > >> Hi Grant, > >> > >> CCing Thomas Gleixner & Steven Rostedt, since th

Re: OF_DYNAMIC node lifecycle

2014-06-23 Thread Grant Likely
On Mon, 23 Jun 2014 18:26:04 +0300, Pantelis Antoniou wrote: > On Jun 23, 2014, at 5:58 PM, Grant Likely wrote: > > We'll also need a transition plan to move to RCU. I think the existing > > iterators can be modified to do the rcu locking in-line, but still require > >

Re: OF_DYNAMIC node lifecycle

2014-06-23 Thread Grant Likely
On Thu, 19 Jun 2014 11:33:20 +0300, Pantelis Antoniou wrote: > Hi Grant, > > CCing Thomas Gleixner & Steven Rostedt, since they might have a few > ideas... > > On Jun 18, 2014, at 11:07 PM, Grant Likely wrote: > > > Hi Nathan and Tyrel, > > > >

Re: OF_DYNAMIC node lifecycle

2014-06-23 Thread Grant Likely
On Thu, 19 Jun 2014 10:26:15 -0500, Nathan Fontenot wrote: > On 06/18/2014 03:07 PM, Grant Likely wrote: > > Hi Nathan and Tyrel, > > > > I'm looking into lifecycle issues on nodes modified by OF_DYNAMIC, and > > I'm hoping you can help me. Right now, pse

Re: [RFC PATCH V3 14/17] ppc/pci: create/release dev-tree node for VFs

2014-06-19 Thread Grant Likely
On Thu, Jun 19, 2014 at 3:46 AM, Wei Yang wrote: > On Wed, Jun 18, 2014 at 07:26:27PM +0100, Grant Likely wrote: >>On Tue, Jun 10, 2014 at 2:56 AM, Wei Yang wrote: >>> Currently, powernv platform is not aware of VFs. This means no dev-node >>> represents a VF. Also, VF

OF_DYNAMIC node lifecycle

2014-06-18 Thread Grant Likely
Hi Nathan and Tyrel, I'm looking into lifecycle issues on nodes modified by OF_DYNAMIC, and I'm hoping you can help me. Right now, pseries seems to be the only user of OF_DYNAMIC, but making OF_DYNAMIC work has a huge impact on the entire kernel because it requires all DT code to manage reference

Re: [RFC PATCH V3 14/17] ppc/pci: create/release dev-tree node for VFs

2014-06-18 Thread Grant Likely
On Tue, Jun 10, 2014 at 2:56 AM, Wei Yang wrote: > Currently, powernv platform is not aware of VFs. This means no dev-node > represents a VF. Also, VF PCI device is created when PF driver want to enable > it. This leads to the pdn->pdev and pdn->pe_number an invalid value. > > This patch create/re

Re: [PATCH 3/3] of: Handle memory@0 node on PPC32 only

2014-05-15 Thread Grant Likely
On Thu, 24 Apr 2014 10:26:42 +0100, Leif Lindholm wrote: > On Wed, Apr 23, 2014 at 02:10:58PM +0100, Grant Likely wrote: > > > Does anyone have a LongTrail DT to hand, and if so does the root have a > > > compatible string? From grepping through the kernel I could only find

Re: [PATCH v2 00/21] FDT clean-ups and libfdt support

2014-04-29 Thread Grant Likely
put into linux-next in a few > days. Please test! I've compiled on arm, arm64, mips, microblaze, xtensa, > and powerpc and booted on arm and arm64. This is pretty great work. I'll read through them again and I may have a comment or two, but in general you can add my tested by tag:

Re: [PATCH 0/3] of: dts: enable memory@0 quirk for PPC32 only

2014-04-23 Thread Grant Likely
On Tue, 22 Apr 2014 15:05:26 +0100, Leif Lindholm wrote: > On Tue, Apr 22, 2014 at 02:08:29PM +0100, Grant Likely wrote: > > > I would prefer to see a "WARN_ON(!IS_ENABLED(CONFIG_PPC32));" added here. > > > > I completely agree. > > OK. So do we keep th

Re: [PATCH 0/3] of: dts: enable memory@0 quirk for PPC32 only

2014-04-23 Thread Grant Likely
On Tue, 22 Apr 2014 15:05:26 +0100, Leif Lindholm wrote: > On Tue, Apr 22, 2014 at 02:08:29PM +0100, Grant Likely wrote: > > > I would prefer to see a "WARN_ON(!IS_ENABLED(CONFIG_PPC32));" added here. > > > > I completely agree. > > OK. So do we keep th

Re: [PATCH 3/3] of: Handle memory@0 node on PPC32 only

2014-04-23 Thread Grant Likely
On Wed, 23 Apr 2014 11:45:28 +0100, Mark Rutland wrote: > On Tue, Apr 22, 2014 at 02:35:15PM +0100, Grant Likely wrote: > > On Fri, 18 Apr 2014 13:59:24 +0100, Leif Lindholm > > wrote: > > > Hi Geert, > > > > > > On Fri, Apr 18, 2014 at 10:04:15AM +

Re: [PATCH 3/3] of: Handle memory@0 node on PPC32 only

2014-04-22 Thread Grant Likely
On Fri, 18 Apr 2014 13:59:24 +0100, Leif Lindholm wrote: > Hi Geert, > > On Fri, Apr 18, 2014 at 10:04:15AM +0200, Geert Uytterhoeven wrote: > > On Thu, Apr 17, 2014 at 7:42 PM, Leif Lindholm > > wrote: > > > In order to deal with an firmware bug on a specific ppc32 platform > > > (longtrail),

Re: [PATCH 0/3] of: dts: enable memory@0 quirk for PPC32 only

2014-04-22 Thread Grant Likely
On Fri, 18 Apr 2014 10:37:58 -0500, Rob Herring wrote: > On Fri, Apr 18, 2014 at 7:48 AM, Leif Lindholm > wrote: > > On Thu, Apr 17, 2014 at 07:43:13PM -0500, Rob Herring wrote: > >> On Thu, Apr 17, 2014 at 12:41 PM, Leif Lindholm > >> wrote: > >> > drivers/of/fdt.c contains a workaround for a

Re: [PATCH v6 00/11] reserved-memory regions/CMA in devicetree, again

2014-03-31 Thread Grant Likely
On Tue, Mar 11, 2014 at 10:37 AM, Grant Likely wrote: > Hi Ben, Russell and Catalin, > > I've got this series queued up, and I'd like to be ready to merge it > in the next merge window. I'm going to queue it up in linux-next. If > you have any concerns, please shout

Re: [PATCH] of: give priority to the compatible match in __of_match_node()

2014-02-19 Thread Grant Likely
On Wed, 19 Feb 2014 16:23:02 -0500, Paul Gortmaker wrote: > On 14-02-19 03:41 PM, Grant Likely wrote: > > On Wed, 19 Feb 2014 13:25:54 -0500, Paul Gortmaker > > wrote: > >> On Thu, Feb 13, 2014 at 2:01 PM, Rob Herring wrote: > >>> On Wed, Feb 12, 2014 at 5:

Re: [PATCH] of: give priority to the compatible match in __of_match_node()

2014-02-19 Thread Grant Likely
atible && type > 3. specific compatible && name > 4. specific compatible > 5. general compatible && type && name > 6. general compatible && type > 7. general compatible && name > 8. general compatible >

Re: [PATCH] of: give priority to the compatible match in __of_match_node()

2014-02-17 Thread Grant Likely
On Thu, 13 Feb 2014 13:01:42 -0600, Rob Herring wrote: > On Wed, Feb 12, 2014 at 5:38 AM, Kevin Hao wrote: > > When the device node do have a compatible property, we definitely > > prefer the compatible match besides the type and name. Only if > > there is no such a match, we then consider the ca

Re: [PATCH 2/2] of: search the best compatible match first in __of_match_node()

2014-02-17 Thread Grant Likely
On Fri, 14 Feb 2014 09:53:40 -0600, Rob Herring wrote: > On Thu, Feb 13, 2014 at 11:22 PM, Kevin Hao wrote: > > Currently, of_match_node compares each given match against all node's > > compatible strings with of_device_is_compatible. > > > > To achieve multiple compatible strings per node with o

Re: [PATCH 2/2] of: search the best compatible match first in __of_match_node()

2014-02-17 Thread Grant Likely
On Fri, 14 Feb 2014 13:22:46 +0800, Kevin Hao wrote: > Currently, of_match_node compares each given match against all node's > compatible strings with of_device_is_compatible. > > To achieve multiple compatible strings per node with ordering from > specific to generic, this requires given matches

Re: [PATCH 0/2] move of_find_next_cache_node to DT core

2013-11-02 Thread Grant Likely
On Fri, 04 Oct 2013 11:42:49 +0100, Sudeep KarkadaNagesha wrote: > Hi Grant, > > On 18/09/13 17:18, Sudeep KarkadaNagesha wrote: > > On 18/09/13 15:51, Grant Likely wrote: > >> On Wed, 18 Sep 2013 11:53:03 +0100, Sudeep KarkadaNagesha > >> wrote:

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-25 Thread Grant Likely
On Wed, 9 Oct 2013 14:38:24 +0800, wrote: > From: Tang Yuantian > > The following SoCs will be affected: p2041, p3041, p4080, > p5020, p5040, b4420, b4860, t4240 > > Signed-off-by: Tang Yuantian > Signed-off-by: Li Yang > --- > v5: > - refine the binding document > - update the co

Re: [PATCH v2 08/10] of/platform: Resolve interrupt references at probe time

2013-10-24 Thread Grant Likely
On Wed, 16 Oct 2013 00:24:36 +0100, Grant Likely wrote: > On Wed, 18 Sep 2013 15:24:50 +0200, Thierry Reding > wrote: > > Interrupt references are currently resolved very early (when a device is > > created). This has the disadvantage that it will fail in cases where the &g

Re: [PATCH v2 08/10] of/platform: Resolve interrupt references at probe time

2013-10-15 Thread Grant Likely
On Wed, 18 Sep 2013 15:24:50 +0200, Thierry Reding wrote: > Interrupt references are currently resolved very early (when a device is > created). This has the disadvantage that it will fail in cases where the > interrupt parent hasn't been probed and no IRQ domain for it has been > registered yet.

Re: [PATCH v2 04/10] irqdomain: Return errors from irq_create_of_mapping()

2013-10-15 Thread Grant Likely
On Mon, 23 Sep 2013 10:13:38 +0200, Thierry Reding wrote: > On Sun, Sep 22, 2013 at 04:14:43PM -0500, Rob Herring wrote: > > On Wed, Sep 18, 2013 at 8:24 AM, Thierry Reding > > wrote: > > > Instead of returning 0 for all errors, allow the precise error code to > > > be propagated. This will be u

Re: [PATCH v2 01/10] of/irq: Rework of_irq_count()

2013-10-15 Thread Grant Likely
On Sun, 22 Sep 2013 16:19:27 -0500, Rob Herring wrote: > On Wed, Sep 18, 2013 at 8:24 AM, Thierry Reding > wrote: > > The of_irq_to_resource() helper that is used to implement of_irq_count() > > tries to resolve interrupts and in fact creates a mapping for resolved > > interrupts. That's pretty h

Re: [PATCH v2 01/10] of/irq: Rework of_irq_count()

2013-10-15 Thread Grant Likely
On Sun, 22 Sep 2013 16:19:27 -0500, Rob Herring wrote: > On Wed, Sep 18, 2013 at 8:24 AM, Thierry Reding > wrote: > > The of_irq_to_resource() helper that is used to implement of_irq_count() > > tries to resolve interrupts and in fact creates a mapping for resolved > > interrupts. That's pretty h

Re: [PATCH 22/51] DMA-API: amba: get rid of separate dma_mask

2013-09-22 Thread Grant Likely
On Thu, 19 Sep 2013 22:47:01 +0100, Russell King wrote: > AMBA Primecell devices always treat streaming and coherent DMA exactly > the same, so there's no point in having the masks separated. > > Signed-off-by: Russell King for the drivers/of/platform.c portion: Acked-by:

Re: [PATCH 0/2] move of_find_next_cache_node to DT core

2013-09-18 Thread Grant Likely
ode to DT common code. > > Regards, > Sudeep Acked-by: Grant Likely However, do you have a user for this function on other architectures yet? I'd like to see a user for the function in the same patch series.. g. > > Sudeep KarkadaNagesha (2): > powerpc: remove big endi

Re: [PATCH] of: Feed entire flattened device tree into the random pool

2013-08-29 Thread Grant Likely
On Mon, 29 Jul 2013 13:11:50 +1000, Anton Blanchard wrote: > > Hi, > > > be32_to_cpu(initial_boot_params->totalsize); > > Ouch, thanks Grant. > > Anton > -- > > We feed the entire DMI table into the random pool to provide > better random data during early boot, so do the same with the > flatt

Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures

2013-08-28 Thread Grant Likely
On Thu, 22 Aug 2013 14:59:30 +0100, Mark Rutland wrote: > On Mon, Aug 19, 2013 at 02:56:10PM +0100, Sudeep KarkadaNagesha wrote: > > On 19/08/13 14:02, Rob Herring wrote: > > > On 08/19/2013 05:19 AM, Mark Rutland wrote: > > >> On Sat, Aug 17, 2013 at 11:09:36PM +0100, Benjamin Herrenschmidt wrote

Re: [PATCH V3] i2c: move of helpers into the core

2013-08-28 Thread Grant Likely
gister child nodes in the core instead of doing this manually > in each driver. So, fix the drivers and documentation, too. > > Acked-by: Rob Herring > Reviewed-by: Felipe Balbi > Acked-by: Rafael J. Wysocki > Tested-by: Sylwester Nawrocki > Signed-off-by: Wolf

Re: [PATCH] of: Feed entire flattened device tree into the random pool

2013-07-27 Thread Grant Likely
On Thu, 25 Jul 2013 14:30:31 +1000, Anton Blanchard wrote: > > Hi Michael, > > > But why not put the initcall in drivers/of/fdt.c, that way it's not > > early but it's still common ? > > Good idea! How does this look? So long as it happens before > module_init(rand_initialize) we should be good

Re: [RFC 11/14] powerpc: Eliminate NO_IRQ usage

2013-07-25 Thread Grant Likely
On Thu, Jul 25, 2013 at 3:58 PM, Geert Uytterhoeven wrote: > On Wed, Jan 11, 2012 at 9:22 PM, Grant Likely > wrote: >> NO_IRQ is evil. Stop using it in arch/powerpc and powerpc device drivers > >> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c >> in

Re: [PATCH v2] of: Specify initrd location using 64-bit

2013-07-20 Thread Grant Likely
On Mon, 01 Jul 2013 16:34:26 -0500, Rob Herring wrote: > On 07/01/2013 01:20 PM, Santosh Shilimkar wrote: > > On some PAE architectures, the entire range of physical memory could reside > > outside the 32-bit limit. These systems need the ability to specify the > > initrd location using 64-bit nu

Re: [PATCH] of: Fix address decoding on Bimini and js2x machines

2013-07-04 Thread Grant Likely
On Wed, 3 Jul 2013 15:37:56 +0100, Grant Likely wrote: > On Wed, Jul 3, 2013 at 3:10 PM, Rob Herring wrote: > > On 07/03/2013 01:01 AM, Benjamin Herrenschmidt wrote: > >> Commit: > >> > >> e38c0a1fbc5803cbacdaac0557c70ac8ca5152e7 > >> of

Re: [PATCH] of: Fix address decoding on Bimini and js2x machines

2013-07-03 Thread Grant Likely
On Wed, Jul 3, 2013 at 3:10 PM, Rob Herring wrote: > On 07/03/2013 01:01 AM, Benjamin Herrenschmidt wrote: >> Commit: >> >> e38c0a1fbc5803cbacdaac0557c70ac8ca5152e7 >> of/address: Handle #address-cells > 2 specially >> >> broke real time clock access on Bimini, js2x, and similar powerpc >> ma

Re: [PATCH] of: Specify initrd location using 64-bit

2013-06-28 Thread Grant Likely
On Thu, Jun 27, 2013 at 9:54 PM, Rob Herring wrote: > On 06/21/2013 12:20 PM, Santosh Shilimkar wrote: >> On Friday 21 June 2013 05:04 AM, Sebastian Andrzej Siewior wrote: >>> On 06/21/2013 02:52 AM, Santosh Shilimkar wrote: diff --git a/arch/microblaze/kernel/prom.c b/arch/microblaze/kernel/

Re: [PATCH v2 08/11] irqdomain: Refactor irq_domain_associate_many()

2013-06-18 Thread Grant Likely
On Tue, Jun 18, 2013 at 12:04 PM, Michael Neuling wrote: > Grant Likely wrote: > >> On Tue, 18 Jun 2013 10:05:31 +0100, Grant Likely >> wrote: >> > On Tue, Jun 18, 2013 at 2:25 AM, Michael Neuling wrote: >> > > Michael Neuling wrote: >> > >

Re: [PATCH v2 08/11] irqdomain: Refactor irq_domain_associate_many()

2013-06-18 Thread Grant Likely
On Tue, 18 Jun 2013 10:05:31 +0100, Grant Likely wrote: > On Tue, Jun 18, 2013 at 2:25 AM, Michael Neuling wrote: > > Michael Neuling wrote: > > > >> Grant, > >> > >> In next-20130617 we are getting the below crash on POWER7. Bisecting, >

Re: [PATCH v2 08/11] irqdomain: Refactor irq_domain_associate_many()

2013-06-18 Thread Grant Likely
On Tue, Jun 18, 2013 at 2:25 AM, Michael Neuling wrote: > Michael Neuling wrote: > >> Grant, >> >> In next-20130617 we are getting the below crash on POWER7. Bisecting, >> points to this patch (d39046ec72 in next) > > Also, reverting just d39046ec72 fixes the crash in next-20130617. Odd. Of all

Re: [RFC 08/10] irqdomain: Refactor irq_domain_associate_many()

2013-06-18 Thread Grant Likely
On Tue, Jun 18, 2013 at 4:09 AM, Mike Qiu wrote: > 于 2013/6/10 8:49, Grant Likely 写道: > >> Originally, irq_domain_associate_many() was designed to unwind the >> mapped irqs on a failure of any individual association. However, that >> proved to be a problem with certain

Re: [RFC 10/10] irqchip: Make versatile fpga irq driver a generic chip

2013-06-15 Thread Grant Likely
On Sat, Jun 15, 2013 at 10:22 PM, Linus Walleij wrote: > On Sat, Jun 15, 2013 at 11:19 PM, Linus Walleij > wrote: >> It still works like a charm on the Integrator/AP. >> Tested-by: Linus Walleij > > BTW here is the new hwirq output in /proc/interrupts and it's really nice: > > root@integrator:/p

Re: [PATCH] dtc: ensure #line directives don't consume data from the next line

2013-06-14 Thread Grant Likely
On Wed, 05 Jun 2013 10:50:02 -0600, Stephen Warren wrote: > On 06/03/2013 09:36 AM, Stephen Warren wrote: > > From: Stephen Warren > > > > Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} > > could match line-break characters. If the #line directive did not contain > > th

Re: [PATCH 1/5] ibmebus: convert of_platform_driver to platform_driver

2013-06-12 Thread Grant Likely
On Wed, 12 Jun 2013 15:29:38 +1000, Benjamin Herrenschmidt wrote: > On Wed, 2013-05-22 at 07:26 -0500, Rob Herring wrote: > > > git://sources.calxeda.com/kernel/linux.git of-platform-removal > > > > Ben, > > > > Did you have a chance to test this? I want to get this into -next. > > I tested th

Re: [PATCH] of: Fix locking vs. interrupts

2013-06-12 Thread Grant Likely
On Wed, 12 Jun 2013 10:25:56 +0200 (CEST), Thomas Gleixner wrote: > On Wed, 12 Jun 2013, Benjamin Herrenschmidt wrote: > > > The OF code uses irqsafe locks everywhere except in a handful of functions > > for no obvious reasons. Since the conversion from the old rwlocks, this > > now triggers loc

Re: [RFC 10/10] irqchip: Make versatile fpga irq driver a generic chip

2013-06-10 Thread Grant Likely
On Mon, Jun 10, 2013 at 8:40 AM, Linus Walleij wrote: > On Mon, Jun 10, 2013 at 2:49 AM, Grant Likely wrote: > >> This is an RFC patch to convert the versatile FPGA irq controller driver >> to use generic irq chip. It builds on the series that extends the >> generic chi

Re: [RFC 10/10] irqchip: Make versatile fpga irq driver a generic chip

2013-06-10 Thread Grant Likely
On Mon, Jun 10, 2013 at 10:03 AM, Russell King - ARM Linux wrote: > On Mon, Jun 10, 2013 at 01:49:22AM +0100, Grant Likely wrote: >> This is an RFC patch to convert the versatile FPGA irq controller driver >> to use generic irq chip. It builds on the series that extends the >&

[RFC 10/10] irqchip: Make versatile fpga irq driver a generic chip

2013-06-09 Thread Grant Likely
neric chip setup. I've written this as a proof of concept to see if the new generic irq code does what it needs to. I had to extend it slightly to properly handle the valid mask used by the versatile FPGA driver. Tested on QEMU, but not on real hardware. Signed-off-by: Grant Likely Cc: Ru

[RFC 09/10] irqdomain: remove irq_domain_generate_simple()

2013-06-09 Thread Grant Likely
Nobody calls it; remove the function Signed-off-by: Grant Likely --- include/linux/irqdomain.h | 8 kernel/irq/irqdomain.c| 15 --- 2 files changed, 23 deletions(-) diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h index f9e8e06..fe7c57d 100644 --- a

[RFC 08/10] irqdomain: Refactor irq_domain_associate_many()

2013-06-09 Thread Grant Likely
n. Signed-off-by: Grant Likely --- include/linux/irqdomain.h | 22 +++--- kernel/irq/irqdomain.c| 185 +++--- 2 files changed, 101 insertions(+), 106 deletions(-) diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h index fd4b26f..f9e8

[RFC 06/10] irqdomain: Clean up aftermath of irq_domain refactoring

2013-06-09 Thread Grant Likely
After refactoring the irqdomain code, there are a number of API functions that are merely empty wrappers around core code. Drop those wrappers out of the C file and replace them with static inlines in the header. Signed-off-by: Grant Likely --- arch/powerpc/platforms/cell/beat_interrupt.c | 2

[RFC 07/10] irqdomain: Beef up debugfs output

2013-06-09 Thread Grant Likely
issues to be able to see the entire list of mapped irqs, not just the ones that happen to be connected to devices. Signed-off-by: Grant Likely --- kernel/irq/irqdomain.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/kernel/irq/irqdomain.c b

[RFC 05/10] irqdomain: Eliminate revmap type

2013-06-09 Thread Grant Likely
dling IRQs. Signed-off-by: Grant Likely --- include/linux/irqdomain.h | 48 + kernel/irq/generic-chip.c | 5 + kernel/irq/irqdomain.c| 55 +++ 3 files changed, 43 insertions(+), 65 deletions(-) diff --

[RFC 04/10] irqdomain: merge linear and tree reverse mappings.

2013-06-09 Thread Grant Likely
From: Grant Likely Keeping them separate makes irq_domain more complex and adds a lot of code (as proven by the diffstat). Merging them simplifies the whole scheme. This change makes it so both the tree and linear methods can be used by the same irq_domain instance. If the hwirq is less than

[RFC 03/10] irqdomain: Add a name field

2013-06-09 Thread Grant Likely
in irq domain log messages and debugfs output. Signed-off-by: Grant Likely --- include/linux/irqdomain.h | 1 + kernel/irq/generic-chip.c | 1 + kernel/irq/irqdomain.c| 19 ++- 3 files changed, 8 insertions(+), 13 deletions(-) diff --git a/include/linux/irqdomain.h b/include

[RFC 02/10] irqdomain: Replace LEGACY mapping with LINEAR

2013-06-09 Thread Grant Likely
linear map. It also makes it possible for current LEGACY map users to pre-allocate irq_descs for a subset of the hwirqs and dynamically allocate the rest as needed. Signed-off-by: Grant Likely Cc: Paul Mundt Cc: Benjamin Herrenschmidt Cc: Thomas Gleixner Cc: Rob Herring --- include/linux

[RFC 01/10] irqdomain: Relax failure path on setting up mappings

2013-06-09 Thread Grant Likely
here is no reason to fail the entire allocation. v2: Still output an information message on failed mappings and make sure attempted mapping gets cleared out of the irq_data structure. Signed-off-by: Grant Likely Cc: Paul Mundt Cc: Benjamin Herrenschmidt Cc: Thomas Gleixner --- kernel/irq/i

[RFC 00/10] Refactor irqdomain

2013-06-09 Thread Grant Likely
I've done a bunch of refactoring work on the irq_domain infrastructure. Some of these patches I've posted before, and some our brand new. The goal of this is to greatly simplify how irq_domains work. With this series, instead of there being multiple different types of irq domains, each with differe

Re: [PATCH 1/3] irq: Set multiple MSI descriptor data for multiple IRQs

2013-06-05 Thread Grant Likely
On Tue, 15 Jan 2013 15:38:54 +0800, Mike Qiu wrote: > Multiple MSI only requires the IRQ in msi_desc entry to be set as > the value of irq_base. > > This patch implements the above mentioned technique. > > Signed-off-by: Mike Qiu Hi Mike, question below... > --- > +int irq_set_multiple_msi_d

Re: DTB build failure due to preproccessing

2013-05-31 Thread Grant Likely
On Fri, May 31, 2013 at 5:04 PM, Stephen Warren wrote: > On 05/31/2013 05:48 AM, Grant Likely wrote: >> On Fri, 31 May 2013 11:29:30 +0100, Ian Campbell >> wrote: >>> This affects arch/powerpc/boot/dts/virtex440-ml510.dts but I think it is >>&

Re: DTB build failure due to preproccessing

2013-05-31 Thread Grant Likely
of these preprocessor line number comments since it manages to > report the original source line number. dtc is only able to track line numbers when the native /include/ directive is used. The #include directive doesn't help it. It should be added, but until it is the following patch solves th

Re: [PATCH] irqdomain: Allow quiet failure mode

2013-05-06 Thread Grant Likely
ssage for diagnostic purposes. > > Signed-off-by: Benjamin Herrenschmidt > > > Grant, I'm happy to merge that myself provided I have your ack, > it fixes an annoying problem on Cell introduced by previous changes > to irqdomain (not recent but users started to notice).

  1   2   3   4   5   6   7   8   9   10   >