Re: [PATCH] bus: Make remove callback return void

2021-07-06 Thread Heikki Krogerus
that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Signed-off-by: Uwe Kleine-König For ulpi and typec: Acked-by: Heikki Krogerus thanks, -- heikki

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Heikki Krogerus
t; @@ -1408,8 +1408,6 @@ static int ucsi_ccg_remove(struct i2c_client *client) > ucsi_unregister(uc->ucsi); > ucsi_destroy(uc->ucsi); > free_irq(uc->irq, uc); > - > - return 0; > } > > static const struct i2c_device_id ucsi_ccg_device_id[] = { > diff --git a/drivers/usb/typec/wusb3801.c b/drivers/usb/typec/wusb3801.c > index e63509f8b01e..3cc7a15ecbd3 100644 > --- a/drivers/usb/typec/wusb3801.c > +++ b/drivers/usb/typec/wusb3801.c > @@ -399,7 +399,7 @@ static int wusb3801_probe(struct i2c_client *client) > return ret; > } > > -static int wusb3801_remove(struct i2c_client *client) > +static void wusb3801_remove(struct i2c_client *client) > { > struct wusb3801 *wusb3801 = i2c_get_clientdata(client); > > @@ -411,8 +411,6 @@ static int wusb3801_remove(struct i2c_client *client) > > if (wusb3801->vbus_on) > regulator_disable(wusb3801->vbus_supply); > - > - return 0; > } Reviewed-by: Heikki Krogerus -- heikki

Re: [PATCH 1/2] usb: phy: fsl-usb: drop driver owner assignment

2024-04-02 Thread Heikki Krogerus
On Wed, Mar 27, 2024 at 06:46:08PM +0100, Krzysztof Kozlowski wrote: > Core in platform_driver_register() already sets the .owner, so driver > does not need to. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Heikki Krogerus > --- > drivers/usb/phy/phy-fsl-usb.c | 1 -

Re: [PATCH 2/2] usb: typec: nvidia: drop driver owner assignment

2024-04-02 Thread Heikki Krogerus
On Wed, Mar 27, 2024 at 06:46:09PM +0100, Krzysztof Kozlowski wrote: > Core in typec_altmode_register_driver() already sets the .owner, so > driver does not need to. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/altmodes/n

Re: [PATCH v2 2/3] usb: typec: nvidia: drop driver owner assignment

2024-04-03 Thread Heikki Krogerus
On Sun, Mar 31, 2024 at 11:17:36AM +0200, Krzysztof Kozlowski wrote: > Core in typec_altmode_register_driver() already sets the .owner, so > driver does not need to. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Heikki Krogerus > --- > > Changes in v2: > 1. N

Re: [PATCH v2 3/3] usb: typec: displayport: drop driver owner assignment

2024-04-03 Thread Heikki Krogerus
On Sun, Mar 31, 2024 at 11:17:37AM +0200, Krzysztof Kozlowski wrote: > Core in typec_altmode_register_driver() already sets the .owner, so > driver does not need to. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Heikki Krogerus > --- > > Changes in v2: > 1. Ne