Re: [PATCH] ASoC: fsl_esai: change dev_warn to dev_dbg in irq handler

2024-10-11 Thread Iuliana Prodan
On 10/11/2024 7:53 AM, Shengjiu Wang wrote: Irq handler need to be executed as fast as possible, so the log in irq handler is better to use dev_dbg which needs to be enabled when debugging. Signed-off-by: Shengjiu Wang Reviewed-by: Iuliana Prodan Thanks, Iulia --- sound/soc/fsl

Re: [PATCH 0/2] ASoC: imx-card: add cs42888 codec support

2024-10-10 Thread Iuliana Prodan
On 10/9/2024 10:46 AM, Shengjiu Wang wrote: add cs42888 codec support Chancel Liu (2): ASoC: imx-card: Set mclk for codec ASoC: imx-card: Add CS42888 support For the series: Reviewed-by: Iuliana Prodan Thanks, Iulia sound/soc/fsl/imx-card.c | 59

Re: [PATCH 0/2] ASoC: fsl_micfil: Check the difference for i.MX8 and i.MX9

2024-07-29 Thread Iuliana Prodan
watermark mask ASoC: fsl_micfil: Differentiate register access permission for platforms sound/soc/fsl/fsl_micfil.c | 20 +++- sound/soc/fsl/fsl_micfil.h | 2 +- 2 files changed, 16 insertions(+), 6 deletions(-) For the series: Reviewed-by: Iuliana Prodan Thanks, Iulia

Re: [PATCH] ASoC: fsl_xcvr: refine the requested phy clock frequency

2023-11-23 Thread Iuliana Prodan
sai_pll_bypass sai_pll_out sai_pll_out_div2 earc_phy_cg Signed-off-by: Shengjiu Wang Reviewed-by: Iuliana Prodan Thanks, Iulia --- sound/soc/fsl/fsl_xcvr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound

Re: [PATCH] ASoC: fsl_sai: Fix pins setting for i.MX8QM platform

2023-04-19 Thread Iuliana Prodan
On 4/18/2023 12:42 PM, Chancel Liu wrote: SAI on i.MX8QM platform supports the data lines up to 4. So the pins setting should be corrected to 4. Fixes: eba0f0077519 ("ASoC: fsl_sai: Enable combine mode soft") Signed-off-by: Chancel Liu --- Reviewed-by: Iuliana Prodan Tha

Re: [PATCH] ASoC: fsl: Simplify an error message

2023-04-17 Thread Iuliana Prodan
On 4/16/2023 9:29 AM, Christophe JAILLET wrote: dev_err_probe() already display the error code. There is no need to duplicate it explicitly in the error message. Signed-off-by: Christophe JAILLET Reviewed-by: Iuliana Prodan Thanks, Iulia --- sound/soc/fsl/fsl-asoc-card.c | 2 +- 1

Re: [PATCH] ASoC: fsl_sai: fix getting version from VERID

2023-02-07 Thread Iuliana Prodan
= val & FSL_SAI_VERID_FEATURE_MASK; ret = regmap_read(sai->regmap, FSL_SAI_PARAM, &val); I would put the version in one line, but probably is easier to read this way. Also, please explain, in commit message, what and from where is 0x0301 - might worth adding a macro for this, in anot

Re: [PATCH] ASoC: fsl_sai: initialize is_dsp_mode flag

2023-01-16 Thread Iuliana Prodan
to initialize is_dsp_mode flag every time. Fixes: a3f7dcc9cc03 ("ASoC: fsl-sai: Add SND_SOC_DAIFMT_DSP_A/B support.") Signed-off-by: Shengjiu Wang Reviewed-by: Iuliana Prodan Thanks, Iulia --- sound/soc/fsl/fsl_sai.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sou