Re: [PATCH 3/9] fs_enet: Don't share the interrupt.

2007-09-28 Thread Jeff Garzik
Scott Wood wrote: > This driver can't handle an interrupt immediately after request_irq You MUST assume that you will receive an interrupt immediately after request_irq(). If fs_enet cannot handle that, then that is what wants fixing. Please send along a fix for this, rather than band-aiding t

Re: 2.6.23-rc6-mm1: Build failure on ppc64 drivers/ata/pata_scc.c

2007-09-25 Thread Jeff Garzik
Satyam Sharma wrote: > Hi, > > > On Thu, 20 Sep 2007, Alan Cox wrote: >> On Thu, 20 Sep 2007 14:13:15 +0100 >> [EMAIL PROTECTED] (Mel Gorman) wrote: >> >>> PPC64 building allmodconfig fails to compile drivers/ata/pata_scc.c . It >>> doesn't show up on other arches because this driver is specific

Re: [PATCH 1/2] [FS_ENET] TX stuff should use fep->tx_lock, instead of fep->lock.

2007-09-19 Thread Jeff Garzik
Vitaly Bordug wrote: > Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> > > --- > > drivers/net/fs_enet/fs_enet-main.c |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) applied 1-2, after hand-editing the subject line to remove brackets from around "[FS_ENET]" everything withi

Re: [PATCH] ucc_geth: fix compilation

2007-09-15 Thread Jeff Garzik
Anton Vorontsov wrote: > Currently qe_bd_t is used in the macro call -- dma_unmap_single, > which is a no-op on PPC32, thus error is hidden today. Starting > with 2.6.24, macro will be replaced by the empty static function, > and erroneous use of qe_bd_t will trigger compilation error. > > Signed-

Re: [PATCH 1/2][RESEND] ehea: propagate physical port state

2007-09-12 Thread Jeff Garzik
Jan-Bernd Themann wrote: > Introduces a module parameter to decide whether the physical > port link state is propagated to the network stack or not. > It makes sense not to take the physical port state into account > on machines with more logical partitions that communicate > with each other. This

Re: [PATCH v2] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

2007-08-31 Thread Jeff Garzik
Olof Johansson wrote: > Move away from using the pci config access functions for simple register > access. Our device has all of the registers in the config space (hey, > from the hardware point of view it looks reasonable :-), so we need to > somehow get to it. Newer firmwares have it in the devi

Re: [PATCH] [01/10] pasemi_mac: Abstract out register access

2007-08-31 Thread Jeff Garzik
applied ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] bmac: add simple ethtool support for network manager

2007-08-31 Thread Jeff Garzik
Olaf Hering wrote: > NetworkManager will not start dhcpd on an interface unless it reports > link-up state via ethtool. > > Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> > > --- > drivers/net/bmac.c | 13 + > 1 file changed, 13 insertions(+) applied

Re: [PATCH 1/6] ibmveth: Enable TCP checksum offload

2007-08-31 Thread Jeff Garzik
Brian King wrote: > This patchset enables TCP checksum offload support for IPV4 > on ibmveth. This completely eliminates the generation and checking of > the checksum for packets that are completely virtual and never > touch a physical network. A simple TCP_STREAM netperf run on > a virtual network

Re: [PATCH 1/7] Generic bitbanged MDIO library

2007-08-31 Thread Jeff Garzik
Scott Wood wrote: > Previously, bitbanged MDIO was only supported in individual > hardware-specific drivers. This code factors out the higher level > protocol implementation, reducing the hardware-specific portion to > functions setting direction, data, and clock. > > Signed-off-by: Scott Wood <[

Re: [PATCH 2/7] fs_enet: Whitespace cleanup.

2007-08-31 Thread Jeff Garzik
Scott Wood wrote: > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > drivers/net/fs_enet/fs_enet-main.c | 85 --- > drivers/net/fs_enet/fs_enet.h |4 +- > drivers/net/fs_enet/mac-fcc.c |1 - > drivers/net/fs_enet/mii-fec.c |1 - > 4

Re: [PATCH 3/6] ibmveth: Add ethtool TSO handlers

2007-08-31 Thread Jeff Garzik
Brian King wrote: > Add handlers for get_tso and get_ufo to prevent errors being printed > by ethtool. > > Signed-off-by: Brian King <[EMAIL PROTECTED]> > --- > > linux-2.6-bjking1/drivers/net/ibmveth.c |2 ++ > 1 file changed, 2 insertions(+) > > diff -puN drivers/net/ibmveth.c~ibmveth_eth

Re: [PATCH 1/4] ehea: fix interface to DLPAR tools

2007-08-24 Thread Jeff Garzik
Jan-Bernd Themann wrote: > Userspace DLPAR tool expects decimal numbers to be written to > and read from sysfs entries. > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> applied 1-3 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://

Re: [PATCH] ucc_geth: kill unused include

2007-08-24 Thread Jeff Garzik
Kumar Gala wrote: > The ucc_geth_mii code is based on the gianfar_mii code that use to include > ocp.h. ucc never need this and it causes issues when we want to kill > arch/ppc includes from arch/powerpc. > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> > --- > > Jeff, if you issue with this fo

Re: [PATCH 4/4] ehea: show physical port state

2007-08-24 Thread Jeff Garzik
Jan-Bernd Themann wrote: > Introduces a module parameter to decide whether the physical > port link state is propagated to the network stack or not. > It makes sense not to take the physical port state into account > on machines with more logical partitions that communicate > with each other. This

Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix

2007-08-16 Thread Jeff Garzik
Mikael Pettersson wrote: > (cc:ing linuxppc-dev) > > On Tue, 26 Jun 2007 13:43:15 +0800, Albert Lee wrote: >> Recently the PLL input clock of pata_pdc2027x is sometimes detected >> higer than expected (e.g. 20.027 MHz compared to 16.714 MHz). >> It seems sometimes the mdelay() function is not as p

Re: [PATCH 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-08-08 Thread Jeff Garzik
David Miller wrote: > From: Jan-Bernd Themann <[EMAIL PROTECTED]> > Date: Fri, 3 Aug 2007 14:41:14 +0200 > >> I think this patch could be the final version for now. It has been tested >> on two platforms (power and x86_64) and works very well. > > I checked in the LRO patch and the two sample dri

Re: [PATCH 2/6] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-08-07 Thread Jeff Garzik
Brian King wrote: > Jeff Garzik wrote: >> Brian King wrote: >>> This patch adds the appropriate ethtool hooks to allow for >>> enabling/disabling >>> of hypervisor assisted checksum offload for TCP. >>> >>> Signed-off-by: Brian King <[EMA

Re: [PATCH 6/6] ibmveth: Remove use of bitfields

2007-08-07 Thread Jeff Garzik
Brian King wrote: > Removes the use of bitfields from the ibmveth driver. This results > in slightly smaller object code. > > Signed-off-by: Brian King <[EMAIL PROTECTED]> > --- > > linux-2.6-bjking1/drivers/net/ibmveth.c | 90 > > linux-2.6-bjking1/drivers/ne

Re: [PATCH 4/6] ibmveth: Add ethtool driver stats hooks

2007-08-07 Thread Jeff Garzik
Brian King wrote: > Add ethtool hooks to ibmveth to retrieve driver statistics. > > Signed-off-by: Brian King <[EMAIL PROTECTED]> > --- > > drivers/net/ibmveth.c | 53 > +- > 1 file changed, 52 insertions(+), 1 deletion(-) > > diff -puN drivers

Re: [PATCH 3/6] ibmveth: Add ethtool TSO handlers

2007-08-07 Thread Jeff Garzik
Brian King wrote: > Add handlers for get_tso and get_ufo to prevent errors being printed > by ethtool. > > Signed-off-by: Brian King <[EMAIL PROTECTED]> > --- > > drivers/net/ibmveth.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff -puN drivers/net/ibmveth.c~ibmveth_etht

Re: [PATCH 2/6] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-08-07 Thread Jeff Garzik
Brian King wrote: > This patch adds the appropriate ethtool hooks to allow for enabling/disabling > of hypervisor assisted checksum offload for TCP. > > Signed-off-by: Brian King <[EMAIL PROTECTED]> > --- > > linux-2.6-bjking1/drivers/net/ibmveth.c | 118 > +++- > l

Re: [PATCH 1/6] ibmveth: Enable TCP checksum offload

2007-08-07 Thread Jeff Garzik
Brian King wrote: > This patchset enables TCP checksum offload support for IPV4 > on ibmveth. This completely eliminates the generation and checking of > the checksum for packets that are completely virtual and never > touch a physical network. A simple TCP_STREAM netperf run on > a virtual network

Re: [RESEND][PATCH 1/3] ehea: Fix workqueue handling

2007-08-07 Thread Jeff Garzik
Thomas Klein wrote: > Fix: Workqueue ehea_driver_wq was not destroyed > > Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> > > --- > drivers/net/ehea/ehea.h |2 +- > drivers/net/ehea/ehea_main.c |1 + > 2 files changed, 2 insertions(+), 1 deletions(-) applied 1-3 to #upstream-fixes

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Jeff Garzik
David Miller wrote: > From: Jeff Garzik <[EMAIL PROTECTED]> > Date: Mon, 30 Jul 2007 12:17:58 -0400 > >> David, thoughts on merging? I'm not We could stick this into your tree >> or mine. Whether yours or mine, I would like to keep the driver and >> net

Re: [PATCH] gfar: Fix modpost warning

2007-07-30 Thread Jeff Garzik
Kumar Gala wrote: > Fix the following modpost warning: > > WARNING: vmlinux.o(.init.text+0x1aa6c): Section mismatch: reference to > .exit.text:gfar_mdio_exit (between 'gfar_init' and 'gfar_mdio_init') > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> > --- > drivers/net/gianfar_mii.c |2 +-

Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile

2007-07-30 Thread Jeff Garzik
Stephen Hemminger wrote: > Why make this a user selectable option at all? Unless you want > to deal with out of tree drivers (not my problem), it should be hidden > to avoid having to explain an support it. In this case it's an optional library kernel module. That seems to be a common setup for

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Jeff Garzik
Seems pretty good to me, save for one minor detail: patches #1/#2 should be combined together for greater git-bisect happiness. Ditto for patches #3/#4. Largely harmless in this case, but keeps the git history pollution to a minimum. Caveat reviewer: I'm not an expert of net/ipv4/* code, so

Re: [RFC 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-27 Thread Jeff Garzik
Just to chime in... In general, I like where this LRO effort is going, and I really appreciate you guys working on it. Jeff ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/2] [POWERPC] Add support of platforms without PHY to gianfar driver

2007-07-25 Thread Jeff Garzik
I'll let paulus and linuxppc merge this one (or not)... Jeff ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] eHEA: net_poll support

2007-07-24 Thread Jeff Garzik
Jan-Bernd Themann wrote: > net_poll support for eHEA added > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> > --- > > > drivers/net/ehea/ehea.h |2 +- > drivers/net/ehea/ehea_main.c | 22 +- > 2 files changed, 22 insertions(+), 2 deletions(-) applied __

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Jeff Garzik
Andreas Schwab wrote: > Jeff Garzik <[EMAIL PROTECTED]> writes: > >> Andy Whitcroft wrote: >>> Andrew Morton wrote: >>> >>>>> + start_sector = req->sector*priv->blocking_factor; >>>>> + sectors = req->nr_sectors*pri

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Jeff Garzik
Andy Whitcroft wrote: > Andrew Morton wrote: > >>> + start_sector = req->sector*priv->blocking_factor; >>> + sectors = req->nr_sectors*priv->blocking_factor; >> s/*/ * /. checkpatch missed this. > > Ok, this is something we need to decide on. Currently we only ask for > consistent spacing o

Re: [PATCH] eHEA: Fix bonding support

2007-07-18 Thread Jeff Garzik
Thomas Klein wrote: > The driver didn't allow an interface's MAC address to be modified if the > respective interface wasn't setup - a failing Hcall was the result. Thus > bonding wasn't usable. The fix moves the failing Hcall which was registering > a MAC address for the reception of BC packets in

Re: [PATCH] PHY fixed driver: rework release path and update phy_id notation

2007-07-18 Thread Jeff Garzik
Vitaly Bordug wrote: > device_bind_driver() error code returning has been fixed. > release() function has been written, so that to free resources > in correct way; the release path is now clean. > > Before the rework, it used to cause > Device '[EMAIL PROTECTED]:1' does not have a release()

Re: [PATCH 4/4] ibmveth: Add ethtool driver stats hooks

2007-07-18 Thread Jeff Garzik
Brian King wrote: > Add ethtool hooks to ibmveth to retrieve driver statistics. > > ACK patches 3-4 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-07-18 Thread Jeff Garzik
Brian King wrote: > This patch adds the appropriate ethtool hooks to allow for enabling/disabling > of hypervisor assisted checksum offload for TCP. > > Signed-off-by: Brian King <[EMAIL PROTECTED]> > --- > > linux-2.6-bjking1/drivers/net/ibmveth.c | 120 > +++- > l

Re: [PATCH 1/4] ibmveth: Enable TCP checksum offload

2007-07-18 Thread Jeff Garzik
Brian King wrote: > This patchset enables TCP checksum offload support for IPV4 > on ibmveth. This completely eliminates the generation and checking of > the checksum for packets that are completely virtual and never > touch a physical network. A simple TCP_STREAM netperf run on > a virtual network

Re: [PATCH 2.6.22-rc7 0/4] phy/gianfar: Fixes for gianfar and vitesse RGMII-ID support

2007-07-16 Thread Jeff Garzik
Andy Fleming wrote: > A few bugs in the Vitesse PHY driver were found on the 8641D HPCN board. > Originally, they were masked by a bug in the PHY Lib which was fixed by patch > 5f708dd91d15876e26d7a57f97a255cedffca463 (Fix phy_id for Vitesse 824x PHY). > That patch allowed the Vitesse PHY to bind

Re: [PATCH] Fix Tsi108 ethernet driver performance

2007-07-16 Thread Jeff Garzik
Alexandre Bounine wrote: > From: Alexandre Bounine <[EMAIL PROTECTED]> > > This patch improves performance of the Tsi108 Ethernet driver by > changing interrupt handling for frame receive path. It reduces number of > interrupts generated for received frames and therefore lowers CPU > utilization b

Re: [PATCH 1/1] eHEA: Introducing support vor DLPAR memory add

2007-07-16 Thread Jeff Garzik
Thomas Klein wrote: > This patch adds support for DLPAR memory add to the eHEA driver. To detect > whether memory was added the driver uses its own memory mapping table and > checks for kernel addresses whether they're located in already known memory > sections. If not the function ehea_rereg_mrs()

Re: [PATCH] PHY fixed driver: rework release path and update phy_id notation

2007-07-10 Thread Jeff Garzik
Vitaly Bordug wrote: > device_bind_driver() error code returning has been fixed. > release() function has been written, so that to free resources > in correct way; the release path is now clean. > > Before the rework, it used to cause > Device '[EMAIL PROTECTED]:1' does not have a release() func

Re: [PATCH 2/2] eHEA: Receive SKB Aggregation

2007-07-10 Thread Jeff Garzik
Jan-Bernd Themann wrote: > This patch enables the receive side processing to aggregate TCP packets within > the HEA device driver. It analyses the packets already received after an > interrupt arrived and forwards these as chains of SKBs for the same TCP > connection with modified header field. We

Re: [PATCH 1/2] eHEA: Capability flag for DLPAR support

2007-07-10 Thread Jeff Garzik
Jan-Bernd Themann wrote: > This patch introduces a capability flag that is used by the DLPAR userspace > tool to check which DLPAR features are supported by the eHEA driver. > > Missing goto has been included. > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> applied ___

Re: [PATCH/RESENT] ehea: Whitespace cleanup

2007-07-02 Thread Jeff Garzik
Jan-Bernd Themann wrote: > This patch fixes several whitespace issues. > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> applied ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

<    1   2   3