Re: [PATCH] powermac: Call of_node_put(bk_node) only once in pmac_has_backlight_type()

2024-10-03 Thread Krzysztof Kozlowski
On 03/10/2024 07:56, Dan Carpenter wrote: > First of all, the change is wrong. We can't dereference "prop" after calling > of_node_put(). You have to be a bit extra careful reviewing Markus's patches > because a lot of the rest of us have blocked these messages so you're on your > own in that way

Re: [PATCH treewide 10/11] ARM: dts: nxp: imx: Switch to {hp,mic}-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
On 27/09/2024 14:42, Geert Uytterhoeven wrote: > Replace the deprecated "hp-det-gpio" and "mic-det-gpio" properties by > "hp-det-gpios" resp. "mic-det-gpios" in Freescale Generic ASoC Sound > Card device nodes. > > Signed-off-by: Geert Uytterhoeven > --- > This has a run-time dependency on "ASoC:

Re: [PATCH treewide 01/11] ASoC: fsl-asoc-card: Add missing handling of {hp,mic}-dt-gpios

2024-09-27 Thread Krzysztof Kozlowski
;) > Fixes: 40ba2eda0a7b727f ("arm64: dts: imx8mm-nitrogen-r2: add audio") > Signed-off-by: Geert Uytterhoeven > --- > Noticed accidentally. > Compile-tested only. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 09/11] mips: dts: ingenic: Switch to simple-audio-card,hp-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
On 27/09/2024 14:42, Geert Uytterhoeven wrote: > Replace the deprecated "simple-audio-card,hp-det-gpio" property by > "simple-audio-card,hp-det-gpios" in Simple Audio Card device nodes. > > Signed-off-by: Geert Uytterhoeven > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 08/11] arm64: dts: uniphier: Switch to hp-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
On 27/09/2024 14:42, Geert Uytterhoeven wrote: > Replace the deprecated "hp-det-gpio" property by "hp-det-gpios" in Audio > Graph Card device nodes. > > Signed-off-by: Geert Uytterhoeven > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 06/11] arm64: dts: rockchip: Switch to simple-audio-card,hp-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
On 27/09/2024 14:42, Geert Uytterhoeven wrote: > Replace the deprecated "simple-audio-card,hp-det-gpio" property by > "simple-audio-card,hp-det-gpios" in Simple Audio Card device nodes. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 03/11] ARM: dts: marvell: mmp2-olpc-xo-1-75: Switch to {hp,mic}-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
> arch/arm/boot/dts/marvell/mmp2-olpc-xo-1-75.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I think the non-Freescale DTS could be split to indicate there is no real dependency. Only Freescale DTS will be affected, thus should be taken at least with one cycle break. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 07/11] arm64: dts: rockchip: Switch to hp-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
On 27/09/2024 14:42, Geert Uytterhoeven wrote: > Replace the deprecated "hp-det-gpio" property by "hp-det-gpios" in Audio > Graph Card and Realtek RT5651 Audio Codec device nodes. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 05/11] arm64: dts: renesas: beacon-renesom: Switch to mic-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
| 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 04/11] arm64: dts: freescale: imx: Switch to simple-audio-card,hp-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
On 27/09/2024 14:42, Geert Uytterhoeven wrote: > Replace the deprecated "simple-audio-card,hp-det-gpio" property by > "simple-audio-card,hp-det-gpios" in Simple Audio Card device nodes. > > Signed-off-by: Geert Uytterhoeven Subject: drop freescale prefix.

Re: [PATCH treewide 02/11] ASoC: dt-bindings: Deprecate {hp,mic}-det-gpio

2024-09-27 Thread Krzysztof Kozlowski
ings to > reflect this. > > Signed-off-by: Geert Uytterhoeven > --- > No driver changes needed, as gpiod_get_optional() as called from > simple_util_init_jack() tries all suffixes. > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH -next 2/8] soc: fsl: cpm1: Simplify with dev_err_probe()

2024-08-28 Thread Krzysztof Kozlowski
On 28/08/2024 03:58, Jinjie Ruan wrote: > > > On 2024/8/27 21:50, Krzysztof Kozlowski wrote: >> On 27/08/2024 13:46, Jinjie Ruan wrote: >>> Use the dev_err_probe() helper to simplify error handling during probe. >>> This also handle scenario, when EDEFER is

Re: [PATCH -next 2/8] soc: fsl: cpm1: Simplify with dev_err_probe()

2024-08-27 Thread Krzysztof Kozlowski
On 27/08/2024 13:46, Jinjie Ruan wrote: > Use the dev_err_probe() helper to simplify error handling during probe. > This also handle scenario, when EDEFER is returned and useless error > is printed. ? Sorry, this cannot happen. Please point to below code which can defer. > > Signed-off-by: Jinji

[PATCH] dt-bindings: fsl: fsl,rcpm: fix unevaluated fsl,rcpm-wakeup property

2024-08-11 Thread Krzysztof Kozlowski
ooks like none of in-tree DTS use it. Fixes: ad21e3840a88 ("dt-bindings: soc: fsl: Convert rcpm to yaml format") Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/soc/fsl/fsl,rcpm.yaml | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --

Re: [PATCH 1/1] dt-bindings: soc: fsl: add missed compatible string fsl,ls*-isc

2024-08-05 Thread Krzysztof Kozlowski
On 02/08/2024 19:11, Frank Li wrote: > Add compatible string, fsl,ls1088a-isc, fsl,ls2080a-isc, fsl,lx2160a-isc. git grep on fsl,lx2046a-isc gives me 0. > Fix the below warning: > arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dtb: /soc/syscon@1f7: > failed to match any schema with compatible

Re: [PATCH v3 2/3] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

2024-07-02 Thread Krzysztof Kozlowski
On 02/07/2024 14:01, Michael Ellerman wrote: > Krzysztof Kozlowski writes: >> On 30/05/2024 16:46, Esben Haabendal wrote: >>> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select >>> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies

Re: [PATCH v3 3/3] arm64/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

2024-07-02 Thread Krzysztof Kozlowski
On 30/05/2024 16:46, Esben Haabendal wrote: > With CONFIG_FSL_IFC now being user-visible, and thus changed from a select > to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be > selected in defconfig. > > Signed-off-by: Esben Haabendal Reviewed-by: Krzysztof K

Re: [PATCH v3 2/3] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

2024-07-02 Thread Krzysztof Kozlowski
s up? Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Patch v5 12/12] i2x: pnx: Fix potential deadlock warning from del_timer_sync() call in isr

2024-06-28 Thread Krzysztof Kozlowski
On 27/06/2024 17:00, Piotr Wojtaszczyk wrote: > When del_timer_sync() is called in an interrupt context it throws a warning > because of potential deadlock. The timer is used only to exit from > wait_for_completion() after a timeout so replacing the call with > wait_for_completion_timeout() allows

Re: [Patch v5 02/12] dt-bindings: dma: Add lpc32xx DMA mux binding

2024-06-28 Thread Krzysztof Kozlowski
On 27/06/2024 17:00, Piotr Wojtaszczyk wrote: > LPC32XX SoCs use pl080 dma controller which have few request signals > multiplexed between peripherals. This binding describes how devices can > use the multiplexed request signals. > > Signed-off-by: Piotr Wojtaszczyk Reviewe

Re: [PATCHv5 7/9] ASoC: dt-bindings: imx-audio-spdif: remove binding

2024-06-24 Thread Krzysztof Kozlowski
On 24/06/2024 11:18, Elinor Montmasson wrote: >>> >>> Previous `imx-spdif` driver used the dummy codec instead of >>> using declared spdif codecs. It was discussed in previous version of this >>> contribution >>> that using the dummy codec isn't good practice. So one to one backward >>> compatibili

Re: [PATCHv5 6/9] ASoC: dt-bindings: fsl-asoc-card: add compatible string for spdif

2024-06-24 Thread Krzysztof Kozlowski
On 24/06/2024 10:51, Elinor Montmasson wrote: > >> The compatible is already documented, so now you create duplicated binding. >> >> This is very confusing. > > > The double compatible documentation is only temporary, next commit (7/9) > removes the previous binding in "fsl,imx-audio-spdif.yaml"

Re: [PATCHv5 7/9] ASoC: dt-bindings: imx-audio-spdif: remove binding

2024-06-24 Thread Krzysztof Kozlowski
On 24/06/2024 10:51, Elinor Montmasson wrote: > From: "Krzysztof Kozlowski" > Sent: Sunday, 23 June, 2024 13:09:33 >> On 20/06/2024 15:25, Elinor Montmasson wrote: >>> imx-audio-spdif was merged into the fsl-asoc-card driver, and therefore >>> removed.

Re: [PATCHv5 8/9] arm64: dts: imx8m: update spdif sound card node properties

2024-06-23 Thread Krzysztof Kozlowski
On 20/06/2024 15:25, Elinor Montmasson wrote: > Following merge of imx-spdif driver into fsl-asoc-card: > * update properties to match those used by fsl-asoc-card. > * S/PDIF in/out dummy codecs must now be declared explicitly, add and > use them. > > These modifications were tested only on an i

Re: [PATCHv5 7/9] ASoC: dt-bindings: imx-audio-spdif: remove binding

2024-06-23 Thread Krzysztof Kozlowski
On 20/06/2024 15:25, Elinor Montmasson wrote: > imx-audio-spdif was merged into the fsl-asoc-card driver, and therefore > removed. So what happens with all existing users (e.g. DTS)? They become invalid/not supported? After quick look, I do not see backwards compatibility in the driver and above

Re: [PATCHv5 6/9] ASoC: dt-bindings: fsl-asoc-card: add compatible string for spdif

2024-06-23 Thread Krzysztof Kozlowski
On 20/06/2024 15:25, Elinor Montmasson wrote: > The S/PDIF audio card support was merged from imx-spdif into the > fsl-asoc-card driver, making it possible to use an S/PDIF with an ASRC. > Add the new compatible and update properties. Please use standard email subjects, so with the PATCH keyword i

Re: [Patch v4 07/10] ARM: lpc32xx: Remove pl08x platform data in favor for device tree

2024-06-20 Thread Krzysztof Kozlowski
On 21/06/2024 07:56, Markus Elfring wrote: >> With the driver for nxp,lpc3220-dmamux we can remove the pl08x platform >> data and let pl08x driver to create peripheral channels from the DT >> properties. > > Do you see opportunities to improve such a change description? > https://git.kernel.org/pu

Re: [Patch v4 06/10] dmaengine: Add dma router for pl08x in LPC32XX SoC

2024-06-20 Thread Krzysztof Kozlowski
On 20/06/2024 19:56, Piotr Wojtaszczyk wrote: > LPC32XX connects few of its peripherals to pl08x DMA thru a multiplexer, > this driver allows to route a signal request line thru the multiplexer for > given peripheral. > > Signed-off-by: Piotr Wojtaszczyk > --- > Changes for v4: > - This patch is

Re: [Patch v4 05/10] clk: lpc32xx: initialize regmap using parent syscon

2024-06-20 Thread Krzysztof Kozlowski
On 20/06/2024 19:56, Piotr Wojtaszczyk wrote: > > - base = of_iomap(np, 0); > - if (!base) { > - pr_err("failed to map system control block registers\n"); > - return; > - } > - > - clk_regmap = regmap_init_mmio(NULL, base, &lpc32xx_scb_regmap_config); > +

Re: [Patch v4 04/10] ARM: dts: lpc32xx: Add missing dma and i2s properties

2024-06-20 Thread Krzysztof Kozlowski
On 20/06/2024 19:56, Piotr Wojtaszczyk wrote: > Adds properties declared in the new DT bindings: > - nxp,lpc3220-i2s.yaml > - nxp,lpc3220-dmamux.yaml > for dma router/mux and I2S interface. > > Signed-off-by: Piotr Wojtaszczyk You are doing here multiple things at once. This should be One pat

Re: [Patch v4 03/10] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-20 Thread Krzysztof Kozlowski
Vladimir Zapolskiy > +L: alsa-de...@alsa-project.org (moderated for non-subscribers) > +L: linuxppc-dev@lists.ozlabs.org > +S: Maintained > +F: Documentation/devicetree/bindings/sound/nxp,lpc3220-i2s.yaml > +N: lpc32xx Drop the last "N:". Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Patch v4 02/10] dt-bindings: dma: Add lpc32xx DMA mux binding

2024-06-20 Thread Krzysztof Kozlowski
On 20/06/2024 19:56, Piotr Wojtaszczyk wrote: > LPC32XX SoCs use pl080 dma controller which have few request signals > multiplexed between peripherals. This binding describes how devices can > use the multiplexed request signals. > > Signed-off-by: Piotr Wojtaszczyk > + > +properties: > + "#dma

Re: [Patch v4 01/10] dt-bindings: dma: pl08x: Add dma-cells description

2024-06-20 Thread Krzysztof Kozlowski
On 20/06/2024 19:56, Piotr Wojtaszczyk wrote: > Recover dma-cells description from the legacy DT binding. Fixes: 6f64aa5746d2 ("dt-bindings: dma: convert arm-pl08x to yaml") Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-17 Thread Krzysztof Kozlowski
On 17/06/2024 16:04, Piotr Wojtaszczyk wrote: >> >>> It's used by snd_soc_dai_init_dma_data() in [PATCH v3 4/4] to give the >>> dmaengine a >>> hint which dma config to use. The LPC32xx doesn't have yet a dmamux driver >>> like >> >> and if I change driver platform data to foo and bar, does the DT

Re: [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-17 Thread Krzysztof Kozlowski
On 17/06/2024 11:33, Piotr Wojtaszczyk wrote: > On Sat, Jun 15, 2024 at 12:01 PM Krzysztof Kozlowski wrote: >> Do not attach (thread) your patchsets to some other threads (unrelated >> or older versions). This buries them deep in the mailbox and might >> interfere with

Re: (subset) [RFC PATCH 2/2] dt-bindings: memory: fsl: replace maintainer

2024-06-16 Thread Krzysztof Kozlowski
b570a28b4e3d877ef6c Best regards, -- Krzysztof Kozlowski

Re: [RFC PATCH 2/2] dt-bindings: memory: fsl: replace maintainer

2024-06-16 Thread Krzysztof Kozlowski
On 17/06/2024 05:24, Shawn Guo wrote: > On Tue, Jun 11, 2024 at 10:49:36AM +0200, Krzysztof Kozlowski wrote: >> On 04/06/2024 16:22, Michael Walle wrote: >>> Li Yang's mail address is bouncing, replace it with Shawn Guo's one. >>> >>> Signed-off-by: M

Re: [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-15 Thread Krzysztof Kozlowski
On 14/06/2024 18:34, Piotr Wojtaszczyk wrote: > Add nxp,lpc3220-i2s DT binding documentation. > > Signed-off-by: Piotr Wojtaszczyk Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying ent

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-12 Thread Krzysztof Kozlowski
On 12/06/2024 10:02, Piotr Wojtaszczyk wrote: > On Tue, Jun 11, 2024 at 12:18 PM Krzysztof Kozlowski wrote: >> I do not see my comment about DAI being addressed. > Were you asking if it's a DAI? yes it is. > Then you miss $ref to dai-common and defining sound-dai-cells li

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-12 Thread Krzysztof Kozlowski
On 12/06/2024 10:06, Piotr Wojtaszczyk wrote: > On Tue, Jun 11, 2024 at 12:45 PM Krzysztof Kozlowski wrote: >>> Changes for v2: >>> - Added maintainers field >>> - Dropped clock-names >>> - Dropped unused unneded interrupts field >> >> Does th

Re: (subset) [PATCH v3 1/3] memory: fsl_ifc: Make FSL_IFC config visible and selectable

2024-06-12 Thread Krzysztof Kozlowski
inux-mem-ctrl/c/9ba0cae3cac07c21c583f9ff194f74043f90d29c Best regards, -- Krzysztof Kozlowski

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-11 Thread Krzysztof Kozlowski
On 11/06/2024 11:47, Piotr Wojtaszczyk wrote: > Add nxp,lpc3220-i2s DT binding documentation. > > Signed-off-by: Piotr Wojtaszczyk > --- > Changes for v2: > - Added maintainers field > - Dropped clock-names > - Dropped unused unneded interrupts field Does the device has interrupts or not? This s

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-11 Thread Krzysztof Kozlowski
On 11/06/2024 11:47, Piotr Wojtaszczyk wrote: > Add nxp,lpc3220-i2s DT binding documentation. > > Signed-off-by: Piotr Wojtaszczyk > --- > + > +maintainers: > + - Piotr Wojtaszczyk > + > +properties: > + compatible: > +enum: > + - nxp,lpc3220-i2s > + > + reg: > +maxItems: 1 > +

Re: [Patch v2 1/2] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs

2024-06-11 Thread Krzysztof Kozlowski
On 11/06/2024 11:47, Piotr Wojtaszczyk wrote: > This driver was ported from an old version in linux 2.6.27 and adjusted > for the new ASoC framework and DMA API. > > Signed-off-by: Piotr Wojtaszczyk > --- > Changes for v2: > - Coding Style cleanup > - Use dev_err_probe() for error handling in pro

Re: [RFC PATCH 2/2] dt-bindings: memory: fsl: replace maintainer

2024-06-11 Thread Krzysztof Kozlowski
rship. > --- I suppose this could go via IMX SoC tree, so: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: Drop Li Yang as maintainer for all bindings

2024-06-11 Thread Krzysztof Kozlowski
NERS but > didn't address all the in-file entries of the device tree bindings. > > Signed-off-by: Michael Walle Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/2] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

2024-05-28 Thread Krzysztof Kozlowski
On 28/05/2024 15:33, Esben Haabendal wrote: > Krzysztof Kozlowski writes: > >> On 28/05/2024 14:28, Esben Haabendal wrote: >>> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select >>> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies need

Re: [PATCH v2 1/2] memory: fsl_ifc: Make FSL_IFC config visible and selectable

2024-05-28 Thread Krzysztof Kozlowski
On 28/05/2024 15:15, Christophe Leroy wrote: > > > Le 28/05/2024 à 14:28, Esben Haabendal a écrit : >> [Vous ne recevez pas souvent de courriers de es...@geanix.com. Découvrez >> pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] >> >> While use of fsl_ifc driver with

Re: [PATCH v2 2/2] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

2024-05-28 Thread Krzysztof Kozlowski
On 28/05/2024 14:28, Esben Haabendal wrote: > With CONFIG_FSL_IFC now being user-visible, and thus changed from a select > to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be > selected in config snippets. > > Signed-off-by: Esben Haabendal > --- > arch/powerpc/configs/85xx-hw.co

Re: [PATCH 1/2] ASoC: dt-bindings: fsl,mqs: Add i.MX95 platform support

2024-05-20 Thread Krzysztof Kozlowski
On 17/05/2024 11:45, Shengjiu Wang wrote: > In order to support the MQS module on i.MX95, a new property > "fsl,mqs-ctrl" needs to be added, as there are two MQS instances > on the i.MX95 platform, the definition of bit positions in the > control register is different. This new property is to disti

[PATCH 13/13] ASoC: sunxi: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/sunxi/sun50i-dmic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c index c76628bc86c6..fedfa4fc95fb 100644 --- a/sound

[PATCH 12/13] ASoC: samsung: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/samsung/midas_wm1811.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/samsung/midas_wm1811.c b/sound/soc/samsung/midas_wm1811.c index f31244156ff6..0841e2e6f8ce 100644

[PATCH 11/13] ASoC: meson: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/meson/aiu-fifo.c | 2 +- sound/soc/meson/axg-fifo.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/meson/aiu-fifo.c b/sound/soc/meson/aiu-fifo.c index 4041ff8e437f

[PATCH 10/13] ASoC: mediatek: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/mediatek/mt7986/mt7986-afe-pcm.c | 4 ++-- sound/soc/mediatek/mt8186/mt8186-afe-pcm.c | 14 +++--- sound/soc/mediatek/mt8186/mt8186-mt6366.c | 2 +- sound/soc/mediatek/mt8188/mt8188-afe

[PATCH 09/13] ASoC: loongson: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/loongson/loongson_card.c | 2 +- sound/soc/loongson/loongson_dma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/loongson/loongson_card.c b/sound/soc/loongson

[PATCH 08/13] ASoC: kirkwood: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/kirkwood/kirkwood-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/kirkwood/kirkwood-dma.c b/sound/soc/kirkwood/kirkwood-dma.c index ef00792e1d49..036b42058272

[PATCH 07/13] ASoC: img: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/img/img-i2s-in.c | 2 +- sound/soc/img/img-i2s-out.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c index dacc29fcf24b

[PATCH 06/13] ASoC: fsl: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/fsl/fsl-asoc-card.c | 2 +- sound/soc/fsl/imx-card.c | 6 +++--- sound/soc/fsl/imx-hdmi.c | 2 +- sound/soc/fsl/imx-pcm-rpmsg.c | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions

[PATCH 05/13] ASoC: amd: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/amd/acp/acp-mach-common.c | 2 +- sound/soc/amd/acp3x-rt5682-max9836.c | 2 +- sound/soc/amd/ps/ps-sdw-dma.c| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/amd

[PATCH 04/13] ASoC: arm: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/arm/pxa2xx-pcm-lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/arm/pxa2xx-pcm-lib.c b/sound/arm/pxa2xx-pcm-lib.c index 51d2ff80df16..571e9d909cdf 100644 --- a/sound/arm

[PATCH 03/13] ASoC: ti: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/ti/omap-hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/ti/omap-hdmi.c b/sound/soc/ti/omap-hdmi.c index 4513b527ab97..639bc83f4263 100644 --- a/sound/soc/ti/omap

[PATCH 01/13] ASoC: qcom: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/qcom/apq8016_sbc.c | 4 ++-- sound/soc/qcom/qdsp6/q6apm-dai.c | 2 +- sound/soc/qcom/sc7180.c | 10 +- sound/soc/qcom/sc7280.c | 12 ++-- sound/soc/qcom

[PATCH 00/13] ASoC: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
tof --- Krzysztof Kozlowski (13): ASoC: qcom: Use snd_soc_substream_to_rtd() for accessing private_data ASoC: tegra: Use snd_soc_substream_to_rtd() for accessing private_data ASoC: ti: Use snd_soc_substream_to_rtd() for accessing private_data ASoC: arm: Use snd_soc_substream_to_

[PATCH 02/13] ASoC: tegra: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/tegra/tegra_asoc_machine.c | 2 +- sound/soc/tegra/tegra_pcm.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/tegra/tegra_asoc_machine.c b/sound/soc

[PATCH 4/4] ASoC: uniphier: Constify static snd_pcm_hardware

2024-04-29 Thread Krzysztof Kozlowski
Static 'struct snd_pcm_hardware' is not modified by the driver and its copy is passed to the core, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- sound/soc/uniphier/aio-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 3/4] ASoC: meson: Constify static snd_pcm_hardware

2024-04-29 Thread Krzysztof Kozlowski
Static 'struct snd_pcm_hardware' is not modified by the driver and its copy is passed to the core, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- sound/soc/meson/aiu-fifo-i2s.c | 2 +- sound/soc/meson/aiu-fifo-spdif.c | 2 +- sound/soc

[PATCH 2/4] ASoC: fsl: Constify static snd_pcm_hardware

2024-04-29 Thread Krzysztof Kozlowski
Static 'struct snd_pcm_hardware' is not modified by the driver and its copy is passed to the core, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- sound/soc/fsl/imx-pcm-rpmsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH 1/4] ASoC: qcom: Constify static snd_pcm_hardware

2024-04-29 Thread Krzysztof Kozlowski
Static 'struct snd_pcm_hardware' is not modified by the driver and its copy is passed to the core, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- sound/soc/qcom/qdsp6/q6apm-dai.c | 4 ++-- sound/soc/qcom/qdsp6/q6asm-dai.c | 2 +- 2 files

[PATCH 0/4] ASoC: Constify static snd_pcm_hardware

2024-04-29 Thread Krzysztof Kozlowski
No dependencies. Static 'struct snd_pcm_hardware' is not modified by few drivers and its copy is passed to the core, so it can be made const for increased code safety. Best regards, Krzysztof --- Krzysztof Kozlowski (4): ASoC: qcom: Constify static snd_pcm_hardware

[PATCH v2 2/3] usb: typec: nvidia: drop driver owner assignment

2024-03-31 Thread Krzysztof Kozlowski
Core in typec_altmode_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. None --- drivers/usb/typec/altmodes/nvidia.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/typec/altmodes/nvidia.c b/drivers

[PATCH v2 3/3] usb: typec: displayport: drop driver owner assignment

2024-03-31 Thread Krzysztof Kozlowski
Core in typec_altmode_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. New patch --- drivers/usb/typec/altmodes/displayport.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/typec/altmodes

[PATCH v2 1/3] usb: phy: fsl-usb: drop driver owner assignment

2024-03-31 Thread Krzysztof Kozlowski
Core in platform_driver_register() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. None --- drivers/usb/phy/phy-fsl-usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/phy/phy-fsl-usb.c b/drivers/usb/phy/phy-fsl

[PATCH] usb: phy: MAINTAINERS: mark Freescale USB PHY as orphaned

2024-03-27 Thread Krzysztof Kozlowski
Emails to the only maintainer bounce: : host nxp-com.mail.protection.outlook.com[52.101.68.39] said: 550 5.4.1 Recipient address rejected: Access denied. Signed-off-by: Krzysztof Kozlowski --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b

[PATCH 2/2] usb: typec: nvidia: drop driver owner assignment

2024-03-27 Thread Krzysztof Kozlowski
Core in typec_altmode_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/typec/altmodes/nvidia.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/typec/altmodes/nvidia.c b/drivers/usb/typec/altmodes/nvidia.c

[PATCH 1/2] usb: phy: fsl-usb: drop driver owner assignment

2024-03-27 Thread Krzysztof Kozlowski
Core in platform_driver_register() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/phy/phy-fsl-usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/phy/phy-fsl-usb.c b/drivers/usb/phy/phy-fsl-usb.c index 79617bb0a70e

[PATCH v2 2/2] dt-bindings: timer: narrow regex for unit address to hex numbers

2024-03-25 Thread Krzysztof Kozlowski
Regular expression used to match the unit address part should not allow non-hex numbers. Expect at least one hex digit as well. Acked-by: Rob Herring Signed-off-by: Krzysztof Kozlowski --- v2: Change '*' into '+' in the regex. --- .../devicetree/bindings/timer/arm,

[PATCH v2 1/2] dt-bindings: soc: fsl: narrow regex for unit address to hex numbers

2024-03-25 Thread Krzysztof Kozlowski
Regular expression used to match the unit address part should not allow non-hex numbers. Acked-by: Rob Herring Signed-off-by: Krzysztof Kozlowski --- v2: No changes --- .../devicetree/bindings/soc/fsl/fsl,layerscape-dcfg.yaml| 2 +- .../devicetree/bindings/soc/fsl/fsl,layerscape

Re: [PATCH v2 4/4] ASoC: fsl: imx-rpmsg: Update to correct DT node

2024-03-11 Thread Krzysztof Kozlowski
On 11/03/2024 08:33, Chancel Liu wrote: >>> @@ -127,6 +126,22 @@ static int imx_rpmsg_probe(struct platform_device >> *pdev) >>> goto fail; >>> } >>> >>> + if (!strcmp(pdev->dev.platform_data, "rpmsg-micfil-channel")) >>> + np = of_find_node_by_name(NULL, "rpmsg_

Re: [PATCH v2 4/4] ASoC: fsl: imx-rpmsg: Update to correct DT node

2024-03-07 Thread Krzysztof Kozlowski
On 07/03/2024 08:44, Chancel Liu wrote: > Platform device for card to probe is registered in imx-audio-rpmsg. > According to this change DT node of ASoC CPU DAI device is updated. > > Signed-off-by: Chancel Liu > --- > sound/soc/fsl/imx-rpmsg.c | 21 ++--- > 1 file changed, 18 in

Re: [PATCH v4 01/11] dt-bindings: wiiu: Document the Nintendo Wii U devicetree

2024-02-20 Thread Krzysztof Kozlowski
On 20/02/2024 17:20, Christophe Leroy wrote: > Michael, > > Le 19/11/2022 à 12:30, Ash Logan a écrit : >> Adds schema for the various Wii U devicetree nodes used. >> >> Signed-off-by: Ash Logan > > There's an issue at https://github.com/linuxppc/issues/issues/410 with > kernel v6.4 as a target

Re: [PATCH RFC/RFT v2 2/4] dt-bindings: riscv: Add Svvptc ISA extension description

2024-02-01 Thread Krzysztof Kozlowski
On 31/01/2024 16:59, Alexandre Ghiti wrote: > Add description for the Svvptc ISA extension which was ratified recently. > > Signed-off-by: Alexandre Ghiti > --- Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an o

[PATCH] dt-bindings: soc: fsl: narrow regex for unit address to hex numbers

2024-01-23 Thread Krzysztof Kozlowski
Regular expression used to match the unit address part should not allow non-hex numbers. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/soc/fsl/fsl,layerscape-dcfg.yaml| 2 +- .../devicetree/bindings/soc/fsl/fsl,layerscape-scfg.yaml| 2 +- 2 files changed, 2

Re: [PATCH v2 3/3] ASoC: dt-bindings: fsl,micfil: Add compatible string for i.MX95 platform

2024-01-11 Thread Krzysztof Kozlowski
On 12/01/2024 06:43, Chancel Liu wrote: > Add compatible string "fsl,imx95-micfil" for i.MX95 platform. > > Signed-off-by: Chancel Liu Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/3] ASoC: dt-bindings: fsl,sai: Add compatible string for i.MX95 platform

2024-01-11 Thread Krzysztof Kozlowski
On 12/01/2024 06:43, Chancel Liu wrote: > Add compatible string "fsl,imx95-sai" for i.MX95 platform. > > Signed-off-by: Chancel Liu > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] ASoC: dt-bindings: fsl,sai: Add compatible string for i.MX95 platform

2024-01-11 Thread Krzysztof Kozlowski
On 11/01/2024 12:06, Chancel Liu wrote: >>> Add compatible string "fsl,imx95-sai" for i.MX95 platform. >>> >>> Signed-off-by: Chancel Liu >>> --- >>> Documentation/devicetree/bindings/sound/fsl,sai.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindin

Re: [PATCH 1/3] ASoC: dt-bindings: fsl,sai: Add compatible string for i.MX95 platform

2024-01-11 Thread Krzysztof Kozlowski
On 09/01/2024 08:55, Chancel Liu wrote: > Add compatible string "fsl,imx95-sai" for i.MX95 platform. > > Signed-off-by: Chancel Liu > --- > Documentation/devicetree/bindings/sound/fsl,sai.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/sound/fsl,s

Re: [PATCHv3 RESEND 00/10] ASoC: fsl-asoc-card: compatibility integration of a generic codec use case for use with S/PDIF controller

2023-12-18 Thread Krzysztof Kozlowski
uld be used with other CPU DAIs than > the S/PDIF controller, setting these parameters could be required. > > This series of patch was successfully built for arm64 and x86 on top of > the latest for-next branch of the ASoC git tree on the 14th of December. > These modifications have also

Re: [PATCH] dt-bindings: fsl,dpaa2-console: drop unneeded quotes

2023-11-22 Thread Krzysztof Kozlowski
On 22/11/2023 23:44, Rob Herring wrote: > Drop unneeded quotes over simple string values to fix a soon to be > enabled yamllint warning: > > [error] string value is redundantly quoted with any quotes (quoted-strings) > > Signed-off-by: Rob Herring Reviewed-by: Krzyszto

Re: [PATCH v9 14/15] media: imx-asrc: Add memory to memory driver

2023-11-16 Thread Krzysztof Kozlowski
On 16/11/2023 09:32, Shengjiu Wang wrote: >>> +MODULE_DESCRIPTION("Freescale ASRC M2M driver"); >>> +MODULE_ALIAS("platform:" M2M_DRV_NAME); >> >> You should not need MODULE_ALIAS() in normal cases. If you need it, >> usually it means your device ID table is wrong (e.g. misses either >> entries or

Re: [PATCH v9 14/15] media: imx-asrc: Add memory to memory driver

2023-11-11 Thread Krzysztof Kozlowski
On 10/11/2023 06:48, Shengjiu Wang wrote: > +static int asrc_m2m_probe(struct platform_device *pdev) > +{ > + struct fsl_asrc_m2m_pdata *data = pdev->dev.platform_data; > + struct device *dev = &pdev->dev; > + struct asrc_m2m *m2m; > + int ret; > + > + m2m = devm_kzalloc(dev, si

Re: [PATCH v6 08/30] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC

2023-09-26 Thread Krzysztof Kozlowski
On 25/09/2023 15:50, Herve Codina wrote: > With these details, do you still think I need to change the child > (channel) > compatible ? From OS point of view, you have a driver binding to this child-level compatible. How do you enforce Linux driver binding based on p

Re: [PATCH v6 08/30] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC

2023-09-25 Thread Krzysztof Kozlowski
On 25/09/2023 12:27, Herve Codina wrote: > On Mon, 25 Sep 2023 10:21:15 +0200 > Krzysztof Kozlowski wrote: > >> On 25/09/2023 10:17, Herve Codina wrote: >>> Hi Krzysztof, >>> >>> On Sat, 23 Sep 2023 19:39:49 +0200 >>> Krzysztof Kozlowski w

Re: [PATCH 1/2] ASoC: dt-bindings: fsl_rpmsg: List DAPM endpoints ignoring suspend

2023-09-25 Thread Krzysztof Kozlowski
On 25/09/2023 10:20, Chancel Liu wrote: >>> Add a property to list DAPM endpoints which mark paths between these >>> endpoints ignoring suspend. These DAPM paths can still be power on >>> when system enters into suspend. >>> >>> Signed-off-by: Chancel Liu >>> --- >>> Documentation/devicetree/bind

Re: [PATCH v6 08/30] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC

2023-09-25 Thread Krzysztof Kozlowski
On 25/09/2023 10:17, Herve Codina wrote: > Hi Krzysztof, > > On Sat, 23 Sep 2023 19:39:49 +0200 > Krzysztof Kozlowski wrote: > >> On 22/09/2023 09:58, Herve Codina wrote: >>> The QMC (QUICC mutichannel controller) is a controller present in some >>> Pow

Re: [PATCH 1/2] ASoC: dt-bindings: fsl_rpmsg: List DAPM endpoints ignoring suspend

2023-09-24 Thread Krzysztof Kozlowski
On 25/09/2023 04:48, Chancel Liu wrote: > Add a property to list DAPM endpoints which mark paths between these > endpoints ignoring suspend. These DAPM paths can still be power on when > system enters into suspend. > > Signed-off-by: Chancel Liu > --- > Documentation/devicetree/bindings/sound/fs

Re: [PATCH v6 08/30] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC

2023-09-23 Thread Krzysztof Kozlowski
On 22/09/2023 09:58, Herve Codina wrote: > The QMC (QUICC mutichannel controller) is a controller present in some > PowerQUICC SoC such as MPC885. > The QMC HDLC uses the QMC controller to transfer HDLC data. > > Additionally, a framer can be connected to the QMC HDLC. > If present, this framer is

[PATCH] powerpc: dts: add missing space before {

2023-07-05 Thread Krzysztof Kozlowski
Add missing whitespace between node name/label and opening {. Signed-off-by: Krzysztof Kozlowski --- arch/powerpc/boot/dts/fsl/c293si-post.dtsi | 12 ++-- arch/powerpc/boot/dts/fsl/p1022rdk.dts | 10 +- arch/powerpc/boot/dts/fsl/p1022si-post.dtsi | 2 +- arch/powerpc/boot

Re: [PATCH v13 03/15] dt-bindings: Convert gpio-mmio to yaml

2023-04-12 Thread Krzysztof Kozlowski
On 11/04/2023 20:43, Sean Anderson wrote: > This is a generic binding for simple MMIO GPIO controllers. Although we > have a single driver for these controllers, they were previously spread > over several files. Consolidate them. The register descriptions are > adapted from the comments in the sour

Re: [PATCH v11 03/13] dt-bindings: Convert gpio-mmio to yaml

2023-03-14 Thread Krzysztof Kozlowski
On 14/03/2023 20:52, Sean Anderson wrote: > On 3/14/23 15:45, Krzysztof Kozlowski wrote: >> On 14/03/2023 19:50, Sean Anderson wrote: >>> On 3/14/23 14:32, Krzysztof Kozlowski wrote: >>>> On 14/03/2023 19:09, Sean Anderson wrote: >>>>> On 3/14/23 13:5

Re: [PATCH v11 03/13] dt-bindings: Convert gpio-mmio to yaml

2023-03-14 Thread Krzysztof Kozlowski
On 14/03/2023 19:50, Sean Anderson wrote: > On 3/14/23 14:32, Krzysztof Kozlowski wrote: >> On 14/03/2023 19:09, Sean Anderson wrote: >>> On 3/14/23 13:56, Krzysztof Kozlowski wrote: >>>> On 13/03/2023 17:11, Sean Anderson wrote: >>>> + reg-names: >

  1   2   3   4   >