> > + /* TODO: The SAI driver should figure this out for us */
> > + switch (channels) {
> > + case 2:
> > + snd_soc_dai_set_tdm_slot(cpu_dai, 0xfffc, 0xfffc, 2,
> 0);
> > + break;
> > + case 1:
> > + snd_soc_dai_set_tdm_slot(cpu_dai, 0xfffe, 0xfff
> > > The udelay just doesn't make sense to what you are talking about.
> > >
> > > Does SAI really need 10us delay between two register-updating?
> > >
> >
> > No, this is not must be.
>
> Then you should explain in your comments why you really put it here or
> just drop it if it's just a mistake
> The udelay just doesn't make sense to what you are talking about.
>
> Does SAI really need 10us delay between two register-updating?
>
No, this is not must be.
> We basically use udelay only if the IP hardware actually needs it: some
> IP needs time to boot itself up after doing software re
> > > > +static int fsl_sai_probe(struct platform_device *pdev) {
> > > [...]
> > > > +
> > > > + sai->dma_params_rx.addr = res->start + SAI_RDR;
> > > > + sai->dma_params_rx.maxburst = 6;
> > > > + index = of_property_match_string(np, "dma-names", "rx");
> > > > + ret = of_
> > The SGTL5000 is based on regulators and when it is disabled, there
> > will be an error returns directly while the SGTL5000 codec is probing.
>
> What makes you say this?
>
>From the code:
File path: "sound/soc/codecs/sgtl5000.c"
==
#ifdef CONFIG_REGULATOR
.
#else
static
> > > >> If there are any comments that say PPC but are not PPC-specific,
> that
> > > >> >should be fixed.
> > > > Yes, find it.
> > > >
> > > > The comments is in "sound/soc/fsl/Makefile" :
> > > > +++
> > > > "# Freescale PowerPC SSI/DMA Platform Support"
> > > > ---
> > > >
> >
> > On VF610 series there are no regulators used, and now whether the
> > CONFIG_REGULATOR mirco is enabled or not, for the VF610 audio patch
> > series, the board cannot be probe successfully.
> > And this patch will solve this issue.
>
> I don't understand what this is for at all, you're just sa
> >> If there are any comments that say PPC but are not PPC-specific, that
> >> >should be fixed.
> > Yes, find it.
> >
> > The comments is in "sound/soc/fsl/Makefile" :
> > +++
> > "# Freescale PowerPC SSI/DMA Platform Support"
> > ---
> >
> > But fsl-spdif.o is also under it.
> >
> > But fsl-ssi.o and fsl-spdif.o is based PowrePC platform? Which we can
> see from the comments.
>
> fsl_ssi was originally PPC-only, but it now supports PPC and ARM. You
> can see that from the git history.
>
> If there are any comments that say PPC but are not PPC-specific, that
> should be
> > > sound/soc/fsl/fsl-sgtl5000-vf610.c | 208
> > > +
> >
> > I just doubt if this file naming is appropriate. Even if we might not
> > have rigor rule for the file names, according to existing ones, they
> > are all in a same pattern: [SoC name]-[codec name].
Hi Nicolin,
> > This is the SGTL5000 codec based audio driver supported with both
> > playback and capture dai link implemention.
> >
> > This implementation is only compatible with device tree definition.
> >
> > Signed-off-by: Alison Wang > Signed-off-by: Xiubo Li
> >
> > Conflicts:
> > s
=
> [...]
> > diff --git a/sound/soc/fsl/fsl-sgtl5000-vf610.c b/sound/soc/fsl/fsl-
> sgtl5000-vf610.c
> > new file mode 100644
> > index 000..f535b42
> > --- /dev/null
> > +++ b/sound/soc/fsl/fsl-sgtl5000-vf610.c
> > @@ -0,0 +1,208 @@
> > +/*
> > + * Freeacale ALSA SoC Audio using SGT1500 as c
> > From the ASoC subsystem comments we can see that:
> > ++
> > Configures the clock dividers. This is used to derive the best DAI bit
> > and frame clocks from the system or master clock. It's best to set the
> > DAI bit and frame clocks as low as possible to save system power.
> > --
>
> > Conflicts:
> > sound/soc/fsl/Makefile
>
> Ahem.
>
This will be removed.
> > +static int fsl_sgtl5000_remove(struct platform_device *pdev) {
> > + snd_soc_unregister_card(&fsl_sgt1500_card);
> > +
> > + return 0;
> > +}
>
> You're using snd_soc_unregister_card() so you don't need t
> > +static int fsl_sai_set_dai_clkdiv(struct snd_soc_dai *cpu_dai,
> > + int div_id, int div)
> > +{
> > + struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai);
> > + u32 tcr2, rcr2;
> > +
> > + if (div_id == FSL_SAI_TX_DIV) {
> > + tcr2 = readl(sai->base + FSL_SAI_TCR2
> > This adds Freescale SAI ASoC Audio support.
> > This implementation is only compatible with device tree definition.
> > Features:
> > o Supports playback/capture
> > o Supports 16/20/24 bit PCM
> > o Supports 8k - 96k sample rates
> > o Supports slave mode only.
> >
>
> Just for curiosity, I f
Sorry, forgot the Subject!
Sent again.
>
> Hello,
>
> This patch series is mostly Freescale's SAI SoC Digital Audio Interface
> driver implementation. And the implementation is only compatible with
> device tree definition.
>
> This patch series is based on linux-next and has been tested on V
17 matches
Mail list logo
