[PATCH] ucc_geth: fix ethtool set ring param bug

2010-08-30 Thread Liang Li
ng in 180 seconds.. ] Then the natural solution would be 'stop driver/device then adjust ring buffer parameter then reactivate driver/device'. Signed-off-by: Liang Li --- drivers/net/ucc_geth.c |4 ++-- drivers/net/ucc_geth.h |2 ++ drivers/net/ucc_geth_ethtool.c |

Re: [PATCH] ucc_geth: fix ethtool set ring param bug

2010-08-31 Thread Liang Li
On Tue, Aug 31, 2010 at 03:41:22PM +0100, Ben Hutchings wrote: > On Mon, 2010-08-30 at 22:47 +0800, Liang Li wrote: > > It's common sense that when we should do change to driver ring > > desc/buffer etc only after 'stop/shutdown' the device. When we > > do ch

[v1 PATCH] ucc_geth: fix ethtool set ring param bug

2010-08-31 Thread Liang Li
ng in 180 seconds.. ] Then the natural solution would be 'stop driver/device then adjust ring buffer parameter then reactivate driver/device'. v1: add roll back branch for 'auto reopen fail' statement Signed-off-by: Liang Li --- drivers/net/ucc_geth.c |4 ++-- dr

Re: [v1 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-01 Thread Liang Li
On Wed, Sep 01, 2010 at 02:42:30PM +0100, Ben Hutchings wrote: > On Wed, 2010-09-01 at 09:43 +0800, Liang Li wrote: > > It's common sense that when we should do change to driver ring > > desc/buffer etc only after 'stop/shutdown' the device. When we > > do ch

Re: [v1 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-02 Thread Liang Li
On Thu, Sep 02, 2010 at 12:11:47PM +0100, Ben Hutchings wrote: > On Thu, 2010-09-02 at 08:50 +0800, Liang Li wrote: > > On Wed, Sep 01, 2010 at 02:42:30PM +0100, Ben Hutchings wrote: > > > On Wed, 2010-09-01 at 09:43 +0800, Liang Li wrote: > > > > It's common sen

[v2 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-02 Thread Liang Li
ng in 180 seconds.. ] Then the natural solution would be 'stop driver/device then adjust ring buffer parameter then reactivate driver/device'. v1: add roll back state for 'auto reopen fail' v2: just do dev_close when 'reopen fail' Signed-off-by: Liang Li --- drive

Re: [v2 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-02 Thread Liang Li
On Thu, Sep 02, 2010 at 07:04:59PM +0100, Ben Hutchings wrote: > On Fri, 2010-09-03 at 00:02 +0800, Liang Li wrote: > > It's common sense that when we should do change to driver ring > > desc/buffer etc only after 'stop/shutdown' the device. When we > > do ch