Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/include/asm/reg_fsl_emb.h
b/arch/powerpc/include/asm/reg_fsl_emb.h
index 77bb71c..1cf8ab0 100644
--- a/arch/powerpc/include/asm
There are 6 counters in e6500 core instead of 4 in e500 core.
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h | 12
arch/powerpc/kernel/cputable.c |2 +-
arch/powerpc/oprofile/op_model_fsl_emb.c | 30 ++
arch
available, the more specific events have been used which will
produce slightly different results than e500 PMU equivalents.
Based on work done by Priyanka Jain
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h |4 +-
arch/powerpc/perf/Makefile |2 +-
arch
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/include/asm/reg_fsl_emb.h
b/arch/powerpc/include/asm/reg_fsl_emb.h
index 77bb71c..1cf8ab0 100644
--- a/arch/powerpc/include/asm
There are 6 counters in e6500 core instead of 4 in e500 core.
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h | 12
arch/powerpc/kernel/cputable.c |2 +-
arch/powerpc/oprofile/op_model_fsl_emb.c | 30 ++
arch
available, the more specific events have been used which will
produce slightly different results than e500 PMU equivalents.
Based on work done by Priyanka Jain
Signed-off-by: Lijun Pan
Signed-off-by: Priyanka Jain
Signed-off-by: Poonam Aggrwal
---
arch/powerpc/include/asm/reg_fsl_emb.h |4
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/include/asm/reg_fsl_emb.h
b/arch/powerpc/include/asm/reg_fsl_emb.h
index 77bb71c..1cf8ab0 100644
--- a/arch/powerpc/include/asm
available, the more specific events have been used which will
produce slightly different results than e500 PMU equivalents.
Based on work done by Priyanka Jain
Signed-off-by: Lijun Pan
Signed-off-by: Priyanka Jain
Signed-off-by: Poonam Aggrwal
---
arch/powerpc/include/asm/reg_fsl_emb.h |4
Udma
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/perf_event_fsl_emb.h |2 +-
arch/powerpc/perf/core-fsl-emb.c |6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/perf_event_fsl_emb.h
b/arch/powerpc/include/asm
There are 6 counters in e6500 core instead of 4 in e500 core.
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h | 12
arch/powerpc/kernel/cputable.c |2 +-
arch/powerpc/oprofile/op_model_fsl_emb.c | 30 ++
arch
available, the more specific events have been used which will
produce slightly different results than e500 PMU equivalents.
Author: Priyanka Jain
Signed-off-by: Priyanka Jain
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h |4 +-
arch/powerpc/perf/Makefile
Udma
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/perf_event_fsl_emb.h |2 +-
arch/powerpc/perf/core-fsl-emb.c |6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/perf_event_fsl_emb.h
b/arch/powerpc/include/asm
There are 6 counters in e6500 core instead of 4 in e500 core.
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h | 12
arch/powerpc/kernel/cputable.c |2 +-
arch/powerpc/oprofile/op_model_fsl_emb.c | 30 ++
arch
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/include/asm/reg_fsl_emb.h
b/arch/powerpc/include/asm/reg_fsl_emb.h
index 77bb71c..1cf8ab0 100644
--- a/arch/powerpc/include/asm
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/include/asm/reg_fsl_emb.h
b/arch/powerpc/include/asm/reg_fsl_emb.h
index 77bb71c..1cf8ab0 100644
--- a/arch/powerpc/include/asm
There are 6 counters in e6500 core instead of 4 in e500 core.
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h | 12
arch/powerpc/kernel/cputable.c |2 +-
arch/powerpc/oprofile/op_model_fsl_emb.c | 30 ++
arch
cache reloads,
etc). Where available, the more specific events have been used which will
produce slightly different results than e500 PMU equivalents.
Signed-off-by: Priyanka Jain
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/reg_fsl_emb.h |4 +-
arch/powerpc/perf/Mak
Udma
Signed-off-by: Lijun Pan
---
arch/powerpc/include/asm/perf_event_fsl_emb.h |2 +-
arch/powerpc/perf/core-fsl-emb.c |6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/perf_event_fsl_emb.h
b/arch/powerpc/include/asm
bsc9131 device tree does not have these properties.
Signed-off-by: Lijun Pan
---
arch/powerpc/boot/dts/fsl/bsc9131si-pre.dtsi |3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/bsc9131si-pre.dtsi
b/arch/powerpc/boot/dts/fsl/bsc9131si-pre.dtsi
index 743e4ae
b4420 and b4860 device trees do not have these properties.
Signed-off-by: Lijun Pan
---
arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi |2 ++
arch/powerpc/boot/dts/fsl/b4860si-pre.dtsi |2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi
b/arch
b4420 and b4860 device trees do not have these properties.
Signed-off-by: Lijun Pan
---
v2: fixed a typo
arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi |2 ++
arch/powerpc/boot/dts/fsl/b4860si-pre.dtsi |2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/b4420si
mpc85xx_smp_defconfig and mpc85xx_defconfig already have CONFIG_P1023RDS=y.
Merge CONFIG_P1023RDB=y and other relevant configurations into
mpc85xx_smp_defconfig and mpc85_defconfig.
Signed-off-by: Lijun Pan
---
arch/powerpc/configs/85xx/p1023_defconfig | 188
mpc85xx_smp_defconfig and mpc85xx_defconfig already have CONFIG_P1023RDS=y.
Merge CONFIG_P1023RDB=y and other relevant configurations into
mpc85xx_smp_defconfig and mpc85_defconfig.
Signed-off-by: Lijun Pan
---
arch/powerpc/configs/85xx/p1023_defconfig | 188
mpc85xx_smp_defconfig and mpc85xx_defconfig already have CONFIG_P1023RDS=y.
Merge CONFIG_P1023RDB=y and other relevant configurations into
mpc85xx_smp_defconfig and mpc85_defconfig.
Signed-off-by: Lijun Pan
---
arch/powerpc/configs/85xx/p1023_defconfig | 188
mpc85xx_smp_defconfig and mpc85xx_defconfig already have CONFIG_P1023RDS=y.
Merge CONFIG_P1023RDB=y and other relevant configurations into
mpc85xx_smp_defconfig and mpc85_defconfig.
Signed-off-by: Lijun Pan
---
v4 only add CONFIG_P1023_RDB=y CONFIG_EEPROM_AT24=y CONFIG_RTC_DRV_DS1307=y to
P1023RDS is no longer supported by Freescale while P1023RDB is still supported.
Signed-off-by: Lijun Pan
---
arch/powerpc/boot/dts/p1023rds.dts | 219 -
arch/powerpc/configs/mpc85xx_defconfig | 1 -
arch/powerpc/configs/mpc85xx_smp_defconfig
P1023RDS is no longer supported/manufactured by Freescale while P1023RDB is.
Signed-off-by: Lijun Pan
---
arch/powerpc/boot/dts/p1023rds.dts | 219 -
arch/powerpc/configs/mpc85xx_defconfig | 1 -
arch/powerpc/configs/mpc85xx_smp_defconfig
> -Original Message-
> From: Wood Scott-B07421
> Sent: Monday, May 05, 2014 2:05 PM
> To: Pan Lijun-B44306
> Cc: linuxppc-...@ozlabs.org; Medve Emilian-EMMEDVE1
> Subject: Re: [PATCH v2] powerpc/mpc85xx: Remove P1023 RDS support
>
> On Mon, 2014-05-05 at 13:2
Merge Freescale's Internal mpc85xx_smp_defconfig with upstream's.
Run savedefconfig to get the minimal change.
Signed-off-by: Lijun Pan
---
arch/powerpc/configs/mpc85xx_smp_defconfig | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/power
Merge Freescale's Internal mpc85xx_defconfig with upstream's.
Run savedefconfig to get the minimal change.
Signed-off-by: Lijun Pan
---
arch/powerpc/configs/mpc85xx_defconfig | 28 +++-
1 file changed, 7 insertions(+), 21 deletions(-)
diff --git a/arch/power
Merge Freescale's Internal corenet32_smp_defconfig with upstream's.
Run savedefconfig to get the minimal change.
Signed-off-by: Lijun Pan
---
arch/powerpc/configs/corenet32_smp_defconfig | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/arch/power
Merge Freescale's Internal corenet64_smp_defconfig with upstream's.
Run savedefconfig to get the minimal change.
Signed-off-by: Lijun Pan
---
arch/powerpc/configs/corenet64_smp_defconfig | 42
1 file changed, 24 insertions(+), 18 deletions(-)
diff --
> -Original Message-
> From: Wood Scott-B07421
> Sent: Thursday, April 09, 2015 5:31 PM
> To: Pan Lijun-B44306
> Cc: linuxppc-...@ozlabs.org; Schmitt Richard-B43082
> Subject: Re: new way of writing defconfigs for freescale's powerpc platforms
>
> On Thu, 2015-04-09 at 16:52 -0500, Pan L
x27;s powerpc platforms
>
> On Thu, 2015-04-16 at 23:13 -0500, Scott Wood wrote:
> > On Fri, 2015-04-17 at 10:54 +1000, Michael Ellerman wrote:
> > > On Thu, 2015-04-09 at 21:52 +, Lijun Pan wrote:
> > > > Hi Maintainers,
> > > >
> >
make mpc85xx_basic_defconfig
make smp.config
make kvm_guest.config
or just
make mpc85xx_smp_defconfig
Signed-off-by: Lijun Pan
---
arch/powerpc/Makefile | 17 ++
...t32_smp_defconfig => corenet32_basic_defconfig} | 0
...t64_smp_defconfig => corenet64_basi
> > Cc: Pan Lijun-B44306; linuxppc-...@ozlabs.org; Schmitt
> > > Richard-B43082
> > > Subject: Re: new way of writing defconfigs for freescale's powerpc
> > > platforms
> > >
> > > On Thu, 2015-04-16 at 23:13 -0500, Scott Wood wrote:
> > > >
;t want to break the build for existing defconfigs.
Signed-off-by: Lijun Pan
---
v2 changes:
rename kvm_guest.config to kvm_e500.config
utilize the definition of mergeconfig in scripts/kconfig/Makefile
.config before and after this patch differs, need to investigate more
need suggestions on
rules in arch/powerpc/Makefile is
because I don't want to break the build for existing defconfigs.
Signed-off-by: Lijun Pan
---
v3 changes:
1.call "merge_config.sh -m" several times to get a concatenated
arch/powerpc/configs/*_tmp_defconfig before any real "make".
2.
rules in arch/powerpc/Makefile is
because I don't want to break the build for existing defconfigs.
Signed-off-by: Lijun Pan
---
v3 changes:
1.call "merge_config.sh -m" several times to get a concatenated
arch/powerpc/configs/*_tmp_defconfig before any real "make".
2.
> -Original Message-
> From: Wood Scott-B07421
> Sent: Wednesday, May 13, 2015 5:18 PM
> To: Pan Lijun-B44306
> Cc: linuxppc-...@ozlabs.org
> Subject: Re: [PATCH v3] powerpc/defconfig: new way of writing defconfig
>
> On Mon, 2015-05-11 at 23:39 -0500, Lijun Pan
ig as above.
We should not take the following steps.
e.g.
make mpc85xx_basic_defconfig
make smp.config
make kvm_guest.config
Signed-off-by: Lijun Pan
---
v4 changes:
1. removed many fragments according to the review feedback in v3
2. I cannot reuse the code in http://patchwork.ozlabs.o
> On Aug 12, 2019, at 12:07 AM, Paul Mackerras wrote:
>
> ---
> arch/powerpc/include/asm/xive.h | 8
> arch/powerpc/kvm/book3s_xive.c| 31 ++
> arch/powerpc/sysdev/xive/common.c | 87 ---
> 3 files changed, 103 insertions(+), 23 deletion
According to the PAPR, hcalls should not modify the Condition
Register fields, hence save/restore the CR is not necessary.
Signed-off-by: Lijun Pan
---
arch/powerpc/platforms/pseries/hvCall.S | 36 -
1 file changed, 36 deletions(-)
diff --git a/arch/powerpc/platforms
und xive_native_configure_queue() that
> does the necessary cleanup.
>
> Reported-by: Satheesh Rajendran
> Cc: sta...@vger.kernel.org # v5.2
> Fixes: 13ce3297c576 ("KVM: PPC: Book3S HV: XIVE: Add controls for the EQ
> configuration")
> Signed-off-by: Cédric Le Goater
xive_native_configure_queue() that
> does the necessary cleanup.
>
> Reported-by: Satheesh Rajendran
> Cc: sta...@vger.kernel.org # v5.2
> Fixes: 13ce3297c576 ("KVM: PPC: Book3S HV: XIVE: Add controls for the EQ
> configuration")
> Signed-off-by: Cédric Le
("ibmvnic: serialize access to work queue on remove")Signed-off-by: Junlin Yang <yangjun...@yulong.com>---Acked-by: Lijun Pan <l...@linux.ibm.com>Changes in v1: a.According to Christophe Leroy's explanation, update the commit information. b.Add fixes tags. drivers/net/ethe
> On Apr 20, 2021, at 4:35 PM, Dany Madden wrote:
>
> When ibmvnic gets a FATAL error message from the vnicserver, it marks
> the Command Respond Queue (CRQ) inactive and resets the adapter. If this
> FATAL reset fails and a transmission timeout reset follows, the CRQ is
> still inactive, ibmv
On Wed, Apr 21, 2021 at 2:25 AM Sukadev Bhattiprolu
wrote:
>
> Lijun Pan [l...@linux.vnet.ibm.com] wrote:
> >
> >
> > > On Apr 20, 2021, at 4:35 PM, Dany Madden wrote:
> > >
> > > When ibmvnic gets a FATAL error message from the vnicserver, it marks
&
On Wed, Apr 21, 2021 at 3:06 AM Rick Lindsley
wrote:
>
> On 4/20/21 2:42 PM, Lijun Pan wrote:
> >
> > This v2 does not adddress the concerns mentioned in v1.
> > And I think it is better to exit with error from do_reset, and schedule a
> > thorough
> > do_hard
On Tue, Apr 20, 2021 at 4:37 PM Dany Madden wrote:
>
> When ibmvnic gets a FATAL error message from the vnicserver, it marks
> the Command Respond Queue (CRQ) inactive and resets the adapter. If this
> FATAL reset fails and a transmission timeout reset follows, the CRQ is
> still inactive, ibmvnic
On Thu, Apr 22, 2021 at 2:07 AM Rick Lindsley
wrote:
>
> On 4/21/21 10:30 PM, Lijun Pan wrote:
> >> Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
> >> Signed-off-by: Dany Madden
> >> Reviewed-by: Rick Lindsley
> >> Reviewed-by: Su
On Thu, Apr 22, 2021 at 12:21 PM Michal Suchánek wrote:
>
> Hello,
>
> On Thu, Apr 22, 2021 at 12:06:45AM -0500, Lijun Pan wrote:
> > On Wed, Apr 21, 2021 at 2:25 AM Sukadev Bhattiprolu
> > wrote:
> > >
> > > Lijun Pan [l...@linux.vnet.ibm.com] wrote:
; ^~
> drivers/net/ethernet/ibm/ibmvnic.c: In function 'reset_reason_to_string':
> drivers/net/ethernet/ibm/ibmvnic.c:1935:2: warning: enumeration value
> 'VNIC_RESET_FOOBAR' not handled in switch [-Wswitch]
> switch (reason) {
> ^~
>
>
scrq->irq, scrq->msgs);
> return -EINVAL;
> }
>
> If the expression is true, scrq must be a null pointer and cannot
> dereference.
>
> Signed-off-by: YANG LI
> Reported-by: Abaci
> ---
Acked-by: Lijun Pan
ng device
reset")
Signed-off-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index aed985e08e8a..11f28fd03057 100644
--- a/drivers/net/etherne
On Tue, Jan 19, 2021 at 1:56 PM Uwe Kleine-König
wrote:
>
> On Tue, Jan 19, 2021 at 01:33:13PM -0600, Lijun Pan wrote:
> > Returning -EBUSY in ibmvnic_remove() does not actually hold the
> > removal procedure since driver core doesn't care for the return
> > value
Reported-by: Uwe Kleine-König
Fixes: 7d7195a026ba ("ibmvnic: Do not process device remove during device
reset")
Signed-off-by: Lijun Pan
---
v1 versus RFC:
1/ articulate why remove the REMOVING checking in __ibmvnic_reset
and why keep the current checking for REMOVING in ibmvnic_re
On Thu, Jan 21, 2021 at 12:42 PM Dany Madden wrote:
>
> On 2021-01-20 22:20, Lijun Pan wrote:
> > Returning -EBUSY in ibmvnic_remove() does not actually hold the
> > removal procedure since driver core doesn't care for the return
> > value (see __device_release_
> > diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
> > b/drivers/net/ethernet/ibm/ibmvnic.c
> > index aed985e08e8a..11f28fd03057 100644
> > --- a/drivers/net/ethernet/ibm/ibmvnic.c
> > +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> > @@ -2235,8 +2235,7 @@ static void __ibmvnic_reset(struct work_struct
rg/linuxppc-dev/20210117101242.dpwayq6wdgfdz...@pengutronix.de/T/#m48f5befd96bc9842ece2a3ad14f4c27747206a53
Reported-by: Uwe Kleine-König
Fixes: 7d7195a026ba ("ibmvnic: Do not process device remove during device
reset")
Signed-off-by: Lijun Pan
---
v2: drop v1's deletion of REMOVIN
r vio_bus_remove() returns
> calling this unconditionally is the consistent behaviour which is
> implemented here.
>
> Signed-off-by: Uwe Kleine-König
Acked-by: Lijun Pan
On Tue, May 4, 2021 at 2:14 PM Dany Madden wrote:
>
> When ibmvnic gets a FATAL error message from the vnicserver, it marks
> the Command Respond Queue (CRQ) inactive and resets the adapter. If this
> FATAL reset fails and a transmission timeout reset follows, the CRQ is
> still inactive, ibmvnic'
On Tue, May 4, 2021 at 2:27 PM Lijun Pan wrote:
>
> On Tue, May 4, 2021 at 2:14 PM Dany Madden wrote:
> >
> > When ibmvnic gets a FATAL error message from the vnicserver, it marks
> > the Command Respond Queue (CRQ) inactive and resets the adapter. If this
>
enumeration value
> 'VNIC_RESET_FOOBAR' not handled in switch [-Wswitch]
> switch (reason) {
> ^~
>
> Signed-off-by: Michal Suchanek
> Acked-by: Lijun Pan
> ---
> v2: Fix typo in commit message
> ---
Hi Michal,
Thank you for reposting the patch and includ
On Tue, May 4, 2021 at 3:24 PM Dany Madden wrote:
>
> On 2021-05-04 12:31, Lijun Pan wrote:
> > On Tue, May 4, 2021 at 2:27 PM Lijun Pan wrote:
> >>
> >> On Tue, May 4, 2021 at 2:14 PM Dany Madden wrote:
> >> >
> >> > When ibmvnic ge
> On May 18, 2021, at 9:28 PM, YueHaibing wrote:
>
> Use kobj_to_dev() instead of container_of()
>
> Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
>
> Signed-off-by: YueHaibing
> ---
Acked-by: Lijun Pan
> drivers/net/ethernet/ibm/ibmveth.c | 3 +--
&g
On Thu, Jun 10, 2021 at 7:56 AM Wang Hai wrote:
>
> Convert list_for_each() to list_for_each_entry() where
> applicable. This simplifies the code.
>
> Reported-by: Hulk Robot
> Signed-off-by: Wang Hai
> ---
Acked-by: Lijun Pan
The error messages in the changed functions are exactly the same.
In order to differentiate them and make debugging easier,
we print the function names in the error messages.
Signed-off-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 14 +++---
1 file changed, 7 insertions(+), 7
ff-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index 50e86e65961e..e366fd42a8c4 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
Instead of comparing (adapter->init_done_rc == 1), let it
be (adapter->init_done_rc == PARTIALSUCCESS).
Signed-off-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/et
At the beginning of the function, from_passive_init is set false by
"adapter->from_passive_init = false;",
hence the if statement will never run.
Signed-off-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers
This patch series refactor reset_init and init functions,
improve the debugging messages, and make some other cosmetic changes
to make the code easier to read and debug.
Lijun Pan (5):
ibmvnic: print caller in several error messages
ibmvnic: compare adapter->init_done_rc with more reada
These two functions share the majority of the code, hence merge
them together. In the meanwhile, add a reset pass-in parameter
to differentiate them. Thus, the code is easier to read and to tell
the difference between reset_init and regular init.
Signed-off-by: Lijun Pan
---
drivers/net
This patch series refactor reset_init and init functions,
improve the debugging messages, and make some other cosmetic changes
to make the code easier to read and debug.
Lijun Pan (5):
ibmvnic: print caller in several error messages
ibmvnic: compare adapter->init_done_rc with more reada
Instead of comparing (adapter->init_done_rc == 1), let it
be (adapter->init_done_rc == PARTIALSUCCESS).
Signed-off-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/et
The error messages in the changed functions are exactly the same.
In order to differentiate them and make debugging easier,
we print the function names in the error messages.
Signed-off-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 14 +++---
1 file changed, 7 insertions(+), 7
ff-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index 50e86e65961e..e366fd42a8c4 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
At the beginning of the function, from_passive_init is set false by
"adapter->from_passive_init = false;",
hence the if statement will never run.
Signed-off-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers
These two functions share the majority of the code, hence merge
them together. In the meanwhile, add a reset pass-in parameter
to differentiate them. Thus, the code is easier to read and to tell
the difference between reset_init and regular init.
Signed-off-by: Lijun Pan
---
drivers/net
This patch series refactor reset_init and init functions,
and make some other cosmetic changes to make the code
easier to read and debug. v2 removes __func__ and v1's 1/5.
Lijun Pan (4):
ibmvnic: compare adapter->init_done_rc with more readable
ibmvnic_rc_codes
ibmvnic:
Instead of comparing (adapter->init_done_rc == 1), let it
be (adapter->init_done_rc == PARTIALSUCCESS).
Signed-off-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/et
ff-by: Lijun Pan
---
v2: removes __func__ in error messages.
drivers/net/ethernet/ibm/ibmvnic.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index 65f5d99f97dc..644352e5056d 100644
At the beginning of the function, from_passive_init is set false by
"adapter->from_passive_init = false;",
hence the if statement will never run.
Signed-off-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers
These two functions share the majority of the code, hence merge
them together. In the meanwhile, add a reset pass-in parameter
to differentiate them. Thus, the code is easier to read and to tell
the difference between reset_init and regular init.
Signed-off-by: Lijun Pan
---
drivers/net
84 matches
Mail list logo
