Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-12-15 Thread LiuShuo
于 2011年12月15日 04:15, Scott Wood 写道: On 12/14/2011 02:41 AM, LiuShuo wrote: 于 2011年12月13日 10:46, LiuShuo 写道: 于 2011年12月13日 05:30, Scott Wood 写道: On 12/12/2011 03:19 PM, Artem Bityutskiy wrote: On Mon, 2011-12-12 at 15:15 -0600, Scott Wood wrote: NAND chips come from the factory with bad

Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-12-14 Thread LiuShuo
于 2011年12月13日 10:46, LiuShuo 写道: 于 2011年12月13日 05:30, Scott Wood 写道: On 12/12/2011 03:19 PM, Artem Bityutskiy wrote: On Mon, 2011-12-12 at 15:15 -0600, Scott Wood wrote: NAND chips come from the factory with bad blocks marked at a certain offset into each page. This offset is normally in the

Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-12-13 Thread LiuShuo
struct mtd_info *mtd) { if (!check_migrated_bbt_pattern()) bad_block_info_migtrate(); nand_default_bbt(mtd); /* default function in nand_bbt.c */ } - LiuShuo ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-12-12 Thread LiuShuo
se a user-space tool? That's the kind of answer I was hoping to get from Shuo. :-) OK, I try to do this. Wait for a couple of days. -LiuShuo Most likely is a firmware-based tool, but I'd like there to be some way for the tool to mark that this has happened, so that the Linux driver can refu

Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-12-08 Thread LiuShuo
于 2011年12月08日 03:11, Scott Wood 写道: On 12/06/2011 09:55 PM, LiuShuo wrote: 于 2011年12月07日 08:09, Scott Wood 写道: On 12/03/2011 10:31 PM, shuo@freescale.com wrote: From: Liu Shuo Freescale FCM controller has a 2K size limitation of buffer RAM. In order to support the Nand flash chip whose

Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-12-06 Thread LiuShuo
(FIR_OP_RS<< FIR_OP4_SHIFT)); Please explicitly show the (FIR_OP_NOP<< FIR_OP0_SHIFT) compenent. + } else if (mtd->writesize>= 2048&& mtd->writesize<= 16 * 1024) { + setbits32(&lbc->bank[priv->bank].or, OR_FCM_PGS); Don't insert a blank line here. Ok. -LiuShuo -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-11-24 Thread LiuShuo
于 2011年11月24日 16:16, Artem Bityutskiy 写道: On Thu, 2011-11-24 at 07:49 +, Li Yang-R58472 wrote: Subject: Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip On Thu, 2011-11-24 at 08:41 +0800, b35...@freescale.com wrote: + /* +

Re: [PATCH v3 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-11-23 Thread LiuShuo
before calling nand_scan(). We will +* re-malloc later if needed. +*/ + elbc_fcm_ctrl->buffer = kmalloc(4096 * 6, GFP_KERNEL); + if (!elbc_fcm_ctrl->buffer) + return -ENOMEM; Clean up properly if you fail to allocate the buffer. This includes freeing elbc_fcm_ctrl, setting fsl_lbc_ctrl_dev->nand to NULL, and releasing fsl_elbc_nand_mutex. -Scott - LiuShuo ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-11-22 Thread LiuShuo
er have to be used if writesize +* of chip is greater than 2048. +* We malloc a large enough buffer at this point, because we +* don't know writesize before calling nand_scan(). We will +* re-malloc later if needed. +

Re: [PATCH 2/3] mtd/nand : set Nand flash page address to FBAR and FPAR correctly

2011-11-17 Thread LiuShuo
Ok and I want to add another patch before 3/3. -LiuShuo On Tue, 2011-11-15 at 17:29 +0800, b35...@freescale.com wrote: From: Liu Shuo If we use the Nand flash chip whose number of pages in a block is greater than 64(for large page), we must treat the low bit of FBAR as being the high bit of

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-09-01 Thread LiuShuo
于 2011年08月25日 19:25, Matthieu CASTET 写道: Hi, LiuShuo a écrit : 于 2011年08月23日 18:02, Matthieu CASTET 写道: LiuShuo a écrit : 于 2011年08月19日 00:25, Scott Wood 写道: On 08/17/2011 09:33 PM, b35...@freescale.com wrote: From: Liu Shuo Freescale FCM controller has a 2K size limitation of buffer RAM

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-23 Thread LiuShuo
于 2011年08月23日 18:02, Matthieu CASTET 写道: LiuShuo a écrit : 于 2011年08月19日 00:25, Scott Wood 写道: On 08/17/2011 09:33 PM, b35...@freescale.com wrote: From: Liu Shuo Freescale FCM controller has a 2K size limitation of buffer RAM. In order to support the Nand flash chip whose page size is larger

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-23 Thread LiuShuo
于 2011年08月23日 16:14, Matthieu CASTET 写道: LiuShuo a écrit : 于 2011年08月23日 00:19, Scott Wood 写道: On 08/22/2011 11:13 AM, Matthieu CASTET wrote: Scott Wood a écrit : To eliminate it we'd need to do an extra data transfer without reissuing the command, which Shuo was unable to get to

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-23 Thread LiuShuo
Maybe we will always print the NOP restrictions when this hack is used, let the customers select how to use the flash on their board. -LiuShuo If it's less than 4 for 4K or 8 for 8K, also print a message saying not to use jffs2 (does yaffs2 do similar things?). If it's less than 2 for 4K

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-22 Thread LiuShuo
于 2011年08月23日 00:19, Scott Wood 写道: On 08/22/2011 11:13 AM, Matthieu CASTET wrote: Scott Wood a écrit : To eliminate it we'd need to do an extra data transfer without reissuing the command, which Shuo was unable to get to work. That's weird because our controller seems quite flexible [1]. So

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-18 Thread LiuShuo
于 2011年08月19日 01:00, Matthieu CASTET 写道: b35...@freescale.com a écrit : From: Liu Shuo Freescale FCM controller has a 2K size limitation of buffer RAM. In order to support the Nand flash chip whose page size is larger than 2K bytes, we divide a page into multi-2K pages for MTD layer driver. In

Re: [PATCH] mtd-utils: fix corrupt cleanmarker with flash_erase -j command

2011-08-17 Thread LiuShuo
t mtd_info { .. enum { MTD_OOB_PLACE, MTD_OOB_AUTO, MTD_OOB_RAW, } oob_mode; } In function mtd_do_writeoob() (in drivers/mtd/mtdchar.c) : - ops.mode = MTD_OOB_PLACE; + ops.mode = mtd->oob_mode; Could w