Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-05 Thread Marc Zyngier
On 2024-07-05 09:05, Christian Zigotzky wrote: How about the other patch[1], which would be far preferable? M. [1] https://lore.kernel.org/all/86ed8ba2sp.wl-...@kernel.org - - - - Marc, We will test the patch as soon as possible. Christian - - - - Our tester has reported, that it

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-04 Thread Marc Zyngier
On Thu, 04 Jul 2024 05:10:46 +0100, Christian Zigotzky wrote: > > On 02.07.24 18:54, Marc Zyngier wrote: > > On Sun, 30 Jun 2024 11:21:55 +0100, > > Christian Zigotzky wrote: > >> Hello, > >> > >> There is an issue with the identification of ATA

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-03 Thread Marc Zyngier
Hi Michael, On Wed, 03 Jul 2024 12:30:38 +0100, Michael Ellerman wrote: > > Rob Herring writes: > > On Tue, Jul 2, 2024 at 10:54 AM Marc Zyngier wrote: > >> > >> On Sun, 30 Jun 2024 11:21:55 +0100, > >> Christian Zigotzky wrote: > >>

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-03 Thread Marc Zyngier
On Wed, 03 Jul 2024 11:26:17 +0100, Christian Zigotzky wrote: > > On 3. Jul 2024, at 08:40, Marc Zyngier wrote: > > This isn't a DTS. This is a listing of all the nodes, not something I > can use to feed the kernel. I explained how to generate it. > > Download the

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-03 Thread Marc Zyngier
On Wed, 03 Jul 2024 04:27:37 +0100, Christian Zigotzky wrote: > > Hello Marc, > > On 02.07.24 18:54, Marc Zyngier wrote: > > On Sun, 30 Jun 2024 11:21:55 +0100, > > Christian Zigotzky wrote: > >> Hello, > >> > >> There is an issue with the i

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-03 Thread Marc Zyngier
On Wed, 03 Jul 2024 04:11:55 +0100, Christian Zigotzky wrote: > > Hello Marc, > > On 02.07.24 21:49, Marc Zyngier wrote: > > On 2024-07-02 18:55, Christian Zigotzky wrote: > >> Hello Marc, > >> > >> Thank you for your reply. > >> &g

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-02 Thread Marc Zyngier
On Tue, 02 Jul 2024 21:48:23 +0100, Rob Herring wrote: > > On Tue, Jul 2, 2024 at 10:54 AM Marc Zyngier wrote: > > > > On Sun, 30 Jun 2024 11:21:55 +0100, > > Christian Zigotzky wrote: > > > > > > Hello, > > > > > > There is an is

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-02 Thread Marc Zyngier
On 2024-07-02 18:55, Christian Zigotzky wrote: Hello Marc, Thank you for your reply. On 02.07.24 17:19, Marc Zyngier wrote: Please provide the device tree for your platform. It isn't possible to debug this without it, no matter how many pictures you provide. If it doesn't exist in source form

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-02 Thread Marc Zyngier
On Sun, 30 Jun 2024 11:21:55 +0100, Christian Zigotzky wrote: > > Hello, > > There is an issue with the identification of ATA drives with our > P.A. Semi Nemo boards [1] after the > commit "of/irq: Factor out parsing of interrupt-map parent > phandle+args from of_irq_parse_raw()" [2]. [snip]

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-02 Thread Marc Zyngier
Christian, On Sun, 30 Jun 2024 11:21:55 +0100, Christian Zigotzky wrote: > > Hello, > > There is an issue with the identification of ATA drives with our > P.A. Semi Nemo boards [1] after the > commit "of/irq: Factor out parsing of interrupt-map parent > phandle+args from of_irq_parse_raw()"

Re: [PATCH v4 09/29] KVM: arm64: use `at s1e1a` for POE

2024-05-29 Thread Marc Zyngier
ruction could fail, and not get the IPA. > > Switch to using `at s1e1a` so that KVM can get the IPA regardless of S1 > permissions. > > Signed-off-by: Joey Gouly > Cc: Marc Zyngier > Cc: Oliver Upton > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/kvm/

Re: [PATCH v4 08/29] KVM: arm64: make kvm_at() take an OP_AT_*

2024-05-29 Thread Marc Zyngier
On Fri, 03 May 2024 14:01:26 +0100, Joey Gouly wrote: > > To allow using newer instructions that current assemblers don't know about, > replace the `at` instruction with the underlying SYS instruction. > > Signed-off-by: Joey Gouly > Cc: Marc Zyngier > Cc: Oliver Upton

Re: [PATCH v4 07/29] KVM: arm64: Save/restore POE registers

2024-05-29 Thread Marc Zyngier
On Fri, 03 May 2024 14:01:25 +0100, Joey Gouly wrote: > > Define the new system registers that POE introduces and context switch them. > > Signed-off-by: Joey Gouly > Cc: Marc Zyngier > Cc: Oliver Upton > Cc: Catalin Marinas > Cc: Will Deacon > --- > arc

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-13 Thread Marc Zyngier
On Fri, 12 Apr 2024 15:54:22 +0100, Sean Christopherson wrote: > > On Fri, Apr 12, 2024, Marc Zyngier wrote: > > On Fri, 12 Apr 2024 11:44:09 +0100, Will Deacon wrote: > > > On Fri, Apr 05, 2024 at 07:58:12AM -0400, Paolo Bonzini wrote: > > > Also, if you're in t

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-12 Thread Marc Zyngier
On Fri, 12 Apr 2024 11:44:09 +0100, Will Deacon wrote: > > On Fri, Apr 05, 2024 at 07:58:12AM -0400, Paolo Bonzini wrote: > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index dc04bc767865..ff17849be9f4 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > > @@

Re: [PATCH 0/4] KVM, mm: remove the .change_pte() MMU notifier and set_pte_at_notify()

2024-04-12 Thread Marc Zyngier
mm/migrate_device.c | 8 +--- > mm/mmu_notifier.c | 17 - > virt/kvm/kvm_main.c | 50 + > 26 files changed, 10 insertions(+), 411 deletions(-) > Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.

Re: [PATCH] KVM: Get rid of return value from kvm_arch_create_vm_debugfs()

2024-02-16 Thread Marc Zyngier
ail VM creation. > > Change to a void return to discourage architectures from making debugfs > failures fatal for the VM. Seems like everyone already had the right > idea, as all implementations already return 0 unconditionally. > > Signed-off-by: Oliver Upton Acked-by: Marc

Re: kvm/arm64: Spark benchmark

2023-06-09 Thread Marc Zyngier
On Fri, 09 Jun 2023 01:59:35 +0100, Yu Zhao wrote: > > TLDR > > Apache Spark spent 12% less time sorting four billion random integers twenty > times (in ~4 hours) after this patchset [1]. Why are the 3 architectures you have considered being evaluated with 3 different benchmarks? I am not

Re: [PATCH mm-unstable v1 3/5] kvm/arm64: add kvm_arch_test_clear_young()

2023-02-23 Thread Marc Zyngier
On Thu, 23 Feb 2023 03:58:47 +, Yu Zhao wrote: > > On Fri, Feb 17, 2023 at 2:00 AM Marc Zyngier wrote: > > > > On Fri, 17 Feb 2023 04:21:28 +, > > Yu Zhao wrote: > > > > > > On Thu, Feb 16, 2023 at 9:12 PM Yu Zhao wrote: > > >

Re: [PATCH mm-unstable v1 3/5] kvm/arm64: add kvm_arch_test_clear_young()

2023-02-17 Thread Marc Zyngier
| 1 + > > arch/arm64/kvm/hyp/pgtable.c| 51 ++-- > > arch/arm64/kvm/mmu.c| 77 - > > 6 files changed, 141 insertions(+), 46 deletions(-) > > Adding Marc and Will. > > Can you please add other interested part

Re: [PATCH v2 00/50] KVM: Rework kvm_init() and hardware enabling

2022-12-28 Thread Marc Zyngier
On 2022-12-27 13:02, Paolo Bonzini wrote: Queued, thanks. I will leave this in kvm/queue after testing everything else and moving it to kvm/next; this way, we can wait for test results on other architectures. Can you please make this a topic branch, and if possible based on a released -rc?

Re: [PATCH AUTOSEL 4.14 3/4] powerpc/msi: Fix deassociation of MSI descriptors

2022-12-28 Thread Marc Zyngier
On Tue, 27 Dec 2022 20:36:08 +, Sasha Levin wrote: > > From: Marc Zyngier > > [ Upstream commit 4545c6a3d6ba71747eaa984c338ddd745e56e23f ] > > Since 2f2940d16823 ("genirq/msi: Remove filter from > msi_free_descs_free_range()"), the core MSI code relies on th

Re: [PATCH v4 12/12] KVM: remove KVM_REQ_UNHALT

2022-09-22 Thread Marc Zyngier
by: Paolo Bonzini > Signed-off-by: Sean Christopherson Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.

Re: [PATCH v6 32/33] arm64: irq-gic: Replace unreachable() with -EINVAL

2022-06-23 Thread Marc Zyngier
On 2022-06-23 02:49, Chen Zhongjin wrote: Using unreachable() at default of switch generates an extra branch at end of the function, and compiler won't generate a ret to close this branch because it knows it's unreachable. If there's no instruction in this branch, compiler will generate a NOP,

Re: [PATCH 23/36] arm64,smp: Remove trace_.*_rcuidle() usage

2022-06-15 Thread Marc Zyngier
} > > > > if ((unsigned)ipinr < NR_IPI) > > - trace_ipi_exit_rcuidle(ipi_types[ipinr]); > > + trace_ipi_exit(ipi_types[ipinr]); > > } > > > > static irqreturn_t ipi_handler(int irq, void *data) Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.

Re: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs shutdown path

2022-04-29 Thread Marc Zyngier
eally!) off. > > This patch mimics the ipi_cpu_stop() interrupt disable mechanism > in the crash CPU shutdown path, hence disabling IRQs/FIQs in all > secondary CPUs in the kexec/panic path as well. > > Cc: Marc Zyngier > Cc: Russell King > Signed-off-by: Guilherme G. Pi

Re: [PATCH 02/30] ARM: kexec: Disable IRQs/FIQs also on crash CPUs shutdown path

2022-04-29 Thread Marc Zyngier
On Fri, 29 Apr 2022 22:45:14 +0100, "Russell King (Oracle)" wrote: > > On Fri, Apr 29, 2022 at 06:38:19PM -0300, Guilherme G. Piccoli wrote: > > Thanks Marc and Michael for the review/discussion. > > > > On 29/04/2022 15:20, Marc Zyngier wrote: > >

Re: [PATCH] powerpc/sysdev: Use of_device_get_match_data()

2022-03-04 Thread Marc Zyngier
On Fri, 04 Mar 2022 13:10:19 +, Christophe Leroy wrote: > > > > Le 04/03/2022 à 02:18, cgel@gmail.com a écrit : > > From: Minghao Chi (CGEL ZTE) > > > > Use of_device_get_match_data() to simplify the code. > > > > Reported-by: Zeal Robot > > Signed-off-by: Minghao Chi (CGEL ZTE) >

Re: [PATCH v3 08/12] KVM: Propagate vcpu explicitly to mark_page_dirty_in_slot()

2021-11-17 Thread Marc Zyngier
On Wed, 17 Nov 2021 17:39:59 +, David Woodhouse wrote: > > From: David Woodhouse > > The kvm_dirty_ring_get() function uses kvm_get_running_vcpu() to work out > which dirty ring to use, but there are some use cases where that doesn't > work. > > There's one in setting the Xen shared info

Re: [PATCH v3 02/12] KVM: Add Makefile.kvm for common files, use it for x86

2021-11-17 Thread Marc Zyngier
m-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o > +kvm-$(CONFIG_KVM_VFIO) += $(KVM)/vfio.o > +kvm-$(CONFIG_KVM_MMIO) += $(KVM)/coalesced_mmio.o > +kvm-$(CONFIG_KVM_ASYNC_PF) += $(KVM)/async_pf.o > +kvm-$(CONFIG_HAVE_KVM_IRQ_ROUTING) += $(KVM)/irqchip.o > +kvm-$(CONFIG_HAVE_KVM_DIRTY_RING) += $(KVM)/dirty_ring.o Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.

Re: [PATCH v3 07/12] KVM: arm64: Use Makefile.kvm for common files

2021-11-17 Thread Marc Zyngier
m.o mmu.o mmio.o psci.o perf.o hypercalls.o pvtime.o \ >inject_fault.o va_layout.o handle_exit.o \ >guest.o debug.o reset.o sys_regs.o \ >vgic-sys-reg-v3.o fpsimd.o pmu.o \ Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.

Re: [PATCH] powerpc/xive: Change IRQ domain to a tree domain

2021-11-16 Thread Marc Zyngier
driver to use a 'tree' domain type instead. > > [1] For instance, a linux KVM guest with virtio-rng and virtio-balloon > devices. > > Cc: Marc Zyngier > Cc: sta...@vger.kernel.org # v5.14+ > Fixes: 4f86a06e2d6e ("irqdomain: Make normal and nomap irqdomains exclus

[PATCH v2 7/7] KVM: Convert kvm_for_each_vcpu() to using xa_for_each_range()

2021-11-16 Thread Marc Zyngier
Now that the vcpu array is backed by an xarray, use the optimised iterator that matches the underlying data structure. Suggested-by: Sean Christopherson Signed-off-by: Marc Zyngier --- include/linux/kvm_host.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/include

[PATCH v2 6/7] KVM: Use 'unsigned long' as kvm_for_each_vcpu()'s index

2021-11-16 Thread Marc Zyngier
Everywhere we use kvm_for_each_vpcu(), we use an int as the vcpu index. Unfortunately, we're about to move rework the iterator, which requires this to be upgrade to an unsigned long. Let's bite the bullet and repaint all of it in one go. Signed-off-by: Marc Zyngier --- arch/arm64/kvm

[PATCH v2 5/7] KVM: Convert the kvm->vcpus array to a xarray

2021-11-16 Thread Marc Zyngier
this memory, let's use an xarray instead, which gives us almost the same flexibility as a normal array, but with a reduced memory usage with smaller VMs. Signed-off-by: Marc Zyngier --- include/linux/kvm_host.h | 5 +++-- virt/kvm/kvm_main.c | 15 +-- 2 files changed, 12

[PATCH v2 4/7] KVM: x86: Use kvm_get_vcpu() instead of open-coded access

2021-11-16 Thread Marc Zyngier
As we are about to change the way vcpus are allocated, mandate the use of kvm_get_vcpu() instead of open-coding the access. Signed-off-by: Marc Zyngier --- arch/x86/kvm/vmx/posted_intr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx/posted_intr.c b/arch

[PATCH v2 3/7] KVM: s390: Use kvm_get_vcpu() instead of open-coded access

2021-11-16 Thread Marc Zyngier
As we are about to change the way vcpus are allocated, mandate the use of kvm_get_vcpu() instead of open-coding the access. Reviewed-by: Claudio Imbrenda Signed-off-by: Marc Zyngier --- arch/s390/kvm/kvm-s390.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch

[PATCH v2 2/7] KVM: mips: Use kvm_get_vcpu() instead of open-coded access

2021-11-16 Thread Marc Zyngier
As we are about to change the way vcpus are allocated, mandate the use of kvm_get_vcpu() instead of open-coding the access. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Marc Zyngier --- arch/mips/kvm/loongson_ipi.c | 4 ++-- arch/mips/kvm/mips.c | 2 +- 2 files changed, 3

[PATCH v2 1/7] KVM: Move wiping of the kvm->vcpus array to common code

2021-11-16 Thread Marc Zyngier
her changes. The locking is dropped altogether, as this should only be called when there is no further references on the kvm structure. Reviewed-by: Claudio Imbrenda Signed-off-by: Marc Zyngier --- arch/arm64/kvm/arm.c | 10 +- arch/mips/kvm/mips.c |

[PATCH v2 0/7] KVM: Turn the vcpu array into an xarray

2021-11-16 Thread Marc Zyngier
into an xarray, which results in a net code deletion after a bit of cleanup. * From v1: - Rebased on v5.16-rc1 - Dropped the dubious locking on teardown - Converted kvm_for_each_vcpu() to xa_for_each_range(), together with an invasive change converting the index to an unsigned long Marc

Re: [PATCH 0/5] KVM: Turn the vcpu array into an xarray

2021-11-16 Thread Marc Zyngier
On Tue, 16 Nov 2021 15:03:40 +, Paolo Bonzini wrote: > > On 11/5/21 20:20, Marc Zyngier wrote: > > The kvm structure is pretty large. A large portion of it is the vcpu > > array, which is 4kB on x86_64 and arm64 as they deal with 512 vcpu > > VMs. Of course, hardly

Re: [PATCH 16/39] irqdomain: Make normal and nomap irqdomains exclusive

2021-11-16 Thread Marc Zyngier
On Mon, 15 Nov 2021 19:05:17 +, Cédric Le Goater wrote: > > Hello Mark, s/k/c/ > > On 5/20/21 18:37, Marc Zyngier wrote: > > Direct mappings are completely exclusive of normal mappings, meaning > > that we can refactor the code slightl

Re: [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates

2021-11-12 Thread Marc Zyngier
On Fri, 12 Nov 2021 14:15:18 +, Christian Zigotzky wrote: > > On 12 November 2021 at 02:41 pm, Marc Zyngier wrote: > > On Fri, 12 Nov 2021 09:40:30 +, > > Christian Zigotzky wrote: > >> On 11 November 2021 at 06:39 pm, Marc Zyngier wrote: > >>

Re: [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates

2021-11-12 Thread Marc Zyngier
On Fri, 12 Nov 2021 09:40:30 +, Christian Zigotzky wrote: > > On 11 November 2021 at 06:39 pm, Marc Zyngier wrote: > > On Wed, 10 Nov 2021 18:07:24 +, > > Christian Zigotzky wrote: > >> On 09 November 2021 at 03:45 pm, Christian Zigotzky wrote: > >>

Re: [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates

2021-11-11 Thread Marc Zyngier
On Wed, 10 Nov 2021 18:07:24 +, Christian Zigotzky wrote: > > On 09 November 2021 at 03:45 pm, Christian Zigotzky wrote: > > Hello, > > > > The Nemo board [1] doesn't recognize any ATA disks with the > pci-v5.16 updates [2]. > > > > Error messages: > > > > ata4.00: gc timeout cmd 0xec > >

Re: [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates

2021-11-11 Thread Marc Zyngier
On Thu, 11 Nov 2021 10:44:30 +, Christian Zigotzky wrote: > > On 11 November 2021 at 11:20 am, Marc Zyngier wrote: > > On Thu, 11 Nov 2021 07:47:08 +, > > Christian Zigotzky wrote: > >> On 11 November 2021 at 08:13 am, Marc Zyngier wrote: > >>

Re: [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates

2021-11-11 Thread Marc Zyngier
On Thu, 11 Nov 2021 07:47:08 +, Christian Zigotzky wrote: > > On 11 November 2021 at 08:13 am, Marc Zyngier wrote: > > On Thu, 11 Nov 2021 05:24:52 +, > > Christian Zigotzky wrote: > >> Hello Marc, > >> > >> Here you are: > >> ht

Re: [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates

2021-11-10 Thread Marc Zyngier
On Thu, 11 Nov 2021 05:24:52 +, Christian Zigotzky wrote: > > On 10 November 2021 at 08:09 pm, Marc Zyngier wrote: > > HI all, > > > > On Wed, 10 Nov 2021 18:41:06 +, > > Bjorn Helgaas wrote: > >> On Wed, Nov 10, 2021 at 07:07:24PM +0100, Christi

Re: [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates

2021-11-10 Thread Marc Zyngier
ATA disks without any problems. > > > > I created a patch for an easy reverting the bad commit [1]. With this patch > > we can do further our kernel tests. > > > > Could you please check the first bad commit [2]? > > > > Thanks, > > Chr

Re: [PATCH 5/5] KVM: Convert the kvm->vcpus array to a xarray

2021-11-08 Thread Marc Zyngier
On 2021-11-06 11:48, Marc Zyngier wrote: On Fri, 05 Nov 2021 20:21:36 +, Sean Christopherson wrote: On Fri, Nov 05, 2021, Marc Zyngier wrote: > At least on arm64 and x86, the vcpus array is pretty huge (512 entries), > and is mostly empty in most cases (running 512 vc

Re: [PATCH 5/5] KVM: Convert the kvm->vcpus array to a xarray

2021-11-06 Thread Marc Zyngier
On Fri, 05 Nov 2021 20:21:36 +, Sean Christopherson wrote: > > On Fri, Nov 05, 2021, Marc Zyngier wrote: > > At least on arm64 and x86, the vcpus array is pretty huge (512 entries), > > and is mostly empty in most cases (running 512 vcpu VMs is not that > > common).

Re: [PATCH 1/5] KVM: Move wiping of the kvm->vcpus array to common code

2021-11-06 Thread Marc Zyngier
On Fri, 05 Nov 2021 20:12:12 +, Sean Christopherson wrote: > > On Fri, Nov 05, 2021, Marc Zyngier wrote: > > All architectures have similar loops iterating over the vcpus, > > freeing one vcpu at a time, and eventually wiping the reference > > off the vc

[PATCH 5/5] KVM: Convert the kvm->vcpus array to a xarray

2021-11-05 Thread Marc Zyngier
an xarray instead, which gives us almost the same flexibility as a normal array, but with a reduced memory usage with smaller VMs. Signed-off-by: Marc Zyngier --- include/linux/kvm_host.h | 5 +++-- virt/kvm/kvm_main.c | 15 +-- 2 files changed, 12 insertions(+), 8 deletions(-) diff

[PATCH 1/5] KVM: Move wiping of the kvm->vcpus array to common code

2021-11-05 Thread Marc Zyngier
her changes. Signed-off-by: Marc Zyngier --- arch/arm64/kvm/arm.c | 10 +- arch/mips/kvm/mips.c | 21 + arch/powerpc/kvm/powerpc.c | 10 +- arch/riscv/kvm/vm.c| 10 +- arch/s390/kvm/kvm-s390.c | 18 +- arch/x86/kvm/

[PATCH 4/5] KVM: x86: Use kvm_get_vcpu() instead of open-coded access

2021-11-05 Thread Marc Zyngier
As we are about to change the way vcpus are allocated, mandate the use of kvm_get_vcpu() instead of open-coding the access. Signed-off-by: Marc Zyngier --- arch/x86/kvm/vmx/posted_intr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx/posted_intr.c b/arch

[PATCH 3/5] KVM: s390: Use kvm_get_vcpu() instead of open-coded access

2021-11-05 Thread Marc Zyngier
As we are about to change the way vcpus are allocated, mandate the use of kvm_get_vcpu() instead of open-coding the access. Signed-off-by: Marc Zyngier --- arch/s390/kvm/kvm-s390.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390

[PATCH 0/5] KVM: Turn the vcpu array into an xarray

2021-11-05 Thread Marc Zyngier
into an xarray, which results in a net code deletion after a bit of cleanup. This series is on top of the current linux/master as it touches the RISC-V implementation. Only tested on arm64. Marc Zyngier (5): KVM: Move wiping of the kvm->vcpus array to common code KVM: mips: Use kvm_get_v

[PATCH 2/5] KVM: mips: Use kvm_get_vcpu() instead of open-coded access

2021-11-05 Thread Marc Zyngier
As we are about to change the way vcpus are allocated, mandate the use of kvm_get_vcpu() instead of open-coding the access. Signed-off-by: Marc Zyngier --- arch/mips/kvm/loongson_ipi.c | 4 ++-- arch/mips/kvm/mips.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v5 00/14] PCI: Add support for Apple M1

2021-10-05 Thread Marc Zyngier
On Mon, 04 Oct 2021 21:42:45 +0100, Linus Walleij wrote: > > On Mon, Oct 4, 2021 at 9:52 PM Rob Herring wrote: > > > FYI, I pushed patches 1-3 to kernelCI and didn't see any regressions. > > I am a bit worried about changes to the DT interrupt parsing and > > ancient platforms (such as

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.15-1 tag

2021-09-03 Thread Marc Zyngier
Hi Michael, On Fri, 03 Sep 2021 14:36:57 +0100, Michael Ellerman wrote: > > Hi Linus, > > Please pull powerpc updates for 5.15. > > A bit of a small batch this time. > > There was one conflict against my own fixes branch, and the resolution was a > little bit > messy, so I just did a merge

Re: [PATCH 0/2] Fix arm64 boot regression in 5.14

2021-07-20 Thread Marc Zyngier
: Benjamin Herrenschmidt Cc: Christophe Leroy Cc: Paul Mackerras Cc: Jonathan Marek Cc: Catalin Marinas Cc: Andrew Morton Cc: Nicholas Piggin Cc: Mark Rutland Cc: Geert Uytterhoeven Cc: Marc Zyngier Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-arm-ker...@lists.infradead.org --->8 Jona

Re: [PATCH 4/6] KVM: arm64/mmu: avoid struct page in MMU

2021-06-24 Thread Marc Zyngier
On Thu, 24 Jun 2021 04:57:47 +0100, David Stevens wrote: > > From: David Stevens > > Avoid converting pfns returned by follow_fault_pfn to struct pages to > transiently take a reference. The reference was originally taken to > match the reference taken by gup. However, pfns returned by >

Re: [PATCH 3/6] KVM: x86/mmu: avoid struct page in MMU

2021-06-24 Thread Marc Zyngier
On Thu, 24 Jun 2021 09:58:00 +0100, Nicholas Piggin wrote: > > Excerpts from David Stevens's message of June 24, 2021 1:57 pm: > > From: David Stevens > > out_unlock: > > if (is_tdp_mmu_root(vcpu->kvm, vcpu->arch.mmu->root_hpa)) > > read_unlock(>kvm->mmu_lock); > > else > >

Re: [PATCH 2/6] KVM: mmu: also return page from gfn_to_pfn

2021-06-24 Thread Marc Zyngier
Hi David, On Thu, 24 Jun 2021 04:57:45 +0100, David Stevens wrote: > > From: David Stevens > > Return a struct kvm_pfn_page containing both a pfn and an optional > struct page from the gfn_to_pfn family of functions. This differentiates > the gup and follow_fault_pfn cases, which allows

Re: [PATCH 15/31] KVM: PPC: Book3S HV: XIVE: Fix mapping of passthrough interrupts

2021-05-15 Thread Marc Zyngier
On Fri, 14 May 2021 21:51:51 +0100, Thomas Gleixner wrote: > > On Fri, Apr 30 2021 at 10:03, Cédric Le Goater wrote: > > CC: +Marc Thanks Thomas. > > > PCI MSI interrupt numbers are now mapped in a PCI-MSI domain but the > > underlying calls handling the passthrough of the interrupt in the >

Re: [PATCH 2/9] ARM: PXA: Kill use of irq_create_strict_mappings()

2021-04-27 Thread Marc Zyngier
Hi Guenter, Thanks for the heads up. On Mon, 26 Apr 2021 23:39:42 +0100, Guenter Roeck wrote: > > On Tue, Apr 06, 2021 at 10:35:50AM +0100, Marc Zyngier wrote: > > irq_create_strict_mappings() is a poor way to allow the use of > > a linear IRQ domain as a legacy one. Let'

Re: [PATCH 4/9] sh: intc: Drop the use of irq_create_identity_mapping()

2021-04-06 Thread Marc Zyngier
On Tue, 06 Apr 2021 11:32:13 +0100, Geert Uytterhoeven wrote: > > Hi Marc, > > On Tue, Apr 6, 2021 at 11:44 AM Marc Zyngier wrote: > > Instead of playing games with using irq_create_identity_mapping() > > and irq_domain_associate(), drop the use of the former and

Re: [PATCH 1/9] irqdomain: Reimplement irq_linear_revmap() with irq_find_mapping()

2021-04-06 Thread Marc Zyngier
Christophe, On Tue, 06 Apr 2021 12:21:33 +0100, Christophe Leroy wrote: > > > > Le 06/04/2021 à 11:35, Marc Zyngier a écrit : > > irq_linear_revmap() is supposed to be a fast path for domain > > lookups, but it only exposes low-level details of the irqdomain > >

[PATCH 9/9] irqdomain: Kill irq_domain_add_legacy_isa

2021-04-06 Thread Marc Zyngier
This helper doesn't have a user anymore, let's remove it. Signed-off-by: Marc Zyngier --- Documentation/core-api/irq/irq-domain.rst | 1 - include/linux/irqdomain.h | 11 --- 2 files changed, 12 deletions(-) diff --git a/Documentation/core-api/irq/irq-domain.rst b

[PATCH 8/9] powerpc: Convert irq_domain_add_legacy_isa use to irq_domain_add_legacy

2021-04-06 Thread Marc Zyngier
NR_IRQS_LEGACY. The dependency cannot be broken yet as there is a lot of PPC-related code that depends on it, but that's the first step towards it. A followup patch will remove irq_domain_add_legacy_isa. Signed-off-by: Marc Zyngier --- arch/powerpc/include/asm/irq.h | 4 ++-- arch/powerpc

[PATCH 5/9] irqdomain: Kill irq_create_strict_mappings()/irq_create_identity_mapping()

2021-04-06 Thread Marc Zyngier
No user of these APIs are left, remove them. Signed-off-by: Marc Zyngier --- include/linux/irqdomain.h | 9 - kernel/irq/irqdomain.c| 35 --- 2 files changed, 44 deletions(-) diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h index

[PATCH 7/9] irqdomain: Drop references to recusive irqdomain setup

2021-04-06 Thread Marc Zyngier
It was never completely implemented, and was removed a long time ago. Adjust the documentation to reflect this. Signed-off-by: Marc Zyngier --- kernel/irq/irqdomain.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c

[PATCH 6/9] mips: netlogic: Use irq_domain_simple_ops for XLP PIC

2021-04-06 Thread Marc Zyngier
Use the generic irq_domain_simple_ops structure instead of a home-grown one. Signed-off-by: Marc Zyngier --- arch/mips/netlogic/common/irq.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/mips/netlogic/common/irq.c b/arch/mips/netlogic/common/irq.c index

[PATCH 4/9] sh: intc: Drop the use of irq_create_identity_mapping()

2021-04-06 Thread Marc Zyngier
Instead of playing games with using irq_create_identity_mapping() and irq_domain_associate(), drop the use of the former and only use the latter, together with the allocation of the irq_desc as needed. It doesn't make the code less awful, but at least the intent is clearer. Signed-off-by: Marc

[PATCH 0/9] Cleaning up some of the irqdomain features

2021-04-06 Thread Marc Zyngier
in the way irqdomains work. M. Marc Zyngier (9): irqdomain: Reimplement irq_linear_revmap() with irq_find_mapping() ARM: PXA: Kill use of irq_create_strict_mappings() irqchip/jcore-aic: Kill use of irq_create_strict_mappings() sh: intc: Drop the use of irq_create_identity_mapping

[PATCH 1/9] irqdomain: Reimplement irq_linear_revmap() with irq_find_mapping()

2021-04-06 Thread Marc Zyngier
meaningful difference compared to the cost of taking an interrupt. Reimplement irq_linear_revmap() with irq_find_mapping() in order to preserve source code compatibility, and rename the internal field for a measure. Signed-off-by: Marc Zyngier --- include/linux/irqdomain.h | 22

[PATCH 3/9] irqchip/jcore-aic: Kill use of irq_create_strict_mappings()

2021-04-06 Thread Marc Zyngier
irq_create_strict_mappings() is a poor way to allow the use of a linear IRQ domain as a legacy one. Let's be upfront about it. Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-jcore-aic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-jcore-aic.c

[PATCH 2/9] ARM: PXA: Kill use of irq_create_strict_mappings()

2021-04-06 Thread Marc Zyngier
irq_create_strict_mappings() is a poor way to allow the use of a linear IRQ domain as a legacy one. Let's be upfront about it and use a legacy domain when appropriate. Signed-off-by: Marc Zyngier --- arch/arm/mach-pxa/pxa_cplds_irqs.c | 24 +++- 1 file changed, 11 insertions

Re: [PATCH v3 2/2] powerpc/pseries: pass MSI affinity to irq_create_mapping()

2020-11-25 Thread Marc Zyngier
On 2020-11-25 16:24, Laurent Vivier wrote: On 25/11/2020 17:05, Denis Kirjanov wrote: On 11/25/20, Laurent Vivier wrote: With virtio multiqueue, normally each queue IRQ is mapped to a CPU. But since commit 0d9f0a52c8b9f ("virtio_scsi: use virtio IRQ affinity") this is broken on pseries.

Re: [PATCH v2 1/2] genirq: add an irq_create_mapping_affinity() function

2020-11-25 Thread Marc Zyngier
On 2020-11-25 14:09, Laurent Vivier wrote: On 25/11/2020 14:20, Thomas Gleixner wrote: Laurent, On Wed, Nov 25 2020 at 12:16, Laurent Vivier wrote: The proper subsystem prefix is: 'genirq/irqdomain:' and the first letter after the colon wants to be uppercase. Ok. This function adds an

Re: [RFC PATCH kernel 1/2] irq: Add reference counting to IRQ mappings

2020-10-27 Thread Marc Zyngier
Hi Alexey, On 2020-10-27 09:06, Alexey Kardashevskiy wrote: PCI devices share 4 legacy INTx interrupts from the same PCI host bridge. Device drivers map/unmap hardware interrupts via irq_create_mapping()/ irq_dispose_mapping(). The problem with that these interrupts are shared and when

Re: [PATCH v4 2/7] KVM: arm64: clean up redundant 'kvm_run' parameters

2020-05-05 Thread Marc Zyngier
Hi Tianjia, On 2020-04-27 05:35, Tianjia Zhang wrote: In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This patch does a unified

Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function

2020-04-16 Thread Marc Zyngier
On 2020-04-16 09:45, Tianjia Zhang wrote: On 2020/4/16 16:28, Marc Zyngier wrote: [...] Overall, there is a large set of cleanups to be done when both the vcpu and the run structures are passed as parameters at the same time. Just grepping the tree for kvm_run is pretty instructive

Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function

2020-04-16 Thread Marc Zyngier
On 2020-04-16 08:03, Vitaly Kuznetsov wrote: Tianjia Zhang writes: In earlier versions of kvm, 'kvm_run' is an independent structure and is not included in the vcpu structure. At present, 'kvm_run' is already included in the vcpu structure, so the parameter 'kvm_run' is redundant. This patch

Re: [PATCH 03/35] docs: fix broken references to text files

2020-04-09 Thread Marc Zyngier
> hwtracing/coresight/Kconfig > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/virt/kvm/arm/pvtime.rst| 2 +- > virt/kvm/arm/vgic/vgic-mmio-v3.c | 2 +- > virt/kvm/arm/vgic/vgic.h | 4 ++-- Acked-b

Re: [PATCH 10/10] soc: qcom: convert to devm_platform_ioremap_resource

2019-12-15 Thread Marc Zyngier
On Sat, 14 Dec 2019 17:54:47 + Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/soc/qcom/llcc-qcom.c| 7 +-- > drivers/soc/qcom/qcom-geni-se.c | 4 +--- > drivers/soc/qcom/qcom_aoss.c| 4 +--- >

Re: [RFC PATCH 03/23] genirq: Introduce IRQF_DELIVER_AS_NMI

2018-06-13 Thread Marc Zyngier
On 13/06/18 10:20, Thomas Gleixner wrote: > On Wed, 13 Jun 2018, Julien Thierry wrote: >> On 13/06/18 09:34, Peter Zijlstra wrote: >>> On Tue, Jun 12, 2018 at 05:57:23PM -0700, Ricardo Neri wrote: diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h index 5426627..dbc5e02

Re: [PATCH] Extract initrd free logic from arch-specific code.

2018-03-29 Thread Marc Zyngier
On Thu, 29 Mar 2018 18:32:47 +0100, Russell King - ARM Linux wrote: > > On Thu, Mar 29, 2018 at 05:53:14PM +0100, Marc Zyngier wrote: > > On Thu, 29 Mar 2018 16:58:27 +0100, > > Russell King - ARM Linux wrote: [...] > > > I'm not aware of there being an emulated

Re: [PATCH] Extract initrd free logic from arch-specific code.

2018-03-29 Thread Marc Zyngier
On Thu, 29 Mar 2018 16:58:27 +0100, Russell King - ARM Linux wrote: > > On Thu, Mar 29, 2018 at 05:43:47PM +0200, Geert Uytterhoeven wrote: > > On Thu, Mar 29, 2018 at 5:27 PM, Russell King - ARM Linux > > wrote: > > > On Thu, Mar 29, 2018 at 09:37:52AM +1100, Oliver

Re: [PATCH v10 0/4] this patchset is to remove PPCisms for QEIC

2017-11-02 Thread Marc Zyngier
On 01/11/17 17:09, Thomas Gleixner wrote: > On Wed, 1 Nov 2017, Qiang Zhao wrote: >> Michael Ellerman wrote >>> >>> Qiang Zhao writes: >>> Hi all, Could anybody review this patchset and take action on them? Thank you! >>> >>> Who maintains

Re: [PATCH v9 4/4] irqchip/qeic: remove PPCisms for QEIC

2017-08-04 Thread Marc Zyngier
[Please add all the irqchip maintainers when posting irqchip patches...] On 03/08/17 04:38, Zhao Qiang wrote: > QEIC was supported on PowerPC, and dependent on PPC, > Now it is supported on other platforms, so remove PPCisms. > > Signed-off-by: Zhao Qiang > --- >

Re: [Patch V7 4/4] irqchip/qeic: remove PPCisms for QEIC

2017-01-05 Thread Marc Zyngier
On 26/12/16 08:32, Zhao Qiang wrote: > QEIC was supported on PowerPC, and dependent on PPC, > Now it is supported on other platforms, so remove PPCisms. > > Signed-off-by: Zhao Qiang > --- > Changes for v6: > - new added > Changes for v7: > - fix warning > >

Re: [Patch V7 2/4] irqchip/qeic: merge qeic init code from platforms to a common function

2017-01-05 Thread Marc Zyngier
On 26/12/16 08:32, Zhao Qiang wrote: > The codes of qe_ic init from a variety of platforms are redundant, > merge them to a common function and put it to irqchip/irq-qeic.c > > For non-p1021_mds mpc85xx_mds boards, use "qe_ic_init(np, 0, > qe_ic_cascade_low_mpic, qe_ic_cascade_high_mpic);"

Re: [PATCH v6 2/4] irqchip/qeic: merge qeic init code from platforms to a common function

2016-12-16 Thread Marc Zyngier
On 16/12/16 08:43, Qiang Zhao wrote: > On 16/12/16 04:33, Marc Zyngier <marc.zyng...@arm.com> wrote: > >> -Original Message----- >> From: Marc Zyngier [mailto:marc.zyng...@arm.com] >> Sent: Friday, December 16, 2016 4:33 PM >> To: Qiang Zhao <qi

Re: [PATCH v6 2/4] irqchip/qeic: merge qeic init code from platforms to a common function

2016-12-16 Thread Marc Zyngier
On 28/09/16 04:25, Zhao Qiang wrote: > The codes of qe_ic init from a variety of platforms are redundant, > merge them to a common function and put it to irqchip/irq-qeic.c > > For non-p1021_mds mpc85xx_mds boards, use "qe_ic_init(np, 0, > qe_ic_cascade_low_mpic, qe_ic_cascade_high_mpic);"

Re: [Patch v7 0/7] microblaze/PowerPC: Move irq-xilinx to irqchip

2016-11-22 Thread Marc Zyngier
On 14/11/16 12:13, Zubair Lutfullah Kakakhel wrote: > Hi, > > This patch series moves the Xilinx interrupt controller driver out > of arch/microblaze to drivers/irqchip and then cleans it up a bit. > And then removes another implementation of the driver in arch/powerpc. > > This effort results

Re: [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx,kind-of-intr not provided

2016-11-21 Thread Marc Zyngier
On 21/11/16 14:05, Zubair Lutfullah Kakakhel wrote: > Hi, > > On 11/18/2016 01:29 PM, Thomas Gleixner wrote: >> On Mon, 14 Nov 2016, Zubair Lutfullah Kakakhel wrote: >> >>> The powerpc dts file does not have the xlnx,kind-of-intr property. >>> Instead of erroring out, give a warning instead. And

Re: [Patch V6 2/6] irqchip: xilinx: Clean up irqdomain argument and read/write

2016-11-09 Thread Marc Zyngier
missing >> something. > > I wrote this patch/cleanup based on a review of driver by Marc when I moved > the > driver from arch/microblaze to drivers/irqchip > > "Marc Zyngier > > ... > > > arch/microblaze/kernel/intc.c | 196 > -

Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

2016-10-25 Thread Marc Zyngier
On 25/10/16 15:44, Sören Brinkmann wrote: > On Tue, 2016-10-25 at 12:49:33 +0200, Thomas Gleixner wrote: >> On Tue, 25 Oct 2016, Zubair Lutfullah Kakakhel wrote: >>> On 10/21/2016 10:48 AM, Marc Zyngier wrote: >>>> Shouldn't you return an error if irq is zero? >&

Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

2016-10-21 Thread Marc Zyngier
On 17/10/16 17:52, Zubair Lutfullah Kakakhel wrote: > The MIPS based xilfpga platform has the following IRQ structure > > Peripherals --> xilinx_intcontroller -> mips_cpu_int controller > > Add support for the driver to chain the irq handler > > Signed-off-by: Zubair Lutfullah Kakakhel

  1   2   >