Re: [PATCH 6/6] ASoC: fsl_ssi: adjust set DAI format in AC'97 mode

2015-08-02 Thread Markus Pargmann
On Fri, Jul 31, 2015 at 05:13:06PM +0200, Maciej S. Szmigiero wrote: > On 31.07.2015 07:58, Markus Pargmann wrote: > > On Thu, Jul 30, 2015 at 04:35:58PM +0200, Maciej S. Szmigiero wrote: > >> Adjust set DAI format function in fsl_ssi driver so it > >> doesn't fai

Re: [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates

2015-08-02 Thread Markus Pargmann
Hi, On Fri, Jul 31, 2015 at 04:38:20PM +0200, Maciej S. Szmigiero wrote: > Hi Markus, > > Thanks for looking into the changes. > > On 31.07.2015 07:53, Markus Pargmann wrote: > > On Fri, Jul 31, 2015 at 07:27:19AM +0200, Markus Pargmann wrote: > >> Hi, > >

Re: [PATCH 5/6] ASoC: fsl_ssi: instantiate AC'97 CODEC

2015-08-02 Thread Markus Pargmann
On Fri, Jul 31, 2015 at 04:39:20PM +0200, Maciej S. Szmigiero wrote: > On 31.07.2015 07:46, Markus Pargmann wrote: > > On Thu, Jul 30, 2015 at 04:35:23PM +0200, Maciej S. Szmigiero wrote: > >> Instantiate AC'97 CODEC in fsl_ssi driver AC'97 mode. > >>

Re: [PATCH 6/6] ASoC: fsl_ssi: adjust set DAI format in AC'97 mode

2015-07-30 Thread Markus Pargmann
On Thu, Jul 30, 2015 at 04:35:58PM +0200, Maciej S. Szmigiero wrote: > Adjust set DAI format function in fsl_ssi driver so it > doesn't fail and clears RXDIR in AC'97 mode. > > Signed-off-by: Maciej Szmigiero > --- > sound/soc/fsl/fsl_ssi.c |8 +--- > 1 files changed, 5 insertions(+), 3

Re: [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates

2015-07-30 Thread Markus Pargmann
On Fri, Jul 31, 2015 at 07:27:19AM +0200, Markus Pargmann wrote: > Hi, > > On Thu, Jul 30, 2015 at 04:34:19PM +0200, Maciej S. Szmigiero wrote: > > AC'97 bus can support asymmetric playback/capture rates > > so enable them in this case in fsl_ssi driver. > > >

Re: [PATCH 5/6] ASoC: fsl_ssi: instantiate AC'97 CODEC

2015-07-30 Thread Markus Pargmann
On Thu, Jul 30, 2015 at 04:35:23PM +0200, Maciej S. Szmigiero wrote: > Instantiate AC'97 CODEC in fsl_ssi driver AC'97 mode. > > Signed-off-by: Maciej Szmigiero > --- > sound/soc/fsl/fsl_ssi.c | 21 + > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/sou

Re: [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates

2015-07-30 Thread Markus Pargmann
Hi, On Thu, Jul 30, 2015 at 04:34:19PM +0200, Maciej S. Szmigiero wrote: > AC'97 bus can support asymmetric playback/capture rates > so enable them in this case in fsl_ssi driver. > > Signed-off-by: Maciej Szmigiero > --- > sound/soc/fsl/fsl_ssi.c |4 +++- > 1 files changed, 3 insertions(+)

Re: [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()

2014-11-30 Thread Markus Pargmann
iver_exit [snd_soc_fsl_ssi]) from > [<8008ed80>] (SyS_delete_mod) > [ 31.786553] [<8008ec64>] (SyS_delete_module) from [<8000ec20>] > (ret_fast_syscall+0x0/0x48) > [ 31.794824] r6:00c46d18 r5:0800 r4:00c46d18 > [ 31.799530] ---[ e

Re: [PATCH V3] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-15 Thread Markus Pargmann
On Mon, Sep 15, 2014 at 06:37:15PM +0800, Shengjiu Wang wrote: > On Mon, Sep 15, 2014 at 12:32:13PM +0200, Markus Pargmann wrote: > > On Mon, Sep 15, 2014 at 06:22:27PM +0800, Shengjiu Wang wrote: > > > On Mon, Sep 15, 2014 at 12:05:41PM +0200, Markus Pargmann wrote: > >

Re: [PATCH V3] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-15 Thread Markus Pargmann
On Mon, Sep 15, 2014 at 06:22:27PM +0800, Shengjiu Wang wrote: > On Mon, Sep 15, 2014 at 12:05:41PM +0200, Markus Pargmann wrote: > > On Fri, Sep 12, 2014 at 06:35:15PM +0800, Shengjiu Wang wrote: > > > Check if ipg clock is in clock-names property, then we can move the > >

Re: [PATCH V3] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-15 Thread Markus Pargmann
On Fri, Sep 12, 2014 at 06:35:15PM +0800, Shengjiu Wang wrote: > Check if ipg clock is in clock-names property, then we can move the > ipg clock enable and disable operation to startup and shutdown, that > is only enable ipg clock when ssi is working and keep clock is disabled > when ssi is in idle

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-12 Thread Markus Pargmann
On Fri, Sep 12, 2014 at 03:14:28PM +0800, Shengjiu Wang wrote: > On Fri, Sep 12, 2014 at 08:17:06AM +0200, Markus Pargmann wrote: > > Hi, > > > > On Fri, Sep 12, 2014 at 10:01:12AM +0800, Shengjiu Wang wrote: > > > On Thu, Sep 11, 2014 at 03:57:37PM -0700, Nicolin C

Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-11 Thread Markus Pargmann
Hi, On Fri, Sep 12, 2014 at 10:01:12AM +0800, Shengjiu Wang wrote: > On Thu, Sep 11, 2014 at 03:57:37PM -0700, Nicolin Chen wrote: > > On Thu, Sep 11, 2014 at 01:38:29PM +0800, Shengjiu Wang wrote: > > > Move the ipg clock enable and disable operation to startup and shutdown, > > > that is only en

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-10 Thread Markus Pargmann
On Wed, Sep 10, 2014 at 10:42:04AM -0700, Nicolin Chen wrote: > On Wed, Sep 10, 2014 at 04:12:53PM +0800, Shengjiu Wang wrote: > > > Then we can get a patch like: > > > open() { > > > + clk_prepare_enable(); > > > > > > } > > > > > > close() { > > > > > > + clk_disable_unprepare() >

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-10 Thread Markus Pargmann
Hi, On Wed, Sep 10, 2014 at 06:30:06PM +0800, Shengjiu Wang wrote: > On Wed, Sep 10, 2014 at 08:21:18AM +0200, Markus Pargmann wrote: > > On Tue, Sep 09, 2014 at 11:38:05AM -0700, Nicolin Chen wrote: > > > On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: > >

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Markus Pargmann
On Tue, Sep 09, 2014 at 11:38:05AM -0700, Nicolin Chen wrote: > On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: > > @@ -1321,7 +1333,11 @@ static int fsl_ssi_probe(struct platform_device > > *pdev) > > return -ENOMEM; > > } > > > > - ssi_private->regs = devm_regm

Re: [alsa-devel] [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Markus Pargmann
Hi, On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: > Move the ipg clock enable and disable operation to startup and shutdown, > that is only enable ipg clock when ssi is working. we don't need to enable > ipg clock in probe. > Another register accessing need the ipg clock, so use