Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-05-13 Thread Maynard Johnson
Sukadev Bhattiprolu wrote on 05/09/2014 09:46:38 PM: > From: Sukadev Bhattiprolu > To: Arnaldo Carvalho de Melo , > Cc: linux-ker...@vger.kernel.org, Anton Blanchard > , ulrich.weig...@de.ibm.com, Michael Ellerman > , Maynard Johnson/Rochester/IBM@IBMUS, > linuxppc-dev@lists

Re: oprofile callgraph support missing for common cpus

2011-11-17 Thread Maynard Johnson
On 11/17/2011 2:38 AM, Joakim Tjernlund wrote: arch/powerpc/oprofile/common.c has this init code: int __init oprofile_arch_init(struct oprofile_operations *ops) { if (!cur_cpu_spec->oprofile_cpu_type) return -ENODEV; if (firmwa

Re: [PATCH] oprofile, powerpc: Handle events that raise an exception without overflowing

2011-05-23 Thread Maynard Johnson
Eric B Munson wrote: > On Mon, 23 May 2011, Eric B Munson wrote: > >> Commit 0837e3242c73566fc1c0196b4ec61779c25ffc93 fixes a situation on POWER7 >> where events can roll back if a specualtive event doesn't actually complete. >> This can raise a performance monitor exception. We need to catch thi

Re: [PATCH] powerpc: Fix bug where perf_counters breaks oprofile

2009-09-14 Thread Maynard Johnson
Maynard Johnson wrote: > Paul Mackerras wrote: >> Currently there is a bug where if you use oprofile on a pSeries >> machine, then use perf_counters, then use oprofile again, oprofile >> will not work correctly; it will lose the PMU configuration the next >> time the

Re: [PATCH] powerpc: Fix bug where perf_counters breaks oprofile

2009-09-09 Thread Maynard Johnson
d thereafter > won't count anything. > > Maynard Johnson identified the sequence causing the problem: > - oprofile setup calls ppc_enable_pmcs(), which calls > pseries_lpar_enable_pmcs, which tells the hypervisor that we want > to use the PMU, and sets the "PMU i

Re: [PATCH] Fix oprofile sampling of marked events on POWER7

2009-06-15 Thread Maynard Johnson
POWER6. Thanks. -Maynard Signed-off-by: Maynard Johnson diff -paur linux/arch/powerpc/oprofile/op_model_power4.c linux-p7-oprofile-patch//arch/powerpc/oprofile/op_model_power4.c --- linux/arch/powerpc/oprofile/op_model_power4.c 2009-05-01 08:20:21.0 -0500 +++ linux-p7-oprofile-patc

[PATCH] Fix oprofile sampling of marked events on POWER7

2009-05-01 Thread Maynard Johnson
slot bits on all newer processors starting with POWER6. Thanks. -Maynard Signed-off-by: Maynard Johnson diff -paur linux/arch/powerpc/oprofile/op_model_power4.c linux-p7-oprofile-patch//arch/powerpc/oprofile/op_model_power4.c --- linux/arch/powerpc/oprofile/op_model_power4.c 2009-05-01 08

Re: [PATCH] Add PPC_FEATURE_PMU_COMPAT

2008-07-07 Thread Maynard Johnson
Nathan Lynch wrote: > Kumar Gala wrote: > >> On Jul 3, 2008, at 6:20 PM, Nathan Lynch wrote: >> >> >>> Beginning with Power6, there is a set of 32 PMU events which is >>> compatible across POWER processor lines. PPC_FEATURE_PMU_COMPAT >>> indicates support for this subset. >>> >>> Signed-o

Re: [PATCH] Updated: Reworked Cell OProfile: SPU mutex lock fix

2008-05-02 Thread Maynard Johnson
Phil, When you have a chance, could you please take a look at the arch-independent pieces of the OProfile kernel driver that this patch touches? In short, this patch fixes a bug that I was responsible for in my original OProfile-Cell SPE port (argh! :-[ ) where I was improperly adding events

Re: [PATCH] Updated: Reworked Cell OProfile: SPU mutex lock fix

2008-05-01 Thread Maynard Johnson
Carl Love wrote: Sorry, looks like my mailer mangled the file. This is a reworked patch to fix the SPU data storage. Currently, the SPU escape sequences and program counter data is being added directly into the kernel buffer without holding the buffer_mutex lock. This patch changes how the

Re: [Cbe-oss-dev] [PATCH] Reworked Cell OProfile: SPU mutex lock fix

2008-04-24 Thread Maynard Johnson
Carl Love wrote: This is a reworked patch to fix the SPU data storage. Currently, the SPU escape sequences and program counter data is being added directly into the kernel buffer without holding the buffer_mutex lock. This patch changes how the data is stored. A new function, oprofile_add_v

Re: copy_from_user problem

2008-02-27 Thread Maynard Johnson
Benjamin Herrenschmidt wrote: > On Tue, 2008-02-26 at 08:49 -0600, Maynard Johnson wrote: > >> 2. Compile C program as 32-bit; then run it. While the program is >> waiting for input, obtain its PID and do 'cat /proc//maps' to >> get >> the address of

Re: copy_from_user problem

2008-02-26 Thread Maynard Johnson
Nathan Lynch wrote: > Maynard Johnson wrote: >> static long lib_addr; >> module_param(lib_addr, long, 0); > > Should be unsigned long? Right. I switched this to 'ulong', but that didn't m

Re: copy_from_user problem

2008-02-26 Thread Maynard Johnson
Benjamin Herrenschmidt wrote: On Mon, 2008-02-25 at 19:47 -0600, Maynard Johnson wrote: Hi, I'm developing a kernel module that needs to parse the in-memory ELF objects for a shared library (libc, to be specific). When running my test on a 32-bit library, it works fine, but for a 6

copy_from_user problem

2008-02-25 Thread Maynard Johnson
We look at the entry for libc in /proc//maps, and the permissions are the same for both 32-bit and 64-bit. I've run this test on both a stock SLES 10 SP1 kernel and on 2.6.24. I'm sure this is a user error, but for the life of me, I don't know what I'm doing wrong. Can anyon

Re: Resend: [PATCH] oprofile support for Power 5++

2007-07-10 Thread Maynard Johnson
Will Schmidt wrote: > On Tue, 2007-07-10 at 15:31 -0500, Michael Neuling wrote: > Does it make more sense to call this "ppc64/power5+rev3"? >>> >>>This is a change to support new counter setup for oprofile. It may be the >>>same if there is a revision 4 or 5 etc. So since the inter