[PATCH 5/5] selftests/powerpc: Detect taint change in mitigation patching test

2024-11-06 Thread Michael Ellerman
tainted to begin with, and only report a change in the taint state as an error in the test. Signed-off-by: Michael Ellerman --- .../selftests/powerpc/security/mitigation-patching.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/powerpc

[PATCH 4/5] selftests/powerpc: Return errors from all tests

2024-11-06 Thread Michael Ellerman
rting. Signed-off-by: Michael Ellerman --- tools/testing/selftests/powerpc/signal/sigfuz.c| 2 +- .../testing/selftests/powerpc/tm/tm-signal-context-force-tm.c | 2 +- tools/testing/selftests/powerpc/tm/tm-signal-sigreturn-nt.c| 3 +-- 3 files changed, 3 insertions(+), 4 dele

[PATCH 3/5] selftests/powerpc: Fix 32-bit BE build errors on Ubuntu 24.04

2024-11-06 Thread Michael Ellerman
to unsigned long long and long long before passing to printf to avoid the errors. Signed-off-by: Michael Ellerman --- tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c | 2 +- tools/testing/selftests/powerpc/mm/subpage_prot.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletio

Re: [PATCH] hwrng: amd - remove reference to removed PPC_MAPLE config

2024-11-06 Thread Michael Ellerman
in its dependencies. > > Remove the reference to the removed config option. > > Signed-off-by: Lukas Bulwahn > --- > drivers/char/hw_random/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Michael Ellerman (powerpc) Thanks for cleaning it up. The

[PATCH 1/5] selftests/powerpc: Lower run time of count_stcx_fail test

2024-11-06 Thread Michael Ellerman
The count_stcx_fail test runs for close to or just over 2 minutes, which means it sometimes times out. That's overkill for a test that just demonstrates some PMU counters are working. Drop the 64 billion instruction case, to lower the runtime to ~30s. Signed-off-by: Michael Ellerman ---

[PATCH 2/5] selftests/powerpc: Give all tests 2 minutes timeout

2024-11-06 Thread Michael Ellerman
ff-by: Michael Ellerman --- tools/testing/selftests/powerpc/alignment/settings | 1 + tools/testing/selftests/powerpc/cache_shape/settings | 1 + tools/testing/selftests/powerpc/copyloops/settings | 1 + tools/testing/selftests/powerpc/dexcr/settings | 1 + tools/te

Re: [PATCH] powerpc: Add __must_check to set_memory_...()

2024-11-06 Thread Michael Ellerman
Christophe Leroy writes: > Hi Michael, > > Le 07/09/2024 à 17:40, Christophe Leroy a écrit : >> After the following powerpc commits, all calls to set_memory_...() >> functions check returned value. >> - Commit 8f17bd2f4196 ("powerpc: Handle error in mark_rodata_ro() and >> mark_initmem_nx()") >> -

Re: [PATCH 00/28] vdso: Preparations for generic data storage

2024-11-05 Thread Michael Ellerman
Christophe Leroy writes: > Le 30/10/2024 à 12:39, Thomas Gleixner a écrit : >> Folks! >> >> On Thu, Oct 10 2024 at 09:01, Thomas Weißschuh wrote: >>> Historically each architecture defined their own datapage to store the >>> VDSO data. This stands in contrast to the generic nature of the VDSO >>>

Re: [PATCH v3 1/3] mm/pkey: Add PKEY_UNRESTRICTED macro

2024-11-05 Thread Michael Ellerman
Yury Khrustalev writes: > Memory protection keys (pkeys) uapi has two macros for pkeys restrictions: > > - PKEY_DISABLE_ACCESS 0x1 > - PKEY_DISABLE_WRITE 0x2 > > with implicit literal value of 0x0 that means "unrestricted". Code that > works with pkeys has to use this literal value when implyin

Re: [PATCH v3 08/18] powerpc/crc32: expose CRC32 functions through lib

2024-11-05 Thread Michael Ellerman
; create mode 100644 arch/powerpc/lib/crc32-glue.c > rename arch/powerpc/{crypto => lib}/crc32-vpmsum_core.S (100%) > rename arch/powerpc/{crypto => lib}/crc32c-vpmsum_asm.S (100%) Acked-by: Michael Ellerman (powerpc) ... > deleted file mode 100644 > index 63760b7dbb76..

Re: [PATCH 1/2] powerpc/fadump: allocate memory for additional parameters early

2024-11-05 Thread Michael Ellerman
> capture kernel") > Reported-by: Venkat Rao Bagalkote > Closes: > https://lore.kernel.org/lkml/a70e4064-a040-447b-8556-1fd02f193...@linux.vnet.ibm.com/T/#u > Cc: Mahesh Salgaonkar > Cc: Michael Ellerman > Signed-off-by: Hari Bathini > Signed-off-by: Sourabh Ja

Re: [PATCH v8 1/3] modules: Support extended MODVERSIONS info

2024-10-30 Thread Michael Ellerman
ew format. Other architectures do not appear to > have architecture-specific usage of this information. > > Reviewed-by: Sami Tolvanen > Signed-off-by: Matthew Maurer > --- > arch/powerpc/kernel/module_64.c | 24 ++- Acked-by: Michael Ellerman (powerpc) cheers

Re: [PATCH v7 1/3] modules: Support extended MODVERSIONS info

2024-10-29 Thread Michael Ellerman
Matthew Maurer writes: >> Sorry I realise it's version 7, but although the above looks correct it's >> kind of dense. >> >> I think the below would also work and is (I think) easier to follow, and >> is more obviously similar to the existing code. I'm sure your version is >> faster, but I don't th

Re: [PATCH v2] sched/membarrier: Fix redundant load of membarrier_state

2024-10-29 Thread Michael Ellerman
lwz r9,176(r26) # atomic_read(&mm->membarrier_state) > 1b7a74: b 1b78e0 Reviewed-by: Michael Ellerman cheers

Re: [PATCH] powerpc/powernv: Free name on error in opal_event_init()

2024-10-29 Thread Michael Ellerman
On Fri, 20 Sep 2024 19:35:20 +1000, Michael Ellerman wrote: > In opal_event_init() if request_irq() fails name is not freed, leading > to a memory leak. The code only runs at boot time, there's no way for a > user to trigger it, so there's no security impact. > > Fix th

Re: [PATCH v5 17/17] powerpc64/bpf: Add support for bpf trampolines

2024-10-27 Thread Michael Ellerman
Hari Bathini writes: > On 10/10/24 3:09 pm, Hari Bathini wrote: >> On 10/10/24 5:48 am, Michael Ellerman wrote: >>> Alexei Starovoitov writes: >>>> On Tue, Oct 1, 2024 at 12:18 AM Hari Bathini >>>> wrote: >>>>> On 30/09/24 6:25 pm, Al

Re: [PATCH net-next] net: freescale: use ethtool string helpers

2024-10-27 Thread Michael Ellerman
Rosen Penev writes: > On Fri, Oct 25, 2024 at 5:57 AM Simon Horman wrote: >> >> On Thu, Oct 24, 2024 at 01:52:57PM -0700, Rosen Penev wrote: >> > The latter is the preferred way to copy ethtool strings. >> > >> > Avoids manually incrementing the pointer. Cleans up the code quite well. >> > >> > S

Re: [PATCH v6 17/17] powerpc64/bpf: Add support for bpf trampolines

2024-10-27 Thread Michael Ellerman
Hari Bathini writes: > From: Naveen N Rao > > Add support for bpf_arch_text_poke() and arch_prepare_bpf_trampoline() > for 64-bit powerpc. While the code is generic, BPF trampolines are only > enabled on 64-bit powerpc. 32-bit powerpc will need testing and some > updates. Hi Hari, This is break

Re: [PATCH v7 1/3] modules: Support extended MODVERSIONS info

2024-10-25 Thread Michael Ellerman
Matthew Maurer writes: > Adds a new format for MODVERSIONS which stores each field in a separate > ELF section. This initially adds support for variable length names, but > could later be used to add additional fields to MODVERSIONS in a > backwards compatible way if needed. Any new fields will be

Re: [PATCH v2] KVM: PPC: Book3S HV: Mask off LPCR_MER for a vCPU before running it to avoid spurious interrupts

2024-10-24 Thread Michael Ellerman
Hi Gautam, A few comments below ... Gautam Menghani writes: > Mask off the LPCR_MER bit before running a vCPU to ensure that it is not > set if there are no pending interrupts. I would typically leave this until the end of the change log. ie. describe the bug and how it happens first, then the

Re: [PATCH] powerpc/xmon: symbol lookup length fixed

2024-10-24 Thread Michael Ellerman
Mukesh Kumar Chaurasiya writes: > On Thu, Oct 24, 2024 at 10:42:12AM +0530, Mukesh Kumar Chaurasiya wrote: >> On Thu, Oct 24, 2024 at 12:00:53PM +1100, Michael Ellerman wrote: >> > Mukesh Kumar Chaurasiya writes: >> > > Currently xmon cannot lookup symbol beyo

Re: [PATCH] sched/membarrier: Fix redundant load of membarrier_state

2024-10-24 Thread Michael Ellerman
[To += Mathieu] "Nysal Jan K.A." writes: > From: "Nysal Jan K.A" > > On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE > is not selected, sync_core_before_usermode() is a no-op. > In membarrier_mm_sync_core_before_usermode() the compiler does not > eliminate redundant branches and the lo

Re: [PATCH] powerpc/xmon: symbol lookup length fixed

2024-10-23 Thread Michael Ellerman
Mukesh Kumar Chaurasiya writes: > Currently xmon cannot lookup symbol beyond 64 characters in some cases. Can you mention which commands? It looks like it's "ls" and "lp". > Fix this by using KSYM_NAME_LEN instead of fixed 64 characters. > > Signed-off-by: Mukesh Kumar Chaurasiya > --- > arch/

Re: [PATCH 1/7] powerpc/entry: convert to common and generic entry

2024-10-22 Thread Michael Ellerman
"虞陆铭" writes: >>Le 12/10/2024 à 05:56, Luming Yu a écrit : >>> convert powerpc entry code in syscall and fault to use syscall_work >>> and irqentry_state as well as common calls implemented in generic >>> entry infrastructure. >>> >>> Signed-off-by: Luming Yu >>> --- >>> arch/powerpc/Kconfig

Re: [PATCH v3 01/12] powerpc: mm/fault: Fix kfence page fault reporting

2024-10-21 Thread Michael Ellerman
Hi Ritesh, "Ritesh Harjani (IBM)" writes: > copy_from_kernel_nofault() can be called when doing read of /proc/kcore. > /proc/kcore can have some unmapped kfence objects which when read via > copy_from_kernel_nofault() can cause page faults. Since *_nofault() > functions define their own fixup tab

Re: [PATCH v3 04/22] powerpc/cell: Switch to irq_get_nr_irqs()

2024-10-15 Thread Michael Ellerman
Bart Van Assche > --- > arch/powerpc/platforms/cell/axon_msi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Michael Ellerman (powerpc) cheers > diff --git a/arch/powerpc/platforms/cell/axon_msi.c > b/arch/powerpc/platforms/cell/axon_msi.c > inde

Re: [PATCH] powerpc/pseries/iommu: Wait until all TCEs are unmapped before deleting DDW

2024-10-14 Thread Michael Ellerman
Hi Gaurav, Gaurav Batra writes: > Some of the network drivers, like Mellanox, use core linux page_pool APIs > to manage DMA buffers. These page_pool APIs cache DMA buffers with > infrequent map/unmap calls for DMA mappings, thus increasing performance. Can you please resend this and Cc the netde

[PATCH v2] powerpc/64: Remove maple platform

2024-10-13 Thread Michael Ellerman
nux-fullhistory.git/commit/?id=f0d068d65c5e555ffcfbc189de32598f6f00770c Signed-off-by: Michael Ellerman --- Documentation/arch/powerpc/booting.rst | 4 +- arch/powerpc/Kconfig.debug | 6 - arch/powerpc/boot/.gitignore | 1 - arch/powerpc/boot/Makefile | 3 +- arch/powerpc/b

[GIT PULL] Please pull powerpc/linux.git powerpc-6.12-4 tag

2024-10-12 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Linus, Please pull another powerpc fix for 6.12: The following changes since commit 8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b: Linux 6.12-rc2 (2024-10-06 15:32:27 -0700) are available in the git repository at: https://git.kernel.org/pub/sc

Re: [PATCH] powerpc/8xx: Fix kernel DTLB miss on dcbz

2024-10-12 Thread Michael Ellerman
On Sat, 05 Oct 2024 10:53:29 +0200, Christophe Leroy wrote: > Following OOPS is encountered while loading test_bpf module > on powerpc 8xx: > > [ 218.835567] BUG: Unable to handle kernel data access on write at 0xcb00 > [ 218.842473] Faulting instruction address: 0xc0017a80 > [ 218.847451]

Re: [PATCH 2/2] powerpc/vdso: Implement __arch_get_vdso_rng_data()

2024-10-11 Thread Michael Ellerman
Christophe Leroy writes: > Le 10/10/2024 à 11:12, Thomas Weißschuh a écrit : >> On Thu, Oct 10, 2024 at 11:00:15AM +0200, Christophe Leroy wrote: >>> Hi Thomas, >>> >>> Le 10/10/2024 à 10:20, Thomas Weißschuh a écrit : On Wed, Oct 02, 2024 at 10:39:29AM +0200, Christophe Leroy wrote: > VD

Re: [PATCH 2/2] powerpc/vdso: Implement __arch_get_vdso_rng_data()

2024-10-11 Thread Michael Ellerman
"Jason A. Donenfeld" writes: > On Fri, Oct 04, 2024 at 04:03:34PM +0200, Jason A. Donenfeld wrote: >> On Fri, Oct 04, 2024 at 08:52:40PM +1000, Michael Ellerman wrote: >> > >> > >> > On October 4, 2024 2:33:54 AM GMT+10:00, "Jason A. Don

Re: drivers/nx: Invalid wait context issue when rebooting

2024-10-11 Thread Michael Ellerman
Vishal Chourasia writes: > Hi, > I am getting Invalid wait context warning printed when rebooting lpar > > kexec/61926 is trying to acquire `of_reconfig_chain.rwsem` while holding > spinlock `devdata_mutex` > > Note: Name of the spinlock is misleading. Oof, yeah let's rename that to devdata_spinl

Re: [RFC v2 0/4] cma: powerpc fadump fixes

2024-10-11 Thread Michael Ellerman
"Ritesh Harjani (IBM)" writes: > Please find the v2 of cma related powerpc fadump fixes. > > Patch-1 is a change in mm/cma.c to make sure we return an error if someone > uses > cma_init_reserved_mem() before the pageblock_order is initalized. > > I guess, it's best if Patch-1 goes via mm tree and

Re: [RFC] powerpc/kvm: Fix spinlock member access for PREEMPT_RT

2024-10-10 Thread Michael Ellerman
Paolo Bonzini writes: > On 10/10/24 20:09, Vishal Chourasia wrote: >> Hi, >> >> While building the kernel with CONFIG_PREEMPT_RT, I encountered several >> compilation errors in the PowerPC KVM code. The issues appear in >> book3s_hv_rm_mmu.c where it tries to access the 'rlock' member of struct >

Re: [PATCH v5 17/17] powerpc64/bpf: Add support for bpf trampolines

2024-10-09 Thread Michael Ellerman
Alexei Starovoitov writes: > On Tue, Oct 1, 2024 at 12:18 AM Hari Bathini wrote: >> On 30/09/24 6:25 pm, Alexei Starovoitov wrote: >> > On Sun, Sep 29, 2024 at 10:33 PM Hari Bathini >> > wrote: >> >> On 17/09/24 1:20 pm, Alexei Starovoitov wrote: >> >>> On Sun, Sep 15, 2024 at 10:58 PM Hari Bat

[PATCH] powerpc/boot: Remove bogus reference to lilo

2024-10-08 Thread Michael Ellerman
/113032940928131612 Signed-off-by: Michael Ellerman --- arch/powerpc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile index bbfe4a1f06ef..d115834817db 100644 --- a/arch/powerpc/Makefile +++ b/arch/powerpc/Makefile @@ -359,7 +359,7 @@ define

[PATCH 2/2] powerpc/machdep: Drop include of dma-mapping.h

2024-10-08 Thread Michael Ellerman
machdep.h. Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/machdep.h | 6 +- arch/powerpc/kernel/sysfs.c | 1 + arch/powerpc/platforms/pseries/svm.c | 1 + drivers/cpuidle/cpuidle-pseries.c| 1 + 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/arch

[PATCH 1/2] powerpc/machdep: Drop include of seq_file.h

2024-10-08 Thread Michael Ellerman
Drop the include of seq_file.h in machdep.h, replace it with a forward declaration of struct seq_file, which is all that's required. Add direct includes of seq_file.h to some files that were getting seq_file.h via machdep.h. Signed-off-by: Michael Ellerman --- arch/powerpc/includ

[PATCH] powerpc/64: Drop IPI_PRIORITY from asm-offsets

2024-10-08 Thread Michael Ellerman
The last use of IPI_PRIORITY in asm was removed in commit 37f55d30df2e ("KVM: PPC: Book3S HV: Convert kvmppc_read_intr to a C function"). Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/asm-offsets.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kernel/asm-of

Re: [PATCH] powermac: Call of_node_put(bk_node) only once in pmac_has_backlight_type()

2024-10-08 Thread Michael Ellerman
Christophe Leroy writes: > Le 02/10/2024 à 22:02, Markus Elfring a écrit : >> From: Markus Elfring >> Date: Wed, 2 Oct 2024 21:50:27 +0200 >> >> An of_node_put(bk_node) call was immediately used after a pointer check >> for an of_get_property() call in this function implementation. >> Thus call

Re: [RFC PATCH] powerpc/vdso: Should VDSO64 functions be flagged as functions like VDSO32 ?

2024-10-08 Thread Michael Ellerman
Christophe Leroy writes: > Hi Michael, > > Le 18/09/2024 à 04:33, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> On powerpc64 as shown below by readelf, vDSO functions symbols have >>> type NOTYPE. >>> >>> $ powerpc64-linux-gn

[GIT PULL] Please pull powerpc/linux.git powerpc-6.12-3 tag

2024-10-06 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Linus, Please pull some more powerpc fixes for 6.12: The following changes since commit 9852d85ec9d492ebef56dc5f229416c925758edc: Linux 6.12-rc1 (2024-09-29 15:06:19 -0700) are available in the git repository at: https://git.kernel.org/pu

Re: [PATCH 2/2] powerpc/vdso: Implement __arch_get_vdso_rng_data()

2024-10-04 Thread Michael Ellerman
On October 4, 2024 2:33:54 AM GMT+10:00, "Jason A. Donenfeld" wrote: >Hey Christophe, Michael, > >This series actually looks pretty okay to me. I realize ThomasW is >working on more generic cleanups that might obliterate the need for >this, and that may or may not wind up in 6.13. But, I was t

Re: [PATCH] powerpc/vdso: allow r30 in vDSO code generation of getrandom

2024-09-30 Thread Michael Ellerman
On Wed, 25 Sep 2024 19:50:22 +0200, Jason A. Donenfeld wrote: > For gettimeofday, -ffixed-r30 was passed to work around a bug in Go > code, where the vDSO trampoline forgot to save and restore this register > across function calls. But Go requires a different trampoline for every > call, and there'

Re: Are 256K page sizes really a thing (on ppc64le in particular)?

2024-09-29 Thread Michael Ellerman
LEROY Christophe writes: > Le 28/09/2024 à 18:08, Florian Weimer a écrit : >> I'm working on adding a header to glibc, so that >> programmers can easily determine the range of possible page sizes for a >> particular target, for things like pointer tagging and mapped file >> alignment requirement

[GIT PULL] Please pull powerpc/linux.git powerpc-6.12-2 tag

2024-09-25 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Linus, Please pull a couple of powerpc fixes for 6.12: The following changes since commit 3a7101e9b27fe97240c2fd430c71e61262447dd1: Merge tag 'powerpc-6.12-1' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux (2024-09-19 08:03:

[PATCH] powerpc/powernv: Free name on error in opal_event_init()

2024-09-20 Thread Michael Ellerman
q.com> Closes: https://lore.kernel.org/linuxppc-dev/87wmjp3wig.fsf@mail.lhotse Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/powernv/opal-irqchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/powernv/opal-irqchip.c b/arch/powerpc/platforms/powernv/opal

Re: [PATCH] powerpc/vdso32: Fix use of crtsavres for PPC64

2024-09-20 Thread Michael Ellerman
On Thu, 19 Sep 2024 20:55:57 +0200, Christophe Leroy wrote: > crtsavres.S content is encloded by a #ifndef CONFIG_PPC64 > > To be used on VDSO32 on PPC64 it's content must available on PPC64 as > well. > > Replace #ifndef CONFIG_PPC64 by #ifndef __powerpc64__ as __powerpc64__ > is not set when bu

Re: [PATCH] powerpc/pseries/eeh: move pseries_eeh_err_inject() outside CONFIG_DEBUG_FS block

2024-09-20 Thread Michael Ellerman
On Tue, 17 Sep 2024 09:24:45 -0400, Narayana Murty N wrote: > Makes pseries_eeh_err_inject() available even when debugfs > is disabled (CONFIG_DEBUG_FS=n). It moves eeh_debugfs_break_device() > and eeh_pe_inject_mmio_error() out of the CONFIG_DEBUG_FS block > and renames it as eeh_break_device(). >

Re: [PATCH RFC v3 1/2] mm: Add personality flag to limit address to 47 bits

2024-09-19 Thread Michael Ellerman
Charlie Jenkins writes: > On Wed, Sep 11, 2024 at 11:38:55PM +1000, Michael Ellerman wrote: >> Geert Uytterhoeven writes: >> > Hi Christophe, >> > >> > On Tue, Sep 10, 2024 at 11:21 AM Christophe Leroy >> > wrote: >> >> >>> diff

Re: [PATCH] powerpc/perf: Use guard(irqsave)() in eight functions

2024-09-19 Thread Michael Ellerman
Markus Elfring writes: > From: Markus Elfring > Date: Mon, 16 Sep 2024 19:25:00 +0200 > > Scope-based resource management became supported for some > programming interfaces by contributions of Peter Zijlstra on 2023-05-26. > See also the commit 54da6a0924311c7cf5015533991e44fb8eb12773 ("locking:

Re: [FSL P50x0] [GIT KERNEL] [VDSO] compiling issue

2024-09-19 Thread Michael Ellerman
Christian Zigotzky writes: > Hi All, > > The compiling of the latest Git kernel doesn’t work anymore for our FSL > P5020/P5040 boards [1] since the random-6.12-rc1 updates [2]. > > Error messages: > > arch/powerpc/kernel/vdso/vdso32.so.dbg: dynamic relocations are not supported > > make[2]: *** [

Re: [RFC PATCH] powerpc/tlb: enable arch want batched unmap tlb flush

2024-09-19 Thread Michael Ellerman
Luming Yu writes: > On Thu, Sep 19, 2024 at 01:22:21PM +1000, Michael Ellerman wrote: >> Luming Yu writes: >> > From: Yu Luming >> > >> > ppc always do its own tracking for batch tlb. >> >> I don't think it does? :) >> >> I

Re: [PATCH] powerpc/atomic: Use YZ constraints for DS-form instructions

2024-09-19 Thread Michael Ellerman
Segher Boessenkool writes: > Hi! > > On Mon, Sep 16, 2024 at 10:05:10PM +1000, Michael Ellerman wrote: >> The 'ld' and 'std' instructions require a 4-byte aligned displacement >> because they are DS-form instructions. But the "m" asm constrai

Re: [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.

2024-09-18 Thread Michael Ellerman
Danny Tsen writes: > Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the > subsequent patches to fix data mismatch over ipsec tunnel. This change log needs to stand on its own. ie. it needs to explain what the problem is and why the feature is being disabled, without reference t

Re: [PATCH v2] crash, powerpc: Default to CRASH_DUMP=n on PPC_BOOK3S_32

2024-09-18 Thread Michael Ellerman
3 +++ > arch/powerpc/Kconfig | 4 > arch/riscv/Kconfig | 3 +++ > arch/s390/Kconfig | 3 +++ > arch/sh/Kconfig| 3 +++ > arch/x86/Kconfig | 3 +++ > kernel/Kconfig.kexec | 2 +- > 10 files changed, 29 insertions(+), 1 deletion(-) Acked-by: Michael Ellerman (powerpc) cheers

Re: [RFC PATCH] powerpc/tlb: enable arch want batched unmap tlb flush

2024-09-18 Thread Michael Ellerman
Luming Yu writes: > From: Yu Luming > > ppc always do its own tracking for batch tlb. I don't think it does? :) I think you're referring to the batch handling in arch/powerpc/include/asm/book3s/64/tlbflush-hash.h ? But that's only used for 64-bit Book3S with the HPT MMU. > By trivially enabl

[GIT PULL] Please pull powerpc/linux.git powerpc-6.12-1 tag

2024-09-18 Thread Michael Ellerman
Constify struct kobj_type Jinjie Ruan (1): powerpc: Remove useless config comment in asm/percpu.h Madhavan Srinivasan (2): powerpc/xmon: Fix tmpstr length check in scanhex selftests/powerpc: Allow building without static libc Michael Ellerman (13): MAINTAINERS: Mark

Re: [RFC PATCH] powerpc/vdso: Should VDSO64 functions be flagged as functions like VDSO32 ?

2024-09-17 Thread Michael Ellerman
Christophe Leroy writes: > On powerpc64 as shown below by readelf, vDSO functions symbols have > type NOTYPE. > > $ powerpc64-linux-gnu-readelf -a arch/powerpc/kernel/vdso/vdso64.so.dbg > ELF Header: > Magic: 7f 45 4c 46 02 02 01 00 00 00 00 00 00 00 00 00 > Class:

Re: [PATCH] powerpc/atomic: Use YZ constraints for DS-form instructions

2024-09-17 Thread Michael Ellerman
On Mon, 16 Sep 2024 22:05:10 +1000, Michael Ellerman wrote: > The 'ld' and 'std' instructions require a 4-byte aligned displacement > because they are DS-form instructions. But the "m" asm constraint > doesn't enforce that. > > That can lead to

Re: [PATCH] MAINTAINERS: powerpc: Add Maddy

2024-09-17 Thread Michael Ellerman
On Tue, 27 Aug 2024 16:36:51 +1000, Michael Ellerman wrote: > Maddy will be helping out with upstream maintenance, add him as a > reviewer. > > Applied to powerpc/next. [1/1] MAINTAINERS: powerpc: Add Maddy https://git.kernel.org/powerpc/c/b77d36bb9a3de774950ba712a0e47f9d33c6f6d7 cheers

Re: [PATCH] powerpc/atomic: Use YZ constraints for DS-form instructions

2024-09-16 Thread Michael Ellerman
Mina Almasry writes: > On Mon, Sep 16, 2024 at 5:05 AM Michael Ellerman wrote: >> >> The 'ld' and 'std' instructions require a 4-byte aligned displacement >> because they are DS-form instructions. But the "m" asm constraint >> doesn&#

[PATCH] powerpc/atomic: Use YZ constraints for DS-form instructions

2024-09-16 Thread Michael Ellerman
s. Fixes: 9f0cbea0d8cc ("[POWERPC] Implement atomic{, 64}_{read, write}() without volatile") Cc: sta...@vger.kernel.org # v2.6.24+ Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/all/20240913125302.0a06b...@canb.auug.org.au Signed-off-by: Michael Ellerman --- arch/po

Re: [PATCH net-next v2] page_pool: fix build on powerpc with GCC 14

2024-09-15 Thread Michael Ellerman
Christophe Leroy writes: > Le 14/09/2024 à 04:02, Michael Ellerman a écrit : ... >> >> diff --git a/arch/powerpc/include/asm/atomic.h >> b/arch/powerpc/include/asm/atomic.h >> index 5bf6a4d49268..0e41c1da82dd 100644 >> --- a/arch/powerpc/include/asm/atomic.h

Re: [PATCH net-next v2] page_pool: fix build on powerpc with GCC 14

2024-09-13 Thread Michael Ellerman
Mina Almasry writes: > Building net-next with powerpc with GCC 14 compiler results in this > build error: > > /home/sfr/next/tmp/ccuSzwiR.s: Assembler messages: > /home/sfr/next/tmp/ccuSzwiR.s:2579: Error: operand out of domain (39 is > not a multiple of 4) > make[5]: *** [/home/sfr/next/next/scri

Re: [PATCH] of: address: Unify resource bounds overflow checking

2024-09-13 Thread Michael Ellerman
Rob Herring writes: > On Fri, Sep 13, 2024 at 8:15 AM Michael Ellerman wrote: >> Thomas Weißschuh writes: >> > The members "start" and "end" of struct resource are of type >> > "resource_size_t" which can be 32bit wide. >> > Val

Re: [PATCH] of: address: Unify resource bounds overflow checking

2024-09-13 Thread Michael Ellerman
Thomas Weißschuh writes: > The members "start" and "end" of struct resource are of type > "resource_size_t" which can be 32bit wide. > Values read from OF however are always 64bit wide. > > Refactor the diff overflow checks into a helper function. > Also extend the checks to validate each calculat

Re: [PATCH 1/1] crypto: Fix data mismatch over ipsec tunnel encrypted/decrypted with ppc64le AES/GCM module.

2024-09-12 Thread Michael Ellerman
Danny Tsen writes: > This patch is to fix an issue when simd is not usable that data mismatch > may occur over ipsec tunnel. The fix is to register algs as SIMD modules > so that the algorithm is excecuted when SIMD instructions is usable. > > A new module rfc4106(gcm(aes)) is also added. Re-write

Re: [PATCH] powerpc: Switch back to struct platform_driver::remove()

2024-09-12 Thread Michael Ellerman
On Mon, 09 Sep 2024 15:09:02 +0200, Uwe Kleine-König wrote: > After commit 0edb555a65d1 ("platform: Make platform_driver::remove() > return void") .remove() is (again) the right callback to implement for > platform drivers. > > Convert all pwm drivers to use .remove(), with the eventual goal to dr

Re: [PATCH v3] powerpc/pseries/eeh: Fix pseries_eeh_err_inject

2024-09-12 Thread Michael Ellerman
On Mon, 09 Sep 2024 09:02:20 -0500, Narayana Murty N wrote: > VFIO_EEH_PE_INJECT_ERR ioctl is currently failing on pseries > due to missing implementation of err_inject eeh_ops for pseries. > This patch implements pseries_eeh_err_inject in eeh_ops/pseries > eeh_ops. Implements support for injecting

Re: [PATCH v2] selftest/powerpc/benchmark: remove requirement libc-dev

2024-09-12 Thread Michael Ellerman
On Mon, 12 Aug 2024 15:11:52 +0530, Madhavan Srinivasan wrote: > Currently exec-target.c file is linked as static and this > post a requirement to install libc dev package to build. > Without it, build-break when compiling selftest/powerpc/benchmark. > > CC exec_target > /usr/bin/ld: canno

Re: [PowerPC][linux-next-6.11-rc7-20240910] Kernel Warnings at kernel/jump_label.c:266

2024-09-11 Thread Michael Ellerman
Venkat Rao Bagalkote writes: > Greetings!!! > > I am observing kernel warnings while booting with > linux-next-6.11-rc7-20240910 kernel. Below are the warnings. > > [   63.613506] WARNING: CPU: 20 PID: 214 at kernel/jump_label.c:266 > static_key_dec+0x78/0x8c > [   63.613518] Modules linked in: e

Re: [PATCH RFC v3 1/2] mm: Add personality flag to limit address to 47 bits

2024-09-11 Thread Michael Ellerman
"Arnd Bergmann" writes: > On Mon, Sep 9, 2024, at 23:22, Charlie Jenkins wrote: >> On Fri, Sep 06, 2024 at 10:52:34AM +0100, Lorenzo Stoakes wrote: >>> On Fri, Sep 06, 2024 at 09:14:08AM GMT, Arnd Bergmann wrote: >>> The intent is to optionally be able to run a process that keeps higher bits >>> f

Re: [PATCH RFC v3 1/2] mm: Add personality flag to limit address to 47 bits

2024-09-11 Thread Michael Ellerman
Geert Uytterhoeven writes: > Hi Christophe, > > On Tue, Sep 10, 2024 at 11:21 AM Christophe Leroy > wrote: >> >>> diff --git a/include/uapi/linux/personality.h >> >>> b/include/uapi/linux/personality.h >> >>> index 49796b7756af..cd3b8c154d9b 100644 >> >>> --- a/include/uapi/linux/personality.h >

Re: [PATCH RFC v3 1/2] mm: Add personality flag to limit address to 47 bits

2024-09-11 Thread Michael Ellerman
Charlie Jenkins writes: > On Fri, Sep 06, 2024 at 04:59:40PM +1000, Michael Ellerman wrote: >> Charlie Jenkins writes: >> > Create a personality flag ADDR_LIMIT_47BIT to support applications >> > that wish to transition from running in environments that support

Re: [PATCH v2] powerpc/pseries/eeh: Fix pseries_eeh_err_inject

2024-09-10 Thread Michael Ellerman
Narayana Murty N writes: > On 05/09/24 6:33 PM, Michael Ellerman wrote: >> Narayana Murty N writes: >>> VFIO_EEH_PE_INJECT_ERR ioctl is currently failing on pseries >>> due to missing implementation of err_inject eeh_ops for pseries. >>> This patch implemen

Re: [PATCH] powerpc/ftrace: restore r2 to caller's stack on livepatch sibling call

2024-09-10 Thread Michael Ellerman
"Ryan B. Sullivan" writes: > Hello all, > > Just wanted to ping and see if there was any further feedback or > questions regarding the patch? Hi Ryan, I'd really like a selftest that triggers the sibling call behaviour. As I said upthread I tried writing one but failed. Which you later explaine

Re: [PATCH -next,v2] MIPS: Remove the obsoleted code for include/linux/mv643xx.h

2024-09-09 Thread Michael Ellerman
Gaosheng Cui writes: > Most of the drivers which used this header have been deleted, most > of these code is obsoleted, move the only defines that are actually > used into arch/powerpc/platforms/chrp/pegasos_eth.c and delete the > file completely. > > Signed-off-by: Gaosheng Cui > --- > v2: Delet

Re: [PATCH v4 RESEND] powerpc: Replace kretprobe code with rethook on powerpc

2024-09-08 Thread Michael Ellerman
Masami Hiramatsu (Google) writes: > On Fri, 06 Sep 2024 21:52:52 +1000 > Michael Ellerman wrote: > >> On Fri, 30 Aug 2024 07:31:31 -0400, Abhishek Dubey wrote: >> > This is an adaptation of commit f3a112c0c40d ("x86,rethook,kprobes: >> > Replace kret

Re: [PATCH] crash: Default to CRASH_DUMP=n when support for it is unlikely

2024-09-08 Thread Michael Ellerman
Dave Vasilevsky writes: > I received a notification from Patchwork that my patch is now in the > state "Handled Elsewhere".[0] Does that mean someone merged it > somewhere? Or that I should be using a different mailing list? Or > something else? > > I'd appreciate some guidance. It was sent/Cc'ed

Re: [PATCH] powerpc/xive: Use cpumask_intersects()

2024-09-08 Thread Michael Ellerman
Costa Shulyupin writes: > Replace `cpumask_any_and(a, b) >= nr_cpu_ids` > with the more readable `!cpumask_intersects(a, b)`. I agree it's more readable. It would be nice if the change log told me that both functions have similar performance behaviour. I'm not saying this is a super hot path, bu

Re: [PATCH 1/2] powerpc/vdso: Fix VDSO data access when running in a non-root time namespace

2024-09-08 Thread Michael Ellerman
"Jason A. Donenfeld" writes: > On Fri, Sep 06, 2024 at 03:43:17PM +0200, Jason A. Donenfeld wrote: >> On Fri, Sep 06, 2024 at 10:23:08PM +1000, Michael Ellerman wrote: >> > Christophe Leroy writes: >> > > When running in a non-root time namespace, the glo

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.11-3 tag

2024-09-06 Thread Michael Ellerman
Linus Torvalds writes: > On Fri, 6 Sept 2024 at 05:08, Michael Ellerman wrote: >> >> Please pull some more powerpc fixes for 6.11: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git >> tags/powerpc-6.11-3 > > Hmm. New pgp key? Ple

Re: [PATCH 1/2] powerpc/vdso: Fix VDSO data access when running in a non-root time namespace

2024-09-06 Thread Michael Ellerman
Christophe Leroy writes: > When running in a non-root time namespace, the global VDSO data page > is replaced by a dedicated namespace data page and the global data > page is mapped next to it. Detailed explanations can be found at > commit 660fd04f9317 ("lib/vdso: Prepare for time namespace suppo

[GIT PULL] Please pull powerpc/linux.git powerpc-6.11-3 tag

2024-09-06 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Linus, Please pull some more powerpc fixes for 6.11: The following changes since commit 227bbaabe64b6f9cd98aa051454c1d4a194a8c6a: powerpc/topology: Check if a core is online (2024-08-13 10:32:17 +1000) are available in the git repository at:

Re: [PATCH] KVM: PPC: remove unused varible

2024-09-06 Thread Michael Ellerman
On Fri, 16 Aug 2024 17:33:12 +0800, al...@kernel.org wrote: > During build testing, we found a error: > /arch/powerpc/kvm/book3s_hv.c:4052:17: error: variable 'loops' set but not > used [-Werror,-Wunused-but-set-variable] > unsigned long loops = 0; > 1 error generated. > > Remove

Re: [PATCH] powerpc/configs/64s: Enable DEFERRED_STRUCT_PAGE_INIT

2024-09-06 Thread Michael Ellerman
On Tue, 20 Aug 2024 16:57:05 +1000, Michael Ellerman wrote: > It can speed up initialisation of page structs at boot on large > machines. > > Applied to powerpc/next. [1/1] powerpc/configs/64s: Enable DEFERRED_STRUCT_PAGE_INIT https://git.kernel.o

Re: [PATCH] powerpc/64s/mm: Move __real_pte stubs into hash-4k.h

2024-09-06 Thread Michael Ellerman
On Wed, 21 Aug 2024 18:07:29 +1000, Michael Ellerman wrote: > The stub versions of __real_pte() etc are only used with HPT & 4K pages, > so move them into the hash-4k.h header. > > Applied to powerpc/next. [1/1] powerpc/64s/mm: Move __real_pte stubs into hash-4k.h https:

Re: [PATCH 0/2] Use helper function for_each_child_of_node()

2024-09-06 Thread Michael Ellerman
On Thu, 22 Aug 2024 16:54:28 +0800, Zhang Zekun wrote: > Use for_each_child_of_node() to iterate through the device_node, this > can make code more simple. > > Zhang Zekun (2): > powerpc/powermac/pfunc_base: Use helper function > for_each_child_of_node() > powerpc/pseries/dlpar: Use helper

Re: [PATCH] powerpc: Stop using no_llseek

2024-09-06 Thread Michael Ellerman
On Tue, 03 Sep 2024 21:19:51 +1000, Michael Ellerman wrote: > Since commit 868941b14441 ("fs: remove no_llseek"), no_llseek() is > simply defined to be NULL, and a NULL llseek means seeking is > unsupported. > > So for statically defined file_operations, such as all th

Re: [PATCH] powerpc/64s: Remove the "fast endian switch" syscall

2024-09-06 Thread Michael Ellerman
On Fri, 23 Aug 2024 17:08:30 +1000, Michael Ellerman wrote: > The non-standard "fast endian switch" syscall was added in 2008[1], > but was never widely used. It was disabled by default in 2017[2], and > there's no evidence it's ever been used since. > > Remov

Re: [PATCH] powerpc/64s: Make mmu_hash_ops __ro_after_init

2024-09-06 Thread Michael Ellerman
On Wed, 21 Aug 2024 18:07:45 +1000, Michael Ellerman wrote: > The mmu_hash_ops are only assigned to during boot, so mark them > __ro_after_init to prevent any further modification. > > Applied to powerpc/next. [1/1] powerpc/64s: Make mmu_hash_ops __ro_after_init https://gi

Re: [PATCH] macintosh/via-pmu: register_pmu_pm_ops() can be __init

2024-09-06 Thread Michael Ellerman
On Wed, 21 Aug 2024 18:21:01 +1000, Michael Ellerman wrote: > register_pmu_pm_ops() is only called at init time, via > device_initcall(), so can be marked __init. The driver can't be built as > a module. > > Applied to powerpc/next. [1/1] macintosh/via-pmu: register_pmu_pm

Re: [PATCH 1/2] powerpc/mm/64s: Move THP reqs into a separate symbol

2024-09-06 Thread Michael Ellerman
On Fri, 23 Aug 2024 13:29:10 +1000, Michael Ellerman wrote: > Move the Kconfig symbols related to transparent hugepages (THP) under a > separate config symbol, separate from CONFIG_PPC_BOOK3S_64. > > The new symbol is automatically enabled if CONFIG_PPC_BOOK3S_64 is > enabled,

Re: [PATCH v3] powerpc/xmon: Fix tmpstr length check in scanhex

2024-09-06 Thread Michael Ellerman
On Mon, 26 Aug 2024 12:12:17 +0530, Madhavan Srinivasan wrote: > If a function name is greater than 63 char long, xmon command > may not find them. For example, here is a test that > executed an illegal instruction in a kernel function and one of > call stack function has name >63 char long, > > c

Re: [PATCH -next 1/3] powerpc: Constify struct kobj_type

2024-09-06 Thread Michael Ellerman
On Mon, 26 Aug 2024 23:09:55 +0800, Huang Xiaojia wrote: > 'struct kobj_type' is not modified. It is only used in > kobject_init_and_add()/kobject_init() which takes > a 'const struct kobj_type *ktype' parameter. > > Constifying this structure moves some data to a read-only section, > so increase

Re: [PATCH v3 1/3] powerpc/pseries: Use correct data types from pseries_hp_errorlog struct

2024-09-06 Thread Michael Ellerman
On Wed, 21 Aug 2024 19:50:26 -0700, Haren Myneni wrote: > _be32 type is defined for some elements in pseries_hp_errorlog > struct but also used them u32 after be32_to_cpu() conversion. > > Example: In handle_dlpar_errorlog() > hp_elog->_drc_u.drc_index = be32_to_cpu(hp_elog->_drc_u.drc_index); >

Re: [PATCH -next] powerpc/powernv/pci: Remove obsoleted declaration for pnv_pci_init_ioda_hub

2024-09-06 Thread Michael Ellerman
On Thu, 22 Aug 2024 21:00:43 +0800, Gaosheng Cui wrote: > The pnv_pci_init_ioda_hub() have been removed since > commit 5ac129cdb50b ("powerpc/powernv/pci: Remove ioda1 support"), > and now it is useless, so remove it. > > Applied to powerpc/next. [1/1] powerpc/powernv/pci: Remove obsoleted decl

Re: [PATCH -next 0/4] Remove obsoleted declaration for powerpc

2024-09-06 Thread Michael Ellerman
On Thu, 22 Aug 2024 21:06:05 +0800, Gaosheng Cui wrote: > Remove obsoleted declaration for powerpc, thanks! > > Gaosheng Cui (4): > powerpc: Remove obsoleted declaration for _get_SP > powerpc: Remove obsoleted declaration for maple_calibrate_decr > powerpc: Remove obsoleted declaration for p

  1   2   3   4   5   6   7   8   9   10   >