ce code to the position
> where it is really needed.
>
> Signed-off-by: Joonsoo Kim
Acked-by: Michal Nazarewicz
>
> diff --git a/arch/powerpc/kvm/book3s_hv_builtin.c
> b/arch/powerpc/kvm/book3s_hv_builtin.c
> index 28ec226..97613ea 100644
> --- a/arch/powerpc/kvm/book3s
On Thu, Jun 12 2014, Joonsoo Kim wrote:
> We can remove one call sites for clear_cma_bitmap() if we first
> call it before checking error number.
>
> Signed-off-by: Joonsoo Kim
Reviewed-by: Michal Nazarewicz
> diff --git a/mm/cma.c b/mm/cma.c
> index 1e1b017..01a0713 10064
arbitrary bitmap granularity for following generalization.
>
> Signed-off-by: Joonsoo Kim
Acked-by: Michal Nazarewicz
> diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c
> index bc4c171..9bc9340 100644
> --- a/drivers/base/dma-contiguous.c
> +++ b/drivers/bas
big issue.
> cma region. So support it to prepare generalization of cma area
> management functionality.
>
> Additionally, add some comments which tell us why alignment
> constraint is needed on cma region.
>
> Signed-off-by: Joonsoo Kim
Acked-by: Michal Nazarewicz
> di
lity in following patches.
> This separation helps us not to touch DMA APIs while extending
> core functions.
>
> Signed-off-by: Joonsoo Kim
Acked-by: Michal Nazarewicz
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of
On Thu, Jun 12 2014, Michal Nazarewicz wrote:
> I used “function(arg1, arg2, …)” at the *beginning* of functions when
> the arguments passed to the function were included in the message. In
> all other cases I left it at just “function:” (or just no additional
> prefix). IMO that&#x
Joonsoo Kim
Reviewed-by: Michal Nazarewicz
> diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c
> index bd0bb81..fb0cdce 100644
> --- a/drivers/base/dma-contiguous.c
> +++ b/drivers/base/dma-contiguous.c
> @@ -177,14 +177,24 @@ static int
print function name consistently.
>
> Lastly, I add one more debug log on cma_activate_area().
I don't particularly care what format of logs you choose, so:
Acked-by: Michal Nazarewicz
even though I'd go without empty “()”.
> Signed-off-by: Joonsoo Kim
>
> diff
>> Joonsoo Kim writes:
>>
>> > We don't need explicit 'CMA:' prefix, since we already define prefix
>> > 'cma:' in pr_fmt. So remove it.
>> >
>> > And, some logs print function name and others doesn't. This looks
>> > bad to me, so I unify log format to print function name consistently.
>> >
>> >
On Tue, Jun 10 2014, Joonsoo Kim wrote:
> Without including device.h, build failure occurs.
> In dma-contiguous.h, we try to access to dev->cma_area, so we need
> device.h. In the past, we included it luckily by swap.h in
> drivers/base/dma-contiguous.c. Swap.h includes node.h and then node.h
> in
On Tue, Jun 03 2014, Joonsoo Kim wrote:
> Now, we have general CMA reserved area management framework,
> so use it for future maintainabilty. There is no functional change.
>
> Signed-off-by: Joonsoo Kim
Acked-by: Michal Nazarewicz
--
On Tue, Jun 03 2014, Joonsoo Kim wrote:
> Now, we have general CMA reserved area management framework,
> so use it for future maintainabilty. There is no functional change.
>
> Signed-off-by: Joonsoo Kim
Acked-by: Michal Nazarewicz
> diff --git a/include/linux/dma-contiguous.h
a management code.
>
> Signed-off-by: Joonsoo Kim
Some small comments below, but in general
Acked-by: Michal Nazarewicz
>
> diff --git a/include/linux/cma.h b/include/linux/cma.h
> new file mode 100644
> index 000..60ba06f
> --- /dev/null
> +++ b/inclu
requiring DMA contiguous.
>
> Signed-off-by: Aneesh Kumar K.V
Acked-by: Michal Nazarewicz
> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index 07abd9d..74b7c98 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -202,11 +202,10 @@ config DMA_SHAR
On 06/26/2012 09:27 AM, Alexandre Pereira da Silva wrote:
Grab the devicetree node properties to override VendorId, ProductId,
bcdDevice, Manucacturer, Product and SerialNumber
Like before, the code looks good to me:
Acked-by: Michal Nazarewicz
Not commenting on the other aspects of the
On Tue, 03 Jan 2012 15:19:04 +0100, Gilad Ben-Yossef
wrote:
on_each_cpu() returns as its own return value the return value of
smp_call_function(). smp_call_function() in turn returns a hard
coded value of zero.
Some callers to on_each_cpu() waste cycles and bloat code space
by checking the ret
: Michal Nazarewicz
@@ -877,7 +877,7 @@ fsl_ep_queue(struct usb_ep *_ep, struct usb_request *_req,
gfp_t gfp_flags)
VDBG("%s, bad ep", __func__);
return -EINVAL;
}
- if (ep->desc->bmAttributes == USB_ENDPOINT_XFER_ISOC) {
+ if (usb_en
>bmAttributes == USB_ENDPOINT_XFER_ISOC) {
+ if (ep->desc->bmAttributes & USB_ENDPOINT_XFER_ISOC) {
On Tue, 22 Nov 2011 02:22:10 +0100, Michal Nazarewicz wrote:
What you really meant is:
(ep->desc->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) == USB_ENDPOINT_XFER_ISOC
It would probably
On Tue, 22 Nov 2011 02:15:21 +0100, Peter Chen wrote:
Some ISO gadgets, like audio, has SYNC attribute as well as
USB_ENDPOINT_XFER_ISOC for their bmAttributes at ISO endpoint
descriptor. So, it needs to use & instead of == to judge if
it is ISO XFER.
Signed-off-by: Peter Chen
---
drivers/us
19 matches
Mail list logo
