Re: [PATCH 1/2] powerpc/sstep: Unexport analyze_instr, emulate_vsx_load, emulate_vsx_store

2024-10-01 Thread Michal Suchánek
On Tue, Oct 01, 2024 at 02:08:18PM +0200, Christophe Leroy wrote: > > > Le 01/10/2024 à 12:08, Michal Suchanek a écrit : > > There is no modular user of analyze_instr, and the latter two are only > > used by sstep itself. > > analyze_instr() is used in arch/powerpc/kvm/emulate_loadstore.c which

Re: [PATCH v5 00/11] KVM: PPC: Nested APIv2 guest support

2024-09-26 Thread Michal Suchánek
On Thu, Sep 26, 2024 at 10:53:45AM +0530, Vaibhav Jain wrote: > Hi Michal, > > Michal Suchánek writes: > > > > > Hello, > > > > are there any machines on which this is supposed to work? > > > > On a 9105-22A with ML1050_fw1050.20 (78) and >

Re: [PATCH v5 00/11] KVM: PPC: Nested APIv2 guest support

2024-09-25 Thread Michal Suchánek
On Thu, Sep 14, 2023 at 01:05:49PM +1000, Jordan Niethe wrote: > > A nested-HV API for PAPR has been developed based on the KVM-specific > nested-HV API that is upstream in Linux/KVM and QEMU. The PAPR API had > to break compatibility to accommodate implementation in other > hypervisors and partit

Re: [PATCH v5 3/4] arm64: topology: Support SMT control on ACPI based system

2024-09-12 Thread Michal Suchánek
Hello, On Thu, Sep 12, 2024 at 01:59:16PM +0200, Morten Rasmussen wrote: > On Fri, Sep 06, 2024 at 04:36:30PM +0800, Yicong Yang wrote: > > On 2024/9/6 15:06, Morten Rasmussen wrote: > > > Hi Yicong, > > > > > > On Thu, Sep 05, 2024 at 08:02:20PM +0800, Yicong Yang wrote: > > >> On 2024/9/5 16:34

Re: [PATCH v2 2/2] powerpc/pseries: Add failure related checks for h_get_mpp and h_get_ppp

2024-08-15 Thread Michal Suchánek
On Fri, Apr 12, 2024 at 02:50:47PM +0530, Shrikanth Hegde wrote: > Couple of Minor fixes: > > - hcall return values are long. Fix that for h_get_mpp, h_get_ppp and > parse_ppp_data > > - If hcall fails, values set should be at-least zero. It shouldn't be > uninitialized values. Fix that for h_get

Re: [PATCH] powerpc/pseries: Fix scv instruction crash with kexec

2024-07-09 Thread Michal Suchánek
On Tue, Jul 09, 2024 at 11:03:10PM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > Hello, > > > > On Tue, Jun 25, 2024 at 11:40:47PM +1000, Nicholas Piggin wrote: > >> kexec on pseries disables AIL (reloc_on_exc), required for scv > >> instructi

Re: [PATCH] powerpc/pseries: Fix scv instruction crash with kexec

2024-07-09 Thread Michal Suchánek
Hello, On Tue, Jun 25, 2024 at 11:40:47PM +1000, Nicholas Piggin wrote: > kexec on pseries disables AIL (reloc_on_exc), required for scv > instruction support, before other CPUs have been shut down. This means > they can execute scv instructions after AIL is disabled, which causes an > interrupt a

Re: [PATCH 0/2] Skip offline cores when enabling SMT on PowerPC

2024-06-13 Thread Michal Suchánek
On Thu, Jun 13, 2024 at 09:34:10PM +1000, Michael Ellerman wrote: > "Nysal Jan K.A." writes: > > From: "Nysal Jan K.A" > > > > After the addition of HOTPLUG_SMT support for PowerPC [1] there was a > > regression reported [2] when enabling SMT. > > This implies it was a kernel regression. But it

Re: [PATCH] powerpc/pseries/iommu: LPAR panics when rebooted with a frozen PE

2024-04-19 Thread Michal Suchánek
Hello, On Fri, Apr 19, 2024 at 04:12:46PM +1000, Michael Ellerman wrote: > Gaurav Batra writes: > > At the time of LPAR reboot, partition firmware provides Open Firmware > > property ibm,dma-window for the PE. This property is provided on the PCI > > bus the PE is attached to. > > AFAICS you're

Re: [PATCH v4 07/10] cpu/SMT: Allow enabling partial SMT states via sysfs

2024-04-08 Thread Michal Suchánek
Hello, On Wed, Jul 05, 2023 at 04:51:40PM +0200, Laurent Dufour wrote: > From: Michael Ellerman > > Add support to the /sys/devices/system/cpu/smt/control interface for > enabling a specified number of SMT threads per core, including partial > SMT states where not all threads are brought online.

Re: Cannot load wireguard module

2024-03-20 Thread Michal Suchánek
On Wed, Mar 20, 2024 at 11:41:32PM +1100, Michael Ellerman wrote: > Michal Suchánek writes: > > On Mon, Mar 18, 2024 at 06:08:55PM +0100, Michal Suchánek wrote: > >> On Mon, Mar 18, 2024 at 10:50:49PM +1100, Michael Ellerman wrote: > >> > Michael Ellerman writes: &g

Re: Cannot load wireguard module

2024-03-18 Thread Michal Suchánek
On Mon, Mar 18, 2024 at 10:50:49PM +1100, Michael Ellerman wrote: > Michael Ellerman writes: > > Michal Suchánek writes: > >> Hello, > >> > >> I cannot load the wireguard module. > >> > >> Loading the module provides no diagnostic other tha

Cannot load wireguard module

2024-03-15 Thread Michal Suchánek
Hello, I cannot load the wireguard module. Loading the module provides no diagnostic other than 'No such device'. Please provide maningful diagnostics for loading software-only driver, clearly there is no particular device needed. Thanks Michal jostaberry-1:~ # uname -a Linux jostaberry-1 6.8

Re: [PATCH] selftests: powerpc: Add header symlinks for building papr character device tests

2024-02-15 Thread Michal Suchánek
On Thu, Feb 15, 2024 at 01:39:27PM -0600, Nathan Lynch wrote: > Michal Suchánek writes: > > On Thu, Feb 15, 2024 at 01:13:34PM -0600, Nathan Lynch wrote: > >> Michal Suchanek writes: > >> > > >> > Without the headers the tests don't build. > &

Re: [PATCH] selftests: powerpc: Add header symlinks for building papr character device tests

2024-02-15 Thread Michal Suchánek
On Thu, Feb 15, 2024 at 01:13:34PM -0600, Nathan Lynch wrote: > Michal Suchanek writes: > > > > Without the headers the tests don't build. > > > > Fixes: 9118c5d32bdd ("powerpc/selftests: Add test for papr-vpd") > > Fixes: 76b2ec3faeaa ("powerpc/selftests: Add test for papr-sysparm") > > Signed-of

Re: [RFC] UBUNTU: [Config] y2038: Disable COMPAT and COMPAT_32BIT_TIME on ppc64le

2023-11-24 Thread Michal Suchánek
On Fri, Nov 24, 2023 at 03:59:04PM +1100, Michael Ellerman wrote: > Dimitri John Ledkov writes: > > BugLink: https://bugs.launchpad.net/bugs/2038587 > > > > ppc64le is exclusively little endian and 64-bit, thus there is no need > > for COMPAT_32BIT_TIME, nor COMPAT. > > To be pedantic, the ppc64l

Re: [PATCH v4 09/13] powerpc/pseries: Add papr-vpd character driver for VPD retrieval

2023-11-21 Thread Michal Suchánek
sary RTAS interactions are performed before returning the fd > + * to user space. This keeps the read handler simple and ensures that > + * the kernel can prevent interleaving of ibm,get-vpd call sequences. > + * > + * Return: The installed fd number if successful, -ve err

Re: [PATCH v3 00/10] powerpc/pseries: New character devices for system parameters and VPD

2023-11-13 Thread Michal Suchánek
Hello, On Thu, Oct 26, 2023 at 06:56:36PM -0500, Nathan Lynch wrote: > Nathan Lynch via B4 Relay > writes: > > I have made changes to librtas to prefer the new interfaces and > > verified that existing clients work correctly with the new code. > > Unfortunately I made a mistake in testing this t

Re: [PATCH v7 3/3 RESEND] powerpc/pseries: PLPKS SED Opal keystore support

2023-09-14 Thread Michal Suchánek
Hello, On Thu, Sep 14, 2023 at 02:13:32PM +1000, Michael Ellerman wrote: > Nathan Chancellor writes: > > Hi Greg, > > > > On Fri, Sep 08, 2023 at 10:30:56AM -0500, gjo...@linux.vnet.ibm.com wrote: > >> From: Greg Joyce > >> > >> Define operations for SED Opal to read/write keys > >> from POWER L

Re: [PATCH] integrity: powerpc: Do not select CA_MACHINE_KEYRING

2023-09-12 Thread Michal Suchánek
On Mon, Sep 11, 2023 at 11:39:38PM -0400, Nayna wrote: > > On 9/7/23 13:32, Michal Suchánek wrote: > > Adding more CC's from the original patch, looks like get_maintainers is > > not that great for this file. > > > > On Thu, Sep 07, 2023 at 06:52:19PM +0200, Mi

Re: [PATCH] integrity: powerpc: Do not select CA_MACHINE_KEYRING

2023-09-07 Thread Michal Suchánek
Adding more CC's from the original patch, looks like get_maintainers is not that great for this file. On Thu, Sep 07, 2023 at 06:52:19PM +0200, Michal Suchanek wrote: > No other platform needs CA_MACHINE_KEYRING, either. > > This is policy that should be decided by the administrator, not Kconfig

Re: [PATCH RFC] powerpc/rtas: Make it possible to disable sys_rtas

2023-09-07 Thread Michal Suchánek
On Thu, Sep 07, 2023 at 11:52:44AM -0500, Nathan Lynch wrote: > Michal Suchánek writes: > > On Wed, Sep 06, 2023 at 02:34:59PM -0500, Nathan Lynch wrote: > >> Michal Suchanek writes: > >> > >> > Additional patch

Re: [PATCH RFC] powerpc/rtas: Make it possible to disable sys_rtas

2023-09-07 Thread Michal Suchánek
On Wed, Sep 06, 2023 at 02:34:59PM -0500, Nathan Lynch wrote: > Michal Suchanek writes: > > > Additional patch suggestion to go with the rtas devices: > > > > --- > > > > With most important rtas functions available through diffe

Re: [PATCH RFC 0/2] powerpc/pseries: new character devices for RTAS functions

2023-09-06 Thread Michal Suchánek
Hello, On Tue, Aug 22, 2023 at 04:33:38PM -0500, Nathan Lynch via B4 Relay wrote: > This is a proposal for adding chardev-based access to a select subset > of RTAS functions on the pseries platform. > > The problem: important platform features are enabled on Linux VMs > through the powerpc-specif

Re: [PATCH RFC 1/2] powerpc/pseries: papr-vpd char driver for VPD retrieval

2023-09-06 Thread Michal Suchánek
On Tue, Aug 22, 2023 at 04:33:39PM -0500, Nathan Lynch via B4 Relay wrote: > From: Nathan Lynch > > PowerVM LPARs may retrieve Vital Product Data (VPD) for system > components using the ibm,get-vpd RTAS function. > > We can expose this to user space with a /dev/papr-vpd character > device, where

Re: [PATCH RFC 1/2] powerpc/pseries: papr-vpd char driver for VPD retrieval

2023-09-05 Thread Michal Suchánek
On Tue, Sep 05, 2023 at 12:42:11PM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > On Thu, Aug 31, 2023 at 12:59:25PM -0500, Nathan Lynch wrote: > ... > >> You (Michal) seem to favor a kernel-user ABI where user space is allowed > >> to invoke arbitrary

Re: [PATCH RFC 1/2] powerpc/pseries: papr-vpd char driver for VPD retrieval

2023-09-04 Thread Michal Suchánek
On Thu, Aug 31, 2023 at 03:34:37PM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > Hello, > > > > thanks for working on this. > > > > On Tue, Aug 22, 2023 at 04:33:39PM -0500, Nathan Lynch via B4 Relay wrote: > >> From: Nathan Lynch &

Re: [PATCH RFC 1/2] powerpc/pseries: papr-vpd char driver for VPD retrieval

2023-09-04 Thread Michal Suchánek
Hello, On Thu, Aug 31, 2023 at 12:59:25PM -0500, Nathan Lynch wrote: > Michal Suchánek writes: > > On Thu, Aug 31, 2023 at 09:37:12PM +1000, Michael Ellerman wrote: > >> Michal Suchánek writes: > >> > On Thu, Aug 31, 2023 at 03:34:37PM +1000, Michael Ellerman

Re: [PATCH RFC 1/2] powerpc/pseries: papr-vpd char driver for VPD retrieval

2023-08-31 Thread Michal Suchánek
On Thu, Aug 31, 2023 at 09:37:12PM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > On Thu, Aug 31, 2023 at 03:34:37PM +1000, Michael Ellerman wrote: > >> Michal Suchánek writes: > >> > On Tue, Aug 22, 2023 at 04:33:39PM -0500, Nathan Lynch via B4 Rel

Re: [PATCH RFC 1/2] powerpc/pseries: papr-vpd char driver for VPD retrieval

2023-08-31 Thread Michal Suchánek
On Thu, Aug 31, 2023 at 03:34:37PM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > Hello, > > > > thanks for working on this. > > > > On Tue, Aug 22, 2023 at 04:33:39PM -0500, Nathan Lynch via B4 Relay wrote: > >> From: Nathan Lynch &

Re: [PATCH RFC 1/2] powerpc/pseries: papr-vpd char driver for VPD retrieval

2023-08-31 Thread Michal Suchánek
On Thu, Aug 31, 2023 at 03:34:37PM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > Hello, > > > > thanks for working on this. > > > > On Tue, Aug 22, 2023 at 04:33:39PM -0500, Nathan Lynch via B4 Relay wrote: > >> From: Nathan Lynch &

Re: [PATCH RFC 1/2] powerpc/pseries: papr-vpd char driver for VPD retrieval

2023-08-30 Thread Michal Suchánek
Hello, thanks for working on this. On Tue, Aug 22, 2023 at 04:33:39PM -0500, Nathan Lynch via B4 Relay wrote: > From: Nathan Lynch > > PowerVM LPARs may retrieve Vital Product Data (VPD) for system > components using the ibm,get-vpd RTAS function. > > We can expose this to user space with a /d

Re: [PATCH v6 02/14] x86/kexec: refactor for kernel/Kconfig.kexec

2023-08-22 Thread Michal Suchánek
Hello, On Thu, Jul 13, 2023 at 07:13:57PM +0800, Leizhen (ThunderTown) wrote: > > > On 2023/7/13 0:15, Eric DeVolder wrote: > > The kexec and crash kernel options are provided in the common > > kernel/Kconfig.kexec. Utilize the common options and provide > > the ARCH_SUPPORTS_ and ARCH_SELECTS_

Re: [PATCH 1/2] pseries/smp: export the smt level in the SYS FS.

2023-04-14 Thread Michal Suchánek
Hello, On Fri, Apr 14, 2023 at 10:11:24PM +1000, Michael Ellerman wrote: > Laurent Dufour writes: > > On 13/04/2023 15:37:59, Michael Ellerman wrote: > >> Laurent Dufour writes: > >>> There is no SMT level recorded in the kernel neither in user space. > >>> Indeed there is no real constraint abo

Re: [PATCH] Revert "powerpc/rtas: Implement reentrant rtas call"

2023-04-14 Thread Michal Suchánek
Hello, On Fri, Sep 16, 2022 at 04:56:18PM -0500, Nathan Lynch wrote: > "Nicholas Piggin" writes: > > On Wed Sep 14, 2022 at 3:39 AM AEST, Leonardo Brás wrote: > >> On Mon, 2022-09-12 at 14:58 -0500, Nathan Lynch wrote: > >> > Leonardo Brás writes: > >> > > On Fri, 2022-09-09 at 09:04 -0500, Nath

Re: [PATCH 1/2] pseries/smp: export the smt level in the SYS FS.

2023-03-31 Thread Michal Suchánek
Hello, On Fri, Mar 31, 2023 at 05:39:04PM +0200, Laurent Dufour wrote: > There is no SMT level recorded in the kernel neither in user space. > Indeed there is no real constraint about that and mixed SMT levels are > allowed and system is working fine this way. > > However when new CPU are added,

Re: [PATCH] powerpc/pseries/cpuhp: respect current SMT when adding new CPU

2023-03-30 Thread Michal Suchánek
On Thu, Mar 30, 2023 at 05:51:57PM +0200, Laurent Dufour wrote: > On 13/02/2023 16:40:50, Nathan Lynch wrote: > > Michal Suchánek writes: > >> On Mon, Feb 13, 2023 at 08:46:50AM -0600, Nathan Lynch wrote: > >>> Laurent Dufour writes: > >>>> When a n

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-13 Thread Michal Suchánek
On Mon, Mar 13, 2023 at 10:53:34PM +0100, Andrea Righi wrote: > On Mon, Mar 13, 2023 at 10:48:53PM +0100, Michal Suchánek wrote: > > Hello, > > > > On Mon, Mar 13, 2023 at 09:32:16PM +0100, Andrea Righi wrote: > > > On Wed, Jan 11, 2023 at 04:11:51PM +, Gar

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-13 Thread Michal Suchánek
Hello, On Mon, Mar 13, 2023 at 09:32:16PM +0100, Andrea Righi wrote: > On Wed, Jan 11, 2023 at 04:11:51PM +, Gary Guo wrote: > > Currently modversion uses a fixed size array of size (64 - sizeof(long)) > > to store symbol names, thus placing a hard limit on length of symbols. > > Rust symbols

Re: [PATCH v4 1/2] powerpc/mm: Support execute-only memory on the Radix MMU

2023-03-08 Thread Michal Suchánek
Hello, On Wed, Aug 31, 2022 at 11:13:59PM +1000, Michael Ellerman wrote: > On Wed, 17 Aug 2022 15:06:39 +1000, Russell Currey wrote: > > Add support for execute-only memory (XOM) for the Radix MMU by using an > > execute-only mapping, as opposed to the RX mapping used by powerpc's > > other MMUs.

Re: [PATCH] powerpc/pseries/cpuhp: respect current SMT when adding new CPU

2023-02-13 Thread Michal Suchánek
Hello, On Mon, Feb 13, 2023 at 08:46:50AM -0600, Nathan Lynch wrote: > Laurent Dufour writes: > > When a new CPU is added, the kernel is activating all its threads. This > > leads to weird, but functional, result when adding CPU on a SMT 4 system > > for instance. > > > > Here the newly added CPU

Re: [PATCH v2] of: Fix of platform build on powerpc due to bad of disaply code

2023-01-20 Thread Michal Suchánek
Hello, On Fri, Jan 20, 2023 at 11:23:39AM -0600, Rob Herring wrote: > On Thu, Jan 19, 2023 at 3:53 AM Michal Suchanek wrote: > > > > The commit 2d681d6a23a1 ("of: Make of framebuffer devices unique") > > breaks build because of wrong argument to snprintf. That certainly > > avoids the runtime err

Re: [PATCH v2] of: Fix of platform build on powerpc due to bad of disaply code

2023-01-20 Thread Michal Suchánek
On Thu, Jan 19, 2023 at 11:34:46AM +0100, Michal Suchánek wrote: > Hello, > > On Thu, Jan 19, 2023 at 10:24:07AM +, Christophe Leroy wrote: > > > > > > Le 19/01/2023 à 10:53, Michal Suchanek a écrit : > > > The commit 2d681d6a23a1 ("of: Make of

Re: [PATCH v2] of: Fix of platform build on powerpc due to bad of disaply code

2023-01-20 Thread Michal Suchánek
On Fri, Jan 20, 2023 at 12:39:23PM +0100, Thomas Zimmermann wrote: > Hi > > Am 20.01.23 um 12:27 schrieb Michal Suchánek: > > Hello, > > > > On Thu, Jan 19, 2023 at 04:20:57PM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 19.01.23

Re: [PATCH v2] of: Fix of platform build on powerpc due to bad of disaply code

2023-01-20 Thread Michal Suchánek
Hello, On Thu, Jan 19, 2023 at 04:20:57PM +0100, Thomas Zimmermann wrote: > Hi > > Am 19.01.23 um 14:23 schrieb Michal Suchánek: > > On Thu, Jan 19, 2023 at 02:11:13PM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-01-19 Thread Michal Suchánek
On Thu, Jan 19, 2023 at 03:09:36PM +, Gary Guo wrote: > On Tue, 17 Jan 2023 11:22:45 -0800 > Lucas De Marchi wrote: > > > On Tue, Jan 17, 2023 at 06:51:44PM +0100, Michal Suchánek wrote: > > >Hello, > > > > > >On Fri, Jan 13, 2023 at 06:18:41PM +000

Re: [PATCH v2] of: Fix of platform build on powerpc due to bad of disaply code

2023-01-19 Thread Michal Suchánek
On Thu, Jan 19, 2023 at 02:11:13PM +0100, Thomas Zimmermann wrote: > Hi > > Am 19.01.23 um 11:24 schrieb Christophe Leroy: > > > > > > Le 19/01/2023 à 10:53, Michal Suchanek a écrit : > > > The commit 2d681d6a23a1 ("of: Make of framebuffer devices unique") > > > breaks build because of wrong arg

Re: [PATCH v2] of: Fix of platform build on powerpc due to bad of disaply code

2023-01-19 Thread Michal Suchánek
Hello, On Thu, Jan 19, 2023 at 10:24:07AM +, Christophe Leroy wrote: > > > Le 19/01/2023 à 10:53, Michal Suchanek a écrit : > > The commit 2d681d6a23a1 ("of: Make of framebuffer devices unique") > > breaks build because of wrong argument to snprintf. That certainly > > avoids the runtime err

Re: [PATCH] of: Make of framebuffer devices unique

2023-01-19 Thread Michal Suchánek
On Thu, Jan 19, 2023 at 09:00:44AM +0100, Thomas Zimmermann wrote: > Hi Michal, > > thanks for fixing this issue. But the review time was way too short. Please > see my comments below. > > Am 18.01.23 um 22:46 schrieb Michal Suchánek: > > On Wed, Jan 18, 2023 at 09:13:05P

Re: [PATCH] of: Make of framebuffer devices unique

2023-01-18 Thread Michal Suchánek
On Wed, Jan 18, 2023 at 09:13:05PM +0100, Erhard F. wrote: > On Tue, 17 Jan 2023 17:58:04 +0100 > Michal Suchanek wrote: > > > Since Linux 5.19 this error is observed: > > > > sysfs: cannot create duplicate filename '/devices/platform/of-display' > > > > This is because multiple devices with th

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-01-17 Thread Michal Suchánek
Hello, On Fri, Jan 13, 2023 at 06:18:41PM +, Gary Guo wrote: > On Thu, 12 Jan 2023 14:40:59 -0700 > Lucas De Marchi wrote: > > > On Wed, Jan 11, 2023 at 04:11:51PM +, Gary Guo wrote: > > > > > > struct modversion_info { > > >- unsigned long crc; > > >- char name[MODULE_NAME_LEN]; > > >

Re: [PATCH] powerpc/ftrace: fix syscall tracing on PPC64_ELF_ABI_V1

2022-12-07 Thread Michal Suchánek
Hello, On Wed, Dec 07, 2022 at 10:18:13AM -0500, Mathieu Desnoyers wrote: > On 2022-12-06 21:09, Michael Ellerman wrote: > > Mathieu Desnoyers writes: > > > On 2022-12-05 17:50, Michael Ellerman wrote: > > > > Relatedly we have a patch in next to optionally use ABIv2 for 64-bit big > > endian b

Re: [PATCH -next] fbdev: offb: allow build when DRM_OFDRM=m

2022-11-23 Thread Michal Suchánek
gt; FB_CFB_* symbols to =y instead of =m. > > > > Fixes: c8a17756c425 ("drm/ofdrm: Add ofdrm for Open Firmware framebuffers") > > Signed-off-by: Randy Dunlap > > Suggested-by: Masahiro Yamada > > Cc: Thomas Zimmermann > > Cc: Michal Suchánek > &g

Re: build failure in linux-next: offb missing fb helpers

2022-11-19 Thread Michal Suchánek
Hello, On Sat, Nov 19, 2022 at 10:27:04PM +0900, Masahiro Yamada wrote: > On Sat, Nov 19, 2022 at 3:20 PM Randy Dunlap wrote: > > > > Hi-- > > > > [adding Masahiro-san] > > > > > > On 11/18/22 07:03, Michal Suchánek wrote: > > > Hello, >

Re: [PATCH v5 1/5] drm/ofdrm: Add ofdrm for Open Firmware framebuffers

2022-11-19 Thread Michal Suchánek
Hello, On Tue, Oct 11, 2022 at 05:07:08PM +0200, Thomas Zimmermann wrote: > Open Firmware provides basic display output via the 'display' node. > DT platform code already provides a device that represents the node's > framebuffer. Add a DRM driver for the device. The display mode and > color forma

Re: [PATCH v4 5/5] drm/ofdrm: Support big-endian scanout buffers

2022-10-12 Thread Michal Suchánek
On Wed, Oct 12, 2022 at 05:59:45PM +0300, Ville Syrjälä wrote: > On Wed, Oct 12, 2022 at 04:31:14PM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 12.10.22 um 15:12 schrieb Arnd Bergmann: > > > On Wed, Oct 12, 2022, at 2:00 PM, Thomas Zimmermann wrote: > > >> > > >> Could well be. But ofdrm int

Re: [PATCH v4 5/5] drm/ofdrm: Support big-endian scanout buffers

2022-10-12 Thread Michal Suchánek
Hello, On Wed, Oct 12, 2022 at 03:12:35PM +0200, Arnd Bergmann wrote: > On Wed, Oct 12, 2022, at 2:00 PM, Thomas Zimmermann wrote: > > > > Could well be. But ofdrm intents to replace offb and this test has > > worked well in offb for almost 15 yrs. If there are bug reports, I'm > > happy to take

Re: [PATCH v4 5/5] drm/ofdrm: Support big-endian scanout buffers

2022-10-12 Thread Michal Suchánek
On Wed, Oct 12, 2022 at 10:38:29AM +0200, Arnd Bergmann wrote: > On Wed, Oct 12, 2022, at 10:27 AM, Thomas Zimmermann wrote: > > Am 12.10.22 um 09:44 schrieb Arnd Bergmann: > >> On Wed, Oct 12, 2022, at 9:40 AM, Thomas Zimmermann wrote: > >>> Am 12.10.22 um 09:17 schrieb Arnd Bergmann: > On We

Re: [PATCH v4 5/5] drm/ofdrm: Support big-endian scanout buffers

2022-10-12 Thread Michal Suchánek
On Wed, Oct 12, 2022 at 08:29:39AM +0200, Arnd Bergmann wrote: > On Tue, Oct 11, 2022, at 11:38 PM, Michal Suchánek wrote: > > On Tue, Oct 11, 2022 at 10:06:59PM +0200, Arnd Bergmann wrote: > >> On Tue, Oct 11, 2022, at 1:30 PM, Thomas Zimmermann wrote: > >> > Am 11

Re: [PATCH v4 5/5] drm/ofdrm: Support big-endian scanout buffers

2022-10-11 Thread Michal Suchánek
On Tue, Oct 11, 2022 at 10:06:59PM +0200, Arnd Bergmann wrote: > On Tue, Oct 11, 2022, at 1:30 PM, Thomas Zimmermann wrote: > > Am 11.10.22 um 09:46 schrieb Javier Martinez Canillas: > >>> +static bool display_get_big_endian_of(struct drm_device *dev, struct > >>> device_node *of_node) > >>> +{ >

Re: [PATCH] powerpc/pseries/vas: Pass hw_cpu_id to node associativity HCALL

2022-09-30 Thread Michal Suchánek
Hello, On Thu, Sep 29, 2022 at 05:16:40PM -0500, Nathan Lynch wrote: > Haren Myneni writes: > > Generally the hypervisor decides to allocate a window on different > > VAS instances. But if the user space wishes to allocate on the > > current VAS instance where the process is executing, the kernel

Re: [PATCH v4 5/5] drm/ofdrm: Support big-endian scanout buffers

2022-09-28 Thread Michal Suchánek
Hello, On Wed, Sep 28, 2022 at 12:50:10PM +0200, Thomas Zimmermann wrote: > All DRM formats assume little-endian byte order. On big-endian systems, > it is likely that the scanout buffer is in big endian as well. Update > the format accordingly and add endianess conversion to the format-helper > l

Re: [PATCH 5.15 0/6] arm64: kexec_file: use more system keyrings to verify kernel image signature + dependencies

2022-09-27 Thread Michal Suchánek
On Tue, Sep 27, 2022 at 11:39:52AM +0900, AKASHI Takahiro wrote: > On Mon, Sep 26, 2022 at 09:40:25AM +0200, Michal Such??nek wrote: > > On Mon, Sep 26, 2022 at 08:47:32AM +0200, Greg Kroah-Hartman wrote: > > > On Sat, Sep 24, 2022 at 01:55:23PM +0200, Michal Suchánek wrote: >

Re: [PATCH 5.15 0/6] arm64: kexec_file: use more system keyrings to verify kernel image signature + dependencies

2022-09-26 Thread Michal Suchánek
On Mon, Sep 26, 2022 at 08:47:32AM +0200, Greg Kroah-Hartman wrote: > On Sat, Sep 24, 2022 at 01:55:23PM +0200, Michal Suchánek wrote: > > On Sat, Sep 24, 2022 at 12:13:34PM +0200, Greg Kroah-Hartman wrote: > > > On Sat, Sep 24, 2022 at 11:45:21AM +0200, Michal Suchánek wrote: &

Re: [PATCH 5.15 0/6] arm64: kexec_file: use more system keyrings to verify kernel image signature + dependencies

2022-09-24 Thread Michal Suchánek
On Fri, Sep 23, 2022 at 09:16:50PM +0200, Michal Suchánek wrote: > Hello, > > On Fri, Sep 23, 2022 at 03:03:36PM -0400, Mimi Zohar wrote: > > On Fri, 2022-09-23 at 19:10 +0200, Michal Suchanek wrote: > > > Hello, > > > > > > this is backport of commit 0

Re: [PATCH 5.15 0/6] arm64: kexec_file: use more system keyrings to verify kernel image signature + dependencies

2022-09-24 Thread Michal Suchánek
On Sat, Sep 24, 2022 at 12:13:34PM +0200, Greg Kroah-Hartman wrote: > On Sat, Sep 24, 2022 at 11:45:21AM +0200, Michal Suchánek wrote: > > On Sat, Sep 24, 2022 at 11:19:19AM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Sep 23, 2022 at 07:10:28PM +0200, Michal Suchanek wr

Re: [PATCH 5.15 0/6] arm64: kexec_file: use more system keyrings to verify kernel image signature + dependencies

2022-09-24 Thread Michal Suchánek
On Sat, Sep 24, 2022 at 11:19:19AM +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 23, 2022 at 07:10:28PM +0200, Michal Suchanek wrote: > > Hello, > > > > this is backport of commit 0d519cadf751 > > ("arm64: kexec_file: use more system keyrings to verify kernel image > > signature") > > to table 5

Re: [PATCH 5.15 0/6] arm64: kexec_file: use more system keyrings to verify kernel image signature + dependencies

2022-09-23 Thread Michal Suchánek
Hello, On Fri, Sep 23, 2022 at 03:03:36PM -0400, Mimi Zohar wrote: > On Fri, 2022-09-23 at 19:10 +0200, Michal Suchanek wrote: > > Hello, > > > > this is backport of commit 0d519cadf751 > > ("arm64: kexec_file: use more system keyrings to verify kernel image > > signature") > > to table 5.15 tre

Re: [PATCH] powerpc/pseries: add lparctl driver for platform-specific functions

2022-09-14 Thread Michal Suchánek
On Tue, Sep 13, 2022 at 12:02:42PM -0500, Nathan Lynch wrote: > Michal Suchánek writes: > > On Tue, Sep 13, 2022 at 10:59:56AM -0500, Nathan Lynch wrote: > >> Michal Suchánek writes: > >> > >> > On Fri, Aug 12, 2022 at 02:14:21PM -0500, Nathan Lync

Re: [PATCH] powerpc/pseries: add lparctl driver for platform-specific functions

2022-09-13 Thread Michal Suchánek
On Tue, Sep 13, 2022 at 10:59:56AM -0500, Nathan Lynch wrote: > Michal Suchánek writes: > > > On Fri, Aug 12, 2022 at 02:14:21PM -0500, Nathan Lynch wrote: > >> Laurent Dufour writes: > >> > Le 30/07/2022 à 02:04, Nathan Lynch a écrit : > >>

Re: [PATCH] powerpc/pseries: add lparctl driver for platform-specific functions

2022-09-13 Thread Michal Suchánek
On Fri, Aug 12, 2022 at 02:14:21PM -0500, Nathan Lynch wrote: > Laurent Dufour writes: > > Le 30/07/2022 à 02:04, Nathan Lynch a écrit : > >> +static long lparctl_get_sysparm(struct lparctl_get_system_parameter > >> __user *argp) > >> +{ > >> + struct lparctl_get_system_parameter *gsp; > >> + l

Re: [PATCH v3a 1/2] lib: generic accessor functions for arch keystore

2022-08-08 Thread Michal Suchánek
On Mon, Aug 08, 2022 at 04:31:06PM +, Christophe Leroy wrote: > > > Le 08/08/2022 à 17:43, gjo...@linux.vnet.ibm.com a écrit : > > From: Greg Joyce > > > > Generic kernel subsystems may rely on platform specific persistent > > KeyStore to store objects containing sensitive key material. In

Re: [PATCH v3 1/2] lib: generic accessor functions for arch keystore

2022-08-01 Thread Michal Suchánek
On Mon, Aug 01, 2022 at 03:45:45PM -0400, Nayna wrote: > > On 8/1/22 09:40, Michal Suchánek wrote: > > Hello, > > > > On Mon, Aug 01, 2022 at 07:34:25AM -0500, gjo...@linux.vnet.ibm.com wrote: > > > From: Greg Joyce > > > > > > Generic kernel

Re: [PATCH v3 1/2] lib: generic accessor functions for arch keystore

2022-08-01 Thread Michal Suchánek
Hello, On Mon, Aug 01, 2022 at 07:34:25AM -0500, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > > Generic kernel subsystems may rely on platform specific persistent > KeyStore to store objects containing sensitive key material. In such case, > they need to access architecture specific fun

Re: [PATCH v2 00/10] drm: Add driver for PowerPC OF displays

2022-07-28 Thread Michal Suchánek
Hello, On Thu, Jul 28, 2022 at 09:13:59PM +1000, Michael Ellerman wrote: > Thomas Zimmermann writes: > > (was: drm: Add driverof PowerPC OF displays) > > > > PowerPC's Open Firmware offers a simple display buffer for graphics > > output. Add ofdrm, a DRM driver for the device. As with the existin

Re: [PATCH v2 09/10] drm/ofdrm: Add per-model device function

2022-07-26 Thread Michal Suchánek
Hello, On Tue, Jul 26, 2022 at 03:38:37PM +0200, Javier Martinez Canillas wrote: > On 7/20/22 16:27, Thomas Zimmermann wrote: > > Add a per-model device-function structure in preparation of adding > > color-management support. Detection of the individual models has been > > taken from fbdev's offb

Re: [PATCH] powerpc: Remove the static variable initialisations to 0

2022-07-23 Thread Michal Suchánek
Hello, On Sat, Jul 23, 2022 at 05:24:36PM +0800, Jason Wang wrote: > Initialise global and static variable to 0 is always unnecessary. > Remove the unnecessary initialisations. Isn't this change also unnecessary? Initializing to 0 does not affect correctness, or even any kind of semantics in any

Re: [PATCH 2/2] drm/tiny: Add ofdrm for Open Firmware framebuffers

2022-05-18 Thread Michal Suchánek
On Wed, May 18, 2022 at 10:11:03PM +0100, Mark Cave-Ayland wrote: > On 18/05/2022 19:30, Thomas Zimmermann wrote: > > > Open Firmware provides basic display output via the 'display' node. > > DT platform code already provides a device that represents the node's > > framebuffer. Add a DRM driver fo

Re: [PATCH 2/2] drm/tiny: Add ofdrm for Open Firmware framebuffers

2022-05-18 Thread Michal Suchánek
Hello, On Wed, May 18, 2022 at 08:30:06PM +0200, Thomas Zimmermann wrote: > Open Firmware provides basic display output via the 'display' node. > DT platform code already provides a device that represents the node's > framebuffer. Add a DRM driver for the device. The display mode and > color forma

Re: [PATCH] powerpc/time: Always set decrementer in timer_interrupt()

2022-04-20 Thread Michal Suchánek
Hello, On Thu, Apr 21, 2022 at 12:16:57AM +1000, Michael Ellerman wrote: > This is a partial revert of commit 0faf20a1ad16 ("powerpc/64s/interrupt: > Don't enable MSR[EE] in irq handlers unless perf is in use"). > > Prior to that commit, we always set the decrementer in > timer_interrupt(), to cl

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.18-1 tag

2022-03-30 Thread Michal Suchánek
On Mon, Mar 28, 2022 at 08:07:13PM +1100, Michael Ellerman wrote: > Linus Torvalds writes: > > On Fri, Mar 25, 2022 at 3:25 AM Michael Ellerman > > wrote: > > > That said: > > > >> There's a series of commits cleaning up function descriptor handling, > > > > For some reason I also thought that

Re: [PATCH v5 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2022-02-14 Thread Michal Suchánek
Hello, On Mon, Feb 14, 2022 at 10:14:16AM -0500, Mimi Zohar wrote: > Hi Michal, > > On Sun, 2022-02-13 at 21:59 -0500, Mimi Zohar wrote: > > > > > On Tue, 2022-01-11 at 12:37 +0100, Michal Suchanek wrote: > > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > > > index dea74d7717c0..1

Re: No Linux logs when doing `ppc64_cpu --smt=off/8`

2022-02-14 Thread Michal Suchánek
On Mon, Feb 14, 2022 at 01:33:24PM +0100, Paul Menzel wrote: > Dear Michal, > > > Thank you for your reply. > > Am 14.02.22 um 10:43 schrieb Michal Suchánek: > > > On Mon, Feb 14, 2022 at 07:08:07AM +0100, Paul Menzel wrote: > > > Dear PPC folks, > >

Re: No Linux logs when doing `ppc64_cpu --smt=off/8`

2022-02-14 Thread Michal Suchánek
Hello, On Mon, Feb 14, 2022 at 07:08:07AM +0100, Paul Menzel wrote: > Dear PPC folks, > > > On the POWER8 server IBM S822LC running `ppc64_cpu --smt=off` or `ppc64_cpu > --smt=8`, Linux 5.17-rc4 does not log anything. I would have expected a > message about the change in number of processing uni

Re: [PATCH v5 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2022-02-09 Thread Michal Suchánek
Hello, On Wed, Feb 09, 2022 at 07:44:15AM +0100, Paul Menzel wrote: > Dear Michal, > > > Thank you for the patch. > > > Am 11.01.22 um 12:37 schrieb Michal Suchanek: > > Could you please remove the dot/period at the end of the git commit message > summary? Sure > > Copy the code from s390x

Re: [PATCH v3 4/6] modules: Add CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC

2022-02-08 Thread Michal Suchánek
Hello, On Thu, Feb 03, 2022 at 11:51:05AM -0800, Luis Chamberlain wrote: > On Thu, Feb 03, 2022 at 07:05:13AM +, Christophe Leroy wrote: > > Le 03/02/2022 à 01:01, Luis Chamberlain a écrit : > > > On Sat, Jan 29, 2022 at 05:02:09PM +, Christophe Leroy wrote: > > >> diff --git a/kernel/modu

Re: [PATCH v5 3/6] kexec_file: Don't opencode appended signature verification.

2022-02-03 Thread Michal Suchánek
Hello, thanks for the review. On Tue, Jan 25, 2022 at 12:15:56PM -0800, Luis Chamberlain wrote: > On Tue, Jan 11, 2022 at 12:37:45PM +0100, Michal Suchanek wrote: > > diff --git a/include/linux/verification.h b/include/linux/verification.h > > index a655923335ae..32db9287a7b0 100644 > > --- a/inc

Re: [PATCH v7 1/7] powerpc/pmem: Restrict papr_scm to P8 and above.

2022-01-21 Thread Michal Suchánek
On Fri, Jan 21, 2022 at 02:48:32PM +0530, Aneesh Kumar K.V wrote: > Michal Suchánek writes: > > > Hello, > > > > On Wed, Jul 01, 2020 at 12:52:29PM +0530, Aneesh Kumar K.V wrote: > >> The PAPR based virtualized persistent memory devices are only supported

Re: [PATCH v7 1/7] powerpc/pmem: Restrict papr_scm to P8 and above.

2022-01-21 Thread Michal Suchánek
Hello, On Wed, Jul 01, 2020 at 12:52:29PM +0530, Aneesh Kumar K.V wrote: > The PAPR based virtualized persistent memory devices are only supported on > POWER9 and above. In the followup patch, the kernel will switch the persistent > memory cache flush functions to use a new `dcbf` variant instruct

Re: [PATCH v2 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2021-12-13 Thread Michal Suchánek
Hello, On Sun, Dec 12, 2021 at 07:46:53PM -0500, Nayna wrote: > > On 11/25/21 13:02, Michal Suchanek wrote: > > Copy the code from s390x > > > > Signed-off-by: Michal Suchanek > > --- > > arch/powerpc/Kconfig| 11 +++ > > arch/powerpc/kexec/elf_64.c | 36 +

Re: [PATCH v2 6/6] module: Move duplicate mod_check_sig users code to mod_parse_sig

2021-12-13 Thread Michal Suchánek
Hello, On Tue, Dec 07, 2021 at 05:10:34PM +0100, Philipp Rudo wrote: > Hi Michal, > > On Thu, 25 Nov 2021 19:02:44 +0100 > Michal Suchanek wrote: > > > Multiple users of mod_check_sig check for the marker, then call > > mod_check_sig, extract signature length, and remove the signature. > > > >

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-12-09 Thread Michal Suchánek
Hello, On Wed, Dec 08, 2021 at 08:50:54PM -0500, Nayna wrote: > > On 11/25/21 13:02, Michal Suchanek wrote: > > Hello, > > Hi Michael, > > > > > This is resend of the KEXEC_SIG patchset. > > > > The first patch is new because it'a a cleanup that does not require any > > change to the module v

Re: [PATCH v2 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2021-12-09 Thread Michal Suchánek
Hello, On Wed, Dec 08, 2021 at 08:51:47PM -0500, Nayna wrote: > > On 11/25/21 13:02, Michal Suchanek wrote: > > Copy the code from s390x > > > > Signed-off-by: Michal Suchanek > > --- > > arch/powerpc/Kconfig| 11 +++ > > arch/powerpc/kexec/elf_64.c | 36 ++

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-12-07 Thread Michal Suchánek
On Tue, Dec 07, 2021 at 05:10:14PM +0100, Philipp Rudo wrote: > Hi Michal, > > i finally had the time to take a closer look at the series. Except for > the nit in patch 4 and my personal preference in patch 6 the code looks > good to me. > > What I don't like are the commit messages on the first

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-12-01 Thread Michal Suchánek
Hello, On Wed, Dec 01, 2021 at 10:37:47AM +0800, Baoquan He wrote: > Hi, > > On 11/25/21 at 07:02pm, Michal Suchanek wrote: > > Hello, > > > > This is resend of the KEXEC_SIG patchset. > > > > The first patch is new because it'a a cleanup that does not require any > > change to the module verif

Re: [PATCH v3 0/4] powerpc: watchdog fixes

2021-11-25 Thread Michal Suchánek
Hello, On Thu, Nov 25, 2021 at 04:11:03PM +0100, Laurent Dufour wrote: > On 25/11/2021, 10:36:43, Michael Ellerman wrote: > > On Wed, 10 Nov 2021 12:50:52 +1000, Nicholas Piggin wrote: > >> These are some watchdog fixes and improvements, in particular a > >> deadlock between the wd_smp_lock and co

Re: [PATCH 0/3] KEXEC_SIG with appended signature

2021-11-24 Thread Michal Suchánek
On Wed, Nov 24, 2021 at 08:10:10AM -0500, Mimi Zohar wrote: > On Wed, 2021-11-24 at 12:09 +0100, Philipp Rudo wrote: > > Now Michal wants to adapt KEXEC_SIG for ppc too so distros can rely on all > > architectures using the same mechanism and thus reduce maintenance cost. > > On the way there he ev

Re: [PATCH 0/3] KEXEC_SIG with appended signature

2021-11-19 Thread Michal Suchánek
Hello, On Thu, Nov 18, 2021 at 05:34:01PM -0500, Nayna wrote: > > On 11/16/21 04:53, Michal Suchánek wrote: > > On Mon, Nov 15, 2021 at 06:53:53PM -0500, Nayna wrote: > > > On 11/12/21 03:30, Michal Suchánek wrote: > > > > Hello, > > > > > >

Re: [PATCH 0/3] KEXEC_SIG with appended signature

2021-11-16 Thread Michal Suchánek
On Mon, Nov 15, 2021 at 06:53:53PM -0500, Nayna wrote: > > On 11/12/21 03:30, Michal Suchánek wrote: > > Hello, > > > > On Thu, Nov 11, 2021 at 05:26:41PM -0500, Nayna wrote: > > > On 11/8/21 07:05, Michal Suchánek wrote: > > > > Hello, > >

Re: [PATCH 0/3] KEXEC_SIG with appended signature

2021-11-12 Thread Michal Suchánek
Hello, On Thu, Nov 11, 2021 at 05:26:41PM -0500, Nayna wrote: > > On 11/8/21 07:05, Michal Suchánek wrote: > > Hello, > > > > On Mon, Nov 08, 2021 at 09:18:56AM +1100, Daniel Axtens wrote: > > > Michal Suchánek writes: > > > > > > > O

  1   2   3   4   >