Re: [PATCH] ibmvnic: Use -EBUSY in __ibmvnic_reset()

2024-04-23 Thread Nick Child
be passed to adapter->reset_done_rc, which is only treated as a boolean. So, the point of the patch not doing any behavioral differences is still true. Personally, I don't have strong opinions on this. Reviewed-by: Nick Child

Re: [PATCH 2/3] powerpc/pseries/memhp: Remove unbalanced dlpar_release_drc() call

2023-11-15 Thread Nick Child
Hi Nathan, Patches 1 and 3 LGTM Regarding this patch, dlpar_memory_remove_by_count() calls dlpar_add_lmb() and does not free drc on add error. dlpar_add_lmb() is called here in error recovery so probably not a big deal. This is all new code to me but it looks like if the requested number of

Re: [net-next PATCH 3/4] netdev: replace napi_reschedule with napi_schedule

2023-10-02 Thread Nick Child
he purpose is actually deprecated in favour of different logic. Convert every user of napi_reschedule to napi_schedule. Signed-off-by: Christian Marangi --- For drivers/net/ethernet/ibm/ibmveth.c | 2 +- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- Acke

[RFC PATCH v1] powerpc: Add version to install filenames

2023-03-14 Thread Nick Child
from `arch/s390/boot/install.sh`. Signed-off-by: Nick Child --- Hoping I am not breaking someones dependency on targeting /boot/vmlinux so RFC'ing. I typically have kernelinstall on my LPARs and installing and rebooting goes peacefully. Recently, I did not have kernelinstall and `make install

Re: [PATCH 10/13] powerpc/rtas: improve function information lookups

2022-11-23 Thread Nick Child
;, + prior->name, curr->name); + } + } Just a thought, would it be simpler to use sort()? you already have the cmp_func implemented for bsearch(). As for the series as a whole: I am no RTAS expert but was able to build, boot and mess around with new tracepoints without errors: Tested-by: Nick Child

Re: [PATCH 10/13] powerpc/rtas: improve function information lookups

2022-11-23 Thread Nick Child
On 11/22/22 20:51, Andrew Donnellan wrote: On Fri, 2022-11-18 at 09:07 -0600, Nathan Lynch wrote: +enum rtas_function_flags { +   RTAS_FN_FLAG_BANNED_FOR_SYSCALL_ON_LE = (1 << 0), +}; This seems to be new, what's the justification? Seems to be a run-time replacement of: #ifdef

[PATCH] MAINTAINERS: Update ibmveth maintainer

2022-08-03 Thread Nick Child
Add Nick Child as the maintainer of the IBM Power Virtual Ethernet Device Driver, replacing Cristobal Forno. Signed-off-by: Nick Child --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2cfda104ba4e..4686e505b8e0 100644

[PATCH v2 20/20] cuda/pmu: Make find_via_cuda/pmu init functions

2021-12-16 Thread Nick Child
` do not use the `__init` macro. Since, only initialization functions call `find_via_cuda` and `find_via_pmu` it is safe to label these functions with `__init`. Signed-off-by: Nick Child --- arch/powerpc/platforms/powermac/setup.c | 4 ++-- include/linux/cuda.h| 2 +- include

[PATCH v2 19/20] powerpc/512x: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/platforms/512x/clock-commonclk.c | 52 +-- arch/powerpc/platforms/512x/mpc512x.h | 4 +- arch/powerpc/platforms/512x/mpc512x_shared.c | 4 +- 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/arch/powerpc/platforms/512x/clock

[PATCH v2 18/20] powerpc/85xx: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/platforms/85xx/ge_imp3a.c | 2 +- arch/powerpc/platforms/85xx/mpc85xx_cds.c | 2 +- arch/powerpc/platforms/85xx/socrates_fpga_pic.c | 2 +- arch/powerpc/platforms/85xx/socrates_fpga_pic.h | 2 +- arch/powerpc/platforms/85xx/xes_mpc85xx.c | 4

[PATCH v2 17/20] powerpc/83xx: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/platforms/83xx/km83xx.c | 2 +- arch/powerpc/platforms/83xx/mpc834x_mds.c | 2 +- arch/powerpc/platforms/83xx/mpc837x_mds.c | 2 +- arch/powerpc/platforms/83xx/mpc837x_rdb.c | 2 +- arch/powerpc/platforms/83xx/mpc83xx.h | 6 +++--- arch/powerpc/platforms/83xx

[PATCH v2 16/20] powerpc/embedded6xx: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-off-by: Nick Child --- arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 4 ++-- arch/powerpc/platforms/embedded6xx/hlwd-pic.h | 2 +- arch/powerpc/platforms/embedded6xx/holly.c | 2 +- arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c | 4 ++-- arch/powerpc/platforms/embedded6xx

[PATCH v2 15/20] powerpc/44x: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/platforms/44x/' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Signed-off-by: Nick Child --- arch/powerpc/platforms/44x/fsp2.c | 4 ++-- 1 file

[PATCH v2 14/20] powerpc/4xx: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/platforms/4xx' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Signed-off-by: Nick Child --- arch/powerpc/platforms/4xx/cpm.c | 4 ++-- arch

[PATCH v2 13/20] powerpc/ps3: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/platforms/ps3/gelic_udbg.c | 2 +- arch/powerpc/platforms/ps3/mm.c | 4 ++-- arch/powerpc/platforms/ps3/os-area.c| 4 ++-- arch/powerpc/platforms/ps3/platform.h | 14 +++--- arch/powerpc/platforms/ps3/repository.c | 20

[PATCH v2 12/20] powerpc/pseries: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/include/asm/book3s/64/mmu.h | 2 +- arch/powerpc/include/asm/iommu.h | 2 +- arch/powerpc/include/asm/setup.h | 2 +- arch/powerpc/platforms/pseries/event_sources.c | 2 +- arch/powerpc/platforms/pseries/iommu.c | 2

[PATCH v2 11/20] powerpc/powernv: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/include/asm/cpuidle.h | 2 +- arch/powerpc/include/asm/opal.h | 2 +- arch/powerpc/platforms/powernv/idle.c | 6 +++--- arch/powerpc/platforms/powernv/opal-core.c | 6 +++--- arch/powerpc/platforms/powernv

[PATCH v2 10/20] powerpc/powermac: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/platforms/powermac` are only called by other initialization functions and therefore should inherit the attribute. Also, change function declarations in header files to include `__init`. Signed-off-by: Nick Child --- arch/powerpc/include/asm/smu.h

[PATCH v2 09/20] powerpc/pasemi: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/platforms/pasemi/msi.c| 2 +- arch/powerpc/platforms/pasemi/pasemi.h | 2 +- arch/powerpc/platforms/pasemi/pci.c| 2 +- arch/powerpc/platforms/pasemi/setup.c | 2 +- arch/powerpc/sysdev/mpic.h | 2 +- 5 files changed, 5 insertions(+), 5

[PATCH v2 08/20] powerpc/chrp: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
The function `Enable_SRAM` defined in 'arch/powerpc/platforms/chrp' is deserving of an `__init` macro attribute. This function is only called by other initialization functions and therefore should inherit the attribute. Signed-off-by: Nick Child --- arch/powerpc/platforms/chrp/pegasos_eth.c | 2

[PATCH v2 07/20] powerpc/cell: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/platforms/cell' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Signed-off-by: Nick Child --- arch/powerpc/platforms/cell/cbe_regs.c| 2

[PATCH v2 06/20] powerpc/xmon: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/include/asm/xmon.h | 2 +- arch/powerpc/xmon/xmon.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/include/asm/xmon.h b/arch/powerpc/include/asm/xmon.h index 68bfb2361f03..f2d44b44f46c 100644 --- a/arch/powerpc/include/asm

[PATCH v2 05/20] powerpc/sysdev: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some files functions in 'arch/powerpc/sysdev' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Also, change function declarations in header files to include `__init`. Signed-off-by: Nick

[PATCH v2 04/20] powerpc/perf: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/perf' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Also, change function declarations in header files to include `__init`. Signed-off-by: Nick

[PATCH v2 02/20] powerpc/lib: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/lib' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Also, change function declarations in header files to include `__init`. Signed-off-by: Nick

[PATCH v2 01/20] powerpc/kernel: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
to include `__init`. Signed-off-by: Nick Child --- arch/powerpc/include/asm/btext.h | 10 +- arch/powerpc/include/asm/eeh.h | 2 +- arch/powerpc/include/asm/fadump-internal.h | 6 +++--- arch/powerpc/include/asm/kexec.h | 2 +- arch/powerpc/include/asm

[PATCH v2 03/20] powerpc/mm: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/mm' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Also, change function declarations in header files to include `__init`. Signed-off-by: Nick Child

[PATCH v2 00/20] powerpc: Define eligible functions as __init

2021-12-16 Thread Nick Child
`merge` v1: https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=277093= Nick Child (20): powerpc/kernel: Add __init attribute to eligible functions powerpc/lib: Add __init attribute to eligible functions powerpc/mm: Add __init attribute to eligible functions powerpc/perf: Add __init at

[PATCH 20/20] cuda/pmu: Make find_via_cuda/pmu init functions

2021-12-16 Thread Nick Child
/ pmu.h` do not use the `__init` macro. Since, only initialization functions call `find_via_cuda` and `find_via_pmu` it is safe to label these functions with `__init`. Signed-off-by: Nick Child --- arch/powerpc/platforms/powermac/setup.c | 4 ++-- include/linux/cuda.h| 2 +- include

[PATCH 19/20] powerpc/512x: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/platforms/512x/clock-commonclk.c | 52 +-- arch/powerpc/platforms/512x/mpc512x.h | 4 +- arch/powerpc/platforms/512x/mpc512x_shared.c | 4 +- 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/arch/powerpc/platforms/512x/clock

[PATCH 18/20] powerpc/85xx: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/platforms/85xx/ge_imp3a.c | 2 +- arch/powerpc/platforms/85xx/mpc85xx_cds.c | 2 +- arch/powerpc/platforms/85xx/socrates_fpga_pic.c | 2 +- arch/powerpc/platforms/85xx/socrates_fpga_pic.h | 2 +- arch/powerpc/platforms/85xx/xes_mpc85xx.c | 4

[PATCH 17/20] powerpc/83xx: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/platforms/83xx/km83xx.c | 2 +- arch/powerpc/platforms/83xx/mpc834x_mds.c | 2 +- arch/powerpc/platforms/83xx/mpc837x_mds.c | 2 +- arch/powerpc/platforms/83xx/mpc837x_rdb.c | 2 +- arch/powerpc/platforms/83xx/mpc83xx.h | 6 +++--- arch/powerpc/platforms/83xx

[PATCH 16/20] powerpc/embedded6xx: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-off-by: Nick Child --- arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 4 ++-- arch/powerpc/platforms/embedded6xx/hlwd-pic.h | 2 +- arch/powerpc/platforms/embedded6xx/holly.c | 2 +- arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c | 4 ++-- arch/powerpc/platforms/embedded6xx

[PATCH 15/20] powerpc/44x: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/platforms/44x/' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Signed-off-by: Nick Child --- arch/powerpc/platforms/44x/fsp2.c | 4 ++-- 1 file

[PATCH 14/20] powerpc/4xx: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/platforms/4xx' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Signed-off-by: Nick Child --- arch/powerpc/platforms/4xx/cpm.c | 4 ++-- arch

[PATCH 13/20] powerpc/ps3: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/platforms/ps3/gelic_udbg.c | 2 +- arch/powerpc/platforms/ps3/mm.c | 4 ++-- arch/powerpc/platforms/ps3/os-area.c| 4 ++-- arch/powerpc/platforms/ps3/platform.h | 14 +++--- arch/powerpc/platforms/ps3/repository.c | 20

[PATCH 12/20] powerpc/pseries: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/include/asm/book3s/64/mmu.h | 2 +- arch/powerpc/include/asm/iommu.h | 2 +- arch/powerpc/include/asm/setup.h | 2 +- arch/powerpc/platforms/pseries/event_sources.c | 2 +- arch/powerpc/platforms/pseries/iommu.c | 2

[PATCH 11/20] powerpc/powernv: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/include/asm/cpuidle.h | 2 +- arch/powerpc/include/asm/opal.h | 2 +- arch/powerpc/platforms/powernv/idle.c | 6 +++--- arch/powerpc/platforms/powernv/opal-core.c | 6 +++--- arch/powerpc/platforms/powernv

[PATCH 10/20] powerpc/powermac: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/platforms/powermac` are only called by other initialization functions and therefore should inherit the attribute. Also, change function declarations in header files to include `__init`. Signed-off-by: Nick Child --- arch/powerpc/include/asm/smu.h

[PATCH 09/20] powerpc/pasemi: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/platforms/pasemi/msi.c| 2 +- arch/powerpc/platforms/pasemi/pasemi.h | 2 +- arch/powerpc/platforms/pasemi/pci.c| 2 +- arch/powerpc/platforms/pasemi/setup.c | 2 +- arch/powerpc/sysdev/mpic.h | 2 +- 5 files changed, 5 insertions(+), 5

[PATCH 08/20] powerpc/chrp: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
The function `Enable_SRAM` defined in 'arch/powerpc/platforms/chrp' is deserving of an `__init` macro attribute. This function is only called by other initialization functions and therefore should inherit the attribute. Signed-off-by: Nick Child --- arch/powerpc/platforms/chrp/pegasos_eth.c | 2

[PATCH 07/20] powerpc/cell: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/platforms/cell' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Signed-off-by: Nick Child --- arch/powerpc/platforms/cell/cbe_regs.c| 2

[PATCH 06/20] powerpc/xmon: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
-by: Nick Child --- arch/powerpc/include/asm/xmon.h | 2 +- arch/powerpc/xmon/xmon.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/include/asm/xmon.h b/arch/powerpc/include/asm/xmon.h index 68bfb2361f03..3e5970a4f215 100644 --- a/arch/powerpc/include/asm

[PATCH 05/20] powerpc/sysdev: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some files functions in 'arch/powerpc/sysdev' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Also, change function declarations in header files to include `__init`. Signed-off-by: Nick

[PATCH 04/20] powerpc/perf: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/perf' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Also, change function declarations in header files to include `__init`. Signed-off-by: Nick

[PATCH 03/20] powerpc/mm: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/mm' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Also, change function declarations in header files to include `__init`. Signed-off-by: Nick Child

[PATCH 02/20] powerpc/lib: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
Some functions defined in 'arch/powerpc/lib' are deserving of an `__init` macro attribute. These functions are only called by other initialization functions and therefore should inherit the attribute. Also, change function declarations in header files to include `__init`. Signed-off-by: Nick

[PATCH 00/20] powerpc: Define eligible functions as __init

2021-12-16 Thread Nick Child
good starting point. Please let me know if there is anything I am doing wrong or if I can do anything to help meet the kernel contribution guidelines. Special thanks to Daniel Axtens for mentoring me and helping me get my first patchset out! Nick Child (20): powerpc/kernel: Add __init at

[PATCH 01/20] powerpc/kernel: Add __init attribute to eligible functions

2021-12-16 Thread Nick Child
to include `__init`. Signed-off-by: Nick Child --- arch/powerpc/include/asm/btext.h | 10 +- arch/powerpc/include/asm/eeh.h | 2 +- arch/powerpc/include/asm/fadump-internal.h | 6 +++--- arch/powerpc/include/asm/kexec.h | 2 +- arch/powerpc/include/asm